Re: r313957 - Closure types have no name (and can't have a typedef name for linkage

2017-10-02 Thread Peter Collingbourne via cfe-commits
On Mon, Oct 2, 2017 at 7:02 PM, Richard Smith wrote: > On 2 October 2017 at 17:10, Peter Collingbourne via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Looks like this caused PR34811, which caused a link error on a Chromium >> bot: >>

Re: r313957 - Closure types have no name (and can't have a typedef name for linkage

2017-10-02 Thread Richard Smith via cfe-commits
On 2 October 2017 at 17:10, Peter Collingbourne via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Looks like this caused PR34811, which caused a link error on a Chromium > bot: > https://build.chromium.org/p/chromium.fyi/builders/CFI% > 20Linux%20ToT/builds/7081 > > The link error might be

Re: r313957 - Closure types have no name (and can't have a typedef name for linkage

2017-10-02 Thread Peter Collingbourne via cfe-commits
Looks like this caused PR34811, which caused a link error on a Chromium bot: https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/7081 The link error might be caused by an unrelated LTO bug, but this bug does seem real. Please take a look. Peter On Thu, Sep 21, 2017 at

r313957 - Closure types have no name (and can't have a typedef name for linkage

2017-09-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Sep 21 21:33:20 2017 New Revision: 313957 URL: http://llvm.org/viewvc/llvm-project?rev=313957=rev Log: Closure types have no name (and can't have a typedef name for linkage purposes), so they never formally have linkage. Modified: cfe/trunk/lib/AST/Decl.cpp