Author: epilk Date: Tue Jan 8 10:24:39 2019 New Revision: 350642 URL: http://llvm.org/viewvc/llvm-project?rev=350642&view=rev Log: __has_feature(pragma_clang_attribute_namespaces) should be __has_extension
Thanks to Richard Smith for pointing this out. Modified: cfe/trunk/docs/LanguageExtensions.rst cfe/trunk/include/clang/Basic/Features.def cfe/trunk/test/Sema/pragma-attribute-namespace.c Modified: cfe/trunk/docs/LanguageExtensions.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/LanguageExtensions.rst?rev=350642&r1=350641&r2=350642&view=diff ============================================================================== --- cfe/trunk/docs/LanguageExtensions.rst (original) +++ cfe/trunk/docs/LanguageExtensions.rst Tue Jan 8 10:24:39 2019 @@ -2727,7 +2727,7 @@ Without the namespaces on the macros, `` a contrived example, but its very possible for this kind of situation to appear in real code if the pragmas are spread out across a large file. You can test if your version of clang supports namespaces on ``#pragma clang attribute`` with -``__has_feature(pragma_clang_attribute_namespaces)``. +``__has_extension(pragma_clang_attribute_namespaces)``. Subject Match Rules ------------------- Modified: cfe/trunk/include/clang/Basic/Features.def URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Features.def?rev=350642&r1=350641&r2=350642&view=diff ============================================================================== --- cfe/trunk/include/clang/Basic/Features.def (original) +++ cfe/trunk/include/clang/Basic/Features.def Tue Jan 8 10:24:39 2019 @@ -17,6 +17,12 @@ // // The Predicate field dictates the conditions under which the feature or // extension will be made available. +// +// FEATURE(...) should be used to advertise support for standard language +// features, whereas EXTENSION(...) should be used for clang extensions. Note +// that many of the identifiers in this file don't follow this rule for backward +// compatibility reasons. +// //===----------------------------------------------------------------------===// #if !defined(FEATURE) && !defined(EXTENSION) @@ -69,7 +75,6 @@ FEATURE(attribute_overloadable, true) FEATURE(attribute_unavailable_with_message, true) FEATURE(attribute_unused_on_fields, true) FEATURE(attribute_diagnose_if_objc, true) -FEATURE(pragma_clang_attribute_namespaces, true) FEATURE(blocks, LangOpts.Blocks) FEATURE(c_thread_safety_attributes, true) FEATURE(cxx_exceptions, LangOpts.CXXExceptions) @@ -241,6 +246,7 @@ EXTENSION(cxx_init_captures, LangOpts.CP EXTENSION(cxx_variable_templates, LangOpts.CPlusPlus) // Miscellaneous language extensions EXTENSION(overloadable_unmarked, true) +EXTENSION(pragma_clang_attribute_namespaces, true) #undef EXTENSION #undef FEATURE Modified: cfe/trunk/test/Sema/pragma-attribute-namespace.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/pragma-attribute-namespace.c?rev=350642&r1=350641&r2=350642&view=diff ============================================================================== --- cfe/trunk/test/Sema/pragma-attribute-namespace.c (original) +++ cfe/trunk/test/Sema/pragma-attribute-namespace.c Tue Jan 8 10:24:39 2019 @@ -1,6 +1,6 @@ // RUN: %clang_cc1 -fsyntax-only -verify %s -#if !__has_feature(pragma_clang_attribute_namespaces) +#if !__has_extension(pragma_clang_attribute_namespaces) #error #endif _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits