Re: r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

2019-02-15 Thread Hans Wennborg via cfe-commits
Merged in r354129. Please let me know if there are any follow-ups. Thanks, Hans On Fri, Feb 15, 2019 at 12:16 AM Erik Pilkington wrote: > > Hans, can you merge this diagnostic regression fix into LLVM 8? > > Thanks! > > > On Feb 14, 2019, at 2:48 PM, Erik Pilkington via cfe-commits > > wrote:

Re: r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

2019-02-14 Thread Shoaib Meenai via cfe-commits
I don't think Hans ended up getting added to the recipients? (Unless Outlook is being silly or it was a BCC, in which case I apologize for the spam.) On 2/14/19, 3:16 PM, "cfe-commits on behalf of Erik Pilkington via cfe-commits" wrote: Hans, can you merge this diagnostic regression fix i

Re: r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

2019-02-14 Thread Erik Pilkington via cfe-commits
Hans, can you merge this diagnostic regression fix into LLVM 8? Thanks! > On Feb 14, 2019, at 2:48 PM, Erik Pilkington via cfe-commits > wrote: > > Author: epilk > Date: Thu Feb 14 14:48:01 2019 > New Revision: 354074 > > URL: http://llvm.org/viewvc/llvm-project?rev=354074&view=rev > Log: > [

r354074 - [Sema] Fix-up a -Wfloat-conversion diagnostic

2019-02-14 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Thu Feb 14 14:48:01 2019 New Revision: 354074 URL: http://llvm.org/viewvc/llvm-project?rev=354074&view=rev Log: [Sema] Fix-up a -Wfloat-conversion diagnostic We were warning on valid ObjC property reference exprs, and passing in the wrong arguments to DiagnoseFloatingImpCast (