Re: r364102 - Fix __has_cpp_attribute expansion to produce trailing L and (where

2019-06-21 Thread Reid Kleckner via cfe-commits
I added -P to remove the line markers which were introducing the colons. On Fri, Jun 21, 2019 at 2:58 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit added broken test to the builder: > >

Re: r364102 - Fix __has_cpp_attribute expansion to produce trailing L and (where

2019-06-21 Thread Galina Kistanova via cfe-commits
Hello Richard, This commit added broken test to the builder: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26522 . . . Failing Tests (2): Clang :: Preprocessor/has_attribute.cpp . . . Please have a look? The builder was already red and did not

r364102 - Fix __has_cpp_attribute expansion to produce trailing L and (where

2019-06-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jun 21 13:20:21 2019 New Revision: 364102 URL: http://llvm.org/viewvc/llvm-project?rev=364102=rev Log: Fix __has_cpp_attribute expansion to produce trailing L and (where necessary) leading whitespace. Simplify unit test and extend to cover no_unique_address attribute.