Re: r364428 - Make CodeGen depend on ASTMatchers

2020-09-11 Thread Vassil Vassilev via cfe-commits
Thanks a lot! On 9/11/20 6:20 PM, Michael LIAO wrote: b22d4504968 was committed last night. On Fri, Sep 11, 2020 at 9:30 AM Vassil Vassilev wrote: On 9/11/20 5:13 AM, Michael LIAO wrote: That change was added long ago to fix the shared library build. Possibly, there are changes removing that

Re: r364428 - Make CodeGen depend on ASTMatchers

2020-09-11 Thread Michael LIAO via cfe-commits
b22d4504968 was committed last night. On Fri, Sep 11, 2020 at 9:30 AM Vassil Vassilev wrote: > > On 9/11/20 5:13 AM, Michael LIAO wrote: > > That change was added long ago to fix the shared library build. > > Possibly, there are changes removing that dependency then. Just > > verified that

Re: r364428 - Make CodeGen depend on ASTMatchers

2020-09-11 Thread Vassil Vassilev via cfe-commits
On 9/11/20 5:13 AM, Michael LIAO wrote: That change was added long ago to fix the shared library build. Possibly, there are changes removing that dependency then. Just verified that removing that dependency is just fine.   That's great! Would you commit that change or should I? On Thu,

Re: r364428 - Make CodeGen depend on ASTMatchers

2020-09-10 Thread Michael LIAO via cfe-commits
That change was added long ago to fix the shared library build. Possibly, there are changes removing that dependency then. Just verified that removing that dependency is just fine. On Thu, Sep 10, 2020 at 6:48 AM Vassil Vassilev wrote: > > Hello, > >IIUC, clang's CodeGen does not immediately

Re: r364428 - Make CodeGen depend on ASTMatchers

2020-09-10 Thread Vassil Vassilev via cfe-commits
Hello,   IIUC, clang's CodeGen does not immediately depend on ASTMatchers. I was wondering what is the reason for inserting such a dependency to fix the shared library builds?   Can you give more details about the failure you are fixing?   Sorry for the late question. Best, Vassil On

r364428 - Make CodeGen depend on ASTMatchers

2019-06-26 Thread Michael Liao via cfe-commits
Author: hliao Date: Wed Jun 26 07:13:43 2019 New Revision: 364428 URL: http://llvm.org/viewvc/llvm-project?rev=364428=rev Log: Make CodeGen depend on ASTMatchers - Shared library builds are broken due to the missing dependency. Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt Modified: