I've gone ahead and reverted in 4c539e8.
On Tue, Oct 22, 2019 at 10:43 AM Hans Wennborg wrote:
>
> Since it looks suspicious, can we revert your change in the meantime?
> We have a number of instances where this fires, so it's not just one
> place we'd need to work around it.
>
> On Mon, Oct 21,
LOG: Revert r374202"[ObjC generics] Fix not inheriting type bounds in
categories/extensions."
This introduced new errors, see below. Reverting until that can be investigated
properly.
#import
void f(int width, int height) {
FourCharCode best_fourcc = kCMPixelFormat_422Yp
Since it looks suspicious, can we revert your change in the meantime?
We have a number of instances where this fires, so it's not just one
place we'd need to work around it.
On Mon, Oct 21, 2019 at 6:39 PM Volodymyr Sapsai wrote:
>
> That error looks strange and confusing to me too. My guess is
That error looks strange and confusing to me too. My guess is that my change
exposed some bug with literals. I’ve tried
NSDictionary* videoSettingsDictionary2 = [NSDictionary
dictionaryWithObject:@(best_fourcc)
forKey:(id)kCVPixelBufferPixelFormatTypeKey];
and
@interface GenericTest
Hi Volodymyr,
This broke the Chrome build in an interesting way. Here's a reduced repro:
$ cat /tmp/a.mm
#import
void f(int width, int height) {
FourCharCode best_fourcc = kCMPixelFormat_422YpCbCr8_yuvs;
NSDictionary* videoSettingsDictionary = @{
(id)kCVPixelBufferPixelFormatTypeKey :
Author: vsapsai
Date: Wed Oct 9 12:29:13 2019
New Revision: 374202
URL: http://llvm.org/viewvc/llvm-project?rev=374202=rev
Log:
[ObjC generics] Fix not inheriting type bounds in categories/extensions.
When a category/extension doesn't repeat a type bound, corresponding
type parameter is
