Re: r331745 - [C++2a] Implement operator<=>: Fix another bug in the code gen tests.

2019-02-11 Thread Nico Weber via cfe-commits
On Tue, May 8, 2018 at 3:59 AM Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Tue May 8 00:56:05 2018 > New Revision: 331745 > > URL: http://llvm.org/viewvc/llvm-project?rev=331745=rev > Log: > [C++2a] Implement operator<=>: Fix another bug in the

[PATCH] D57230: [analyzer] Toning down invalidation a bit

2019-02-11 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. I think I might have a theory, but I would like to discuss it as I am not familiar with the internals bindings. My theory is the following: when we store the bindings, we store them in a map where the key is a base region. So when we try to look the bindings up

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

2019-02-11 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:987-989 +The first argument to the attribute is the type passed to +`__builtin_object_size`, and the second is the flag that the fortified

[PATCH] D58056: Look through typedefs in getFunctionTypeWithExceptionSpec

2019-02-11 Thread Stephan Bergmann via Phabricator via cfe-commits
sberg created this revision. sberg added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://bugs.llvm.org/show_bug.cgi?id=40658 Repository: rC Clang https://reviews.llvm.org/D58056 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D58062: Support framework import/include auto-completion

2019-02-11 Thread David Goldman via Phabricator via cfe-commits
dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Frameworks filesystem representations: UIKit.framework/Headers/%header% Framework import format: #import Thus the completion code must map the

[PATCH] D57991: [Driver][Darwin] Emit an error when using -pg on OS without support for it.

2019-02-11 Thread Steven Wu via Phabricator via cfe-commits
steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM with a suggestion to make code cleaner. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:101 + "the clang compiler does not support -pg option on

RE: r353718 - Make test actually test something (colons were missing)

2019-02-11 Thread via cfe-commits
I thin the Best Fix is probably to make FileCheck diag if a line starts with (after a few whitelisted comment chars like // and #) a check-prefix but then isn't followed by : (maybe after -NOT, -SAME, -LABEL etc). FileCheck doesn't explicitly pass over leading comment characters, it just

[PATCH] D58067: [Analyzer] Crash fix for FindLastStoreBRVisitor

2019-02-11 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added a comment. I tried very hard to create a test case where we are crashing on a true positive but I did not succeed. I am not sure whether it is possible so fixing the false positive in `CallAndMessageUnInitRefArg` also

r353729 - Attempt to pacify bots more after r353718 and r353725

2019-02-11 Thread Nico Weber via cfe-commits
Author: nico Date: Mon Feb 11 10:01:27 2019 New Revision: 353729 URL: http://llvm.org/viewvc/llvm-project?rev=353729=rev Log: Attempt to pacify bots more after r353718 and r353725 Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c URL:

[PATCH] D58061: Fix a few tests that were missing ':' on CHECK lines and weren't testing anything.

2019-02-11 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Good catch! Is there a reasonable way to just make FileCheck itself enforce this, or does that cause too many false positives with tests that are using e.g. `x86_64` as the entire

r353740 - [COFF, ARM64] Remove definitions for _byteswap library functions

2019-02-11 Thread Tom Tan via cfe-commits
Author: tomtan Date: Mon Feb 11 12:04:02 2019 New Revision: 353740 URL: http://llvm.org/viewvc/llvm-project?rev=353740=rev Log: [COFF, ARM64] Remove definitions for _byteswap library functions _byteswap_* functions are are implemented in below file as normal function from libucrt.lib and

[PATCH] D57915: [COFF, ARM64] Remove definitions for _byteswap library functions

2019-02-11 Thread Tom Tan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL353740: [COFF, ARM64] Remove definitions for _byteswap library functions (authored by TomTan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D58060: Fix diagnostic for addr spaces in static_cast

2019-02-11 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: ebevhan. When we diagnose `static_cast` we should prevent accidental address space conversions unless the conversion is safe (i.e. converting to an address space that is a super set is safe!).

[PATCH] D58061: Fix a few tests that were missing ':' on CHECK lines and weren't testing anything.

2019-02-11 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: rjmccall. Herald added subscribers: kristof.beyls, javed.absar. Found by `git grep '\/\/ CHECK-[^: ]* ' clang/test/ | grep -v RUN:`. Also tweak CodeGenCXX/arm-swiftcall.cpp to still pass now that it checks more.

[PATCH] D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682)

2019-02-11 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Ah, thanks, seems like a reasonable fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58016/new/ https://reviews.llvm.org/D58016

[PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

2019-02-11 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D17444#1392823 , @thakis wrote: > Instead of this patch we could have an assert.h wrapper in lib/Headers that > defines static_assert to _Static_assert in ms mode for C files, and I suppose > that's a cleaner fix. But I hope it's

[PATCH] D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682)

2019-02-11 Thread Joran Bigalet via Phabricator via cfe-commits
jbigalet added a comment. Thanks! I don't have commit rights btw Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58016/new/ https://reviews.llvm.org/D58016 ___ cfe-commits mailing list

[PATCH] D38606: [CodeGen] Emit a helper function for __builtin_os_log_format to reduce code size

2019-02-11 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Herald added subscribers: llvm-commits, jkorous. Herald added a project: LLVM. Comment at: cfe/trunk/test/CodeGenObjC/os_log.m:53 + // CHECK-O0: %[[V5:.*]] = bitcast %[[V0]]* %[[V3]] to i8* + // CHECK-O0-NOT call void (...) @clang.arc.use({{.*}} +

[PATCH] D58057: Allow bundle size to be 0 in clang-offload-bundler

2019-02-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: rjmccall. HIP uses clang-offload-bundler to create fat binary. The bundle for host is empty. Currently clang-offload-bundler checks if the bundle size is 0 when unbundling. If so it will exit without unbundling the remaining bundles. This

Re: r353718 - Make test actually test something (colons were missing)

2019-02-11 Thread Roman Lebedev via cfe-commits
On Mon, Feb 11, 2019 at 7:38 PM Aaron Ballman via cfe-commits wrote: > > On Mon, Feb 11, 2019 at 11:36 AM Nico Weber via cfe-commits > wrote: > > > > Author: nico > > Date: Mon Feb 11 08:37:02 2019 > > New Revision: 353718 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=353718=rev > > Log:

[PATCH] D58056: Look through typedefs in getFunctionTypeWithExceptionSpec

2019-02-11 Thread Stephan Bergmann via Phabricator via cfe-commits
sberg added a comment. The change itself should probably be uncontroversial (the bad cast had been there ever since getFunctionTypeWithExceptionSpec had been introduced with r221918), but I'm not sure about the test: It tests the relevant code somewhat indirectly; is it fine in

[PATCH] D45978: dllexport const variables must have external linkage.

2019-02-11 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. In D45978#1392855 , @aaron.ballman wrote: > It looks like the patch got mucked up somehow, I only see three testing files > in the patch now? Oops! Sorry about that. CHANGES SINCE LAST ACTION

[PATCH] D45978: dllexport const variables must have external linkage.

2019-02-11 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 186275. Herald added a subscriber: mstorsjo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 Files: lib/Sema/SemaDecl.cpp test/Sema/dllexport-1.c test/Sema/dllexport-1.cpp test/Sema/dllexport-2.cpp

Re: r353718 - Make test actually test something (colons were missing)

2019-02-11 Thread Nico Weber via cfe-commits
On Mon, Feb 11, 2019 at 11:38 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Feb 11, 2019 at 11:36 AM Nico Weber via cfe-commits > wrote: > > > > Author: nico > > Date: Mon Feb 11 08:37:02 2019 > > New Revision: 353718 > > > > URL:

r353725 - Attempt to pacify bots after r353718

2019-02-11 Thread Nico Weber via cfe-commits
Author: nico Date: Mon Feb 11 09:30:25 2019 New Revision: 353725 URL: http://llvm.org/viewvc/llvm-project?rev=353725=rev Log: Attempt to pacify bots after r353718 Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c URL:

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

2019-02-11 Thread Scott Linder via Phabricator via cfe-commits
scott.linder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56871/new/ https://reviews.llvm.org/D56871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58062: Support framework import/include auto-completion

2019-02-11 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:8375 + auto AddFilesFromIncludeDir = [&](StringRef IncludeDir, bool IsSystem, +bool isFramework) { +bool stripFrameworkSuffix = false; nit:

[PATCH] D58065: [analyzer] Document the frontend library

2019-02-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, dkrupp, rnkovacs, a.sidorin, aaron.ballman. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. Since

[PATCH] D45978: dllexport const variables must have external linkage.

2019-02-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: test/Sema/dllexport-1.c:1-4 +// RUN: %clang_cc1 -triple i686-win32 -emit-llvm -fms-extensions -std=c99 < %s| FileCheck %s +// RUN: %clang_cc1 -triple x86_64-win32 -emit-llvm -fms-extensions -std=c11 < %s | FileCheck %s +// RUN:

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

2019-02-11 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington updated this revision to Diff 186300. erik.pilkington added a comment. Link to the GCC docs for `__builitn_object_size`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57918/new/ https://reviews.llvm.org/D57918 Files: clang/include/clang/Basic/Attr.td

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

2019-02-11 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added inline comments. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:29 +// Bulk memory builtins +TARGET_BUILTIN(__builtin_wasm_memory_init, "vIiv*ii", "", "bulk-memory")

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

2019-02-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56871/new/ https://reviews.llvm.org/D56871 ___ cfe-commits mailing list

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

2019-02-11 Thread Vedant Kumar via Phabricator via cfe-commits
vsk marked an inline comment as done. vsk added a comment. > I'd prefer not adding this kind of state to PassBuilder. SplitColdCode is > soemthing that refers to the construction of one particular pipeline, not to > pipeline-building in general. It should be an argument passed down through >

[PATCH] D58067: [Analyzer] Crash fix for FindLastStoreBRVisitor

2019-02-11 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, dcoughlin. baloghadamsoftware added a project: clang. Herald added subscribers: gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, szepet. This patch is a fix for bug 40625

[PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

2019-02-11 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. In D17444#1393339 , @rnk wrote: > In D17444#1392823 , @thakis wrote: > > > Instead of this patch we could have an assert.h wrapper in lib/Headers that > > defines static_assert to

[PATCH] D54978: Move the SMT API to LLVM

2019-02-11 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added subscribers: delcypher, ddcc. ddcc added a comment. The likely reason for this versioning problem is that the current versioning implementation in FindZ3.cmake is best-effort only: among other conditions, if the z3 binary is available, it will execute it and parse out the version

[PATCH] D58069: [Sema] Mark GNU compound literal array init as an rvalue.

2019-02-11 Thread Eli Friedman via Phabricator via cfe-commits
efriedma created this revision. efriedma added a reviewer: rsmith. Herald added a project: clang. Basically the same issue as string init, except it didn't really have any visible consequences before I removed the implicit lvalue-to-rvalue conversion from CodeGen. While I'm here, a couple

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

2019-02-11 Thread Hylke Kleve via Phabricator via cfe-commits
hyklv added a comment. In D57655#1382855 , @MyDeveloperDay wrote: > The reviewers set a high barrier of entry, you need to at least start by > adding some unit tests (or someone will break your code in the future), if > you think it was a bug it might

[PATCH] D54978: Move the SMT API to LLVM

2019-02-11 Thread Brian Rzycki via Phabricator via cfe-commits
brzycki added a comment. In D54978#1392464 , @Szelethus wrote: > Shouldn't that be off by default? The default for `LLVM_ENABLE_Z3_SOLVER` depends entirely on what CMake detects from `find_package()`. Here is the relevant code in `llvm/CMakeLists.txt`:

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

2019-02-11 Thread Hylke Kleve via Phabricator via cfe-commits
hyklv added a comment. In D57655#1382437 , @lebedev.ri wrote: > Test? > Is this a fix, or a new formatting style? a fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57655/new/ https://reviews.llvm.org/D57655

[PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

2019-02-11 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D17444#1393509 , @thakis wrote: > Given that we already have interposition headers and users already have to > hold the compiler right, does it matter if we have one more interposing > header? I'd say it's one more bit of

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

2019-02-11 Thread Hylke Kleve via Phabricator via cfe-commits
hyklv updated this revision to Diff 186315. hyklv marked an inline comment as done. hyklv added a comment. I removed accidental changes in the copyright notice, updated the code to insert one space instead of one tab. Added a test case for the alignment. Repository: rC Clang CHANGES SINCE

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

2019-02-11 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. Not really. Would making only the `attachTo*` methods virtual enough though? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58072/new/ https://reviews.llvm.org/D58072 ___ cfe-commits mailing

[PATCH] D57855: [analyzer] Reimplement checker options

2019-02-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus updated this revision to Diff 186350. Szelethus added a comment. - Removed the accidentally added `nullability:Optimistic` entry, - Reworded `unix.DynamicMemoryModeling:Optimistic`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57855/new/ https://reviews.llvm.org/D57855

[PATCH] D57896: Variable names rule

2019-02-11 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht added a comment. In D57896#1391925 , @hubert.reinterpretcast wrote: > In D57896#1391611 , @zturner wrote: > > > Is this actually any better? Whereas before we can’t differentiate type > > names and

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

2019-02-11 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. In D58072#1393640 , @bruno wrote: > How much of the `ModuleDependencyCollector` will be reused as is by LLDB? I > wonder about the tradeoff versus inheriting from `DependencyCollector` > directly. We reuse the `attachTo`

[PATCH] D58067: [Analyzer] Crash fix for FindLastStoreBRVisitor

2019-02-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, right, indeed, thanks, nice! We should eventually remove `operator==()` from the `SVal` class because it doesn't do anything you'd possibly imagine it to do. However we do need to come up

[PATCH] D57890: [analyzer] Fix in self assignment checker

2019-02-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Sounds reasonable, but it also sounds like something that should be reproducible on the upstream clang. Do you have a code snippet that causes the problematic AST to appear? Even if we don't have the false positive up here in upstream, Is it something we can test via

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

2019-02-11 Thread Lingda Li via Phabricator via cfe-commits
lildmh updated this revision to Diff 186338. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58074/new/ https://reviews.llvm.org/D58074 Files: include/clang/AST/OpenMPClause.h include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

2019-02-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus updated this revision to Diff 186346. Szelethus added a comment. - Added a convenience method to `CheckerManager` for reporting invalid user input - Edited the error message to be more flexible CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57850/new/

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

2019-02-11 Thread Russell McClellan via Phabricator via cfe-commits
russellmcc added a comment. Bump! Still watching this space - thanks so much for your time! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

2019-02-11 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. If people have opinions on this final version, please let me know. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 ___ cfe-commits mailing list

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

2019-02-11 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. Herald added a subscriber: jkorous. I would like to merge this even though http://wg21.link/p1264 has not been voted into C++ yet, because this is arguably a bug and libc++ differs from other stdlibs in this regard. Once http://wg21.link/p1264 is merged into C++ in one

[PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

2019-02-11 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 186337. rsmith marked an inline comment as done. rsmith added a comment. Address a couple of review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57984/new/ https://reviews.llvm.org/D57984 Files:

[clang-tools-extra] r353760 - [NFC][clangd] Remove unused lambda capture

2019-02-11 Thread Francis Visoiu Mistrih via cfe-commits
Author: thegameg Date: Mon Feb 11 14:36:47 2019 New Revision: 353760 URL: http://llvm.org/viewvc/llvm-project?rev=353760=rev Log: [NFC][clangd] Remove unused lambda capture Avoid this warning: llvm/clang-tools-extra/clangd/ClangdServer.cpp:365:23: warning: lambda capture 'this' is not used

r353761 - [WebAssembly] Make thread-related options consistent

2019-02-11 Thread Heejin Ahn via cfe-commits
Author: aheejin Date: Mon Feb 11 14:47:50 2019 New Revision: 353761 URL: http://llvm.org/viewvc/llvm-project?rev=353761=rev Log: [WebAssembly] Make thread-related options consistent Summary: There have been three options related to threads and users had to set all three of them separately to get

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

2019-02-11 Thread Russell McClellan via Phabricator via cfe-commits
russellmcc added a comment. Bump! Thanks for the consideration! Again, this is preventing us from rolling out automated style checking on diffs at work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54881/new/ https://reviews.llvm.org/D54881

Re: r353729 - Attempt to pacify bots more after r353718 and r353725

2019-02-11 Thread Nico Weber via cfe-commits
This still didn't help. I can't repro the failures onhttp:// lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast , I tried Rel+Asserts and Rel-Asserts builds. Can anyone else repro this? On Mon, Feb 11, 2019 at 1:01 PM Nico Weber via cfe-commits <

[PATCH] D58010: [CodeGen] Set construction vtable visibility after creating initializer

2019-02-11 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL353742: [CodeGen] Set construction vtable visibility after creating initializer (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D57915: [COFF, ARM64] Remove definitions for _byteswap library functions

2019-02-11 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. In D57915#1389722 , @TomTan wrote: > In D57915#1389560 , @lebedev.ri > wrote: > > > In D57915#1389549 , @TomTan wrote: > > > > > Added the tests

r353742 - [CodeGen] Set construction vtable visibility after creating initializer

2019-02-11 Thread Petr Hosek via cfe-commits
Author: phosek Date: Mon Feb 11 12:13:42 2019 New Revision: 353742 URL: http://llvm.org/viewvc/llvm-project?rev=353742=rev Log: [CodeGen] Set construction vtable visibility after creating initializer We must only set the construction vtable visibility after we create the vtable initializer,

r353744 - Fix a few tests that were missing ':' on CHECK lines and weren't testing anything.

2019-02-11 Thread Nico Weber via cfe-commits
Author: nico Date: Mon Feb 11 12:33:22 2019 New Revision: 353744 URL: http://llvm.org/viewvc/llvm-project?rev=353744=rev Log: Fix a few tests that were missing ':' on CHECK lines and weren't testing anything. Found by `git grep '\/\/ CHECK-[^: ]* ' clang/test/ | grep -v RUN:`. Also tweak

Re: r353729 - Attempt to pacify bots more after r353718 and r353725

2019-02-11 Thread Galina Kistanova via cfe-commits
Hello Nico, This builders fail on your test as well - http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/15736 , http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/4242. Please find attached the 2 temp files you can use to reliably run against your

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

2019-02-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some very minor nits. Comment at: clang/include/clang/Basic/AttrDocs.td:987-989 +The first argument to the attribute is the type passed to +`__builtin_object_size`, and the second is the flag

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

2019-02-11 Thread Fedor Sergeev via Phabricator via cfe-commits
fedor.sergeev added a comment. In D57265#1393453 , @vsk wrote: > > I'd prefer not adding this kind of state to PassBuilder. SplitColdCode is > > soemthing that refers to the construction of one particular pipeline, not > > to pipeline-building in

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

2019-02-11 Thread Heejin Ahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL353761: [WebAssembly] Make thread-related options consistent (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[PATCH] D58069: [Sema] Mark GNU compound literal array init as an rvalue.

2019-02-11 Thread Eli Friedman via Phabricator via cfe-commits
efriedma marked 2 inline comments as done. efriedma added inline comments. Comment at: lib/Sema/SemaInit.cpp:172-173 + E = PE->getSubExpr(); +else if (UnaryOperator *UO = dyn_cast(E)) + E = UO->getSubExpr(); +else if (GenericSelectionExpr *GSE = dyn_cast(E))

[PATCH] D58069: [Sema] Mark GNU compound literal array init as an rvalue.

2019-02-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. > The analyzer test change maybe indicates we could simplify the analyzer code > a little with this fix? Apparently a hack was added to support lvalues in > initializers in r315750, but I'm not really familiar with the relevant code. Nope, unfortunately, not much can be

[PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

2019-02-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. > Also, I suppose this is really actually an -fms-compatibility thing not > -fms-extensions because it takes an identifier from outside the implementer's > namespace. I just verified, it really does take the identifier and it does not treat `static_assert` as a

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

2019-02-11 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere created this revision. JDevlieghere added reviewers: bruno, vsapsai. Herald added a project: clang. For reproducers in LLDB we want to hook up into the existing clang infrastructure. To make that happen we need to be able to override the ModuleDependencyCollector's methods.

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

2019-02-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:304-305 def err_analyzer_config_unknown : Error<"unknown analyzer-config '%0'">; +def err_analyzer_checker_option_invalid_input : Error< +

[PATCH] D58069: [Sema] Mark GNU compound literal array init as an rvalue.

2019-02-11 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. efriedma marked an inline comment as done. Closed by commit rC353762: [Sema] Mark GNU compound literal array init as an rvalue. (authored by efriedma, committed by ). Changed prior to commit:

r353762 - [Sema] Mark GNU compound literal array init as an rvalue.

2019-02-11 Thread Eli Friedman via cfe-commits
Author: efriedma Date: Mon Feb 11 14:54:27 2019 New Revision: 353762 URL: http://llvm.org/viewvc/llvm-project?rev=353762=rev Log: [Sema] Mark GNU compound literal array init as an rvalue. Basically the same issue as string init, except it didn't really have any visible consequences before I

r353765 - Add a new attribute, fortify_stdlib

2019-02-11 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Mon Feb 11 15:21:39 2019 New Revision: 353765 URL: http://llvm.org/viewvc/llvm-project?rev=353765=rev Log: Add a new attribute, fortify_stdlib This attribute applies to declarations of C stdlib functions (sprintf, memcpy...) that have known fortified variants (__sprintf_chk,

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

2019-02-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL353765: Add a new attribute, fortify_stdlib (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

2019-02-11 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington marked 8 inline comments as done. erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:987-989 +The first argument to the attribute is the type passed to +`__builtin_object_size`, and the second is the flag that the fortified

[PATCH] D57855: [analyzer] Reimplement checker options

2019-02-11 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked 5 inline comments as done. Szelethus added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:384 + CheckerOptions<[ +CmdLineOption It would be great if there were a way to define options once and reuse them. I think it's

[PATCH] D58061: Fix a few tests that were missing ':' on CHECK lines and weren't testing anything.

2019-02-11 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. There has been some progress recently on better FileCheck diagnosis of likely test-writing issues, although to date it mostly requires the human to ask "what is going on here?" explicitly. I can see adding a check to detect the

[PATCH] D57915: [COFF, ARM64] Remove definitions for _byteswap library functions

2019-02-11 Thread Tom Tan via Phabricator via cfe-commits
TomTan added a comment. In D57915#1393510 , @thakis wrote: > In D57915#1389722 , @TomTan wrote: > > > In D57915#1389560 , @lebedev.ri > > wrote: > > > > > In D57915#1389549

[PATCH] D58061: Fix a few tests that were missing ':' on CHECK lines and weren't testing anything.

2019-02-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC353744: Fix a few tests that were missing : on CHECK lines and werent testing… (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

2019-02-11 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. How much of the `ModuleDependencyCollector` will be reused as is by LLDB? I wonder about the tradeoff versus inheriting from `DependencyCollector` directly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58072/new/

[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

2019-02-11 Thread Lingda Li via Phabricator via cfe-commits
lildmh created this revision. lildmh added reviewers: ABataev, hfinkel, Meinersbur. lildmh added a project: OpenMP. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. This patch implements the parsing and sema support for OpenMP map clauses with potential

[PATCH] D58069: [Sema] Mark GNU compound literal array init as an rvalue.

2019-02-11 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaInit.cpp:172-173 + E = PE->getSubExpr(); +else if (UnaryOperator *UO = dyn_cast(E)) + E = UO->getSubExpr(); +else if

Re: r353370 - Generalised the SMT state constraints

2019-02-11 Thread Mikhail Ramalho via cfe-commits
Hi Douglas, thank you for the report. We are discussing the issue in https://reviews.llvm.org/D54975. @michaelplatings said he found a solution and I asked him to run the tests locally. If it indeed fixes the issue, I'd say we push it. Em seg, 11 de fev de 2019 às 20:13, escreveu: > Hi

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

2019-02-11 Thread Shiva Chen via Phabricator via cfe-commits
shiva0217 added a comment. In D57497#1388350 , @apazos wrote: > If this is a target flag in GCC, shouldn't we make it a LLVM Target feature > and pass it as -mattr, just like done for mrelax? Hi Ana, It seems that most of the -mattr features only

[PATCH] D58072: Make ModuleDependencyCollector's method virtual (NFC)

2019-02-11 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. In D58072#1393817 , @bruno wrote: > Not really. Would making only the `attachTo*` methods virtual enough though? You mean making them **not** virtual? They're the only ones I don't override. Repository: rC Clang

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

2019-02-11 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 186356. jyu2 added a comment. I find some ambiguous error for asm-goto out of scope. Instead call VerifyIndirectOrAsmJumps one time, call that function twice one for indirect-goto one for asm-goto. Let me know if you see any problems. Thanks for all the

r353791 - Fix VS2015 build problem introduced by r353370.

2019-02-11 Thread Douglas Yung via cfe-commits
Author: dyung Date: Mon Feb 11 18:17:51 2019 New Revision: 353791 URL: http://llvm.org/viewvc/llvm-project?rev=353791=rev Log: Fix VS2015 build problem introduced by r353370. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConstraintManager.h Modified:

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

2019-02-11 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai marked an inline comment as done. vsapsai added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:388 } else { Result = HS.getFileMgr().getFile(Dest); } I have considered changing this to `.getFile(Dest, /*OpenFile=*/true)` so that

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

2019-02-11 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58089/new/ https://reviews.llvm.org/D58089 ___

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

2019-02-11 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/google-objc-function-naming.m:10 +// function would be declared in a system header. +int printf(const char *, ...); //

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

2019-02-11 Thread Aleksei Sidorin via Phabricator via cfe-commits
a_sidorin added a comment. Hi Gabor, The refactoring looks great. I have some minor comments inline. Comment at: unittests/AST/ASTImporterTest.cpp:3549 + void TypedTest_ImportDefinitionThenPrototype() { +Decl *FromTU0 = getTuDecl(getDefinition(), Lang_CXX, "input0.cc");

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

2019-02-11 Thread Nicholas Allegra via Phabricator via cfe-commits
comex created this revision. comex added reviewers: jkorous, phosek. Herald added subscribers: cfe-commits, kadircet, arphaman, ioeric, ilya-biryukov, mgorny. Herald added a project: clang. Fixes build in BUILD_SHARED_LIBS mode. Removes the "DEPENDS clangdXpcJsonConversions" line as LINK_LIBS

[PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

2019-02-11 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. @ABataev Is it intentional that we do not propagate `Allowed` through labels? For example: void f() { #pragma omp barrier // ok label: #pragma omp barrier // error, "cannot be an immediate substatement" label: ; #pragma omp barrier // ok }

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

2019-02-11 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > Did you mean declare as a target feature in RISCV.td or I misunderstanding > something? That's sort of the right idea, but I don't think it works in this context because we aren't trying to change the generated code for a function; we actually need to stick the

[PATCH] D58095: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

2019-02-11 Thread Stephane Moore via Phabricator via cfe-commits
stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Implicit functions are outside the control of source authors and should be exempt from style restrictions. Tested via running clang tools tests. This is an amended followup to

[PATCH] D54978: Move the SMT API to LLVM

2019-02-11 Thread Brian Rzycki via Phabricator via cfe-commits
brzycki added a comment. In D54978#1393968 , @thakis wrote: > Do you understand why the default matters for you? You seem to explicitly > disable the setting, and you still get Z3 as part of your build. Did you make > a clean build dir before turning it

[PATCH] D57930: [Driver] Verify GCCInstallation is valid

2019-02-11 Thread Daniel Mentz via Phabricator via cfe-commits
danielmentz marked an inline comment as done. danielmentz added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:259-260 if (GCCInstallation.getParentLibPath().find("opt/rh/devtoolset") != StringRef::npos) // With devtoolset on RHEL, we want to

[PATCH] D58091: Customize warnings for missing built-in type

2019-02-11 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added reviewers: jyknight, lebedev.ri, aaron.ballman, bcain. Herald added subscribers: jfb, bollu, krytarowski, emaste. Herald added a project: clang. If we detect a built-in declaration for which we cannot derive a type matching the pattern in the

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

2019-02-11 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai created this revision. vsapsai added reviewers: dexonsmith, bruno. Herald added a subscriber: jkorous. In `DirectoryLookup::LookupFile` parameter `HasBeenMapped` doesn't cover the case when clang finds a file through a header map but doesn't remap the lookup filename because the target

  1   2   >