[clang-tools-extra] r309550 - [clangd] Add ':' to completion trigger characters.

2017-07-31 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Jul 31 02:27:52 2017 New Revision: 309550 URL: http://llvm.org/viewvc/llvm-project?rev=309550=rev Log: [clangd] Add ':' to completion trigger characters. Summary: Without it we don't get completion requests from VSCode after nested name qualifiers (e.g. after

[clang-tools-extra] r309378 - [clangd] Workaround for a test failure on Windows.

2017-07-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Jul 28 05:25:51 2017 New Revision: 309378 URL: http://llvm.org/viewvc/llvm-project?rev=309378=rev Log: [clangd] Workaround for a test failure on Windows. Previous workaround (r308959) didn't account for a case when system drive letter is not 'C:'. Modified:

[clang-tools-extra] r309585 - [clangd] Allow to get vfs::FileSystem used inside codeComplete.

2017-07-31 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Jul 31 10:09:29 2017 New Revision: 309585 URL: http://llvm.org/viewvc/llvm-project?rev=309585=rev Log: [clangd] Allow to get vfs::FileSystem used inside codeComplete. Summary: This is useful for managing lifetime of VFS-based caches. Reviewers: bkramer, krasimir

r309795 - Use VFS operations in FileManager::makeAbsolutePath.

2017-08-02 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Aug 2 00:25:24 2017 New Revision: 309795 URL: http://llvm.org/viewvc/llvm-project?rev=309795=rev Log: Use VFS operations in FileManager::makeAbsolutePath. Summary: It used to call into llvm::sys::fs::make_absolute. Reviewers: akyrtzi, erikjv, bkramer, krasimir,

[clang-tools-extra] r309800 - [clangd] Capitalized descriptions of clangd options. NFC.

2017-08-02 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Aug 2 01:53:48 2017 New Revision: 309800 URL: http://llvm.org/viewvc/llvm-project?rev=309800=rev Log: [clangd] Capitalized descriptions of clangd options. NFC. To follow the style of other options shown on `clangd -help`. Modified:

[clang-tools-extra] r309801 - [clangd] Run clang-format on all clangd sources. NFC.

2017-08-02 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Aug 2 02:08:39 2017 New Revision: 309801 URL: http://llvm.org/viewvc/llvm-project?rev=309801=rev Log: [clangd] Run clang-format on all clangd sources. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp

Re: [clang-tools-extra] r308721 - [clangd] Specified --gcc-toolchain explicitly in VFS test.

2017-08-03 Thread Ilya Biryukov via cfe-commits
=libc++ > Seems adding "-stdlib=libstdc++" in CDB.ExtraClangFlags will fix. > How do you think? > > > On Fri, Jul 21, 2017 at 5:21 PM Ilya Biryukov via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ibiryukov >> Date: Fri Jul 21 01:20:47 2017 >

r310618 - Fixed a race condition in PrecompiledPreamble.

2017-08-10 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Aug 10 09:10:40 2017 New Revision: 310618 URL: http://llvm.org/viewvc/llvm-project?rev=310618=rev Log: Fixed a race condition in PrecompiledPreamble. Summary: Two PrecompiledPreambles, used in parallel on separate threads, could be writing preamble to the same

[clang-tools-extra] r310819 - [clangd] Check if CompileCommand has changed on forceReparse.

2017-08-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Aug 14 01:37:32 2017 New Revision: 310819 URL: http://llvm.org/viewvc/llvm-project?rev=310819=rev Log: [clangd] Check if CompileCommand has changed on forceReparse. Reviewers: krasimir, bkramer, klimek Reviewed By: klimek Subscribers: cfe-commits Differential

[clang-tools-extra] r310821 - [clangd] Use multiple working threads in clangd.

2017-08-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Aug 14 01:45:47 2017 New Revision: 310821 URL: http://llvm.org/viewvc/llvm-project?rev=310821=rev Log: [clangd] Use multiple working threads in clangd. Reviewers: bkramer, krasimir, klimek Reviewed By: klimek Subscribers: arphaman, cfe-commits Differential

[clang-tools-extra] r310818 - [clangd] Fixed a data race.

2017-08-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Aug 14 01:17:24 2017 New Revision: 310818 URL: http://llvm.org/viewvc/llvm-project?rev=310818=rev Log: [clangd] Fixed a data race. Summary: Calling addDocument after removeDocument could have resulted in an invalid program state (AST and Preamble for the valid

r308016 - [index] Added a method indexTopLevelDecls to run indexing on a list of Decls.

2017-07-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Jul 14 03:47:45 2017 New Revision: 308016 URL: http://llvm.org/viewvc/llvm-project?rev=308016=rev Log: [index] Added a method indexTopLevelDecls to run indexing on a list of Decls. Summary: We need it in clangd for refactoring that replaces ASTUnit with manual AST

r308722 - Fixed failing assert in code completion.

2017-07-21 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Jul 21 02:24:00 2017 New Revision: 308722 URL: http://llvm.org/viewvc/llvm-project?rev=308722=rev Log: Fixed failing assert in code completion. Summary: The code was accessing uninstantiated default argument. This resulted in failing assertion at

[clang-tools-extra] r308721 - [clangd] Specified --gcc-toolchain explicitly in VFS test.

2017-07-21 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Jul 21 01:20:47 2017 New Revision: 308721 URL: http://llvm.org/viewvc/llvm-project?rev=308721=rev Log: [clangd] Specified --gcc-toolchain explicitly in VFS test. In order to avoid platform-specific configuration quirks. (Possible fix for

[clang-tools-extra] r308738 - [clangd] Replace ASTUnit with manual AST management.

2017-07-21 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Jul 21 06:29:29 2017 New Revision: 308738 URL: http://llvm.org/viewvc/llvm-project?rev=308738=rev Log: [clangd] Replace ASTUnit with manual AST management. Summary: This refactoring does not aim to introduce any significant changes to the behaviour of clangd to keep

[clang-tools-extra] r308959 - [clangd] Workaround Windows test failures.

2017-07-25 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jul 25 02:31:51 2017 New Revision: 308959 URL: http://llvm.org/viewvc/llvm-project?rev=308959=rev Log: [clangd] Workaround Windows test failures. To properly fix this, Unix-specific paths should not be used when running tests on Windows. Modified:

[clang-tools-extra] r309295 - [clangd] Don't reverse priorities of completion items.

2017-07-27 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jul 27 10:43:07 2017 New Revision: 309295 URL: http://llvm.org/viewvc/llvm-project?rev=309295=rev Log: [clangd] Don't reverse priorities of completion items. Summary: Current algorithm incorrectly provides completion results in a reverse order. Reviewers: krasimir,

Re: [clang-tools-extra] r308738 - [clangd] Replace ASTUnit with manual AST management.

2017-07-25 Thread Ilya Biryukov via cfe-commits
ot;:{" > textDocument":{"uri":"file:///main.cpp"},"position":{"line": > 4,"character":10}}} > > --> {"jsonrpc":"2.0","id":1,"result":[{"uri": "file:///main.cpp", > &qu

[clang-tools-extra] r306705 - [clangd] Check failure of Lexer::getRawToken in GoToDeclaration.

2017-06-29 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jun 29 10:11:32 2017 New Revision: 306705 URL: http://llvm.org/viewvc/llvm-project?rev=306705=rev Log: [clangd] Check failure of Lexer::getRawToken in GoToDeclaration. There was an access to unitialized memory because it wasn't checked. Modified:

[clang-tools-extra] r307025 - [clangd] Add -ffreestanding on VFS tests.

2017-07-03 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Jul 3 07:46:03 2017 New Revision: 307025 URL: http://llvm.org/viewvc/llvm-project?rev=307025=rev Log: [clangd] Add -ffreestanding on VFS tests. Summary: They don't provide proper gcc installations and may fail on implicit include. Reviewers: klimek, krasimir,

[clang-tools-extra] r306530 - [clangd] Allow to override resource dir in ClangdServer.

2017-06-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Jun 28 03:34:50 2017 New Revision: 306530 URL: http://llvm.org/viewvc/llvm-project?rev=306530=rev Log: [clangd] Allow to override resource dir in ClangdServer. Reviewers: bkramer, krasimir, klimek Reviewed By: klimek Subscribers: klimek, cfe-commits Tags:

[clang-tools-extra] r306652 - [clangd] Added a test, checking that gcc install is searched via VFS.

2017-06-29 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jun 29 01:43:51 2017 New Revision: 306652 URL: http://llvm.org/viewvc/llvm-project?rev=306652=rev Log: [clangd] Added a test, checking that gcc install is searched via VFS. Reviewers: bkramer, krasimir, klimek Reviewed By: klimek Subscribers: klimek, cfe-commits

[clang-tools-extra] r306656 - [clangd] Run a test, searching for gcc install, only on Unix.

2017-06-29 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jun 29 02:22:32 2017 New Revision: 306656 URL: http://llvm.org/viewvc/llvm-project?rev=306656=rev Log: [clangd] Run a test, searching for gcc install, only on Unix. This should fix windows buildbots. Modified:

r306549 - Use vfs::FileSystem in ASTUnit when creating CompilerInvocation.

2017-06-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Jun 28 08:06:34 2017 New Revision: 306549 URL: http://llvm.org/viewvc/llvm-project?rev=306549=rev Log: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation. Summary: It used to always call into the RealFileSystem before. Reviewers: bkramer, krasimir,

[clang-tools-extra] r309705 - [clangd] Fixed MSVC compilation failures.

2017-08-01 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Aug 1 10:17:37 2017 New Revision: 309705 URL: http://llvm.org/viewvc/llvm-project?rev=309705=rev Log: [clangd] Fixed MSVC compilation failures. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.h Modified: clang-tools-extra/trunk/clangd/ClangdUnit.h URL:

[clang-tools-extra] r309696 - [clangd] Rewrote AST and Preamble management.

2017-08-01 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Aug 1 08:51:38 2017 New Revision: 309696 URL: http://llvm.org/viewvc/llvm-project?rev=309696=rev Log: [clangd] Rewrote AST and Preamble management. Summary: The new implementation allows code completion that never waits for AST. Reviewers: bkramer, krasimir, klimek

[clang-tools-extra] r309720 - [clangd] Fix more MSVC compilation failures.

2017-08-01 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Aug 1 11:27:58 2017 New Revision: 309720 URL: http://llvm.org/viewvc/llvm-project?rev=309720=rev Log: [clangd] Fix more MSVC compilation failures. It turns out MSVC does not allow non-copyable classes in std::future and std::promise template arguments. Modified:

[clang-tools-extra] r310470 - [clangd] Fixed a bug in make_tagged.

2017-08-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Aug 9 05:55:13 2017 New Revision: 310470 URL: http://llvm.org/viewvc/llvm-project?rev=310470=rev Log: [clangd] Fixed a bug in make_tagged. It accidentally std::move'd from Value parameter if it deduced to an l-value ref. Modified:

[clang-tools-extra] r303063 - Test commit(changed comment)

2017-05-15 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon May 15 08:50:46 2017 New Revision: 303063 URL: http://llvm.org/viewvc/llvm-project?rev=303063=rev Log: Test commit(changed comment) Modified: clang-tools-extra/trunk/clangd/ASTManager.h Modified: clang-tools-extra/trunk/clangd/ASTManager.h URL:

[clang-tools-extra] r303067 - [ClangD] Refactor clangd into separate components

2017-05-15 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon May 15 09:17:35 2017 New Revision: 303067 URL: http://llvm.org/viewvc/llvm-project?rev=303067=rev Log: [ClangD] Refactor clangd into separate components Summary: Major refactoring to split LSP implementation, Clang API calls and threading(mostly synchronization)

[clang-tools-extra] r303151 - Restored r303067 and fixed failing test.

2017-05-16 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 16 04:38:59 2017 New Revision: 303151 URL: http://llvm.org/viewvc/llvm-project?rev=303151=rev Log: Restored r303067 and fixed failing test. Summary: This commit restores r303067(reverted by r303094) and fixes the 'formatting.test' failure. The failure is due to

[clang-tools-extra] r303154 - Fixing compilation failures on buildbots.

2017-05-16 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 16 05:06:20 2017 New Revision: 303154 URL: http://llvm.org/viewvc/llvm-project?rev=303154=rev Log: Fixing compilation failures on buildbots. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tools-extra/trunk/clangd/DraftStore.cpp

r305890 - Moved code hanlding precompiled preamble out of the ASTUnit.

2017-06-21 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Jun 21 05:24:58 2017 New Revision: 305890 URL: http://llvm.org/viewvc/llvm-project?rev=305890=rev Log: Moved code hanlding precompiled preamble out of the ASTUnit. Reviewers: bkramer, krasimir, arphaman, akyrtzi, klimek Reviewed By: klimek Subscribers: mgorny,

r305902 - Fixed compiler warnings after r305890.

2017-06-21 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Jun 21 07:34:27 2017 New Revision: 305902 URL: http://llvm.org/viewvc/llvm-project?rev=305902=rev Log: Fixed compiler warnings after r305890. Should fix buildbots that pass -Werror. Modified: cfe/trunk/lib/Frontend/ASTUnit.cpp Modified:

[clang-tools-extra] r303636 - [clangd] Added a missing dependency on clangdAST to fix the build

2017-05-23 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 23 08:59:37 2017 New Revision: 303636 URL: http://llvm.org/viewvc/llvm-project?rev=303636=rev Log: [clangd] Added a missing dependency on clangdAST to fix the build Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified:

[clang-tools-extra] r303993 - [clangd] Attempt to fix tests failing on Windows

2017-05-26 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri May 26 09:34:34 2017 New Revision: 303993 URL: http://llvm.org/viewvc/llvm-project?rev=303993=rev Log: [clangd] Attempt to fix tests failing on Windows Modified: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp Modified:

[clang-tools-extra] r303977 - [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-26 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri May 26 07:26:51 2017 New Revision: 303977 URL: http://llvm.org/viewvc/llvm-project?rev=303977=rev Log: [clangd] Allow to use vfs::FileSystem for file accesses. Summary: Custom vfs::FileSystem is currently used for unit tests. This revision depends on

[clang-tools-extra] r303173 - [clangd] Refactor ProtocolHandlers to decouple them from ClangdLSPServer

2017-05-16 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 16 09:40:30 2017 New Revision: 303173 URL: http://llvm.org/viewvc/llvm-project?rev=303173=rev Log: [clangd] Refactor ProtocolHandlers to decouple them from ClangdLSPServer Summary: A refactoring to decouple ProtocolHandlers and Language Server input parsing loop

[clang-tools-extra] r303177 - Added missing includes in clangd to fix the build.

2017-05-16 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 16 10:23:55 2017 New Revision: 303177 URL: http://llvm.org/viewvc/llvm-project?rev=303177=rev Log: Added missing includes in clangd to fix the build. This commit should fix buildbot failures. Modified: clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp

[clang-tools-extra] r304214 - [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider.

2017-05-30 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 30 10:11:02 2017 New Revision: 304214 URL: http://llvm.org/viewvc/llvm-project?rev=304214=rev Log: [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider. Summary: This allows an implementation of FileSystemProvider that can track

[clang-tools-extra] r305283 - Revert "[clangd] Allow to override contents of the file during completion."

2017-06-13 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jun 13 05:01:11 2017 New Revision: 305283 URL: http://llvm.org/viewvc/llvm-project?rev=305283=rev Log: Revert "[clangd] Allow to override contents of the file during completion." This caused buildbots failures, reverting until we'll find out what's wrong. Modified:

[clang-tools-extra] r305279 - [clangd] Use 'std::string' for VFSTag instead of 'int'

2017-06-13 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jun 13 03:24:48 2017 New Revision: 305279 URL: http://llvm.org/viewvc/llvm-project?rev=305279=rev Log: [clangd] Use 'std::string' for VFSTag instead of 'int' Reviewers: krasimir Reviewed By: krasimir Subscribers: klimek, cfe-commits Tags: #clang-tools-extra

[clang-tools-extra] r305280 - [clangd] Allow to override contents of the file during completion.

2017-06-13 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jun 13 03:32:27 2017 New Revision: 305280 URL: http://llvm.org/viewvc/llvm-project?rev=305280=rev Log: [clangd] Allow to override contents of the file during completion. Reviewers: krasimir Reviewed By: krasimir Subscribers: klimek, cfe-commits Differential

[clang-tools-extra] r305291 - [clangd] Allow to override contents of the file during completion.

2017-06-13 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jun 13 09:15:56 2017 New Revision: 305291 URL: http://llvm.org/viewvc/llvm-project?rev=305291=rev Log: [clangd] Allow to override contents of the file during completion. Summary: This is a reapplied r305280 with a fix to the crash found by build bots (StringRef to an

[clang-tools-extra] r305299 - [clangd] A comment for ClangdServer's constructor. NFC.

2017-06-13 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jun 13 11:02:27 2017 New Revision: 305299 URL: http://llvm.org/viewvc/llvm-project?rev=305299=rev Log: [clangd] A comment for ClangdServer's constructor. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.h Modified:

[clang-tools-extra] r305376 - [clangd] Add a filename parameter to FileSystemProvider.

2017-06-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Jun 14 04:46:44 2017 New Revision: 305376 URL: http://llvm.org/viewvc/llvm-project?rev=305376=rev Log: [clangd] Add a filename parameter to FileSystemProvider. Reviewers: krasimir Reviewed By: krasimir Subscribers: klimek, cfe-commits Tags: #clang-tools-extra

[clang-tools-extra] r305298 - [clangd] Store references instead of unique_ptrs in ClangdServer.

2017-06-13 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jun 13 10:59:43 2017 New Revision: 305298 URL: http://llvm.org/viewvc/llvm-project?rev=305298=rev Log: [clangd] Store references instead of unique_ptrs in ClangdServer. Summary: ClangdServer owned objects passed to it in constructor for no good reason. Lots of stuff

[clang-tools-extra] r313730 - [clangd] Introduced Logger interface.

2017-09-20 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Sep 20 00:24:15 2017 New Revision: 313730 URL: http://llvm.org/viewvc/llvm-project?rev=313730=rev Log: [clangd] Introduced Logger interface. Summary: This fixes a bunch of logging-related FIXMEs. Reviewers: bkramer, krasimir, malaperle Reviewed By: malaperle

r314019 - Set completion priority of destructors and operators to CCP_Unlikely.

2017-09-22 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Sep 22 12:07:37 2017 New Revision: 314019 URL: http://llvm.org/viewvc/llvm-project?rev=314019=rev Log: Set completion priority of destructors and operators to CCP_Unlikely. Summary: It will move destructors and operators to the end of completion list. Destructors and

[clang-tools-extra] r314020 - [clangd] Updated gold for completion tests after cfe changes.

2017-09-22 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Sep 22 12:07:45 2017 New Revision: 314020 URL: http://llvm.org/viewvc/llvm-project?rev=314020=rev Log: [clangd] Updated gold for completion tests after cfe changes. Modified: clang-tools-extra/trunk/test/clangd/completion-snippet.test

[clang-tools-extra] r313759 - [clangd] Put inacessible items to the end of completion list.

2017-09-20 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Sep 20 08:09:14 2017 New Revision: 313759 URL: http://llvm.org/viewvc/llvm-project?rev=313759=rev Log: [clangd] Put inacessible items to the end of completion list. Reviewers: bkramer, krasimir Reviewed By: krasimir Subscribers: klimek, cfe-commits Differential

Re: [clang-tools-extra] r313754 - [clangd] Serialize onDiagnosticsReady callbacks for the same file.

2017-09-20 Thread Ilya Biryukov via cfe-commits
esn't look like the sanitizers are > reporting anything suspicious. Do you by any chance know what went wrong? > If it will turn out to be a macOS only thing it might make sense to XFAIL > formatting.test until the issue is resolved. > > Thanks, > Alex > > On 20 September 2017 a

[clang-tools-extra] r313801 - [clangd] Fixed crash on MacOS.

2017-09-20 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Sep 20 12:32:06 2017 New Revision: 313801 URL: http://llvm.org/viewvc/llvm-project?rev=313801=rev Log: [clangd] Fixed crash on MacOS. Caused by invalid order of members in ClangdServer. DiagnosticsMutex was used after destruction. Modified:

Re: [clang-tools-extra] r313754 - [clangd] Serialize onDiagnosticsReady callbacks for the same file.

2017-09-20 Thread Ilya Biryukov via cfe-commits
wrong? >> If it will turn out to be a macOS only thing it might make sense to XFAIL >> formatting.test until the issue is resolved. >> >> Thanks, >> Alex >> >> On 20 September 2017 at 13:58, Ilya Biryukov via cfe-commits < >> cfe-commits@lists.llvm.org> wr

[clang-tools-extra] r313754 - [clangd] Serialize onDiagnosticsReady callbacks for the same file.

2017-09-20 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Sep 20 05:58:55 2017 New Revision: 313754 URL: http://llvm.org/viewvc/llvm-project?rev=313754=rev Log: [clangd] Serialize onDiagnosticsReady callbacks for the same file. Summary: Calls to onDiagnosticsReady were done concurrently before. This sometimes led to older

[clang-tools-extra] r313749 - [clangd] Run clang-format on ClangdUnit.cpp. NFC.

2017-09-20 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Sep 20 03:46:58 2017 New Revision: 313749 URL: http://llvm.org/viewvc/llvm-project?rev=313749=rev Log: [clangd] Run clang-format on ClangdUnit.cpp. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified:

[clang-tools-extra] r315065 - [clangd] Run clang-format on the source code. NFC.

2017-10-06 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Oct 6 07:39:39 2017 New Revision: 315065 URL: http://llvm.org/viewvc/llvm-project?rev=315065=rev Log: [clangd] Run clang-format on the source code. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp Modified:

[clang-tools-extra] r315287 - Revert "Revert r315214 since diff -Z isn't portable, this is breaking:"

2017-10-10 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Oct 10 02:08:47 2017 New Revision: 315287 URL: http://llvm.org/viewvc/llvm-project?rev=315287=rev Log: Revert "Revert r315214 since diff -Z isn't portable, this is breaking:" This reverts commit r315242 and restores r315214. To fix original failure, replaced

Re: [clang-tools-extra] r315214 - [clangd] Added a command-line arg to mirror clangd input into a file.

2017-10-10 Thread Ilya Biryukov via cfe-commits
Sorry about that, `diff -b` seems to work. Restored commit and changed to `diff -b` in r315287. Thanks for spotting and reverting this. On Mon, Oct 9, 2017 at 8:45 PM, Bruno Cardoso Lopes <bruno.card...@gmail.com > wrote: > Hi, > > On Mon, Oct 9, 2017 at 9:58 AM, Ilya Biryukov

[clang-tools-extra] r315284 - [clangd] Fix compilation on gcc.

2017-10-10 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Oct 10 01:40:57 2017 New Revision: 315284 URL: http://llvm.org/viewvc/llvm-project?rev=315284=rev Log: [clangd] Fix compilation on gcc. Modified: clang-tools-extra/trunk/clangd/Function.h Modified: clang-tools-extra/trunk/clangd/Function.h URL:

Re: [clang-tools-extra] r315210 - [clangd] Added move-only function helpers.

2017-10-10 Thread Ilya Biryukov via cfe-commits
ommit broke build on one of our builders: >> >> http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi- >> test/builds/16435 >> >> Please have a look? >> >> Thanks >> >> Galina >> >> >> On Mon, Oct 9, 2017 at 9:26 AM, Ilya Biryukov via cfe-

Re: [clang-tools-extra] r315210 - [clangd] Added move-only function helpers.

2017-10-10 Thread Ilya Biryukov via cfe-commits
se have a look? > > Thanks > > Galina > > > On Mon, Oct 9, 2017 at 9:26 AM, Ilya Biryukov via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ibiryukov >> Date: Mon Oct 9 09:26:26 2017 >> New Revision: 315210 >> >> URL: htt

r315212 - Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

2017-10-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Oct 9 09:52:12 2017 New Revision: 315212 URL: http://llvm.org/viewvc/llvm-project?rev=315212=rev Log: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble. Summary: It was previsouly set only in ASTUnit, but it should be set for all client of

[clang-tools-extra] r315214 - [clangd] Added a command-line arg to mirror clangd input into a file.

2017-10-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Oct 9 09:58:16 2017 New Revision: 315214 URL: http://llvm.org/viewvc/llvm-project?rev=315214=rev Log: [clangd] Added a command-line arg to mirror clangd input into a file. Summary: The arg is useful for debugging and creating test cases. Reviewers: bkramer, krasimir

[clang-tools-extra] r315213 - [clangd] Added a test for r315212.

2017-10-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Oct 9 09:53:00 2017 New Revision: 315213 URL: http://llvm.org/viewvc/llvm-project?rev=315213=rev Log: [clangd] Added a test for r315212. Added: clang-tools-extra/trunk/test/clangd/diagnostics-preamble.test Added:

[clang-tools-extra] r315210 - [clangd] Added move-only function helpers.

2017-10-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Oct 9 09:26:26 2017 New Revision: 315210 URL: http://llvm.org/viewvc/llvm-project?rev=315210=rev Log: [clangd] Added move-only function helpers. Summary: They are now used in ClangdScheduler instead of deferred std::async computations. The results of `std::async` are

[clang-tools-extra] r315317 - [clangd] clang-format the source code. NFC.

2017-10-10 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Oct 10 07:21:04 2017 New Revision: 315317 URL: http://llvm.org/viewvc/llvm-project?rev=315317=rev Log: [clangd] clang-format the source code. NFC. Modified: clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp

[clang-tools-extra] r315324 - [clangd] Added missing #includes to Function.h

2017-10-10 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Oct 10 09:12:50 2017 New Revision: 315324 URL: http://llvm.org/viewvc/llvm-project?rev=315324=rev Log: [clangd] Added missing #includes to Function.h Modified: clang-tools-extra/trunk/clangd/Function.h Modified: clang-tools-extra/trunk/clangd/Function.h URL:

[clang-tools-extra] r315323 - [clangd] Added forgotten return in UniqueFunction.

2017-10-10 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Oct 10 09:12:47 2017 New Revision: 315323 URL: http://llvm.org/viewvc/llvm-project?rev=315323=rev Log: [clangd] Added forgotten return in UniqueFunction. This hasn't bitten us because we only used functions returning 'void'. Modified:

[clang-tools-extra] r315325 - [clangd] Use UniqueFunction for deferred computations.

2017-10-10 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Oct 10 09:12:54 2017 New Revision: 315325 URL: http://llvm.org/viewvc/llvm-project?rev=315325=rev Log: [clangd] Use UniqueFunction for deferred computations. Previsouly, `std::future` that were results of `std::async(std::launch::deferred, ...` were used. Modified:

[clang-tools-extra] r315028 - [clangd] Attempt to fix compilation with MSVC.

2017-10-05 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Oct 5 15:15:15 2017 New Revision: 315028 URL: http://llvm.org/viewvc/llvm-project?rev=315028=rev Log: [clangd] Attempt to fix compilation with MSVC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.h Modified: clang-tools-extra/trunk/clangd/ClangdServer.h

[clang-tools-extra] r314989 - [clangd] Added async API to run code completion.

2017-10-05 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Oct 5 10:04:13 2017 New Revision: 314989 URL: http://llvm.org/viewvc/llvm-project?rev=314989=rev Log: [clangd] Added async API to run code completion. Summary: ClangdServer now provides async code completion API. It is still used synchronously by ClangdLSPServer,

Re: [clang-tools-extra] r314989 - [clangd] Added async API to run code completion.

2017-10-06 Thread Ilya Biryukov via cfe-commits
64-scei-ps4-windows10pro-fast/builds/12525 > > Can you take a look and fix it? > > Douglas Yung > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > Ilya Biryukov via cfe-commits > > Sent: T

r312788 - Fixed a crash in code completion.

2017-09-08 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Sep 8 06:36:38 2017 New Revision: 312788 URL: http://llvm.org/viewvc/llvm-project?rev=312788=rev Log: Fixed a crash in code completion. Summary: The crash occured when FunctionDecl was parsed with an initializer. Reviewers: bkramer, klimek, francisco.lopes Reviewed

r313014 - Fix recording preamble's conditional stack in skipped PP branches.

2017-09-12 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Sep 12 01:35:57 2017 New Revision: 313014 URL: http://llvm.org/viewvc/llvm-project?rev=313014=rev Log: Fix recording preamble's conditional stack in skipped PP branches. Summary: This fixes PR34547. `Lexer::LexEndOfFile` handles recording of ConditionalStack for

[clang-tools-extra] r313029 - [clangd] Add support for snippet completions

2017-09-12 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Sep 12 06:57:14 2017 New Revision: 313029 URL: http://llvm.org/viewvc/llvm-project?rev=313029=rev Log: [clangd] Add support for snippet completions Enhances CompletionItemsCollector in such a way that snippet completions can be presented to the client. Enable snippet

[clang-tools-extra] r314445 - [clangd] Skip informative qualifier chunks.

2017-09-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Sep 28 11:39:59 2017 New Revision: 314445 URL: http://llvm.org/viewvc/llvm-project?rev=314445=rev Log: [clangd] Skip informative qualifier chunks. Summary: Completion results look much nicer without them. Informative qualifiers are stored for every method from a base

[clang-tools-extra] r314678 - [clangd] Command line arg to specify compile_commands.json path

2017-10-02 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Oct 2 08:13:20 2017 New Revision: 314678 URL: http://llvm.org/viewvc/llvm-project?rev=314678=rev Log: [clangd] Command line arg to specify compile_commands.json path Summary: Adds compileCommands command line argument to specify an absolute path directly to the

[clang-tools-extra] r314677 - [clangd] Run clang-format on the source code. NFC.

2017-10-02 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Oct 2 08:10:41 2017 New Revision: 314677 URL: http://llvm.org/viewvc/llvm-project?rev=314677=rev Log: [clangd] Run clang-format on the source code. NFC. Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.h Modified:

[clang-tools-extra] r311436 - [clangd] Updated ClangdServer comments. NFC.

2017-08-22 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Aug 22 02:16:46 2017 New Revision: 311436 URL: http://llvm.org/viewvc/llvm-project?rev=311436=rev Log: [clangd] Updated ClangdServer comments. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.h Modified: clang-tools-extra/trunk/clangd/ClangdServer.h

r311330 - Fixed a crash on replaying Preamble's PP conditional stack.

2017-08-21 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Aug 21 05:03:08 2017 New Revision: 311330 URL: http://llvm.org/viewvc/llvm-project?rev=311330=rev Log: Fixed a crash on replaying Preamble's PP conditional stack. Summary: The crash occurs when the first token after a preamble is a macro expansion. Fixed by moving

[clang-tools-extra] r312483 - clangd: Tolerate additional headers

2017-09-04 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Sep 4 05:28:15 2017 New Revision: 312483 URL: http://llvm.org/viewvc/llvm-project?rev=312483=rev Log: clangd: Tolerate additional headers Summary: The language server protocol specified 2 headers (Content-Length and Content-Type), but does not specify their

Re: [clang-tools-extra] r315323 - [clangd] Added forgotten return in UniqueFunction.

2017-10-23 Thread Ilya Biryukov via cfe-commits
wrote: > Is there missing test coverage for this? > > On Tue, Oct 10, 2017 at 9:12 AM Ilya Biryukov via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ibiryukov >> Date: Tue Oct 10 09:12:47 2017 >> New Revision: 315323 >> >> URL: http://llvm.org/vie

[clang-tools-extra] r316323 - [clangd] Updated outdated test comment. NFC.

2017-10-23 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Oct 23 07:08:52 2017 New Revision: 316323 URL: http://llvm.org/viewvc/llvm-project?rev=316323=rev Log: [clangd] Updated outdated test comment. NFC. Modified: clang-tools-extra/trunk/test/clangd/input-mirror.test Modified:

Re: [clang-tools-extra] r315287 - Revert "Revert r315214 since diff -Z isn't portable, this is breaking:"

2017-10-23 Thread Ilya Biryukov via cfe-commits
Missed that, will do, thanks. On Wed, Oct 11, 2017 at 1:39 AM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > On Tue, Oct 10, 2017 at 2:08 AM, Ilya Biryukov via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: ibiryukov > > Date: Tue Oct 10

[clang-tools-extra] r318317 - [clangd] clang-format the source code. NFC.

2017-11-15 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Nov 15 10:04:56 2017 New Revision: 318317 URL: http://llvm.org/viewvc/llvm-project?rev=318317=rev Log: [clangd] clang-format the source code. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp clang-tools-extra/trunk/clangd/ClangdServer.cpp

r318945 - Avoid copying the data of in-memory preambles

2017-11-24 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Nov 24 05:12:38 2017 New Revision: 318945 URL: http://llvm.org/viewvc/llvm-project?rev=318945=rev Log: Avoid copying the data of in-memory preambles Summary: Preambles are large and we should avoid copying them. Reviewers: bkramer, klimek Reviewed By: bkramer

[clang-tools-extra] r318946 - [clangd] Sort list of sources in CMakeLists.txt. NFC

2017-11-24 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Nov 24 05:13:41 2017 New Revision: 318946 URL: http://llvm.org/viewvc/llvm-project?rev=318946=rev Log: [clangd] Sort list of sources in CMakeLists.txt. NFC Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified:

[clang-tools-extra] r318944 - [clangd] Ensure preamble outlives the AST

2017-11-24 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Nov 24 05:04:21 2017 New Revision: 318944 URL: http://llvm.org/viewvc/llvm-project?rev=318944=rev Log: [clangd] Ensure preamble outlives the AST Summary: In-memory preambles will not be copied anymore, so we need to make sure they outlive the AST. Reviewers: bkramer,

[clang-tools-extra] r319753 - [clangd] Set completion options per-request.

2017-12-05 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Dec 5 02:42:57 2017 New Revision: 319753 URL: http://llvm.org/viewvc/llvm-project?rev=319753=rev Log: [clangd] Set completion options per-request. Summary: Previously, completion options were set per ClangdServer instance. It will allow to change completion

r320702 - Renamed test file to use proper naming convention

2017-12-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Dec 14 06:51:17 2017 New Revision: 320702 URL: http://llvm.org/viewvc/llvm-project?rev=320702=rev Log: Renamed test file to use proper naming convention Also changed the order of CHECK statements. CHEKC-NOT must come before CHECK in skipped-function-bodies.cpp Added:

r320696 - [Frontend] Treat function with skipped body as definition

2017-12-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Dec 14 05:00:33 2017 New Revision: 320696 URL: http://llvm.org/viewvc/llvm-project?rev=320696=rev Log: [Frontend] Treat function with skipped body as definition Summary: This fixes an invalid warning about missing definition of a function when parsing with

[clang-tools-extra] r320706 - [clangd] Implemented tracing using Context

2017-12-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Dec 14 07:04:59 2017 New Revision: 320706 URL: http://llvm.org/viewvc/llvm-project?rev=320706=rev Log: [clangd] Implemented tracing using Context Reviewers: sammccall, ioeric, hokein Reviewed By: sammccall Subscribers: klimek, luckygeck, cfe-commits Differential

[clang-tools-extra] r320708 - [clangd] Changed tracing interfaces

2017-12-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Dec 14 07:33:38 2017 New Revision: 320708 URL: http://llvm.org/viewvc/llvm-project?rev=320708=rev Log: [clangd] Changed tracing interfaces Summary: EventTracer interface now contains two methods: - spanEvent for events that have duration, - instant for events that are

[clang-tools-extra] r320576 - [clangd] Implemented logging using Context

2017-12-13 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Dec 13 04:51:22 2017 New Revision: 320576 URL: http://llvm.org/viewvc/llvm-project?rev=320576=rev Log: [clangd] Implemented logging using Context Reviewers: sammccall, ioeric, hokein Reviewed By: sammccall Subscribers: klimek, cfe-commits Differential Revision:

[clang-tools-extra] r320577 - [clangd] clang-format the source code. NFC

2017-12-13 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Dec 13 04:53:16 2017 New Revision: 320577 URL: http://llvm.org/viewvc/llvm-project?rev=320577=rev Log: [clangd] clang-format the source code. NFC Modified: clang-tools-extra/trunk/clangd/index/Index.cpp clang-tools-extra/trunk/clangd/index/Index.h

r320804 - [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

2017-12-15 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Dec 15 03:27:51 2017 New Revision: 320804 URL: http://llvm.org/viewvc/llvm-project?rev=320804=rev Log: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble. Summary: Revision D38639 needs this commit in order to properly make open

[clang-tools-extra] r320591 - [clangd] Fix bool conversion operator of UniqueFunction

2017-12-13 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Dec 13 07:42:59 2017 New Revision: 320591 URL: http://llvm.org/viewvc/llvm-project?rev=320591=rev Log: [clangd] Fix bool conversion operator of UniqueFunction Usages of it were giving compiler errors because of the missing explicit conversion. Modified:

[clang-tools-extra] r320578 - [clangd] Try to workaround MSVC compilation failure.

2017-12-13 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Dec 13 05:43:47 2017 New Revision: 320578 URL: http://llvm.org/viewvc/llvm-project?rev=320578=rev Log: [clangd] Try to workaround MSVC compilation failure. Modified: clang-tools-extra/trunk/clangd/Context.h Modified: clang-tools-extra/trunk/clangd/Context.h URL:

r318514 - Use llvm-config.h instead of config.h

2017-11-17 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Nov 17 02:09:02 2017 New Revision: 318514 URL: http://llvm.org/viewvc/llvm-project?rev=318514=rev Log: Use llvm-config.h instead of config.h To fix standalone builds broken by r318411 (config.h is private to llvm). Modified:

  1   2   3   4   >