Re: [PATCH] D11948: Add some macros to abstract marking of parameters as not null, and use them in cstring

2015-08-13 Thread Stephen Hines via cfe-commits
I don't see anywhere in the C standard that says that a memcpy() with NULL for either pointer is UB (which would only be valid for the case where n == 0). This seems like a particularly aggressive (mis)optimization in the general case. It should only be acceptable if the length is guaranteed to be

Re: [PATCH] D13572: Use Triple.isAndroid() where possible.

2015-10-08 Thread Stephen Hines via cfe-commits
srhines added a comment. LGTM Repository: rL LLVM http://reviews.llvm.org/D13572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-02 Thread Stephen Hines via cfe-commits
srhines updated this revision to Diff 41654. srhines added a comment. Switched to isPowerOf2_32() and added more details about Android's ABI. http://reviews.llvm.org/D14639 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/arm-abi-vector.c Index: test/CodeGen/arm-abi-vector.c

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-02 Thread Stephen Hines via cfe-commits
srhines marked 3 inline comments as done. srhines added a comment. I uploaded a fixed version to use isPowerOf2_32() and more comments. Thanks for the reviews. http://reviews.llvm.org/D14639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-01 Thread Stephen Hines via cfe-commits
srhines updated this revision to Diff 41560. srhines added a comment. Update vector ABI for Android ARM targets. Summary: Looking into some recent issues with LLDB's expression parser highlighted that upstream clang passes vector types differently than the Android Open Source Project's clang for

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-01 Thread Stephen Hines via cfe-commits
srhines commandeered this revision. srhines added a reviewer: ADodds. srhines added a comment. Commandeering, since I am going to upload a version with the updated tests. Repository: rL LLVM http://reviews.llvm.org/D14639 ___ cfe-commits mailing

r254682 - LLDB JIT needs android vector passing rules.

2015-12-03 Thread Stephen Hines via cfe-commits
Author: srhines Date: Thu Dec 3 19:39:30 2015 New Revision: 254682 URL: http://llvm.org/viewvc/llvm-project?rev=254682=rev Log: LLDB JIT needs android vector passing rules. Summary: Looking into some recent issues with LLDBs expression parser highlighted that upstream clang passes vectors

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-03 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254682: LLDB JIT needs android vector passing rules. (authored by srhines). Changed prior to commit: http://reviews.llvm.org/D14639?vs=41654=41837#toc Repository: rL LLVM

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-01 Thread Stephen Hines via cfe-commits
srhines added a comment. In http://reviews.llvm.org/D14639#300077, @rnk wrote: > Were these changes made to AOSP Clang to match upstream GCC, or some custom > Android version of GCC? Where would one go to find ground truth on how these > types should be passed? These changes are reverting to

Re: [PATCH] D20709: Support ARM subtarget feature +long64

2016-05-30 Thread Stephen Hines via cfe-commits
srhines added a comment. In http://reviews.llvm.org/D20709#443536, @kristof.beyls wrote: > Hi Pirama, > > My understanding is that this introduces (yet another) ARM 32 bit ABI variant > - in this case with longs being 64 bit. > My understanding is also that this is the ABI that is used in

Re: [PATCH] D20709: For RenderScript, set alignment and width of long to 64-bits

2016-06-01 Thread Stephen Hines via cfe-commits
srhines added a comment. After talking to Richard this afternoon on IRC, we are going with a slightly different plan here. We will create two new triples (renderscript32-*-* and renderscript64-*-*), which are direct subclasses of the general Android ARM32 and ARM64 targets. In this case, we

Re: [PATCH] D18138: Add -fnative-half-arguments-and-returns

2016-03-15 Thread Stephen Hines via cfe-commits
srhines added a reviewer: kristof.beyls. srhines added a comment. Kristof, can you or someone at ARM (where this is clearly relevant) take a look here? The CL obviously looks fine to me, but I might not have all of the original context as to why this was so constrained to OpenCL. Thanks.

Re: [PATCH] D18363: Fix typo s/initalize/initialize/

2016-03-22 Thread Stephen Hines via cfe-commits
srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. I think this is trivial enough for me to accept. I also added cfe-commits, so that they at least have a chance to review/comment. Repository: rL LLVM http://reviews.llvm.org/D18363

[PATCH] D17874: Switch krait to use -mcpu=cortex-a15 for assembler tool invocations.

2016-03-03 Thread Stephen Hines via cfe-commits
srhines created this revision. srhines added reviewers: cfe-commits, weimingz. Herald added a subscriber: aemerson. Using -no-integrated-as causes -mcpu=krait to be transformed into -march=armv7-a today. This precludes the assembler from using instructions like sdiv, which are present for krait.

r262742 - Switch krait to use -mcpu=cortex-a15 for assembler tool invocations.

2016-03-04 Thread Stephen Hines via cfe-commits
Author: srhines Date: Fri Mar 4 14:57:22 2016 New Revision: 262742 URL: http://llvm.org/viewvc/llvm-project?rev=262742=rev Log: Switch krait to use -mcpu=cortex-a15 for assembler tool invocations. Summary: Using -no-integrated-as causes -mcpu=krait to be transformed into -march=armv7-a today.

Re: [PATCH] D17874: Switch krait to use -mcpu=cortex-a15 for assembler tool invocations.

2016-03-04 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL262742: Switch krait to use -mcpu=cortex-a15 for assembler tool invocations. (authored by srhines). Changed prior to commit: http://reviews.llvm.org/D17874?vs=49791=49844#toc Repository: rL LLVM

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-21 Thread Stephen Hines via cfe-commits
srhines added inline comments. Comment at: clang-tidy/ClangTidy.cpp:61 @@ -60,3 +60,3 @@ FULLNAME, -#include "../../../lib/StaticAnalyzer/Checkers/Checkers.inc" +#include "Checkers.inc" #undef CHECKER alexfh wrote: > As it is, the change leaves almost no

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-27 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267835: Fix include path in ClangTidy.cpp. (authored by srhines). Changed prior to commit: http://reviews.llvm.org/D19249?vs=54587=55368#toc Repository: rL LLVM http://reviews.llvm.org/D19249

[clang-tools-extra] r267835 - Fix include path in ClangTidy.cpp.

2016-04-27 Thread Stephen Hines via cfe-commits
Author: srhines Date: Wed Apr 27 20:42:12 2016 New Revision: 267835 URL: http://llvm.org/viewvc/llvm-project?rev=267835=rev Log: Fix include path in ClangTidy.cpp. Summary: https://llvm.org/bugs/show_bug.cgi?id=27355 To compile with other binary output directory structures in build systems like

Re: [PATCH] D19393: Move Checkers.inc to clang/include/.../Checkers

2016-04-21 Thread Stephen Hines via cfe-commits
srhines added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/CMakeLists.txt:3 @@ +2,3 @@ + -I ${CMAKE_CURRENT_SOURCE_DIR}/../../../ + SOURCE ../../../../lib/StaticAnalyzer/Checkers/Checkers.td + TARGET ClangSACheckers) Anna should probably

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

2016-05-24 Thread Stephen Hines via cfe-commits
srhines added a comment. In http://reviews.llvm.org/D20602#438528, @rsmith wrote: > Looks like this extension was added at some point between 1.1 and 2.1. It > would make sense to produce an `ExtWarn` for it if the OpenCL standard > version is less than the one that introduced it (whenever

r266840 - MarkEOLs should only be true for clang-cl.exe.

2016-04-19 Thread Stephen Hines via cfe-commits
Author: srhines Date: Tue Apr 19 19:33:06 2016 New Revision: 266840 URL: http://llvm.org/viewvc/llvm-project?rev=266840=rev Log: MarkEOLs should only be true for clang-cl.exe. Summary: https://llvm.org/bugs/show_bug.cgi?id=27396 This fixes an issue in response files where "\r\n" was being

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

2016-09-13 Thread Stephen Hines via cfe-commits
srhines added a comment. My comment is mostly naming considerations to improve clarity. I do have concerns though about the unhandled else path. Comment at: lib/Sema/SemaChecking.cpp:3842 @@ -3841,2 +3841,3 @@ -static void CheckFormatString(Sema , const StringLiteral *FExpr,

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

2016-09-14 Thread Stephen Hines via cfe-commits
srhines added a comment. I will take care of submitting this. Thanks for the reviews everybody! https://reviews.llvm.org/D23820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

2016-09-14 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281527: Do not warn about format strings that are indexed string literals. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D23820?vs=71286=71416#toc Repository: rL LLVM

r281527 - Do not warn about format strings that are indexed string literals.

2016-09-14 Thread Stephen Hines via cfe-commits
Author: srhines Date: Wed Sep 14 15:05:20 2016 New Revision: 281527 URL: http://llvm.org/viewvc/llvm-project?rev=281527=rev Log: Do not warn about format strings that are indexed string literals. Summary: The warning for a format string not being a sting literal and therefore being potentially

[PATCH] D24579: Revert "Do not warn about format strings that are indexed string literals."

2016-09-14 Thread Stephen Hines via cfe-commits
srhines created this revision. srhines added a subscriber: cfe-commits. This reverts r281527 because I messed up the attribution. https://reviews.llvm.org/D24579 Files: lib/Sema/SemaChecking.cpp test/Sema/format-strings.c Index: test/Sema/format-strings.c

Re: [PATCH] D24579: Revert "Do not warn about format strings that are indexed string literals."

2016-09-14 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281530: Revert "Do not warn about format strings that are indexed string literals." (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D24579?vs=71417=71419#toc Repository: rL

r281294 - clang-format: Add Java detection to git-clang-format.

2016-09-12 Thread Stephen Hines via cfe-commits
Author: srhines Date: Tue Sep 13 00:00:20 2016 New Revision: 281294 URL: http://llvm.org/viewvc/llvm-project?rev=281294=rev Log: clang-format: Add Java detection to git-clang-format. Summary: This change adds "java" to the list of known extensions that clang-format supports. Patch by Luis

Re: [PATCH] D24401: clang-format: Add Java detection to git-clang-format.

2016-09-12 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281294: clang-format: Add Java detection to git-clang-format. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D24401?vs=71104=71107#toc Repository: rL LLVM

r281686 - Do not warn about format strings that are indexed string literals.

2016-09-15 Thread Stephen Hines via cfe-commits
Author: srhines Date: Thu Sep 15 20:07:04 2016 New Revision: 281686 URL: http://llvm.org/viewvc/llvm-project?rev=281686=rev Log: Do not warn about format strings that are indexed string literals. Summary: The warning for a format string not being a string literal and therefore being potentially

Re: [PATCH] D24584: Do not warn about format strings that are indexed string literals.

2016-09-15 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281686: Do not warn about format strings that are indexed string literals. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D24584?vs=71585=71586#toc Repository: rL LLVM

[PATCH] D24648: Fix unused result from sign extending an Offset.

2016-09-16 Thread Stephen Hines via cfe-commits
srhines created this revision. srhines added a reviewer: cfe-commits. srhines added a subscriber: meikeb. Offset was doubled in size, but the assignment was missing. We just need to reassign to the original variable in this case to fix it. https://reviews.llvm.org/D24648 Files:

Re: [PATCH] D24648: Fix unused result from sign extending an Offset.

2016-09-16 Thread Stephen Hines via cfe-commits
be marked WARN_UNUSED_RESULT > > > On Thursday, September 15, 2016, Stephen Hines via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> srhines created this revision. >> srhines added a reviewer: cfe-commits. >> srhines added a subscriber: meikeb. >

r281706 - Fix unused result from sign extending an Offset.

2016-09-16 Thread Stephen Hines via cfe-commits
Author: srhines Date: Fri Sep 16 02:21:24 2016 New Revision: 281706 URL: http://llvm.org/viewvc/llvm-project?rev=281706=rev Log: Fix unused result from sign extending an Offset. Summary: Offset was doubled in size, but the assignment was missing. We just need to reassign to the original variable

Re: [PATCH] D24648: Fix unused result from sign extending an Offset.

2016-09-16 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281706: Fix unused result from sign extending an Offset. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D24648?vs=71598=71599#toc Repository: rL LLVM

Re: [PATCH] D24319: clang-format: Add an option to git-clang-format to diff between to commits

2016-09-22 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282136: clang-format: Add an option to git-clang-format to diff between to commits (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D24319?vs=72064=72138#toc Repository: rL

r282136 - clang-format: Add an option to git-clang-format to diff between to commits

2016-09-22 Thread Stephen Hines via cfe-commits
Author: srhines Date: Thu Sep 22 00:52:55 2016 New Revision: 282136 URL: http://llvm.org/viewvc/llvm-project?rev=282136=rev Log: clang-format: Add an option to git-clang-format to diff between to commits Summary: When building pre-upload hooks using git-clang-format, it is useful to limit the

r285127 - Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

2016-10-25 Thread Stephen Hines via cfe-commits
Author: srhines Date: Tue Oct 25 16:44:35 2016 New Revision: 285127 URL: http://llvm.org/viewvc/llvm-project?rev=285127=rev Log: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation. Summary: This is only forced on if there is no non-Cortex-A53 CPU specified as well. Android's

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

2016-10-25 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285127: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D25761?vs=75174=75801#toc Repository: rL LLVM

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

2016-11-08 Thread Stephen Hines via cfe-commits
srhines added a comment. In https://reviews.llvm.org/D26385#589534, @danalbert wrote: > > This macro (along with ANDROID) should always be defined for Android > > targets. > > What if only `arm-linux-androideabi` (without a version) is specified? We > should be falling back to the old behavior

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

2016-11-08 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286295: Define __ANDROID_API__ for all Android builds. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D26385?vs=77236=77250#toc Repository: rL LLVM

r286295 - Define __ANDROID_API__ for all Android builds.

2016-11-08 Thread Stephen Hines via cfe-commits
Author: srhines Date: Tue Nov 8 15:23:26 2016 New Revision: 286295 URL: http://llvm.org/viewvc/llvm-project?rev=286295=rev Log: Define __ANDROID_API__ for all Android builds. Summary: Bug: https://llvm.org/bugs/show_bug.cgi?id=30940 This macro (along with __ANDROID__) should always be defined

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

2016-11-08 Thread Stephen Hines via cfe-commits
srhines added a comment. Ugh, phabricator dropped my updated commit message, so that is completely wrong now. Oh well. I guess I will just use repo/gerrit for staging things in the future (and get consensus there) before asking for any upstream reviews. Repository: rL LLVM

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

2016-11-08 Thread Stephen Hines via cfe-commits
srhines added a comment. In https://reviews.llvm.org/D26385#589589, @eugenis wrote: > This is a good change, but I don't think it is the right fix for PR30940. > Instead of handling this in the NDK, we should change *::getIRStackGuard to > fallback to __stack_chk_guard when targeting an old

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

2016-11-08 Thread Stephen Hines via cfe-commits
srhines updated this revision to Diff 77236. srhines added a comment. Switched to conditionally defining __ANDROID_API__ instead. https://reviews.llvm.org/D26385 Files: lib/Basic/Targets.cpp test/Driver/android-targets.cpp Index: test/Driver/android-targets.cpp

[PATCH] D26422: Revert "Define __ANDROID_API__ for all Android builds."

2016-11-08 Thread Stephen Hines via cfe-commits
srhines added a comment. Reverted because this broke builds: clang-hexagon-elf llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast clang-ppc64be-linux-multistage llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast It isn't clear from the logs why these builds failed, since I did a general build, but

[PATCH] D26422: Revert "Define __ANDROID_API__ for all Android builds."

2016-11-08 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286298: Revert "Define __ANDROID_API__ for all Android builds." (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D26422?vs=77254=77256#toc Repository: rL LLVM

[PATCH] D26422: Revert "Define __ANDROID_API__ for all Android builds."

2016-11-08 Thread Stephen Hines via cfe-commits
srhines created this revision. srhines added subscribers: danalbert, eugenis, pirama, cfe-commits. Herald added a subscriber: tberghammer. This reverts commit a8804ddd9fe71304b28e5b834d134fe93e568ee0. https://reviews.llvm.org/D26422 Files: lib/Basic/Targets.cpp

r286298 - Revert "Define __ANDROID_API__ for all Android builds."

2016-11-08 Thread Stephen Hines via cfe-commits
Author: srhines Date: Tue Nov 8 15:54:49 2016 New Revision: 286298 URL: http://llvm.org/viewvc/llvm-project?rev=286298=rev Log: Revert "Define __ANDROID_API__ for all Android builds." Summary: This reverts commit a8804ddd9fe71304b28e5b834d134fe93e568ee0. Subscribers: cfe-commits, pirama,

[PATCH] D26491: Define __ANDROID_API__ when specified as part of an Android target.

2016-11-09 Thread Stephen Hines via cfe-commits
srhines updated this revision to Diff 77446. srhines added a comment. Added bug link to commit message. https://reviews.llvm.org/D26491 Files: lib/Basic/Targets.cpp test/Preprocessor/init.c Index: test/Preprocessor/init.c

[PATCH] D26491: Define __ANDROID_API__ when specified as part of an Android target.

2016-11-09 Thread Stephen Hines via cfe-commits
srhines created this revision. srhines added subscribers: danalbert, eugenis, pirama, cfe-commits. Herald added a subscriber: tberghammer. This macro should be defined only when the user directly specifies an API level as part of an Android target. For any regular Android target, we leave this

[PATCH] D26385: Define __ANDROID_API__ for all Android builds.

2016-11-07 Thread Stephen Hines via cfe-commits
srhines created this revision. srhines added subscribers: danalbert, eugenis, pirama, cfe-commits. Herald added a subscriber: tberghammer. Bug: https://llvm.org/bugs/show_bug.cgi?id=30940 This macro (along with __ANDROID__) should always be defined for Android targets. We set it to the major

[PATCH] D26287: clang-format: Use git-ls-tree to get file mode in diff mode

2016-11-07 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286212: clang-format: Use git-ls-tree to get file mode in diff mode (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D26287?vs=76878=77142#toc Repository: rL LLVM

r286212 - clang-format: Use git-ls-tree to get file mode in diff mode

2016-11-07 Thread Stephen Hines via cfe-commits
Author: srhines Date: Mon Nov 7 23:50:14 2016 New Revision: 286212 URL: http://llvm.org/viewvc/llvm-project?rev=286212=rev Log: clang-format: Use git-ls-tree to get file mode in diff mode Summary: If a file has been renamed/deleted from the filesystem and --diff mode with two commits is active,

r286543 - Define __ANDROID_API__ when specified as part of an Android target.

2016-11-10 Thread Stephen Hines via cfe-commits
Author: srhines Date: Thu Nov 10 19:29:39 2016 New Revision: 286543 URL: http://llvm.org/viewvc/llvm-project?rev=286543=rev Log: Define __ANDROID_API__ when specified as part of an Android target. Summary: This macro should be defined only when the user directly specifies an API level as part of

[PATCH] D26491: Define __ANDROID_API__ when specified as part of an Android target.

2016-11-10 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286543: Define __ANDROID_API__ when specified as part of an Android target. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D26491?vs=77446=77578#toc Repository: rL LLVM

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

2016-10-19 Thread Stephen Hines via cfe-commits
srhines created this revision. srhines added a reviewer: cfe-commits. srhines added subscribers: danalbert, pirama. Herald added subscribers: tberghammer, rengolin, aemerson. This is only forced on if there is no non-Cortex-A53 CPU specified as well. Android's platform and NDK builds need to

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

2016-10-19 Thread Stephen Hines via cfe-commits
srhines added a comment. From what I can tell, there is no nice way to generate tests for Clang's driver when producing linker flags. -### only works for the -cc1 command line (which won't see this flag, since it is only for linking, and not compilation). If there is a suggestion for how to

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

2016-10-19 Thread Stephen Hines via cfe-commits
srhines added a comment. In https://reviews.llvm.org/D25761#573902, @rengolin wrote: > In https://reviews.llvm.org/D25761#573892, @srhines wrote: > > > From what I can tell, there is no nice way to generate tests for Clang's > > driver when producing linker flags. -### only works for the -cc1

[PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

2016-10-19 Thread Stephen Hines via cfe-commits
srhines added a comment. This looks good to me, but I would prefer if one of the more experienced Clang folks could officially LGTM this. Thanks. https://reviews.llvm.org/D24010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25928: [cfi] Enable cfi-icall on ARM and AArch64.

2016-10-25 Thread Stephen Hines via cfe-commits
srhines accepted this revision. srhines added a reviewer: srhines. srhines added a comment. This revision is now accepted and ready to land. Looks good for the Android side. Repository: rL LLVM https://reviews.llvm.org/D25928 ___ cfe-commits

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

2016-10-19 Thread Stephen Hines via cfe-commits
srhines updated this revision to Diff 75174. srhines added a comment. Added a test for this behavior. I missed that "-### -v" was actually working correctly last night. Tests added so I am more satisfied that this won't break accidentally in the future. https://reviews.llvm.org/D25761 Files:

[PATCH] D24933: Enable configuration files in clang

2016-11-18 Thread Stephen Hines via cfe-commits
srhines added a comment. Thanks to Hans for notifying me about this. Cross-compilation flags are a big challenge in Android, but I have similar concerns about looking for magic files/dirs. Richard's suggestion about improving @file is really interesting, and would satisfy a large part of our

[PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

2016-10-31 Thread Stephen Hines via cfe-commits
srhines added a comment. Ping. Other developers (Firefox) are now starting to hit this issue. https://reviews.llvm.org/D24010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r310958 - Switch to consumeError(), since this can crash otherwise.

2017-08-15 Thread Stephen Hines via cfe-commits
Author: srhines Date: Tue Aug 15 14:20:41 2017 New Revision: 310958 URL: http://llvm.org/viewvc/llvm-project?rev=310958=rev Log: Switch to consumeError(), since this can crash otherwise. Summary: If assertions are disabled, but LLVM_ABI_BREAKING_CHANGES is enabled, this will cause an issue with

Re: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

2017-08-24 Thread Stephen Hines via cfe-commits
This change seems to have broken the git mirrors, as I can no longer check out clang without having a merge conflict as git alters the line endings. Setting core.autocrlf to false doesn't help either. Does anyone have any idea how to fix this svn <-> git issue? Thanks, Steve On Thu, Aug 24, 2017

Re: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

2017-08-24 Thread Stephen Hines via cfe-commits
Ah, sorry I had to run off for a meeting. Yes, I was able to finally fix this. For anyone else who hits it, you can "git reset --hard" back to the CL before the initial change. Then you can "git pull" to move past the issue. Thanks for fixing this. Steve On Thu, Aug 24, 2017 at 4:35 PM, Keane,

r342165 - Support -fno-omit-frame-pointer with -pg.

2018-09-13 Thread Stephen Hines via cfe-commits
Author: srhines Date: Thu Sep 13 12:50:02 2018 New Revision: 342165 URL: http://llvm.org/viewvc/llvm-project?rev=342165=rev Log: Support -fno-omit-frame-pointer with -pg. Summary: Previously, any instance of -fomit-frame-pointer would make it such that -pg was an invalid flag combination. If

r342501 - Fix logic around determining use of frame pointer with -pg.

2018-09-18 Thread Stephen Hines via cfe-commits
Author: srhines Date: Tue Sep 18 11:34:33 2018 New Revision: 342501 URL: http://llvm.org/viewvc/llvm-project?rev=342501=rev Log: Fix logic around determining use of frame pointer with -pg. Summary: As part of r342165, I rewrote the logic to check whether -fno-omit-frame-pointer was passed after

Re: r342501 - Fix logic around determining use of frame pointer with -pg.

2018-09-18 Thread Stephen Hines via cfe-commits
; > "/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/test/Driver" > "-fstack-size-section" "-ferror-limit" "19" "-fmessage-length" "0" "-pg" > "-stack-protector" "

Re: r342501 - Fix logic around determining use of frame pointer with -pg.

2018-09-18 Thread Stephen Hines via cfe-commits
lave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/test/Driver" >> "-fstack-size-section" "-ferror-limit" "19" "-fmessage-length" "0" "-pg" >> "-stack-protector" "2" "-f

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

2019-04-04 Thread Stephen Hines via cfe-commits
ce/clang-stage1-cmake-RA-incremental/clang-build/lib/clang/9.0.0" >> "-fdebug-compilation-dir" >> "/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/clang-build/tools/clang/test/Driver" >> "-ferror-limit" "19" "-fmessa

r357713 - Verify that Android targets generate DWARF 4 by default.

2019-04-04 Thread Stephen Hines via cfe-commits
Author: srhines Date: Thu Apr 4 11:17:46 2019 New Revision: 357713 URL: http://llvm.org/viewvc/llvm-project?rev=357713=rev Log: Verify that Android targets generate DWARF 4 by default. Summary: In the future, Android releases will support DWARF 5, but we need to ensure that older targets only

r353318 - Switch to cantFail(), since it does the same assertion.

2019-02-06 Thread Stephen Hines via cfe-commits
Author: srhines Date: Wed Feb 6 09:59:39 2019 New Revision: 353318 URL: http://llvm.org/viewvc/llvm-project?rev=353318=rev Log: Switch to cantFail(), since it does the same assertion. Reviewers: cfe-commits, lhames Reviewed By: lhames Subscribers: hintonda, klimek, pirama Differential