Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

ahatanak added a comment. In http://reviews.llvm.org/D11815#236368, @vkalintiris wrote: > In http://reviews.llvm.org/D11815#235394, @ahatanak wrote: > > > > > For example, on a Mips target, where the O32 ABI requires either way an > 8-byte alignment, we would generate redundant code for

Re: r246548 - Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++.

On Tue, Sep 1, 2015 at 12:43 PM, Renato Golin wrote: > On 1 September 2015 at 15:49, Aaron Ballman via cfe-commits > wrote: >> Author: aaronballman >> Date: Tue Sep 1 09:49:24 2015 >> New Revision: 246548 >> >> URL:

[clang-tools-extra] r246575 - Add \n to the regex in clang-tidy-diff.py in order to fix http://llvm.org/PR24637,

Author: yrnkrn Date: Tue Sep 1 14:08:17 2015 New Revision: 246575 URL: http://llvm.org/viewvc/llvm-project?rev=246575=rev Log: Add \n to the regex in clang-tidy-diff.py in order to fix http://llvm.org/PR24637, git usecase for multiple files diff. Modified:

r246565 - Pull initFeatureMap out of line now that it's used in multiple places.

Author: echristo Date: Tue Sep 1 13:13:20 2015 New Revision: 246565 URL: http://llvm.org/viewvc/llvm-project?rev=246565=rev Log: Pull initFeatureMap out of line now that it's used in multiple places. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/lib/Basic/TargetInfo.cpp

Re: [clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

Hi, In the other thread (search for ... 0ca9a2b from bartek-w) he provided a regex with two more changes beyond adding \n. Here are all three regexes: pre-r245683 match = re.search('^\+\+\+\ (.*?/){%s}(\S*)' % args.p, line) r245683 match = re.search('^\+\+\+\ \"?(.*?/){%s}([^ \t\"]*)' %

Re: [PATCH] D12453: [CUDA] Allow function overloads based on host/device attributes.

eliben accepted this revision. eliben added a comment. This revision is now accepted and ready to land. The CUDA parts look very good. Someone else should approve the overloading-related logic Comment at: include/clang/Sema/Sema.h:8605 @@ +8604,3 @@ + + CUDAFunctionPreference

Re: r246534 - [modules] When emitting line tables, only emit filenames that are actually referenced by the entries that we emit.

On Tue, Sep 1, 2015 at 1:12 AM, NAKAMURA Takumi wrote: > FYI, > > MultiOnDiskHashTable.h:108 delete T; > It is crashing. > > Modules/cxx-templates.cpp can fail if target is i686-pc-win32. > Does this happen when building with Clang, or just when building with MSVC?

Re: r246546 - Reverting r246497 (which requires also reverting r246524 and r246521 to avoid merge conflicts). It broke the build on MSVC 2015. It also broke an MSVC 2013 bot with testing issues.

Thanks! 2015-09-01 16:24 GMT+03:00 Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org>: > Author: aaronballman > Date: Tue Sep 1 08:24:39 2015 > New Revision: 246546 > > URL: http://llvm.org/viewvc/llvm-project?rev=246546=rev > Log: > Reverting r246497 (which requires also reverting

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

yiranwang added a comment. Thanks for testing. There is proof as the following, given that alignment of _Aligner is _Align (the whole purpose of _Aligner here, which we do not want to double check), and for any type, the "sizeof" is always multiple of "alignof", this change should be ABI

r246573 - Fix typo in test

Author: eliben Date: Tue Sep 1 13:56:19 2015 New Revision: 246573 URL: http://llvm.org/viewvc/llvm-project?rev=246573=rev Log: Fix typo in test Modified: cfe/trunk/test/Preprocessor/init.c Modified: cfe/trunk/test/Preprocessor/init.c URL:

Re: r246548 - Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++.

On 1 September 2015 at 18:15, Aaron Ballman wrote: > It seems unlikely as this shouldn't effect codegen. None of the other > bots seem to be red because it either. FWIW, my tests were 32-bit x86 > on Windows 10 with MSVC 2015. Ok, I cleared the stage2 build directory,

Re: [PATCH] D11664: [CUDA] Implemented additional processing steps needed to link with CUDA libdevice bitcode.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. The ternary is a bit ugly, but LGTM. :) -eric http://reviews.llvm.org/D11664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

sfantao added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:702 @@ +701,3 @@ + return true; +} + } Alexey, after rebasing this patch with the latest changes, I started having a regression related with how `DSAStack->hasDirective` works. In my

Re: [PATCH] D12381: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type Propagation checker.

xazax.hun marked an inline comment as not done. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:81 @@ +80,3 @@ +initBugType(); +SmallString<64> Buf; +llvm::raw_svector_ostream OS(Buf); zaks.anna wrote: > How do we know that the

Re: [PATCH] D11664: [CUDA] Implemented additional processing steps needed to link with CUDA libdevice bitcode.

tra updated the summary for this revision. tra updated this revision to Diff 33713. tra added a comment. Updated the patch to use bitcode linker to perform selective linking and internalizing. Removed Internalize+GDCE passes. http://reviews.llvm.org/D11664 Files:

Re: r246548 - Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++.

On Tue, Sep 1, 2015 at 2:10 PM, Renato Golin wrote: > On 1 September 2015 at 18:17, Renato Golin wrote: >> Ok, I cleared the stage2 build directory, let's see how this build goes... >> >>

Re: r246548 - Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++.

On 1 September 2015 at 19:23, Aaron Ballman wrote: > On Tue, Sep 1, 2015 at 2:10 PM, Renato Golin wrote: >> On 1 September 2015 at 18:17, Renato Golin wrote: >>> Ok, I cleared the stage2 build directory, let's see how

Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

sfantao updated this revision to Diff 33712. sfantao added a comment. Rebase on top of the last changes in http://reviews.llvm.org/D11361. http://reviews.llvm.org/D12262 Files: include/clang/Basic/OpenMPKinds.h include/clang/Sema/Sema.h lib/Basic/OpenMPKinds.cpp lib/Sema/SemaExpr.cpp

Re: r246548 - Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++.

On 1 September 2015 at 18:17, Renato Golin wrote: > Ok, I cleared the stage2 build directory, let's see how this build goes... > > http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost-neon/builds/3248 Nah, there is something definitely wrong with that. I'll

r246534 - [modules] When emitting line tables, only emit filenames that are actually referenced by the entries that we emit.

Author: rsmith Date: Tue Sep 1 02:41:55 2015 New Revision: 246534 URL: http://llvm.org/viewvc/llvm-project?rev=246534=rev Log: [modules] When emitting line tables, only emit filenames that are actually referenced by the entries that we emit. Modified:

[PATCH] D12547: Add support for function attribute "disable_tail_calls"

ahatanak created this revision. ahatanak added a subscriber: cfe-commits. There have been requests for a function attribute that disables tail call optimizations in the backend. This patch defines such an attribute. http://reviews.llvm.org/D12547 Files: include/clang/Basic/Attr.td

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

mzolotukhin added a comment. Gentle ping. http://reviews.llvm.org/D12313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

mclow.lists updated this revision to Diff 33770. mclow.lists added a comment. Updated based on Eric's comments. http://reviews.llvm.org/D11380 Files: include/experimental/functional test/std/experimental/algorithms/alg.search/search.pass.cpp

Re: [PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

mclow.lists marked 3 inline comments as done. mclow.lists added a comment. http://reviews.llvm.org/D11380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12444: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610)

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D12444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r246591 - [MS ABI] Switch to the CRC implementation in LLVM

Author: majnemer Date: Tue Sep 1 16:24:07 2015 New Revision: 246591 URL: http://llvm.org/viewvc/llvm-project?rev=246591=rev Log: [MS ABI] Switch to the CRC implementation in LLVM We now have an implementation of the CRC in LLVM's libSupport. Let's consolidate around that one. Modified:

r246595 - Use hasAttr, not getAttr if we're just checking for presence.

Author: echristo Date: Tue Sep 1 17:03:56 2015 New Revision: 246595 URL: http://llvm.org/viewvc/llvm-project?rev=246595=rev Log: Use hasAttr, not getAttr if we're just checking for presence. Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL:

Re: [PATCH] D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

pcc added a comment. It's probably time to add something like the driver test I was talking about in http://reviews.llvm.org/D12021. Without that, you will have no test coverage for the functional change here. http://reviews.llvm.org/D12544 ___

Re: [PATCH] D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

krasin updated this revision to Diff 33764. krasin added a comment. Add a test for default blacklist. http://reviews.llvm.org/D12544 Files: include/clang/Driver/Options.td include/clang/Driver/SanitizerArgs.h lib/Driver/SanitizerArgs.cpp lib/Frontend/CompilerInvocation.cpp

Re: [PATCH] D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

krasin added a comment. In http://reviews.llvm.org/D12544#237819, @pcc wrote: > It's probably time to add something like the driver test I was talking about > in http://reviews.llvm.org/D12021. Without that, you will have no test > coverage for the functional change here. Done, please, take

Re: r203885 - [Modules] Emit the module file paths as dependencies of the PCH when we are building one.

(Apologies for the long delay). > On Aug 8, 2015, at 6:30 PM, Richard Smith wrote: > > On Thu, Mar 13, 2014 at 8:07 PM, Argyrios Kyrtzidis > wrote: > Author: akirtzidis > Date: Thu Mar 13 22:07:38 2014 > New Revision: 203885

Re: [PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

Prazek marked 3 inline comments as done. Comment at: lib/CodeGen/CGClass.cpp:1279 @@ +1278,3 @@ + if (CGM.getCodeGenOpts().StrictVPtrs && BaseVPtrsInitialized) +CXXThisValue = Builder.CreateInvariantGroupBarrier(LoadCXXThis()); + rjmccall wrote: > Prazek

Re: [PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

Prazek updated the summary for this revision. Prazek updated this revision to Diff 33775. http://reviews.llvm.org/D12312 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGClass.cpp lib/CodeGen/CGExprCXX.cpp lib/Driver/Tools.cpp

Re: [PATCH] D12444: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610)

This revision was automatically updated to reflect the committed changes. Closed by commit rL246618: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610) (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D12444?vs=33623=33777#toc Repository: rL LLVM

r246618 - [Sema] Avoid crash on tag-type mismatch (Fixes PR24610)

Author: vedantk Date: Tue Sep 1 22:27:15 2015 New Revision: 246618 URL: http://llvm.org/viewvc/llvm-project?rev=246618=rev Log: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610) Differential Revision: http://reviews.llvm.org/D12444 Modified: cfe/trunk/lib/Sema/SemaDecl.cpp

r246610 - Migrate the target attribute parsing code into an extension off of

Author: echristo Date: Tue Sep 1 19:12:02 2015 New Revision: 246610 URL: http://llvm.org/viewvc/llvm-project?rev=246610=rev Log: Migrate the target attribute parsing code into an extension off of the main attribute and cache the results so we don't have to parse a single attribute more than

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis marked 2 inline comments as done. eugenis added a comment. Repository: rL LLVM http://reviews.llvm.org/D12087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM with nit. Comment at: test/Driver/fsanitize-blacklist.c:25 @@ -18,1 +24,3 @@ +// CHECK-DEFAULT-BLACKLIST: -fsanitize-blacklist={{.*}}asan_blacklist.txt +//

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

nmusgrave added inline comments. Comment at: lib/CodeGen/CGCXX.cpp:42-44 @@ -33,1 +41,5 @@ bool CodeGenModule::TryEmitBaseDestructorAsAlias(const CXXDestructorDecl *D) { + // If sanitizing memory to check for use-after-dtor, do not emit as + // an alias, unless it has no

Re: [clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

Thank you for the update! On 1 Sep 2015 21:10, "Yaron Keren" wrote: > Hi, > > In the other thread (search for ... 0ca9a2b from bartek-w) he provided a > regex with two more changes beyond adding \n. > Here are all three regexes: > > pre-r245683 > match =

r246582 - Re-commit r246497 (and dependent changes r246524 and r246521), reverted in

Author: rsmith Date: Tue Sep 1 15:35:42 2015 New Revision: 246582 URL: http://llvm.org/viewvc/llvm-project?rev=246582=rev Log: Re-commit r246497 (and dependent changes r246524 and r246521), reverted in r246546, with a workaround for an MSVC 2013 miscompile and an MSVC 2015 rejects-valid.

Re: r246497 - [modules] Rework serialized DeclContext lookup table management. Instead of

On Tue, Sep 1, 2015 at 6:26 AM, Aaron Ballman wrote: > On Tue, Sep 1, 2015 at 4:43 AM, İsmail Dönmez > wrote: > > Hi, > > > > On Tue, Sep 1, 2015 at 1:17 AM, Richard Smith via cfe-commits > > wrote: > >> Author:

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:469-470 @@ +468,4 @@ + llvm::LLVMContext = getModule().getContext(); + llvm::Function *StubFn = + llvm::Function::Create(FT, Fn->getLinkage(), Name, ()); + assert(StubFn->getName() == Name && "name

Re: r246548 - Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++.

On 1 September 2015 at 20:09, Aaron Ballman wrote: > Like a parameter/local misalignment? Yes, I think due to placement new for inherited classes, ignoring the padding between the base class and the inherited extra. Anyway, it's not your commit, as I just got a failure

Re: Move createEliminateAvailableExternallyPass earlier

Hi Yaron, Thanks, moving it earlier in general seems ok to me. I originally put this right before the GlobalDCE calls because it was somewhat related. I wonder if the createEliminateAvailableExternallyPass call for the LTO pipeline should similarly be moved up closer to inlining, perhaps after

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev updated this revision to Diff 33740. http://reviews.llvm.org/D9040 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c === --- test/Analysis/malloc.c +++

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:166 @@ +165,3 @@ + /// report anything and turn off the check. + /// + /// When \p SuppressPath is set to true, no more bugs will be reported on this It is still

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:523 @@ -510,2 +522,3 @@ REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair) +REGISTER_MAP_WITH_PROGRAMSTATE(ReallocSizeZeroFlag, SymbolRef, ReallocSizeZero)

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:806 @@ -690,1 +805,3 @@ + ProgramStateRef State = C.getState(); + if (State->get()) zaks.anna wrote: > Maybe we should only check these at the time the bug is

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

xazax.hun updated this revision to Diff 33728. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. Style fixes according to the review. http://reviews.llvm.org/D12445 Files: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp test/Analysis/nullability.mm Index:

Re: [PATCH] D12453: [CUDA] Allow function overloads based on host/device attributes.

tra updated the summary for this revision. tra updated this revision to Diff 33741. tra marked an inline comment as done. tra added a comment. Removed builtin-related changes(http://reviews.llvm.org/D12122). Will commit them separately. Added more test cases. Addressed eliben@'s comments.

r246600 - Fix assertion failure in TransformOpaqueValueExpr

Author: hubert.reinterpretcast Date: Tue Sep 1 17:50:31 2015 New Revision: 246600 URL: http://llvm.org/viewvc/llvm-project?rev=246600=rev Log: Fix assertion failure in TransformOpaqueValueExpr Summary: `OpaqueValueExpr`s may not have a source expression (as in the case when they are created due

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev added a comment. Ping http://reviews.llvm.org/D9040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r246596 - Migrate the target attribute parsing code into an extension off of

Author: echristo Date: Tue Sep 1 17:03:58 2015 New Revision: 246596 URL: http://llvm.org/viewvc/llvm-project?rev=246596=rev Log: Migrate the target attribute parsing code into an extension off of the main attribute and cache the results so we don't have to parse a single attribute more than

r246589 - Make trunk release notes point to 3.7, not 3.6

Author: nico Date: Tue Sep 1 16:13:14 2015 New Revision: 246589 URL: http://llvm.org/viewvc/llvm-project?rev=246589=rev Log: Make trunk release notes point to 3.7, not 3.6 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:523 @@ -510,2 +522,3 @@ REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair) +REGISTER_MAP_WITH_PROGRAMSTATE(ReallocSizeZeroFlag, SymbolRef, ReallocSizeZero)

[PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

dougk created this revision. dougk added reviewers: jyknight, chandlerc. dougk added a subscriber: cfe-commits. Herald added a subscriber: jyknight. Rename SHAVE toolchain to Myriad toolchain. Run the Myriad linker whenever the vendor [sic] is Myriad. Also recognize RTEMS as the OS, and do

Move createEliminateAvailableExternallyPass earlier

Following the discussion on cfe-dev, this moves createEliminateAvailableExternallyPass earlier in the pass pipeline to save running many ModulePasses on available external functions that are thrown away anyhow. Index: lib/Transforms/IPO/PassManagerBuilder.cpp

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

rsmith added inline comments. Comment at: lib/CodeGen/CGCXX.cpp:42-44 @@ -33,1 +41,5 @@ bool CodeGenModule::TryEmitBaseDestructorAsAlias(const CXXDestructorDecl *D) { + // If sanitizing memory to check for use-after-dtor, do not emit as + // an alias, unless it has no fields

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

eugenis added a subscriber: eugenis. eugenis added a comment. This would greatly simplify the abi versioning change in http://reviews.llvm.org/D11740. Thanks for working on this! Comment at: include/CMakeLists.txt:24 @@ +23,3 @@ + -P

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

ABataev added a comment. Seems good to me, but it would be good if John McCall could look at the patch. http://reviews.llvm.org/D11361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r246534 - [modules] When emitting line tables, only emit filenames that are actually referenced by the entries that we emit.

Hi Richard, Since yesterday I see several clang test failures which *may* be related to the series of patches of modules you comitted. These are: Clang :: Modules/cxx-templates.cpp Clang :: Modules/submodules-merge-defs.cpp Clang :: PCH/cxx-key-functions.cpp

Re: r246534 - [modules] When emitting line tables, only emit filenames that are actually referenced by the entries that we emit.

FYI, MultiOnDiskHashTable.h:108 delete T; It is crashing. Modules/cxx-templates.cpp can fail if target is i686-pc-win32. On Tue, Sep 1, 2015 at 5:09 PM Yaron Keren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > Since yesterday I see several clang test failures

Re: r246497 - [modules] Rework serialized DeclContext lookup table management. Instead of

Hi, On Tue, Sep 1, 2015 at 1:17 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Mon Aug 31 17:17:11 2015 > New Revision: 246497 > > URL: http://llvm.org/viewvc/llvm-project?rev=246497=rev > Log: > [modules] Rework serialized DeclContext lookup table

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

joerg added a subscriber: joerg. joerg requested changes to this revision. joerg added a reviewer: joerg. joerg added a comment. This revision now requires changes to proceed. Please don't commit this as is. Many platforms have posix_memalign or equivalent, which makes this both simpler and

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

olista01 added a comment. Ping? http://reviews.llvm.org/D12148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

xazax.hun updated this revision to Diff 33704. xazax.hun added a comment. Made sure that inlined defensive checks do not generate false positives. http://reviews.llvm.org/D12445 Files: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp test/Analysis/nullability.mm Index:

r246548 - Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++.

Author: aaronballman Date: Tue Sep 1 09:49:24 2015 New Revision: 246548 URL: http://llvm.org/viewvc/llvm-project?rev=246548=rev Log: Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++. This corresponds to

Re: [PATCH] D12530: Fix several corner cases for loop-convert check.

angelgarcia marked 2 inline comments as done. Comment at: test/clang-tidy/modernize-loop-convert-basic.cpp:448 @@ +447,3 @@ +ret = it; + } +} klimek wrote: > This test seems to be missing the it.insert(0) case that was removed from the > "unsupported"

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

jroelofs added a comment. In http://reviews.llvm.org/D12512#236988, @majnemer wrote: > In http://reviews.llvm.org/D12512#236987, @EricWF wrote: > > > In http://reviews.llvm.org/D12512#236984, @majnemer wrote: > > > > > Wouldn't this change be problematic if you threw to code which was > > >

[clang-tools-extra] r246550 - Fix several corner cases for loop-convert check.

Author: angelgarcia Date: Tue Sep 1 10:05:15 2015 New Revision: 246550 URL: http://llvm.org/viewvc/llvm-project?rev=246550=rev Log: Fix several corner cases for loop-convert check. Summary: Reduced the amount of wrong conversions of this check. Reviewers: klimek Subscribers: alexfh,

Re: [PATCH] D12530: Fix several corner cases for loop-convert check.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Learned that I need to learn to read, because the deleted comment was just duplicated. Looks good, great first step towards making this significantly more useful :)

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've made those changes and commit in r246548, along with an updated test case for ObjC++ that I had previously missed. http://reviews.llvm.org/D12301 ___ cfe-commits

Re: [PATCH] D12530: Fix several corner cases for loop-convert check.

klimek added a comment. Nice! Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:378 @@ +377,3 @@ + for (const auto : Usages) { +if (!U.E->isRValue()) + return false; (not necessarily in this CL) please rename E to Expression or similar; I'm fine

r246546 - Reverting r246497 (which requires also reverting r246524 and r246521 to avoid merge conflicts). It broke the build on MSVC 2015. It also broke an MSVC 2013 bot with testing issues.

Author: aaronballman Date: Tue Sep 1 08:24:39 2015 New Revision: 246546 URL: http://llvm.org/viewvc/llvm-project?rev=246546=rev Log: Reverting r246497 (which requires also reverting r246524 and r246521 to avoid merge conflicts). It broke the build on MSVC 2015. It also broke an MSVC 2013 bot

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

jmolloy added a comment. This looks alright to me, but I'd like to wait for someone more familiar with Clang to approve it. http://reviews.llvm.org/D12148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

Looks like this patch broke handling of multiple files: https://llvm.org/PR24637 Can you take a look at this? On Fri, Aug 21, 2015 at 12:56 PM, Yaron Keren wrote: > Whenever is any special character in the filename, such as space or > backslash (Windows), some examples: