Re: [PATCH][Solaris] Default to -fno-cxa-finalize

2015-09-05 Thread Saleem Abdulrasool via cfe-commits
On Fri, Sep 4, 2015 at 1:11 AM, Xan López via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote: > > There is no __cxa_finalize symbol available on recent Solaris OS > > versions, so we need this flag to make non trivial

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

2015-09-05 Thread Joerg Sonnenberger via cfe-commits
On Fri, Sep 04, 2015 at 09:28:39PM +, Eric Fiselier via cfe-commits wrote: > EricWF added a comment. > > In http://reviews.llvm.org/D12512#237175, @joerg wrote: > > > Please don't commit this as is. Many platforms have posix_memalign or > > equivalent, which makes this both simpler and

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

2015-09-05 Thread Dan Albert via cfe-commits
danalbert added a comment. Android has posix_memalign too. http://reviews.llvm.org/D12512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

2015-09-05 Thread Dan Albert via cfe-commits
Android has posix_memalign too. On Sep 5, 2015 12:00, "Joerg Sonnenberger" wrote: > On Fri, Sep 04, 2015 at 09:28:39PM +, Eric Fiselier via cfe-commits > wrote: > > EricWF added a comment. > > > > In http://reviews.llvm.org/D12512#237175, @joerg wrote: > > > > >

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

2015-09-05 Thread Joerg Sonnenberger via cfe-commits
On Sat, Sep 05, 2015 at 07:29:43PM +, Dan Albert via cfe-commits wrote: > danalbert added a comment. > > Android has posix_memalign too. Yes, but people seem to be reluctant to use it. See the linked review. Joerg ___ cfe-commits mailing list

Re: [PATCH] D11781: Refactored pthread usage in libcxx

2015-09-05 Thread Fulvio Esposito via cfe-commits
espositofulvio updated the summary for this revision. espositofulvio updated this revision to Diff 34104. espositofulvio added a comment. - Addressed possible ABI breaks - Reverted to not using a __config_file as @jroelofs has two separate patch for that Repository: rL LLVM

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

2015-09-05 Thread Piotr Dziwinski via cfe-commits
piotrdz updated this revision to Diff 34113. piotrdz marked 6 inline comments as done. piotrdz added a comment. I addressed all latest review issues. http://reviews.llvm.org/D12462 Files: clang-tidy/readability/CMakeLists.txt

Re: [PATCH] D12664: Fixed comparison.

2015-09-05 Thread James Touton via cfe-commits
jtouton added a comment. Added cfe-commits. http://reviews.llvm.org/D12664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

2015-09-05 Thread Tobias Langner via cfe-commits
randomcppprogrammer added a reviewer: aaron.ballman. randomcppprogrammer updated this revision to Diff 34111. randomcppprogrammer added a comment. Updated check according to comments given by Aaron Ballman. Most notable change: added optional check for throwing anonmyous temporaries.