Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

2015-10-12 Thread Elena Demikhovsky via cfe-commits
delena added a comment. Do you need to add some tests for clang? Repository: rL LLVM http://reviews.llvm.org/D13014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13546: [ATTR] Automatic line feed after pragma-like attribute.

2015-10-12 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250017: [ATTR] Automatic line feed after pragma-like attribute. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D13546?vs=36924=37080#toc Repository: rL LLVM

r250017 - [ATTR] Automatic line feed after pragma-like attribute.

2015-10-12 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Oct 12 01:59:48 2015 New Revision: 250017 URL: http://llvm.org/viewvc/llvm-project?rev=250017=rev Log: [ATTR] Automatic line feed after pragma-like attribute. Automatically insert line feed after pretty printing of all pragma-like attributes + fix printing of

[PATCH] D13643: [Sema] Warn on ternary comparison

2015-10-12 Thread Matěj Grabovský via cfe-commits
mgrabovsky created this revision. mgrabovsky added a subscriber: cfe-commits. This change adds a Sema diagnostic for comparisons like `a < b < c`, which usually do not behave as intended by the author. Fixes bug 20082. http://reviews.llvm.org/D13643 Files:

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

2015-10-12 Thread Nicholas Allegra via cfe-commits
comex added a comment. Ping again. http://reviews.llvm.org/D12686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13582: [DEBUG INFO] Emit debug info for type used in explicit cast only.

2015-10-12 Thread Bataev, Alexey via cfe-commits
Yes, revision 246985 broke th debug info for types in explicit casts. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 09.10.2015 18:26, David Blaikie пишет: On

Re: [PATCH] D13639: Add decayedType and hasDecayedType AST matchers

2015-10-12 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius updated this revision to Diff 37081. curdeius added a comment. Fix description formatting. http://reviews.llvm.org/D13549 Files: lib/Driver/Tools.cpp tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs tools/clang-format-vs/ClangFormat/Properties/AssemblyInfo.cs

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius added inline comments. Comment at: lib/Driver/Tools.cpp:2356 @@ -2355,3 +2355,3 @@ CmdArgs.push_back( -Args.MakeArgString("-dwarf-version=" + llvm::itostr(DwarfVersion))); +Args.MakeArgString("-dwarf-version=" + Twine(DwarfVersion))); }

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius updated this revision to Diff 37086. curdeius added a comment. Escape only '<' and '&'. Remove unrelated changes from the revision. http://reviews.llvm.org/D13549 Files: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186 @@ -145,1 +185,3 @@ +if (!string.IsNullOrEmpty(assumeFilename)) + process.StartInfo.Arguments += " -assume-filename \"" + assumeFilename + "\"";

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: lib/Driver/Tools.cpp:2356 @@ -2355,3 +2355,3 @@ CmdArgs.push_back( -Args.MakeArgString("-dwarf-version=" + llvm::itostr(DwarfVersion))); +Args.MakeArgString("-dwarf-version=" + Twine(DwarfVersion))); }

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186 @@ -145,1 +185,3 @@ +if (!string.IsNullOrEmpty(assumeFilename)) + process.StartInfo.Arguments += " -assume-filename \"" + assumeFilename + "\"";

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius updated this revision to Diff 37087. curdeius marked 2 inline comments as done. curdeius added a comment. Add FIXME comment. http://reviews.llvm.org/D13549 Files: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs tools/clang-format-vs/ClangFormat/Properties/AssemblyInfo.cs

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186 @@ -145,1 +185,3 @@ +if (!string.IsNullOrEmpty(assumeFilename)) + process.StartInfo.Arguments += " -assume-filename \"" + assumeFilename + "\"";

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: tools/clang-format/ClangFormat.cpp:227 @@ -213,1 +226,3 @@ + llvm::outs() << ""; + break; default: curdeius wrote: > klimek wrote: > > For XML, we should only need "<" and "&". Everything else is just

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius marked 3 inline comments as done. curdeius added a comment. Applied suggestions from comments. http://reviews.llvm.org/D13549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

2015-10-12 Thread Sean Eveson via cfe-commits
seaneveson updated this revision to Diff 37084. seaneveson added a comment. Updated to latest trunk Replaced some code with an existing method: ignoreParenBaseCasts() Could someone commit this for me as I don't have SVN access? Thank you. http://reviews.llvm.org/D13099 Files:

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186 @@ -145,1 +185,3 @@ +if (!string.IsNullOrEmpty(assumeFilename)) + process.StartInfo.Arguments += " -assume-filename \"" + assumeFilename + "\"";

Re: [PATCH] D13658: [VFS] Let the user decide if they want path normalization.

2015-10-12 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: include/clang/Basic/VirtualFileSystem.h:282 @@ -280,2 +281,3 @@ /// Add a buffer to the VFS with a path. The VFS owns the buffer. - void addFile(const

[PATCH] D13658: [VFS] Let the user decide if they want path normalization.

2015-10-12 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This is a more principled version of what I did earlier. Path normalization is generally a good thing, but may break users in strange environments, e. g. using lots of symlinks. Let the user

Re: [PATCH] D13658: [VFS] Let the user decide if they want path normalization.

2015-10-12 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250060: [VFS] Let the user decide if they want path normalization. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D13658?vs=37124=37125#toc Repository: rL LLVM

r250060 - [VFS] Let the user decide if they want path normalization.

2015-10-12 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 12 11:16:39 2015 New Revision: 250060 URL: http://llvm.org/viewvc/llvm-project?rev=250060=rev Log: [VFS] Let the user decide if they want path normalization. This is a more principled version of what I did earlier. Path normalization is generally a good thing, but may

Re: [PATCH] D13304: Avoid inlining in throw statement

2015-10-12 Thread Jun Bum Lim via cfe-commits
junbuml added a comment. Just want to hear if there is any opinion about moving this implementation back to PrunceEH.cpp like http://reviews.llvm.org/D12979 and adding the minimum callee size check to avoid marking noinlines on trivial constrictor calls. Please let me know any objection or

Re: r248949 - Don't inherit availability information when implementing a protocol requirement.

2015-10-12 Thread Hans Wennborg via cfe-commits
On Fri, Oct 9, 2015 at 9:10 PM, Douglas Gregor wrote: > > > Sent from my iPhone > >> On Oct 9, 2015, at 2:17 PM, Hans Wennborg wrote: >> >>> On Fri, Oct 9, 2015 at 1:46 PM, Douglas Gregor wrote: >>> On Oct 7, 2015, at 11:55 AM, Hans

Re: [libcxx] r249798 - Split out of .

2015-10-12 Thread Steven Wu via cfe-commits
Hi Richard Your splitting seems causing problem when using extern "C". Here is a test case: $ cat test.cpp #ifdef __cplusplus extern "C" { #endif #include #ifdef __cplusplus } #endif Error: clang -fsyntax-only test.cpp In file included from test.cpp:4: In file included from

Re: [PATCH] D13399: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang

2015-10-12 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250064: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D13399?vs=36897=37127#toc Repository: rL

Re: [PATCH] D13658: [VFS] Let the user decide if they want path normalization.

2015-10-12 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:276 @@ -275,2 +275,3 @@ std::string WorkingDirectory; + bool UseNormalizedPaths; I'd use an in class initializer. Comment at:

Re: [PATCH] D13658: [VFS] Let the user decide if they want path normalization.

2015-10-12 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 37124. bkramer added a comment. Addressed review comments. http://reviews.llvm.org/D13658 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp Index:

Re: [PATCH] D13357: [Concepts] Add diagnostic; specializations of variable and function concepts

2015-10-12 Thread Nathan Wilson via cfe-commits
nwilson updated this revision to Diff 37099. nwilson added a comment. Moving tests to the correct file. Modifying the diagnostic id and message so it's more applicable to the checks in this Patch. Update the quoted sections of the standard as well. Use ternary operator for Partial Specialization

Re: [PATCH] D13620: Documentation for "Throw by value, catch by reference" check in clang-tidy

2015-10-12 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for doing this! http://reviews.llvm.org/D13620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13620: Documentation for "Throw by value, catch by reference" check in clang-tidy

2015-10-12 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. I have commit in r250034. I noticed that there was a missing reference to the new documentation in list.rst, so I went ahead and added that as part of your patch during the commit. http://reviews.llvm.org/D13620

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

2015-10-12 Thread Nathan Wilson via cfe-commits
nwilson marked 2 inline comments as done. Comment at: lib/Sema/SemaDecl.cpp:7886 @@ -7863,1 +7885,3 @@ + + if (NewFD->isInvalidDecl() && !NewFD->isConcept()) { HasExplicitTemplateArgs = false; Maybe there could be a problem further down if we think

r250037 - [VFS] Unbreak test.

2015-10-12 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 12 08:39:33 2015 New Revision: 250037 URL: http://llvm.org/viewvc/llvm-project?rev=250037=rev Log: [VFS] Unbreak test. Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp URL:

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius marked 5 inline comments as done. curdeius added a comment. Assume-Filename option will now give an error when there are quotes in the filename. http://reviews.llvm.org/D13549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius updated this revision to Diff 37115. curdeius added a comment. Add option converters for filenames (prohibiting quotes) and styles (giving a list of predefined styles). http://reviews.llvm.org/D13549 Files: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs

Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

2015-10-12 Thread Amjad Aboud via cfe-commits
aaboud updated this revision to Diff 37108. aaboud added a comment. Added two LIT tests to check the xsave intrinsic instructions. Repository: rL LLVM http://reviews.llvm.org/D13014 Files: include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuiltin.cpp lib/Headers/CMakeLists.txt

Re: r250036 - [VFS] Don't try to be heroic with '.' in paths.

2015-10-12 Thread Manuel Klimek via cfe-commits
I believe we need a more principled approach here :) 1. The first thing we need is to actually produce nice errors when we hit an addFile() with the same path (normalized or non-normalized) I'd propose the following approach: we compare the buffers; if the buffer contents are equal, we declare

r250043 - [Driver] Remove `else` after `return`

2015-10-12 Thread Simon Atanasyan via cfe-commits
Author: atanasyan Date: Mon Oct 12 09:32:57 2015 New Revision: 250043 URL: http://llvm.org/viewvc/llvm-project?rev=250043=rev Log: [Driver] Remove `else` after `return` Modified: cfe/trunk/lib/Driver/Multilib.cpp Modified: cfe/trunk/lib/Driver/Multilib.cpp URL:

RE: [Patch][OpenCL] Custom atomic Builtin check ignores address space of a non-atomic pointer

2015-10-12 Thread Anastasia Stulova via cfe-commits
I have just made one minor update in the CodeGen test (test/CodeGen/atomic-ops.c) that is now checking the IR output rather than only making sure frontend doesn't crash. The final patch is attached here! Thanks, Anastasia -Original Message- From: Pekka Jääskeläinen

[PATCH] D13664: [Fix] Don't emit multiple diagnostics for the same error

2015-10-12 Thread George Burgess IV via cfe-commits
george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. Given code like the following (stolen from tests): ``` template int f(T1 *, const T2 *); template int f(const T1 *, T2 *); int (*p)(const int *, const int *)

Re: [PATCH] D13607: [Fix] Make it an error to take the address of (most) enable_if functions.

2015-10-12 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

2015-10-12 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1726 @@ -1720,1 +1725,3 @@ +def err_auto_bitfield : Error< + "cannot pass bit-field as __auto_type initializer in C">; pass -> use Also, why not? Just because GCC messes this

Re: [PATCH] D13664: [Fix] Don't emit multiple diagnostics for the same error

2015-10-12 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D13664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13664: [Fix] Don't emit multiple diagnostics for the same error

2015-10-12 Thread George Burgess IV via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250078: [Sema] Don't emit multiple diags for one error (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D13664?vs=37137=37138#toc Repository: rL LLVM

r250078 - [Sema] Don't emit multiple diags for one error

2015-10-12 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Mon Oct 12 13:40:58 2015 New Revision: 250078 URL: http://llvm.org/viewvc/llvm-project?rev=250078=rev Log: [Sema] Don't emit multiple diags for one error Fixed a bug where we'd emit multiple diagnostics if there was a problem taking the address of an overloaded template

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

2015-10-12 Thread Vedant Kumar via cfe-commits
vsk added a comment. This lgtm. If you don't have commit rights, I can land this for you if you'd like. http://reviews.llvm.org/D12686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13582: [DEBUG INFO] Emit debug info for type used in explicit cast only.

2015-10-12 Thread John McCall via cfe-commits
> On Oct 12, 2015, at 10:50 AM, David Blaikie wrote: > +John, author of the original patch - in case it's an obvious mistake. I > haven't looked at John's change yet & compared it to the intended behavior, > etc. Will do so soon and/or if John doesn't see something at a

r250094 - Support Debug Info path remapping

2015-10-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Oct 12 15:21:08 2015 New Revision: 250094 URL: http://llvm.org/viewvc/llvm-project?rev=250094=rev Log: Support Debug Info path remapping Add support for the `-fdebug-prefix-map=` option as in GCC. The syntax is `-fdebug-prefix-map=OLD=NEW`. When compiling files from

r250090 - [Sema] Make `_with_enable_if_attrs` an error

2015-10-12 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Mon Oct 12 14:57:04 2015 New Revision: 250090 URL: http://llvm.org/viewvc/llvm-project?rev=250090=rev Log: [Sema] Make `_with_enable_if_attrs` an error This fixes a bug where one can take the address of a conditionally enabled function to drop its enable_if guards. For

Re: [PATCH] D13607: [Fix] Make it an error to take the address of (most) enable_if functions.

2015-10-12 Thread George Burgess IV via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250090: [Sema] Make `_with_enable_if_attrs` an error (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D13607?vs=37075=37152#toc Repository: rL LLVM

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

2015-10-12 Thread Matthias Gehre via cfe-commits
mgehre updated this revision to Diff 37155. mgehre marked an inline comment as done. mgehre added a comment. Add test for static_cast with const http://reviews.llvm.org/D13368 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

[libcxxabi] r250097 - Fix Bug 25103 - _cxa_demangle improperly demangles virtual thunks. Thanks to Jason King for the report and suggested fix

2015-10-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Oct 12 15:45:05 2015 New Revision: 250097 URL: http://llvm.org/viewvc/llvm-project?rev=250097=rev Log: Fix Bug 25103 - _cxa_demangle improperly demangles virtual thunks. Thanks to Jason King for the report and suggested fix Modified:

[clang-tools-extra] r250098 - [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

2015-10-12 Thread Matthias Gehre via cfe-commits
Author: mgehre Date: Mon Oct 12 15:46:53 2015 New Revision: 250098 URL: http://llvm.org/viewvc/llvm-project?rev=250098=rev Log: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast Summary: This check flags all usages of static_cast, where a base class is casted to a derived

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

2015-10-12 Thread Matthias Gehre via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250098: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D13368?vs=37155=37164#toc Repository: rL LLVM

r250099 - Parse and ignore #pragma runtime_checks in MS extensions mode (PR25138)

2015-10-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Oct 12 15:47:58 2015 New Revision: 250099 URL: http://llvm.org/viewvc/llvm-project?rev=250099=rev Log: Parse and ignore #pragma runtime_checks in MS extensions mode (PR25138) We already silently ignore the /RTC, which controls the same functionality. Modified:

Re: [PATCH] D13192: Fix incorrect parsing of arguments for nested functions

2015-10-12 Thread Marshall Clow via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. landed as revision 249649 http://reviews.llvm.org/D13192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r250105 - Add warning flags for #include_next and some nearby warnings.

2015-10-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Oct 12 16:05:54 2015 New Revision: 250105 URL: http://llvm.org/viewvc/llvm-project?rev=250105=rev Log: Add warning flags for #include_next and some nearby warnings. Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td

[PATCH] D13673: Add initial support for the MUSL C library.

2015-10-12 Thread Vasileios Kalintiris via cfe-commits
vkalintiris created this revision. vkalintiris added reviewers: mclow.lists, jroelofs, EricWF. vkalintiris added a subscriber: cfe-commits. vkalintiris added a dependency: D13407: [libcxx] Capture configuration information when installing the libc++ headers. Herald added subscribers: srhines,

Re: [PATCH] D12508: [libcxx] Make it drastically simpler to link libc++.

2015-10-12 Thread Richard Smith via cfe-commits
rsmith added a comment. I think this is a good direction. I used to link libc++abi into libc++, and switched to using a hand-rolled linker script a while back. It's been working great for me. http://reviews.llvm.org/D12508 ___ cfe-commits mailing

Re: [PATCH] D13673: Add initial support for the MUSL C library.

2015-10-12 Thread Jonathan Roelofs via cfe-commits
jroelofs added a comment. LGTM, with one small nit (and once http://reviews.llvm.org/D13407 lands): Comment at: src/locale.cpp:1176 @@ -1171,3 +1175,3 @@ } -#endif // __GLIBC__ || __EMSCRIPTEN__ || __NETBSD__ +#endif // __GLIBC__ || __NETBSD__ || || __EMSCRIPTEN__ ||

Re: [PATCH] D13639: Add decayedType and hasDecayedType AST matchers

2015-10-12 Thread Matthias Gehre via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250114: Add decayedType and hasDecayedType AST matchers (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D13639?vs=37066=37178#toc Repository: rL LLVM

r250114 - Add decayedType and hasDecayedType AST matchers

2015-10-12 Thread Matthias Gehre via cfe-commits
Author: mgehre Date: Mon Oct 12 16:46:07 2015 New Revision: 250114 URL: http://llvm.org/viewvc/llvm-project?rev=250114=rev Log: Add decayedType and hasDecayedType AST matchers Summary: Add decayedType and hasDecayedType AST matchers Reviewers: klimek Subscribers: klimek, cfe-commits

r250137 - [modules] Allow the error on importing a C++ module within an extern "C"

2015-10-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Oct 12 19:39:40 2015 New Revision: 250137 URL: http://llvm.org/viewvc/llvm-project?rev=250137=rev Log: [modules] Allow the error on importing a C++ module within an extern "C" context (but otherwise at the top level) to be disabled, to support use of C++ standard library

r250112 - test: change argument

2015-10-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Oct 12 16:19:30 2015 New Revision: 250112 URL: http://llvm.org/viewvc/llvm-project?rev=250112=rev Log: test: change argument This failed on AArch64 due to the type mismatch using int instead of __builtin_va_list. Modified: cfe/trunk/test/CodeGen/Inputs/stdio.h

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

2015-10-12 Thread Matthias Gehre via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250116: [clang-tidy] new check cppcoreguidelines-pro-bounds-pointer-arithmetic (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D13311?vs=36564=37183#toc Repository: rL LLVM

[clang-tools-extra] r250116 - [clang-tidy] new check cppcoreguidelines-pro-bounds-pointer-arithmetic

2015-10-12 Thread Matthias Gehre via cfe-commits
Author: mgehre Date: Mon Oct 12 16:53:19 2015 New Revision: 250116 URL: http://llvm.org/viewvc/llvm-project?rev=250116=rev Log: [clang-tidy] new check cppcoreguidelines-pro-bounds-pointer-arithmetic Summary: This check flags all usage of pointer arithmetic, because it could lead to an invalid

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

2015-10-12 Thread Richard Smith via cfe-commits
rsmith added a comment. Thanks, this essentially looks good to me. I can't think of any other cases where C++ allows `auto` that you've not covered. Comment at: lib/Sema/SemaExprCXX.cpp:1172-1173 @@ -1171,1 +1171,4 @@ + if (D.getDeclSpec().getTypeSpecType() ==

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

2015-10-12 Thread Nicholas Allegra via cfe-commits
comex updated the summary for this revision. comex updated this revision to Diff 37202. comex marked 3 inline comments as done. comex added a comment. Fixed raised issues. (I don't have commit rights.) http://reviews.llvm.org/D12686 Files: include/clang/AST/ASTContext.h

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

2015-10-12 Thread Samuel Benzaquen via cfe-commits
sbenza added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:29 @@ +28,3 @@ + implicitCastExpr(unless(hasParent(arraySubscriptExpr())), +

Re: [PATCH] D12922: Add support for function attribute "notail"

2015-10-12 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 37172. ahatanak added a comment. I've made some changes following the discussion I had and the feedback I got on the llvm-side patch. This is the link to the discussion thread: http://thread.gmane.org/gmane.comp.compilers.llvm.cvs/271105/ The difference

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

2015-10-12 Thread Nicholas Allegra via cfe-commits
comex marked 5 inline comments as done. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1726 @@ -1720,1 +1725,3 @@ +def err_auto_bitfield : Error< + "cannot pass bit-field as __auto_type initializer in C">; rsmith wrote: > pass -> use > > Also, why

r250140 - [modules] Improve error message on failed module load due to a missing file to

2015-10-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Oct 12 20:26:26 2015 New Revision: 250140 URL: http://llvm.org/viewvc/llvm-project?rev=250140=rev Log: [modules] Improve error message on failed module load due to a missing file to say which module file referenced the missing file. Modified:

r250111 - test: relax path matching for windows

2015-10-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Oct 12 16:19:27 2015 New Revision: 250111 URL: http://llvm.org/viewvc/llvm-project?rev=250111=rev Log: test: relax path matching for windows The test failed on Windows due to use of \ as a path separator rather than /. Modified:

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

2015-10-12 Thread Nicholas Allegra via cfe-commits
comex updated this revision to Diff 37215. comex added a comment. Okay. http://reviews.llvm.org/D12686 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticParseKinds.td

r250149 - [X86] LLVM now prints XOP immediates as unsigned after r250147. Fix expected check string accordingly.

2015-10-12 Thread Craig Topper via cfe-commits
Author: ctopper Date: Tue Oct 13 00:15:17 2015 New Revision: 250149 URL: http://llvm.org/viewvc/llvm-project?rev=250149=rev Log: [X86] LLVM now prints XOP immediates as unsigned after r250147. Fix expected check string accordingly. Modified: cfe/trunk/test/CodeGen/xop-builtins.c Modified: