Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

djasper added a subscriber: djasper. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:495-496 @@ +494,4 @@ + for (unsigned I = 0; I < NumErrors; ++I) { +const auto = Errors[I]; +// Skip errors without fixes. They are never going to overlap with anything +//

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

aaron.ballman added a comment. In http://reviews.llvm.org/D13643#266649, @mgrabovsky wrote: > In http://reviews.llvm.org/D13643#265976, @aaron.ballman wrote: > > > Should there be an exception to this diagnostic for code involving Boolean > > values? e.g., > > > > void f(bool a, bool b, bool c)

Re: [PATCH] D11908: Clang support for -fthinlto.

Ping. Thanks, Teresa On Sat, Oct 3, 2015 at 6:51 PM, Teresa Johnson wrote: > tejohnson updated this revision to Diff 36453. > tejohnson added a comment. > > - Rename code gen option to EmitFunctionSummary as per review for > http://reviews.llvm.org/D13107. > - Clang format

r250298 - Tweak a -g related test for the PS4

Author: filcab Date: Wed Oct 14 09:45:36 2015 New Revision: 250298 URL: http://llvm.org/viewvc/llvm-project?rev=250298=rev Log: Tweak a -g related test for the PS4 Make sure we're matching what we want: - Always have -generate-arange-section (independent of -g) - Emit a -dwarf-version=... when

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

djasper added a comment. There might be an even easier algorithm: What if we put all start and end points into a single sorted list. Identical start points are sorted by decreasing end points and identical end points are sorted by increasing start points. Now do a single sweep and simply count

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

Thank you, Filipe! Katya. Sent from my iPhone On Oct 14, 2015, at 6:12 AM, "Filipe Cabecinhas" > wrote: Hi all, I have harnessed the powers of time zones and did the last tweak we needed to get it comitted. It's

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

angelgarcia added a comment. That works pretty well (well, identical end points have to be sorted decreasingly, if I understand correctly). I see a couple of problems though, like equal intervals, or consecutive. But the algorithm is way more efficient than what we currently have, I will try to

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

angelgarcia added a comment. I've done a couple of runs for each version, and these are the results (I have clang-tidy compiled with the option "RelWithDebInfo"): $ time clang-tidy -checks=* test.cpp -- -std=c++11 Without looking for overlaps. Suppressed 23463 warnings (23463 in non-user

Re: [PATCH] D13714: [libcxx] Use __config_site to configure the test suite features.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13731: [RFC][Analyzer] Supporting function attributes in .model files.

pgousseau created this revision. pgousseau added a subscriber: cfe-commits. Dear All, I would like to propose a patch for specifying function attributes in .model files to be used by the analyzer checkers. There are a number of checkers (such as UncheckedReturn) that contain hardcoded list of

Re: [libcxx] r249738 - Split out of .

To make it easier to find and investigate issues like this, I set up an experimental bot on the Green Dragon Jenkins installation on lab.llvm.org that builds a stage2 on Darwin with LLVM_ENABLE_MODULES: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA/ I’ve configured it to

r250301 - Intrin.h: implement __emul and __emulu

Author: hans Date: Wed Oct 14 11:24:28 2015 New Revision: 250301 URL: http://llvm.org/viewvc/llvm-project?rev=250301=rev Log: Intrin.h: implement __emul and __emulu Modified: cfe/trunk/lib/Headers/Intrin.h Modified: cfe/trunk/lib/Headers/Intrin.h URL:

Re: [PATCH] D11908: Clang support for -fthinlto.

joker.eph accepted this revision. joker.eph added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D11908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: r250173 - Always pass a -dwarf-version argument to integrated as.

> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Douglas Katzman via cfe-commits > Sent: Tuesday, October 13, 2015 9:23 AM > To: cfe-commits@lists.llvm.org > Subject: r250173 - Always pass a -dwarf-version argument to integrated as. > >

[libcxxabi] r250307 - Add config.project_obj_root to the libc++abi testsuite

Author: ericwf Date: Wed Oct 14 13:20:48 2015 New Revision: 250307 URL: http://llvm.org/viewvc/llvm-project?rev=250307=rev Log: Add config.project_obj_root to the libc++abi testsuite Modified: libcxxabi/trunk/test/lit.site.cfg.in Modified: libcxxabi/trunk/test/lit.site.cfg.in URL:

Re: [libcxx] r249738 - Split out of .

> On Oct 13, 2015, at 7:43 PM, Richard Smith wrote: > > On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva > wrote: > On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith >

Re: [PATCH] D13713: [libc++] Stop marking interface symbols always_inline + hidden when building for unstable ABI

EricWF added a comment. - I would love to have some documentation in libc++ about always-inline, the ABI problem it is trying to solve, and how it falls short. Because you tried to fix these semantics in clang would you be willing to write up a short summary of when always-inline does and

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

mgrabovsky added a comment. In http://reviews.llvm.org/D13643#265976, @aaron.ballman wrote: > Should there be an exception to this diagnostic for code involving Boolean > values? e.g., > > void f(bool a, bool b, bool c) { > > if (a == b == c) > ; > > } > > At the very least, it seems like

Re: [PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

EricWF added a subscriber: EricWF. EricWF added reviewers: EricWF, mclow.lists. EricWF added a comment. > This is required by the standard and is needed if the user tries to > explicitly instantiate the transcendental functions using _Tp, for example, > std::abs(int_valarray). These may in

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher wrote: > It was already reverted, but I agree, let's get this fixed first. > It was reintroduced in r250252. It is breaking http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/1362 -- Sean

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

On Tue, Oct 13, 2015 at 11:38 PM Sean Silva wrote: > On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher > wrote: > >> It was already reverted, but I agree, let's get this fixed first. >> > > It was reintroduced in r250252. It is breaking >

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

On Tue, Oct 13, 2015 at 7:51 PM, Katya Romanova < katya_roman...@playstation.sony.com> wrote: > kromanova added a comment. > > Hi, > > The initial PS4 patch caused a test failure (debug-options.c) on the PS4 > bot. I suspect that I know why the problem happens, but I'm not sure what > will be the

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

It was already reverted, but I agree, let's get this fixed first. Thanks! -eric On Tue, Oct 13, 2015 at 11:33 PM Sean Silva wrote: > On Tue, Oct 13, 2015 at 7:51 PM, Katya Romanova < > katya_roman...@playstation.sony.com> wrote: > >> kromanova added a comment. >> >> Hi,

r250273 - Revert-to-green r250262 (PS4 toolchain patch)

Author: silvas Date: Wed Oct 14 01:45:07 2015 New Revision: 250273 URL: http://llvm.org/viewvc/llvm-project?rev=250273=rev Log: Revert-to-green r250262 (PS4 toolchain patch) It is breaking llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast e.g.

RE: [PATCH] D13482: Revised Initial patch for PS4 toolchain

Hi Sean, I don’t think that the whole patch should have been reverted. There were much easier way to make the PS4 bot green. A single test could have been marked as “XFAIL: ps4” for a few hours until a better solution is implemented. Reverting this huge patch is more drastic measure that might

Re: [PATCH] D13504: Prevent modernize-use-auto from emitting a warning when 'auto' was already being used.

angelgarcia added a comment. Ping http://reviews.llvm.org/D13504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r250283 - Support every kind of initialization.

Author: angelgarcia Date: Wed Oct 14 04:22:32 2015 New Revision: 250283 URL: http://llvm.org/viewvc/llvm-project?rev=250283=rev Log: Support every kind of initialization. Summary: modernize-make-unique now correctly supports the different kinds of list initialization. Reviewers: klimek

[clang-tools-extra] r250284 - Prevent modernize-use-auto from emitting a warning when 'auto' was already being used.

Author: angelgarcia Date: Wed Oct 14 04:29:55 2015 New Revision: 250284 URL: http://llvm.org/viewvc/llvm-project?rev=250284=rev Log: Prevent modernize-use-auto from emitting a warning when 'auto' was already being used. Summary: This fixes https://llvm.org/bugs/show_bug.cgi?id=25082 .

[PATCH] D13720: Use __SIZE_TYPE__ to fix buildbot failures.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added a subscriber: cfe-commits. Use __SIZE_TYPE__ to fix buildbot failures. http://reviews.llvm.org/D13720 Files: test/clang-tidy/modernize-make-unique.cpp Index: test/clang-tidy/modernize-make-unique.cpp

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev updated this revision to Diff 37321. ABataev marked 16 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D11182 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev marked 40 inline comments as done. ABataev added a comment. Richard, thanks for the review! Tried to fix all your comments. Comment at: include/clang/AST/DeclOpenMP.h:95 @@ +94,3 @@ +/// #pragma omp declare reduction (foo : int,float : omp_out += omp_in) +///

Re: [PATCH] D13504: Prevent modernize-use-auto from emitting a warning when 'auto' was already being used.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. One thing does need to change though. For each overload you added you need to change all of the uses of `__is_val_expr` in the original overload to a new metafunction that only

r250278 - [CMake] Add LLVM_VERSION_PATCH to the -current_version flag for libclang.

Author: cbieneman Date: Wed Oct 14 02:50:47 2015 New Revision: 250278 URL: http://llvm.org/viewvc/llvm-project?rev=250278=rev Log: [CMake] Add LLVM_VERSION_PATCH to the -current_version flag for libclang. This is to match autoconf where LLVM_SUBMIT_SUBVERSION is usually set to

[libcxx] r250279 - Fix GCC atomic implementation in C++03

Author: ericwf Date: Wed Oct 14 03:36:22 2015 New Revision: 250279 URL: http://llvm.org/viewvc/llvm-project?rev=250279=rev Log: Fix GCC atomic implementation in C++03 Modified: libcxx/trunk/include/atomic Modified: libcxx/trunk/include/atomic URL:

Re: [PATCH] D13590: Support every kind of initialization.

angelgarcia updated this revision to Diff 37322. angelgarcia added a comment. Remove \code and \endcode. http://reviews.llvm.org/D13590 Files: clang-tidy/modernize/MakeUniqueCheck.cpp test/clang-tidy/modernize-make-unique.cpp Index: test/clang-tidy/modernize-make-unique.cpp

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

angelgarcia added a comment. > These need to be documented. Done. > I'd name this Queue instead (reading later I had no idea what this was). Done. > Why are you calling this "Sit"? I didn't even know how to describe this variable without using examples, and naming it is harder. More or

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

cbergstrom added a comment. ‎And does this hardcode the abi and break cxxrt? It's not just me who uses that    Original Message   From: Eric Fiselier Sent: Thursday, October 15, 2015 03:26 To: e...@efcs.ca; mclow.li...@gmail.com; jonat...@codesourcery.com; danalb...@google.com;

[libcxxabi] r250316 - Fix LIBCXXABI_HAS_NO_THREADS configuration.

Author: ericwf Date: Wed Oct 14 14:21:38 2015 New Revision: 250316 URL: http://llvm.org/viewvc/llvm-project?rev=250316=rev Log: Fix LIBCXXABI_HAS_NO_THREADS configuration. Modified: libcxxabi/trunk/test/libcxxabi/test/config.py Modified: libcxxabi/trunk/test/libcxxabi/test/config.py URL:

Re: [Diffusion] rL244063: Add missing atomic libcall support.

dim added a subscriber: dim. dim added auditors: 3.7-release, cfe-commits, tstellarAMD, jyknight, compnerd, majnemer. dim added a comment. This is a change that was required to be able to use clang 3.7.0 for FreeBSD on arm. Please merge this to the 3.7 branch. (I already mailed this to James

[libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

Author: ericwf Date: Wed Oct 14 14:54:03 2015 New Revision: 250319 URL: http://llvm.org/viewvc/llvm-project?rev=250319=rev Log: [libcxx] Make it drastically simpler to link libc++. Summary: Currently on most platforms you have to manually link the c++ abi library used with libc++ whenever you

[libcxx] r250323 - Update testing guide for libc++

Author: ericwf Date: Wed Oct 14 15:44:44 2015 New Revision: 250323 URL: http://llvm.org/viewvc/llvm-project?rev=250323=rev Log: Update testing guide for libc++ Modified: libcxx/trunk/docs/TestingLibcxx.rst Modified: libcxx/trunk/docs/TestingLibcxx.rst URL:

[PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF created this revision. EricWF added reviewers: mclow.lists, jroelofs, danalbert, compnerd. EricWF added subscribers: cfe-commits, cbergstrom, rengolin, emaste. This patch turns on `LIBCXX_ENABLE_ABI_LINKER_SCRIPT` by default whenever `LLVM_HAVE_LINK_VERSION_SCRIPT` is ON. This turns out

[libcxxabi] r250313 - Configure for config site header

Author: ericwf Date: Wed Oct 14 14:01:47 2015 New Revision: 250313 URL: http://llvm.org/viewvc/llvm-project?rev=250313=rev Log: Configure for config site header Modified: libcxxabi/trunk/test/libcxxabi/test/config.py Modified: libcxxabi/trunk/test/libcxxabi/test/config.py URL:

Re: [PATCH] D12508: [libcxx] Make it drastically simpler to link libc++.

EricWF updated this revision to Diff 37376. EricWF added a comment. Updating diff so it merges cleanly against master. http://reviews.llvm.org/D12508 Files: CMakeLists.txt lib/CMakeLists.txt test/CMakeLists.txt utils/gen_link_script/gen_link_script.py Index:

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

jroelofs added inline comments. Comment at: CMakeLists.txt:71 @@ -70,1 +70,3 @@ +# Use a static copy of the ABI library when linking libc++. This option +# cannot be used with LIBCXX_ENABLE_ABI_LINKER_SCRIPT. option(LIBCXX_ENABLE_STATIC_ABI_LIBRARY "Statically link the ABI

Re: [libcxx] r249738 - Split out of .

> On Oct 14, 2015, at 3:32 PM, Richard Smith wrote: > > On Wed, Oct 14, 2015 at 2:03 PM, Adrian Prantl via cfe-commits > > wrote: >> On Oct 14, 2015, at 11:37 AM, Adrian Prantl via cfe-commits >>

[libcxx] r250325 - Link to new documentation from existing homepage

Author: ericwf Date: Wed Oct 14 15:51:33 2015 New Revision: 250325 URL: http://llvm.org/viewvc/llvm-project?rev=250325=rev Log: Link to new documentation from existing homepage Modified: libcxx/trunk/www/index.html Modified: libcxx/trunk/www/index.html URL:

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

mgehre updated this revision to Diff 37401. mgehre added a comment. Remove dead codet http://reviews.llvm.org/D13746 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

mgehre updated this revision to Diff 37417. mgehre marked 7 inline comments as done. mgehre added a comment. Matcher does not rely on __range anymore http://reviews.llvm.org/D13640 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF added a comment. @cbergstrom After installing libcxxrt I ran the libc++ configuration with `-DLIBCXX_CXX_ABI=libcxxrt` and everything worked perfectly. It generated libc++.so as `INPUT(libc++.so.1 -lcxxrt)` and after running it against the test suite everything works great.

[PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. This check flags all array subscriptions on static arrays and std::arrays that either have a non-compile-time-constant index or are out of bounds. Dynamic

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF added a comment. Thanks for the review. I'm going to wait a little to see if any objections crop up before committing. http://reviews.llvm.org/D13739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r250336 - Update issues status

Author: ericwf Date: Wed Oct 14 17:26:40 2015 New Revision: 250336 URL: http://llvm.org/viewvc/llvm-project?rev=250336=rev Log: Update issues status Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

mgehre added a comment. Updated commit to fix comments http://reviews.llvm.org/D13640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF added a comment. In http://reviews.llvm.org/D13739#267286, @cbergstrom wrote: > ‎And does this hardcode the abi and break cxxrt? It's not just me who uses > that  No it does not hard code the ABI. The linker script is generated based on the name of the ABI library selected at build

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF updated this revision to Diff 37393. EricWF marked 5 inline comments as done. EricWF added a comment. Address review comments. http://reviews.llvm.org/D13739 Files: CMakeLists.txt cmake/Modules/HandleOutOfTreeLLVM.cmake docs/BuildingLibcxx.rst docs/UsingLibcxx.rst Index:

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF added inline comments. Comment at: CMakeLists.txt:71 @@ -70,1 +70,3 @@ +# Use a static copy of the ABI library when linking libc++. This option +# cannot be used with LIBCXX_ENABLE_ABI_LINKER_SCRIPT. option(LIBCXX_ENABLE_STATIC_ABI_LIBRARY "Statically link the ABI

[PATCH] D13748: [libcxx] Fix PR15638 - Only allocate in parent when starting a thread to prevent calling terminate.

EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, jroelofs. EricWF added a subscriber: cfe-commits. Hi, When creating a new thread libc++ performs at least 2 allocations. The first allocates a tuple of args and the functor that will be passed to the new thread. The

Re: [libcxx] r249738 - Split out of .

+Ted > On 2015-Oct-14, at 15:32, Richard Smith via cfe-commits > wrote: > >> While building module 'LLVM_Utils' imported from >> ../lib/Support/APFloat.cpp:15: >> In file included from :1: >> In file included from ../include/llvm/ADT/APFloat.h:20: >> In file

Re: [libcxx] r249738 - Split out of .

> On Oct 14, 2015, at 11:37 AM, Adrian Prantl via cfe-commits > wrote: > >> >> On Oct 13, 2015, at 7:43 PM, Richard Smith > > wrote: >> >> On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva >

Re: [PATCH] D12747: Implement [depr.c.headers]

rsmith abandoned this revision. rsmith added a comment. Patch has been split up and the individual parts have all been committed (except the module map changes, which are currently problematic due to libc / libc++ layering issues). Repository: rL LLVM http://reviews.llvm.org/D12747

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

mgehre updated this revision to Diff 37396. mgehre marked an inline comment as done. mgehre added a comment. Test more complex array arithmetic, test gsl::array_view works, add "use array_view instead" to diagnostic http://reviews.llvm.org/D13640 Files:

Re: [libcxx] r249738 - Split out of .

On Wed, Oct 14, 2015 at 2:03 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 14, 2015, at 11:37 AM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > On Oct 13, 2015, at 7:43 PM, Richard Smith wrote: > > On Tue, Oct

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris updated this revision to Diff 37335. vkalintiris added a comment. Address reviewers' comments. http://reviews.llvm.org/D13673 Files: CMakeLists.txt include/__config include/__config_site.in include/__locale include/support/musl/xlocale.h src/locale.cpp Index:

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

klimek added a comment. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:438-440 @@ +437,5 @@ + int Count[2] = {0, 0}; + // Sit[1][0] will tell if there exists any range that is covered by the + // first set but not by the second one, Sit[1][1] will tell if there is a

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

angelgarcia updated this revision to Diff 37334. angelgarcia added a comment. Add an enum and rename "Sit" to "Coverage" to improve readability. http://reviews.llvm.org/D13516 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris added inline comments. Comment at: CMakeLists.txt:309 @@ -307,1 +308,3 @@ +config_define_if(LIBCXX_LIBC_IS_MUSL _LIBCXX_LIBC_IS_MUSL) + EricWF wrote: > Please name the macro "_LIBCPP_HAS_MUSL_LIBC" for consistency. Should I rename the corresponding

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

klimek added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:444-448 @@ +443,7 @@ + }; + // Keep track of the different coverage situations that have been spotted + // during the process: Coverage[Covered][Empty] will tell if there exists any + //

Re: [PATCH] D13713: [libc++] Stop marking interface symbols always_inline + hidden when building for unstable ABI

eugenis added a comment. I've wrote down my understanding of the problem in ABIVersioning.rst. AFAIK, Howard added the attribute so he might know more about it. Why does windows need this attributes in the unstable abi build? Hidden visibility and always_inline work together for the same goal,

Re: [libcxx] r249738 - Split out of .

> On Oct 14, 2015, at 5:07 PM, Richard Smith wrote: > > On Wed, Oct 14, 2015 at 3:58 PM, Adrian Prantl via cfe-commits > > wrote: >> On Oct 14, 2015, at 3:32 PM, Richard Smith >

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

sfantao added a comment. Ping! http://reviews.llvm.org/D12614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

sfantao added a comment. Are there any more comments/suggestions about this patch? Thanks! Samuel http://reviews.llvm.org/D9888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D13482: Revised Initial patch for PS4 toolchain

Filipe, I have one question regarding the change in debug-option.c that you made to get the builds green again… (r250294). Basically you changed the generic run line that used to test the drivers for every single platform // RUN: %clang -### -g %s 2>&1 | FileCheck -check-prefix=CI %s into the

Re: [libcxx] r249738 - Split out of .

> On Oct 14, 2015, at 3:49 PM, Duncan P. N. Exon Smith > wrote: > > My understanding is that we don't expect clang to be used with *newer* libc++ > headers, just older or equal. This kind of break is a little unfortunate, > but probably fine. Ted, can you confirm? On

r250348 - [X86] Use C+11 non-static data member initialization to initialize all the X86 feature controls. NFC

Author: ctopper Date: Wed Oct 14 18:47:57 2015 New Revision: 250348 URL: http://llvm.org/viewvc/llvm-project?rev=250348=rev Log: [X86] Use C+11 non-static data member initialization to initialize all the X86 feature controls. NFC This simplifies the constructor initialization list and makes it

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

On Wed, Oct 14, 2015 at 12:54 AM, Romanova, Katya < katya_roman...@playstation.sony.com> wrote: > Hi Sean, > > > > I don’t think that the whole patch should have been reverted. There were > much easier way to make the PS4 bot green. A single test could have been > marked as “XFAIL: ps4” for a few

Re: [PATCH] D13713: [libc++] Stop marking interface symbols always_inline + hidden when building for unstable ABI

eugenis updated this revision to Diff 37427. Repository: rL LLVM http://reviews.llvm.org/D13713 Files: docs/DesignDocs/ABIVersioning.rst include/__config Index: include/__config === --- include/__config +++ include/__config

Re: [libcxx] r249738 - Split out of .

On Wed, Oct 14, 2015 at 3:58 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 14, 2015, at 3:32 PM, Richard Smith wrote: > > On Wed, Oct 14, 2015 at 2:03 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Oct 14,

Re: [libcxx] r249738 - Split out of .

On Wed, Oct 14, 2015 at 3:32 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Oct 14, 2015 at 2:03 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Oct 14, 2015, at 11:37 AM, Adrian Prantl via cfe-commits < >>

[PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. I checked this patch on my own build on RHEL 6. Regressions were OK.

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

angelgarcia updated this revision to Diff 37336. angelgarcia added a comment. Done. http://reviews.llvm.org/D13516 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h unittests/clang-tidy/OverlappingReplacementsTest.cpp Index:

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

klimek added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:495-496 @@ +494,4 @@ + std::vector Apply(NumErrors, true); + for (int I = 0; I < NumErrors; ++I) { +for (int J = I + 1; J < NumErrors; ++J) { + OverlappingKind Kind =

r250293 - Bring back r250262: PS4 toolchain

Author: filcab Date: Wed Oct 14 07:25:43 2015 New Revision: 250293 URL: http://llvm.org/viewvc/llvm-project?rev=250293=rev Log: Bring back r250262: PS4 toolchain There was a minor problem with a test. Sorry for the noise yesterday. This patch adds missing pieces to clang, including the PS4

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

angelgarcia updated this revision to Diff 37344. angelgarcia added a comment. Use bounding boxes to reduce complexity. http://reviews.llvm.org/D13516 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

klimek added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:438-440 @@ +437,5 @@ + int Count[2] = {0, 0}; + // Sit[1][0] will tell if there exists any range that is covered by the + // first set but not by the second one, Sit[1][1] will tell if there

[clang-tools-extra] r250288 - Use __SIZE_TYPE__ to fix buildbot failures.

Author: angelgarcia Date: Wed Oct 14 05:30:32 2015 New Revision: 250288 URL: http://llvm.org/viewvc/llvm-project?rev=250288=rev Log: Use __SIZE_TYPE__ to fix buildbot failures. Summary: Use __SIZE_TYPE__ to fix buildbot failures. Reviewers: klimek Subscribers: cfe-commits Differential

Re: [PATCH] D13720: Use __SIZE_TYPE__ to fix buildbot failures.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r250283 - Support every kind of initialization.

On 14 October 2015 at 10:22, Angel Garcia Gomez via cfe-commits wrote: > Author: angelgarcia > Date: Wed Oct 14 04:22:32 2015 > New Revision: 250283 > > URL: http://llvm.org/viewvc/llvm-project?rev=250283=rev > Log: > Support every kind of initialization. Hi, this

[libcxx] r250361 - Add links to libc++ code coverage and builders

Author: ericwf Date: Wed Oct 14 22:27:02 2015 New Revision: 250361 URL: http://llvm.org/viewvc/llvm-project?rev=250361=rev Log: Add links to libc++ code coverage and builders Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/index.rst URL:

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

Hi all, I have harnessed the powers of time zones and did the last tweak we needed to get it comitted. It's still going through some bots, but I don't foresee big problems. The fast bots liked it. Thanks to everyone that reviewed it and worked on it! Filipe On Wed, Oct 14, 2015 at 8:54 AM,

Re: [PATCH] D12922: Add support for function attribute "notail"

ahatanak updated this revision to Diff 37437. ahatanak added a comment. Address some of the review comments: - Added a c++ test which tests the c++ spelling of the attribute on member functions and shows which virtual functions calls get marked as "notail" in the IR. - Added a check that was

Re: [PATCH] D12922: Add support for function attribute "notail"

ahatanak marked an inline comment as done. Comment at: include/clang/Basic/AttrDocs.td:1619 @@ +1618,3 @@ + let Content = [{ +Tail call optimization is not performed on direct calls to a function marked ``notail``. + }]; Perhaps direct call isn't the right

Re: [PATCH] D12922: Add support for function attribute "notail"

> On 2015-Oct-13, at 09:55, Aaron Ballman wrote: > > aaron.ballman added a comment. > > In http://reviews.llvm.org/D12922#265452, @ahatanak wrote: > >> I think there are a couple of things that have to be discussed: >> >> 1. Name of the attribute: Should it be

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

klimek added a comment. LG in general now, looks to me like we have very few tests though. My favorite strategy to make sure I have enough tests is to comment out code (or do mutations) as long as the tests still pass. Then write tests that fail with the mutation, then undo the mutation.

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1962 @@ +1961,3 @@ +[LineNum][ColNum]; +assert(Entry.Order != -1u && "Entry not initialized!"); +assert(!Entry.Addr && !Entry.ID && "Entry registered

r250369 - [X86] Add proper feature names to xsave builtins.

Author: ctopper Date: Thu Oct 15 00:23:46 2015 New Revision: 250369 URL: http://llvm.org/viewvc/llvm-project?rev=250369=rev Log: [X86] Add proper feature names to xsave builtins. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

[PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added subscribers: klimek, cfe-commits. If a RegExp contains a character group with a quote (`/["]/`), the trailing end of it is first tokenized as a string literal, which leads to the merging code seeing an unbalanced