Re: [PATCH] D15836: [libcxx] Fix undefined behavior in forward_list

EricWF updated this revision to Diff 43824. EricWF added a comment. forward_list and it's iterators should allow incomplete types in C++17 and beyond. I updated the patch to fix this issue as a drive-by. http://reviews.llvm.org/D15836 Files: include/__config include/forward_list

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

ABataev added a comment. Aaron, thanks for the review! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2504 @@ -2493,3 +2503,3 @@ // Availability attribute def warn_availability_unknown_platform : Warning< aaron.ballman wrote: > >> It would be good

[PATCH] D15836: [libcxx] Fix undefined behavior in forward_list

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. This patch is similar to the fix but it has a few differences. This patch doesn't use a `__link_pointer` typedef because we don't need to change the linked list pointers because

Re: [PATCH] D15639: [clang-format] Ensure Sort include is stable with negative Priority

jeanphilippeD abandoned this revision. jeanphilippeD added a comment. This was fixed by other patch. http://reviews.llvm.org/D15639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

hokein updated this revision to Diff 43826. hokein added a comment. Move unittest to lit test. http://reviews.llvm.org/D15710 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tidy/misc/DefinitionsInHeadersCheck.h

r256672 - [X86][PKU] add clang intrinsic for {RD|WR}PKRU

Author: abadouh Date: Thu Dec 31 08:14:07 2015 New Revision: 256672 URL: http://llvm.org/viewvc/llvm-project?rev=256672=rev Log: [X86][PKU] add clang intrinsic for {RD|WR}PKRU Differential Revision: http://reviews.llvm.org/D15837 Added: cfe/trunk/lib/Headers/pkuintrin.h

Re: [PATCH] D15805: [clang-tidy] Cleanup code in CERT module.

aaron.ballman added a comment. In http://reviews.llvm.org/D15805#318307, @hokein wrote: > So shoud we need to rename to `cert` at this patch? Yes, but just the namespaces as you do in this patch (not anything in user documentation, for instance). This patch LG; if you need me to commit on

Re: [PATCH] D15823: Support virtual-near-miss check.

congliu marked 2 inline comments as done. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:79 @@ +78,3 @@ + if (BaseReturnType->isReferenceType() && DerivedReturnType->isReferenceType()){ +BaseReturnType = BaseReturnType.getNonReferenceType(); +DerivedReturnType =

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

ABataev updated this revision to Diff 43828. ABataev added a comment. Fix after review. After some discussion with gcc guys it was decided to allow to use static member functions as interrupt handler. http://reviews.llvm.org/D15709 Files: include/clang/Basic/Attr.td

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

thiagomacieira added a comment. Ping? http://reviews.llvm.org/D14727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

hokein marked 5 inline comments as done. hokein added a comment. http://reviews.llvm.org/D15710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15805: [clang-tidy] Cleanup code in CERT module.

hokein added a comment. So shoud we need to rename to `cert` at this patch? Repository: rL LLVM http://reviews.llvm.org/D15805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:259 @@ +258,3 @@ +def err_anyx86_interrupt_attribute : Error< + "interrupt service routine %select{must have void return value|" + "can only have a pointer argument and an optional

Re: [libcxx] r249798 - Split out of .

On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith wrote: > On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote: > >> One problem with this patch: stdio.h can be used in .c files, and when >> building .c files with -gnu99 -pedantic, >> > > Do you mean

r256683 - [TrailingObjects] Convert classes in OpenMPClause.h

Author: jyknight Date: Thu Dec 31 18:38:24 2015 New Revision: 256683 URL: http://llvm.org/viewvc/llvm-project?rev=256683=rev Log: [TrailingObjects] Convert classes in OpenMPClause.h Modified: cfe/trunk/include/clang/AST/OpenMPClause.h cfe/trunk/lib/AST/OpenMPClause.cpp Modified:

[PATCH] D15839: Move _xgetbv to immintrin.h

ehsan created this revision. ehsan added a reviewer: hansw. ehsan added a subscriber: cfe-commits. The documentation in https://msdn.microsoft.com/en-us/library/hh977022.aspx says that this intrinsic is defined in immintrin.h, and that's the header where MSVC declares this intrinsic, but clang-cl

Re: [PATCH] D15839: Move _xgetbv to immintrin.h

ehsan abandoned this revision. ehsan added a comment. Oops, sorry, I submitted this by mistake. http://reviews.llvm.org/D15839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r249798 - Split out of .

On Thu, Dec 31, 2015 at 10:52 AM, Nico Weber wrote: > On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith > wrote: > >> On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote: >> >>> One problem with this patch: stdio.h can be used in .c

r256686 - Reimplement __readeflags and __writeeflags on top of intrinsics

Author: majnemer Date: Fri Jan 1 00:50:08 2016 New Revision: 256686 URL: http://llvm.org/viewvc/llvm-project?rev=256686=rev Log: Reimplement __readeflags and __writeeflags on top of intrinsics Lean on LLVM to provide this functionality now that it provides the necessary intrinsics. Modified: