Re: [PATCH] D16135: Macro Debug Info support in Clang

aaboud added inline comments. Comment at: include/clang/AST/ASTConsumer.h:163 @@ -155,1 +162,3 @@ + /// The caller takes ownership on the returned pointer. + virtual std::unique_ptr CreatePreprocessorCallbacks(Preprocessor ); }; Richard, I know that you

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

alexfh added inline comments. Comment at: clang-tidy/ClangTidyOptions.h:216 @@ +215,3 @@ +/// HeaderFileExtensions. +bool endWithHeaderFileExtensions(llvm::StringRef FileName, + llvm::StringRef HeaderFileExtensions); hokein wrote:

r257586 - [OPENMP] Fix for declarative/standalone directives use.

Author: abataev Date: Wed Jan 13 05:18:54 2016 New Revision: 257586 URL: http://llvm.org/viewvc/llvm-project?rev=257586=rev Log: [OPENMP] Fix for declarative/standalone directives use. Fixes processing of declarative directives and standalone executable directives. Declarative directives should

Re: [PATCH] D15686: PR25910: clang allows two var definitions with the same mangled name

andreybokhanko added a comment. In http://reviews.llvm.org/D15686#325266, @rnk wrote: > I thought we already addressed this issue with @rjmccall and decided that, if > the user intentionally declares extern "C" variables with an _Z prefix, then > we know they are intentionally attempting to

[PATCH] D16138: Correct setting of UserLabelPrefix for MCU target

andreybokhanko created this revision. andreybokhanko added reviewers: rnk, mkuper. andreybokhanko added a subscriber: cfe-commits. Correct setting of UserLabelPrefix for MCU target http://reviews.llvm.org/D16138 Files: lib/Basic/Targets.cpp test/Preprocessor/elfiamcu-predefines.c Index:

[PATCH] D16135: Macro Debug Info support in Clang

aaboud created this revision. aaboud added reviewers: dblaikie, rsmith, aprantl, probinson. aaboud added a subscriber: cfe-commits. Added support for FE Clang to create Debug Info entries (DIMacro and DIMacroFile) into generated module if "debug-info-kind" flag is set to "standalone".

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

alexfh added a comment. Thank you for the patch! I have a few concerns though. See inline comments. Comment at: clang-tidy/ClangTidy.cpp:348 @@ +347,3 @@ + LocalName.str() }; + for (const auto : Names) { +auto Iter =

Re: [PATCH] D16138: Correct setting of UserLabelPrefix for MCU target

andreybokhanko updated this revision to Diff 44726. andreybokhanko added a comment. Patch updated to be in line with llvm trunk. Sorry for the noise. http://reviews.llvm.org/D16138 Files: lib/Basic/Targets.cpp test/Preprocessor/elfiamcu-predefines.c Index: lib/Basic/Targets.cpp

Re: [PATCH] D15448: [analyzer] SVal Visitor.

NoQ updated this revision to Diff 44734. NoQ added a comment. Rebase on top of http://reviews.llvm.org/D12901 - support `SymbolCast` in the explainer, as it finally appears in the wild. http://reviews.llvm.org/D15448 Files: docs/analyzer/DebugChecks.rst

Re: r257533 - D9600: Add scan-build python implementation

Hi, On Wed, Jan 13, 2016 at 12:38 AM, Laszlo Nagy via cfe-commits wrote: > Author: rizsotto > Date: Tue Jan 12 16:38:41 2016 > New Revision: 257533 > > URL: http://llvm.org/viewvc/llvm-project?rev=257533=rev > Log: > D9600: Add scan-build python implementation This

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl:37 @@ +36,3 @@ + write_pipe(p, tmp); // expected-error {{invalid argument type to function write_pipe (expecting: 'int *')}} + read_pipe(p, ptr);// expected-error {{invalid pipe

Re: [PATCH] D16138: Correct setting of UserLabelPrefix for MCU target

rafael added a subscriber: rafael. rafael accepted this revision. rafael added a reviewer: rafael. rafael added a comment. This revision is now accepted and ready to land. LGTM, but could you change the default in a followup commit? TargetInfo should really be setting it to "" since it is far

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:593 @@ -592,2 +592,3 @@ +def err_no_declarators : Error<"declaration does not declare anything">; def ext_typedef_without_a_name : ExtWarn<"typedef requires a name">, InGroup;

Re: [PATCH] D16080: [CUDA] Add tests for compiling CUDA files with -E.

tra added inline comments. Comment at: test/Driver/cuda-preprocess.cu:13-16 @@ +12,6 @@ + +// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_20 %s 2>&1 \ +// RUN: | FileCheck -check-prefix NOARCH %s +// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_20

Re: [PATCH] D16081: [CUDA] Add test for compiling CUDA code with -S.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15907: Allow various function attributes to be specified on Objective-C blocks too.

comex added reviewers: aaron.ballman, rsmith. comex added a comment. Ping, and adding potential reviewers like I was supposed to do in the first place. http://reviews.llvm.org/D15907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

ldionne added a reviewer: rsmith. ldionne updated this revision to Diff 44779. ldionne added a comment. Rebase on top of the master branch, and add Richard Smith as a reviewer, since he also reviewed David Majnemer's original patch (suggested by Nathan Wilson). http://reviews.llvm.org/D15421

r257652 - Update cxx_dr_status.html after the 3.8 branch

Author: hans Date: Wed Jan 13 13:14:03 2016 New Revision: 257652 URL: http://llvm.org/viewvc/llvm-project?rev=257652=rev Log: Update cxx_dr_status.html after the 3.8 branch Modified: cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/www/cxx_dr_status.html URL:

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs abandoned this revision. jroelofs added a comment. Hmm. There's no "close revision" button. Abandoning it in lieu of closing it. http://reviews.llvm.org/D15528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

On Fri, Jan 8, 2016 at 1:54 PM, Philippe Canal wrote: > Hi Richard, > > In our use (Persistency of C++ objects, including the (meta)description of > their data content as well as use the name as key to access the class' > reflection information at run-time), the 'context' is

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

rsmith added a comment. I think this functionality can be provided more simply by adding another flag to `PrintingPolicy` to request fully-qualified names always be produced. It already usually provides fully-qualified names; the only notable exception I can see is that if a qualifier was

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

akyrtzi added a comment. Tests need to be updated, for example: clang/test/Index/remap-load.c:7:11: error: expected string not found in input // CHECK: remap-load.c:2:10: BinaryOperator= Extent=[2:10 - 2:23] ^ :334:1: note: scanning from here // CHECK: remap-load.c:2:10: BinaryOperator=+

[PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

sbenza created this revision. sbenza added a reviewer: alexfh. sbenza added a subscriber: cfe-commits. Add check performance-faster-string-find. It replaces single character string literals to character literals in calls to string::find and friends. http://reviews.llvm.org/D16152 Files:

r257695 - Update make_cxx_dr_status after the 3.8 branch.

Author: rsmith Date: Wed Jan 13 16:51:59 2016 New Revision: 257695 URL: http://llvm.org/viewvc/llvm-project?rev=257695=rev Log: Update make_cxx_dr_status after the 3.8 branch. Modified: cfe/trunk/www/make_cxx_dr_status Modified: cfe/trunk/www/make_cxx_dr_status URL:

[PATCH][clang-format] Sublime script: prevent console window popup

Hello, In the attachment is a small patch for clang-format-sublime.py, that prevents the console window from showing. Right now, it is flashing ever so briefly, ever so annoyingly; this patches fixes that. I've tested it on Windows and Mac OS X. I do not have write access; if you agree with the

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rjmccall added inline comments. Comment at: include/clang/Basic/TargetInfo.h:385 @@ +384,3 @@ + unsigned getFloat128Width() const { return Float128Width; } + unsigned getFloat128Align() const { return Float128Align; } + const llvm::fltSemantics () const { I

Re: [PATCH] D16177: Adding missing intrinsics _cvtsh_ss and _cvtss_sh

kromanova added a subscriber: cfe-commits. kromanova added a comment. Adding cfe-commits as a subscriber. Repository: rL LLVM http://reviews.llvm.org/D16177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev removed a subscriber: rsmith. ABataev updated this revision to Diff 44833. ABataev added a comment. Updated to latest version http://reviews.llvm.org/D10599 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticParseKinds.td

r257741 - clang-format: [JS] Fix incorrect line break leading to semicolon insertion.

Author: djasper Date: Wed Jan 13 23:37:52 2016 New Revision: 257741 URL: http://llvm.org/viewvc/llvm-project?rev=257741=rev Log: clang-format: [JS] Fix incorrect line break leading to semicolon insertion. clang-format only works for JavaScript code, if all the semicolons are present anyway, so

Re: r257533 - D9600: Add scan-build python implementation

Thanks for the clarification. On Thursday, January 14, 2016, Laszlo Nagy wrote: > yes, it is just an initial drop. improvements are planed to make a full > replacement of the one written in Perl. > > On Thu, Jan 14, 2016 at 12:14 AM, Ismail Donmez

[PATCH] D16154: Default vaarg lowering should support indirect struct types.

jyknight created this revision. jyknight added a subscriber: cfe-commits. Herald added subscribers: jyknight, dschuff, jfb. Fixes PR11517 for SPARC. On most targets, clang lowers va_arg itself, eschewing the use of the llvm vaarg instruction. This is necessary (at least for now) as the type

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

nwilson added a comment. In http://reviews.llvm.org/D15421#326144, @rsmith wrote: > Bikeshedding on the name a bit... how about `__type_pack_element`? Hmm, I kind of felt like having `nth` in there implied we're indexing into something... What about `__nth_pack_element`?

Re: [PATCH] D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool.

nwilson added a comment. Please let me know if the subject or summary of this Patch is ambiguous. http://reviews.llvm.org/D16163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r257682 - Fix PR#25973 : 'basic_string::assign(InputIt, InputIt) doesn't provide the strong exception safety guarantee'. This turned out to be a pervasive problem in , which required

Author: marshall Date: Wed Jan 13 15:54:34 2016 New Revision: 257682 URL: http://llvm.org/viewvc/llvm-project?rev=257682=rev Log: Fix PR#25973 : 'basic_string::assign(InputIt, InputIt) doesn't provide the strong exception safety guarantee'. This turned out to be a pervasive problem in , which

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

hokein added inline comments. Comment at: clang-tidy/tool/ClangTidyMain.cpp:78 @@ +77,3 @@ +static cl::opt +HeaderFileExtensions("header-file-extensions", + cl::desc("File extensions that regard as header file.\n" alexfh wrote: > We don't need

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

rsmith added inline comments. Comment at: include/clang/Basic/Builtins.h:216-219 @@ -215,3 +215,6 @@ /// \brief This names the __make_integer_seq BuiltinTemplateDecl. BTK__make_integer_seq + + /// \brief This names the __nth_element BuiltinTemplateDecl. + ,

Re: r257710 - [Sema] Suppress diags in overload resolution.

Thanks! Richard, what say the code owner? On Wed, Jan 13, 2016 at 3:59 PM, George Burgess IV wrote: > FYI: This patch should to be merged into the clang 3.8.0 branch. > > Thank you! > George > > On Wed, Jan 13, 2016 at 3:36 PM, George Burgess IV via cfe-commits >

[libcxx] r257721 - Merging r257702:

Author: hans Date: Wed Jan 13 18:02:08 2016 New Revision: 257721 URL: http://llvm.org/viewvc/llvm-project?rev=257721=rev Log: Merging r257702: r257702 | marshall | 2016-01-13 15:05:15 -0800 (Wed, 13 Jan 2016) | 1 line

[libcxx] r257720 - Merging r257696:

Author: hans Date: Wed Jan 13 18:01:17 2016 New Revision: 257720 URL: http://llvm.org/viewvc/llvm-project?rev=257720=rev Log: Merging r257696: r257696 | marshall | 2016-01-13 14:52:36 -0800 (Wed, 13 Jan 2016) | 1 line Fix

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

rsmith added a comment. Bikeshedding on the name a bit... how about `__type_pack_element`? http://reviews.llvm.org/D15421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16158: [CMake] Add clang's targets to LLVM's export set when not building standalone

beanz created this revision. beanz added reviewers: rnk, chapuni, hintonda. beanz added a subscriber: cfe-commits. CMake freaks out in trivial cases like: > cmake -G Ninja -DLLVM_ENABLE_PIC=Off -DLLVM_INSTALL_TOOLCHAIN_ONLY=On ../llvm This is a result of static ink dependencies not all being

Re: r257533 - D9600: Add scan-build python implementation

yes, it is just an initial drop. improvements are planed to make a full replacement of the one written in Perl. On Thu, Jan 14, 2016 at 12:14 AM, Ismail Donmez wrote: > Hi, > > On Wed, Jan 13, 2016 at 12:38 AM, Laszlo Nagy via cfe-commits > wrote: >

[libcxx] r257716 - Merging r257682:

Author: hans Date: Wed Jan 13 17:53:40 2016 New Revision: 257716 URL: http://llvm.org/viewvc/llvm-project?rev=257716=rev Log: Merging r257682: r257682 | marshall | 2016-01-13 13:54:34 -0800 (Wed, 13 Jan 2016) | 1 line Fix

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

On Wed, Jan 13, 2016 at 2:31 PM, Nathan Wilson wrote: > nwilson added a comment. > > In http://reviews.llvm.org/D15421#326144, @rsmith wrote: > > > Bikeshedding on the name a bit... how about `__type_pack_element`? > > Hmm, I kind of felt like having `nth` in there implied

[libcxx] r257696 - Fix test for C++03 - lacking noexcept

Author: marshall Date: Wed Jan 13 16:52:36 2016 New Revision: 257696 URL: http://llvm.org/viewvc/llvm-project?rev=257696=rev Log: Fix test for C++03 - lacking noexcept Modified: libcxx/trunk/test/libcxx/strings/iterators.exceptions.pass.cpp Modified:

Re: [PATCH] D15686: PR25910: clang allows two var definitions with the same mangled name

rjmccall added a comment. Yes, this seems to be exactly what I wanted, thanks! LGTM. http://reviews.llvm.org/D15686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16080: [CUDA] Add tests for compiling CUDA files with -E.

jlebar marked 2 inline comments as done. jlebar added a comment. Thank you for the review, Artem. http://reviews.llvm.org/D16080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:550 @@ -548,1 +549,3 @@ case BuiltinType::Double: +// FIXME: For targets where lond double and __float128 have the same size, +// they are currently indistinguishable in the debugger

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pxli168 updated this revision to Diff 44826. pxli168 added a comment. Fix format of diag err string, remove useless ':' after expecting. http://reviews.llvm.org/D15914 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

On Wed, Jan 13, 2016 at 6:48 PM, Richard Smith wrote: > On Wed, Jan 13, 2016 at 3:41 PM, Arthur O'Dwyer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Following Louis' suggestion, how about __pack_nth? >> > > Maybe just __pack_element, to mirror its intended

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

hubert.reinterpretcast added inline comments. Comment at: include/clang/AST/DeclTemplate.h:375 @@ +374,3 @@ + bool isConcept() const { return TemplatedDecl.getInt(); } + void setConcept(bool IC) { TemplatedDecl.setInt(true); } + nwilson wrote: >

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

alexfh added a subscriber: jroelofs. alexfh added a comment. In http://reviews.llvm.org/D15528#326031, @jroelofs wrote: > Hmm. There's no "close revision" button. Abandoning it in lieu of closing it. Weird. That's probably because I've not marked it "Accepted". Now I tried a few other actions

[PATCH] D16171: Warning on redeclaring with a conflicting asm label

weimingz created this revision. weimingz added a reviewer: nicholas. weimingz added a subscriber: cfe-commits. r255371 errors on redeclaring with a conflicting asm label. This patch changes errors to warnings to prevent breaking existing codes. http://reviews.llvm.org/D16171 Files:

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson added inline comments. Comment at: include/clang/AST/DeclTemplate.h:375 @@ +374,3 @@ + bool isConcept() const { return TemplatedDecl.getInt(); } + void setConcept(bool IC) { TemplatedDecl.setInt(true); } + hubert.reinterpretcast wrote: > The parameter

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

On Wed, Jan 13, 2016 at 3:41 PM, Arthur O'Dwyer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Following Louis' suggestion, how about __pack_nth? > Maybe just __pack_element, to mirror its intended use to implement things like tuple_element? (I'm not completely happy about using this

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson added inline comments. Comment at: include/clang/AST/DeclTemplate.h:377 @@ -376,3 +376,3 @@ NamedDecl *TemplatedDecl; TemplateParameterList* TemplateParams; I can't seem to follow the link properly, but I'm assuming it's supposed to be where

Re: [PATCH] D16080: [CUDA] Add tests for compiling CUDA files with -E.

jlebar updated this revision to Diff 44823. jlebar added a comment. Address tra's review comments. http://reviews.llvm.org/D16080 Files: test/Preprocessor/cuda-preprocess.cu Index: test/Preprocessor/cuda-preprocess.cu === ---

Re: [PATCH] D16080: [CUDA] Add tests for compiling CUDA files with -E.

jlebar marked 2 inline comments as done. Comment at: test/Driver/cuda-preprocess.cu:13-16 @@ +12,6 @@ + +// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_20 %s 2>&1 \ +// RUN: | FileCheck -check-prefix NOARCH %s +// RUN: %clang -E -target x86_64-linux-gnu

r257738 - CodeGen: Only emit CFI unrelated cast checks for bit casts.

Author: pcc Date: Wed Jan 13 20:49:48 2016 New Revision: 257738 URL: http://llvm.org/viewvc/llvm-project?rev=257738=rev Log: CodeGen: Only emit CFI unrelated cast checks for bit casts. We were previously emitting them for no-op casts (e.g. implicit casts to const). Modified:

r257739 - Driver: Remove SanitizerArgs::clear() function and SanitizerSet ctor,

Author: pcc Date: Wed Jan 13 20:49:51 2016 New Revision: 257739 URL: http://llvm.org/viewvc/llvm-project?rev=257739=rev Log: Driver: Remove SanitizerArgs::clear() function and SanitizerSet ctor, replace with in-class initializers. Modified: cfe/trunk/include/clang/Basic/Sanitizers.h

[PATCH] D16175: Introduce -fsanitize-stats flag.

pcc created this revision. pcc added reviewers: kcc, eugenis. pcc added a subscriber: cfe-commits. This is part of a new statistics gathering feature for the sanitizers. See clang/docs/SanitizerStats.rst for further info and docs. http://reviews.llvm.org/D16175 Files: docs/SanitizerStats.rst

[clang-tools-extra] r257642 - Teach clang-tidy how to upgrade warnings into errors.

Author: jroelofs Date: Wed Jan 13 11:36:41 2016 New Revision: 257642 URL: http://llvm.org/viewvc/llvm-project?rev=257642=rev Log: Teach clang-tidy how to upgrade warnings into errors. Similar in format to the `-checks=` argument, this new `-warnings-as-errors=` argument upgrades any warnings