r262691 - [MIPS] initFeatureMap() to handle empty string argument

Author: bhushan.attarde Date: Fri Mar 4 00:56:29 2016 New Revision: 262691 URL: http://llvm.org/viewvc/llvm-project?rev=262691=rev Log: [MIPS] initFeatureMap() to handle empty string argument SUMMARY: This patch sets CPU string to its default value when it is not supplied by

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

On Thu, Mar 03, 2016 at 04:50:11PM -0800, Nico Weber via cfe-commits wrote: > On Thu, Mar 3, 2016 at 4:28 PM, Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Thu, Mar 03, 2016 at 02:09:17PM -0800, Nico Weber via cfe-commits wrote: > > > On Thu, Mar 3, 2016 at

Re: [PATCH] D17849: [clang-tidy] Make 'modernize-use-nullptr' check work on multiple nested implicit cast expressions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262698: [clang-tidy] Make 'modernize-use-nullptr' check work on multiple nested… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D17849?vs=49736=49802#toc Repository: rL LLVM

[clang-tools-extra] r262698 - [clang-tidy] Make 'modernize-use-nullptr' check work on multiple nested implicit cast expressions.

Author: hokein Date: Fri Mar 4 02:55:54 2016 New Revision: 262698 URL: http://llvm.org/viewvc/llvm-project?rev=262698=rev Log: [clang-tidy] Make 'modernize-use-nullptr' check work on multiple nested implicit cast expressions. Summary: For some test cases like: ``` int func(int, void*,

r262697 - [Coverage] Fix the start/end locations of switch statements

Author: vedantk Date: Fri Mar 4 02:07:15 2016 New Revision: 262697 URL: http://llvm.org/viewvc/llvm-project?rev=262697=rev Log: [Coverage] Fix the start/end locations of switch statements While pushing switch statements onto the region stack we neglected to specify their start/end locations.

r262699 - [OPENMP 4.0] Codegen for 'declare reduction' construct.

Author: abataev Date: Fri Mar 4 03:22:22 2016 New Revision: 262699 URL: http://llvm.org/viewvc/llvm-project?rev=262699=rev Log: [OPENMP 4.0] Codegen for 'declare reduction' construct. Emit function for 'combiner' part of 'declare reduction' construct and 'initialilzer' part, if any. Added:

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:237 @@ +236,3 @@ +/// related to the same file entry are put into the same vector. +FileToReplacementsMap groupReplacementsByFile(const Replacements , +

r262700 - [SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations

Author: labath Date: Fri Mar 4 04:00:08 2016 New Revision: 262700 URL: http://llvm.org/viewvc/llvm-project?rev=262700=rev Log: [SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations Summary: While diagnosing a CXXNewExpr warning, we were calling isInSystemHeader(), which

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric updated this revision to Diff 49806. ioeric marked 3 inline comments as done. ioeric added a comment. - Moved formatAndApplyAllReplacements to Tooling/Refactoing; added an overloaded version of formatAndApplyAllReplacements that takes no Style; groupReplacementsByFile groups Replacements

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric updated this revision to Diff 49807. ioeric added a comment. - removed unused forward declarations. http://reviews.llvm.org/D17852 Files: include/clang/Basic/SourceManager.h include/clang/Format/Format.h include/clang/Tooling/Core/Replacement.h

Re: [PATCH] D17816: [PPC] FE support for generating VSX [negated] absolute value instructions

amehsan updated this revision to Diff 49822. amehsan added a comment. added -ferror-limit 0 to the command line for no-altivec test. fixed indentation of RUN commands confirmed that all tests pass in a release and minrelsize build types changed {{[0-9]*}} to {{.*}} (it was fine but no need to

Re: [PATCH] D17816: [PPC] FE support for generating VSX [negated] absolute value instructions

amehsan marked 4 inline comments as done. amehsan added a comment. http://reviews.llvm.org/D17816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17547: [OpenMP] Add support for multidimensional array sections in map clause SEMA.

sfantao marked an inline comment as done. Comment at: lib/Sema/SemaOpenMP.cpp:9127 @@ +9126,3 @@ +// whose base type is \a BaseQTy. +static bool CheckArrayExpressionDoesNotReferToUnitySize(Sema , + const Expr *E,

[libcxxabi] r262717 - Reducing stack usage of test

Author: bcraig Date: Fri Mar 4 08:25:13 2016 New Revision: 262717 URL: http://llvm.org/viewvc/llvm-project?rev=262717=rev Log: Reducing stack usage of test This test has a lot of classes with large amounts of manually inserted padding in them, presumably to prevent various optimizations. The

r262716 - Move class into anonymous namespace. NFC.

Author: d0k Date: Fri Mar 4 08:18:52 2016 New Revision: 262716 URL: http://llvm.org/viewvc/llvm-project?rev=262716=rev Log: Move class into anonymous namespace. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp Modified:

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

On 3/4/2016 6:23 AM, Joerg Sonnenberger via cfe-commits wrote: On Thu, Mar 03, 2016 at 04:50:11PM -0800, Nico Weber via cfe-commits wrote: On Thu, Mar 3, 2016 at 4:28 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: On Thu, Mar 03, 2016 at 02:09:17PM -0800, Nico

Re: r262688 - [X86] Pass __m64 types via SSE registers for GCC compatibility

It'd be nice to have a comment here that mentions that the clang behavior which is being preserved for Darwin, FreeBSD, and PS4 is a *bug* which is being intentionally left unfixed. The previous clang behavior directly contradicts the x86_64 ABI document, which I believe all of these platforms

Re: [PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

This revision was automatically updated to reflect the committed changes. jyknight marked an inline comment as done. Closed by commit rL262737: Make TargetInfo store an actual DataLayout instead of a string. (authored by jyknight). Changed prior to commit:

Re: [PATCH] D17890: [OpenMP][NVPTX][CUDA] Adding support for printf for an NVPTX OpenMP device.

arpith-jacob added a comment. Thanks for the quick review! The test cases are the same as the CUDA version so it should be fine. http://reviews.llvm.org/D17890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r262688 - [X86] Pass __m64 types via SSE registers for GCC compatibility

Ah, great! I always love it when people document their ABIs. Is your ABI document public? If so, could you add it to docs/CompilerWriterInfo.rst? On Fri, Mar 4, 2016 at 11:54 AM, Robinson, Paul wrote: >> It'd be nice to have a comment here that mentions that

r262737 - Make TargetInfo store an actual DataLayout instead of a string.

Author: jyknight Date: Fri Mar 4 13:00:41 2016 New Revision: 262737 URL: http://llvm.org/viewvc/llvm-project?rev=262737=rev Log: Make TargetInfo store an actual DataLayout instead of a string. Use it to calculate UserLabelPrefix, instead of specifying it (often incorrectly). Note that the

Re: [PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

jbcoe added a comment. I think there are some minor issues with the tests, easily fixed. I wonder if the matchers can catch things inside implementation-defined inline namespaces like `std::_v1_::experimental::library_fundamentals_v1::string_view`. Comment at:

r262729 - [analyzer] Add diagnostic in ObjCDeallocChecker for use of -dealloc instead of -release.

Author: dcoughlin Date: Fri Mar 4 12:09:58 2016 New Revision: 262729 URL: http://llvm.org/viewvc/llvm-project?rev=262729=rev Log: [analyzer] Add diagnostic in ObjCDeallocChecker for use of -dealloc instead of -release. In dealloc methods, the analyzer now warns when -dealloc is called directly

Re: r262691 - [MIPS] initFeatureMap() to handle empty string argument

Test case? On Fri, Mar 4, 2016, 4:02 AM Bhushan D. Attarde via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: bhushan.attarde > Date: Fri Mar 4 00:56:29 2016 > New Revision: 262691 > > URL: http://llvm.org/viewvc/llvm-project?rev=262691=rev > Log: > [MIPS] initFeatureMap() to handle

Re: r262691 - [MIPS] initFeatureMap() to handle empty string argument

I've followed up to the original thread, but I'm fairly certain this isn't the right patch here. -eric On Fri, Mar 4, 2016 at 10:28 AM Eric Christopher wrote: > Test case? > > On Fri, Mar 4, 2016, 4:02 AM Bhushan D. Attarde via cfe-commits < > cfe-commits@lists.llvm.org>

Re: [PATCH] D16139: [MIPS] initFeatureMap() to handle empty string argument

echristo added a subscriber: echristo. echristo added a comment. This seems wrong. You should fix setCPU instead or set a default CPU. Repository: rL LLVM http://reviews.llvm.org/D16139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. I may have more comments when I catch up on email next week. Just a drive-by as I added myself as reviewer. Comment at:

r262743 - Update cxx_status with likely new features from Jacksonville WG21 meeting.

Author: rsmith Date: Fri Mar 4 15:01:14 2016 New Revision: 262743 URL: http://llvm.org/viewvc/llvm-project?rev=262743=rev Log: Update cxx_status with likely new features from Jacksonville WG21 meeting. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL:

r262742 - Switch krait to use -mcpu=cortex-a15 for assembler tool invocations.

Author: srhines Date: Fri Mar 4 14:57:22 2016 New Revision: 262742 URL: http://llvm.org/viewvc/llvm-project?rev=262742=rev Log: Switch krait to use -mcpu=cortex-a15 for assembler tool invocations. Summary: Using -no-integrated-as causes -mcpu=krait to be transformed into -march=armv7-a today.

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

arpith-jacob marked 15 inline comments as done. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:348 @@ +347,2 @@ + initializeEnvironment(); +} This function will also handle global variables from the 'declare target' construct in the future. void

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

pcc added inline comments. Comment at: include/clang/Basic/Attr.td:1543 @@ +1542,3 @@ + let Subjects = SubjectList<[Record]>; + let Documentation = [Undocumented]; +} aaron.ballman wrote: > No new undocumented attributes, please. Same below. Yes, sorry, forgot

Re: [PATCH] D17874: Switch krait to use -mcpu=cortex-a15 for assembler tool invocations.

weimingz accepted this revision. weimingz added a comment. This revision is now accepted and ready to land. Ana is OK with it. http://reviews.llvm.org/D17874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262741 - [OPENMP] Codegen for distribute directive

Author: cbertol Date: Fri Mar 4 14:24:58 2016 New Revision: 262741 URL: http://llvm.org/viewvc/llvm-project?rev=262741=rev Log: [OPENMP] Codegen for distribute directive This patch provide basic implementation of codegen for teams directive, excluding all clauses except dist_schedule. It also

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 262741. Repository: rL LLVM http://reviews.llvm.org/D17170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262744 - Revert r262741 - [OPENMP] Codegen for distribute directive

Author: sfantao Date: Fri Mar 4 15:02:14 2016 New Revision: 262744 URL: http://llvm.org/viewvc/llvm-project?rev=262744=rev Log: Revert r262741 - [OPENMP] Codegen for distribute directive Was causing a failure in one of the buildbot slaves. Removed:

r262749 - clang-cl: Enable PCH flags by default.

Author: nico Date: Fri Mar 4 15:59:42 2016 New Revision: 262749 URL: http://llvm.org/viewvc/llvm-project?rev=262749=rev Log: clang-cl: Enable PCH flags by default. Now that pragma comment and pragma detect_mismatch are implemented, this might just work. Some pragmas aren't serialized yet (from

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

arpith-jacob updated this revision to Diff 49851. arpith-jacob added a comment. Addressed feedback; see inline comments for details. http://reviews.llvm.org/D17877 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

djasper added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:228 @@ -226,3 +227,3 @@ /// \pre Replacements must be for the same file. -std::vector -calculateChangedRangesInFile(const tooling::Replacements ); +std::vector calculateChangedRangesInFile(const

Re: [PATCH] D17874: Switch krait to use -mcpu=cortex-a15 for assembler tool invocations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262742: Switch krait to use -mcpu=cortex-a15 for assembler tool invocations. (authored by srhines). Changed prior to commit: http://reviews.llvm.org/D17874?vs=49791=49844#toc Repository: rL LLVM

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

ariccio updated this revision to Diff 49845. ariccio added a comment. Alrighty. This final version of the patch causes no test failures (vs the unmodified build*). *An unrelated test normally fails on my machine. http://reviews.llvm.org/D17688 Files:

Re: [PATCH] D16949: Fix for: Bug 5941 - improve diagnostic for * vs & confusion

This revision was automatically updated to reflect the committed changes. Closed by commit rL262752: PR5941 - improve diagnostic for * vs & confusion when choosing overload… (authored by dblaikie). Changed prior to commit: http://reviews.llvm.org/D16949?vs=49577=49856#toc Repository: rL

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

zaks.anna added a comment. http://reviews.llvm.org/D17688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262753 - Update diagnostics now that hexadecimal literals look likely to be part of C++17.

Author: rsmith Date: Fri Mar 4 16:32:06 2016 New Revision: 262753 URL: http://llvm.org/viewvc/llvm-project?rev=262753=rev Log: Update diagnostics now that hexadecimal literals look likely to be part of C++17. Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td

r262752 - PR5941 - improve diagnostic for * vs & confusion when choosing overload candidate with a parameter of incomplete (ref or pointer) type

Author: dblaikie Date: Fri Mar 4 16:29:11 2016 New Revision: 262752 URL: http://llvm.org/viewvc/llvm-project?rev=262752=rev Log: PR5941 - improve diagnostic for * vs & confusion when choosing overload candidate with a parameter of incomplete (ref or pointer) type Reviewers: dblaikie

Re: r262741 - [OPENMP] Codegen for distribute directive

Thanks - already reverted and I found the problem. Will push a new version soon. -- Carlo From: Nico Weber To: Carlo Bertolli/Watson/IBM@IBMUS Cc: cfe-commits Date: 03/04/2016 06:09 PM Subject:Re: r262741 - [OPENMP] Codegen

Re: r262741 - [OPENMP] Codegen for distribute directive

Looks like the new tests don't pass on Windows: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10365 On Mar 4, 2016 12:29 PM, "Carlo Bertolli via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: cbertol > Date: Fri Mar 4 14:24:58 2016 > New Revision: 262741 > > URL:

RE: r262688 - [X86] Pass __m64 types via SSE registers for GCC compatibility

> Ah, great! I always love it when people document their ABIs. > > Is your ABI document public? If so, could you add it to > docs/CompilerWriterInfo.rst? I don't think I was aware of that page... AFAIK ours is not available on-line, but I can raise the question internally. --paulr > > On Fri,

Re: [PATCH] D17682: [X86] AMD Bobcat CPU (btver1) doesn't support XSAVE

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D17682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14905: [constexpr-lambda] Support parsing of constexpr specifier (and its inference) on lambda expressions

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticParseKinds.td:772 @@ +771,3 @@ +def warn_cxx14_compat_constexpr_on_lambda : Warning< + "constexpr on lambda expressions are incompatible with C++14">, + InGroup, DefaultIgnore; are -> is

Re: [PATCH] D14905: [constexpr-lambda] Support parsing of constexpr specifier (and its inference) on lambda expressions

faisalv added a comment. *ping* http://reviews.llvm.org/D14905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

ryee88 updated this revision to Diff 49866. http://reviews.llvm.org/D16965 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/Parser/cxx-class.cpp Index: test/Parser/cxx-class.cpp === ---

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

ryee88 added a subscriber: dblaikie. ryee88 added a comment. Anyone care to take a look? http://reviews.llvm.org/D16965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

ariccio added a comment. In http://reviews.llvm.org/D17688#368330, @zaks.anna wrote: > ? http://reviews.llvm.org/D17688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262764 - Test commit: Fix run-on sentence in comment

Author: mps Date: Fri Mar 4 19:56:07 2016 New Revision: 262764 URL: http://llvm.org/viewvc/llvm-project?rev=262764=rev Log: Test commit: Fix run-on sentence in comment Modified: cfe/trunk/lib/Parse/ParseDecl.cpp Modified: cfe/trunk/lib/Parse/ParseDecl.cpp URL:

r262765 - Add null check to diagnostic path for lambda captures.

Author: rtrieu Date: Fri Mar 4 22:04:57 2016 New Revision: 262765 URL: http://llvm.org/viewvc/llvm-project?rev=262765=rev Log: Add null check to diagnostic path for lambda captures. Previously, the failed capture of a variable in nested lambdas may crash when the lambda pointer is null. Only

[PATCH] D17890: [OpenMP][NVPTX][CUDA] Adding support for printf for an NVPTX OpenMP device.

arpith-jacob created this revision. arpith-jacob added a reviewer: jlebar. arpith-jacob added subscribers: carlo.bertolli, sfantao, caomhin, cfe-commits. Support for CUDA printf is exploited to support printf for an NVPTX OpenMP device. To reflect the support of both programming models, the

RE: r262688 - [X86] Pass __m64 types via SSE registers for GCC compatibility

> It'd be nice to have a comment here that mentions that the clang > behavior which is being preserved for Darwin, FreeBSD, and PS4 is a > *bug* which is being intentionally left unfixed. The previous clang > behavior directly contradicts the x86_64 ABI document, which I believe > all of these