Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:57 @@ +56,3 @@ + + auto functionNameSourceRange = CharSourceRange::getCharRange( + PushBackExpr->getExprLoc(), Call->getArg(0)->getExprLoc()); capital letter?

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59561. Prazek marked an inline comment as done. Prazek added a comment. Fixed stuff http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/UseEmplaceCheck.cpp docs/ReleaseNotes.rst docs/clang-tidy/checks/modernize-use-emplace.rst Index:

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

dblaikie added a subscriber: dblaikie. dblaikie added a comment. Could you describe in more detail (ideally in the original patch review summary/description) what this transformation does? Under what conditions does it suggest emplace, etc. http://reviews.llvm.org/D20964

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:30 @@ +29,3 @@ + cxxMemberCallExpr(hasDeclaration(functionDecl(hasName(PushBackName))), +on(hasType(cxxRecordDecl(hasName(VectorName) + .bind("call");

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59568. Prazek added a comment. - Post review fix http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h

Re: [PATCH] D20961: [mips] Replace almost all Arch checks in MipsTargetInfo with ABI checks. NFC.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7347 @@ -7346,3 +7346,3 @@ def err_blocks_disable : Error<"blocks support disabled - compile with -fblocks" - " or pick a deployment target that supports them">; + " or %select{pick a

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

Anastasia added a comment. Do you think we could add any test for this change? Comment at: lib/CodeGen/BackendUtil.cpp:657 @@ -627,2 +656,3 @@ + bool EmitAssemblyHelper::AddEmitPasses(BackendAction Action, Remove the empty line please

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 4 inline comments as done. Comment at: docs/clang-tidy/checks/modernize-use-emplace.rst:6 @@ +5,3 @@ + +This check would look for cases when inserting new element into an STL +container, but the element is constructed temporarily or is constructed just

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 2 inline comments as done. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:40 @@ +39,3 @@ + // passed pointer because smart pointer won't be constructed + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl(

r271688 - Obj-C: Fix assert-on-invalid (PR27822)

Author: hans Date: Fri Jun 3 11:59:13 2016 New Revision: 271688 URL: http://llvm.org/viewvc/llvm-project?rev=271688=rev Log: Obj-C: Fix assert-on-invalid (PR27822) Clang would assert when isObjCInstancetype() was called on a tok::annot_cxxscope token. Modified:

r271689 - Fix test for LLVM_LIBDIR_SUFFIX=64 case.

Author: ismail Date: Fri Jun 3 12:06:52 2016 New Revision: 271689 URL: http://llvm.org/viewvc/llvm-project?rev=271689=rev Log: Fix test for LLVM_LIBDIR_SUFFIX=64 case. Modified: cfe/trunk/test/Driver/android-ndk-standalone.cpp Modified: cfe/trunk/test/Driver/android-ndk-standalone.cpp

[PATCH] D20966: [include-fixer] Add the missing header to the file where the unidentified symbol comes from.

hokein created this revision. hokein added reviewers: bkramer, ioeric. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D20966 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 2 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D20964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 4 inline comments as done. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:29 @@ +28,3 @@ + auto callPushBack = + cxxMemberCallExpr(hasDeclaration(functionDecl(hasName(PushBackName))), +

Re: [PATCH] D20963: [mips] The P5600 does not support N32/N64 since it's a 32-bit CPU.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be good idea to try this check with LLVM STL too. Comment at: docs/clang-tidy/checks/modernize-use-emplace.rst:47 @@ +46,3 @@ + +In this case the calls of push_back won't be

RE: r271413 - Fixup list of available extensions

Hi Jan, In the future could you please keep "[OpenCL]" prefix for all commit messages related to OpenCL. :) Thanks, Anastasia -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Jan Vesely via cfe-commits Sent: 01 June 2016 19:05 To:

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:31 @@ +30,3 @@ +on(hasType(cxxRecordDecl(hasName(VectorName) + .bind("call"); + ok, std::list works for me. I just don't want to spend much

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! http://reviews.llvm.org/D20090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59562. Prazek added a comment. Learning how to use arc http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp

Re: [PATCH] D20053: [clang-tidy] Add misc-unnecessary-mutable check.

etienneb added inline comments. Comment at: clang-tidy/misc/UnnecessaryMutableCheck.cpp:23 @@ +22,3 @@ + +// Matcher checking if the declaration is non-macro existent mutable which is +// not dependent on context. add an anonymous namespace around this

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:40 @@ +39,3 @@ + // passed pointer because smart pointer won't be constructed + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl(

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:40 @@ +39,3 @@ + // passed pointer because smart pointer won't be constructed + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl(

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

Prazek added a subscriber: Prazek. Prazek added a comment. besides it lgtm Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration

RE: r271413 - Fixup list of available extensions

No worries! Thanks! Anastasia -Original Message- From: Jan Vesely [mailto:jv...@scarletmail.rutgers.edu] On Behalf Of Jan Vesely Sent: 03 June 2016 18:35 To: Anastasia Stulova; cfe-commits@lists.llvm.org Cc: nd Subject: Re: r271413 - Fixup list of available extensions of course. sorry

[PATCH] D20979: [OpenCL] Use function attribute/metadata to represent kernel attributes

yaxunl created this revision. yaxunl added reviewers: Anastasia, bader, pxli168. yaxunl added subscribers: cfe-commits, tstellarAMD. This patch attempts to use target-dependent function attribute to represent reqd_work_group_size, work_group_size_hint and vector_type_hint kernel attributes and

Re: r271413 - Fixup list of available extensions

of course. sorry about that. I didn't realize the patches had different title from phabricator. Jan On Fri, 2016-06-03 at 17:14 +, Anastasia Stulova wrote: > Hi Jan, > > In the future could you please keep "[OpenCL]" prefix for all commit > messages related to OpenCL. :) > > Thanks, >

Re: Don't pass --build-id by default.

r271692, thanks. Cheers, Rafael On 3 June 2016 at 10:19, Ed Maste wrote: > On 2 June 2016 at 21:19, Hal Finkel via cfe-commits > wrote: >> - Original Message - >>> From: "Rafael Espíndola" >>> To: "Hal

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Jeroen, I am not quite sure what your question is about in (a). Regarding (b) please see example in test/SemaOpenCL/extensions.cl from the commit r269670. Please note that SPIR target supports all extensions but disables them by default (see commit r269670). The latter logic hasn't been

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59580. Prazek marked 4 inline comments as done. Prazek added a comment. - Review fixes http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

twoh added a subscriber: twoh. twoh closed this revision. twoh added a comment. I have commit in r271708: http://reviews.llvm.org/rL271708 http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

alexfh added a comment. In http://reviews.llvm.org/D20917#447046, @sbenza wrote: > Is it a typo in the description when it says that when RemoveStar is on we > will write 'auto*' instead if 'auto'? Yep, the whole patch description is a typo, fixed ;) http://reviews.llvm.org/D20917

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

alexfh updated this revision to Diff 59599. alexfh marked an inline comment as done. alexfh added a comment. - Updated formatting in the doc. http://reviews.llvm.org/D20917 Files: clang-tidy/modernize/UseAutoCheck.cpp clang-tidy/modernize/UseAutoCheck.h

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. Friendly ping... http://reviews.llvm.org/D20602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Don't pass --build-id by default.

On 2 June 2016 at 21:19, Hal Finkel via cfe-commits wrote: > - Original Message - >> From: "Rafael Espíndola" >> To: "Hal Finkel" >> Cc: "cfe-commits cfe" >> Sent: Thursday, June 2,

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added a comment. In http://reviews.llvm.org/D20964#448455, @Eugene.Zelenko wrote: > I think will be good idea to try this check with LLVM STL too. You mean llvm::SmallVector stuff? http://reviews.llvm.org/D20964 ___ cfe-commits mailing

r271701 - Test commit

Author: twoh Date: Fri Jun 3 13:27:39 2016 New Revision: 271701 URL: http://llvm.org/viewvc/llvm-project?rev=271701=rev Log: Test commit Modified: cfe/trunk/include/clang/Basic/Builtins.def Modified: cfe/trunk/include/clang/Basic/Builtins.def URL:

r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

Author: twoh Date: Fri Jun 3 13:52:51 2016 New Revision: 271708 URL: http://llvm.org/viewvc/llvm-project?rev=271708=rev Log: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths. Differential Revision: http://reviews.llvm.org/D19843

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

Prazek added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list. -if (Dec == *D->decl_begin()) -

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

jlebar accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaDeclAttr.cpp:4044 @@ +4043,3 @@ +// Checks whether an argument of launch_bounds attribute is +// acceptable, performs implicit conversion to Rvalue and returns +// non-nullptr

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

Also, once that is resolved, this warning tells people that #include is wrong: ..\..\third_party\ffmpeg\compat/w32pthreads.h(39,10): warning: non-portable path to file ''; specified path differs in case from file name on disk [-Wnonportable-include-path] #include ^~~

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

tra updated this revision to Diff 59631. tra marked an inline comment as done. tra added a comment. Rephrased comments http://reviews.llvm.org/D20985 Files: lib/Sema/SemaDeclAttr.cpp test/CodeGenCUDA/launch-bounds.cu test/SemaCUDA/pr27778.cu Index: test/SemaCUDA/pr27778.cu

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

jlebar added a comment. How is this different from test/SemaCUDA/launch_bounds.cu:27-28? It does const int constint = 512; __launch_bounds__(constint) void TestConstInt(void); which looks verbatim the same as this testcase. http://reviews.llvm.org/D20985

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

tra updated this revision to Diff 59624. tra added a comment. Addressed Justin's comments. http://reviews.llvm.org/D20985 Files: lib/Sema/SemaDeclAttr.cpp test/CodeGenCUDA/launch-bounds.cu test/SemaCUDA/pr27778.cu Index: test/SemaCUDA/pr27778.cu

Re: [PATCH] D20853: [clang-tidy] misc-macro-parentheses: Don't insert parentheses in variable declarations. Fixes bugzilla 26273

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a few style comments. Comment at: clang-tidy/misc/MacroParenthesesCheck.cpp:82 @@ +81,3 @@ + + // If we see int/short/struct etc just assume this is a

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

tra marked 3 inline comments as done. Comment at: lib/Sema/SemaDeclAttr.cpp:4046 @@ +4045,3 @@ +// non-nullptr Expr result on success. Returns nullptr otherwise and +// may output an error. +static Expr *makeLaunchBoundsArgExpr(Sema , Expr *E, jlebar wrote: >

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

It's not just windows.h, but windows sdk headers in general (#include , #include #include #include etc). Here's what the warning does on the first few files in Chromium: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/8155/steps/compile/logs/stdio (We add /FIIntrin.h --

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

teemperor added a comment. The previous stats were wrong (only applied this patch, not the patch using the code): Release: 63311672 Byte -> 77212960 Byte (+22% or +13.8 MB) http://reviews.llvm.org/D20382 ___ cfe-commits mailing list

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

alexfh added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list. -if (Dec == *D->decl_begin()) -

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

yaxunl updated this revision to Diff 59630. yaxunl marked 10 inline comments as done. yaxunl added a comment. Add a sema test for mismatched type size. Fix codegen test. http://reviews.llvm.org/D20133 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGenOpenCL/as_type.cl

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

yaxunl added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:3394 @@ +3393,3 @@ + if (NumElementsDst == 4) +Args.push_back(llvm::UndefValue::get(CGF.Int32Ty)); + llvm::Constant *Mask = llvm::ConstantVector::get(Args); Anastasia wrote: > should

Re: r271692 - Don't pass --build-id to ld by default.

Can you add this to the release notes? It'll for example break chromium's crash server (we can fix this on our end by explicitly passing -Wl,--build-id for release builds, but we only saw this commit fly by by chance.) On Fri, Jun 3, 2016 at 1:26 PM, Rafael Espindola via cfe-commits <

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

jlebar added a comment. In http://reviews.llvm.org/D20985#448836, @tra wrote: > In http://reviews.llvm.org/D20985#448822, @jlebar wrote: > > > How is this different from test/SemaCUDA/launch_bounds.cu:27-28? It does > > > > const int constint = 512; > > __launch_bounds__(constint) void

[libunwind] r271737 - [libunwind] Remove unused code.

Author: asiri Date: Fri Jun 3 15:57:48 2016 New Revision: 271737 URL: http://llvm.org/viewvc/llvm-project?rev=271737=rev Log: [libunwind] Remove unused code. The whole file is guarded with #if _LIBUNWIND_ARM_EHABI, and then in the middle we have these two blocks, which render them pretty

Re: r271692 - Don't pass --build-id to ld by default.

On 3 June 2016 at 15:53, Nico Weber via cfe-commits wrote: > Can you add this to the release notes? It'll for example break chromium's > crash server (we can fix this on our end by explicitly passing > -Wl,--build-id for release builds, but we only saw this commit fly

[PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

tra created this revision. tra added reviewers: rsmith, jlebar. tra added a subscriber: cfe-commits. Fixes clang crash reported in PR27778. http://reviews.llvm.org/D20985 Files: lib/Sema/SemaDeclAttr.cpp test/CodeGenCUDA/launch-bounds.cu test/SemaCUDA/pr27778.cu Index:

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

tra added a comment. In http://reviews.llvm.org/D20985#448822, @jlebar wrote: > How is this different from test/SemaCUDA/launch_bounds.cu:27-28? It does > > const int constint = 512; > __launch_bounds__(constint) void TestConstInt(void); > > > which looks verbatim the same as this

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL271739: [clang-tidy] modernize-use-auto: don't remove stars by default (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D20917?vs=59599=59625#toc Repository: rL LLVM

[clang-tools-extra] r271739 - [clang-tidy] modernize-use-auto: don't remove stars by default

Author: alexfh Date: Fri Jun 3 16:22:58 2016 New Revision: 271739 URL: http://llvm.org/viewvc/llvm-project?rev=271739=rev Log: [clang-tidy] modernize-use-auto: don't remove stars by default Summary: By default, modernize-use-auto check will retain stars when replacing an explicit type with

Re: [PATCH] D20856: [clang-tidy] readability-identifier-naming - Support for Type Aliases

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you for the patch! Do you need me to submit it? http://reviews.llvm.org/D20856 ___ cfe-commits mailing list

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I'm getting lots of warnings like so: In file included from ..\..\tools\win\static_initializers\static_initializers.cc:5: C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\DIA SDK\include\dia2.h(30,10): error: non-portable path to file '"Windows.h"'; specified path

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

On Fri, Jun 3, 2016 at 6:14 PM, Eric Niebler wrote: > I just checked, and warnings are not emitted from files in an -isystem > path. I didn’t have to do anything special to get that behavior. I don’t > know about -imsvc. Is that a clang-cl thing? I can’t say at this point why >

Re: [PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Removing from my dashboard until http://reviews.llvm.org/D20428 is submitted. http://reviews.llvm.org/D20693 ___ cfe-commits mailing

r271750 - CodeGen: correct assertion

Author: compnerd Date: Fri Jun 3 18:26:30 2016 New Revision: 271750 URL: http://llvm.org/viewvc/llvm-project?rev=271750=rev Log: CodeGen: correct assertion The assertion added earlier was overly strict. We need to strip the pointer casts (as when constructing the GV). Correct the types

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

The information about whether the file is in a system path is already being computed, so it would incur no extra overhead. I'm not sure that's the right fix. You are more than welcome to revert the (clang) commit while we think of the right fix. \e On Jun 3, 2016 5:25 PM, "Bruno Cardoso Lopes"

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

On Fri, Jun 3, 2016 at 7:07 PM, Eric Niebler wrote: > On 6/3/16, 3:24 PM, "tha...@google.com on behalf of Nico Weber" < > tha...@google.com on behalf of tha...@chromium.org> wrote: > > On Fri, Jun 3, 2016 at 6:14 PM, Eric Niebler wrote: > >> I just checked, and

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

jlebar added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4079 @@ +4078,3 @@ + if (ValArg.isInvalid()) +return nullptr; + OK, so then we want an assert, not an if? http://reviews.llvm.org/D20985 ___

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I think this should be reverted until we figure out how to solve it. Moreover, it looks expensive to check for each file if it's within a system path. I would really like to measure compile time for this change before it goes definitely in. On Fri, Jun 3, 2016 at 4:53 PM, Justin Bogner via

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

alexfh added a comment. Most of the fixits are still useless, but I didn't notice any false positives (i.e. all warnings would be useful to some degree). So I suggest disabling the fixes completely at least for now. Comment at: include/llvm-c/Core.h:604 @@ -603,3 +603,3 @@

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

> The information about whether the file is in a system path is already being > computed, so it would incur no extra overhead. I'm not sure that's the right > fix. You are more than welcome to revert the (clang) commit while we think > of the right fix. I'm not sure what the right fix is either,

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I can investigate the system header issue. And I could add a special exception for if folks feel that that’s the right thing to do. If we’re really worried about how noisy this warning could be, the warning could be disabled by default. Thoughts? Eric On 6/3/16, 2:46 PM,

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I just checked, and warnings are not emitted from files in an -isystem path. I didn’t have to do anything special to get that behavior. I don’t know about -imsvc. Is that a clang-cl thing? I can’t say at this point why the diagnostics system treats -isystem and -imsvc differently. How about

r271747 - Bump libclang API minor version after r271351.

Author: mren Date: Fri Jun 3 18:11:41 2016 New Revision: 271747 URL: http://llvm.org/viewvc/llvm-project?rev=271747=rev Log: Bump libclang API minor version after r271351. Also use the next enum value for CXObjCPropertyAttr_class. Modified: cfe/trunk/include/clang-c/Index.h Modified:

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

On 6/3/16, 3:24 PM, "tha...@google.com on behalf of Nico Weber" wrote: > On Fri, Jun 3, 2016 at 6:14 PM, Eric Niebler wrote: >> I just checked, and warnings are not emitted from files in an -isystem path. >> I didn’t have to

r271754 - PR27989: only enqueue binary operators into the data recursive int expression

Author: rsmith Date: Fri Jun 3 19:22:31 2016 New Revision: 271754 URL: http://llvm.org/viewvc/llvm-project?rev=271754=rev Log: PR27989: only enqueue binary operators into the data recursive int expression evaluator if they are actually int expressions. Modified:

r271758 - [Modules] Improve diagnostics for LockFileManager errors

Author: bruno Date: Fri Jun 3 20:13:22 2016 New Revision: 271758 URL: http://llvm.org/viewvc/llvm-project?rev=271758=rev Log: [Modules] Improve diagnostics for LockFileManager errors Uses error message now provided by LockFileManager in LLVM r271755. rdar://problem/26529101 Modified:

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:28 @@ +27,3 @@ + + auto callPushBack = + cxxMemberCallExpr(hasDeclaration(functionDecl(hasName(PushBackName))), Shouldn't it start with an uppercase letter?

Re: r271427 - [driver][arm] add armv7 and thumb include and lib paths

Fixed in r271689. On Fri, Jun 3, 2016 at 9:55 AM, Ismail Donmez wrote: > This is due to lib vs lib64. Will fix. Sorry for the wrong diagnosis :) > > On Thu, Jun 2, 2016 at 8:24 PM, Chih-hung Hsieh wrote: >> Ismail, >> I saw that android-ndk-standalone.cpp has

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda abandoned this revision. hintonda added a comment. This revision is OBE. http://reviews.llvm.org/D18575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:31 @@ +30,3 @@ +MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus) return; + clang-format

Re: [PATCH] D19165: [clang-tidy] Add modernize-increment-bool check.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. > -Wdeprecated-increment-bool does it. But what I see from SemaExpr.cpp in > CheckIncrementDecrementOperand, it doesn't have any fixits. If an automated fix for this issue makes

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

Taewook Oh via cfe-commits writes: > Author: twoh > Date: Fri Jun 3 13:52:51 2016 > New Revision: 271708 > > URL: http://llvm.org/viewvc/llvm-project?rev=271708=rev > Log: > Use the name of the file on disk to issue a new diagnostic about > non-portable #include and

Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno closed this revision. bruno added a comment. Applied your suggestions and committed in r271755! Thanks http://reviews.llvm.org/D20942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37 @@ +36,3 @@ + +It turns out that the common bug is to have function returning only bools but having int as

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

alexfh added a comment. Looks like a useful check to have. I'm not sure though, that it has anything to do with "modernize". I'd suggest adding a new "bugprone" module (should be added by http://reviews.llvm.org/D18821, hopefully soon) and moving the check there. Comment at:

Re: r271427 - [driver][arm] add armv7 and thumb include and lib paths

This is due to lib vs lib64. Will fix. Sorry for the wrong diagnosis :) On Thu, Jun 2, 2016 at 8:24 PM, Chih-hung Hsieh wrote: > Ismail, > I saw that android-ndk-standalone.cpp has already -stdlib=libstdc++. > Could you tell me or just go ahead and make the necessary change? >

Re: [PATCH] D20909: [clang-tidy] Ignore function context in misc-unused-using-decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271632: [clang-tidy] Ignore function context in misc-unused-using-decls. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20909?vs=59492=59494#toc Repository: rL LLVM

[clang-tools-extra] r271632 - [clang-tidy] Ignore function context in misc-unused-using-decls.

Author: hokein Date: Fri Jun 3 03:05:11 2016 New Revision: 271632 URL: http://llvm.org/viewvc/llvm-project?rev=271632=rev Log: [clang-tidy] Ignore function context in misc-unused-using-decls. Summary: Make the check's behavior more correct when handling using-decls in multiple scopes.

[PATCH] D20950: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. The further solution is to add the missing header to the file where the symbol comes from. http://reviews.llvm.org/D20950 Files: include-fixer/IncludeFixer.cpp

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

ioeric updated this revision to Diff 59497. ioeric added a comment. - Use FormatTokenLexer to skip comments. http://reviews.llvm.org/D20898 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

bkramer added a comment. There are still headers in this list that aren't part of glibc, like curses. I'd rather have those not in the list right now and add stuff as-needed later. I hope that other packages usually found in /usr/include are saner so we don't need to add a header map for them.

Re: [PATCH] D20909: [clang-tidy] Ignore function context in misc-unused-using-decls.

hokein updated this revision to Diff 59492. hokein added a comment. Address code comments. http://reviews.llvm.org/D20909 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp clang-tidy/misc/UnusedUsingDeclsCheck.h test/clang-tidy/misc-unused-using-decls.cpp Index:

[clang-tools-extra] r271660 - [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.

Author: hokein Date: Fri Jun 3 06:26:02 2016 New Revision: 271660 URL: http://llvm.org/viewvc/llvm-project?rev=271660=rev Log: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file. Summary: The further solution is to add the missing header to the file

Re: [PATCH] D20950: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271660: [include-fixer] Don't add missing header if the unindentified symbol isn't… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20950?vs=59496=59529#toc Repository: rL

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D20898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff updated this revision to Diff 59532. sepavloff added a comment. Fixed test for friend functions. http://reviews.llvm.org/D16989 Files: include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp test/SemaCXX/PR25848.cpp test/SemaCXX/friend2.cpp Index: test/SemaCXX/friend2.cpp

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added a comment. That could work :) I'm not sure my commit history is considered a "track record of submitting high quality patches" but I'll give it a try. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

Anastasia added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:3394 @@ +3393,3 @@ + if (NumElementsDst == 4) +Args.push_back(llvm::UndefValue::get(CGF.Int32Ty)); + llvm::Constant *Mask = llvm::ConstantVector::get(Args); should this be 3 unstead

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

ioeric updated this revision to Diff 59499. ioeric added a comment. - Removed non glibc header mapping. http://reviews.llvm.org/D20902 Files: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp Index: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp

  1   2   >