[PATCH] D21275: clang-format: [JS] Indent namespaces in JavaScript/TS by default.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added subscribers: cfe-commits, alexeagle. Herald added a subscriber: klimek. There's no convention of avoiding the nested indentation. http://reviews.llvm.org/D21275 Files: lib/Format/Format.cpp

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

xazax.hun closed this revision. xazax.hun added a comment. This was committad as the part of http://reviews.llvm.org/rL272529 http://reviews.llvm.org/D16044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21270: clang-rename: implement handling of remaining named casts

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG, although I believe the recent history of changes indicates that the approach is suboptimal, and we should address this on a higher level. But for now fixing the bugs seems like the right

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

Hi Steven, Great to see the commentary and updates here. I've got a few questions about some of this work. It might be nice to see some separate RFCs for a couple of things, but we'll figure that out after you send out patches probably :) What needs to be improved: > 1. Whitelist for command

[PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

jojo created this revision. jojo added reviewers: rengolin, jmolloy, bsmith, rsmith, labrinea. jojo added a subscriber: cfe-commits. jojo set the repository for this revision to rL LLVM. jojo changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users".

Re: [PATCH] D14277: [Analyzer] Make referenced SymbolMetadata live even if its region is dead

xazax.hun added a comment. Maybe it would be great to do a profiling before and after this patch? It looks like this is a hotspot of the analyzer: http://clang-developers.42468.n3.nabble.com/Analyzer-pretty-profiling-pictures-td4052016.html Repository: rL LLVM http://reviews.llvm.org/D14277

Re: [PATCH] D21270: clang-rename: implement handling of remaining named casts

vmiklos added a comment. Yes, if there will be a way to avoid hooking into each and every AST callback, that sounds more effective. :-) I'm aware of one more bug around destructors when renaming a class, but then I'm (as a user) quite happy about the current state.

[PATCH] D21278: Fix an enum-compare compliation warning message.

hokein created this revision. hokein added a reviewer: klimek. hokein added subscribers: cfe-commits, spatel. A follow-up fix on D21235. http://reviews.llvm.org/D21278 Files: lib/Target/X86/X86ISelLowering.cpp Index: lib/Target/X86/X86ISelLowering.cpp

Re: [PATCH] D21278: Fix an enumeral mismatch warning.

hokein added a comment. In http://reviews.llvm.org/D21278#455850, @klimek wrote: > LG. Fix the change description when submitting, though - this is not about an > enum comparison, right? Done. This is enumeral mismatch indeed. http://reviews.llvm.org/D21278

Re: [PATCH] D18309: sourceRange function for MemRegion

Alexander_Droste closed this revision. Alexander_Droste added a comment. This was committed, as part of http://reviews.llvm.org/rL272529. http://reviews.llvm.org/D18309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

klimek added a subscriber: cfe-commits. klimek added a comment. Generally, please subscribe cfe-commits when sending patches via phab. See http://llvm.org/docs/Phabricator.html Repository: rL LLVM http://reviews.llvm.org/D21279 ___ cfe-commits

r272540 - [Clang][X86] Convert non-temporal store builtins to generic __builtin_nontemporal_store in headers

Author: rksimon Date: Mon Jun 13 04:57:52 2016 New Revision: 272540 URL: http://llvm.org/viewvc/llvm-project?rev=272540=rev Log: [Clang][X86] Convert non-temporal store builtins to generic __builtin_nontemporal_store in headers We can now use __builtin_nontemporal_store instead of target

Re: [PATCH] D21273: clang-format: [JS] Introduce WrapJavaScriptImports option.

djasper added inline comments. Comment at: include/clang/Format/Format.h:631 @@ +630,3 @@ + /// \brief Whether to wrap JavaScript import/export statements. + bool WrapJavaScriptImports; + Wondering whether we should call this JavaScriptWrapImports so that the

r272536 - clang-format: Fix incorrect cast detection.

Author: djasper Date: Mon Jun 13 02:49:09 2016 New Revision: 272536 URL: http://llvm.org/viewvc/llvm-project?rev=272536=rev Log: clang-format: Fix incorrect cast detection. Before: auto s = sizeof...(Ts)-1; After: auto s = sizeof...(Ts) - 1; Modified:

r272537 - clang-format: Don't merge const and &, e.g. in function ref qualifiers.

Author: djasper Date: Mon Jun 13 02:49:28 2016 New Revision: 272537 URL: http://llvm.org/viewvc/llvm-project?rev=272537=rev Log: clang-format: Don't merge const and &, e.g. in function ref qualifiers. Before (when aligning & to the right): SomeType MemberFunction(const Deleted &) const&;

r272538 - clang-format: Fix incorrect function type detection.

Author: djasper Date: Mon Jun 13 02:49:35 2016 New Revision: 272538 URL: http://llvm.org/viewvc/llvm-project?rev=272538=rev Log: clang-format: Fix incorrect function type detection. Before: returnsFunction (, )(param); After: returnsFunction(, )(param); Modified:

r272535 - clang-format: Don't indent lambda body relative to its return type.

Author: djasper Date: Mon Jun 13 02:48:45 2016 New Revision: 272535 URL: http://llvm.org/viewvc/llvm-project?rev=272535=rev Log: clang-format: Don't indent lambda body relative to its return type. Before: []() // -> int { return 1; // }; After: []() // -> int {

Re: [PATCH] D21278: Fix an enum-compare compliation warning message.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. Fix the change description when submitting, though - this is not about an enum comparison, right? http://reviews.llvm.org/D21278 ___

Re: [PATCH] D21278: Fix an enumeral mismatch warning.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272539: Fix an enumeral mismatch warning. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21278?vs=60494=60498#toc Repository: rL LLVM http://reviews.llvm.org/D21278 Files:

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping. http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18120: Message Passing Interface mock header

Alexander_Droste closed this revision. Alexander_Droste added a comment. This was committed, as part of http://reviews.llvm.org/rL272529. http://reviews.llvm.org/D18120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r272541 - Fix unused variable warning

Author: rksimon Date: Mon Jun 13 05:05:19 2016 New Revision: 272541 URL: http://llvm.org/viewvc/llvm-project?rev=272541=rev Log: Fix unused variable warning Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp URL:

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

anemet added a comment. Ping^3 http://reviews.llvm.org/D19403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

On Mon, Jun 13, 2016 at 11:55 AM, Michael Spertus wrote: > Hi David, > While I understand the initial reasoning. I have found that this is like a > hundred times better for working on Clang in practice and can't imagine > working without it. The point is that many Clang data

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

compnerd added a subscriber: compnerd. Comment at: lib/Basic/Targets.cpp:5709 @@ -5715,1 +5708,3 @@ + +return false; } Please collapse this: return Name == "generic" || llvm::AArch64::parseCPUArch(Name) != llvm::ARM::AK_INVALID;

Re: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

yaxunl retitled this revision from "[OpenCL] Use function attribute/metadata to represent kernel attributes" to "[OpenCL] Use function metadata to represent kernel attributes". yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 60545.

Re: [PATCH] D21295: Add a negative TBAA test

rogfer01 added inline comments. Comment at: test/CodeGen/tbaa.cpp:57 @@ +56,3 @@ +// NO-TBAA-LABEL: define i32 @_Z1g +// NO-TBAA: store i32 1, i32* %{{.*}}, align 4{{ *$}} +// NO-TBAA: store i32 4, i32* %{{.*}}, align 4{{ *$}} jmolloy wrote: > Would it just be

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

mclow.lists added a comment. > Apologies, not at program launch time but link time. I'm OK with that; I think that's unnecessary complication, but not a deal-breaker. The choosing at program launch seems unworkable to me. [ I think that the threading implementation should be chosen by the

[PATCH] D21298: delete null check

SilverGeri created this revision. SilverGeri added a reviewer: xazax.hun. SilverGeri added a subscriber: cfe-commits. removes the unnecessary if statements, if it was used to check a pointer's validity just to call delete on that pointer http://reviews.llvm.org/D21298 Files:

r272559 - clang-format: [JS] Indent namespaces in JavaScript/TS by default.

Author: mprobst Date: Mon Jun 13 11:41:28 2016 New Revision: 272559 URL: http://llvm.org/viewvc/llvm-project?rev=272559=rev Log: clang-format: [JS] Indent namespaces in JavaScript/TS by default. Summary: There's no convention of avoiding the nested indentation. Reviewers: djasper Subscribers:

Re: [PATCH] D20561: Warn when taking address of packed member

This revision was automatically updated to reflect the committed changes. Closed by commit rL272552: Warn when taking address of a packed member (authored by rogfer01). Changed prior to commit: http://reviews.llvm.org/D20561?vs=59342=60537#toc Repository: rL LLVM

r272552 - Warn when taking address of a packed member

Author: rogfer01 Date: Mon Jun 13 10:41:40 2016 New Revision: 272552 URL: http://llvm.org/viewvc/llvm-project?rev=272552=rev Log: Warn when taking address of a packed member This patch implements PR#22821. Taking the address of a packed member is dangerous since the reduced alignment of the

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. In http://reviews.llvm.org/D20328#456271, @mclow.lists wrote: > > I've adopted a initialize-on-first-use policy to workaround this > > particular problem. > > > That's not constexpr. > > You say it in your comment "This prohibits any prospects of calling a runtime >

Re: [PATCH] D21273: clang-format: [JS] Introduce WrapJavaScriptImports option.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272558: clang-format: [JS] Introduce JavaScriptWrapImports option. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D21273?vs=60532=60552#toc Repository: rL LLVM

r272549 - [X86][AVX512F] bugfix - sqrtps should get __mask16 as mask parameter

Author: abadouh Date: Mon Jun 13 10:15:57 2016 New Revision: 272549 URL: http://llvm.org/viewvc/llvm-project?rev=272549=rev Log: [X86][AVX512F] bugfix - sqrtps should get __mask16 as mask parameter CR: Michael Zuckerman Modified: cfe/trunk/lib/Headers/avx512fintrin.h

[PATCH] D21295: Add a negative TBAA test

rogfer01 created this revision. rogfer01 added a reviewer: rsmith. rogfer01 added a subscriber: cfe-commits. This commit extends tbaa.cpp to just make sure that tbaa markers are not emitted when they should not. http://reviews.llvm.org/D21295 Files: test/CodeGen/tbaa.cpp Index:

Re: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

yaxunl added a comment. I updated the patch to use function metadata only. Please review. Thanks. http://reviews.llvm.org/D20979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

On Mon, Jun 13, 2016 at 12:27 PM, Zachary Turner wrote: > I agree that it can be annoying to say "hey guys, i would normally do post > commit review on this, but i wanted to give the courtesy of a heads up", and > then potentially waiting an indeterminate amount of time. > > I

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7907 @@ -7904,1 +7906,3 @@ +def ext_opencl_ext_vector_type_rgba_selector: ExtWarn< + "vector component name '%0' is an OpenCL version 2.2 feature">; } // end of sema category

r272558 - clang-format: [JS] Introduce JavaScriptWrapImports option.

Author: mprobst Date: Mon Jun 13 11:39:50 2016 New Revision: 272558 URL: http://llvm.org/viewvc/llvm-project?rev=272558=rev Log: clang-format: [JS] Introduce JavaScriptWrapImports option. Summary: When turned on, clang-format wraps JavaScript imports (and importing exports), instead of forcing

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. In http://reviews.llvm.org/D20328#456241, @mclow.lists wrote: > > Apologies, not at program launch time but link time. > > > I'm OK with that; I think that's unnecessary complication, but not a > deal-breaker. > The choosing at program launch seems unworkable to me. >

[PATCH] D21289: [ubsan] Version names of handlers

filcab created this revision. filcab added reviewers: kcc, samsonov, rsmith. filcab added a subscriber: cfe-commits. This patch introduces a simple way to bump of all the handlers in UBSan. This way, we can easily break backwards compatibility without it being confusing for users (a bit like the

r272548 - clang-format: Restrict r272537 to function ref qualifiers.

Author: djasper Date: Mon Jun 13 09:45:12 2016 New Revision: 272548 URL: http://llvm.org/viewvc/llvm-project?rev=272548=rev Log: clang-format: Restrict r272537 to function ref qualifiers. Seems this isn't generally desirable. Before: int const * a; After: int const* a; Modified:

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

anemet added a comment. Thanks, Aaron! http://reviews.llvm.org/D19403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Add support for musl-libc on Linux

Should musl really be an environment? What happens when targeting ARM, do we get a gnueabi+musl? Is it used as an environment when configuring gcc? Cheers, Rafael On 13 June 2016 at 08:20, Lei Zhang via cfe-commits wrote: > 2016-06-13 3:07 GMT+08:00 Joerg

Re: Add support for musl-libc on Linux

On 13 June 2016 at 09:25, Lei Zhang wrote: > 2016-06-13 21:02 GMT+08:00 Rafael Espíndola : >> Should musl really be an environment? What happens when targeting ARM, >> do we get a gnueabi+musl? Is it used as an environment when >> configuring

Re: [PATCH] D21273: clang-format: [JS] Introduce WrapJavaScriptImports option.

mprobst updated this revision to Diff 60519. mprobst added a comment. - rename to JavaScriptWrapImports - re-alphabetize options list http://reviews.llvm.org/D21273 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

Anastasia added inline comments. Comment at: test/Headers/opencl-c-header.cl:53-54 @@ +52,4 @@ +// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o - -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -fdisable-module-hash -ftime-report

r272568 - Capture the resource directory and use it for subsequent checks.

Author: probinson Date: Mon Jun 13 12:41:05 2016 New Revision: 272568 URL: http://llvm.org/viewvc/llvm-project?rev=272568=rev Log: Capture the resource directory and use it for subsequent checks. This is the same tactic used in linux-header-search.cpp. Modified:

Re: [PATCH] D21250: Make test less sensitive to resource dir

probinson closed this revision. probinson added a comment. r272568, thanks! http://reviews.llvm.org/D21250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272569 - clang-format: [JS] Initialize new configuration value.

Author: mprobst Date: Mon Jun 13 12:50:10 2016 New Revision: 272569 URL: http://llvm.org/viewvc/llvm-project?rev=272569=rev Log: clang-format: [JS] Initialize new configuration value. Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp URL:

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

berenm added a comment. I think it's better to update the diff with full context (git diff -U99) rather than attach the file, in order to have it integrated into phabricator diff view. Or use the arcanist command-line tool, which should do it for you. Except from that, from a quick reading

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper removed rL LLVM as the repository for this revision. bmharper updated this revision to Diff 60569. bmharper added a comment. diff with full context http://reviews.llvm.org/D21279 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

twoh closed this revision. twoh added a comment. Re-commited in http://reviews.llvm.org/rL272562 http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272564 - [immintrin] Reimplement _bit_scan_{forward,reverse}

Author: majnemer Date: Mon Jun 13 12:26:16 2016 New Revision: 272564 URL: http://llvm.org/viewvc/llvm-project?rev=272564=rev Log: [immintrin] Reimplement _bit_scan_{forward,reverse} There is no need to use a target-specific intrinsic to implement _bit_scan_forward or _bit_scan_reverse,

r272571 - [CUDA][OpenMP] Create generic offload toolchains

Author: sfantao Date: Mon Jun 13 13:10:57 2016 New Revision: 272571 URL: http://llvm.org/viewvc/llvm-project?rev=272571=rev Log: [CUDA][OpenMP] Create generic offload toolchains Summary: This patch introduces the concept of offloading tool chain and offloading kind. Each tool chain may have

Re: [PATCH] D21243: Fix clang-tidy patterns to adapt to newly added ExprWithCleanups nodes.

timshen added a comment. In http://reviews.llvm.org/D21243#455999, @alexfh wrote: > Does this just fix the tests broken with http://reviews.llvm.org/D20498 or > have you looked at other checks that might be broken by > http://reviews.llvm.org/D20498, but don't have relevant tests? This just

Re: [PATCH] D21298: [Clang-tidy] delete null check

Eugene.Zelenko added a comment. Will be good idea to change some if statements in regression test to (p != nullptr) (for C++11) and (p != NULL) (pre-C+11). See http://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-cast.html. Repository: rL LLVM

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

Gotcha. Going forward, if I feel anything requires a heads up, I'll do the full pre-commit review. Thanks for the feedback, Mike On Mon, Jun 13, 2016 at 11:30 AM, Aaron Ballman wrote: > On Mon, Jun 13, 2016 at 12:27 PM, Zachary Turner > wrote: > >

Re: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D20979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21298: [Clang-tidy] delete null check

aaron.ballman added inline comments. Comment at: clang-tidy/misc/DeleteNullCheck.cpp:23 @@ +22,3 @@ + const auto HasDeleteExpr = + cxxDeleteExpr(hasDescendant(declRefExpr().bind("pointerToDelete"))) + .bind("deleteExpr"); etienneb wrote: > The use

[PATCH] D21301: Detect recursive default argument definition

sepavloff created this revision. sepavloff added a subscriber: cfe-commits. If definition of default function argument uses itself, clang crashed, because corresponding function parameter is not associated with the default argument yet. With this fix clang emits appropriate error message. This

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

yaxunl updated this revision to Diff 60568. yaxunl added a comment. Update the test as Anastasia suggested. http://reviews.llvm.org/D20444 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/LangOptions.def include/clang/Driver/CC1Options.td

r272572 - Revert r272562 for build bot failure (clang-x86-win2008-selfhost)

Author: twoh Date: Mon Jun 13 13:32:30 2016 New Revision: 272572 URL: http://llvm.org/viewvc/llvm-project?rev=272572=rev Log: Revert r272562 for build bot failure (clang-x86-win2008-selfhost) Removed: cfe/trunk/test/Lexer/Inputs/case-insensitive-include.h

r272562 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

Author: twoh Date: Mon Jun 13 12:03:18 2016 New Revision: 272562 URL: http://llvm.org/viewvc/llvm-project?rev=272562=rev Log: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths. Differential Revision: http://reviews.llvm.org/D19843

Re: [PATCH] D21298: [Clang-tidy] delete null check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). I think misc-delete-null-pointer will be better name. Repository: rL LLVM http://reviews.llvm.org/D21298

Re: [PATCH] D21298: [Clang-tidy] delete null check

etienneb added a comment. Some comments after a quick look to the code. Comment at: clang-tidy/misc/DeleteNullCheck.cpp:22 @@ +21,3 @@ +void DeleteNullCheck::registerMatchers(MatchFinder *Finder) { + const auto HasDeleteExpr = +

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-move-const-arg.cpp:75-76 @@ +74,4 @@ + +struct NonMoveable { + public: + NonMoveable(); This type isn't non-moveable. For that, you need to explicitly delete the move constructor. Perhaps a

Re: [PATCH] D21301: Detect recursive default argument definition

majnemer added a subscriber: majnemer. majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Sema/SemaExpr.cpp:4570 @@ +4569,3 @@ + // If the default argument

Re: [PATCH] D20561: Warn when taking address of packed member

aaron.ballman added a comment. I think Richard has had enough time to comment. You can go ahead and commit, and if there are any issues, they can be handled post-commit. Thanks! http://reviews.llvm.org/D20561 ___ cfe-commits mailing list

Re: [PATCH] D21273: clang-format: [JS] Introduce WrapJavaScriptImports option.

djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:789 @@ -788,3 +788,3 @@ if (Style.Language == FormatStyle::LK_JavaScript && -CurrentToken->is(Keywords.kw_import)) +CurrentToken->is(Keywords.kw_import) && !Style.JavaScriptWrapImports)

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

aaron.ballman added a comment. I think Richard has had sufficient time to comment. You should be fine to commit and we can deal with any problems post-commit. http://reviews.llvm.org/D19403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. As requested - full diff (of all three files) F2059068: AlignFullDiff.patch Repository: rL LLVM http://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

[Added CC to the musl list] Lei Zhang wrote: > 2016-06-13 3:07 GMT+08:00 Joerg Sonnenberger : > > On Sun, Jun 12, 2016 at 10:51:11AM +0800, Lei Zhang via llvm-commits wrote: > >> Hi, > >> > >> I'm replying to this thread; sorry I wasn't subscribed to the list, > >> thus cannot reply

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

mboehme added inline comments. Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:37 @@ +36,3 @@ + if (BeforeArgumentsRange.isValid() && AfterArgumentsRange.isValid()) { +(*Diag) << FixItHint::CreateRemoval(BeforeArgumentsRange) +<<

Re: Add support for musl-libc on Linux

2016-06-13 21:02 GMT+08:00 Rafael Espíndola : > Should musl really be an environment? What happens when targeting ARM, > do we get a gnueabi+musl? Is it used as an environment when > configuring gcc? Honestly I couldn't judge if musl *should* be an environment. But it

Re: [PATCH] D20630: [OpenCL] Allow -std={cl|CL}{|1.1|1.2|2.0} in driver

yaxunl marked 4 inline comments as done. yaxunl added a comment. Ping! Richard, are you OK with this? Thanks. http://reviews.llvm.org/D20630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

2016-06-13 21:21 GMT+08:00 Felix Janda : > [Added CC to the musl list] > > Lei Zhang wrote: >> 2016-06-13 3:07 GMT+08:00 Joerg Sonnenberger : >> > On Sun, Jun 12, 2016 at 10:51:11AM +0800, Lei Zhang via llvm-commits wrote: >> >> Hi, >> >> >> >> I'm replying to

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. Thank you Aaron. I will commit ASAP. http://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21290: [include-fixer] only deduplicate symbols after matching symbols with the undefined identifier.

ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits. we should only deduplicate symbols after matching symbols with the undefined identifier. This patch tries to fix the situation where matching symbols are deleted when it has the same header as

[libcxx] r272638 - Add missing include

Author: ericwf Date: Mon Jun 13 23:58:19 2016 New Revision: 272638 URL: http://llvm.org/viewvc/llvm-project?rev=272638=rev Log: Add missing include Modified: libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.lock.guard/variadic_mutex.pass.cpp Modified:

Re: [libcxx] r272634 - Implement variadic lock_guard.

This is causing some of the libc++ bots to go red. `variadic_copy.fail.cpp` is encountering an error, which seems to be a clang bug which temporarily existed in 3.9. The test passes against current ToT and older clang releases and GCC. Please do not revert this commit due to that specific

Re: [PATCH] D21096: [libcxx] [test] Fix MSVC warning C4125 "decimal digit terminates octal escape sequence".

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I'm not a fan of the warning, but it seems like a minimally invasive fix. http://reviews.llvm.org/D21096 ___ cfe-commits mailing list

Re: [PATCH] D21096: [libcxx] [test] Fix MSVC warning C4125 "decimal digit terminates octal escape sequence".

EricWF closed this revision. EricWF added a comment. r272639. http://reviews.llvm.org/D21096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272639 - Avoid octal escape sequence warning with MSVC. Patch from s...@microsoft.com

Author: ericwf Date: Tue Jun 14 00:47:46 2016 New Revision: 272639 URL: http://llvm.org/viewvc/llvm-project?rev=272639=rev Log: Avoid octal escape sequence warning with MSVC. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/re/re.regex/re.regex.construct/awk_oct.pass.cpp

Re: [PATCH] D21273: clang-format: [JS] Introduce WrapJavaScriptImports option.

mprobst updated this revision to Diff 60532. mprobst added a comment. - classify as LT_ImportStatement, re-enable wrapping later - no early exist in TokenAnnotator: while loop is required for consumeToken(). http://reviews.llvm.org/D21273 Files: include/clang/Format/Format.h

Re: [PATCH] D21273: clang-format: [JS] Introduce WrapJavaScriptImports option.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D21273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

Hi David, While I understand the initial reasoning. I have found that this is like a hundred times better for working on Clang in practice and can't imagine working without it. The point is that many Clang data structures contain SmallVectors and having to do zero expansion clicks instead of

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. @mclow.lists, @EricWF: Ping. http://reviews.llvm.org/D20328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

mclow.lists added a comment. > I've adopted a initialize-on-first-use policy to workaround this particular > problem. That's not constexpr. You say it in your comment "This prohibits any prospects of calling a runtime initialization routine", but then you have a runtime initialization

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

I agree that it can be annoying to say "hey guys, i would normally do post commit review on this, but i wanted to give the courtesy of a heads up", and then potentially waiting an indeterminate amount of time. I think that actually discourages these kind of changes going up at all, because people

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

Thanks for the feedback! Replies inline. > On Jun 12, 2016, at 11:44 PM, Eric Christopher wrote: > > Hi Steven, > > Great to see the commentary and updates here. I've got a few questions about > some of this work. It might be nice to see some separate RFCs for a couple of

Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

spatel added a comment. In http://reviews.llvm.org/D21268#455679, @RKSimon wrote: > Eeep that's certainly a lot more work than just adding a few extra cases! > Please add a TODO explaining what we need to do? I don't know what the answer is yet...looks like this is going to require (a lot

Re: [PATCH] D21275: clang-format: [JS] Indent namespaces in JavaScript/TS by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272559: clang-format: [JS] Indent namespaces in JavaScript/TS by default. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D21275?vs=60487=60553#toc Repository: rL LLVM

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

alexfh added a comment. Thank you for working on this! A few more comments in addition to what Aaron has written. Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:22 @@ +21,3 @@ + +void ReplaceCallWithArg(const CallExpr *TheCallExpr, DiagnosticBuilder *Diag, +

Re: [PATCH] D21243: Fix clang-tidy patterns to adapt to newly added ExprWithCleanups nodes.

alexfh added a comment. Does this just fix the tests broken with http://reviews.llvm.org/D20498 or have you looked at other checks that might be broken by http://reviews.llvm.org/D20498, but don't have relevant tests? In the latter case we'd certainly need your help figuring out where further

Re: [PATCH] D21243: Fix clang-tidy patterns to adapt to newly added ExprWithCleanups nodes.

alexfh added a comment. In http://reviews.llvm.org/D21243#455999, @alexfh wrote: > Does this just fix the tests broken with http://reviews.llvm.org/D20498 or > have you looked at other checks that might be broken by > http://reviews.llvm.org/D20498, but don't have relevant tests? In the latter

Re: Add support for musl-libc on Linux

2016-06-13 3:07 GMT+08:00 Joerg Sonnenberger : > On Sun, Jun 12, 2016 at 10:51:11AM +0800, Lei Zhang via llvm-commits wrote: >> Hi, >> >> I'm replying to this thread; sorry I wasn't subscribed to the list, >> thus cannot reply to it directly. >> >>

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

mboehme updated this revision to Diff 60506. http://reviews.llvm.org/D21223 Files: clang-tidy/misc/MoveConstantArgumentCheck.cpp docs/clang-tidy/checks/misc-move-const-arg.rst test/clang-tidy/misc-move-const-arg.cpp Index: test/clang-tidy/misc-move-const-arg.cpp

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

mboehme updated this revision to Diff 60507. http://reviews.llvm.org/D21223 Files: clang-tidy/misc/MoveConstantArgumentCheck.cpp docs/clang-tidy/checks/misc-move-const-arg.rst test/clang-tidy/misc-move-const-arg.cpp Index: test/clang-tidy/misc-move-const-arg.cpp

  1   2   3   >