Re: [PATCH] D23003: [ObjC Availability] Warn upon unguarded use of partially available declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL278826: [ObjC] Warn on unguarded use of partial declaration (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D23003?vs=67713=68218#toc Repository: rL LLVM

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

yaxunl added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:101 @@ -100,3 +100,3 @@ DoubleTy = llvm::Type::getDoubleTy(LLVMContext); PointerWidthInBits = C.getTargetInfo().getPointerWidth(0); PointerAlignInBytes = joey wrote: > What if you

Re: [PATCH] D23555: [analyzer] CloneDetector now checks template arguments of function calls.

NoQ added inline comments. Comment at: lib/Analysis/CloneDetection.cpp:154 @@ -153,2 +153,3 @@ // Function pointers don't have a callee and we just skip hashing it. -if (S->getDirectCallee()) +if (S->getDirectCallee()) { + // If the function is a template

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

yaxunl updated this revision to Diff 68241. yaxunl added a comment. Remove language dependency. Choose proper integer types for pointer arithmetic. https://reviews.llvm.org/D23361 Files: include/clang/Basic/TargetInfo.h lib/Basic/TargetInfo.cpp lib/Basic/Targets.cpp

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

klimek added a reviewer: diltsman. klimek added a comment. +Daniel dilts who wrote the arguments support One problem is that getting into the game of parsing arbitrary shell modes is rather ugly. https://reviews.llvm.org/D23455 ___ cfe-commits

Re: [PATCH] D23375: Add kfree( ) to MallocChecker.cpp

dcoughlin added a comment. I would recommend putting the tests in existing test files next to tests that for similar diagnostics for other allocation/free schemes. So the test for printExpectedAllocName() should go in test/Analysis/free.c and the test for printExpectedDeallocName() should

Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good, thanks. Do you have commit access? https://reviews.llvm.org/D23546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22794: [Sema] Propagate nullability when deducing type of auto

ahatanak added a comment. I didn't think of this case, but no, it isn't a good idea. We shouldn't issue a warning unless we know the returned pointer is nullable. Comment at: lib/Sema/SemaDecl.cpp:9739 @@ +9738,3 @@ + DeducedType = DeducedType.setNullability( +

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1688-1689 @@ -1687,3 +1687,4 @@ - if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass()) + if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass() && + !CXXDecl->hasAttr()) return true;

Re: [PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

Today, the code includes the eprintf archive on all linker invocations for i386 that include the OS X archive. Removing the eprintf library from the command and including eprintf only for i386 in the OS X archive should be equivalent to what we have today. -Chris > On Aug 16, 2016, at 8:27

Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

alexshap added a comment. Thanks, no, i don't. I will be grateful to you if you land this patch. https://reviews.llvm.org/D23546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth updated this revision to Diff 68225. amccarth added a comment. Add comment as requested. https://reviews.llvm.org/D23462 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-dllimport-base-class.cpp Index: test/CodeGenCXX/debug-info-dllimport-base-class.cpp

[PATCH] D23573: [OpenCL] Add extension cl_khr_subgroups to clang

ashi1 created this revision. ashi1 added reviewers: yaxunl, Anastasia. ashi1 added a subscriber: cfe-commits. ashi1 set the repository for this revision to rL LLVM. Adding extension cl_khr_subgroups to clang's OpenCL Extensions and initiated inside AMDGPU Target. Similar to

Re: [PATCH] D23573: [OpenCL] Add extension cl_khr_subgroups to clang

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Better update the title to be `[OpenCL] AMDGPU: add support of cl_khr_subgroups` since cl_khr_subgroups is already in clang. Repository: rL LLVM

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

Hahnfeld added inline comments. Comment at: test/CMakeLists.txt:27-33 @@ -26,8 +26,9 @@ list(APPEND CLANG_TEST_DEPS clang clang-headers clang-format c-index-test diagtool clang-tblgen + clang-offload-bundler ) Most users will get it anyway

[clang-tools-extra] r278780 - [clang-rename] fix broken build

Author: omtcyfz Date: Tue Aug 16 01:19:06 2016 New Revision: 278780 URL: http://llvm.org/viewvc/llvm-project?rev=278780=rev Log: [clang-rename] fix broken build As Eric Fiselier pointed out, r278760 breaks build, because RecursiveASTVisitor doesn't have a const overload. This patch is a quick

Re: [PATCH] D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

mboehme marked 2 inline comments as done. Comment at: include/clang/AST/RecursiveASTVisitor.h:892 @@ -891,1 +891,3 @@ + else +TRY_TO(TraverseStmt(LE->capture_init_begin()[C - LE->capture_begin()])); return true; klimek wrote: > I'd rather pass in the

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL278783: [X86] Add xgetbv/x[X86] Add xgetbv xsetbv intrinsics to non-windows platforms (authored by myatsina). Changed prior to commit: https://reviews.llvm.org/D21959?vs=65676=68146#toc Repository:

r278783 - [X86] Add xgetbv/x[X86] Add xgetbv xsetbv intrinsics to non-windows platforms

Author: myatsina Date: Tue Aug 16 03:13:36 2016 New Revision: 278783 URL: http://llvm.org/viewvc/llvm-project?rev=278783=rev Log: [X86] Add xgetbv/x[X86] Add xgetbv xsetbv intrinsics to non-windows platforms commit on behalf of guyblank Differential Revision: https://reviews.llvm.org/D21959

Re: [PATCH] D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

mboehme updated this revision to Diff 68139. mboehme added a comment. Update to a clean diff. (Sorry, the last diff included a large number of extraneous changes by others.) https://reviews.llvm.org/D23204 Files: include/clang/AST/RecursiveASTVisitor.h lib/Index/IndexBody.cpp

Nomination for 3.9: r278786 - Left shifts of negative values are defined if -fwrapv is set

Hi Hans, [cc. Richard as code owner] I'd like to nominate this commit for 3.9. The actual code churn is tiny, and this fixes a problem noticed by and causing pain to the qemu project. Cheers, James On Tue, 16 Aug 2016 at 10:53 James Molloy via cfe-commits < cfe-commits@lists.llvm.org> wrote:

[PATCH] D23544: [clang-tidy] readability-implicit-bool-cast forgets to store its options.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D23544 Files: clang-tidy/readability/ImplicitBoolCastCheck.cpp clang-tidy/readability/ImplicitBoolCastCheck.h Index: clang-tidy/readability/ImplicitBoolCastCheck.h

Re: [PATCH] D23544: [clang-tidy] readability-implicit-bool-cast forgets to store its options.

alexfh added inline comments. Comment at: clang-tidy/readability/ImplicitBoolCastCheck.h:25 @@ -24,3 +24,3 @@ public: ImplicitBoolCastCheck(StringRef Name, ClangTidyContext *Context) : ClangTidyCheck(Name, Context), BTW, could you move the constructor

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

Anastasia added a comment. In https://reviews.llvm.org/D23086#515590, @yaxunl wrote: > In https://reviews.llvm.org/D23086#515506, @Anastasia wrote: > > > > > > > > > Surely vendors can re-implement all OpenCL types with an implicit typedef. > > For example this would just work: > > > > > >

Re: [PATCH] D23498: Left shifts of negative values are defined if -fwrapv is set

jmolloy added a comment. Hi Filipe, Did this look good to you after those changes? Cheers, James https://reviews.llvm.org/D23498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme marked 9 inline comments as done. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:493 @@ +492,3 @@ +if (!S) + continue; + For some reason, I thought I had read that they weren't compatible with CFG / CFGBlock -- but obviously I must have been

[PATCH] D23546: Remove excessive padding from LineNoCacheTy

alexshap created this revision. alexshap added a reviewer: lattner. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". The struct LineNoCacheTy is in SourceMgr.cpp inside anonymous namespace.

Re: [PATCH] D23544: [clang-tidy] readability-implicit-bool-cast forgets to store its options.

hokein updated this revision to Diff 68154. hokein added a comment. Move ctor body to .cpp file. https://reviews.llvm.org/D23544 Files: clang-tidy/readability/ImplicitBoolCastCheck.cpp clang-tidy/readability/ImplicitBoolCastCheck.h Index: clang-tidy/readability/ImplicitBoolCastCheck.h

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme updated this revision to Diff 68147. mboehme added a comment. Responses to reviewer comments. https://reviews.llvm.org/D23353 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/UseAfterMoveCheck.cpp clang-tidy/misc/UseAfterMoveCheck.h

Re: [PATCH] D23498: Left shifts of negative values are defined if -fwrapv is set

LGTM. Thank you, Filipe On Tue, Aug 16, 2016 at 10:23 AM, Davide Italiano wrote: > davide added a comment. > > The `Sema` bits look fine to me. I'll let Filipe comment on the sanitizer > part. > > > https://reviews.llvm.org/D23498 > > >

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

omtcyfz added a subscriber: omtcyfz. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:659 @@ +658,3 @@ + UseAfterMove Use; + if (finder.find(FunctionBody, MovingCall, MovedVariable, )) { +emitDiagnostic(MovingCall, MovedVariable, Use, this, Result.Context);

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

mboehme marked 4 inline comments as done. mboehme added a comment. In https://reviews.llvm.org/D23353#511362, @Prazek wrote: > I will review it later, but my first thoughts: > > 1. I think we should make some other group, because misc seems to be > overloaded. I discussed it with Alex months

Re: [PATCH] D23498: Left shifts of negative values are defined if -fwrapv is set

davide added a comment. The `Sema` bits look fine to me. I'll let Filipe comment on the sanitizer part. https://reviews.llvm.org/D23498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23544: [clang-tidy] readability-implicit-bool-cast forgets to store its options.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278791: [clang-tidy] readability-implicit-bool-cast forgets to store its options. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D23544?vs=68154=68158#toc Repository: rL

[clang-tools-extra] r278791 - [clang-tidy] readability-implicit-bool-cast forgets to store its options.

Author: hokein Date: Tue Aug 16 06:15:05 2016 New Revision: 278791 URL: http://llvm.org/viewvc/llvm-project?rev=278791=rev Log: [clang-tidy] readability-implicit-bool-cast forgets to store its options. Reviewers: alexfh Subscribers: cfe-commits Differential Revision:

Re: [PATCH] D15227: [analyzer] Valist checkers.

xazax.hun updated this revision to Diff 68157. xazax.hun marked 5 inline comments as done. xazax.hun added a comment. - Improvements according to review comments. https://reviews.llvm.org/D15227 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

Re: [PATCH] D7511: [libc++] Change how CMake links libc++ with OS X.

EricWF abandoned this revision. EricWF added a comment. Abandoning https://reviews.llvm.org/D7511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23498: Left shifts of negative values are defined if -fwrapv is set

jmolloy accepted this revision. jmolloy added a reviewer: jmolloy. jmolloy added a comment. This revision is now accepted and ready to land. Thanks, r278786! https://reviews.llvm.org/D23498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23544: [clang-tidy] readability-implicit-bool-cast forgets to store its options.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r278786 - Left shifts of negative values are defined if -fwrapv is set

Author: jamesm Date: Tue Aug 16 04:45:36 2016 New Revision: 278786 URL: http://llvm.org/viewvc/llvm-project?rev=278786=rev Log: Left shifts of negative values are defined if -fwrapv is set This means we shouldn't emit ubsan detection code or warn. Fixes PR25552. Added:

Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

alexshap added a comment. F2274214: Screen Shot 2016-08-16 at 3.34.00 AM.png https://reviews.llvm.org/D23546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r278826 - [ObjC] Warn on unguarded use of partial declaration

Author: epilk Date: Tue Aug 16 12:44:11 2016 New Revision: 278826 URL: http://llvm.org/viewvc/llvm-project?rev=278826=rev Log: [ObjC] Warn on unguarded use of partial declaration This commit adds a traversal of the AST after Sema of a function that diagnoses unguarded references to declarations

Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

This revision was automatically updated to reflect the committed changes. Closed by commit rL278838: Remove excessive padding from LineNoCacheTy (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D23546?vs=68153=68240#toc Repository: rL LLVM

Re: [PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

arsenm closed this revision. arsenm added a comment. r278844 https://reviews.llvm.org/D23536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

hfinkel added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:537 @@ +536,3 @@ + llvm::LLVMContext::MD_noalias), + NewScopeList)); + rjmccall wrote: > This is a very strange

r278861 - Emit debug info for dynamic classes if they are imported from a DLL.

Author: amccarth Date: Tue Aug 16 17:11:18 2016 New Revision: 278861 URL: http://llvm.org/viewvc/llvm-project?rev=278861=rev Log: Emit debug info for dynamic classes if they are imported from a DLL. With -debug-info-kind=limited, we omit debug info for dynamic classes that live in other TUs.

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Prazek added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35 @@ +34,3 @@ + auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr( + hasDeclaration(decl(anyOf(isPrivate(), isProtected(; + aaron.ballman wrote: >

r278850 - [CMake] Fixing typo in Info.plist generation

Author: cbieneman Date: Tue Aug 16 15:49:49 2016 New Revision: 278850 URL: http://llvm.org/viewvc/llvm-project?rev=278850=rev Log: [CMake] Fixing typo in Info.plist generation This is causing an error in the generation of the clang info plist. Modified: cfe/trunk/tools/driver/Info.plist.in

Re: r266775 - Pass dwarf-version to cc1as.

Hi Hans, Can we please merge this one to release_39 too? I forgot all about it, sorry. Doug, can you please approve? -Dimitry > On 19 Apr 2016, at 19:43, Douglas Katzman via cfe-commits > wrote: > > Author: dougk > Date: Tue Apr 19 12:43:54 2016 > New Revision:

r278862 - [CMake] Workflow improvements to PGO generation

Author: cbieneman Date: Tue Aug 16 17:16:29 2016 New Revision: 278862 URL: http://llvm.org/viewvc/llvm-project?rev=278862=rev Log: [CMake] Workflow improvements to PGO generation This patch adds a few new convenience options used by the PGO CMake cache to setup options on bootstrap stages. The

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35 @@ +34,3 @@ + auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr( + hasDeclaration(decl(anyOf(isPrivate(), isProtected(; + Prazek wrote: >

[PATCH] D23581: [GraphWriter] Change GraphWriter to use NodeRef in GraphTraits

timshen created this revision. timshen added a reviewer: dblaikie. timshen added a subscriber: cfe-commits. Corresponding LLVM patch: D23580 https://reviews.llvm.org/D23581 Files: lib/Serialization/ModuleManager.cpp Index: lib/Serialization/ModuleManager.cpp

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

aaron.ballman added inline comments. Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:46-56 @@ +45,13 @@ +// std::move(). This will hopefully prevent erroneous replacements if the +// code does unusual things (e.g. create an alias for std::move() in +//

r278806 - Add empty --gcc-toolchain empty to cuda-detect test.

Author: sfantao Date: Tue Aug 16 09:31:39 2016 New Revision: 278806 URL: http://llvm.org/viewvc/llvm-project?rev=278806=rev Log: Add empty --gcc-toolchain empty to cuda-detect test. Unless we overload the default gcc toolchain with an empty string the system root used in the tests will be

Re: [PATCH] D23533: [clang-tidy] Rewrite compilation database test to not require shell

alexfh added inline comments. Comment at: test/clang-tidy/clang-tidy-run-with-database.cpp:11 @@ -10,3 @@ -// RUN: echo '#include "header.h"' > %T/compilation-database-test/b/d.cpp -// RUN: sed 's|test_dir|%T/compilation-database-test|g'

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor planned changes to this revision. teemperor added a comment. - As the hash_stream patch will take a while to land upstream, we will change this to use FoldingSetNodeID and change it to hash_stream once that landed. https://reviews.llvm.org/D22515

r278811 - Reorder stderr redirection in test command.

Author: sfantao Date: Tue Aug 16 09:38:39 2016 New Revision: 278811 URL: http://llvm.org/viewvc/llvm-project?rev=278811=rev Log: Reorder stderr redirection in test command. Modified: cfe/trunk/test/Driver/cuda-detect.cu Modified: cfe/trunk/test/Driver/cuda-detect.cu URL:

r278812 - Reduce the number of allocations required for AST attributes. In test cases, the max resident memory changed from 65760k to 64476k which is 1.9% improvement. Allocations in grow_pod changed

Author: aaronballman Date: Tue Aug 16 09:48:39 2016 New Revision: 278812 URL: http://llvm.org/viewvc/llvm-project?rev=278812=rev Log: Reduce the number of allocations required for AST attributes. In test cases, the max resident memory changed from 65760k to 64476k which is 1.9% improvement.

[PATCH] D23595: [Clang] Fix some Clang-tidy modernize-use-using and Include What You Use warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: compnerd, mehdi_amini. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

Author: rsmith Date: Tue Aug 16 20:05:07 2016 New Revision: 278882 URL: http://llvm.org/viewvc/llvm-project?rev=278882=rev Log: If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work around a Linux kernel bug where the actual amount of available stack may be a *lot* lower

Re: [PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

dcoughlin added a comment. Thanks for patch! Some comments inline. You don't have to do it in this patch, but I think it would be good to get this working with AddImplicitDtors. I think it would also be good to (eventually) add CFGElements marking when the storage duration for underlying

Re: Nomination for 3.9: r278786 - Left shifts of negative values are defined if -fwrapv is set

Looks fine to me. (At one point we were deliberately not following GCC in making -fwrapv affect left shift, because it's a bit operation rather than an arithmetic one, but this is ultimately supposed to be a GCC-compatible flag so behaving as they do seems reasonable.) On Tue, Aug 16, 2016 at

r278890 - Some missing usage of TargetParser. NFC.

Author: zijiaoma Date: Tue Aug 16 21:13:33 2016 New Revision: 278890 URL: http://llvm.org/viewvc/llvm-project?rev=278890=rev Log: Some missing usage of TargetParser. NFC. Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp

r278842 - Try to work around an MSVC 2013 bug around defaulted default ctors

Author: rnk Date: Tue Aug 16 15:20:56 2016 New Revision: 278842 URL: http://llvm.org/viewvc/llvm-project?rev=278842=rev Log: Try to work around an MSVC 2013 bug around defaulted default ctors An UnresolvedSetIterator() is supposed to be zeroed out, but MSVC 2013 does not do that. Modified:

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

arsenm added inline comments. Comment at: lib/CodeGen/CodeGenModule.h:664 @@ +663,3 @@ + /// Get integer type of the same size as a pointer type. + llvm::IntegerType *getIntPtrTy(llvm::PointerType *PT); + This has the same purpose as DataLayout::getIntPtrType,

r278849 - [CMake] [Apple Cache] Set CLANG_VENDOR_UTI for Apple builds

Author: cbieneman Date: Tue Aug 16 15:44:58 2016 New Revision: 278849 URL: http://llvm.org/viewvc/llvm-project?rev=278849=rev Log: [CMake] [Apple Cache] Set CLANG_VENDOR_UTI for Apple builds This is just a minor update to the Apple packaging configuration. Modified:

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth closed this revision. amccarth added a comment. Closed by r278861 https://reviews.llvm.org/D23462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg marked an inline comment as done. thegameg added a comment. https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg marked an inline comment as done. thegameg added a comment. https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg updated this revision to Diff 68288. thegameg added a comment. Mention UniqueExternalLinkage type, add a test according to it. `EXPECT_FALSE(matches(` -> `EXPECT_TRUE(notMatches(` https://reviews.llvm.org/D23585 Files: include/clang/ASTMatchers/ASTMatchers.h

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg updated this revision to Diff 68290. thegameg added a comment. Sorry, sent the wrong patch. https://reviews.llvm.org/D23585 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

r278851 - [OpenCL] AMDGPU: Add extensions cl_amd_media_ops and cl_amd_media_ops2

Author: yaxunl Date: Tue Aug 16 15:49:49 2016 New Revision: 278851 URL: http://llvm.org/viewvc/llvm-project?rev=278851=rev Log: [OpenCL] AMDGPU: Add extensions cl_amd_media_ops and cl_amd_media_ops2 Differential Revision: https://reviews.llvm.org/D23322 Modified:

Re: [PATCH] D23322: [OpenCL] AMDGPU: Add extensions cl_amd_media_ops and cl_amd_media_ops2

This revision was automatically updated to reflect the committed changes. Closed by commit rL278851: [OpenCL] AMDGPU: Add extensions cl_amd_media_ops and cl_amd_media_ops2 (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D23322?vs=67358=68250#toc Repository: rL LLVM

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D23462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22929: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl

ahatanak added inline comments. Comment at: test/CodeGenObjCXX/encode.mm:231 @@ +230,3 @@ +struct S { + typedef T Ty; + Ty *t; manmanren wrote: > I wonder if we can further reduce the testing case. Is this necessary to > cause the infinite recursion? Yes. If I

Re: [PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

rjmccall added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:525 @@ +524,3 @@ +void CodeGenFunction::LexicalNoAliasInfo::addNoAliasMD() { + if (MemoryInsts.empty() || NoAliasScopes.empty()) +return; It's much more likely that NoAliasScopes will be

Re: [PATCH] D22929: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl

manmanren accepted this revision. manmanren added a reviewer: manmanren. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman https://reviews.llvm.org/D22929 ___ cfe-commits mailing list

[PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg created this revision. thegameg added reviewers: bkramer, alexfh, hokein. thegameg added a subscriber: cfe-commits. Herald added a subscriber: klimek. Matches NamedDecl nodes whose linkage is external. https://reviews.llvm.org/D23585 Files: docs/LibASTMatchersReference.html

Re: r266775 - Pass dwarf-version to cc1as.

Looks like it was committed back in April, so unless I'm missing something it should already be in the branch (which was cut mid-July). Thanks, Hans On Tue, Aug 16, 2016 at 2:16 PM, Dimitry Andric wrote: > Hi Hans, > > Can we please merge this one to release_39 too? I

Re: r277852 - PR26423: Assert on valid use of using declaration of a function with an undeduced auto return type

On Fri, Aug 5, 2016 at 12:03 PM, David Blaikie via cfe-commits wrote: > Author: dblaikie > Date: Fri Aug 5 14:03:01 2016 > New Revision: 277852 > > URL: http://llvm.org/viewvc/llvm-project?rev=277852=rev > Log: > PR26423: Assert on valid use of using declaration of a

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. A few minor nits, but thank you for the patch! Comment at: include/clang/ASTMatchers/ASTMatchers.h:5481 @@ +5480,3 @@ +/// +/// Example matches only z

r278891 - Add missing close brace to fix Windows bots. Oops :(

Author: rsmith Date: Tue Aug 16 21:22:39 2016 New Revision: 278891 URL: http://llvm.org/viewvc/llvm-project?rev=278891=rev Log: Add missing close brace to fix Windows bots. Oops :( Modified: cfe/trunk/tools/driver/cc1_main.cpp Modified: cfe/trunk/tools/driver/cc1_main.cpp URL:

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren added a comment. Richard, Are you okay with the patch now? Thanks, Manman https://reviews.llvm.org/D23125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21675: New ODR checker for modules

rtrieu updated this revision to Diff 68278. rtrieu added a comment. Add function void ODRHash(llvm::FoldingSetNodeID ) to several classes for computing the hash. Decl, Stmt, TemplateArgument, Type and QualType now have this function, and can call among each others' functions.

r278897 - [PM] Update Clang for LLVM's r278896 which re-organized a header.

Author: chandlerc Date: Tue Aug 16 22:09:11 2016 New Revision: 278897 URL: http://llvm.org/viewvc/llvm-project?rev=278897=rev Log: [PM] Update Clang for LLVM's r278896 which re-organized a header. (sorry this didn't get landed closer in time...) Modified:

r278898 - CodeGen: Avoid dereferencing end() in ScalarExprEmitter::EmitOverflowCheckedBinOp

Author: dexonsmith Date: Tue Aug 16 22:15:29 2016 New Revision: 278898 URL: http://llvm.org/viewvc/llvm-project?rev=278898=rev Log: CodeGen: Avoid dereferencing end() in ScalarExprEmitter::EmitOverflowCheckedBinOp Use BB.getNextNode(), which returns nullptr on end(), instead of

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Prazek added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35 @@ +34,3 @@ + auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr( + hasDeclaration(decl(anyOf(isPrivate(), isProtected(; + aaron.ballman wrote: >

Re: [PATCH] D23284: Add -Rpass-with-hotness

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but you should wait for confirmation on the behavior of the R_Group behavior from @dnovillo or @rsmith before committing. https://reviews.llvm.org/D23284

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor marked 2 inline comments as done. teemperor added a comment. https://reviews.llvm.org/D22515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23555: [analyzer] CloneDetector now checks template arguments of function calls.

teemperor created this revision. teemperor added reviewers: v.g.vassilev, NoQ. teemperor added a subscriber: cfe-commits. The CloneDetector currently ignores template arguments in function calls which leads to false-positive clones such as `isa(S)` and `isa(S)`. This patch adds functionality to

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with one minor nit (you can fix it during the commit). Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35 @@ +34,3 @@ + auto CanCallCtor =

Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. No tests for serialization/deserialization/AST printing https://reviews.llvm.org/D23528 ___ cfe-commits mailing list

[PATCH] D23550: [analyzer] Small cleanups when checkers retrieving statements from exploded nodes.

xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, dcoughlin, NoQ. xazax.hun added a subscriber: cfe-commits. Small cleanup to utilize PathDiagnosticLocation::getStmt where appropriate. https://reviews.llvm.org/D23550 Files:

StaticAnalyzer: Fix GCC 6 indention warning in ArrayBoundCheckerV2.cpp

Dear Clang developers, please find attached a tiny patch which fixes a indentation warning from GCC 6 within ArrayBoundCheckerV2.cpp Proposed commit message: > StaticAnalyzer: Fix GCC 6 indention warning in ArrayBoundCheckerV2.cpp > > Patch by Christoph Grüninger Bye Christoph Index:

Re: [PATCH] D23427: [Clang-tidy] Comparison Misuse

aaron.ballman added a comment. Thank you for working on this check! We already have a frontend diagnostic for comparisons between string literals and pointers, so I'm not certain of the utility of adding a clang-tidy check for that case (see -Wstring-compare, aka,

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor updated this revision to Diff 68170. teemperor added a comment. - Renamed FoldingSetWrapper to FoldingSetNodeIDWrapper - Added missing // end anonymous namespace https://reviews.llvm.org/D22515 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. https://reviews.llvm.org/D22515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1688-1689 @@ -1687,3 +1687,4 @@ - if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass()) + if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass() && + !CXXDecl->hasAttr()) return true;

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:95-98 @@ +94,6 @@ +const QualType T = VD->getType(); +if (T->isPointerType() && !T->getPointeeType().isConstQualified())

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman closed this revision. aaron.ballman added a comment. Thank you! I've commit in r278812. https://reviews.llvm.org/D23329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >