Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

alexfh added a comment. Thank you for the patch! In https://reviews.llvm.org/D24349#537500, @aaron.ballman wrote: > In https://reviews.llvm.org/D24349#537350, @Eugene.Zelenko wrote: > > > Probably check should have options to extend list of containers and also to > > assume all classes with

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

aaron.ballman added a comment. In https://reviews.llvm.org/D24349#538098, @alexfh wrote: > Thank you for the patch! > > In https://reviews.llvm.org/D24349#537500, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D24349#537350, @Eugene.Zelenko wrote: > > > > > Probably check should have

Re: [PATCH] D24307: calculate extent size for memory regions allocated by C++ new expression

dkrupp added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1011 @@ +1010,3 @@ +// containing the elements. +Region = (State->getSVal(NE, LCtx)) + .getAsRegion() MemRegion has now method called castAs<>, only

r281018 - Update clang for D21514. NFC

Author: deadalnix Date: Thu Sep 8 23:42:49 2016 New Revision: 281018 URL: http://llvm.org/viewvc/llvm-project?rev=281018=rev Log: Update clang for D21514. NFC Summary: As per title. Reviewers: ahatanak, bkramer, whitequark, mehdi_amini, void Subscribers: cfe-commits Differential Revision:

[PATCH] D24373: [Coroutines] Adding builtins for coroutine intrinsics and backendutil support.

GorNishanov created this revision. GorNishanov added reviewers: rsmith, majnemer. GorNishanov added a subscriber: cfe-commits. Herald added subscribers: beanz, mehdi_amini. With this commit simple coroutines can be created in plain C using coroutine builtins (see coro.c and coro.h for an

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

bcraig added a subscriber: bcraig. bcraig added a comment. This seems related: https://reviews.llvm.org/D20596 In that (stale) review, I switch away from unique_ptr in general for locale related operations. https://reviews.llvm.org/D24374 ___

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

omtcyfz added a comment. Ping. Comment at: clang-rename/USRFindingAction.cpp:169 @@ -160,2 +168,3 @@ << SymbolOffset << ").\n"; +exit(1); } else { alexfh wrote: > I'd better not use `exit()` in library code and try to find a way

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

omtcyfz removed rL LLVM as the repository for this revision. omtcyfz updated this revision to Diff 70818. omtcyfz added a comment. Restricted `size()` and `empty()` functions a little bit more. https://reviews.llvm.org/D24349 Files: clang-tidy/readability/ContainerSizeEmptyCheck.cpp

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

omtcyfz updated this revision to Diff 70822. omtcyfz added a comment. Allow inheritance for `size()` and `empty()`. https://reviews.llvm.org/D24349 Files: clang-tidy/readability/ContainerSizeEmptyCheck.cpp docs/clang-tidy/checks/readability-container-size-empty.rst

[PATCH] D24395: Align declarations that are preceded by different number of commas.

nikola created this revision. nikola added a reviewer: djasper. nikola added a subscriber: cfe-commits. Herald added a subscriber: klimek. Having a template with more than one template argument breaks alignment of consecutive declarations. Something like this won't be correctly aligned: int x;

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

nemanjai added a comment. Looking over the patch, I realized that I forgot to add a test case for the __POWER9_VECTOR__ macro and the builtins that target the record forms of the instructions. I'll add those on the next revision along with addressing any review comments. Repository: rL

[PATCH] D24401: clang-format: Add Java detection to git-clang-format.

lhchavez created this revision. lhchavez added a reviewer: djasper. lhchavez added subscribers: cfe-commits, srhines. lhchavez set the repository for this revision to rL LLVM. This change adds "java" to the list of known extensions that clang-format supports. Repository: rL LLVM

Re: [PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D24378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

rmaprath updated this revision to Diff 70840. rmaprath added a comment. Herald added a subscriber: beanz. Final patch incorporating all the changes from @EricWF and @compnerd. Will commit tomorrow (@mclow.lists gave approval earlier) / Asiri https://reviews.llvm.org/D21968 Files:

[PATCH] D24400: Also cleanup comments around redundant colons/commas in format::cleanup.

ioeric created this revision. ioeric added a reviewer: djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D24400 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp

r281053 - [codeview] Extend the heuristic for detecting classes imported from DLLs

Author: rnk Date: Fri Sep 9 11:27:04 2016 New Revision: 281053 URL: http://llvm.org/viewvc/llvm-project?rev=281053=rev Log: [codeview] Extend the heuristic for detecting classes imported from DLLs If a dynamic class contains a dllimport method, then assume the class may not be constructed in

r281056 - Make -fstandalone-debug and -flimit-debug-info available in clang-cl

Author: rnk Date: Fri Sep 9 11:42:50 2016 New Revision: 281056 URL: http://llvm.org/viewvc/llvm-project?rev=281056=rev Log: Make -fstandalone-debug and -flimit-debug-info available in clang-cl Our limited debug info optimizations are breaking down at DLL boundaries, so we're going to evaluate

[PATCH] D24407: [CUDA] Make __GCC_ATOMIC_XXX_LOCK_FREE macros the same on host/device.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: jhen, cfe-commits. This fixes a bug where we were unable to compile the following CUDA file with libstdc++ (didn't try libc++): #include void foo() { std::shared_future x; } The problem is that only

Re: [PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

efriedma added a comment. This is probably going to lead to someone complaining about clang realigning the stack on 32-bit Windows; are your sure we're choosing the right alignment there? https://reviews.llvm.org/D24378 ___ cfe-commits mailing

Re: [PATCH] D24400: Also cleanup comments around redundant colons/commas in format::cleanup.

djasper added inline comments. Comment at: lib/Format/Format.cpp:1141 @@ -1134,1 +1140,3 @@ deleteToken(DeleteLeft ? Left : Right); +// Delete all comments between `Left` and `Right`. +for (auto *Comment : Comments) Couldn't you just do:

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

bcraig added a comment. In https://reviews.llvm.org/D24374#538521, @smeenai wrote: > @bcraig thanks for pointing me to that diff; there's a lot of nice cleanup > going on there. Were you planning on updating and following up on it? > > I also realized I forgot to adjust `locale_win32.cpp` for

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

ioeric added a comment. In https://reviews.llvm.org/D24380#538434, @Eugene.Zelenko wrote: > I think will be good idea to await clang-refactor and merge code there. This tool is not exactly a clang-tool; it is a framework that invokes multiple clang refactoring tool and also manipulates build

Re: [PATCH] D23963: [analyzer] pr28449 - Move literal rvalue construction away from RegionStore.

dcoughlin added a comment. I agree that it is weird that region store modifies the value it was asked to bind and over all this seems like the right approach. My big concern with this patch is that the logic that looks whether an lval is being stored into a non-reference location and

Re: [PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

efriedma added a comment. Huh... then I guess this is fine. https://reviews.llvm.org/D24378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24235: [OpenCL] Improve double literal handling

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D24235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

mclow.lists added a comment. This all looks good to me - but with a couple nits. Comment at: include/memory:2137 @@ -2132,3 +2136,3 @@ -_LIBCPP_INLINE_VISIBILITY +_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR __libcpp_compressed_pair_imp&

Re: [PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

On Fri, Sep 9, 2016 at 10:45 AM, Friedman, Eli via cfe-commits < cfe-commits@lists.llvm.org> wrote: > It probably makes sense to say that alloca should have the same alignment > as the default stack alignment, simply because it's hard to do anything > useful with completely unaligned memory.

r281071 - Myriad: nominally "support" ASAN.

Author: dougk Date: Fri Sep 9 13:20:49 2016 New Revision: 281071 URL: http://llvm.org/viewvc/llvm-project?rev=281071=rev Log: Myriad: nominally "support" ASAN. Doesn't work, but needs to be enabled in order to get there. Modified: cfe/trunk/lib/Driver/ToolChains.cpp

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

rsmith added a subscriber: rsmith. Comment at: test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/constinit.pass.cpp:19-23 @@ +18,6 @@ + +_LIBCPP_SAFE_STATIC static std::unique_ptr a; + +int main() { +assert(a == nullptr); +}

Re: [PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

It probably makes sense to say that alloca should have the same alignment as the default stack alignment, simply because it's hard to do anything useful with completely unaligned memory. That said, the default stack alignment is 4 bytes on 32-bit Windows, not 16. -Eli On 9/9/2016 10:29 AM,

Re: [PATCH] D24400: Also cleanup comments around redundant colons/commas in format::cleanup.

ioeric added inline comments. Comment at: lib/Format/Format.cpp:1136 @@ +1135,3 @@ +for (auto *Tok = Left->Next; Tok && Tok != Right; Tok = Tok->Next) + if (Tok->is(tok::comment)) +deleteToken(Tok); djasper wrote: > Hm. I think this

Re: [PATCH] D24400: Also cleanup comments around redundant colons/commas in format::cleanup.

ioeric updated this revision to Diff 70865. ioeric marked an inline comment as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D24400 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp

Re: [PATCH] D24238: StaticAnalyzer CastToStruct : No memory corruption when casting array to struct

NoQ added a subscriber: cfe-commits. NoQ added a comment. Adding cfe-commits as per developer policy. Yeah, it doesn't probably cause the same kind of memory corruption, however i wouldn't call this code safe: it still violates the //strict aliasing rule//, unless the array is of `char`s. I

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be good idea to await clang-refactor and merge code there. Please run Include What You Use. Code use a lot of containers and will be good to include them explicitly. Comment at:

Re: [PATCH] D24407: [CUDA] Make __GCC_ATOMIC_XXX_LOCK_FREE macros the same on host/device.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D24407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24278: [analyzer] Extend bug reports with extra notes.

a.sidorin added a comment. This definitely seems to be useful. However, this patch is pretty big. Some of its parts are not directly related with the feature being introduced (for example, changes for copypaste/sub-sequences.cpp). Is it possible to split this patch? Moreover, as I understand,

Re: [PATCH] D24400: Also cleanup comments around redundant colons/commas in format::cleanup.

ioeric updated this revision to Diff 70863. ioeric marked an inline comment as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D24400 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp

Re: [PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

rnk added a comment. In https://reviews.llvm.org/D24378#538430, @efriedma wrote: > This is probably going to lead to someone complaining about clang realigning > the stack on 32-bit Windows; are your sure we're choosing the right alignment > there? I checked, and MSVC emits a call to

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

On Fri, Sep 9, 2016 at 11:29 AM, Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Sep 7, 2016 at 4:44 PM, Richard Smith > wrote: > >> On Wed, Sep 7, 2016 at 12:45 PM, Manman Ren wrote: >> >>> On Tue, Sep 6, 2016 at 6:54 PM,

Re: [PATCH] D24278: [analyzer] Extend bug reports with extra notes.

NoQ added a comment. Thanks! I could have split this up into three patches (one for the core and two patches for the checkers), however that'd mean that the first patch comes without tests; so i thought that the patch should be self-contained. Was it a bad idea after all?

r281057 - [DebugInfo] Ensure complete type is emitted with -fstandalone-debug

Author: rnk Date: Fri Sep 9 12:03:53 2016 New Revision: 281057 URL: http://llvm.org/viewvc/llvm-project?rev=281057=rev Log: [DebugInfo] Ensure complete type is emitted with -fstandalone-debug The logic for upgrading a class from a forward decl to a complete type was not checking the debug info

Re: [PATCH] D24400: Also cleanup comments around redundant colons/commas in format::cleanup.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. One remark, otherwise looks good. Comment at: lib/Format/Format.cpp:1136 @@ +1135,3 @@ +for (auto *Tok = Left->Next; Tok && Tok != Right; Tok = Tok->Next) +

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai planned changes to this revision. smeenai added a comment. @bcraig thanks for pointing me to that diff; there's a lot of nice cleanup going on there. Were you planning on updating and following up on it? I also realized I forgot to adjust `locale_win32.cpp` for this diff. Will

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

On Fri, Sep 9, 2016 at 11:33 AM, Richard Smith wrote: > On Fri, Sep 9, 2016 at 11:29 AM, Manman Ren via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Wed, Sep 7, 2016 at 4:44 PM, Richard Smith >> wrote: >> >>> On Wed, Sep 7, 2016 at

Re: [PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

There's an (unconvincing to me) explanation for why gcc does this here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19131 On 9 Sep 2016 10:14 am, "Eli Friedman" wrote: > efriedma added a comment. > > This is probably going to lead to someone complaining about clang >

Re: [PATCH] D24400: Also cleanup comments around redundant colons/commas in format::cleanup.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281064: Also cleanup comments around redundant colons/commas in format::cleanup. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D24400?vs=70865=70867#toc Repository: rL LLVM

r281064 - Also cleanup comments around redundant colons/commas in format::cleanup.

Author: ioeric Date: Fri Sep 9 12:50:49 2016 New Revision: 281064 URL: http://llvm.org/viewvc/llvm-project?rev=281064=rev Log: Also cleanup comments around redundant colons/commas in format::cleanup. Reviewers: djasper Subscribers: klimek, cfe-commits Differential Revision:

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

On Wed, Sep 7, 2016 at 4:44 PM, Richard Smith wrote: > On Wed, Sep 7, 2016 at 12:45 PM, Manman Ren wrote: > >> On Tue, Sep 6, 2016 at 6:54 PM, Richard Smith >> wrote: >> >>> On Tue, Sep 6, 2016 at 11:16 AM, Manman Ren via

r281078 - Modules: revert r280728.

Author: mren Date: Fri Sep 9 14:03:07 2016 New Revision: 281078 URL: http://llvm.org/viewvc/llvm-project?rev=281078=rev Log: Modules: revert r280728. In post-commit review, Richard suggested a better way to fix this. rdar://27926200 Removed: cfe/trunk/test/Modules/Inputs/lookup-assert/

Re: [PATCH] D23079: ObjC: Use a new type for ObjC type parameter (patch 2 out of 3)

manmanren added a comment. Hi Doug, Can you take a look at the updated version? Thanks, Manman https://reviews.llvm.org/D23079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

omtcyfz added a comment. In https://reviews.llvm.org/D24380#538556, @ioeric wrote: > In https://reviews.llvm.org/D24380#538434, @Eugene.Zelenko wrote: > > > I think will be good idea to await clang-refactor and merge code there. > > > This tool is not exactly a clang-tool; it is a framework that

Re: [PATCH] D24371: Add diagnostics to require_constant_initialization

rsmith added a comment. There's no way for `-verify` to test for a diagnostic with an invalid location at the moment. Maybe add a FIXME and disable that portion of the test for C++11? Comment at: lib/Sema/SemaDecl.cpp:10535-10538 @@ -10534,1 +10534,6 @@ <<

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai updated this revision to Diff 70899. smeenai added a comment. Correcting support_win32.cpp https://reviews.llvm.org/D24374 Files: include/support/win32/locale_win32.h src/support/win32/locale_win32.cpp Index: src/support/win32/locale_win32.cpp

Buildbot numbers for the last week of 8/28/2016 - 9/03/2016

Hello everyone, Below are some buildbot numbers for the last week of 8/28/2016 - 9/03/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Re: [PATCH] D24330: Add some MS aliases for existing intrinsics

agutowski updated this revision to Diff 70923. agutowski added a comment. Changed way of handling Intel intrinsics Removed constant folding https://reviews.llvm.org/D24330 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h include/clang/Basic/BuiltinsX86.def

Re: [PATCH] D24371: Add diagnostics to require_constant_initialization

loladiro updated this revision to Diff 70915. loladiro added a comment. Address review comments: - Disable C++11 test that lacks source locations - Use CacheCulprit to give diagnostics for < C++11 Repository: rL LLVM https://reviews.llvm.org/D24371 Files: lib/Sema/SemaDecl.cpp

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai added a comment. Cool. Any thoughts on this implementation vs. `___mb_cur_max_l_func`? In other words, do we have a general policy on using internal CRT functionality? FWIW, `support/win32/support.h` was using `xlocinfo.h` before my recent cleanup, which is also an internal header.

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

I believe mclow is working on this On Sep 8, 2016 9:30 PM, "Keno Fischer" wrote: > loladiro created this revision. > loladiro added reviewers: EricWF, mclow.lists. > loladiro added a subscriber: cfe-commits. > loladiro set the repository for this revision to rL

[PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

majnemer created this revision. majnemer added reviewers: rnk, rsmith, efriedma, chandlerc. majnemer added a subscriber: cfe-commits. GCC documents __builtin_alloca as aligning the storage to at least __BIGGEST_ALIGNMENT__. MSVC documents essentially the same for the x64 ABI:

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

Committed r281119. Let me know if you see any problem. Cheers, Manman On Fri, Sep 9, 2016 at 12:07 PM, Manman Ren wrote: > > > On Fri, Sep 9, 2016 at 11:33 AM, Richard Smith > wrote: > >> On Fri, Sep 9, 2016 at 11:29 AM, Manman Ren via cfe-commits

Re: [PATCH] D24330: Add some MS aliases for existing intrinsics

agutowski updated this revision to Diff 70926. agutowski added a comment. Separated Intel intrinsics tests https://reviews.llvm.org/D24330 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h include/clang/Basic/BuiltinsX86.def lib/Basic/Targets.cpp

Re: [PATCH] D21113: Add support for case-insensitive header lookup

sheu added a subscriber: sheu. sheu added a comment. I'd be very interested in seeing this patch happen. What's the current status here? Also, w.r.t. the cache invalidation problem -- would it be feasible / a good idea to move users of the FileSystem API to VirtualFileSystem, in general?

r281119 - Modules: for ObjectiveC try to keep the definition invariant.

Author: mren Date: Fri Sep 9 18:48:27 2016 New Revision: 281119 URL: http://llvm.org/viewvc/llvm-project?rev=281119=rev Log: Modules: for ObjectiveC try to keep the definition invariant. When deserializing ObjCInterfaceDecl with definition data, if we already have a definition, try to keep the

Re: [PATCH] D24307: calculate extent size for memory regions allocated by C++ new expression

dkrupp added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:83 @@ -78,1 +82,3 @@ + // we can assume that the region starts at 0. + if (!state->isNull(extentVal).isConstrained()) { return UnknownVal(); NoQ

[PATCH] D24383: Add addOrMerge interface to tooling::Replacements.

ioeric created this revision. ioeric added reviewers: klimek, djasper. ioeric added subscribers: alexshap, hokein, omtcyfz, cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D24383 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp

Re: [PATCH] D24371: Add diagnostics to require_constant_initialization

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10535-10538 @@ -10534,1 +10534,6 @@ << attr->getRange(); +APValue Value; +SmallVector Notes; +cast(var->ensureEvaluatedStmt()->Value)->EvaluateAsInitializer(

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai added a comment. In https://reviews.llvm.org/D24374#538534, @bcraig wrote: > In https://reviews.llvm.org/D24374#538521, @smeenai wrote: > > > @bcraig thanks for pointing me to that diff; there's a lot of nice cleanup > > going on there. Were you planning on updating and following up on

[PATCH] D24431: CodeGen: Start using inrange annotations on vtable getelementptr.

pcc created this revision. pcc added reviewers: rsmith, eugenis. pcc added subscribers: cfe-commits, krasin. pcc added a dependency: D22296: CodeGen: New vtable group representation: struct of vtable arrays.. This annotation allows the optimizer to split vtable groups, as permitted by a change

Re: [PATCH] D22296: CodeGen: New vtable group representation: struct of vtable arrays.

pcc added a comment. This should now be ready for review and unblocked by other changes (I split out the inrange annotation to https://reviews.llvm.org/D24431). https://reviews.llvm.org/D22296 ___ cfe-commits mailing list

Re: [PATCH] D24426: DebugInfo: use llvm::DINode::FlagAlignment to mark forcibly aligned data

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:979 @@ -978,4 +978,3 @@ llvm::DIType * -CGDebugInfo::createFieldType(StringRef name, QualType type, SourceLocation loc, - AccessSpecifier AS, uint64_t offsetInBits, -

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

ioeric added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:85 @@ +84,3 @@ + +SourceLocation getStartOfNextLine(SourceLocation Loc, const SourceManager , + const LangOptions ) { omtcyfz wrote: > Wouldn't it be

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

ioeric updated this revision to Diff 70793. ioeric marked 16 inline comments as done. ioeric added a comment. - Addressed reviewer comments. https://reviews.llvm.org/D24183 Files: CMakeLists.txt change-namespace/CMakeLists.txt change-namespace/ChangeNamespace.cpp

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

omtcyfz added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:232 @@ +231,3 @@ +} + +// FIXME(ioeric): handle the following symbols: handle == "ioeric" here s/FIXME(ioeric)/FIXME Comment at:

Re: [PATCH] D24235: [OpenCL] Improve double literal handling

neil.hickey added inline comments. Comment at: lib/Sema/SemaExpr.cpp:837 @@ +836,3 @@ + .getSupportedOpenCLOpts() + .cl_khr_fp64) || + getOpenCLOptions().cl_khr_fp64)) { Anastasia wrote: > Could we merge this and two lines

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

omtcyfz updated this revision to Diff 70802. omtcyfz marked 2 inline comments as done. omtcyfz added a comment. Slightly improve the interface. Patch is still not complete, though. https://reviews.llvm.org/D24192 Files: CMakeLists.txt clang-refactor/CMakeLists.txt

Re: [PATCH] D24278: [analyzer] Extend bug reports with extra notes.

bcraig added a subscriber: bcraig. bcraig added a comment. Neat! I would have liked to have had this for the Excess Padding Checker. Currently, the padding checker has a very long diagnostic that recommends a new order for data members. I think a note (or fixit) would be more appropriate,

Re: [PATCH] D24312: [CodeGen] Fix an assert in EmitNullConstant

rjmccall added a comment. LGTM. https://reviews.llvm.org/D24312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22296: [wip] CodeGen: New vtable group representation: struct of vtable arrays.

pcc updated this revision to Diff 70908. pcc added a comment. Refresh and split out the inrange changes into a separate patch https://reviews.llvm.org/D22296 Files: include/clang/AST/VTableBuilder.h lib/AST/VTableBuilder.cpp lib/CodeGen/CGCXX.cpp lib/CodeGen/CGVTT.cpp

r281089 - [CUDA] Make __GCC_ATOMIC_XXX_LOCK_FREE macros the same on host/device.

Author: jlebar Date: Fri Sep 9 15:35:43 2016 New Revision: 281089 URL: http://llvm.org/viewvc/llvm-project?rev=281089=rev Log: [CUDA] Make __GCC_ATOMIC_XXX_LOCK_FREE macros the same on host/device. Summary: This fixes a bug where we were unable to compile the following CUDA file with libstdc++

[PATCH] D24426: DebugInfo: use llvm::DINode::FlagAlignment to mark forcibly aligned data

vleschuk created this revision. vleschuk added reviewers: echristo, aprantl, dblaikie, mehdi_amini. vleschuk added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. Add llvm::DINode::FlagAlignment to entities marked with C++11 'alignas', C11 '_Alignas' keywords or ObjC clang

r281094 - Debug info: Bump the default DWARF version on Darwin to 4.

Author: adrian Date: Fri Sep 9 16:10:35 2016 New Revision: 281094 URL: http://llvm.org/viewvc/llvm-project?rev=281094=rev Log: Debug info: Bump the default DWARF version on Darwin to 4. This is a spiritual re-commit of r201375 with only a brief delay for upgrading the green dragon builders.

Re: [PATCH] D24426: DebugInfo: use llvm::DINode::FlagAlignment to mark forcibly aligned data

vleschuk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:979 @@ -978,4 +978,3 @@ llvm::DIType * -CGDebugInfo::createFieldType(StringRef name, QualType type, SourceLocation loc, - AccessSpecifier AS, uint64_t offsetInBits, -

[PATCH] D24439: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: mehdi_amini, compnerd. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

Re: [PATCH] D24278: [analyzer] Extend bug reports with extra notes.

zaks.anna added a comment. Thanks! Looks good overall. Several comments below. Comment at: lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:160 @@ +159,3 @@ +[](const IntrusiveRefCntPtr ) { + return isa(p.get()); +});

Re: [PATCH] D24371: Add diagnostics to require_constant_initialization

loladiro added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10535-10538 @@ -10534,1 +10534,6 @@ << attr->getRange(); +APValue Value; +SmallVector Notes; +

Re: [PATCH] D24407: [CUDA] Make __GCC_ATOMIC_XXX_LOCK_FREE macros the same on host/device.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281089: [CUDA] Make __GCC_ATOMIC_XXX_LOCK_FREE macros the same on host/device. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D24407?vs=70857=70895#toc Repository: rL LLVM

Re: [PATCH] D24411: [Analyzer] Suppress false positives on the clang static analyzer

hiraditya added a comment. IIRC, I was the primary author of this code, I'd really appreciate if you could attribute the code to the authors. Thanks https://reviews.llvm.org/D24411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r281132 - [tablegen] Check that an optional IdentifierArgument of an attribute is

Author: ahatanak Date: Fri Sep 9 22:29:43 2016 New Revision: 281132 URL: http://llvm.org/viewvc/llvm-project?rev=281132=rev Log: [tablegen] Check that an optional IdentifierArgument of an attribute is provided before trying to print it. This fixes a segfault that occurs when function

Re: [PATCH] D24426: DebugInfo: use llvm::DINode::FlagAlignment to mark forcibly aligned data

vleschuk updated this revision to Diff 70949. vleschuk added a comment. Reverted formatting changes. https://reviews.llvm.org/D24426 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h Index: lib/CodeGen/CGDebugInfo.h

Re: [PATCH] D24426: DebugInfo: use llvm::DINode::FlagAlignment to mark forcibly aligned data

vleschuk marked 2 inline comments as done. vleschuk added a comment. https://reviews.llvm.org/D24426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits