Re: [PATCH] D24804: clang-format: [JS] reserved words in method names.

2016-09-22 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282138: clang-format: [JS] reserved words in method names. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D24804?vs=72061&id=72140#toc Repository: rL LLVM https://reviews.l

r282138 - clang-format: [JS] reserved words in method names.

2016-09-22 Thread Martin Probst via cfe-commits
Author: mprobst Date: Thu Sep 22 02:18:00 2016 New Revision: 282138 URL: http://llvm.org/viewvc/llvm-project?rev=282138&view=rev Log: clang-format: [JS] reserved words in method names. Summary: Before: class X { delete () { ... } } After: class X { delete()

[PATCH] D24821: [ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl.

2016-09-22 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a reviewer: klimek. hokein added a subscriber: cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D24821 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersNarrowi

Re: [PATCH] D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option

2016-09-22 Thread Andrew Savonichev via cfe-commits
asavonic updated this revision to Diff 72143. asavonic added a comment. Herald added a subscriber: yaxunl. Add more test cases and fix minor issues https://reviews.llvm.org/D23712 Files: include/clang/Basic/OpenCLOptions.h include/clang/Basic/TargetInfo.h include/clang/Basic/TargetOptions

Re: [PATCH] D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option

2016-09-22 Thread Andrew Savonichev via cfe-commits
asavonic marked 3 inline comments as done. Comment at: include/clang/Basic/OpenCLOptions.h:39 @@ +38,3 @@ + + void set(llvm::StringRef Ext, bool Enable = true) { +assert(!Ext.empty() && "Extension is empty."); yaxunl wrote: > It seems Enable should be a local

Re: [PATCH] D24803: [change-namespace] fix qualifier of function references.

2016-09-22 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:290 @@ +289,3 @@ + // namespace. + // Note that the matcher does not exlude calls to out-of-line static method + // definitions, so we need to exclude them in the callback handler. s

Re: [PATCH] D24803: [change-namespace] fix qualifier of function references.

2016-09-22 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 72145. ioeric marked 2 inline comments as done. ioeric added a comment. - Addressing review comments: added a test case for out-of-line static method and fixed a bug. https://reviews.llvm.org/D24803 Files: change-namespace/ChangeNamespace.cpp unittests/

Re: [PATCH] D24803: [change-namespace] fix qualifier of function references.

2016-09-22 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang-tools-extra] r282146 - [change-namespace] fix qualifier of function references.

2016-09-22 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu Sep 22 06:54:00 2016 New Revision: 282146 URL: http://llvm.org/viewvc/llvm-project?rev=282146&view=rev Log: [change-namespace] fix qualifier of function references. Reviewers: hokein Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D24803 Modifi

Re: [PATCH] D24803: [change-namespace] fix qualifier of function references.

2016-09-22 Thread Eric Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282146: [change-namespace] fix qualifier of function references. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D24803?vs=72145&id=72152#toc Repository: rL LLVM https://revi

r282148 - Fixing sphinx build due to diagnostic:

2016-09-22 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Sep 22 07:15:18 2016 New Revision: 282148 URL: http://llvm.org/viewvc/llvm-project?rev=282148&view=rev Log: Fixing sphinx build due to diagnostic: /opt/llvm/build.attributes.src/tools/clang/docs/CommandGuide/clang.rst:338: WARNING: unknown option: -flto=full Modif

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-09-22 Thread Sylvestre Ledru via cfe-commits
sylvestre.ledru added a comment. What about landing this version now (with test) and do the other operators in the a second commit? thanks https://reviews.llvm.org/D22910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-09-22 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D22910#549611, @sylvestre.ledru wrote: > What about landing this version now (with test) and do the other operators in > the a second commit? thanks I don't see a whole lot of value in that, but I may be missing information -- is this

Re: r282148 - Fixing sphinx build due to diagnostic:

2016-09-22 Thread Teresa Johnson via cfe-commits
Thank you! Teresa On Thu, Sep 22, 2016 at 5:15 AM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Thu Sep 22 07:15:18 2016 > New Revision: 282148 > > URL: http://llvm.org/viewvc/llvm-project?rev=282148&view=rev > Log: > Fixing sphinx build due to

Re: r282148 - Fixing sphinx build due to diagnostic:

2016-09-22 Thread Teresa Johnson via cfe-commits
Hi Aaron, I just went back to the bot, which had first failed with a process error when I made my commit which is why I didn't see this error. It looks like it is still failing with the same error: http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/16313/steps/docs-clang-html/logs/stdio (

Re: r282148 - Fixing sphinx build due to diagnostic:

2016-09-22 Thread Aaron Ballman via cfe-commits
On Thu, Sep 22, 2016 at 9:34 AM, Teresa Johnson wrote: > Hi Aaron, > > I just went back to the bot, which had first failed with a process error > when I made my commit which is why I didn't see this error. It looks like it > is still failing with the same error: > > http://lab.llvm.org:8011/builde

Re: r282148 - Fixing sphinx build due to diagnostic:

2016-09-22 Thread Teresa Johnson via cfe-commits
On Thu, Sep 22, 2016 at 6:38 AM, Aaron Ballman wrote: > On Thu, Sep 22, 2016 at 9:34 AM, Teresa Johnson > wrote: > > Hi Aaron, > > > > I just went back to the bot, which had first failed with a process error > > when I made my commit which is why I didn't see this error. It looks > like it > > i

[PATCH] D24825: [X86] Remove the mm_malloc.h include guard hack from the X86 builtins tests

2016-09-22 Thread Elad Cohen via cfe-commits
eladcohen created this revision. eladcohen added a subscriber: cfe-commits. The X86 clang/test/CodeGen/*builtins.c tests define the mm_malloc.h include guard as a hack for avoiding its inclusion (mm_malloc.h requires a hosted environment since it expects stdlib.h to be available - which is not t

Re: r282148 - Fixing sphinx build due to diagnostic:

2016-09-22 Thread Aaron Ballman via cfe-commits
On Thu, Sep 22, 2016 at 9:41 AM, Teresa Johnson wrote: > > > > On Thu, Sep 22, 2016 at 6:38 AM, Aaron Ballman wrote: >> >> On Thu, Sep 22, 2016 at 9:34 AM, Teresa Johnson wrote: >> > Hi Aaron, >> > >> > I just went back to the bot, which had first failed with a process error >> > when I made my

r282151 - Second attempt to fix Sphinx bot

2016-09-22 Thread Teresa Johnson via cfe-commits
Author: tejohnson Date: Thu Sep 22 08:41:10 2016 New Revision: 282151 URL: http://llvm.org/viewvc/llvm-project?rev=282151&view=rev Log: Second attempt to fix Sphinx bot The fix in r282148 was not enough to fix the following error: /home/llvmbb/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

2016-09-22 Thread Serge Rogatch via cfe-commits
rSerge added a comment. In https://reviews.llvm.org/D24799#549442, @dberris wrote: > What does the error actually look like? Can you add a test for it? It's > unclear to me how this would read... for example does it say "XRay for arm is > unsupported"? In the attached picture you can see how

Re: r282148 - Fixing sphinx build due to diagnostic:

2016-09-22 Thread Teresa Johnson via cfe-commits
On Thu, Sep 22, 2016 at 6:43 AM, Aaron Ballman wrote: > On Thu, Sep 22, 2016 at 9:41 AM, Teresa Johnson > wrote: > > > > > > > > On Thu, Sep 22, 2016 at 6:38 AM, Aaron Ballman > wrote: > >> > >> On Thu, Sep 22, 2016 at 9:34 AM, Teresa Johnson > wrote: > >> > Hi Aaron, > >> > > >> > I just went

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

2016-09-22 Thread Dean Michael Berris via cfe-commits
dberris added a comment. In https://reviews.llvm.org/D24799#549634, @rSerge wrote: > In https://reviews.llvm.org/D24799#549442, @dberris wrote: > > > What does the error actually look like? Can you add a test for it? It's > > unclear to me how this would read... for example does it say "XRay for

[PATCH] D24826: [LTO] Add -flto-jobs=N to control backend parallelism

2016-09-22 Thread Teresa Johnson via cfe-commits
tejohnson created this revision. tejohnson added a reviewer: mehdi_amini. tejohnson added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. Currently, a linker option must be used to control the backend parallelism of ThinLTO or full LTO (where it only applies to parallel code gen

Re: [PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

2016-09-22 Thread Alexey Bataev via cfe-commits
ABataev added a subscriber: ABataev. ABataev added a comment. You need to add tests for serialization/deserialization https://reviews.llvm.org/D24807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

2016-09-22 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Serialization tests usually come from PCH, so you could probably look in test/PCH to get ideas on how to test this. https://reviews.llvm.org/D24807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D24828: [clang-move] Don't add old_header to the new files.

2016-09-22 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D24828 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h unittests/clang-move/ClangMoveTests.cpp Index: unittests/clang-move/ClangMoveTests.cpp =

r282154 - Third attempt to fix Sphinx bot

2016-09-22 Thread Teresa Johnson via cfe-commits
Author: tejohnson Date: Thu Sep 22 08:58:33 2016 New Revision: 282154 URL: http://llvm.org/viewvc/llvm-project?rev=282154&view=rev Log: Third attempt to fix Sphinx bot Bot now complaining about -flto=thin reference, used similar workaround for that failure. Modified: cfe/trunk/docs/CommandGu

Re: [PATCH] D24828: [clang-move] Don't add old_header to the new files.

2016-09-22 Thread Eric Liu via cfe-commits
ioeric added a comment. Could you elaborate on what this CL does in the description? https://reviews.llvm.org/D24828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24232: Wbitfiled-constant-conversion : allow ~0 , ~(1<

2016-09-22 Thread Daniel Marjamäki via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282156: Fix Wbitfield-constant-conversion false positives (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D24232?vs=70325&id=72169#toc Repository: rL LLVM https://re

Re: [PATCH] D24798: [mips] Fix msa builtins test

2016-09-22 Thread Simon Dardis via cfe-commits
sdardis abandoned this revision. sdardis added a comment. I'm abandoning this revision. This test is riddled with errors such as out of range immediates and type errors that aren't warned about. I'll post a more substantial patch to address the handling of those cases + update this test and I'l

r282156 - Fix Wbitfield-constant-conversion false positives

2016-09-22 Thread Daniel Marjamaki via cfe-commits
Author: danielmarjamaki Date: Thu Sep 22 09:13:46 2016 New Revision: 282156 URL: http://llvm.org/viewvc/llvm-project?rev=282156&view=rev Log: Fix Wbitfield-constant-conversion false positives Summary: The diagnostic did not handle ~ well. An expression such as ~0 is often used when 'all ones' is

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-22 Thread Vedant Kumar via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/Serialization/ASTReaderDecl.cpp:154 @@ -153,3 +153,3 @@ public: - RedeclarableResult(GlobalDeclID FirstID, Decl *MergeWith, bool IsKeyDecl) -

Re: [PATCH] D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option

2016-09-22 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. I think we need two more tests for concatenating and overriding the option, e.g -cl-ext=-cl_khr_fp64 -cl-ext=+cl_khr_fp64 and -cl-ext=-cl_khr_fp64,+cl_khr_fp64 Comment at: include/clang/Basic/OpenCLOptions.h:39 @@ +38,3 @@ + + void set(llvm::Strin

[clang-tools-extra] r282158 - [clang-tidy] Add doc for `explain-config` option.

2016-09-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Sep 22 09:36:43 2016 New Revision: 282158 URL: http://llvm.org/viewvc/llvm-project?rev=282158&view=rev Log: [clang-tidy] Add doc for `explain-config` option. Modified: clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp clang-tools-extra/trunk/docs/clang-tid

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

2016-09-22 Thread Haojian Wu via cfe-commits
hokein added a comment. The interfaces look good to me roughly. Comment at: migrate-tool/MigrationEnvironment.h:22 @@ +21,3 @@ +// RefactoringManager, and AffectedFilesFinder. +class MigrationEnvironment { +public: `MigrationContext` might be better? ==

Re: [PATCH] D24828: [clang-move] The new.cc file should include new_header.h instead of old_header.h

2016-09-22 Thread Eric Liu via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg with nits. Comment at: clang-move/ClangMove.cpp:290 @@ -294,1 +289,3 @@ llvm::StringRef FileName) { + // Don't add the old_header.h to the

Re: OpenBSD/arm types

2016-09-22 Thread Renato Golin via cfe-commits
Hi Mark, It seems not many people have additional comments, so LGTM. Do you have commit access? cheers, --renato On 20 September 2016 at 19:41, Mark Kettenis via cfe-commits wrote: > As discussed in cfe-dev@: > > Like NetBSD, OpenBSD prefers having a consistent set of typedefs > across the arc

Re: OpenBSD/arm types

2016-09-22 Thread Mark Kettenis via cfe-commits
> From: Renato Golin > Date: Thu, 22 Sep 2016 16:06:53 +0100 > > Hi Mark, > > It seems not many people have additional comments, so LGTM. > > Do you have commit access? No I don't. ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D24829: [clang-format] support header deletion in cleanupAroundReplacemnts.

2016-09-22 Thread Eric Liu via cfe-commits
ioeric created this revision. ioeric added a reviewer: djasper. ioeric added subscribers: klimek, cfe-commits. - If a replacement has offset UINT_MAX, length 0, and a replacement text that is an #include directive, this will insert the #include into the correct block in the \p Code. - If a rep

r282169 - [docs] Touch up the coverage docs some more

2016-09-22 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Thu Sep 22 10:34:33 2016 New Revision: 282169 URL: http://llvm.org/viewvc/llvm-project?rev=282169&view=rev Log: [docs] Touch up the coverage docs some more Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst URL: ht

Re: [PATCH] D24820: Add -stats-file option

2016-09-22 Thread Adrian Prantl via cfe-commits
aprantl added inline comments. Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:111 @@ -110,1 +110,3 @@ +def warn_fe_unable_to_open_stats_file : Warning< +"unable to open statistic output file '%0': '%1'">; def err_fe_no_pch_in_dir : Error< statstic

Re: [PATCH] D24339: [clang-tidy] Add check 'readability-redundant-member-init'

2016-09-22 Thread Malcolm Parsons via cfe-commits
malcolm.parsons updated this revision to Diff 72181. malcolm.parsons added a comment. Don't remove init of const members. Do remove calls to constructors that introduce cleanups. https://reviews.llvm.org/D24339 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityT

Re: [PATCH] D24826: [LTO] Add -flto-jobs=N to control backend parallelism

2016-09-22 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a comment. The Gold path looks fine. On OSX, we would have the clang driver relying on a LLVM cl::opt, for which I don't think there is any precedent. CC Duncan for advice. https://reviews.llvm.org/D24826 ___ cfe-commits mailing

Re: [PATCH] D24826: [LTO] Add -flto-jobs=N to control backend parallelism

2016-09-22 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a comment. Also I don't think the same option should be used for the parallel LTO codegen: it actually does not generate the same binary, which should deserve a dedicated opt-in (What if I mix ThinLTO and LTO, and I don't want // codegen?) https://reviews.llvm.org/D24826 _

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

2016-09-22 Thread Abe Skolnik via cfe-commits
Abe updated this revision to Diff 72186. Abe added a comment. Minor edits for style-guidelines conformance. https://reviews.llvm.org/D24481 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CodeGen/aarch64-neon-fma.c clang/test/CodeGen/aarch64-scalar-fma.c clang/test/CodeGen/f

Re: [PATCH] D24826: [LTO] Add -flto-jobs=N to control backend parallelism

2016-09-22 Thread Teresa Johnson via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D24826#549788, @mehdi_amini wrote: > The Gold path looks fine. > On OSX, we would have the clang driver relying on a LLVM cl::opt, for which > I don't think there is any precedent. CC Duncan for advice. I do see other uses of -mllvm in l

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

2016-09-22 Thread Artem Dergachev via cfe-commits
NoQ added a comment. Thanks, this makes a lot more sense to me! Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:691 @@ -690,1 +690,3 @@ + // Ignore autosynthesized code. + if (Mgr->getAnalysisDeclContext(D)->isBodyAutosynthesized()) I think this

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

2016-09-22 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. LGTM. Thanks. https://reviews.llvm.org/D24481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

2016-09-22 Thread Steve Canon via cfe-commits
scanon accepted this revision. scanon added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D24481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D20014: [libc++] Explicit return in non-void function

2016-09-22 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r269298. https://reviews.llvm.org/D20014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

2016-09-22 Thread Kit Barton via cfe-commits
kbarton added a comment. Aside from one minor comment, this LGTM. Comment at: lib/Basic/Targets.cpp:1364 @@ -1358,3 +1363,3 @@ // Handle explicit options being passed to the compiler here: if we've // explicitly turned off vsx and turned on power8-vector or direct-move then /

Re: OpenBSD/arm types

2016-09-22 Thread Renato Golin via cfe-commits
On 22 September 2016 at 16:19, Mark Kettenis wrote: > No I don't. No problems. Committed in r282184. cheers, --renato ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r282184 - [OpenBSD] Add type sign information for OpenBSD

2016-09-22 Thread Renato Golin via cfe-commits
Author: rengolin Date: Thu Sep 22 14:28:20 2016 New Revision: 282184 URL: http://llvm.org/viewvc/llvm-project?rev=282184&view=rev Log: [OpenBSD] Add type sign information for OpenBSD Like NetBSD, OpenBSD prefers having a consistent set of typedefs across the architectures it supports over strictl

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-22 Thread Alexander Shaposhnikov via cfe-commits
alexshap added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:154 @@ -153,3 +153,3 @@ public: - RedeclarableResult(GlobalDeclID FirstID, Decl *MergeWith, bool IsKeyDecl) - : FirstID(FirstID), MergeWith(MergeWith), IsKeyDecl(IsKeyDecl) {} +

Re: OpenBSD/arm types

2016-09-22 Thread Mark Kettenis via cfe-commits
> From: Renato Golin > Date: Thu, 22 Sep 2016 20:37:19 +0100 > > On 22 September 2016 at 16:19, Mark Kettenis wrote: > > No I don't. > > No problems. Committed in r282184. Thanks! ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D24785: [AVX512] Fix return types on __builtin_ia32_gather3XivXdi builtins

2016-09-22 Thread Cameron McInally via cfe-commits
cameron.mcinally closed this revision. cameron.mcinally added a comment. This was fixed with r282082. My cfe-commits email is being held for moderation (not a member of the list), so there was no automatic update. Repository: rL LLVM https://reviews.llvm.org/D24785 __

[PATCH] D24841: [asan] Fix incorrect SEH symbol mangling on win64.

2016-09-22 Thread Etienne Bergeron via cfe-commits
etienneb created this revision. etienneb added reviewers: rnk, kcc. etienneb added subscribers: cfe-commits, chrisha. The ASAN unittests are failing (check-asan-dynamic) due to an incorrect symbol name: ``` LINK : error LNK2001: unresolved external symbol ___asan_seh_interceptor ``` On win64, th

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-22 Thread Richard Smith via cfe-commits
What's the purpose of this change? We only put these objects in the stack, and never have many of them at once. If we don't care about size, a natural field order seems preferable to one that minimises padding. On 22 Sep 2016 12:41 pm, "Alexander Shaposhnikov" wrote: > alexshap added inline comm

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

2016-09-22 Thread Alexander Shaposhnikov via cfe-commits
alexshap updated this revision to Diff 72206. alexshap added a comment. Move the check to AnalysisConsumer::HandleCode. Repository: rL LLVM https://reviews.llvm.org/D24792 Files: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp test/An

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-22 Thread Александр Шапошников via cfe-commits
>What's the purpose of this change PaddingChecker generates a report on it, yeah, you are right that it won't save too much (just a little), but it was easy to fix. Another reason why i am doing this - it reduces the number of reports produced by static analyzer (less noisy) - and since it saves sm

Re: [PATCH] D24792: [analyzer] Fix crash in RetainCountChecker::checkEndFunction

2016-09-22 Thread Artem Dergachev via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks again! LGTM. Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:656 @@ +655,3 @@ + // Clear the AnalysisManager of old AnalysisDeclContexts. + Mgr->ClearContexts(

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-22 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. Thank you for the great example! I can now see this patch does fix mis-compiles. There are probably other lifetime bugs you'll see when the code being compiled includes gotos that jump past variable declarations, including the one here: http://lists.llvm.org/pipermail/

Re: [PATCH] D24841: [asan] Fix incorrect SEH symbol mangling on win64.

2016-09-22 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D24841 ___ cfe-commits mailing list

[PATCH] D24845: [clang-tidy] fix for NOLINT after macro expansion

2016-09-22 Thread Matthias Gehre via cfe-commits
mgehre created this revision. mgehre added reviewers: alexfh, aaron.ballman, hokein. mgehre added a subscriber: cfe-commits. When having ``` c++ #define MACRO code-with-warning MACRO; // NOLINT ``` clang-tidy would still show the warning, because it searched for "NOLINT" only in the first

[PATCH] D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers

2016-09-22 Thread Matthias Gehre via cfe-commits
mgehre created this revision. mgehre added reviewers: alexfh, aaron.ballman. mgehre added a subscriber: cfe-commits. Herald added a subscriber: nemanjai. This fixes https://llvm.org/bugs/show_bug.cgi?id=30487 where ``` warning: uninitialized record type: 's' [cppcoreguidelines-pro-type-member-init

Re: [PATCH] D24826: [LTO] Add -flto-jobs=N to control backend parallelism

2016-09-22 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Sep-22, at 09:53, Teresa Johnson wrote: > > tejohnson added a comment. > > In https://reviews.llvm.org/D24826#549788, @mehdi_amini wrote: > >> The Gold path looks fine. >> On OSX, we would have the clang driver relying on a LLVM cl::opt, for which >> I don't think there is any prec

Re: [PATCH] D21677: Add ignoringImplicit matcher

2016-09-22 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r273659. Please specify Differential revision in commit message. Repository: rL LLVM https://reviews.llvm.org/D21677

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

2016-09-22 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r276750. https://reviews.llvm.org/D21343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D21022: [ARM] Fix linker emulation for arm 32 big endian

2016-09-22 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r272402. https://reviews.llvm.org/D21022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

2016-09-22 Thread Tom Stellard via cfe-commits
tstellarAMD accepted this revision. tstellarAMD added a comment. LGTM. https://reviews.llvm.org/D24513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r282228 - [AVX-512] Add initial support for checking rounding mode arguments of builtins.

2016-09-22 Thread Craig Topper via cfe-commits
Author: ctopper Date: Thu Sep 22 23:48:31 2016 New Revision: 282228 URL: http://llvm.org/viewvc/llvm-project?rev=282228&view=rev Log: [AVX-512] Add initial support for checking rounding mode arguments of builtins. The backend can't encode all possible values of the argument and will fail isel. C

r282227 - [X86] Split up the single switch statement in Sema::CheckX86BuiltinFunctionCall into different switches or ifs for each type of check.

2016-09-22 Thread Craig Topper via cfe-commits
Author: ctopper Date: Thu Sep 22 23:48:27 2016 New Revision: 282227 URL: http://llvm.org/viewvc/llvm-project?rev=282227&view=rev Log: [X86] Split up the single switch statement in Sema::CheckX86BuiltinFunctionCall into different switches or ifs for each type of check. This in preparation for a n