[PATCH] D24958: Test linked to D24957

zizhar created this revision. zizhar added a reviewer: rnk. zizhar added a subscriber: cfe-commits. zizhar set the repository for this revision to rL LLVM. A test for the patch in https://reviews.llvm.org/D24957 Repository: rL LLVM https://reviews.llvm.org/D24958 Files:

r282484 - Silencing a Sphinx diagnostic with options, again.

Author: aaronballman Date: Tue Sep 27 07:17:05 2016 New Revision: 282484 URL: http://llvm.org/viewvc/llvm-project?rev=282484=rev Log: Silencing a Sphinx diagnostic with options, again. Warning, treated as error: /opt/llvm/build.attributes.src/tools/clang/docs/CommandGuide/clang.rst:413:

Re: [PATCH] D24119: [libc++] add linker option "-Wl, -z, defs" in standalone build

This revision was automatically updated to reflect the committed changes. Closed by commit rL282483: [cmake] Add linker option "-Wl,-z,defs" in standalone build (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D24119?vs=69944=72632#toc Repository: rL LLVM

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

ioeric updated this revision to Diff 72635. ioeric marked 2 inline comments as done. ioeric added a comment. - Replace dummy binary with unit test with dummy environemnt + fake codebase. https://reviews.llvm.org/D24380 Files: CMakeLists.txt migrate-tool/AffectedFilesFinder.h

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

ioeric added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:179-181 @@ +178,5 @@ +Replacements::mergeIfOrderIndependent(const Replacement ) const { + Replacements Rs(R); + Replacements ShiftedRs(getReplacementInChangedCode(R)); + Replacements ShiftedReplaces; +

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

ioeric updated this revision to Diff 72642. ioeric marked 6 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D24800 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp

Re: [PATCH] D24962: [ASTMatchers] Let registerMatcher() take a const char * instead of a StringRef

mboehme abandoned this revision. mboehme added a comment. Abandoning after discussion with klimek. https://reviews.llvm.org/D24962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24717: Merge deletions that are contained in a larger deletion.

ioeric abandoned this revision. ioeric added a comment. Abandon in favor of https://reviews.llvm.org/D24800 https://reviews.llvm.org/D24717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24961: [avx512] Add aliases to some missing avx512 intrinsics.

igorb accepted this revision. igorb added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D24961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24962: [ASTMatchers] Let registerMatcher() take a const char * instead of a StringRef

mboehme created this revision. mboehme added a reviewer: klimek. mboehme added a subscriber: cfe-commits. Herald added a subscriber: klimek. r282433 added LLVM_ATTRIBUTE_ALWAYS_INLINE to the StringRef(const char *) constructor. This causes the size of the stack frame for

Re: [PATCH] D24119: [libc++] add linker option "-Wl, -z, defs" in standalone build

rmaprath added a subscriber: rmaprath. Comment at: libcxx/trunk/CMakeLists.txt:329 @@ +328,3 @@ + ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND + NOT LLVM_USE_SANITIZER) +set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")

[PATCH] D24963: [change-namespace] fix namespace specifier of global variables.

ioeric created this revision. ioeric added a reviewer: hokein. ioeric added a subscriber: cfe-commits. https://reviews.llvm.org/D24963 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-namespace/ChangeNamespaceTests.cpp

r282488 - [avx512] Add aliases to some missing avx512 intrinsics.

Author: aymanmus Date: Tue Sep 27 09:06:32 2016 New Revision: 282488 URL: http://llvm.org/viewvc/llvm-project?rev=282488=rev Log: [avx512] Add aliases to some missing avx512 intrinsics. Differential Revision:https: //reviews.llvm.org/D24961 Modified: cfe/trunk/lib/Headers/avx512fintrin.h

Re: [PATCH] D24119: [libc++] add linker option "-Wl, -z, defs" in standalone build

zlei added inline comments. Comment at: libcxx/trunk/CMakeLists.txt:329 @@ +328,3 @@ + ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND + NOT LLVM_USE_SANITIZER) +set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs") rmaprath

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

loladiro added a comment. Before I commit this, I just realized __libcpp_compressed_pair_imp& operator=(const __libcpp_compressed_pair_imp& __p) _NOEXCEPT_(is_nothrow_copy_assignable<_T1>::value && is_nothrow_copy_assignable<_T2>::value) {

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

hiraditya added a comment. ping! https://reviews.llvm.org/D24682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24986: Headers: Add iso_volatile load/store intrinsics

majnemer added a comment. IMO, this should be implemented in clang CodeGen so that we don't get extra acquire/release barriers with /volatile:ms but that might be overkill; feel free to disregard this. https://reviews.llvm.org/D24986 ___

Re: [PATCH] D24915: [analyzer] Extend bug reports with extra notes - ObjCDeallocChecker

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM and Devin's comments have been addressed. https://reviews.llvm.org/D24915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

loladiro updated this revision to Diff 72712. loladiro added a comment. Some extra _AFTER_CXX11 that may be necessary - please double check me here, C++11 constexpr rules are not exactly my specialty ;). Repository: rL LLVM https://reviews.llvm.org/D24372 Files: include/memory

Re: [PATCH] D24861: [Sema] extend Wshift-op-parentheses so it warns for multiplicative operators

joerg added a subscriber: joerg. joerg added a comment. I think the comment from Daniel shows the crux of the issue. A left shift is by nature a multiplication operation, so I don't see why it should get the warning. A right shift works like a division and order is quite significant for that.

[libcxx] r282483 - [cmake] Add linker option "-Wl, -z, defs" in standalone build

Author: mgorny Date: Tue Sep 27 07:15:35 2016 New Revision: 282483 URL: http://llvm.org/viewvc/llvm-project?rev=282483=rev Log: [cmake] Add linker option "-Wl,-z,defs" in standalone build Add the "-Wl,-z,defs" linker option that is used to prevent underlinking. It is already used by LLVM itself

Re: [PATCH] D19586: Misleading Indentation check

xazax.hun added inline comments. Comment at: test/clang-tidy/readability-misleading-indentation.cpp:16 @@ +15,3 @@ + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: wrong indentation, 'else' belongs to 'if(cond2)' statement + // CHECK-FIXES: {{^}} //

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

nemanjai closed this revision. nemanjai added a comment. Committed revision 282481. Repository: rL LLVM https://reviews.llvm.org/D24397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24922: [clang-move] Make it support both relative and absolute file path arguments.

hokein updated this revision to Diff 72619. hokein marked 8 inline comments as done. hokein added a comment. Address review comments. https://reviews.llvm.org/D24922 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/ClangMoveMain.cpp

Re: [PATCH] D24922: [clang-move] Make it support both relative and absolute file path arguments.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:62 @@ +61,3 @@ + return MakeAbsolutePath(SourceManager, FileEntry->getName()) == + AbsoluteFilePath; +} ioeric wrote: > To generalize the function, maybe also remove dots in

Re: [PATCH] D24905: Fix unreachable code false positive, vardecl in switch

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp:195 @@ +194,3 @@ +if (Optional S = I->getAs()) { + if (isa(S->getStmt())) +return S->getStmt(); Maybe I would prefer something like !isa which is

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

klimek added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:177-178 @@ +176,4 @@ + /// - are insertions at the same offset and applying them in either order + /// has the same effect, i.e. X + Y = Y + X if one inserts text X and the + /// other

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 72625. a.sidorin added a comment. Address review comments; add accidentally missed file. https://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h lib/AST/ASTImporter.cpp

[clang-tools-extra] r282486 - Workaround ASTMatcher crashes. Added some more test cases.

Author: ioeric Date: Tue Sep 27 07:54:48 2016 New Revision: 282486 URL: http://llvm.org/viewvc/llvm-project?rev=282486=rev Log: Workaround ASTMatcher crashes. Added some more test cases. Summary: - UsingDecl matcher crashed when `UsingShadowDecl` has no parent map. Workaround by moving parent

Re: [PATCH] D24862: Workaround ASTMatcher crashes. Added some more test cases.

This revision was automatically updated to reflect the committed changes. Closed by commit rL282486: Workaround ASTMatcher crashes. Added some more test cases. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D24862?vs=72284=72640#toc Repository: rL LLVM

[PATCH] D24961: [avx512] Add aliases to some missing avx512 intrinsics.

aymanmus created this revision. aymanmus added reviewers: m_zuckerman, igorb, delena. aymanmus added a subscriber: cfe-commits. - "//_mm512_cmp_pd_mask//" Intrinsics, where = {eq, le, lt, neq, nle, nlt, ord, unord}. - //_mm512_cvtepi32lo_pd, _mm512_mask_cvtepi32lo_pd, _mm512_cvtepu32lo_pd,

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

klimek added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:177-178 @@ +176,4 @@ + /// - are insertions at the same offset and applying them in either order + /// has the same effect, i.e. X + Y = Y + X if one inserts text X and the + /// other

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

hxy9243 created this revision. hxy9243 added reviewers: sebpop, hiraditya, wmi. hxy9243 added a subscriber: cfe-commits. hxy9243 set the repository for this revision to rL LLVM. This patch moves some existing functions from the memory.cpp to the memory header file, so that they could be properly

r282545 - Shorten DiagnosticInfoOptimizationRemark* to OptimizationRemark*. NFC

Author: anemet Date: Tue Sep 27 17:19:29 2016 New Revision: 282545 URL: http://llvm.org/viewvc/llvm-project?rev=282545=rev Log: Shorten DiagnosticInfoOptimizationRemark* to OptimizationRemark*. NFC With the new streaming interface in LLVM, these class names need to be typed a lot and it's way

Re: [PATCH] D24981: [Coverage] The coverage region for a switch should cover the code after the switch

This revision was automatically updated to reflect the committed changes. Closed by commit rL282554: [Coverage] The coverage region for switch covers the code after the switch. (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D24981?vs=72692=72733#toc Repository: rL

Re: [PATCH] D24975: [CUDA] Add #pragma clang force_cuda_host_device_{begin, end} pragmas.

jlebar added a comment. > What happens if there are trailing tokens after the pragma? Added code to make this an error. https://reviews.llvm.org/D24975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator

dcoughlin added a comment. @parallaxe Do you need someone to commit this for you? https://reviews.llvm.org/D23236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24999: [Sema] Only relax array-at-end-of-object checks in __builtin_object_size when -fno-strict-aliasing is given.

george.burgess.iv created this revision. george.burgess.iv added reviewers: joerg, rsmith. george.burgess.iv added a subscriber: cfe-commits. Mostly asking for a review to verify that you guys are happy with this approach. Given that Hal said struct-path-tbaa doesn't really deal with arrays

Re: [PATCH] D24998: Add a new optimization option -Og

sylvestre.ledru updated this revision to Diff 72759. sylvestre.ledru added a comment. with the full context + clang format https://reviews.llvm.org/D24998 Files: docs/CommandGuide/clang.rst lib/Frontend/CompilerInvocation.cpp test/Driver/debug-options.c test/Preprocessor/init.c Index:

[PATCH] D25001: [Module] Merge function prototype with a non-prototype function declaration

ahatanak created this revision. ahatanak added reviewers: doug.gregor, rsmith. ahatanak added a subscriber: cfe-commits. This patch fixes a crash that occurs when a non-prototype function is declared before a header containing a prototype of the same function is included. This caused

[PATCH] D24998: Add a new optimization option -Og

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: rengolin. sylvestre.ledru added a subscriber: cfe-commits. Just like gcc, we should have the -Og option as more and more software are using it: https://llvm.org/bugs/show_bug.cgi?id=20765 https://reviews.llvm.org/D24998

Re: [PATCH] D24998: Add a new optimization option -Og

majnemer added a subscriber: majnemer. majnemer added a comment. Please include full context with your diff. Comment at: lib/Frontend/CompilerInvocation.cpp:101-103 @@ -100,1 +100,5 @@ +if (S == "g") { +return 1; +} + Please clang-format this.

r282556 - P0145R3 (C++17 evaluation order tweaks): evaluate the right-hand side of

Author: rsmith Date: Tue Sep 27 18:44:22 2016 New Revision: 282556 URL: http://llvm.org/viewvc/llvm-project?rev=282556=rev Log: P0145R3 (C++17 evaluation order tweaks): evaluate the right-hand side of assignment and compound-assignment operators before the left-hand side. (Even if it's an

r282557 - Put new warning in a diagnostic group.

Author: matze Date: Tue Sep 27 18:44:38 2016 New Revision: 282557 URL: http://llvm.org/viewvc/llvm-project?rev=282557=rev Log: Put new warning in a diagnostic group. The warning I added in r282426 should be a diagnostic group. Modified:

r282555 - Revert r282547 and add test to show correct behavior.

Author: rtrieu Date: Tue Sep 27 18:44:07 2016 New Revision: 282555 URL: http://llvm.org/viewvc/llvm-project?rev=282555=rev Log: Revert r282547 and add test to show correct behavior. Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp

Re: r282547 - Fix defaulted member functions for templated classes.

Reverted in r282555. On Tue, Sep 27, 2016 at 3:44 PM, Richard Smith wrote: > It looks like this will reject valid code, such as: > > template struct X { > using T = typename std::conditional::type; > X(); > X(T) = default; // either copyable or

Re: [PATCH] D24975: [CUDA] Add #pragma clang force_cuda_host_device_{begin, end} pragmas.

rsmith added a comment. Please add serialisation code for the push count for PCH. Should it be an error if the count is nonzero at the end of the TU? What happens if there are trailing tokens after the pragma? Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1027

Re: r282547 - Fix defaulted member functions for templated classes.

It looks like this will reject valid code, such as: template struct X { using T = typename std::conditional::type; X(); X(T) = default; // either copyable or moveable, depending on B }; On Tue, Sep 27, 2016 at 3:28 PM, Richard Trieu via cfe-commits <

[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

jbangert created this revision. jbangert added a reviewer: alexfh. jbangert added a subscriber: cfe-commits. jbangert added a project: clang-tools-extra. This adds helper classes to add using declaractions and namespace aliases to function bodies. These help making function calls to deeply

Re: [PATCH] D24979: [CUDA] Support and std::min/max on the device.

jlebar updated this revision to Diff 72719. jlebar added a comment. Herald added a subscriber: mehdi_amini. s/libgcc/runtime/ https://reviews.llvm.org/D24979 Files: clang/lib/Driver/ToolChains.cpp clang/lib/Headers/CMakeLists.txt clang/lib/Headers/__clang_cuda_complex_builtins.h

Re: [PATCH] D24975: [CUDA] Add #pragma clang force_cuda_host_device_{begin, end} pragmas.

jlebar updated this revision to Diff 72717. jlebar marked 2 inline comments as done. jlebar added a comment. Address Richard Smith's review comments: - Change macro format. - Add tests (these Just Worked). https://reviews.llvm.org/D24975 Files:

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGCXX.cpp:137-138 @@ -136,1 +136,4 @@ + // Disallow aliases to available_externally because available_externally + // will not be there in the end to allow the creation of the alias (PR30341). + // FIXME: An extern

Re: [PATCH] D24373: [Coroutines] Adding builtins for coroutine intrinsics and backendutil support.

GorNishanov marked an inline comment as done. Comment at: include/clang/Basic/Builtins.def:1293 @@ +1292,3 @@ + +BUILTIN(__builtin_coro_id, "v*Iiv*v*v*", "n") +BUILTIN(__builtin_coro_alloc, "bv*", "n") rsmith wrote: > I don't really like having builtins which

Re: [PATCH] D24975: [CUDA] Add #pragma clang force_cuda_host_device_{begin, end} pragmas.

jlebar updated this revision to Diff 72734. jlebar marked 2 inline comments as done. jlebar added a comment. Address Richard's comments. I'm fairly neutral on whether we want to make it an error not to match all of your "begin" pragmas with "end"s. I checked pragma push_macro, and it looks like

Re: [PATCH] D9127: PR23175 (fix) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. Repository: rL LLVM https://reviews.llvm.org/D9127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24373: [Coroutines] Adding builtins for coroutine intrinsics and backendutil support.

GorNishanov updated the summary for this revision. GorNishanov removed a reviewer: majnemer. GorNishanov updated this revision to Diff 72732. GorNishanov added a comment. Herald added a subscriber: mgorny. 1. Added documentation for builtins 2. Added a couple of tests with -disable-llvm-passes to

Re: [PATCH] D11235: clang-format: Fix breaking before nested 'operator' in function declarations

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D11235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r282547 - Fix defaulted member functions for templated classes.

Author: rtrieu Date: Tue Sep 27 17:28:59 2016 New Revision: 282547 URL: http://llvm.org/viewvc/llvm-project?rev=282547=rev Log: Fix defaulted member functions for templated classes. In some cases, non-special member functions were being marked as being defaulted in templated classes. This can

r282564 - Revert r282556. This change made several bots unhappy.

Author: rsmith Date: Tue Sep 27 21:20:06 2016 New Revision: 282564 URL: http://llvm.org/viewvc/llvm-project?rev=282564=rev Log: Revert r282556. This change made several bots unhappy. Modified: cfe/trunk/include/clang/AST/ExprCXX.h cfe/trunk/lib/CodeGen/CGCall.cpp

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL256046. https://reviews.llvm.org/D10370 ___ cfe-commits mailing list

r282554 - [Coverage] The coverage region for switch covers the code after the switch.

Author: arphaman Date: Tue Sep 27 18:30:36 2016 New Revision: 282554 URL: http://llvm.org/viewvc/llvm-project?rev=282554=rev Log: [Coverage] The coverage region for switch covers the code after the switch. This patch fixes a regression introduced in r262697 that changed the way the coverage

Re: [PATCH] D24119: [libc++] add linker option "-Wl, -z, defs" in standalone build

rmaprath added inline comments. Comment at: libcxx/trunk/CMakeLists.txt:329 @@ +328,3 @@ + ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND + NOT LLVM_USE_SANITIZER) +set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs") zlei

Re: [PATCH] D24719: [include-fixer] Add customized editor settings documents.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D24719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24861: [Sema] extend Wshift-op-parentheses so it warns for multiplicative operators

danielmarjamaki added a comment. Compiling 2064 projects resulted in 904 warnings Here are the results: https://drive.google.com/file/d/0BykPmWrCOxt2N04tYl8zVHA3MXc/view?usp=sharing The results looks acceptable imho. The code looks intentional in many cases so I believe there are users that

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

ABataev added inline comments. Comment at: lib/AST/ASTImporter.cpp:3414 @@ +3413,3 @@ + // FriendDecl is not a NamedDecl so we cannot use localUncachedLookup. + CXXRecordDecl *RD = cast(DC); + FriendDecl *ImportedFriend = RD->getFirstFriend(); CXXRecordDecl

Re: [PATCH] D24954: [ToolChains] Disable OpenSUSE rules for SLES10

mgorny retitled this revision from "[ToolChains] Do not assume OpenSUSE for other SUSE variants" to "[ToolChains] Disable OpenSUSE rules for SLES10". mgorny updated the summary for this revision. mgorny updated this revision to Diff 72609. mgorny added a comment. Does this one look better for

[libcxx] r282524 - Revert r282483 - [cmake] Add linker option "-Wl, -z, defs" in standalone build

Author: mgorny Date: Tue Sep 27 13:54:02 2016 New Revision: 282524 URL: http://llvm.org/viewvc/llvm-project?rev=282524=rev Log: Revert r282483 - [cmake] Add linker option "-Wl,-z,defs" in standalone build Revert r282483 as it causes build failures due to missing symbols when not linking to

Re: [PATCH] D24119: [libc++] add linker option "-Wl, -z, defs" in standalone build

rmaprath added a comment. In https://reviews.llvm.org/D24119#554234, @mgorny wrote: > I'm starting to regret that I've committed this. It breaks horribly any > pure-LLVM build, i.e. without linking to libgcc_s. It seems that the build > system is completely unprepared to link to compiler-rt or

Re: [PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

malcolm.parsons added a subscriber: malcolm.parsons. malcolm.parsons added a comment. In https://reviews.llvm.org/D24886#554130, @mgehre wrote: > 2. Also, I suspect we will want this attribute to also be written on types I > was thinking about a case were that was useful, and didn't find any.

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

ioeric updated this revision to Diff 72666. ioeric marked 3 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D24800 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

ioeric added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:179-181 @@ +178,5 @@ +llvm::Expected +Replacements::mergeIfOrderIndependent(const Replacement ) const { + Replacements Rs(R); + Replacements RsShiftedByReplaces(getReplacementInChangedCode(R)); +

r282500 - Adapt to LLVM optimization remark interface change. NFC

Author: anemet Date: Tue Sep 27 11:15:21 2016 New Revision: 282500 URL: http://llvm.org/viewvc/llvm-project?rev=282500=rev Log: Adapt to LLVM optimization remark interface change. NFC Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp URL:

Re: [PATCH] D24752: [Modules] Add missing dependencies to clang builtins modulemap

bruno added a subscriber: bruno. Comment at: lib/Headers/module.modulemap:133 @@ -131,2 +132,3 @@ explicit module aes { + export sse2 header "__wmmintrin_aes.h" The mmx case above makes sense to me, but I find conceptually odd that we need to

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

ahatanak created this revision. ahatanak added reviewers: doug.gregor, rsmith. ahatanak added a subscriber: cfe-commits. This fixes PR30361. clang was failing to compile the test case because it was passing "~C1" instead of "~C1" to FindInstantiatedDecl and RebuildMemberExpr.

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

klimek added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:179-181 @@ +178,5 @@ +llvm::Expected +Replacements::mergeIfOrderIndependent(const Replacement ) const { + Replacements Rs(R); + Replacements RsShiftedByReplaces(getReplacementInChangedCode(R)); +

r282504 - Revert "Adapt to LLVM optimization remark interface change. NFC"

Author: anemet Date: Tue Sep 27 11:39:27 2016 New Revision: 282504 URL: http://llvm.org/viewvc/llvm-project?rev=282504=rev Log: Revert "Adapt to LLVM optimization remark interface change. NFC" This reverts commit r282500. Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp Modified:

Re: [PATCH] D24861: [Sema] extend Wshift-op-parentheses so it warns for multiplicative operators

bruno added a subscriber: bruno. bruno added a comment. Hi Daniel, This is very nice. In https://reviews.llvm.org/D24861#553606, @danielmarjamaki wrote: > Compiling 2064 projects resulted in 904 warnings > > Here are the results: >

Re: [libcxx] r282483 - [cmake] Add linker option "-Wl, -z, defs" in standalone build

On Tue, Sep 27, 2016 at 12:15:35PM -, Michal Gorny via cfe-commits wrote: > Author: mgorny > Date: Tue Sep 27 07:15:35 2016 > New Revision: 282483 > > URL: http://llvm.org/viewvc/llvm-project?rev=282483=rev > Log: > [cmake] Add linker option "-Wl,-z,defs" in standalone build > > Add the

r282492 - Update to commit r282488, fix the buildboot failure.

Author: aymanmus Date: Tue Sep 27 10:37:31 2016 New Revision: 282492 URL: http://llvm.org/viewvc/llvm-project?rev=282492=rev Log: Update to commit r282488, fix the buildboot failure. Modified: cfe/trunk/lib/Headers/avx512fintrin.h Modified: cfe/trunk/lib/Headers/avx512fintrin.h URL:

Re: [PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

rmaprath added inline comments. Comment at: src/config.h:22 @@ +21,3 @@ + +#if defined(__GNUC__) || defined(__clang__) +#define _LIBCXXABI_PRAGMA(_parameter_) _Pragma(#_parameter_) EricWF wrote: > What's the point of defining `_LIBCXXABI_WARNING`? It's unused and

[PATCH] D24965: [clang-tidy] Fix cppcoreguidelines-pro-type-member-init false negatives

malcolm.parsons created this revision. malcolm.parsons added reviewers: alexfh, aaron.ballman, omtcyfz. malcolm.parsons added subscribers: cfe-commits, mgehre. Herald added a subscriber: nemanjai. Handle classes with default constructors that are defaulted or are not present in the AST. Classes

Re: [PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

rmaprath updated this revision to Diff 72653. rmaprath added a comment. Herald added subscribers: mgorny, beanz. Address review comments from @compnerd and @EricWF. https://reviews.llvm.org/D24864 Files: CMakeLists.txt src/config.h src/cxa_exception.cpp src/cxa_exception_storage.cpp

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with two minor nits. Comment at: lib/AST/ASTImporter.cpp:5563-5564 @@ +5562,4 @@ +const TemplateArgumentLoc *FromArgArray = E->getTemplateArgs(); +for (unsigned i = 0, e = E->getNumTemplateArgs();

Re: [PATCH] D24809: [libcxx] [cmake] Strip possibly-inherited compiler flags in in-tree build only

mgorny retitled this revision from "[libcxx] [cmake] Stop stripping -m32 from compiler flags" to "[libcxx] [cmake] Strip possibly-inherited compiler flags in in-tree build only". mgorny updated the summary for this revision. mgorny added a reviewer: beanz. mgorny updated this revision to Diff

Re: [PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

mgorny added a comment. @rafael, ping. Could you review this, please? This is the solution you suggested on the bug. https://reviews.llvm.org/D23754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24914: [clang-rename] Do not print out error message upon encountering multiple replacements in the same SourceLocation.

omtcyfz updated this revision to Diff 72604. omtcyfz marked 2 inline comments as done. omtcyfz added a comment. Address two comments from Alex. https://reviews.llvm.org/D24914 Files: clang-rename/RenamingAction.cpp Index: clang-rename/RenamingAction.cpp

Re: [PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

mgehre added a comment. Thank your very much for your comments! Let me try to give me reasoning for those points: 1. But it's missing some pieces, like test cases I though about how to test this, having no semantic meaning itself. I could look at the AST dump, but it does not even show the

Re: [PATCH] D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers

mgehre updated this revision to Diff 72677. mgehre added a comment. Rename the struct that was introduced in the test. Note that I need to keep the function Bug30487, because that is where the false-positive warning was emitted. https://reviews.llvm.org/D24848 Files:

Re: [PATCH] D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers

On Tue, Sep 27, 2016 at 2:05 PM, Matthias Gehre wrote: > mgehre updated this revision to Diff 72677. > mgehre added a comment. > > Rename the struct that was introduced in the test. Note that I need to keep > the function Bug30487, > because that is where the false-positive

Re: [PATCH] D24278: [analyzer] Extend bug reports with extra notes.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. I have no further comments. https://reviews.llvm.org/D24278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers

malcolm.parsons added a comment. In https://reviews.llvm.org/D24848#554145, @mgehre wrote: > Rename the struct that was introduced in the test. Note that I need to keep > the function Bug30487, > because that is where the false-positive warning was emitted. https://reviews.llvm.org/D24965

Re: [PATCH] D24119: [libc++] add linker option "-Wl, -z, defs" in standalone build

mgorny added a comment. In https://reviews.llvm.org/D24119#554251, @rmaprath wrote: > Doesn't `-DLIBCXXABI_USE_LLVM_UNWINDER=ON` make it possible to build without > `libgcc_s`? Or is this something else? It's supposed to but it doesn't add the necessary libraries when linking libc++.so.

[PATCH] D24981: [Coverage] The coverage region for a switch should cover the code after the switch

arphaman created this revision. arphaman added a reviewer: vsk. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes a regression introduced in r262697 that changed the way the coverage regions for switch are constructed. The PGO

Re: [PATCH] D24977: [CUDA] Declare our __device__ math functions in the same inline namespace as our standard library.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. That is way too much knowledge about details of standard library implementation. If it changes, I suspect users will end up with a rather uninformative error. Is there a way to produce somewhat more

[PATCH] D24984: [libunwind] Add support for a single-threaded libunwind build

rmaprath created this revision. rmaprath added reviewers: jroelofs, compnerd, logan. rmaprath added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. The EHABI unwinder is thread-agnostic, SJLJ unwinder and the DWARF unwinder have a couple of `pthread` dependencies. This patch

Re: [PATCH] D24979: [CUDA] Support and std::min/max on the device.

tra added a subscriber: echristo. tra added a comment. This looks like fix-includes and it may be somewhat shaky if users start messing with include paths. You may want to get @echristo's input on that. I' personally would prefer to force-include these files. I suspect it will not change

Re: [PATCH] D24946: [CUDA] Added support for CUDA-8

jlebar added inline comments. Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:139 @@ -137,1 +138,3 @@ +// CUDA 8.0.41 relies on __USE_FAST_MATH__ and __CUDA_PREC_DIV's values +// Previous versions used to check thether they are defined or not. Nit,

Re: [PATCH] D24977: [CUDA] Declare our __device__ math functions in the same inline namespace as our standard library.

jlebar added a comment. > That is way too much knowledge about details of standard library > implementation. Honestly I think this looks a lot scarier than it is. Or, to be specific, I think we are already relying on implementation details much more implicit and fragile than what is

Re: [PATCH] D24977: [CUDA] Declare our __device__ math functions in the same inline namespace as our standard library.

tra added a comment. OK. https://reviews.llvm.org/D24977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24981: [Coverage] The coverage region for a switch should cover the code after the switch

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM, thank you! It makes sense to inherit the current region's counter when we see a new switch. That should fix the 0 execution count we see on the condition. Repository: rL LLVM

  1   2   >