[PATCH] D25343: [OpenCL] Mark group functions as convergent in opencl-c.h

2016-10-12 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:612 + let Content = [{ +The ``convergent`` attribute can be placed on function declarations. It is +translated to LLVM ``convergent`` attribute, which indicates the call on a

Re: r284008 - Reinstate r283887 and r283882.

2016-10-12 Thread Manman via cfe-commits
Hi Vassil, Any change between this commit and “r283887 + r283882”? And what was the issue that caused the revert? Thanks, Manman > On Oct 12, 2016, at 4:57 AM, Vassil Vassilev via cfe-commits > wrote: > > Author: vvassilev > Date: Wed Oct 12 06:57:08 2016 > New

[PATCH] D25520: [CodeCompletion] Add block placeholders when completing member access for Objective-C block property setters

2016-10-12 Thread Argyrios Kyrtzidis via cfe-commits
akyrtzi added a comment. What if the user just wants to invoke the block, this is as common or more, like: `self.onEventHandler(10)` The assign literal completion is useful but it should be an additional entry (with maybe lower priority) not replace the property completion. BTW, it would be

r284029 - Document potential implementation of CFI in hardware.

2016-10-12 Thread Kostya Serebryany via cfe-commits
Author: kcc Date: Wed Oct 12 13:33:54 2016 New Revision: 284029 URL: http://llvm.org/viewvc/llvm-project?rev=284029=rev Log: Document potential implementation of CFI in hardware. Summary: Document potential implementation of CFI in hardware. Reviewers: eugenis, pcc Subscribers: llvm-commits

[PATCH] D25503: [analyzer] Remove superquadratic behaviour from DataflowWorklist

2016-10-12 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Do you have results that show how this effects performance on average code and machine generated code? One concern is that multiset is malloc intensive. See http://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task. Maybe

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-12 Thread Hal Finkel via cfe-commits
hfinkel added inline comments. Comment at: CMakeLists.txt:327 # Required flags == set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build dialect")

[PATCH] D25531: [libcxx] [test] Include in string_view::copy test

2016-10-12 Thread Billy Robert O'Neal III via cfe-commits
BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. BillyONeal added a subscriber: cfe-commits. The string_view::copy test calls std::min, which is not required to be made available by including . (The MSVC++ STL does not use std::min internally because we need to

[PATCH] D25531: [libcxx] [test] Include in string_view::copy test

2016-10-12 Thread Billy Robert O'Neal III via cfe-commits
BillyONeal added a comment. No, I don't believe any of us in MSVC++ land have commit access. https://reviews.llvm.org/D25531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25531: [libcxx] [test] Include in string_view::copy test

2016-10-12 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. @BillyONeal Do you have commit access? https://reviews.llvm.org/D25531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25406: Fix doubled whitespace in modernize-use-auto fixit

2016-10-12 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:378 + Lexer::getLocForEndOfToken(Range.getEnd(), 0, SM, Context->getLangOpts()); + bool Whitespace = isWhitespace(*FullSourceLoc(Next, SM).getCharacterData()); +

Re: r284008 - Reinstate r283887 and r283882.

2016-10-12 Thread Vassil Vassilev via cfe-commits
Hi Manman, On 12/10/16 20:28, Manman wrote: Hi Vassil, Any change between this commit and “r283887 + r283882”? The only extra change is in: + bool isThisDeclarationADemotedDefinition() const { +return isa(this) ? false : + NonParmVarDeclBits.IsThisDeclarationADemotedDefinition; + }

r284048 - Specify a target cpu in test case

2016-10-12 Thread Arnold Schwaighofer via cfe-commits
Author: arnolds Date: Wed Oct 12 15:30:24 2016 New Revision: 284048 URL: http://llvm.org/viewvc/llvm-project?rev=284048=rev Log: Specify a target cpu in test case Hopefully, this makes the bots happy Modified: cfe/trunk/test/CodeGen/windows-swiftcall.c Modified:

[PATCH] D25264: Implement MS _BitScan intrinsics

2016-10-12 Thread Albert Gutowski via cfe-commits
agutowski updated this revision to Diff 74435. agutowski added a comment. rebase https://reviews.llvm.org/D25264 Files: include/clang/Basic/BuiltinsARM.def include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def lib/Basic/Targets.cpp lib/CodeGen/CGBuiltin.cpp

[PATCH] D25503: [analyzer] Remove superquadratic behaviour from DataflowWorklist

2016-10-12 Thread Alexander Shaposhnikov via cfe-commits
alexshap updated the summary for this revision. alexshap updated this revision to Diff 74437. alexshap added a comment. Switch to priority queue. I have rerun the tests - they are all green. I will post the numbers about the perf a bit later. Repository: rL LLVM

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-12 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 74439. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D25491 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@

Re: r284008 - Reinstate r283887 and r283882.

2016-10-12 Thread Manman via cfe-commits
> On Oct 12, 2016, at 1:39 PM, Vassil Vassilev wrote: > > Hi Manman, > On 12/10/16 20:28, Manman wrote: >> Hi Vassil, >> >> Any change between this commit and “r283887 + r283882”? > The only extra change is in: > > + bool isThisDeclarationADemotedDefinition() const {

[PATCH] D25503: [analyzer] Remove superquadratic behaviour from DataflowWorklist

2016-10-12 Thread Alexander Shaposhnikov via cfe-commits
alexshap added inline comments. Comment at: lib/Analysis/LiveVariables.cpp:66 return nullptr; - const CFGBlock *b = worklist.pop_back_val(); + const auto I = --worklist.end(); + const CFGBlock *b = *I; alexshap wrote: > alexshap wrote: > > zaks.anna

[libcxx] r284047 - Disable trivial pair copy/move tests when unsupported

2016-10-12 Thread Dimitry Andric via cfe-commits
Author: dim Date: Wed Oct 12 15:26:47 2016 New Revision: 284047 URL: http://llvm.org/viewvc/llvm-project?rev=284047=rev Log: Disable trivial pair copy/move tests when unsupported Summary: On FreeBSD, for ABI compatibility reasons, the pair trivial copy constructor is disabled, using the

r284055 - Remove basic block label in test case

2016-10-12 Thread Arnold Schwaighofer via cfe-commits
Author: arnolds Date: Wed Oct 12 16:36:15 2016 New Revision: 284055 URL: http://llvm.org/viewvc/llvm-project?rev=284055=rev Log: Remove basic block label in test case Another attempt to make a bot happy Modified: cfe/trunk/test/CodeGen/windows-swiftcall.c Modified:

[PATCH] D25264: Implement MS _BitScan intrinsics

2016-10-12 Thread David Majnemer via cfe-commits
majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. This looks right to me. https://reviews.llvm.org/D25264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25139: [CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIfDeviceCode().

2016-10-12 Thread Justin Lebar via cfe-commits
jlebar added a comment. If you're busy with other stuff, that's cool, this is not urgent, but pinging in case this got lost. https://reviews.llvm.org/D25139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r283983 - Protect special members of NullBase archetype to avoid exposing them

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 03:09:22 2016 New Revision: 283983 URL: http://llvm.org/viewvc/llvm-project?rev=283983=rev Log: Protect special members of NullBase archetype to avoid exposing them Modified: libcxx/trunk/test/support/archetypes.hpp Modified:

[PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-10-12 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. In https://reviews.llvm.org/D21803#567774, @tavianator wrote: > In https://reviews.llvm.org/D21803#556857, @EricWF wrote: > > > @rmaprath I'll merge this if needed. Feel free to commit your patch first. > > > Yeah, @rmaprath I'm happy to rebase this over your patch.

[libcxx] r284005 - Remove incorrect XFAILS

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 06:29:18 2016 New Revision: 284005 URL: http://llvm.org/viewvc/llvm-project?rev=284005=rev Log: Remove incorrect XFAILS Modified: libcxx/trunk/test/libcxx/utilities/optional/optional.object/optional.object.assign/copy.pass.cpp

r284007 - [CodeCompletion] Show protocol properties that are accessed through qualified id

2016-10-12 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed Oct 12 06:40:15 2016 New Revision: 284007 URL: http://llvm.org/viewvc/llvm-project?rev=284007=rev Log: [CodeCompletion] Show protocol properties that are accessed through qualified id This commit improves code completion for properties that are declared in Objective-C

[PATCH] D25492: [libcxx] [test] Fix shadowing in string.assign and string.append

2016-10-12 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24656: [clang-tidy] Add check readability-redundant-declaration

2016-10-12 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki added inline comments. Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:60 +auto Diag = diag(D->getLocation(), "redundant '%0' declaration") +<< cast(D)->getName(); +if (!MultiVar && !DifferentHeaders) alexfh

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

2016-10-12 Thread Vassil Vassilev via cfe-commits
v.g.vassilev updated this revision to Diff 74353. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. We should not access the IsThisDeclarationADemotedDefinition bits if the decl is ParmVarDecl. https://reviews.llvm.org/D24508 Files: include/clang/AST/Decl.h

[PATCH] D25479: Guard flag –fdenormal-fp-math with –fno-fast-math

2016-10-12 Thread Renato Golin via cfe-commits
rengolin added inline comments. Comment at: test/Driver/denormal-fp-math.c:4 // RUN: %clang -### -target arm-unknown-linux-gnu -c %s -fdenormal-fp-math=positive-zero -v 2>&1 | FileCheck -check-prefix=CHECK-PZ %s +// RUN: %clang -### -target arm-unknown-linux-gnu -c %s

[libcxx] r283999 - Remove usages of _ALIGNAS_TYPE

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 05:19:48 2016 New Revision: 283999 URL: http://llvm.org/viewvc/llvm-project?rev=283999=rev Log: Remove usages of _ALIGNAS_TYPE Modified: libcxx/trunk/test/std/atomics/atomics.flag/default.pass.cpp

Re: [libcxx] r284005 - Remove incorrect XFAILS

2016-10-12 Thread Asiri Rathnayake via cfe-commits
More love for no-exceptions in any case ;) Cheers! On Wed, Oct 12, 2016 at 12:52 PM, Eric Fiselier wrote: > I just committed those tests, so I kinda had to fix them :-P > > On Wed, Oct 12, 2016 at 5:40 AM, Asiri Rathnayake < > asiri.rathnay...@gmail.com> wrote: > >> Thanks! >> >>

[clang-tools-extra] r283981 - [ClangTidy] Add UsingInserter and NamespaceAliaser

2016-10-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 12 02:59:54 2016 New Revision: 283981 URL: http://llvm.org/viewvc/llvm-project?rev=283981=rev Log: [ClangTidy] Add UsingInserter and NamespaceAliaser Summary: This adds helper classes to add using declaractions and namespace aliases to function bodies. These help

[clang-tools-extra] r283986 - [clang-tidy-vs] Fix ClangTidy extension name in the manifest.

2016-10-12 Thread Marek Kurdej via cfe-commits
Author: mkurdej Date: Wed Oct 12 03:32:59 2016 New Revision: 283986 URL: http://llvm.org/viewvc/llvm-project?rev=283986=rev Log: [clang-tidy-vs] Fix ClangTidy extension name in the manifest. Modified: clang-tools-extra/trunk/clang-tidy-vs/source.extension.vsixmanifest.in Modified:

Re: [clang-tools-extra] r283981 - [ClangTidy] Add UsingInserter and NamespaceAliaser

2016-10-12 Thread Renato Golin via cfe-commits
On 12 October 2016 at 08:59, Haojian Wu via cfe-commits wrote: > Author: hokein > Date: Wed Oct 12 02:59:54 2016 > New Revision: 283981 > > URL: http://llvm.org/viewvc/llvm-project?rev=283981=rev > Log: > [ClangTidy] Add UsingInserter and NamespaceAliaser Hi Haojian,

Re: [libcxx] r284005 - Remove incorrect XFAILS

2016-10-12 Thread Asiri Rathnayake via cfe-commits
Thanks! I still have that no-exception cleanup in my TODO list. Just pressed on time, hope to get to it soon. / Asiri On Wed, Oct 12, 2016 at 12:29 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Wed Oct 12 06:29:18 2016 > New Revision: 284005 >

Re: [libcxx] r284005 - Remove incorrect XFAILS

2016-10-12 Thread Eric Fiselier via cfe-commits
I just committed those tests, so I kinda had to fix them :-P On Wed, Oct 12, 2016 at 5:40 AM, Asiri Rathnayake < asiri.rathnay...@gmail.com> wrote: > Thanks! > > I still have that no-exception cleanup in my TODO list. Just pressed on > time, hope to get to it soon. > > / Asiri > > On Wed, Oct

[libcxx] r283996 - Fix more C++11 constexpr issues in the tests

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 04:48:44 2016 New Revision: 283996 URL: http://llvm.org/viewvc/llvm-project?rev=283996=rev Log: Fix more C++11 constexpr issues in the tests Modified: libcxx/trunk/test/support/archetypes.hpp Modified: libcxx/trunk/test/support/archetypes.hpp URL:

[PATCH] D25308: [Sema] Ignore transparent_union attributes in C++

2016-10-12 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283995: [Sema] Handle transparent_union attributes in C mode only (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25308?vs=74127=74350#toc Repository: rL LLVM

[libcxx] r284004 - Unbreak C++03 build

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 06:20:27 2016 New Revision: 284004 URL: http://llvm.org/viewvc/llvm-project?rev=284004=rev Log: Unbreak C++03 build Modified: libcxx/trunk/test/support/test_macros.h Modified: libcxx/trunk/test/support/test_macros.h URL:

[libcxx] r284006 - Correctly grant rebound limited_allocators friendship.

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 06:35:37 2016 New Revision: 284006 URL: http://llvm.org/viewvc/llvm-project?rev=284006=rev Log: Correctly grant rebound limited_allocators friendship. Modified: libcxx/trunk/test/support/test_allocator.h Modified: libcxx/trunk/test/support/test_allocator.h

[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

2016-10-12 Thread Haojian Wu via cfe-commits
hokein added a comment. @jbangert, your patch broke the buildbot, and I reverted it in r283985. You need to add the new source files to the CMakefile. (I saw other compilation errors after I updated the cmake files, Could you take a look on it? ) Repository: rL LLVM

[PATCH] D25397: [change-namespace] don't miss comments in the beginning of a namespace block.

2016-10-12 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: change-namespace/ChangeNamespace.cpp:387 + Token Tok; + while (!Lex->LexFromRawLexer(Tok) && Tok.isNot(tok::TokenKind::l_brace)) { + }

[libcxxabi] r283988 - Provide a fallback __cxa_thread_atexit() implementation. Patch from Tavian Barnes

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 03:54:10 2016 New Revision: 283988 URL: http://llvm.org/viewvc/llvm-project?rev=283988=rev Log: Provide a fallback __cxa_thread_atexit() implementation. Patch from Tavian Barnes Added: libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp Modified:

[PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-10-12 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. Committed as r283988. Thanks for the patch! https://reviews.llvm.org/D21803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r284002 - Remove usages of _LIBCPP_CONSTEXPR under test/std

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 05:28:09 2016 New Revision: 284002 URL: http://llvm.org/viewvc/llvm-project?rev=284002=rev Log: Remove usages of _LIBCPP_CONSTEXPR under test/std Modified: libcxx/trunk/test/std/numerics/rand/rand.adapt/rand.adapt.ibits/eval.pass.cpp

[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

2016-10-12 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283981: [ClangTidy] Add UsingInserter and NamespaceAliaser (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D24997?vs=74311=74338#toc Repository: rL LLVM

r283995 - [Sema] Handle transparent_union attributes in C mode only

2016-10-12 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed Oct 12 04:36:35 2016 New Revision: 283995 URL: http://llvm.org/viewvc/llvm-project?rev=283995=rev Log: [Sema] Handle transparent_union attributes in C mode only This commit marks the transparent_union attributes as C only because clang doesn't support them in C++ mode.

[clang-tools-extra] r283985 - Revert "[ClangTidy] Add UsingInserter and NamespaceAliaser"

2016-10-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 12 03:19:44 2016 New Revision: 283985 URL: http://llvm.org/viewvc/llvm-project?rev=283985=rev Log: Revert "[ClangTidy] Add UsingInserter and NamespaceAliaser" This reverts commit r283981. This patch breaks the buildbot. Removed:

[libcxx] r283991 - Remove use of _VSTD::__invoke in the not_fn tests

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 04:06:12 2016 New Revision: 283991 URL: http://llvm.org/viewvc/llvm-project?rev=283991=rev Log: Remove use of _VSTD::__invoke in the not_fn tests Modified: libcxx/trunk/test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp Modified:

[libcxx] r283993 - Fix use of C++14 constexpr in C++11

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 04:20:58 2016 New Revision: 283993 URL: http://llvm.org/viewvc/llvm-project?rev=283993=rev Log: Fix use of C++14 constexpr in C++11 Modified: libcxx/trunk/test/support/archetypes.ipp Modified: libcxx/trunk/test/support/archetypes.ipp URL:

[libcxx] r283994 - Fix nasty_containers.hpp for other stdlibs

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 04:31:26 2016 New Revision: 283994 URL: http://llvm.org/viewvc/llvm-project?rev=283994=rev Log: Fix nasty_containers.hpp for other stdlibs Modified: libcxx/trunk/test/support/nasty_containers.hpp libcxx/trunk/test/support/test_macros.h Modified:

[PATCH] D25508: [clang-move] Don't comparing absolute file path to relative path.

2016-10-12 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a reviewer: ioeric. hokein added subscribers: bkramer, cfe-commits. Herald added subscribers: mgorny, beanz. This patch is kind of reverting r283202 (but keep the updated lint test), because it leads to a few annoying problems by comparing absolute file

[libcxx] r283997 - support --param=std=gnu++XX

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 04:53:35 2016 New Revision: 283997 URL: http://llvm.org/viewvc/llvm-project?rev=283997=rev Log: support --param=std=gnu++XX Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py URL:

[PATCH] D25508: [clang-move] Don't comparing absolute file path to relative path.

2016-10-12 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 74375. hokein added a comment. Update the patch based on offline discussion. https://reviews.llvm.org/D25508 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/database_template.json test/clang-move/move-class.cpp Index:

r284008 - Reinstate r283887 and r283882.

2016-10-12 Thread Vassil Vassilev via cfe-commits
Author: vvassilev Date: Wed Oct 12 06:57:08 2016 New Revision: 284008 URL: http://llvm.org/viewvc/llvm-project?rev=284008=rev Log: Reinstate r283887 and r283882. Original message: "[modules] PR28752: Do not instantiate variable declarations which are not visible.

[PATCH] D23657: Remove some false positives when taking the address of packed members

2016-10-12 Thread Joerg Sonnenberger via cfe-commits
joerg added inline comments. Comment at: lib/Sema/SemaChecking.cpp:11370 +// we are here such increase has not been enough. So pointing the first +// FieldDecl that either is packed orelse its RecordDecl is, +// seems reasonable. Missing space.

[clang-tools-extra] r284011 - [change-namespace] don't miss comments in the beginning of a namespace block.

2016-10-12 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Oct 12 07:34:18 2016 New Revision: 284011 URL: http://llvm.org/viewvc/llvm-project?rev=284011=rev Log: [change-namespace] don't miss comments in the beginning of a namespace block. Reviewers: hokein Subscribers: cfe-commits Differential Revision:

[PATCH] D25153: preprocessor supports `-dI` flag

2016-10-12 Thread Steve O'Brien via cfe-commits
elsteveogrande added a comment. Ping again -- addressed all issues, looking ok now? Note about this change + review process here. First I know the every 1-2 day pinging generates noise on the lists, and for that I'm SorryNotSorry :-p I just want to ensure this is reaching at least the right

[PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

2016-10-12 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/CodeGen/CGStmtOpenMP.cpp:312 + assert(ArgLVal.getType()->isPointerType()); + ArgAddr = this->EmitLoadOfPointer( +

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

2016-10-12 Thread Teresa Johnson via cfe-commits
tejohnson added a comment. Ping. It seems like using attributes is not feasible at this time due to the lack of data attributes. https://reviews.llvm.org/D24644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25508: [clang-move] Compare with real paths of symlinks

2016-10-12 Thread Eric Liu via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg with one nit. Comment at: clang-move/ClangMove.cpp:410 std::string AbsolutePath = MakeAbsolutePath(SM, FileName); if (MakeAbsolutePath(OriginalRunningDirectory,

[PATCH] D25508: [clang-move] Compare with real paths of symlinks

2016-10-12 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 74382. hokein added a comment. Update. https://reviews.llvm.org/D25508 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/database_template.json test/clang-move/move-class.cpp Index: test/clang-move/move-class.cpp

r284019 - NFC: CodeCompletionResult's constructor should take const NamedDecl

2016-10-12 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Wed Oct 12 10:33:35 2016 New Revision: 284019 URL: http://llvm.org/viewvc/llvm-project?rev=284019=rev Log: NFC: CodeCompletionResult's constructor should take const NamedDecl CodeCompletionResult's Declaration field is a const pointer to the NamedDecl, and thus the

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-10-12 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Ping https://reviews.llvm.org/D22955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25436: [CodeCompletion] Improve completion for properties declared in Objective-C protocols

2016-10-12 Thread Alex Lorenz via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284007: [CodeCompletion] Show protocol properties that are accessed through qualified id (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25436?vs=74227=74364#toc Repository:

r284009 - [ARM] Fix - missing target-cpu in test

2016-10-12 Thread Javed Absar via cfe-commits
Author: javed.absar Date: Wed Oct 12 07:13:55 2016 New Revision: 284009 URL: http://llvm.org/viewvc/llvm-project?rev=284009=rev Log: [ARM] Fix - missing target-cpu in test Fixes an incomplete test, wherein the target-cpu name (cortex-r52) was missing. Differential Revision:

[PATCH] D25474: [ARM] Fix - missing target-cpu in test

2016-10-12 Thread Javed Absar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284009: [ARM] Fix - missing target-cpu in test (authored by javed.absar). Changed prior to commit: https://reviews.llvm.org/D25474?vs=74247=74365#toc Repository: rL LLVM

[PATCH] D25397: [change-namespace] don't miss comments in the beginning of a namespace block.

2016-10-12 Thread Eric Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284011: [change-namespace] don't miss comments in the beginning of a namespace block. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D25397?vs=74038=74368#toc Repository: rL

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

2016-10-12 Thread Artem Dergachev via cfe-commits
NoQ added a comment. Yay, thanks for posting this! :) I've got a bit of concern for some assert-suppressions. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:2314 { + // Return to fulfil assert condition + if (location.getAs()) Hmm. Why would anybody

[PATCH] D25145: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

2016-10-12 Thread Shoaib Meenai via cfe-commits
smeenai closed this revision. smeenai added a comment. Not sure why Phabricator isn't closing this out, but this was committed as SVN r284016 https://reviews.llvm.org/D25145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r284016 - [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

2016-10-12 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Wed Oct 12 08:48:14 2016 New Revision: 284016 URL: http://llvm.org/viewvc/llvm-project?rev=284016=rev Log: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS The behavior of this macro actually needs to apply universally on Windows and not just when using the Microsoft

[PATCH] D25479: Guard flag –fdenormal-fp-math with –fno-fast-math

2016-10-12 Thread Sjoerd Meijer via cfe-commits
SjoerdMeijer updated this revision to Diff 74363. SjoerdMeijer added a comment. Thanks for catching this: the logic and test have been updated. https://reviews.llvm.org/D25479 Files: lib/Driver/Tools.cpp test/Driver/denormal-fp-math.c Index: test/Driver/denormal-fp-math.c

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

2016-10-12 Thread Vassil Vassilev via cfe-commits
v.g.vassilev closed this revision. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Relanded in r284008. https://reviews.llvm.org/D24508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24656: [clang-tidy] Add check readability-redundant-declaration

2016-10-12 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:60 +auto Diag = diag(D->getLocation(), "redundant '%0' declaration") +<< cast(D)->getName(); +if (!MultiVar && !DifferentHeaders)

[PATCH] D25145: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

2016-10-12 Thread Shoaib Meenai via cfe-commits
smeenai added a comment. In https://reviews.llvm.org/D25145#565027, @mclow.lists wrote: > Sigh. Make an expedient choice that you don't really agree with, and you get > immediately reminded of it. I suggested on an earlier review (not this > patch) that I really didn't want to see `_WIN32`

[PATCH] D25503: [analyzer] Remove superquadratic behaviour from DataflowWorklist

2016-10-12 Thread Alexander Shaposhnikov via cfe-commits
alexshap added inline comments. Comment at: lib/Analysis/LiveVariables.cpp:66 return nullptr; - const CFGBlock *b = worklist.pop_back_val(); + const auto I = --worklist.end(); + const CFGBlock *b = *I; zaks.anna wrote: > '--wroklist.end()' ->

[PATCH] D25406: Fix doubled whitespace in modernize-use-auto fixit

2016-10-12 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:378 + Lexer::getLocForEndOfToken(Range.getEnd(), 0, SM, Context->getLangOpts()); + bool Whitespace = isWhitespace(*FullSourceLoc(Next, SM).getCharacterData()); +

[PATCH] D25503: [analyzer] Remove superquadratic behaviour from DataflowWorklist

2016-10-12 Thread Alexander Shaposhnikov via cfe-commits
alexshap added inline comments. Comment at: lib/Analysis/LiveVariables.cpp:66 return nullptr; - const CFGBlock *b = worklist.pop_back_val(); + const auto I = --worklist.end(); + const CFGBlock *b = *I; alexshap wrote: > zaks.anna wrote: > >

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

2016-10-12 Thread Mehdi AMINI via cfe-commits
mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r283978 - Revert Add . Will recommit with better commit message

2016-10-12 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 12 01:48:31 2016 New Revision: 283978 URL: http://llvm.org/viewvc/llvm-project?rev=283978=rev Log: Revert Add . Will recommit with better commit message Removed: libcxx/trunk/include/optional libcxx/trunk/test/libcxx/utilities/optional/

[PATCH] D25503: [analyzer] Remove superquadratic behaviour from DataflowWorklist

2016-10-12 Thread Alexander Shaposhnikov via cfe-commits
alexshap created this revision. alexshap added reviewers: NoQ, zaks.anna. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. The class DataflowWorklist internally maintains a sorted list of pointers to CFGBlock and the method enqueuePredecessors

[clang-tools-extra] r284020 - [clang-move] Compare with real paths of symlinks

2016-10-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 12 10:50:30 2016 New Revision: 284020 URL: http://llvm.org/viewvc/llvm-project?rev=284020=rev Log: [clang-move] Compare with real paths of symlinks Summary: MakeAbsolutePath does wrong things with symlinks previously. When comparing with a symlink, we need to

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

2016-10-12 Thread Shoaib Meenai via cfe-commits
smeenai added a comment. In https://reviews.llvm.org/D25208#564930, @EricWF wrote: > Why do you want to build `libc++.so` with hidden visibility? What's wrong > with the existing way we build `libc++.so`? There's nothing wrong with the existing way, per se. I personally prefer hidden

[PATCH] D25519: [CodeCompletion] Refactor: Extract two Objective-C block formatting related functions from FormatFunctionParameter

2016-10-12 Thread Alex Lorenz via cfe-commits
arphaman created this revision. arphaman added a reviewer: manmanren. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch extracts two new functions from the function `FormatFunctionParameter` that are related to Objective-C block

[PATCH] D25522: Remove warnings from google-benchmarks in libcxx

2016-10-12 Thread Aditya Kumar via cfe-commits
hiraditya created this revision. hiraditya added reviewers: EricWF, mclow.lists. hiraditya added subscribers: sebpop, cfe-commits. https://reviews.llvm.org/D25522 Files: libcxx/benchmarks/ContainerBenchmarks.hpp libcxx/benchmarks/GenerateInput.hpp Index: libcxx/benchmarks/GenerateInput.hpp

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

2016-10-12 Thread Paweł Żukowski via cfe-commits
idlecode updated this revision to Diff 74412. https://reviews.llvm.org/D25439 Files: lib/Format/FormatTokenLexer.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp === ---

[PATCH] D25503: [analyzer] Remove superquadratic behaviour from DataflowWorklist

2016-10-12 Thread Artem Dergachev via cfe-commits
NoQ added a reviewer: a.sidorin. NoQ added a comment. This looks familiar, i think i've seen significant slowdowns around there on some very rare files. Nice catch! Probably a binary-search insert could have also been much better than re-sorting, even if it's still a vector. Repository: rL

r284032 - Declare WinX86_64ABIInfo to satisfy SwiftABI info

2016-10-12 Thread Arnold Schwaighofer via cfe-commits
Author: arnolds Date: Wed Oct 12 13:59:24 2016 New Revision: 284032 URL: http://llvm.org/viewvc/llvm-project?rev=284032=rev Log: Declare WinX86_64ABIInfo to satisfy SwiftABI info This is minimal support that allows swift's test cases on non windows platforms to pass. rdar://28738985 Added:

r284060 - Implement MS _BitScan intrinsics

2016-10-12 Thread Albert Gutowski via cfe-commits
Author: agutowski Date: Wed Oct 12 17:01:05 2016 New Revision: 284060 URL: http://llvm.org/viewvc/llvm-project?rev=284060=rev Log: Implement MS _BitScan intrinsics Summary: _BitScan intrinsics (and some others, for example _Interlocked and _bittest) are supposed to work on both ARM and x86.

r284062 - fix regexes for label names in ms-intrinsics test

2016-10-12 Thread Albert Gutowski via cfe-commits
Author: agutowski Date: Wed Oct 12 17:22:34 2016 New Revision: 284062 URL: http://llvm.org/viewvc/llvm-project?rev=284062=rev Log: fix regexes for label names in ms-intrinsics test Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c URL:

[PATCH] D25001: [Module] Merge function prototype with a non-prototype function declaration

2016-10-12 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. It looks like this patch doesn't do what I thought would do when the unprototyped function declaration is in the header and the prototyped function declaration is in the source code. The DeclRefExpr created for the call to func1("abc", 12) points to the unprototyped

r284084 - [analyzer] DeallocChecker: Don't warn about directly-set IBOutlet ivars on macOS

2016-10-12 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Wed Oct 12 18:57:05 2016 New Revision: 284084 URL: http://llvm.org/viewvc/llvm-project?rev=284084=rev Log: [analyzer] DeallocChecker: Don't warn about directly-set IBOutlet ivars on macOS On macOS (but not iOS), if an ObjC property has no setter, the nib-loading code for

[PATCH] D25503: [analyzer] Remove superquadratic behaviour from DataflowWorklist

2016-10-12 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. I've just run scan-build against LLVM & clang & clang-extra-tools - the new version (with PriorityQueue) is a bit faster - i was running the build on OSX & -j8 and the total time for the new version is 88 minutes vs 92 minutes for the old one. Certainly i think that

[PATCH] D25537: [ThinLTO] Update doc to include lld

2016-10-12 Thread Teresa Johnson via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D25537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r284080 - [NFC] Fixing the description for _mm_store_ps and _mm_store_ps1.

2016-10-12 Thread Yunzhong Gao via cfe-commits
Author: ygao Date: Wed Oct 12 18:27:27 2016 New Revision: 284080 URL: http://llvm.org/viewvc/llvm-project?rev=284080=rev Log: [NFC] Fixing the description for _mm_store_ps and _mm_store_ps1. It seems that the doxygen description of these two intrinsics were swapped by mistake. Modified:

r284083 - fix ms-intrinsics labels code to work with builds with assertions

2016-10-12 Thread Albert Gutowski via cfe-commits
Author: agutowski Date: Wed Oct 12 18:52:38 2016 New Revision: 284083 URL: http://llvm.org/viewvc/llvm-project?rev=284083=rev Log: fix ms-intrinsics labels code to work with builds with assertions Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c Modified:

[PATCH] D25534: Implement part of P0031; adding `constexpr` to `reverse_iterator`

2016-10-12 Thread Marshall Clow via cfe-commits
mclow.lists created this revision. mclow.lists added reviewers: EricWF, lefticus, AntonBikineev. mclow.lists added a subscriber: cfe-commits. This just does the `reverse_iterator` bits of http://wg21.link/P0031 - not any of the other parts. This duplicates some (but not all) of the work that was

[PATCH] D25537: [ThinLTO] Update doc to include lld

2016-10-12 Thread Mehdi AMINI via cfe-commits
mehdi_amini requested changes to this revision. mehdi_amini added a comment. This revision now requires changes to proceed. You have to add which platforms are supported. https://reviews.llvm.org/D25537 ___ cfe-commits mailing list

[PATCH] D24958: Test linked to D24957

2016-10-12 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D24958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25537: [ThinLTO] Update doc to include lld

2016-10-12 Thread Davide Italiano via cfe-commits
davide updated this revision to Diff 74459. davide added a comment. I mentioned that's ELF only. Are you OK with that or you want me to put more detailed info? https://reviews.llvm.org/D25537 Files: docs/ThinLTO.rst Index: docs/ThinLTO.rst

  1   2   >