yaxunl updated this revision to Diff 74514.
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Revised by Aaron's comments. Added a sema test.
https://reviews.llvm.org/D25343
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CGCall.cpp
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-one-name-per-declaration.cpp:8
+ {
+int x = 42, y = 43;
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: Do not declare multiple names
per declaration
ioeric updated this revision to Diff 74531.
ioeric added a comment.
- Updated comments for RefactoringTool.
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
rmaprath updated this revision to Diff 74519.
rmaprath added a comment.
Herald added a subscriber: modocache.
Patch re-based on the latest trunk.
I've resolved my downstream issues, will be committing soon.
/ Asiri
https://reviews.llvm.org/D24864
Files:
CMakeLists.txt
src/config.h
arphaman updated this revision to Diff 74528.
arphaman added a comment.
The updated patch now treats the block property setter completion as a
completion result that's additional to the default property completion result.
Repository:
rL LLVM
https://reviews.llvm.org/D25520
Files:
arphaman added a comment.
In https://reviews.llvm.org/D25520#568448, @akyrtzi wrote:
> What if the user just wants to invoke the block, this is as common or more,
> like:
>
> `self.onEventHandler(10)`
>
> The assign literal completion is useful but it should be an additional entry
> (with
Author: asiri
Date: Thu Oct 13 10:05:19 2016
New Revision: 284128
URL: http://llvm.org/viewvc/llvm-project?rev=284128=rev
Log:
[libcxxabi] Refactor pthread usage into a separate API
This patch refactors all pthread uses of libc++abi into a separate API. This
is the first step towards supporting
Hi Jeremy,
Thanks for the patch, committed as r284125.
Cheers,
/ Asiri
From: jerem...@apple.com on behalf of Jeremy Huddleston
Sequoia
Sent: 13 October 2016 06:57
To: Asiri Rathnayake
Subject: libunwind build
And... apologies for that disclaimer notice.
Cheers,
/ Asiri
From: cfe-commits on behalf of Asiri
Rathnayake via cfe-commits
Sent: 13 October 2016 15:42
To: Jeremy Huddleston Sequoia
Cc:
arphaman added a comment.
Right now I gave the setter completion a flat priority bump of 3. Should
something different be used? What do you think of the following possible
priority heuristic: when completing blocks properties that return `void` the
default property completion result should
agutowski updated this revision to Diff 74533.
agutowski added a comment.
change checking prefix for x86 tests; use Int32 instead of UnsignedIntTy
https://reviews.llvm.org/D25540
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/BuiltinsX86.def
lib/CodeGen/CGBuiltin.cpp
Author: asiri
Date: Thu Oct 13 09:32:24 2016
New Revision: 284125
URL: http://llvm.org/viewvc/llvm-project?rev=284125=rev
Log:
[libunwind] Add missing include. NFC.
This missing include seems to cause compilation failures on older MacOS
versions (< 10.9). This is because r270692 has introduced
arphaman updated this revision to Diff 74520.
arphaman marked 2 inline comments as done.
arphaman added a comment.
The updated patch has comments for the two extracted functions.
Repository:
rL LLVM
https://reviews.llvm.org/D25519
Files:
lib/Sema/SemaCodeComplete.cpp
Index:
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added subscribers: cfe-commits, bkramer, hokein.
Herald added a subscriber: klimek.
If there are multiple pairs with the same file
path after removing dots, we only keep one pair (with path after dots
v.g.vassilev added a comment.
The print related changes were added in in r280240
(https://reviews.llvm.org/D23319). Could you rebase the patch?
Repository:
rL LLVM
https://reviews.llvm.org/D20785
___
cfe-commits mailing list
rjmccall requested changes to this revision.
rjmccall added inline comments.
This revision now requires changes to proceed.
Comment at: lib/CodeGen/CodeGenFunction.h:379
+ /// Set of object pointers which are blacklisted from the UB sanitizer.
+ llvm::SmallPtrSet
mgorny updated this revision to Diff 74538.
mgorny added a comment.
Fixed indentation.
https://reviews.llvm.org/D25568
Files:
cmake/Modules/HandleLibcxxFlags.cmake
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
===
---
Author: arnolds
Date: Thu Oct 13 12:17:36 2016
New Revision: 284133
URL: http://llvm.org/viewvc/llvm-project?rev=284133=rev
Log:
Add more 64bit swiftcall convention tests
Added:
cfe/trunk/test/CodeGen/64bit-swiftcall.c
Added: cfe/trunk/test/CodeGen/64bit-swiftcall.c
URL:
erik.pilkington updated this revision to Diff 74547.
erik.pilkington added a comment.
This new patch fixes the style issues @aaron.ballman and @manmanren brought up.
Thanks,
Erik
https://reviews.llvm.org/D25283
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaDecl.cpp
Author: agutowski
Date: Thu Oct 13 11:03:42 2016
New Revision: 284131
URL: http://llvm.org/viewvc/llvm-project?rev=284131=rev
Log:
Implement MS _ReturnAddress and _AddressOfReturnAddress intrinsics
Reviewers: rnk, thakis, majnemer, hans
Subscribers: cfe-commits
Differential Revision:
ioeric added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:233
- Replacements mergeReplacements(const ReplacementsImpl ) const;
-
This is dead code.
https://reviews.llvm.org/D25565
___
mgorny created this revision.
mgorny added a reviewer: EricWF.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: modocache, beanz.
Use the -print-libgcc-file-name compiler option to obtain the path to
libgcc or an equivalent compiler runtime library, rather than hardcoding
yaxunl updated this revision to Diff 74541.
yaxunl added a comment.
Minor revision by Aaron's comments.
https://reviews.llvm.org/D25343
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CGCall.cpp
lib/Headers/opencl-c.h
lib/Sema/SemaDeclAttr.cpp
rnk added a comment.
Nice! Looks like this wasn't too bad.
Comment at: clang/lib/Sema/SemaCUDA.cpp:546
+ // Externally-visible and similar functions are always emitted.
+ if (S.getASTContext().GetGVALinkageForFunction(FD) > GVA_DiscardableODR)
+return true;
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some minor nits, the attribute functionality looks fine to me. As to
whether we think this is a worthy attribute to add or not, I leave that to
people who know CUDA
akyrtzi added a comment.
> What do you think of the following possible priority heuristic
SGTM.
Changes LGTM. I'd also recommend that as a follow-up patch it would be great to
extend the setter completion to variables as well (global variables, fields,
ivars, etc.)
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284140: Pass -ffunction-sections/-fdata-sections along to
gold-plugin (authored by tejohnson).
Changed prior to commit:
https://reviews.llvm.org/D24644?vs=71591=74555#toc
Repository:
rL LLVM
aaron.ballman added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-one-name-per-declaration.cpp:8
+ {
+int x = 42, y = 43;
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: Do not declare multiple names
per declaration
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 74536.
https://reviews.llvm.org/D25568
Files:
cmake/Modules/HandleLibcxxFlags.cmake
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
===
---
Thanks.
> On Oct 13, 2016, at 07:42, Asiri Rathnayake wrote:
>
> Hi Jeremy,
>
> Thanks for the patch, committed as r284125.
>
> Cheers,
>
> / Asiri
>
>
> From: jerem...@apple.com on behalf of Jeremy
vsk updated the summary for this revision.
vsk updated this revision to Diff 74552.
vsk added a comment.
Per @arphaman's comments:
- Add a CodeGenPGO test which checks whether counters can be created for
statements inside of switch initializers.
- Group calls to 'Visit' together.
erik.pilkington added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:179
- if (const DeclContext *DC = S.getCurObjCLexicalContext())
-ContextVersion = S.getVersionForDecl(cast(DC));
-
manmanren wrote:
> I don't quite get why we can remove the above
Author: davide
Date: Thu Oct 13 12:42:38 2016
New Revision: 284137
URL: http://llvm.org/viewvc/llvm-project?rev=284137=rev
Log:
[ThinLTO] Update doc to include lld (now supported).
Differential Revision: https://reviews.llvm.org/D25537
Modified:
cfe/trunk/docs/ThinLTO.rst
Modified:
Author: tejohnson
Date: Thu Oct 13 13:05:53 2016
New Revision: 284140
URL: http://llvm.org/viewvc/llvm-project?rev=284140=rev
Log:
Pass -ffunction-sections/-fdata-sections along to gold-plugin
Summary:
These options need to be passed to the plugin in order to have
an effect on LTO/ThinLTO
v.g.vassilev added a comment.
This patch needs rebasing.
https://reviews.llvm.org/D7842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
The correct fix is to honor isInit by folding the logic for EmitScalarInit into
this function. That should allow you to eliminate EmitScalarInit completely,
although it would be fine to leave it as just a call to EmitStoreThroughLValue.
I did a quick audit of all
Author: ioeric
Date: Thu Oct 13 14:49:19 2016
New Revision: 284155
URL: http://llvm.org/viewvc/llvm-project?rev=284155=rev
Log:
[clang-move] error out when fail to create new files.
Modified:
clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp
Modified:
Author: arnolds
Date: Thu Oct 13 14:19:37 2016
New Revision: 284150
URL: http://llvm.org/viewvc/llvm-project?rev=284150=rev
Log:
Swift Calling Convention: Fix out of bounds access
Use iterator instead of address of element in vector
It is not valid to access one after the last element.
sebpop added a comment.
In https://reviews.llvm.org/D24991#565861, @EricWF wrote:
> In https://reviews.llvm.org/D24991#565715, @mclow.lists wrote:
>
> > How does this play with existing binaries? Applications that expect these
> > functions to exist in the dylib?
>
>
> This patch is majorly
Author: jlebar
Date: Thu Oct 13 13:45:08 2016
New Revision: 284143
URL: http://llvm.org/viewvc/llvm-project?rev=284143=rev
Log:
[CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIf{Device,Host}Code().
Summary:
Together these let you easily create diagnostics that
- are never emitted for host
Should be fixed in r284141.
/ Asiri
On Thu, Oct 13, 2016 at 7:20 PM, Asiri Rathnayake <
asiri.rathnay...@gmail.com> wrote:
> Looks like this broke the gcc builder: http://lab.llvm.org:
> 8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-
>
Author: jlebar
Date: Thu Oct 13 13:45:13 2016
New Revision: 284144
URL: http://llvm.org/viewvc/llvm-project?rev=284144=rev
Log:
[CUDA] Disallow __shared__ variables in host functions.
Reviewers: tra, rnk
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25143
Modified:
Author: jlebar
Date: Thu Oct 13 13:45:17 2016
New Revision: 284145
URL: http://llvm.org/viewvc/llvm-project?rev=284145=rev
Log:
[CUDA] Allow static variables in __host__ __device__ functions, so long as
they're never codegen'ed for device.
Reviewers: tra, rnk
Subscribers: cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284144: [CUDA] Disallow __shared__ variables in host
functions. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25143?vs=73172=74565#toc
Repository:
rL LLVM
Author: compnerd
Date: Thu Oct 13 14:45:08 2016
New Revision: 284154
URL: http://llvm.org/viewvc/llvm-project?rev=284154=rev
Log:
CodeGen: ensure that the runtime calling convention matches
Incorrect specification of the calling convention results in UB which can cause
the code path to be
agutowski created this revision.
agutowski added reviewers: rnk, hans, majnemer, mstorsjo.
agutowski added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
Previously global 64-bit versions of _Interlocked functions broke buildbots on
i386, so now I'm adding them as builtins for
vsk created this revision.
vsk added reviewers: arphaman, ikudrin.
vsk added a subscriber: cfe-commits.
Generate coverage mappings for in if (; ).
Here's some sample output (let's hope phab gets the spaces right :) --
12| |// CHECK-LABEL: define {{.*}}void @_Z11switch_initv()
13|
On Thu, Oct 13, 2016 at 02:32:24PM -, Asiri Rathnayake via cfe-commits
wrote:
> This missing include seems to cause compilation failures on older MacOS
> versions (< 10.9). This is because r270692 has introduced uint64_t into
> config.h without including this header.
But that would be
jacquelinekay added a comment.
I tested clang-format in vim with the recent state of trunk and it seems to
work without my patch. The bug I ran into initially was fixed in
https://reviews.llvm.org/D23319 with added encoding. So I think this can be
closed without merging.
Repository:
rL
Author: mren
Date: Thu Oct 13 13:42:14 2016
New Revision: 284142
URL: http://llvm.org/viewvc/llvm-project?rev=284142=rev
Log:
Module: emit initializers for C/ObjC after r276159.
In r276159, we started to defer emitting initializers for VarDecls, but
forgot to add the initializers for non-C++
Author: ioeric
Date: Thu Oct 13 13:56:14 2016
New Revision: 284147
URL: http://llvm.org/viewvc/llvm-project?rev=284147=rev
Log:
Print stack trace for clang-change-namespace tool.
Modified:
clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp
Modified:
Hi Richard,
I committed a follow-up patch in r284142 to fix issues with C/ObjC.
Let me know if you see any problem.
Manman
> On Jul 20, 2016, at 12:10 PM, Richard Smith via cfe-commits
> wrote:
>
> Author: rsmith
> Date: Wed Jul 20 14:10:16 2016
> New Revision:
Had a look at the C99 spec, according to section 7.18.1.1 ("Exact-width
integer types"), the types uint_t should be available in stdint.h
itself, inttypes.h on the other hand builds on stdint.h and provides more
functionality.
I don't see a particular need to include inttypes.h here?
Cheers,
/
EricWF added a comment.
Ping.
https://reviews.llvm.org/D25292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Thanks I am closing it!
Repository:
rL LLVM
https://reviews.llvm.org/D20785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Looks like this broke the gcc builder:
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-gcc49-cxx11/builds/573/steps/build.libcxxabi/logs/stdio
I'll have a look soon, might not be able to do so before tomorrow. Please
feel free to revert if this is blocking.
Sorry for the
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D25571
Files:
clang/include/clang/Basic/Linkage.h
clang/include/clang/Sema/Sema.h
clang/lib/AST/ASTContext.cpp
clang/lib/Sema/SemaCUDA.cpp
Index:
Author: asiri
Date: Thu Oct 13 13:40:57 2016
New Revision: 284141
URL: http://llvm.org/viewvc/llvm-project?rev=284141=rev
Log:
[libcxxabi] Fix gcc build after r284128
NFC.
Modified:
libcxxabi/trunk/src/config.h
Modified: libcxxabi/trunk/src/config.h
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284145: [CUDA] Allow static variables in __host__ __device__
functions, so long as… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25150?vs=73182=74566#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284143: [CUDA] Add Sema::CUDADiagBuilder and
Sema::CUDADiagIf{Device,Host}Code(). (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25139?vs=73576=74564#toc
Repository:
rL
rmaprath added a comment.
@EricWF: Gentle ping.
https://reviews.llvm.org/D25468
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Thu Oct 13 14:04:19 2016
New Revision: 284148
URL: http://llvm.org/viewvc/llvm-project?rev=284148=rev
Log:
Print stack trace for clang-move tool.
Modified:
clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp
Modified:
Author: compnerd
Date: Thu Oct 13 15:10:22 2016
New Revision: 284156
URL: http://llvm.org/viewvc/llvm-project?rev=284156=rev
Log:
test: attempt to repair SCEI buildbots
The tests target ARM, ensure that the ARM target is registered.
Modified:
cfe/trunk/test/CodeGenObjC/runtime-abi-match.m
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: marshall
Date: Thu Oct 13 16:06:03 2016
New Revision: 284164
URL: http://llvm.org/viewvc/llvm-project?rev=284164=rev
Log:
Implement http://wg21.link/p0302r1: Removing Allocator Support in
std::function. These functions never worked, and as far as I know, no one ever
called them.
Added:
jlebar added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:9244
/// CUDAKnownEmittedFns.
- llvm::DenseMap> CUDACallGraph;
+ llvm::DenseMap>
CUDACallGraph;
rnk wrote:
> I think you meant to make this change as part of the original patch.
rnk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2730
+llvm::AtomicOrdering::SequentiallyConsistent);
+return Builder.CreateSub(RMWI, ConstantInt::get(IntTy, 1));
}
agutowski wrote:
> rnk wrote:
> > Can you make a helper similar to
Author: agutowski
Date: Thu Oct 13 16:55:16 2016
New Revision: 284167
URL: http://llvm.org/viewvc/llvm-project?rev=284167=rev
Log:
fix _BitScan intrinsics missing header warnings; fix some line endings
Modified:
cfe/trunk/include/clang/Basic/BuiltinsARM.def
On Thu, Oct 13, 2016 at 11:48 AM, Sebastian Pop wrote:
> sebpop added a comment.
>
> In https://reviews.llvm.org/D24991#565861, @EricWF wrote:
>
> > In https://reviews.llvm.org/D24991#565715, @mclow.lists wrote:
> >
> > > How does this play with existing binaries? Applications
Author: alexshap
Date: Thu Oct 13 16:31:46 2016
New Revision: 284166
URL: http://llvm.org/viewvc/llvm-project?rev=284166=rev
Log:
[analyzer] Remove superquadratic behaviour from DataflowWorklist
The class DataflowWorklist internally maintains a sorted list of pointers to
CFGBlock
and the method
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk created this revision.
rnk added a reviewer: rsmith.
rnk added a subscriber: cfe-commits.
GCC documents that the alignment parameter is in bits and it must be:
- an integer constant
- a power of two
- a multiple of CHAR_BITS
- below an unspecified limit
This lines up directly with the
This revision was automatically updated to reflect the committed changes.
jlebar marked an inline comment as done.
Closed by commit rL284158: [CUDA] Emit deferred diagnostics during Sema rather
than during codegen. (authored by jlebar).
Changed prior to commit:
Author: jlebar
Date: Thu Oct 13 15:52:17 2016
New Revision: 284159
URL: http://llvm.org/viewvc/llvm-project?rev=284159=rev
Log:
Add and use isDiscardableGVALinkage function.
Reviewers: rnk
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25571
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284159: Add and use isDiscardableGVALinkage function.
(authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25571?vs=74562=74580#toc
Repository:
rL LLVM
Author: arnolds
Date: Thu Oct 13 15:59:23 2016
New Revision: 284162
URL: http://llvm.org/viewvc/llvm-project?rev=284162=rev
Log:
Add required targets to tests to (hopefully) appease bots
Modified:
cfe/trunk/test/CodeGen/64bit-swiftcall.c
Modified: cfe/trunk/test/CodeGen/64bit-swiftcall.c
agutowski updated this revision to Diff 74586.
agutowski added a comment.
make target-independent Interlocked builtins use EmitMSVCBuiltinExpr
https://reviews.llvm.org/D25576
Files:
include/clang/Basic/BuiltinsARM.def
include/clang/Basic/BuiltinsX86_64.def
lib/CodeGen/CGBuiltin.cpp
Author: agutowski
Date: Thu Oct 13 17:35:07 2016
New Revision: 284172
URL: http://llvm.org/viewvc/llvm-project?rev=284172=rev
Log:
Add 64-bit MS _Interlocked functions as builtins again
Summary: Previously global 64-bit versions of _Interlocked functions broke
buildbots on i386, so now I'm
agutowski added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2730
+llvm::AtomicOrdering::SequentiallyConsistent);
+return Builder.CreateSub(RMWI, ConstantInt::get(IntTy, 1));
}
rnk wrote:
> Can you make a helper similar to
akyrtzi added a comment.
Another recommendation for follow-up. When invoking completion on the
right-hand side of the assignment it should provide a block literal completion
with high priority. For example, when completing like this:
`self.foo = `
Repository:
rL LLVM
Author: marshall
Date: Thu Oct 13 16:15:09 2016
New Revision: 284165
URL: http://llvm.org/viewvc/llvm-project?rev=284165=rev
Log:
Update the status of three papers that do not require library changes
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
Author: jlebar
Date: Thu Oct 13 15:52:12 2016
New Revision: 284158
URL: http://llvm.org/viewvc/llvm-project?rev=284158=rev
Log:
[CUDA] Emit deferred diagnostics during Sema rather than during codegen.
Summary:
Emitting deferred diagnostics during codegen was a hack. It did work,
but usability
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284166: [analyzer] Remove superquadratic behaviour from
DataflowWorklist (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D25503?vs=74437=74585#toc
Repository:
rL LLVM
ruiu added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1392
+auto *BaseTy = getOrCreateType(BI.getType(), Unit);
+if (SeenTypes.find(BaseTy) != SeenTypes.end())
+ continue;
zturner wrote:
> rnk wrote:
> > IMO `SeenTypes.count(...)`
On 09/10/16 05:27, Stefan Kempf via cfe-commits wrote:
Ed Maste wrote:
emaste added a comment.
Seems fine to me, but I'm not particularly knowledgeable about OpenBSD's
toolchain.
Could you commit it please if it looks ok? This diff is what OpenBSD has
in its tree. We'd like to get it
agutowski updated this revision to Diff 74596.
agutowski added a comment.
rebase
https://reviews.llvm.org/D25334
Files:
include/clang/Basic/BuiltinsX86.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/ms-intrinsics.c
test/Headers/ms-intrin.cpp
Index:
Author: spop
Date: Thu Oct 13 19:07:57 2016
New Revision: 284179
URL: http://llvm.org/viewvc/llvm-project?rev=284179=rev
Log:
remove warnings from google-benchmarks in libcxx
Differential Revision: https://reviews.llvm.org/D25522
Patch written by Aditya Kumar.
Modified:
Author: arnolds
Date: Thu Oct 13 17:47:03 2016
New Revision: 284174
URL: http://llvm.org/viewvc/llvm-project?rev=284174=rev
Log:
Disable swiftcall test on windows: More brutal way to appease windows bots
The backtrace on the bot does not give me any indication what is wrong.
The test case
Author: rsmith
Date: Thu Oct 13 18:04:14 2016
New Revision: 284176
URL: http://llvm.org/viewvc/llvm-project?rev=284176=rev
Log:
Reinstate r281429, reverted in r281452, with a fix for its mishandling of
compiles without -fmodules-local-submodule-visibility. Original commit message:
[modules] When
majnemer added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1392
+auto *BaseTy = getOrCreateType(BI.getType(), Unit);
+if (SeenTypes.find(BaseTy) != SeenTypes.end())
+ continue;
ruiu wrote:
> zturner wrote:
> > rnk wrote:
> > > IMO
alexshap created this revision.
alexshap added reviewers: ioeric, klimek.
alexshap added a subscriber: cfe-commits.
alexshap set the repository for this revision to rL LLVM.
This diff replaces manual parsing of the comma-separated list of names with
cl::list and cl::CommaSeparated.
Test plan:
These kinds of crashes typically happen when you have something like a
use-after-destroy of a temporary, like a misuse of Twine or
std::initializer_list.
On Thu, Oct 13, 2016 at 3:47 PM, Arnold Schwaighofer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arnolds
> Date: Thu Oct 13
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM modulo inline comments.
Comment at: include/iterator:95
+template constexpr reverse_iterator(const reverse_iterator&
u);
+template constexpr
On Thu, Oct 13, 2016 at 11:52 AM, Manman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Richard,
>
> I committed a follow-up patch in r284142 to fix issues with C/ObjC.
>
> Let me know if you see any problem.
>
Looks good, thank you!
> Manman
>
> > On Jul 20, 2016, at 12:10 PM,
majnemer added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:
+Address Dest = EmitPointerWithAlignment(E->getArg(0));
+return Builder.CreateMemSet(Dest, Ops[1], Ops[2], true);
}
I think we should manually force the alignment to 1 instead
agutowski updated this revision to Diff 74603.
agutowski added a comment.
force the alignment to 1
https://reviews.llvm.org/D25334
Files:
include/clang/Basic/BuiltinsX86.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/ms-intrinsics.c
test/Headers/ms-intrin.cpp
EricWF created this revision.
EricWF added reviewers: mclow.lists, rsmith.
EricWF added subscribers: cfe-commits, rsmith.
This patch implements the library side of P0035R4. The implementation is thanks
to @rsmith.
In addition to the C++17 implementation, the library implementation can be
EricWF closed this revision.
EricWF added a comment.
I committed this fix a couple days ago when helping the libstdc++ maintainers
setup our test suite.
https://reviews.llvm.org/D25451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ericwf
Date: Fri Oct 14 00:10:06 2016
New Revision: 284199
URL: http://llvm.org/viewvc/llvm-project?rev=284199=rev
Log:
Add ABI changelog entry for
Modified:
libcxx/trunk/lib/abi/CHANGELOG.TXT
Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT
URL:
Author: ericwf
Date: Fri Oct 14 00:29:46 2016
New Revision: 284200
URL: http://llvm.org/viewvc/llvm-project?rev=284200=rev
Log:
Remove two ABI symbols added after the 3.9 release
Modified:
libcxx/trunk/include/string
libcxx/trunk/lib/abi/x86_64-linux-gnu.abilist
Modified:
1 - 100 of 140 matches
Mail list logo