[PATCH] D25263: [Driver] Allow setting the default linker during build

2016-10-17 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added a comment. Have you run all tests with `CLANG_DEFAULT_LINKER` not being the platform default? I imagine there might be some tests that expect `ld` to be used... Comment at: CMakeLists.txt:198 +set(CLANG_DEFAULT_LINKER "" CACHE STRING + "Default linker to use

Re: [PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

2016-10-17 Thread Haojian Wu via cfe-commits
Yeah, "make -j 32" won't compile binaries in clang-tools-extra repo. "make check-clang-tools" should work though I don't use make. I usually run `ninja check-clang-tools` command to build all binaries and run all lint-tests/unittest in clang-extra-tools. There is a remaining build error in the

r284366 - AST: Prefer LLVM_NODISCARD to LLVM_ATTRIBUTE_UNUSED_RESULT

2016-10-17 Thread Justin Bogner via cfe-commits
Author: bogner Date: Mon Oct 17 01:46:35 2016 New Revision: 284366 URL: http://llvm.org/viewvc/llvm-project?rev=284366=rev Log: AST: Prefer LLVM_NODISCARD to LLVM_ATTRIBUTE_UNUSED_RESULT Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL:

[PATCH] D25669: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC)

2016-10-17 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld created this revision. Hahnfeld added reviewers: mgorny, ddunbar, phosek. Hahnfeld added subscribers: cfe-commits, zlei. I made the wrong assumption that execution would continue after an error Diag which led to unneeded complex code. This patch aligns with the better implementation of

[PATCH] D25600: [ASTMatcher] Add isStaticDataMember matcher for varDecl.

2016-10-17 Thread Haojian Wu via cfe-commits
hokein abandoned this revision. hokein added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3005 +/// \endcode +AST_MATCHER(VarDecl, isStaticDataMember) { + return Node.isStaticDataMember(); aaron.ballman wrote: > hokein wrote: > >

[clang-tools-extra] r284368 - Recommit "[ClangTidy] Add UsingInserter and NamespaceAliaser"

2016-10-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 17 03:33:59 2016 New Revision: 284368 URL: http://llvm.org/viewvc/llvm-project?rev=284368=rev Log: Recommit "[ClangTidy] Add UsingInserter and NamespaceAliaser" Summary: This adds helper classes to add using declaractions and namespace aliases to function bodies.

[clang-tools-extra] r284370 - Fix windows buildbot error.

2016-10-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 17 05:05:25 2016 New Revision: 284370 URL: http://llvm.org/viewvc/llvm-project?rev=284370=rev Log: Fix windows buildbot error. Modified: clang-tools-extra/trunk/unittests/clang-tidy/NamespaceAliaserTest.cpp

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

2016-10-17 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Thank you for continuing your efforts on this, I have just a few minor nits remaining. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:35 + diag(MatchedDecl->getLocStart(), + "rand() function has limited randomness; " + msg); +}

[PATCH] D25711: [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC)

2016-10-17 Thread Vedant Kumar via cfe-commits
vsk created this revision. vsk added a reviewer: jlebar. vsk added a subscriber: cfe-commits. https://reviews.llvm.org/D25711 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp Index: lib/Basic/SourceManager.cpp

[PATCH] D25711: [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC)

2016-10-17 Thread Justin Lebar via cfe-commits
jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. The great thing about unique_ptr is, if it compiles, we're probably good. :) https://reviews.llvm.org/D25711 ___ cfe-commits mailing list

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

2016-10-17 Thread Dean Michael Berris via cfe-commits
dberris added a comment. In https://reviews.llvm.org/D24799#566507, @rSerge wrote: > I have extended this feature to check for OS support too (currently Linux > only). I can't commit it so far because I don't know how to implement a test. > XFAIL cannot check for both CPU and OS: it can only

r284442 - [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC)

2016-10-17 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Mon Oct 17 19:23:27 2016 New Revision: 284442 URL: http://llvm.org/viewvc/llvm-project?rev=284442=rev Log: [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC) Differential Revision: https://reviews.llvm.org/D25711 Modified:

[PATCH] D25711: [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC)

2016-10-17 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284442: [Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D25711?vs=74935=74937#toc Repository: rL LLVM

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

2016-10-17 Thread Petr Hosek via cfe-commits
phosek created this revision. phosek added a reviewer: davide. phosek added a subscriber: cfe-commits. phosek set the repository for this revision to rL LLVM. When comparing the linker name in Fuchsia driver, use stem rather than filename to get the name of the linker becase on Windows, the

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

2016-10-17 Thread Davide Italiano via cfe-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Was going to commit the same. Thanks. LGTM. Repository: rL LLVM https://reviews.llvm.org/D25700 ___ cfe-commits mailing list

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

2016-10-17 Thread Davide Italiano via cfe-commits
davide added a comment. And yes, if you can add a test case that will be great (there's no bot that caught this upstream) but one of our internal bots did. Repository: rL LLVM https://reviews.llvm.org/D25700 ___ cfe-commits mailing list

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

2016-10-17 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a reviewer: bruno. bruno added a comment. Can you add a testcase for that? Repository: rL LLVM https://reviews.llvm.org/D25700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25703: [AST] Add CanonicalDeclPtr.

2016-10-17 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: rnk. jlebar added subscribers: tra, cfe-commits. CanonicalDeclPtr is just like a T*, except it calls T::getCanonicalDecl() on construction. This is useful as the key in a "set of canonical Decls" -- it's much less error-prone than calling

[PATCH] D25448: [ubsan] Use the object pointer's type info for devirtualized calls

2016-10-17 Thread Vedant Kumar via cfe-commits
vsk retitled this revision from "[ubsan] Disable -fsanitize=vptr checks for devirtualized calls" to "[ubsan] Use the object pointer's type info for devirtualized calls". vsk updated the summary for this revision. vsk added a subscriber: rsmith. vsk updated this revision to Diff 74916. vsk added

Re: [libcxx] r249738 - Split out of .

2016-10-17 Thread Manman via cfe-commits
> On Oct 17, 2016, at 2:11 PM, Bruno Cardoso Lopes via cfe-commits > wrote: > > Hi, > > On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith wrote: >> On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes >> wrote: >>>

[PATCH] D25284: AvailabilityAttrs: Delay partial availability diagnostics

2016-10-17 Thread Manman Ren via cfe-commits
manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. This is better than what I asked for :] Manman https://reviews.llvm.org/D25284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r249738 - Split out of .

2016-10-17 Thread Bruno Cardoso Lopes via cfe-commits
> @Bruno, > > Can you try "-fdiagnostics-show-note-include-stack” so we know the other path > that leads to string.h? Attached the complete error log (this snippet won't help without full context anyway) -- Bruno Cardoso Lopes http://www.brunocardoso.cc output.log Description: Binary data

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

2016-10-17 Thread Dean Michael Berris via cfe-commits
dberris added a comment. Sorry for the delay, I had thought I pointed to some potentially helpful documentation. :/ BTW, did the test get removed from the latest change? I don't see it being added anymore. https://reviews.llvm.org/D24799 ___

[PATCH] D25363: Store a SourceRange for multi-token builtin types

2016-10-17 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/AST/TypeLoc.h:513 struct BuiltinLocInfo { - SourceLocation BuiltinLoc; + SourceRange BuiltinRange; }; Since this doubles the size of the type loc for builtin types, do you happen to have any

Re: r284272 - Implement no_sanitize_address for global vars

2016-10-17 Thread Kostya Serebryany via cfe-commits
Did you code-review this? (sorry if I missed it) On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katzman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dougk > Date: Fri Oct 14 14:55:09 2016 > New Revision: 284272 > > URL: http://llvm.org/viewvc/llvm-project?rev=284272=rev > Log: >

r284443 - [CMake] Add a few default passthrough variables for bootstrap builds

2016-10-17 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Mon Oct 17 19:50:20 2016 New Revision: 284443 URL: http://llvm.org/viewvc/llvm-project?rev=284443=rev Log: [CMake] Add a few default passthrough variables for bootstrap builds This just passes through a few missing CMake variables for multi-stage builds. Modified:

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

2016-10-17 Thread Justin Lebar via cfe-commits
jlebar added a comment. > The tests should be runnable with lit. I generally just do an in-tree build > and run make check-libcxx. @EricWF , what's the recommended way of running > the tests from an out-of-tree build? Things seem broken at the moment with clang from tip of tree. I did a clean

[PATCH] D25673: [libclang] Add missing cursor kinds to python bindings.

2016-10-17 Thread Vedant Kumar via cfe-commits
vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. Thanks for working on this! Fwiw, I double-checked the API coverage with: $ git grep -E "CXCursor_[a-zA-Z_0-9]+ *= *[0-9]+" | grep -Eo "[0-9]+" | sort -u | uniq | wc -l

[PATCH] D23745: [cmake] Update lit search to match the one in LLVM

2016-10-17 Thread Chris Bieneman via cfe-commits
beanz added a comment. Is there a bug you're trying to fix here? It seems to me that the existing behavior works correctly. I'm also pretty sure from the comment in https://reviews.llvm.org/D23743 that `llvm-lit` shouldn't be in the list. https://reviews.llvm.org/D23745

[PATCH] D25448: [ubsan] Use the object pointer's type info for devirtualized calls

2016-10-17 Thread Vedant Kumar via cfe-commits
vsk updated this revision to Diff 74943. vsk added a comment. - Remove some default arguments left over from an older revision of this patch. - Simplify the test. https://reviews.llvm.org/D25448 Files: lib/CodeGen/CGExprCXX.cpp lib/CodeGen/CodeGenFunction.h

[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

2016-10-17 Thread Chris Bieneman via cfe-commits
beanz added a comment. Looking more closely at this, there is a problem that I see. The clang runtime directory only supports building compiler-rt, and is going to be replaced by the llvm runtimes directory in the (hopefully near) future. Maybe a better way to go is to define

[PATCH] D25448: [ubsan] Use the object pointer's type info for devirtualized calls

2016-10-17 Thread John McCall via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D25448#572245, @vsk wrote: > Patch update: Pass along the type info of the derived class to the ubsan > runtime when we devirtualize a method call. This squashes the FP. I tested > this with 'check-ubsan' in addition to adding a lit test. >

[PATCH] D25448: [ubsan] Use the object pointer's type info for devirtualized calls

2016-10-17 Thread John McCall via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGExprCXX.cpp:31 +CallArgList , CallArgList *RtlArgs, +llvm::Optional DevirtualizedClassTy) { assert(CE == nullptr || isa(CE) || Shouldn't MD just be the devirtualized method? That should avoid

[PATCH] D25547: [CodeGen][ObjC] Do not emit objc_storeStrong to initialize a constexpr variable

2016-10-17 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 74944. ahatanak added a comment. Address review comments. Simplify and add comments. https://reviews.llvm.org/D25547 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGObjC.cpp lib/CodeGen/CGStmtOpenMP.cpp

Re: r284265 - [Sema] Refactor context checking for availability diagnostics

2016-10-17 Thread Bob Wilson via cfe-commits
Hi Erik, This change does not work with one of the headers from the AVFoundation framework in tvOS 10.0. We can try to get a fix into the tvOS SDK, but it will probably be a while before we could release an SDK with that change. In the meantime, this is kind of disruptive. Can you find a way

[PATCH] D23745: [cmake] Update lit search to match the one in LLVM

2016-10-17 Thread Michał Górny via cfe-commits
mgorny added a comment. In https://reviews.llvm.org/D23745#572517, @beanz wrote: > Is there a bug you're trying to fix here? It seems to me that the existing > behavior works correctly. I'm also pretty sure from the comment in > https://reviews.llvm.org/D23743 that `llvm-lit` shouldn't be in

[PATCH] D24572: [clang-tidy] Clean up code after applying replacements.

2016-10-17 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284399: [clang-tidy] Clean up code after applying replacements. (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D24572?vs=74160=74868#toc Repository: rL LLVM

[PATCH] D25686: [Driver] Support "hardfloat" vendor triples used by Gentoo

2016-10-17 Thread Hal Finkel via cfe-commits
hfinkel added a comment. It seems like we should teach Triple how to parse this triples correctly (i.e. to recognize that the vendor is ARM), and then canonicalize the environment to GNUEABIHF (or whatever)? https://reviews.llvm.org/D25686 ___

[PATCH] D25686: [Driver] Support "hardfloat" vendor triples used by Gentoo

2016-10-17 Thread Michał Górny via cfe-commits
mgorny added a comment. In https://reviews.llvm.org/D25686#571857, @hfinkel wrote: > It seems like we should teach Triple how to parse this triples correctly > (i.e. to recognize that the vendor is ARM), and then canonicalize the > environment to GNUEABIHF (or whatever)? I've attempted that

[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

2016-10-17 Thread Michał Górny via cfe-commits
mgorny added a comment. A gentle ping. https://reviews.llvm.org/D23752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25641: [Driver] Use VFS to perform all distribution checks

2016-10-17 Thread Bruno Cardoso Lopes via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks! LGTM! https://reviews.llvm.org/D25641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r284401 - Hexagon: add dummy files to test dir so git keeps them.

2016-10-17 Thread Tim Northover via cfe-commits
Author: tnorthover Date: Mon Oct 17 13:00:27 2016 New Revision: 284401 URL: http://llvm.org/viewvc/llvm-project?rev=284401=rev Log: Hexagon: add dummy files to test dir so git keeps them. Should fix hexagon-elf-toolchain.c tests on Git. Added:

[PATCH] D25641: [Driver] Use VFS to perform all distribution checks

2016-10-17 Thread Michał Górny via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284403: [Driver] Use VFS to perform all distribution checks (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D25641?vs=74767=74874#toc Repository: rL LLVM

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

2016-10-17 Thread Richard Smith via cfe-commits
rsmith added a comment. I really don't like the command-line interface you're proposing here. It seems like it will be extremely confusing what something like `-fmodules -fexclusive-builtin-modules` means, for instance (usually, later `-f` flags override earlier ones, so does this *turn off*

[PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

2016-10-17 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: include/clang/AST/Type.h:2934 ExtInfo(bool noReturn, bool hasRegParm, unsigned regParm, CallingConv cc, -bool producesResult) { +bool producesResult, bool noCallerSavedRegs) { assert((!hasRegParm ||

[PATCH] D24954: [ToolChains] Disable OpenSUSE rules for SLES10

2016-10-17 Thread Michał Górny via cfe-commits
mgorny planned changes to this revision. mgorny added a comment. I'm going to delay this one a bit. I've already fixed all other distro checks to use VFS. Now I'd like to update them to use proper numeric parsing. https://reviews.llvm.org/D24954

r284400 - Fix a typo.

2016-10-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Oct 17 12:41:51 2016 New Revision: 284400 URL: http://llvm.org/viewvc/llvm-project?rev=284400=rev Log: Fix a typo. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL:

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

2016-10-17 Thread Bruno Cardoso Lopes via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Ok, great! LGTM https://reviews.llvm.org/D24669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

2016-10-17 Thread Tim Northover via cfe-commits
On 14 October 2016 at 14:21, Eric Fiselier via cfe-commits wrote: > Could you give me more information about the compiler your using? Do you mostly build libcxx outside of a Clang source tree? I suspect the problem is that if Clang is built at the same time then

[PATCH] D25686: [Driver] Support "hardfloat" vendor triples used by Gentoo

2016-10-17 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: bob.wilson, rengolin, rafael, ddunbar. mgorny added subscribers: cfe-commits, zlei. Herald added a subscriber: aemerson. Support the arm-hardfloat-*-*eabi triples used by Gentoo to signify hardfloat variants of ARM *EABI. Add tests for correct

[clang-tools-extra] r284399 - [clang-tidy] Clean up code after applying replacements.

2016-10-17 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Mon Oct 17 12:25:02 2016 New Revision: 284399 URL: http://llvm.org/viewvc/llvm-project?rev=284399=rev Log: [clang-tidy] Clean up code after applying replacements. Summary: Remove empty namespaces and initializer list commas / colons in affected ranges. Initial patch: proper

Re: r284392 - Reapply r284383. The test failures were due to a missing dir in test/

2016-10-17 Thread Tim Northover via cfe-commits
Hi Krzysztof, This still seems to be failing on Darwin: /Users/tim/llvm/llvm/tools/clang/test/Driver/hexagon-toolchain-elf.c:9:14: error: expected string not found in input // CHECK000: "-cc1" {{.*}} "-internal-externc-isystem" "{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/include"

r284403 - [Driver] Use VFS to perform all distribution checks

2016-10-17 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Mon Oct 17 13:07:15 2016 New Revision: 284403 URL: http://llvm.org/viewvc/llvm-project?rev=284403=rev Log: [Driver] Use VFS to perform all distribution checks Use the VFS provided by D.getVFS() for all distribution checks, including those performing read of the release file.

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

2016-10-17 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. > The long answer is that there is a history of problems regarding the > intrinsic files: > http://lists.llvm.org/pipermail/cfe-dev/2016-May/048837.html > http://lists.llvm.org/pipermail/cfe-dev/2016-September/050943.html > Mainly compatibility issues because MSVC

[PATCH] D25702: [CUDA] Emit errors for wrong-side calls made on the same line as non-wrong-side calls.

2016-10-17 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: cfe-commits, rnk. This fixes two related bugs: 1. Previously, if you had a non-wrong side call at some source code location L, we wouldn't emit errors for wrong-side calls that appeared at L. 2. We'd only

[PATCH] D25663: [analyzer] Update alpha and potential checker documentation, esp. alpha.valist

2016-10-17 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thank you for the cleanup! Anna. https://reviews.llvm.org/D25663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25704: [CUDA] When we emit an error that might have been deferred, also print a callstack.

2016-10-17 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: rnk. jlebar added subscribers: tra, cfe-commits. Previously, when you did something not allowed in a host+device function and then caused it to be codegen'ed, we would print out an error telling you that you did something bad, but we wouldn't

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

2016-10-17 Thread Bruno Cardoso Lopes via cfe-commits
bruno accepted this revision. bruno added a comment. Ok, thanks! LGTM Repository: rL LLVM https://reviews.llvm.org/D25700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

2016-10-17 Thread Petr Hosek via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284430: [Driver] Use stem rather than filename for executable name (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D25700?vs=74905=74917#toc Repository: rL LLVM

r284430 - [Driver] Use stem rather than filename for executable name

2016-10-17 Thread Petr Hosek via cfe-commits
Author: phosek Date: Mon Oct 17 17:02:53 2016 New Revision: 284430 URL: http://llvm.org/viewvc/llvm-project?rev=284430=rev Log: [Driver] Use stem rather than filename for executable name When comparing the linker name in Fuchsia driver, use stem rather than filename to get the name of the linker

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

2016-10-17 Thread Benedek Kiss via cfe-commits
falho removed rL LLVM as the repository for this revision. falho updated this revision to Diff 74908. falho added a comment. Herald added subscribers: modocache, mgorny, beanz. updated diff according to first reviews https://reviews.llvm.org/D22346 Files:

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

2016-10-17 Thread Manman Ren via cfe-commits
manmanren added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10129 +!Var->isThisDeclarationADemotedDefinition()) { + assert(Var->isThisDeclarationADemotedDefinition() && getLangOpts().Modules + && "Demoting decls is only in the contest of

r284372 - Do not reset TUScope when we are in incremental processing mode.

2016-10-17 Thread Vassil Vassilev via cfe-commits
Author: vvassilev Date: Mon Oct 17 05:15:25 2016 New Revision: 284372 URL: http://llvm.org/viewvc/llvm-project?rev=284372=rev Log: Do not reset TUScope when we are in incremental processing mode. Patch by Axel Naumann! Reviewed by Richard Smith and me. Modified: cfe/trunk/lib/Sema/Sema.cpp

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

2016-10-17 Thread Serge Rogatch via cfe-commits
rSerge added a comment. Ping? (please, see the question about the test) https://reviews.llvm.org/D24799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

2016-10-17 Thread Serge Rogatch via cfe-commits
rSerge updated this revision to Diff 74829. https://reviews.llvm.org/D24799 Files: lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp === --- lib/Driver/Tools.cpp +++ lib/Driver/Tools.cpp @@ -4804,7 +4804,16 @@ if

[PATCH] D25621: DebugInfo: use DIAlignment type.

2016-10-17 Thread Victor Leschuk via cfe-commits
vleschuk marked an inline comment as done. vleschuk added inline comments. Comment at: include/clang/AST/ASTContext.h:83 uint64_t Width; -unsigned Align; +llvm::DIAlignment Align; bool AlignIsRequired : 1; aprantl wrote: > I'm not sure we want

[PATCH] D25661: [Driver] Support obtaining active toolchain from gcc-config on Gentoo

2016-10-17 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/Driver/ToolChains.cpp:1438 + if (GCCToolchainDir == "" || GCCToolchainDir == D.SysRoot + "/usr") { +for (unsigned k = 0, ke = CandidateTripleAliases.size(); k < ke; ++k) { + llvm::ErrorOr File =

[PATCH] D25363: Store a SourceRange for multi-token builtin types

2016-10-17 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. ping. https://reviews.llvm.org/D25363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25602: Do not reset TUScope when we are in incremental processing mode.

2016-10-17 Thread Vassil Vassilev via cfe-commits
v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r284372. https://reviews.llvm.org/D25602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25669: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC)

2016-10-17 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/Driver/ToolChain.cpp:553-559 + // "platform" is only used in tests to override CLANG_DEFAULT_CXX_STDLIB + if (LibName == "libc++") +return ToolChain::CST_Libcxx; + else if (LibName == "libstdc++") +return

[PATCH] D25153: preprocessor supports `-dI` flag

2016-10-17 Thread Steve O'Brien via cfe-commits
elsteveogrande added a comment. I'll need help landing this... I also tried `git svn dcommit` but command hung there forever. Thanks! https://reviews.llvm.org/D25153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r284137 - [ThinLTO] Update doc to include lld (now supported).

2016-10-17 Thread Rafael Espíndola via cfe-commits
On 16 October 2016 at 22:13, Davide Italiano wrote: > On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva wrote: >> Nice to see this land! >> >> One nit: >> Currently, doesn't LLD/ELF ignore -plugin-opt? That will mean that if a user >> uses the "gold syntax"

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

2016-10-17 Thread Krzysztof Parzyszek via cfe-commits
kparzysz added a comment. This change bool FileManager::getStatValue(StringRef Path, FileData , bool isFile, std::unique_ptr *F) { // FIXME: FileSystemOpts shouldn't be passed in here, all paths should be // absolute! llvm::dbgs() <<

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-17 Thread Benjamin Kramer via cfe-commits
Too slow ;) Do you have the fix somewhere, so I can try it? On Mon, Oct 17, 2016 at 4:38 PM, Vassil Vassilev wrote: > I was just to commit a fix :( > > On 17/10/16 15:00, Benjamin Kramer via cfe-commits wrote: >> >> Author: d0k >> Date: Mon Oct 17 08:00:44 2016 >> New

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-17 Thread Vassil Vassilev via cfe-commits
On 17/10/16 16:40, Benjamin Kramer wrote: Too slow ;) Do you have the fix somewhere, so I can try it? That would be https://reviews.llvm.org/D25678 Do you run into something else than what I have as a test case (merging templated constexpr variables)? On Mon, Oct 17, 2016 at 4:38 PM,

[PATCH] D25606: alpha.core.UnreachableCode - don't warn about unreachable code inside macro

2016-10-17 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki updated this revision to Diff 74849. danielmarjamaki added a comment. make pattern to avoid warnings more specific Repository: rL LLVM https://reviews.llvm.org/D25606 Files: lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp test/Analysis/unreachable-code-path.c

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-17 Thread Benjamin Kramer via cfe-commits
I'm running into something else and your patch doesn't fix it. It boils down to 'std::is_nothrow_move_constructible' from libstdc++ not compiling because Foo is not visible inside the noexcept specification of that template. I failed to come up with a small test case so far as it involves at least

[PATCH] D25547: [CodeGen][ObjC] Do not emit objc_storeStrong to initialize a constexpr variable

2016-10-17 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 74851. ahatanak added a comment. Simplify the code a bit more. https://reviews.llvm.org/D25547 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGObjC.cpp lib/CodeGen/CGStmtOpenMP.cpp lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D25621: DebugInfo: use DIAlignment type.

2016-10-17 Thread David Blaikie via cfe-commits
On Mon, Oct 17, 2016 at 4:37 AM Victor Leschuk wrote: > vleschuk marked an inline comment as done. > vleschuk added inline comments. > > > > Comment at: include/clang/AST/ASTContext.h:83 > uint64_t Width; > -unsigned Align; > +

Re: [clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

2016-10-17 Thread Haojian Wu via cfe-commits
Hello Tim, Sorry for the trouble and delay (I missed this email previously). I'm looking into it. Could you give me a link to the problematic buildbot? On Mon, Oct 17, 2016 at 3:44 PM, Tim Northover wrote: > On 14 October 2016 at 13:33, Tim Northover

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-17 Thread Vassil Vassilev via cfe-commits
I was just to commit a fix :( On 17/10/16 15:00, Benjamin Kramer via cfe-commits wrote: Author: d0k Date: Mon Oct 17 08:00:44 2016 New Revision: 284382 URL: http://llvm.org/viewvc/llvm-project?rev=284382=rev Log: Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

2016-10-17 Thread Vassil Vassilev via cfe-commits
v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, bkramer. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D25678 Files: lib/Sema/SemaDecl.cpp

r284389 - Revert r284383, while I figure out how to reproduce the failures locally

2016-10-17 Thread Krzysztof Parzyszek via cfe-commits
Author: kparzysz Date: Mon Oct 17 09:47:29 2016 New Revision: 284389 URL: http://llvm.org/viewvc/llvm-project?rev=284389=rev Log: Revert r284383, while I figure out how to reproduce the failures locally Modified: cfe/trunk/lib/Driver/ToolChains.cpp Modified:

[PATCH] D25595: [libcxx] Support std::regex_constants::match_not_null

2016-10-17 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: libcxx/test/std/re/re.alg/re.alg.search/pr21597.pass.cpp:12 + +// template +// bool Rather than this comment about `regex_search`, there should be a comment about `match_not_null`, which is really what we're

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

2016-10-17 Thread Krzysztof Parzyszek via cfe-commits
kparzysz added a comment. In https://reviews.llvm.org/D25597#571532, @kparzysz wrote: > `FileSystemOpts.WorkingDir: ''` There is no space between the single quotes. https://reviews.llvm.org/D25597 ___ cfe-commits mailing list

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

2016-10-17 Thread Krzysztof Parzyszek via cfe-commits
kparzysz added a comment. Printing Path shows `/../target/hexagon/include` https://reviews.llvm.org/D25597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 17 08:00:44 2016 New Revision: 284382 URL: http://llvm.org/viewvc/llvm-project?rev=284382=rev Log: Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of" This reverts commit r284176. It still marks some modules as invisible that should be

[PATCH] D25674: [Concepts] Class template associated constraints

2016-10-17 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: rsmith, faisalv, aaron.ballman. hubert.reinterpretcast added subscribers: nwilson, cfe-commits. This adds associated constraints as a property of class templates. An error is produced if redeclarations are not

Re: r284137 - [ThinLTO] Update doc to include lld (now supported).

2016-10-17 Thread Teresa Johnson via cfe-commits
On Mon, Oct 17, 2016 at 6:15 AM, Teresa Johnson wrote: > > > On Mon, Oct 17, 2016 at 5:13 AM, Rafael Espíndola < > rafael.espind...@gmail.com> wrote: > >> On 16 October 2016 at 22:13, Davide Italiano wrote: >> > On Sun, Oct 16, 2016 at 6:43 PM, Sean

[PATCH] D25311: Add FixItHint for missing #include (err_module_unimported_use_header)

2016-10-17 Thread Sam McCall via cfe-commits
sammccall added a comment. Ping - let me know if there's a more appropriate reviewer! https://reviews.llvm.org/D25311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r284137 - [ThinLTO] Update doc to include lld (now supported).

2016-10-17 Thread Teresa Johnson via cfe-commits
On Mon, Oct 17, 2016 at 5:13 AM, Rafael Espíndola < rafael.espind...@gmail.com> wrote: > On 16 October 2016 at 22:13, Davide Italiano wrote: > > On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva > wrote: > >> Nice to see this land! > >> > >> One nit: > >>

[PATCH] D25673: [libclang] Add missing cursor kinds to python bindings.

2016-10-17 Thread Igor Kudrin via cfe-commits
ikudrin created this revision. ikudrin added reviewers: compnerd, ABataev, erik.pilkington, ogoffart. ikudrin added a subscriber: cfe-commits. https://reviews.llvm.org/D25673 Files: bindings/python/clang/cindex.py Index: bindings/python/clang/cindex.py

r284383 - Return correct path from HexagonToolChain::getHexagonTargetDir

2016-10-17 Thread Krzysztof Parzyszek via cfe-commits
Author: kparzysz Date: Mon Oct 17 08:23:41 2016 New Revision: 284383 URL: http://llvm.org/viewvc/llvm-project?rev=284383=rev Log: Return correct path from HexagonToolChain::getHexagonTargetDir This problem was exposed by r284129, causing clang-hexagon-elf to fail clang tests. Modified:

[PATCH] D25675: clang-format: [JS] Fix template string ASI.

2016-10-17 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Previously, automatic semicolon insertion would add an unwrapped line when a template string contained a line break. var x = `foo${ bar}`; Would

Re: [clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

2016-10-17 Thread Tim Northover via cfe-commits
On 14 October 2016 at 13:33, Tim Northover wrote: > On 14 October 2016 at 06:01, Haojian Wu via cfe-commits > wrote: >> + std::string GuardName(FileName); >> + if (IsHeader) { >> +std::replace(GuardName.begin(), GuardName.end(), '/',

[PATCH] D25661: [Driver] Support obtaining active toolchain from gcc-config on Gentoo

2016-10-17 Thread Michał Górny via cfe-commits
mgorny added inline comments. Comment at: lib/Driver/ToolChains.cpp:1446-1463 + // CURRENT=triple-version + if (Line.startswith("CURRENT=")) { +const std::pair ActiveVersion = + Line.substr(8).rsplit('-'); +

Re: r284383 - Return correct path from HexagonToolChain::getHexagonTargetDir

2016-10-17 Thread Benjamin Kramer via cfe-commits
And now the test fails everywhere, including the hexagon bot. Please fix. On Mon, Oct 17, 2016 at 3:23 PM, Krzysztof Parzyszek via cfe-commits wrote: > Author: kparzysz > Date: Mon Oct 17 08:23:41 2016 > New Revision: 284383 > > URL:

Re: r284187 - Fix bogus assert breaking modules self-host.

2016-10-17 Thread David Blaikie via cfe-commits
Not worth/reasonable to have a test case? On Thu, Oct 13, 2016 at 7:44 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Oct 13 21:35:11 2016 > New Revision: 284187 > > URL: http://llvm.org/viewvc/llvm-project?rev=284187=rev > Log: > Fix bogus

[clang-tools-extra] r284391 - [clang-move] Fix generating illegal header guard.

2016-10-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 17 10:26:34 2016 New Revision: 284391 URL: http://llvm.org/viewvc/llvm-project?rev=284391=rev Log: [clang-move] Fix generating illegal header guard. The filepath might contain some characters (i.e. '@') which are not illegal in c identifiers. This patch changes all

r284392 - Reapply r284383. The test failures were due to a missing dir in test/

2016-10-17 Thread Krzysztof Parzyszek via cfe-commits
Author: kparzysz Date: Mon Oct 17 10:30:10 2016 New Revision: 284392 URL: http://llvm.org/viewvc/llvm-project?rev=284392=rev Log: Reapply r284383. The test failures were due to a missing dir in test/ Added: cfe/trunk/test/Driver/Inputs/hexagon_tree/Tools/bin/ Modified:

  1   2   >