NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/Analysis/virtualcall.h:23
+#if INTERPROCEDURAL
+ // expected-warning-re@-2 ^}}Call Path : fooCall to virtual
function during construction or de
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325
+ const CallEvent *Call,
+ const LocationContext *LCtx) {
+return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated,
-
Author: malcolm.parsons
Date: Thu Nov 17 03:14:04 2016
New Revision: 287215
URL: http://llvm.org/viewvc/llvm-project?rev=287215&view=rev
Log:
[clang-tidy] Changes to modernize-use-default check
Summary:
Warn about special member functions that only contain a comment.
Report the location of the sp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287215: [clang-tidy] Changes to modernize-use-default check
(authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26741?vs=78164&id=78328#toc
Repository:
rL LLVM
https://
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:64
getIncludeFixerContext(const clang::SourceManager &SourceManager,
clang::HeaderSearch &HeaderSearch) {
+return SemaSource.getIncludeFixerContext(SourceManager, HeaderSearc
hokein accepted this revision.
hokein added a reviewer: hokein.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:37
unless(anyOf(hasBody(stmt()), isDefaulted(), isDeleted(
hokein added inline comments.
Comment at: test/clang-tidy/readability-delete-null-pointer.cpp:3
+
+#include
+
We don't rely on implementations of standard headers in lit test. You should
fake the function/class that you need in this test.
Co
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:37
unless(anyOf(hasBody(stmt()), isDefaulted(), isDeleted(),
+ ast_matchers::isTemplateInstantiation(),
// Ensure that all met
sfantao added a comment.
Hi Justin,
Thanks for the patch.
Comment at: clang/lib/Driver/Driver.cpp:479
+// the device toolchain we create depends on both.
+ToolChain *&CudaTC = ToolChains[CudaTriple.str() + "/" + HostTriple.str()];
+if (!CudaTC) {
I
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
A few minor comments regarding outdated comments and style.
Comment at: include/clang/AST/ASTContext.h:1124
/// \brief Return pipe type for the specified typ
Author: malcolm.parsons
Date: Thu Nov 17 05:40:02 2016
New Revision: 287221
URL: http://llvm.org/viewvc/llvm-project?rev=287221&view=rev
Log:
[clang-tidy] Ignore template instantiations in modernize-use-equals-delete check
Summary: Template instantiations were causing misplaced fixits.
Reviewers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287221: [clang-tidy] Ignore template instantiations in
modernize-use-equals-delete check (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26751?vs=78202&id=78344#toc
Re
bkramer added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
hokein wrote:
> I have a concern that `Placed` here mig
bkramer updated this revision to Diff 78345.
bkramer marked 7 inline comments as done.
bkramer added a comment.
- Address review comments.
https://reviews.llvm.org/D26752
Files:
include-fixer/CMakeLists.txt
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/plugin
arphaman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10304
CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
+ Expr *SE = nullptr;
+
NIT, but I think you don't need the extra variable and the `if (SE)` below if
you extract the co
ioeric added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
bkramer wrote:
> hokein wrote:
> > I have a concern that
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
ioeric wrote:
> bkramer wrote:
> > hokein wrote:
> > > I
ioeric added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
hokein wrote:
> ioeric wrote:
> > bkramer wrote:
> > > h
baloghadamsoftware updated this revision to Diff 78352.
baloghadamsoftware added a comment.
Updated according to comments.
https://reviews.llvm.org/D25660
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/Iterat
echuraev created this revision.
echuraev added a reviewer: Anastasia.
echuraev added subscribers: cfe-commits, yaxunl, bader.
https://reviews.llvm.org/D26794
Files:
lib/Sema/SemaExpr.cpp
test/SemaOpenCL/blocks_with_arrays.cl
Index: test/SemaOpenCL/blocks_with_arrays.cl
=
aaron.ballman added inline comments.
Comment at: test/clang-tidy/readability-delete-null-pointer.cpp:7
+ int *p = 0;
+ if (p) {
+// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: 'if' statement is unnecessary;
deleting null pointer has no effect [readability-delete-null-pointer]
malcolm.parsons added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-default-member-init.rst:7
+This check converts a default constructor's member initializers into default
+member initializers. Other member initializers that match the default
+member initiali
bkramer updated this revision to Diff 78354.
bkramer added a comment.
- Turn loop into an assertions, there should never be more than one replacement
coming back.
https://reviews.llvm.org/D26752
Files:
include-fixer/CMakeLists.txt
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer
bkramer added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
ioeric wrote:
> hokein wrote:
> > ioeric wrote:
> > > b
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-default-member-init.rst:7
+This check converts a default constructor's member initializers into default
+member initializers. Other member initializers that match the default
+member initialize
baloghadamsoftware marked 10 inline comments as done.
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:209
+ CheckerContext &C) const {
+ const auto *Func = Call.getDecl()->getA
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
mgorny created this revision.
mgorny added reviewers: rsmith, compnerd, pcc, rengolin.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: dberris.
Use llvm::Triple::getArchTypeName() when looking for compiler-rt
libraries, rather than the exact arch string from the triple. This is
malcolm.parsons created this revision.
malcolm.parsons added a reviewer: aaron.ballman.
malcolm.parsons added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
https://reviews.llvm.org/D26798
Files:
docs/ModularizeUsage.rst
docs/clang-tidy/checks/cppcoreguidelines-pro-type-cstyl
baloghadamsoftware marked 2 inline comments as done.
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D25660#590778, @NoQ wrote:
> - Agree on the `evalAssume()` implementation (i'm still not quite
> understanding what the problem is here, see the new inline comments);
I think it
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D26798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: malcolm.parsons
Date: Thu Nov 17 08:26:45 2016
New Revision: 287226
URL: http://llvm.org/viewvc/llvm-project?rev=287226&view=rev
Log:
[docs] Remove doubled spaces
Reviewers: aaron.ballman
Subscribers: nemanjai, cfe-commits
Differential Revision: https://reviews.llvm.org/D26798
Modified
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287226: [docs] Remove doubled spaces (authored by
malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26798?vs=78361&id=78362#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26798
baloghadamsoftware added a comment.
DO I have to apply your path over patch and update the diff?
https://reviews.llvm.org/D22374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons updated this revision to Diff 78363.
malcolm.parsons added a comment.
Remove doubled spaces
https://reviews.llvm.org/D26750
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
clang-ti
jroelofs added a comment.
Testcase?
https://reviews.llvm.org/D26796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bettinson created this revision.
bettinson added reviewers: rsmith, aaron.ballman.
bettinson added a subscriber: cfe-commits.
Fix PR 30828. ` __attribute__((notnull))` was not inheritable in the
redefinition of a function. This is because attribute NonNull wasn't
`InheritableParamAttr`, it was `
Author: abataev
Date: Thu Nov 17 09:12:05 2016
New Revision: 287227
URL: http://llvm.org/viewvc/llvm-project?rev=287227&view=rev
Log:
[OPENMP] Fixed codegen for 'omp cancel' construct.
If 'omp cancel' construct is used in a worksharing construct it may
cause hanging of the software in case if red
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287228: [include-fixer] Refactor include fixer to be usable
as a plugin (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D26752?vs=78354&id=78366#toc
Repository:
rL LLVM
https://
Author: d0k
Date: Thu Nov 17 09:16:05 2016
New Revision: 287228
URL: http://llvm.org/viewvc/llvm-project?rev=287228&view=rev
Log:
[include-fixer] Refactor include fixer to be usable as a plugin
- Refactor the external sema source into a visible class
- Add support for emitting FixIts
- Wrap up in
Author: d0k
Date: Thu Nov 17 09:22:36 2016
New Revision: 287229
URL: http://llvm.org/viewvc/llvm-project?rev=287229&view=rev
Log:
Link include-fixer into libclang if clang-tools-extra is checked out.
include-fixer only slightly bloats the size of libclang, but since
libclang has no explicit plugi
Author: d0k
Date: Thu Nov 17 09:23:06 2016
New Revision: 287230
URL: http://llvm.org/viewvc/llvm-project?rev=287230&view=rev
Log:
[include-fixer] Add a test for the full round trip through libclang and the
plugin.
Added:
clang-tools-extra/trunk/test/include-fixer/yamldb_plugin.cpp
Added: cl
gnzlbg added a comment.
ping
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny updated this revision to Diff 78370.
mgorny added a comment.
Updated expected output for existing tests and added an additional test to
linux-ld.c.
https://reviews.llvm.org/D26796
Files:
lib/Driver/ToolChain.cpp
test/Driver/Inputs/basic_linux_tree/usr/i686-unknown-linux/lib/.keep
jroelofs added inline comments.
Comment at: test/Driver/print-libgcc-file-name-clangrt.c:11
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-I686 %s
-// CHECK-CLANGRT-I686: libclang_rt.builtins-i686.a
+// CHECK-CLANGRT-I686: libclang_rt.builtins-i386.a
This CH
rnk added a comment.
In https://reviews.llvm.org/D24289#598169, @rsmith wrote:
> This is causing warnings to fire for headers shared between C and C++, where
> the "give the enum an unsigned underlying type" advice doesn't work, and
> where the code in question will never be built for the MS AB
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM,
assuming you have verified that the test is still executed.
https://reviews.llvm.org/D26763
___
cfe-commits mailing list
cfe-commits@lists.llvm.
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:423
+
+void IteratorPastEndChecker::handleComparison(CheckerContext &C,
+ const SVal &LVal,
baloghadamsoftware wrote:
Author: compnerd
Date: Thu Nov 17 11:10:54 2016
New Revision: 287238
URL: http://llvm.org/viewvc/llvm-project?rev=287238&view=rev
Log:
Sema: correct typo correction for ivars in @implementation
The previous typo correction handling assumed that ivars are only declared in
the interface declaration
malcolm.parsons accepted this revision.
malcolm.parsons added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
dtarditi updated this revision to Diff 78375.
dtarditi added a comment.
The parameter array needed to be initialized so that assignments involving
unique pointers work properly. The memory could be uninitialized according to
C++ semantics.. Visual C++ was zeroing the memory and GCC was not. T
mgorny added inline comments.
Comment at: test/Driver/print-libgcc-file-name-clangrt.c:11
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-I686 %s
-// CHECK-CLANGRT-I686: libclang_rt.builtins-i686.a
+// CHECK-CLANGRT-I686: libclang_rt.builtins-i386.a
jroelofs
On 17 Nov 2016 8:56 am, "Reid Kleckner" wrote:
rnk added a comment.
In https://reviews.llvm.org/D24289#598169, @rsmith wrote:
> This is causing warnings to fire for headers shared between C and C++,
where the "give the enum an unsigned underlying type" advice doesn't work,
and where the code in
amehsan updated the summary for this revision.
amehsan updated this revision to Diff 78376.
https://reviews.llvm.org/D26544
Files:
lib/Headers/altivec.h
test/CodeGen/builtins-ppc-altivec.c
test/CodeGen/builtins-ppc-p8vector.c
test/CodeGen/builtins-ppc-quadword.c
test/CodeGen/builtins-pp
amehsan added inline comments.
Comment at: lib/Driver/ToolChains.cpp:2799-2807
+ switch (getArch()) {
+ case llvm::Triple::x86_64:
+return getTriple().isOSWindows();
+ case llvm::Triple::ppc64:
+ case llvm::Triple::ppc64le:
+return !getTriple().isOSBinFormatMachO() &&
Author: malcolm.parsons
Date: Thu Nov 17 11:52:58 2016
New Revision: 287241
URL: http://llvm.org/viewvc/llvm-project?rev=287241&view=rev
Log:
Use unique_ptr for cached tokens for default arguments in C++.
Summary:
This changes pointers to cached tokens for default arguments in C++ from raw
point
CaseyCarter marked an inline comment as done.
CaseyCarter added a comment.
> Do these tests pass with the current `` implementation, or will they
> have to wait?
These tests **do not pass** without making the changes required in P0504R0 to
`` and ``. (Interestingly is unaffected; its use of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287241: Use unique_ptr for cached tokens for default
arguments in C++. (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26435?vs=78375&id=78380#toc
Repository:
rL LLV
mgorny updated this revision to Diff 78378.
mgorny marked 2 inline comments as done.
mgorny added a comment.
Updated the -print-libgcc-file-name test name. Additionally, I've added another
subvariant of that test using i686-* target to ensure that the mapping works
for that function too, in case
CaseyCarter updated this revision to Diff 78379.
CaseyCarter marked an inline comment as done.
CaseyCarter added a comment.
Don't `STATIC_ASSERT`; `static_assert`.
https://reviews.llvm.org/D26782
Files:
test/std/utilities/any/any.class/any.cons/in_place_type.pass.cpp
test/std/utilities/any/
Anastasia added a comment.
I have created a bug to Khronos regarding this, but unfortunately I don't see
it being progressed yet.
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15659
The problem here is that I am not sure we should deviate from the ObjC
implementation because OpenCL blocks ar
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ProgramState.cpp:542
+if (!visitor.VisitSymbol(*SI))
+ Result = false;
}
I guess we should break the loop here.
https://reviews.llvm.org/D26773
___
anemet created this revision.
anemet added a reviewer: hfinkel.
anemet added a subscriber: cfe-commits.
https://reviews.llvm.org/D26807
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ lib/
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ProgramState.cpp:535
+if (!isa(*SI))
+ continue;
Hmm, the original code does actually visit non-SymbolData.
https://reviews.llvm.org/D26773
mgorny added a comment.
I did, even twice ;-). Thanks.
https://reviews.llvm.org/D26763
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mren
Date: Thu Nov 17 12:41:18 2016
New Revision: 287244
URL: http://llvm.org/viewvc/llvm-project?rev=287244&view=rev
Log:
ObjC Module: try to make objc module deterministic.
Make sure that comparing selectors in DeclarationName does its job.
rdar://problem/28988750
Added:
cfe/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287245: [tests] Use __SSE2__ (rather than __i686__...) for
SSE2 ASAN test (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D26763?vs=78245&id=78391#toc
Repository:
rL LLVM
htt
jlebar added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:479
+// the device toolchain we create depends on both.
+ToolChain *&CudaTC = ToolChains[CudaTriple.str() + "/" + HostTriple.str()];
+if (!CudaTC) {
sfantao wrote:
> I am not sure I
ddcc updated this revision to Diff 78392.
ddcc added a comment.
Fix visitation, add early termination, add comments
https://reviews.llvm.org/D26773
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
lib/StaticAnalyzer/Core/ProgramState.cpp
Index: lib/StaticAnalyzer/Core
ddcc added a comment.
I believe you're correct, the original code terminates early because of the
short circuit evaluation on line 553, and visits all reachable nodes but
doesn't recurse on non-SymbolData.
https://reviews.llvm.org/D26773
___
cfe-c
EricWF added a comment.
@rsmith ping. This is kind-of blocking making libc++'s tag types not
constructible from `{}`.
https://reviews.llvm.org/D25654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
On 17 November 2016 at 09:52, Malcolm Parsons via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: malcolm.parsons
> Date: Thu Nov 17 11:52:58 2016
> New Revision: 287241
>
> URL: http://llvm.org/viewvc/llvm-project?rev=287241&view=rev
> Log:
> Use unique_ptr for cached tokens for defaul
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. This patch misses `any.modifiers/emplace.pass.cpp` but I'll fix that up
and commit with the libc++ changes!
https://reviews.llvm.org/D26782
__
Author: ericwf
Date: Thu Nov 17 13:23:35 2016
New Revision: 287249
URL: http://llvm.org/viewvc/llvm-project?rev=287249&view=rev
Log:
Test changes for P0504R0 "Revisiting in-place tag types for
any/optional/variant". Patch from Casey Carter
Modified:
libcxx/trunk/test/std/utilities/any/any.c
Author: ericwf
Date: Thu Nov 17 13:24:04 2016
New Revision: 287250
URL: http://llvm.org/viewvc/llvm-project?rev=287250&view=rev
Log:
Implement P0504R0: Revisiting in-place tag types for any/optional/variant
Modified:
libcxx/trunk/include/any
libcxx/trunk/include/utility
Modified: libcxx/
Author: ericwf
Date: Thu Nov 17 13:24:34 2016
New Revision: 287251
URL: http://llvm.org/viewvc/llvm-project?rev=287251&view=rev
Log:
Remove files missed in r287250
Removed:
libcxx/trunk/test/libcxx/utilities/utility/utility.inplace/
___
cfe-commits
EricWF closed this revision.
EricWF added a comment.
r287249. Thanks again!
https://reviews.llvm.org/D26782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/AST/DeclCXX.cpp:564
+// C++1z [dcl.init.aggr]p1:
+// - no user-provided, explicit, or inherited constructors,
+if (getASTContext().getLangOpts().CPlusPlus1z && Constructor->isExplicit())
rsmith wrote:
> D
ahatanak created this revision.
ahatanak added reviewers: doug.gregor, spyffe.
ahatanak added a subscriber: cfe-commits.
This patch fixes an assert in CodeGenFunction::EmitCallExprLValue that is
triggered when the CallExpr's return type is not a reference type:
assert(E->getCallReturnType(getCon
a.sidorin updated this revision to Diff 78382.
a.sidorin added a comment.
Address review comments; fix tests.
https://reviews.llvm.org/D26753
Files:
include/clang/AST/TemplateBase.h
lib/AST/ASTImporter.cpp
test/ASTMerge/class-template-partial-spec/Inputs/class-template-partial-spec1.cpp
a.sidorin added a comment.
Thank you! I'll update this review again when I have a test for
NestedNameSpecifierLocs.
Comment at: lib/AST/ASTImporter.cpp:458
+ }
+ return true;
+}
spyffe wrote:
> Is this really an appropriate default result? I would argue for
mayurpandey updated this revision to Diff 78390.
mayurpandey added a comment.
Hi,
Updated the patch to incorporate the review comments. I had missed adding
ValArg->getType() when emitting the diagnostic which was cauing the crash.
Testing done, no regressions.
Thanks,
Mayur
https://reviews.l
Author: ericwf
Date: Thu Nov 17 14:08:43 2016
New Revision: 287255
URL: http://llvm.org/viewvc/llvm-project?rev=287255&view=rev
Log:
Workaround compilers w/o C++1z inline variables
Modified:
libcxx/trunk/include/__config
libcxx/trunk/include/utility
Modified: libcxx/trunk/include/__confi
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM with nits
Comment at: lib/Sema/SemaChecking.cpp:110
+S.Diag(ValArg->getLocStart(), diag::err_typecheck_cond_expect_float)
+ << ValArg->getType() << ValArg->
ahatanak updated this revision to Diff 78399.
ahatanak added a comment.
Address Alex's review comments.
Define a static function for setting SrcAlign.
https://reviews.llvm.org/D21099
Files:
lib/Sema/SemaChecking.cpp
test/Sema/warn-cast-align.c
Index: test/Sema/warn-cast-align.c
=
On Thu, Nov 17, 2016 at 9:52 AM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 17 Nov 2016 8:56 am, "Reid Kleckner" wrote:
>> In https://reviews.llvm.org/D24289#598169, @rsmith wrote:
>>> This is causing warnings to fire for headers shared between C and C++,
>>> where the
krasin updated this revision to Diff 78405.
krasin added a comment.
sync
https://reviews.llvm.org/D26560
Files:
test/ubsan/TestCases/TypeCheck/null.cpp
Index: test/ubsan/TestCases/TypeCheck/null.cpp
===
--- test/ubsan/TestCases
Author: malcolm.parsons
Date: Thu Nov 17 15:00:09 2016
New Revision: 287258
URL: http://llvm.org/viewvc/llvm-project?rev=287258&view=rev
Log:
Fixes for r287241. Use placement new. Apply clang-format.
Modified:
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
cfe/trunk/lib/Sema/DeclSpec.cpp
cfe/tr
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
EricWF updated this revision to Diff 78410.
EricWF added a comment.
OK, I've applied the fix to C++11 and C++14. Although the
inheriting-constructor part still only matters in C++1z since it requires
having base classes.
I also fixed aggregate initialization for types with non-aggregate base
c
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM, with couple of minor nits.
Comment at: clang/lib/Driver/Driver.cpp:3650-3654
+
+ // Intentionally omitted from the switch above: llvm::Triple::CUDA. CUDA
+ // compiles alw
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] In random tests, use real static_asserts and silence a warning.
One test triggers MSVC's warning C4310 "cast truncates constant value".
The code is valid, and y
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] allocator is non-Standard.
N4582 17.6.3.5 [allocator.requirements] says that allocators are given
cv-unqualified object types, and N4582 20.9.9 [default.allocat
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
[libcxx] [test] Change ifstream constructor tests to handle read-only files.
Certain source control systems like to set the read-only bit o
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix an assumption about the state of moved-from std::functions.
The Standard doesn't provide any guarantees beyond "valid but unspecified" for
moved-from std::f
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix non-Standard assumptions when testing sample().
sample() isn't specified with a reproducible algorithm, so expecting
exact output is non-Standard. Mark thos
Author: bruno
Date: Thu Nov 17 15:41:22 2016
New Revision: 287262
URL: http://llvm.org/viewvc/llvm-project?rev=287262&view=rev
Log:
[CrashReproducer][Darwin] Suggest attaching .crash diagnostic file
In addition to the preprocessed sources file and reproducer script, also
point to the .crash diagn
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Very nice! LGTM
https://reviews.llvm.org/D25949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: bruno
Date: Thu Nov 17 16:45:31 2016
New Revision: 287275
URL: http://llvm.org/viewvc/llvm-project?rev=287275&view=rev
Log:
[Preprocessor] Support for '-dI' flag
Re-introduce r285411.
Implement the -dI as supported by GCC: Output ‘#include’ directives in addition
to the result of preproc
SilverGeri added inline comments.
Comment at: test/clang-tidy/readability-delete-null-pointer.cpp:7
+ int *p = 0;
+ if (p) {
+// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: 'if' statement is unnecessary;
deleting null pointer has no effect [readability-delete-null-pointer]
--
1 - 100 of 155 matches
Mail list logo
