[PATCH] D26611: Protect test for dynarray under libcpp-no-exceptions

2016-11-24 Thread Roger Ferrer Ibanez via cfe-commits
rogfer01 added a comment. Ping? https://reviews.llvm.org/D26611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26612: Protect std::string tests under libcpp-no-exceptions

2016-11-24 Thread Roger Ferrer Ibanez via cfe-commits
rogfer01 added a comment. Ping? https://reviews.llvm.org/D26612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27059: [clang-move] Enable dump all declarations in old header.

2016-11-24 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287863: [clang-move] Enable dump all declarations in old header. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D27059?vs=79194=79201#toc Repository: rL LLVM

[clang-tools-extra] r287863 - [clang-move] Enable dump all declarations in old header.

2016-11-24 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Nov 24 04:17:17 2016 New Revision: 287863 URL: http://llvm.org/viewvc/llvm-project?rev=287863=rev Log: [clang-move] Enable dump all declarations in old header. Summary: * Add -dump_dels option to dump all declarations from old header. It will allow clang-move used as a

r287859 - [ASTDumper] Add some more character escapes for convenience.

2016-11-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Nov 24 03:41:33 2016 New Revision: 287859 URL: http://llvm.org/viewvc/llvm-project?rev=287859=rev Log: [ASTDumper] Add some more character escapes for convenience. Modified: cfe/trunk/lib/AST/Expr.cpp cfe/trunk/test/Misc/ast-dump-wchar.cpp Modified:

[PATCH] D27059: [clang-move] Enable dump all declarations in old header.

2016-11-24 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 79194. hokein marked 2 inline comments as done. hokein added a comment. Add comments && Update test. https://reviews.llvm.org/D27059 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/ClangMoveMain.cpp

[PATCH] D27059: [clang-move] Enable dump all declarations in old header.

2016-11-24 Thread Eric Liu via cfe-commits
ioeric added a comment. LG with a nit. Comment at: clang-move/tool/ClangMoveMain.cpp:155 + // Don't print trailing "," at the end of last element. + if (DeclPair != *(--Declarations.end())) +llvm::outs() << ",\n"; This check is run in each

[PATCH] D27099: [OpenCL] Prohibit using reserve_id_t in program scope.

2016-11-24 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. Btw, Spec v2.0 s6.9.p seems to mention other types as well! Comment at: lib/Sema/SemaDecl.cpp:5923 + if (getLangOpts().OpenCL && (NULL == S->getParent())) { +if (R->isReserveIDT()) { - Could we combine with the OpenCL check

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

2016-11-24 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:204 + CheckerContext ) const { + const auto *ThisExpr = COCE->getArg(0); + baloghadamsoftware wrote: > NoQ

Re: Upgrade and fix clang-format-vs

2016-11-24 Thread Zachary Turner via cfe-commits
I would use the first solution. We lock ourselves to specific versions of vs, so i think it's fine to do the same with the assemblies and deal with it only when we upgrade On Thu, Nov 24, 2016 at 11:29 AM Antonio Maiorano wrote: > Hi Hans, > > I saw that on September 15th,

[libcxx] r287865 - Protect std::string tests under libcpp-no-exceptions

2016-11-24 Thread Roger Ferrer Ibanez via cfe-commits
Author: rogfer01 Date: Thu Nov 24 05:15:09 2016 New Revision: 287865 URL: http://llvm.org/viewvc/llvm-project?rev=287865=rev Log: Protect std::string tests under libcpp-no-exceptions Skip tests that expect an exception be thrown and/or disable unreachable catch handlers. Differential Revision:

[PATCH] D26608: Protect std::string tests under libcpp-no-exceptions

2016-11-24 Thread Roger Ferrer Ibanez via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287865: Protect std::string tests under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D26608?vs=77805=79206#toc Repository: rL LLVM

[PATCH] D27093: Protect std::{, unordered_}map tests under noexceptions

2016-11-24 Thread Roger Ferrer Ibanez via cfe-commits
rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Skip tests that use exceptions https://reviews.llvm.org/D27093 Files: test/std/containers/associative/map/map.access/at.pass.cpp

[PATCH] D26608: Protect std::string tests under libcpp-no-exceptions

2016-11-24 Thread Roger Ferrer Ibanez via cfe-commits
rogfer01 reopened this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Somehow I managed to get this wrong. The right review is in https://reviews.llvm.org/D26612 Repository: rL LLVM https://reviews.llvm.org/D26608

[PATCH] D26762: Add a method to obtain this SVal of a method that created given StackFrameCtx

2016-11-24 Thread Krzysztof Wiśniewski via cfe-commits
k-wisniewski updated this revision to Diff 79213. k-wisniewski added a comment. I have added method for getting Objective-C message receivers (as it is related somewhat). This might however be broken for super calls as @NoQ told me as I was writing this comment. @dcoughlin - yes, there are

[libcxx] r287866 - Protect tests for std::uninitialized_{copy, fill} under libcpp-no-exceptions

2016-11-24 Thread Roger Ferrer Ibanez via cfe-commits
Author: rogfer01 Date: Thu Nov 24 05:17:09 2016 New Revision: 287866 URL: http://llvm.org/viewvc/llvm-project?rev=287866=rev Log: Protect tests for std::uninitialized_{copy,fill} under libcpp-no-exceptions Skip tests that expect an exception be thrown. Differential Revision:

[PATCH] D27091: Add the way to extract SVals of arguments used in a call for a given StackFrameCtx

2016-11-24 Thread Krzysztof Wiśniewski via cfe-commits
k-wisniewski created this revision. k-wisniewski added reviewers: NoQ, zaks.anna, dcoughlin, a.sidorin. k-wisniewski added subscribers: cfe-commits, NoQ. his patch adds getArgsSVal method to ProgramState that allows the user to obtain SVals of argumetns used in a call that created the given

r287872 - [PPC] support for arithmetic builtins in the FE

2016-11-24 Thread Ehsan Amiri via cfe-commits
Author: amehsan Date: Thu Nov 24 06:40:04 2016 New Revision: 287872 URL: http://llvm.org/viewvc/llvm-project?rev=287872=rev Log: [PPC] support for arithmetic builtins in the FE (commit again after fixing the buildbot failures) This adds various overloads of the following builtins to altivec.h:

[PATCH] D27095: Protect std::array tests under noexceptions

2016-11-24 Thread Roger Ferrer Ibanez via cfe-commits
rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Skip tests that expect exceptions be thrown. https://reviews.llvm.org/D27095 Files: test/std/containers/sequences/array/at.pass.cpp Index:

[PATCH] D27090: Add LocationContext as a parameter to checkRegionChanges

2016-11-24 Thread Krzysztof Wiśniewski via cfe-commits
k-wisniewski created this revision. k-wisniewski added reviewers: zaks.anna, dcoughlin, NoQ, a.sidorin. k-wisniewski added subscribers: cfe-commits, zaks.anna. This patch adds LocationContext to checkRegionChanges. This patch has been distilled out from other changes that I'll add separately.

[PATCH] D27092: Add RecursionChecker for finding infinite recursion

2016-11-24 Thread Krzysztof Wiśniewski via cfe-commits
k-wisniewski created this revision. k-wisniewski added reviewers: zaks.anna, dcoughlin, NoQ, a.sidorin. k-wisniewski added a subscriber: cfe-commits. Herald added a subscriber: mgorny. This patch adds RecursionChecker for finding infinite recursion. I have refactored the checker quite thoroughly

[PATCH] D26896: [libcxx] Make constexpr char_traits and char_traits

2016-11-24 Thread Anton Bikineev via cfe-commits
AntonBikineev updated this revision to Diff 79218. AntonBikineev added a comment. Support gcc's __builtin_memcpy, memchr, strlen https://reviews.llvm.org/D26896 Files: include/__config include/__string

[libcxx] r287868 - Reverting wrong diff

2016-11-24 Thread Roger Ferrer Ibanez via cfe-commits
Author: rogfer01 Date: Thu Nov 24 05:28:02 2016 New Revision: 287868 URL: http://llvm.org/viewvc/llvm-project?rev=287868=rev Log: Reverting wrong diff I managed to confuse me with two reviews of the same thing and ended commiting the wrong one. Modified:

some bugs fixed in altivec.h

2016-11-24 Thread Zeson Wu via cfe-commits
It's mainly about signed and unsigned llvm builtins confusion. When function args are bool vector and signed vector, it should be mapped to signed version instruction. reference: http://www.nxp.com/assets/documents/data/en/reference- manuals/ALTIVECPIM.pdf -- Zeson altivec-header.patch

[PATCH] D27099: [OpenCL] Prohibit using reserve_id_t in program scope.

2016-11-24 Thread Egor Churaev via cfe-commits
echuraev created this revision. echuraev added a reviewer: Anastasia. echuraev added subscribers: bader, yaxunl, cfe-commits. https://reviews.llvm.org/D27099 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/SemaOpenCL/event_t.cl

[PATCH] D26896: [libcxx] Make constexpr char_traits and char_traits

2016-11-24 Thread Anton Bikineev via cfe-commits
AntonBikineev marked 2 inline comments as done. AntonBikineev added inline comments. Comment at: include/__config:925 +#if !__has_builtin(__builtin_memcpy) +#define _LIBCPP_HAS_NO_BUILTIN_MEMCPY EricWF wrote: > What about GCC? Surely it implements some if not

[PATCH] D27104: Unify and simplify the behavior of the hasDeclaration matcher.

2016-11-24 Thread Manuel Klimek via cfe-commits
klimek created this revision. klimek added reviewers: rsmith, lukasza. klimek added a subscriber: cfe-commits. Originally, we weren't able to match on Type nodes themselves (only QualType), so the hasDeclaration matcher was initially written to give what we thought are reasonable results for

r287892 - [Format] Avoid copying std::sets and simplify code a bit.

2016-11-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Nov 24 09:42:29 2016 New Revision: 287892 URL: http://llvm.org/viewvc/llvm-project?rev=287892=rev Log: [Format] Avoid copying std::sets and simplify code a bit. No functional change. Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp

r287890 - [Sema] Pass APSInts by const ref, avoiding copies.

2016-11-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Nov 24 09:36:17 2016 New Revision: 287890 URL: http://llvm.org/viewvc/llvm-project?rev=287890=rev Log: [Sema] Pass APSInts by const ref, avoiding copies. No functionality change intended. Fix by clang-tidy's performance-unnecessary-value-param check. Modified:

r287894 - [CodeGen] Pass objects that are expensive to copy by const ref.

2016-11-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Nov 24 10:01:20 2016 New Revision: 287894 URL: http://llvm.org/viewvc/llvm-project?rev=287894=rev Log: [CodeGen] Pass objects that are expensive to copy by const ref. No functionality change. Found by clang-tidy's performance-unnecessary-value-param. Modified:

[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

2016-11-24 Thread Anastasia Stulova via cfe-commits
Anastasia created this revision. Anastasia added a reviewer: yaxunl. Anastasia added a subscriber: cfe-commits. Clang performs some optimizations/shortcuts for const qualified aggregate variables while generating them on the stack. It bypasses the generation of alloca instructions and their