NoQ commandeered this revision.
NoQ added a reviewer: k-wisniewski.
NoQ added a comment.
Seems to become outdated with https://reviews.llvm.org/D27090.
https://reviews.llvm.org/D26588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
NoQ commandeered this revision.
NoQ added a reviewer: k-wisniewski.
NoQ added a comment.
Seems to become outdated with https://reviews.llvm.org/D27092.
https://reviews.llvm.org/D26589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
NoQ commandeered this revision.
NoQ edited reviewers, added: k-wisniewski; removed: NoQ.
NoQ added a comment.
Seems to become outdated with https://reviews.llvm.org/D27091.
https://reviews.llvm.org/D26760
___
cfe-commits mailing list
cfe-commits@lis
NoQ added a comment.
Hmm, i'm thinking of just the opposite - refactor the CallEvent methods to use
the respective new ProgramState methods.
This way we'd avoid touching the CallEvent allocator for a simple Environment
lookup, while still avoiding code duplication.
https://reviews.llvm.org/D2
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D27248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
ioeric added a comment.
Ping.
Daniel, could you take a look? Manuel and I would like your opinion on this.
https://reviews.llvm.org/D27054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276
+// Virtual method overrides of dependent types cannot be recognized unless they
+// are marked as override or final. Test that check is not triggered on methods
+// mar
djasper added inline comments.
Comment at: include/clang/Tooling/Refactoring/EditList.h:41
+ /// \brief Creates an edit list for a key position.
+ EditList(const SourceManager &SM, SourceLocation KeyPosition);
+
I wonder whether we should always use a SourceLoc
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D27084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
fpetrogalli created this revision.
fpetrogalli added a reviewer: cfe-commits.
This patch generates a list of global external variables that are
passed to the llvm::TargetLibraryInfo (TLI) to enable the vectorization of
loops containing calls to function that are marked with a #pragma omp
declare s
arphaman added a comment.
In https://reviews.llvm.org/D26922#608815, @ahatanak wrote:
> Yes, I meant ParseDecl:5266. Reading the comment in
> ShouldEnterDeclaratorScope, it seemed to me that it shouldn't return true in
> this context (when parsing an objective-c).
>
> Also, the following code (
arphaman added a comment.
In https://reviews.llvm.org/D26922#608815, @ahatanak wrote:
> Yes, I meant ParseDecl:5266. Reading the comment in
> ShouldEnterDeclaratorScope, it seemed to me that it shouldn't return true in
> this context (when parsing an objective-c).
Yes, I agree that it's bette
Zeson created this revision.
Zeson added reviewers: nemanjai, sfertile, jtony, hfinkel, syzaara, lei,
kbarton.
Zeson added a subscriber: cfe-commits.
It's mainly about signed and unsigned llvm builtins confusion.
When function args are bool vector and signed vector, it should be mapped to
signed
ioeric updated this revision to Diff 79716.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D27054
Files:
include/clang/Tooling/Refactoring/EditList.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Refactoring/CMakeLists.txt
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/EditList.h:41
+ /// \brief Creates an edit list for a key position.
+ EditList(const SourceManager &SM, SourceLocation KeyPosition);
+
djasper wrote:
> I wonder whether we should always
rogfer01 created this revision.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Replace throw with TEST_THROW and protect tests that do throw. Also add missing
assert(false).
https://reviews.llvm.org/D27252
Files:
test/std/containers/sequen
rogfer01 created this revision.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown.
https://reviews.llvm.org/D27253
Files:
test/std/thread/futures/futures.promise/move_assign.pass.cpp
Index: test/s
rogfer01 created this revision.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Replace throw with TEST_THROW and skip tests that throw exceptions
https://reviews.llvm.org/D27254
Files:
test/std/experimental/optional/optional.specalg/swap.pas
rogfer01 created this revision.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip test that throws an exception.
https://reviews.llvm.org/D27255
Files:
test/std/input.output/iostream.format/output.streams/ostream_sentry/destruct.pass.cpp
arphaman updated this revision to Diff 79722.
arphaman added a comment.
The updated patch performs the check in `ShouldEnterDeclaratorScope`.
Repository:
rL LLVM
https://reviews.llvm.org/D26922
Files:
lib/Parse/ParseDecl.cpp
lib/Sema/SemaCXXScopeSpec.cpp
test/SemaObjCXX/crash.mm
Inde
arphaman added a comment.
> Also, the following code (which is not valid) crashes with ToT trunk,
>
> @property (nonatomic) int OuterType::InnerType
>
>
> but compiles without any errors with your patch applied. Do you know why
> clang doesn't error out?
This worked because clang continued
fhahn added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6521
+emitX86DeclareSimdFunction(const FunctionDecl *FD,
+llvm::APSInt VLENVal,
+ArrayRef ParamAttrs,
Stray space
C
klimek added inline comments.
Comment at: include/clang/Tooling/Refactoring/EditList.h:41
+ /// \brief Creates an edit list for a key position.
+ EditList(const SourceManager &SM, SourceLocation KeyPosition);
+
ioeric wrote:
> djasper wrote:
> > I wonder whethe
ABataev requested changes to this revision.
ABataev added a comment.
This revision now requires changes to proceed.
1. Please provide full context for your changes (check this document how to do
this http://llvm.org/docs/Phabricator.html).
2. Use clang-format for all your changes.
3. Do not use b
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/EditList.h:41
+ /// \brief Creates an edit list for a key position.
+ EditList(const SourceManager &SM, SourceLocation KeyPosition);
+
klimek wrote:
> ioeric wrote:
> > djasper wrote:
>
nemanjai added a comment.
Thank you for fixing these issues. I certainly see how the shifts really need
to get the signedness right because the right shifts need to fill with the sign
bit (so that vector bool will still have all 0 or all 1 bits). However, I don't
really follow why the compariso
ioeric updated this revision to Diff 79728.
ioeric added a comment.
- Make key customize-able.
https://reviews.llvm.org/D27054
Files:
include/clang/Tooling/Refactoring/EditList.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Refactoring/CMakeLists.txt
lib/Tooling/Refactoring/EditList.cpp
uni
Zeson added a comment.
In https://reviews.llvm.org/D27251#609014, @nemanjai wrote:
> Thank you for fixing these issues. I certainly see how the shifts really need
> to get the signedness right because the right shifts need to fill with the
> sign bit (so that vector bool will still have all 0 o
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/EditList.h:41
+ /// \brief Creates an edit list for a key position.
+ EditList(const SourceManager &SM, SourceLocation KeyPosition);
+
ioeric wrote:
> klimek wrote:
> > ioeric wrote:
>
madsravn updated this revision to Diff 79729.
madsravn marked 3 inline comments as done.
madsravn added a comment.
Diff reflecting changes suggested by comments.
https://reviews.llvm.org/D27210
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/String
djasper added inline comments.
Comment at: include/clang/Tooling/Refactoring/EditList.h:41
+ /// \brief Creates an edit list for a key position.
+ EditList(const SourceManager &SM, SourceLocation KeyPosition);
+
ioeric wrote:
> ioeric wrote:
> > klimek wrote:
>
malcolm.parsons added inline comments.
Comment at: clang-tidy/misc/MiscStringCompareCheck.cpp:48
+ Finder->addMatcher(ifStmt(hasCondition(binaryOperator(hasOperatorName("=="),
+hasLHS(strCompare
+
malcolm.parsons added a subscriber: cfe-commits.
malcolm.parsons added a comment.
Always subscribe cfe-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D27142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
flx added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276
+// Virtual method overrides of dependent types cannot be recognized unless they
+// are marked as override or final. Test that check is not triggered on methods
+// marked with ove
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 79732.
flx marked an inline comment as done.
https://reviews.llvm.org/D27248
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index:
Author: d0k
Date: Wed Nov 30 08:37:40 2016
New Revision: 288244
URL: http://llvm.org/viewvc/llvm-project?rev=288244&view=rev
Log:
[include-fixer] Don't skip repeated lookups in plugin mode.
In this mode not all the errors are fixed so it doesn't make sense to
ignore later ones.
Modified:
cla
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/EditList.h:82-94
+ /// \brief Adds a replacement that inserts \p Text at \p Loc. If this
+ /// insertion conflicts with an existing insertion (at the same position),
+ /// this will be inserted before
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276
+// Virtual method overrides of dependent types cannot be recognized unless they
+// are marked as override or final. Test that check is not triggered on methods
+// mar
djasper added inline comments.
Comment at: include/clang/Tooling/Refactoring/EditList.h:82-94
+ /// \brief Adds a replacement that inserts \p Text at \p Loc. If this
+ /// insertion conflicts with an existing insertion (at the same position),
+ /// this will be inserted before
arphaman created this revision.
arphaman added reviewers: bruno, akyrtzi.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
Code completion results for class methods already include instance methods from
Objective-C root classes. This patch ensure
fpetrogalli updated this revision to Diff 79734.
fpetrogalli added a comment.
Rebase plus apply clang format.
https://reviews.llvm.org/D27250
Files:
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
test/OpenMP/declare_sim
ABataev requested changes to this revision.
ABataev added a comment.
This revision now requires changes to proceed.
You did just some minor changes. The main questions are still unanswered.
https://reviews.llvm.org/D27250
___
cfe-commits mailing lis
fpetrogalli marked 5 inline comments as done.
fpetrogalli added a comment.
I updated the comments related to code formatting.
https://reviews.llvm.org/D27250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM>
https://reviews.llvm.org/D27252
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D27255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
mclow.lists added inline comments.
Comment at: test/std/experimental/optional/optional.specalg/swap.pass.cpp:225
}
+#ifndef TEST_HAS_NO_EXCEPTIONS
{
Why is this here, and not before line L#236?
https://reviews.llvm.org/D27254
__
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D27253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
ioeric updated this revision to Diff 79736.
ioeric added a comment.
- Added replace() and insert() to replace current replacement interfaces.
https://reviews.llvm.org/D27054
Files:
include/clang/Tooling/Refactoring/EditList.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Refactoring/CMakeLists.t
fpetrogalli added a comment.
In https://reviews.llvm.org/D27250#609006, @ABataev wrote:
>
Hi! Thanks for your review!
> 1. Please provide full context for your changes (check this document how to
> do this http://llvm.org/docs/Phabricator.html).
I missed that out, should be done now.
> 2. U
fpetrogalli added a comment.
In https://reviews.llvm.org/D27250#609063, @ABataev wrote:
> You did just some minor changes. The main questions are still unanswered.
Hopefully now they are! :)
Francesco
https://reviews.llvm.org/D27250
___
cfe-comm
Hi Steven,
On Fri, Jun 3, 2016 at 2:36 PM, Steven Wu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi everyone
>
> I am still in the process of upstreaming some improvements to the embed
> bitcode option. If you want more background, you can read the previous RFC (
> http://lists.llvm.or
Anastasia closed this revision.
Anastasia added a comment.
Committed in r288163.
https://reviews.llvm.org/D27109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vangyzen added a comment.
> @EricWF Do you have time and interest to review this again?
I should ask, do you have time and interest to //commit// this?
https://reviews.llvm.org/D26979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D27142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
fhahn added a comment.
Ping.
https://reviews.llvm.org/D27066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Looks mostly good. A few more nits.
Comment at: include/clang/Tooling/Core/Diagnostic.h:68-71
+ /// A freeform chunk of text to describe the context of the replace
madsravn updated this revision to Diff 79747.
madsravn marked 2 inline comments as done.
madsravn added a comment.
Added integerLiteral on both sides of the == operator.
https://reviews.llvm.org/D27210
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/mis
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks good to me.
https://reviews.llvm.org/D27199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
malcolm.parsons added a comment.
I don't know why you're restricting this check to only match within the
condition of an if statement.
https://reviews.llvm.org/D27210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
jtony added inline comments.
Comment at: lib/Headers/altivec.h:16456
#ifdef __VSX__
static __inline__ vector signed long long __ATTRS_o_ai
Thanks a lot for your good catch for the macro issue in vec_xst_be, that's a
good catch. BTW, Can you move this up als
So remove the ifStmt from the third and fourth case?
So that I keep if(str1.compare(str2)) and if(!str1.compare(str2)), and
change the other two to str1.compare(str2) == 0 and str1.compare(str2) != 0
?
That makes good sense. Then I could also add some of the test cases you
mentioned earlier.
On
rogfer01 added inline comments.
Comment at: test/std/experimental/optional/optional.specalg/swap.pass.cpp:225
}
+#ifndef TEST_HAS_NO_EXCEPTIONS
{
mclow.lists wrote:
> Why is this here, and not before line L#236?
Yep, I'm wrong here. Probably a fallout o
rogfer01 updated this revision to Diff 79765.
rogfer01 added a comment.
Protect the right set of tests.
https://reviews.llvm.org/D27254
Files:
test/std/experimental/optional/optional.specalg/swap.pass.cpp
Index: test/std/experimental/optional/optional.specalg/swap.pass.cpp
=
jacobly created this revision.
jacobly added a subscriber: cfe-commits.
struct A {
struct {
int B : 1;
}
}
int A::*addr_anon_bitfield() {
return &A::B;
}
This code does not error, but instead returns a member pointer to a full int
that starts at the beginning of the b
On 30 November 2016 at 15:46, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Steven,
>
> On Fri, Jun 3, 2016 at 2:36 PM, Steven Wu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi everyone
>>
>> I am still in the process of upstreaming some improvements to the e
On 30 November 2016 at 17:18, Mads Ravn wrote:
> So remove the ifStmt from the third and fourth case?
I was thinking all cases.
Can the first case be restricted to casts to bool?
If not, keep the cast to int case with an ifStmt and add a cast to bool case.
Does it matter whether the cast is impli
danielcdh updated this revision to Diff 79770.
danielcdh added a comment.
change the flag name to -fprofile-debug
https://reviews.llvm.org/D25435
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CGDebugInfo.cpp
li
zaks.anna added a comment.
> Hmm, i'm thinking of just the opposite - refactor the CallEvent methods to
> use the respective new ProgramState methods.
>
> This way we'd avoid touching the CallEvent allocator for a simple Environment
> lookup, while still avoiding code duplication.
I see what
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Remove spurious semicolons.
https://reviews.llvm.org/D27266
Files:
test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size_hash_equal_allo
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int'
[or 'unsigned int'], possible loss of data", part 1/4.
Replace "int n = str_.size();" with "int n
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int'
[or 'unsigned int'], possible loss of data", part 2/4.
Use static_cast when storing size_t in int
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int'
[or 'unsigned int'], possible loss of data", part 3/4.
test/std/containers/sequences/vector.bool/
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int'
[or 'unsigned int'], possible loss of data", part 4/4.
Change a few allocators' size_type/differe
Author: dergachev
Date: Wed Nov 30 11:57:18 2016
New Revision: 288257
URL: http://llvm.org/viewvc/llvm-project?rev=288257&view=rev
Log:
[analyzer] Minor fixes and improvements to debug.ExprInspection
- Fix the bug with transition handling in ExprInspectionChecker's
checkDeadSymbols implementati
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288257: [analyzer] Minor fixes and improvements to
debug.ExprInspection (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D26835?vs=78468&id=79776#toc
Repository:
rL LLVM
ht
I think I got it. I will throw a new diff up within the hour.
Thanks for the ideas :)
On Wed, Nov 30, 2016 at 6:48 PM Malcolm Parsons
wrote:
> On 30 November 2016 at 17:18, Mads Ravn wrote:
> > So remove the ifStmt from the third and fourth case?
>
> I was thinking all cases.
> Can the first c
Author: jdevlieghere
Date: Wed Nov 30 12:06:42 2016
New Revision: 288258
URL: http://llvm.org/viewvc/llvm-project?rev=288258&view=rev
Log:
[clang-tidy] Make format style customizable
Summary: I came across an outstanding FIXME to make the format style
customizable. Inspired by the include fixer,
hans added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7439
+void Sema::ActOnDLLAttr(ClassTemplateSpecializationDecl *Def,
+InheritableAttr *Attr) {
+ // We reject explicit instantiations in class scope, so there should
smeenai
zaks.anna added a comment.
Artem just pointed out that I have "Smalls" instead of "SVals" in my first
comment.
https://reviews.llvm.org/D27091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: dergachev
Date: Wed Nov 30 12:26:43 2016
New Revision: 288260
URL: http://llvm.org/viewvc/llvm-project?rev=288260&view=rev
Log:
[analyzer] SValExplainer: Support ObjC ivars and __block variables.
Additionally, explain the difference between normal and heap-based
symbolic regions.
Added:
zaks.anna added a comment.
Thank you for doing this!!!
Artem, do you want to disallow the creation of successors from
checkRegionChanges callback or can this go in as is?
Anna.
Comment at: lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp:240
- /// #checkRegionChanges wh
zaks.anna added a comment.
Thank you! The assert definitely needs to be relaxed.
Would be great to add test cases that check if the analyzer models the vector
types correctly, not just that we do not crash. (Not a blocker, but would be
very useful.)
https://reviews.llvm.org/D27043
khazem added a comment.
Sorry for the late comment, but one of the tests that this introduces is
breaking on my end:
/usr/local/google/home/khazem/doc/llvm/tools/clang/test/ASTMerge/class-template-partial-spec.cpp:9:11:
error: expected string not found in input
// CHECK:
/media/build/smrc
spyffe marked 3 inline comments as done.
spyffe added a comment.
Thank you for your review, Vedant! I will update the patch to reflect your
comments in a moment.
> I'm concerned about the amount of covered-but-untested code this patch
> introduces. Since there are no CHECK lines, it's hard for
Author: dergachev
Date: Wed Nov 30 13:02:44 2016
New Revision: 288263
URL: http://llvm.org/viewvc/llvm-project?rev=288263&view=rev
Log:
[analyzer] Construct temporary objects of correct types, destroy them properly.
When constructing a temporary object region, which represents the result of
Mater
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288263: [analyzer] Construct temporary objects of correct
types, destroy them properly. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D26839?vs=79540&id=79783#toc
Repositor
NoQ abandoned this revision.
NoQ added a comment.
Decided to go ahead and commit as r288260.
https://reviews.llvm.org/D26836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added inline comments.
Comment at: lib/Frontend/FrontendActions.cpp:227
+IsBuiltin = true;
+ addHeaderInclude(H.NameAsWritten, Includes, LangOpts, Module->IsExternC,
+ IsBuiltin /*AlwaysInclude*/);
rsmith wrote:
> I don't
madsravn updated this revision to Diff 79788.
madsravn added a comment.
Trimmed down the ast matcher a little.
https://reviews.llvm.org/D27210
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringCompareCheck.cpp
clang-tidy/misc/StringCompareChe
sfertile added inline comments.
Comment at: lib/Driver/ToolChain.cpp:721-724
+
+const char *ToolChain::getDefaultLinker() const {
+ return CLANG_DEFAULT_LINKER;
+}
Hahnfeld wrote:
> I think this could go into the header
The CLANG_DEFAULT_LINKER macro is getting
On 30 November 2016 at 11:08, Bruno Cardoso Lopes via Phabricator via
cfe-commits wrote:
> > I suspect the problem is instead that #import just doesn't work properly
> with modules
>
> (specifically, either with local submodule visibility or with modules
> that do not export *),
> > because it do
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288267: [Sema] Teach -Wcast-align to look at the aligned
attribute of the (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D21099?vs=78594&id=79792#toc
Repository:
rL LLVM
h
Author: ahatanak
Date: Wed Nov 30 13:42:03 2016
New Revision: 288267
URL: http://llvm.org/viewvc/llvm-project?rev=288267&view=rev
Log:
[Sema] Teach -Wcast-align to look at the aligned attribute of the
declared variables.
Teach Sema to check the aligned attribute attached to variable
declarations
dim created this revision.
dim added reviewers: EricWF, emaste, mclow.lists, theraven.
dim added a subscriber: cfe-commits.
In https://reviews.llvm.org/rL275749 the old _LIBCPP_TRIVIAL_PAIR_COPY_CTOR
define was replaced
by _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR, which is also
auto-
dougk added a comment.
Suppression of sanitizing is necessary if the variable is magically a
memory-mapped device I/O address.
The linker can arrange for this to be the case using fancy scripts, or even
just as simple as a section attribute that requires that you take up exactly a
certain numbe
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Looks good now - thanks.
https://reviews.llvm.org/D27254
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: rjmccall
Date: Wed Nov 30 14:19:46 2016
New Revision: 288269
URL: http://llvm.org/viewvc/llvm-project?rev=288269&view=rev
Log:
Finish adopting ConstantInitBuilder in CGObjCGNU. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
cfe/trunk/lib/CodeGen/ConstantBuilder.h
Modified: c
george.burgess.iv added a comment.
Ping
https://reviews.llvm.org/D14274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rjmccall
Date: Wed Nov 30 14:46:55 2016
New Revision: 288272
URL: http://llvm.org/viewvc/llvm-project?rev=288272&view=rev
Log:
Prospective MSVC workaround.
Modified:
cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
URL:
http://llvm.org/viewvc/llvm-pr
rnk created this revision.
rnk added a reviewer: rsmith.
rnk added subscribers: cfe-commits, jmolloy.
This saves two pointers (!) from FunctionDecl that were being used for
some rare and questionable C-only functionality. The
DeclsInPrototypeScope ArrayRef was added in r151712 in order to parse
t
1 - 100 of 144 matches
Mail list logo
