[PATCH] D26082: Support for Python 3 in libclang python bindings

jbcoe added a comment. Sadly I can't run valgrind on macOS Sierra. I'll try and look at the effects of bindings/python/clang/cindex.py L181 in more detail today. Just out of curiosity, will you be using the Python 3 bindings for anything? If so what? Repository: rL LLVM https://reviews.ll

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

leanil created this revision. leanil added reviewers: alexfh, LegalizeAdulthood, xazax.hun. leanil added a subscriber: cfe-commits. leanil added a project: clang-tools-extra. Herald added a subscriber: JDevlieghere. modernize-raw-string-literal suggests to replace e.g.: std::string s{ "foo \""

[clang-tools-extra] r291892 - Fix the build of the include-fixer plugin for some shared cmake builds and MSVC.

Author: d0k Date: Fri Jan 13 04:14:07 2017 New Revision: 291892 URL: http://llvm.org/viewvc/llvm-project?rev=291892&view=rev Log: Fix the build of the include-fixer plugin for some shared cmake builds and MSVC. - The include fixer plugin does not directly depend on pthread, but can pick up pthrea

Re: [clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

Committed r291892. Should also resolve the bogus MSVC warnings. On Fri, Jan 13, 2017 at 12:00 AM, Bill Seurer via cfe-commits wrote: > On 01/10/2017 01:53 PM, Benjamin Kramer wrote: >> >> I didn't manage to reproduce this. Does adding ${PTHREAD_LIB} to >> LINK_LIBS of tools/clang/tools/extra/incl

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added a comment. In https://reviews.llvm.org/D28080#644222, @yaxunl wrote: > > @yaxunl Sam, I think it would be nice to describe your recent change for > > adding OpenCL extensions. Would you like to write up some text? Otherwise I > > can draft something and you can review. :) > > An

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

pekka.jaaskelainen accepted this revision. pekka.jaaskelainen added inline comments. This revision is now accepted and ready to land. Comment at: docs/UsersManual.rst:2130 + +- x86 is used by some implementations that are x86 compatible + (e.g. `POCL `_)

[PATCH] D28670: [ObjC] Disallow vector parameters and return values in Objective-C methods on older X86 targets

arphaman created this revision. arphaman added reviewers: gparker42, mehdi_amini, erik.pilkington. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds a new error that disallows methods that have parameters/return values with a vecto

[PATCH] D28671: [ASTMatchers] add typeAliasTemplateDecl matcher.

ioeric created this revision. ioeric added a reviewer: hokein. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D28671 Files: include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersNodeTest.cpp Index: unittests/ASTMatchers

[PATCH] D28671: [ASTMatchers] add typeAliasTemplateDecl matcher.

hokein added a comment. You also need to add a new generated document (`docs/LibASTMatchersReference.html`) for that. Please run `clang/docs/tools/dump_ast_matchers.py`, it will do the stuff for you. https://reviews.llvm.org/D28671 ___ cfe-commits

Re: r284890 - DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules.

On 22 Oct 2016, at 00:00, Richard Smith via cfe-commits wrote: > > Author: rsmith > Date: Fri Oct 21 17:00:42 2016 > New Revision: 284890 > > URL: http://llvm.org/viewvc/llvm-project?rev=284890&view=rev > Log: > DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules. > This

[PATCH] D28672: [ASTMatchers] update doc by running dump_ast_matchers.py

ioeric created this revision. ioeric added a reviewer: klimek. ioeric added a subscriber: cfe-commits. https://reviews.llvm.org/D28672 Files: docs/LibASTMatchersReference.html Index: docs/LibASTMatchersReference.html === --- docs/

[PATCH] D28467: [Sema] Add warning for unused lambda captures

aaron.ballman added inline comments. Comment at: test/SemaCXX/warn-unused-lambda-capture.cpp:86 + auto explicit_by_value_unused_sizeof = [i] { return sizeof(i); }; // expected-warning{{lambda capture 'i' is not required to be captured for use in an unevaluated context}} + aut

[PATCH] D28144: clang support for Mageia 6 distro

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D28144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D28334: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks useful to me. https://reviews.llvm.org/D28334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D28467: [Sema] Add warning for unused lambda captures

malcolm.parsons added inline comments. Comment at: test/SemaCXX/warn-unused-lambda-capture.cpp:86 + auto explicit_by_value_unused_sizeof = [i] { return sizeof(i); }; // expected-warning{{lambda capture 'i' is not required to be captured for use in an unevaluated context}} + a

[PATCH] D28467: [Sema] Add warning for unused lambda captures

aaron.ballman added inline comments. Comment at: test/SemaCXX/warn-unused-lambda-capture.cpp:86 + auto explicit_by_value_unused_sizeof = [i] { return sizeof(i); }; // expected-warning{{lambda capture 'i' is not required to be captured for use in an unevaluated context}} + aut

r291905 - [Sema] Add warning for unused lambda captures

Author: malcolm.parsons Date: Fri Jan 13 09:01:06 2017 New Revision: 291905 URL: http://llvm.org/viewvc/llvm-project?rev=291905&view=rev Log: [Sema] Add warning for unused lambda captures Summary: Warn when a lambda explicitly captures something that is not used in its body. The warning is part

[PATCH] D28467: [Sema] Add warning for unused lambda captures

This revision was automatically updated to reflect the committed changes. Closed by commit rL291905: [Sema] Add warning for unused lambda captures (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D28467?vs=84122&id=84305#toc Repository: rL LLVM https://review

Re: r284890 - DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules.

On 13 Jan 2017 4:40 am, "Dimitry Andric via cfe-commits" < cfe-commits@lists.llvm.org> wrote: On 22 Oct 2016, at 00:00, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: rsmith > Date: Fri Oct 21 17:00:42 2016 > New Revision: 284890 > > URL: http://llvm.org/viewvc/llvm

r291907 - Revert "Support for Python 3 in libclang python bindings"

Author: jbcoe Date: Fri Jan 13 10:06:59 2017 New Revision: 291907 URL: http://llvm.org/viewvc/llvm-project?rev=291907&view=rev Log: Revert "Support for Python 3 in libclang python bindings" This reverts commit 4464581bb63e9789e9ee231a8c8800be5f614743. Memory access issues on Linux were reported

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Has this been fixed upstream already? https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28467: [Sema] Add warning for unused lambda captures

malcolm.parsons added a comment. http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/1122/steps/bootstrap%20clang/logs/stdio /home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/llvm/lib/Analysis/ValueTracking.cpp:1116:17: error: lambda capture 'BitWidth' is not used [-Werro

[PATCH] D28467: [Sema] Add warning for unused lambda captures

arphaman added a comment. IMO, you can go ahead and commit a fix that removes the captures, and the fix can be reviewed post-commit. I don't think you should revert this patch as you'll have to remove the captures anyway before reinstating this patch, so might as well do it now. Repository:

[PATCH] D26082: Support for Python 3 in libclang python bindings

jbcoe added a comment. I've reverted this change and submitted https://reviews.llvm.org/D28682 to explicitly check the Python version. I'll pick this up again, I do want Python 3 support. Repository: rL LLVM https://reviews.llvm.org/D26082 ___

[PATCH] D28467: [Sema] Add warning for unused lambda captures

aaron.ballman added a comment. In https://reviews.llvm.org/D28467#645348, @malcolm.parsons wrote: > http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/1122/steps/bootstrap%20clang/logs/stdio > > > /home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/llvm/lib/Analysis/ValueTr

[PATCH] D28467: [Sema] Add warning for unused lambda captures

malcolm.parsons added a comment. There are quite a few of them! Repository: rL LLVM https://reviews.llvm.org/D28467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r291865 - Improve handling of instantiated thread_local variables in Itanium C++ ABI.

Merged in r291912. Thanks, Hans On Thu, Jan 12, 2017 at 5:50 PM, Richard Smith wrote: > This should go onto the 4.0 branch. > > -- Forwarded message -- > From: Richard Smith via cfe-commits > Date: 12 January 2017 at 16:43 > Subject: r291865 - Improve handling of instantiated th

Re: r291871 - Update C++ status pages for Clang 4 branch:

On Thu, Jan 12, 2017 at 4:57 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Jan 12 18:57:54 2017 > New Revision: 291871 > > URL: http://llvm.org/viewvc/llvm-project?rev=291871&view=rev > Log: > Update C++ status pages for Clang 4 branch: > > * Update version number in DR te

[PATCH] D28058: [OpenCL] Correct ndrange_t implementation

dmitry added a comment. @yaxunl, we already have the similar issue for atomics. Probably we can extend typedef semantic checks but I don't think it's a good idea since C and C++ have the similar problem but they don't provide special treatment for types from their standard libraries. I think th

[PATCH] D26082: Support for Python 3 in libclang python bindings

MathieuDuponchelle added a comment. In https://reviews.llvm.org/D26082#645361, @jbcoe wrote: > I've reverted this change and submitted https://reviews.llvm.org/D28682 to > explicitly check the Python version. > > I'll pick this up again, I do want Python 3 support. I'm not entirely sure why yo

r291917 - Use less byval on 32-bit Windows x86 for classes with bases

Author: rnk Date: Fri Jan 13 11:18:19 2017 New Revision: 291917 URL: http://llvm.org/viewvc/llvm-project?rev=291917&view=rev Log: Use less byval on 32-bit Windows x86 for classes with bases This comes up in V8, which has a Handle template class that wraps a typed pointer, and is frequently passed

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Ah no, my mistake. I had the patch applied when I ran the test. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane added a comment. I've actually figured out how to fix the diagnosis location. I switched the diagnosis to use the location of the actual [[deprecated]] attribute instead of the Declaration location. IMO, this is a BETTER note anyway (since the arrow points to the actual [[deprecate

r291919 - unique_ptrify createDriverOptTable

Author: dblaikie Date: Fri Jan 13 11:34:15 2017 New Revision: 291919 URL: http://llvm.org/viewvc/llvm-project?rev=291919&view=rev Log: unique_ptrify createDriverOptTable Modified: cfe/trunk/include/clang/Driver/Driver.h cfe/trunk/include/clang/Driver/Options.h cfe/trunk/lib/Driver/Dri

[libcxx] r291921 - Revert "Rework fix for PR19460 - Use explicit bool as an extension instead."

Author: ericwf Date: Fri Jan 13 12:03:46 2017 New Revision: 291921 URL: http://llvm.org/viewvc/llvm-project?rev=291921&view=rev Log: Revert "Rework fix for PR19460 - Use explicit bool as an extension instead." This reverts commit 3a1b90a866b6d5d62a5f37fbfb3a1ee36cc70dd1. Modified: libcxx/tru

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane updated this revision to Diff 84330. erichkeane added a comment. Fixed the deprecated location 'note'. Observe the changes to a variety of tests. https://reviews.llvm.org/D27486 Files: include/clang/Basic/Attr.td include/clang/Sema/Sema.h lib/Sema/SemaDeclAttr.cpp lib/Sema/

[libcxx] r291922 - Revert "Rework fix for PR19460 - Use explicit bool as an extension instead."

Author: ericwf Date: Fri Jan 13 12:08:23 2017 New Revision: 291922 URL: http://llvm.org/viewvc/llvm-project?rev=291922&view=rev Log: Revert "Rework fix for PR19460 - Use explicit bool as an extension instead." Modified: libcxx/branches/release_40/include/__config libcxx/branches/release_

[libcxx] r291925 - Fix merge conflict caused by r291921

Author: ericwf Date: Fri Jan 13 12:25:13 2017 New Revision: 291925 URL: http://llvm.org/viewvc/llvm-project?rev=291925&view=rev Log: Fix merge conflict caused by r291921 Modified: libcxx/trunk/include/ios Modified: libcxx/trunk/include/ios URL: http://llvm.org/viewvc/llvm-project/libcxx/tru

[libcxx] r291935 - Fix merge error caused by r291922

Author: ericwf Date: Fri Jan 13 12:42:41 2017 New Revision: 291935 URL: http://llvm.org/viewvc/llvm-project?rev=291935&view=rev Log: Fix merge error caused by r291922 Modified: libcxx/branches/release_40/include/ios Modified: libcxx/branches/release_40/include/ios URL: http://llvm.org/viewv

r291938 - unique_ptrify Driver::ToolChains

Author: dblaikie Date: Fri Jan 13 12:53:43 2017 New Revision: 291938 URL: http://llvm.org/viewvc/llvm-project?rev=291938&view=rev Log: unique_ptrify Driver::ToolChains Modified: cfe/trunk/include/clang/Driver/Driver.h cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/include/clang/Driv

r291939 - Remove unused lambda captures. NFC

Author: malcolm.parsons Date: Fri Jan 13 12:55:32 2017 New Revision: 291939 URL: http://llvm.org/viewvc/llvm-project?rev=291939&view=rev Log: Remove unused lambda captures. NFC Modified: cfe/trunk/docs/ReleaseNotes.rst cfe/trunk/lib/AST/CXXInheritance.cpp cfe/trunk/lib/AST/MicrosoftMa

[clang-tools-extra] r291940 - Remove unused lambda captures. NFC

Author: malcolm.parsons Date: Fri Jan 13 12:56:04 2017 New Revision: 291940 URL: http://llvm.org/viewvc/llvm-project?rev=291940&view=rev Log: Remove unused lambda captures. NFC Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.c

[clang-tools-extra] r291941 - Remove unused lambda captures. NFC

Author: malcolm.parsons Date: Fri Jan 13 13:02:50 2017 New Revision: 291941 URL: http://llvm.org/viewvc/llvm-project?rev=291941&view=rev Log: Remove unused lambda captures. NFC Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp Modified: clang-tools-extra/trunk/unittes

Re: LLVM buildmaster will be unavailable on 1/13/17

Just a remainder. LLVM buildmaster will be offline today hopefully for short time due for replacing network hardware. Thank you for understanding. Thanks Galina On Thu, Jan 12, 2017 at 8:29 PM, Galina Kistanova wrote: > Hello everyone, > > LLVM buildmaster will be offline on 1/13/17 hopefull

[PATCH] D26057: [coroutines] Add DependentCoawaitExpr and fix re-building CoroutineBodyStmt.

EricWF added a comment. @rsmith Ping. Would you like me to split this up into smaller change sets? https://reviews.llvm.org/D26057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r291877 - [Sema] Restrict explicit instantation definition dllexport

Merged in r291943. Thanks, Hans On Thu, Jan 12, 2017 at 5:58 PM, Shoaib Meenai wrote: > Requesting a merge to the 4.0 branch. This is a pretty small change, and it > fixes an assertion failure on Windows (see PR31608 for details). > > On 1/12/17, 5:28 PM, "cfe-commits on behalf of Shoaib Meenai

[libcxxabi] r291946 - [libc++abi] Add a silent terminate handler to libcxxabi.

Author: jyknight Date: Fri Jan 13 13:22:26 2017 New Revision: 291946 URL: http://llvm.org/viewvc/llvm-project?rev=291946&view=rev Log: [libc++abi] Add a silent terminate handler to libcxxabi. The current std::terminate_handler pulls in some string code, some I/O code, and more. Since it is automa

[PATCH] D21675: New ODR checker for modules

rtrieu updated this revision to Diff 84340. https://reviews.llvm.org/D21675 Files: include/clang/AST/DeclCXX.h include/clang/AST/ODRHash.h include/clang/AST/Stmt.h include/clang/Basic/DiagnosticSerializationKinds.td lib/AST/CMakeLists.txt lib/AST/DeclCXX.cpp lib/AST/ODRHash.cpp li

[PATCH] D21675: New ODR checker for modules

rtrieu marked 5 inline comments as done. rtrieu added a comment. Comments have been addressed. I will be testing it for performance impact next. Comment at: include/clang/AST/ODRHash.h:54 + // in Pointers. + size_type NextFreeIndex; + rsmith wrote: > Is this

Re: r291907 - Revert "Support for Python 3 in libclang python bindings"

On Fri, Jan 13, 2017 at 8:06 AM, Jonathan Coe via cfe-commits wrote: > Author: jbcoe > Date: Fri Jan 13 10:06:59 2017 > New Revision: 291907 > > URL: http://llvm.org/viewvc/llvm-project?rev=291907&view=rev > Log: > Revert "Support for Python 3 in libclang python bindings" > > This reverts commit 4

Re: r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

Also need to pull in r291881. Sorry about that. On Thu, Jan 12, 2017 at 3:42 PM Hans Wennborg wrote: > On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth > wrote: > >> This isn't quite right, it should either be left as-is or dropped > >> completely. This path was allowing people to spell "-mllv

Re: r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

Merged in r291951. Thanks, Hans On Fri, Jan 13, 2017 at 11:46 AM, Chandler Carruth wrote: > Also need to pull in r291881. Sorry about that. > > > On Thu, Jan 12, 2017 at 3:42 PM Hans Wennborg wrote: >> >> On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth >> wrote: >> >> This isn't quite right,

Re: r291879 - Add a necessary newline for diagnose_if documentation.

Merged in r291952. Thanks, Hans On Thu, Jan 12, 2017 at 5:52 PM, Eric Christopher via cfe-commits wrote: > Author: echristo > Date: Thu Jan 12 19:52:04 2017 > New Revision: 291879 > > URL: http://llvm.org/viewvc/llvm-project?rev=291879&view=rev > Log: > Add a necessary newline for diagnose_if do

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

rnk added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:34 + #if 0 +#define USE_VS_SETUP_CONFIG + #endif What are the outstanding issues preventing you from enabling this by default? Comment at: lib/Driver/MSVCToolChain.cpp:16

[PATCH] D28058: [OpenCL] Correct ndrange_t implementation

yaxunl added a comment. In https://reviews.llvm.org/D28058#645399, @dmitry wrote: > @yaxunl, we already have the similar issue for atomics. Probably we can > extend typedef semantic checks but I don't think it's a good idea since C and > C++ have the similar problem but they don't provide speci

Re: r291879 - Add a necessary newline for diagnose_if documentation.

Great, thanks! On Fri, Jan 13, 2017, 11:52 AM Hans Wennborg wrote: > Merged in r291952. > > Thanks, > Hans > > On Thu, Jan 12, 2017 at 5:52 PM, Eric Christopher via cfe-commits > wrote: > > Author: echristo > > Date: Thu Jan 12 19:52:04 2017 > > New Revision: 291879 > > > > URL: http://llvm.org

r291953 - Fix shared library build after r291938 by adding missing dependency on libOption

Author: dblaikie Date: Fri Jan 13 13:47:55 2017 New Revision: 291953 URL: http://llvm.org/viewvc/llvm-project?rev=291953&view=rev Log: Fix shared library build after r291938 by adding missing dependency on libOption Thanks to Reid Kleckner for the help reproducing/fixing. Modified: cfe/trunk

[PATCH] D26057: [coroutines] Add DependentCoawaitExpr and fix re-building CoroutineBodyStmt.

rsmith added inline comments. Comment at: include/clang/AST/ExprCXX.h:4237 + /// compiler. + bool IsImplicitlyCreated : 1; + I would go with just `isImplicit`, to match other similar uses throughout the AST. Also maybe sink this into the `Stmt` bitfields to ma

[PATCH] D21675: New ODR checker for modules

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks good assuming your performance testing doesn't uncover anything. Comment at: lib/AST/ODRHash.cpp:319-321 +if (!D) return; +if (D->isImplicit()) + r

[PATCH] D28691: Support synchronisation scope in atomic builtin functions

yaxunl created this revision. yaxunl added reviewers: Anastasia, bader, rjmccall. yaxunl added a subscriber: cfe-commits. OpenCL 2.0 atomic builtin functions have a scope argument which is ideally represented as synchronization scope argument in LLVM atomic instructions. Clang supports translati

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Looks great to me, thanks! Unless someone else shouts, I'll land this for you soon. https://reviews.llvm.org/D28543 ___ cfe-commits mailing list

r291955 - PR31606: Generalize our tentative DR resolution for inheriting copy/move

Author: rsmith Date: Fri Jan 13 14:46:54 2017 New Revision: 291955 URL: http://llvm.org/viewvc/llvm-project?rev=291955&view=rev Log: PR31606: Generalize our tentative DR resolution for inheriting copy/move constructors to better match the pre-P0136R1 behavior. Modified: cfe/trunk/include/clan

Re: LLVM buildmaster will be unavailable on 1/13/17

Should we slow down, or block commits for the time being? It could be a total chaos when they get back... On 13 January 2017 at 19:16, Galina Kistanova via cfe-commits wrote: > Just a remainder. > > LLVM buildmaster will be offline today hopefully for short time due for > replacing network hardw

[PATCH] D28691: Support synchronisation scope in Clang atomic builtin functions

yaxunl retitled this revision from "Support synchronisation scope in atomic builtin functions" to "Support synchronisation scope in Clang atomic builtin functions". yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 84373. yaxunl added a comment. Fix typos and for

[PATCH] D28703: [clang] Emit `diagnose_if` warnings from system headers

EricWF created this revision. EricWF added reviewers: george.burgess.iv, rsmith, aaron.ballman. EricWF added a subscriber: cfe-commits. In order for libc++ to meaningfully use `diagnose_if` warnings they need to be emitted from system headers by default. This patch changes the `diagnose_if` warn

[libcxx] r291961 - Add _LIBCPP_DIAGNOSE_WARNING and _LIBCPP_DIAGNOSE_ERROR macros.

Author: ericwf Date: Fri Jan 13 16:02:08 2017 New Revision: 291961 URL: http://llvm.org/viewvc/llvm-project?rev=291961&view=rev Log: Add _LIBCPP_DIAGNOSE_WARNING and _LIBCPP_DIAGNOSE_ERROR macros. Clang recently added a `diagnose_if(cond, msg, type)` attribute which can be used to generate diagno

[PATCH] D28703: [clang] Emit `diagnose_if` warnings from system headers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D28703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

r291963 - [clang] Emit `diagnose_if` warnings from system headers

Author: ericwf Date: Fri Jan 13 16:11:40 2017 New Revision: 291963 URL: http://llvm.org/viewvc/llvm-project?rev=291963&view=rev Log: [clang] Emit `diagnose_if` warnings from system headers Summary: In order for libc++ to meaningfully use `diagnose_if` warnings they need to be emitted from system

r291964 - PR31631: fix bad CFG (and bogus warnings) when an if-statement has an init-statement and has binary operator as its condition.

Author: rsmith Date: Fri Jan 13 16:16:41 2017 New Revision: 291964 URL: http://llvm.org/viewvc/llvm-project?rev=291964&view=rev Log: PR31631: fix bad CFG (and bogus warnings) when an if-statement has an init-statement and has binary operator as its condition. Modified: cfe/trunk/lib/Analysis

[PATCH] D21675: New ODR checker for modules

rtrieu marked an inline comment as done. rtrieu added a comment. From testing, there is no difference when compiling with pre-compiled headers. However, when building the headers, there is a 3-4% impact on compile time. https://reviews.llvm.org/D21675 ___

[PATCH] D28705: [Sema] Fix bug in handling of designated initializer

ahatanak created this revision. ahatanak added reviewers: rsmith, rnk, arphaman. ahatanak added a subscriber: cfe-commits. CheckDesignatedInitializer wasn't taking into account the base classes when computing the index for the field in the derived class, which caused the test case to crash durin

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

Do we want to consider merging this into the release branch? Seems like more of a bugfix than a feature to me. On Fri, Jan 13, 2017 at 2:11 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Fri Jan 13 16:11:40 2017 > New Revision: 291963 > > URL: http

[libcxx] r291969 - Diagnose non-const-callable hash functions and comparators

Author: ericwf Date: Fri Jan 13 16:42:53 2017 New Revision: 291969 URL: http://llvm.org/viewvc/llvm-project?rev=291969&view=rev Log: Diagnose non-const-callable hash functions and comparators Added: libcxx/trunk/test/libcxx/containers/unord/non_const_comparator.fail.cpp Modified: libcxx/t

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

I would love to see this merged. It would make it easier to write libc++ tests if the tests didn't have to worry about the old 4.0 behavior. CC'ing Richard: Would merging this be OK? On Fri, Jan 13, 2017 at 3:46 PM, George Burgess IV < george.burgess...@gmail.com> wrote: > Do we want to consider

[PATCH] D28381: [WebAssembly] Always inline atomics

jgravelle-google abandoned this revision. jgravelle-google added a comment. Abandoning this in favor of https://github.com/kripken/emscripten/pull/4846 https://reviews.llvm.org/D28381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D28457: Add missing const qualifier to member function Decl::isLocalExternDecl()

ahatanak accepted this revision. ahatanak added a reviewer: ahatanak. ahatanak added a comment. This revision is now accepted and ready to land. This looks OK to commit. https://reviews.llvm.org/D28457 ___ cfe-commits mailing list cfe-commits@lists.

r291974 - clang-format: Fix bug in making line break decisions.

Author: djasper Date: Fri Jan 13 17:18:16 2017 New Revision: 291974 URL: http://llvm.org/viewvc/llvm-project?rev=291974&view=rev Log: clang-format: Fix bug in making line break decisions. Here, the optimization to not line wrap when it would not lead to a reduction in columns was overwriting and

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

manmanren updated this revision to Diff 84406. manmanren marked 7 inline comments as done. manmanren added a comment. Add CC1 option to control hashing of the module file content. https://reviews.llvm.org/D27689 Files: include/clang/AST/ExternalASTSource.h include/clang/Basic/Module.h inc

[libcxx] r291976 - Diagnose invalid memory orderings in

Author: ericwf Date: Fri Jan 13 17:45:39 2017 New Revision: 291976 URL: http://llvm.org/viewvc/llvm-project?rev=291976&view=rev Log: Diagnose invalid memory orderings in Added: libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp Modified: libcxx/trunk/include/__config

Re: r291964 - PR31631: fix bad CFG (and bogus warnings) when an if-statement has an init-statement and has binary operator as its condition.

Merged in r291978. (Please keep the list cc'd on merge requests.) Thanks, Hans On Fri, Jan 13, 2017 at 2:28 PM, Richard Smith wrote: > Seems sensible to put this in clang 4. > > -- Forwarded message -- > From: Richard Smith via cfe-commits > Date: 13 January 2017 at 14:16 > Sub

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

manmanren marked an inline comment as done. manmanren added inline comments. Comment at: include/clang/Serialization/Module.h:19 #include "clang/Basic/FileManager.h" +#include "clang/Basic/Module.h" #include "clang/Basic/SourceLocation.h" rsmith wrote: > Redund

LLVM buildmaster is back to work

Hello everyone, LLVM buildmaster is back to work. Please let me know if there are any issues. Thanks you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D28592: [libcxx] [test] Fix MSVC warning C4127 "conditional expression is constant".

STL_MSFT abandoned this revision. STL_MSFT added a comment. Actually, this pattern annoys "warning C6326: Potential comparison of a constant with another constant." from /analyze. I'll figure out a better fix, probably with integral_constant. https://reviews.llvm.org/D28592

[PATCH] D28705: [Sema] Fix bug in handling of designated initializer

rnk added a comment. What happens with virtual bases? struct B { int x; }; struct D : virtual B { int y; }; void test() { D d = {1, .y = 2}; } Comment at: lib/Sema/SemaInit.cpp:2250 +if (auto *CXXRD = dyn_cast(RT->getDecl())) + FieldIndex += CXXRD->getNumBases

[PATCH] D28716: [libc++] Diagnose null inputs in std::string using _LIBCPP_DIAGNOSE_WARNING

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. This patch uses `diagnose_if` to attempt to catch null inputs in `std::string`. Note that unlike `__attribute__((non_null))` `diagnose_if` does not affect codegen. https://reviews.llvm.o

[libcxx] r291986 - Remove unused parameters in C++03

Author: ericwf Date: Fri Jan 13 19:33:53 2017 New Revision: 291986 URL: http://llvm.org/viewvc/llvm-project?rev=291986&view=rev Log: Remove unused parameters in C++03 Modified: libcxx/trunk/include/memory Modified: libcxx/trunk/include/memory URL: http://llvm.org/viewvc/llvm-project/libcxx/

Re: [libcxx] r291072 - Get test-suite configuring on Windows with clang-cl

On Thu, Jan 12, 2017 at 1:17 AM, Shoaib Meenai wrote: > What was the rationale for forcing the use of lld? Were errors encountered > with link? It's slightly annoying to have the extra dependency; Initially I thought it was required in order to avoid re-writing all of the linker flags. However

Re: [libcxx] r291072 - Get test-suite configuring on Windows with clang-cl

Ah. lld-link actually only accepts link-style options, so it wouldn't solve that particular problem. Happily, it seems like we aren't relying on ld-style options to begin with. From: Eric Fiselier Date: Friday, January 13, 2017 at 5:52 PM To: Shoaib Meenai Cc: "cfe-commits@lists.llvm.org" Subje

[libcxx] r291987 - Don't force use of lld in tests on Windows

Author: ericwf Date: Fri Jan 13 19:58:01 2017 New Revision: 291987 URL: http://llvm.org/viewvc/llvm-project?rev=291987&view=rev Log: Don't force use of lld in tests on Windows Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py URL: http://llv

r291988 - Give more accurate descriptions of what kind of template we found in diagnostics.

Author: rsmith Date: Fri Jan 13 20:19:59 2017 New Revision: 291988 URL: http://llvm.org/viewvc/llvm-project?rev=291988&view=rev Log: Give more accurate descriptions of what kind of template we found in diagnostics. We were previouly assuming that every type template was a class template, which i

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

EricWF added a comment. In https://reviews.llvm.org/D28441#639023, @smeenai wrote: > One potential issue with always forcing the non-debug msvcrt is that any apps > that link against libc++ would also then need to use the non-debug CRT > libraries, otherwise you'd get all sorts of fun runtime e

[PATCH] D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows

EricWF updated this revision to Diff 84414. EricWF added a comment. Attempt to address review comments - Rename `LIBCXX_TARGETING_WINDOWS` to `LIBCXX_TARGETING_MSVC`. It is set to on when CMake defines `MSVC` to `ON`. This macro is intented to represent cases where we are targeting native Windo

[PATCH] D28672: [ASTMatchers] update doc by running dump_ast_matchers.py

aaron.ballman added a comment. I'm not seeing anything wrong, per se, but why has so much of this file changed recently? https://reviews.llvm.org/D28672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

aaron.ballman added a comment. I feel like I must be missing something; why is this disabling rather than specifying the thread safety behavior? e.g., `__libcpp_mutex_lock()` specifying that it acquires the capability and `__libcpp_mutex_unlock()` specifying that it releases it? https://revie

[PATCH] D28705: [Sema] Fix bug in handling of designated initializer

ahatanak updated this revision to Diff 84418. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D28705 Files: lib/Sema/SemaInit.cpp test/SemaCXX/designated-initializers-base-class.cpp Index: test/SemaCXX/designated-initi

[PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Do you need somebody to commit this for you? Let me know once you've committed it and I'll merge it into the 4.0 branch. https://reviews.llvm.org/D22452 _

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

EricWF added a comment. In https://reviews.llvm.org/D28520#646160, @aaron.ballman wrote: > I feel like I must be missing something; why is this disabling rather than > specifying the thread safety behavior? e.g., `__libcpp_mutex_lock()` > specifying that it acquires the capability and `__libcpp

[PATCH] D27850: [libcxx] add missing constexpr to optional::value_or

EricWF added a comment. @cpplearner Do you need somebody to commit this for you? https://reviews.llvm.org/D27850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28705: [Sema] Fix bug in handling of designated initializer

ahatanak added a comment. In https://reviews.llvm.org/D28705#646088, @rnk wrote: > What happens with virtual bases? > > struct B { int x; }; > struct D : virtual B { int y; }; > void test() { D d = {1, .y = 2}; } A class with virtual base is not considered an aggregate, so it doesn't go

[PATCH] D28591: [libcxx] [test] Don't ask whether Incomplete& can be assigned to.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Although `is_assignable` can often get accidentally instantiated with an incomplete type by way of `std::tuple` or similar, which is the rational for this test case. https://reviews.l

  1   2   >