[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

mati865 added a comment. omp.h on Linux is supported by OpenMP package https://www.archlinux.org/packages/extra/x86_64/openmp/files/ I haven't tried to build it on win32 yet but since my examination session at college is over I'll try it in following days. I'm not sure but openacc.h probably

r294613 - [c++1z] P0091R3: Basic support for deducing class template arguments via deduction-guides.

Author: rsmith Date: Thu Feb 9 13:17:44 2017 New Revision: 294613 URL: http://llvm.org/viewvc/llvm-project?rev=294613=rev Log: [c++1z] P0091R3: Basic support for deducing class template arguments via deduction-guides. Added: cfe/trunk/test/CXX/expr/expr.post/expr.type.conv/p1.cpp

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. What about omp.h and openacc.h ? many programs are using OpenMP. You raised real issues which should certainly be solved with clang mingw support. Removing the gcc dirs from include path will break any program that currently uses or depends in any way on any header

r294626 - [docs] coverage: Clarify which flags enable gcov-style profiling (NFC)

Author: vedantk Date: Thu Feb 9 15:33:21 2017 New Revision: 294626 URL: http://llvm.org/viewvc/llvm-project?rev=294626=rev Log: [docs] coverage: Clarify which flags enable gcov-style profiling (NFC) Point out that --coverage and -ftest-coverage, which is what most people are used to, do not

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

dexonsmith added a comment. I'm not comfortable signing off on this, but it seems like this should be set up as a blocker for LLVM 4.0 if it isn't already. Comment at: lib/Serialization/ASTReaderDecl.cpp:2518-2523 // An ImportDecl or VarDecl imported from a module will get

[PATCH] D29778: Declare lgamma library builtins as never being const

jgravelle-google created this revision. POSIX requires lgamma writes to an external global variable, signgam. This prevents annotating lgamma with readnone, which is incorrect on targets that write to signgam. https://reviews.llvm.org/D29778 Files: include/clang/Basic/Builtins.def

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

mati865 marked an inline comment as done. mati865 added a comment. @yaron.keren those includes are not available in native Linux Clang: float128_ex.cc:2:10: fatal error: 'quadmath.h' file not found #include ^ And at least 2 of GCC includes clash with Clang includes: - limits.h

[PATCH] D25674: [Concepts] Class template associated constraints

hubert.reinterpretcast updated this revision to Diff 87855. hubert.reinterpretcast added a comment. Address review comments; update to revision 294580 Allocate ConstrainedTemplateDeclInfo separately Update comments to be sentences; NFC https://reviews.llvm.org/D25674 Files:

r294622 - Rename IsExplicitSpecialization -> IsMemberSpecialization when we're talking

Author: rsmith Date: Thu Feb 9 15:04:43 2017 New Revision: 294622 URL: http://llvm.org/viewvc/llvm-project?rev=294622=rev Log: Rename IsExplicitSpecialization -> IsMemberSpecialization when we're talking about member specializations to avoid ambiguous and confusing terminology. Modified:

r294623 - [CodeGen] Remove unneeded `private`. NFCI.

Author: davide Date: Thu Feb 9 15:19:51 2017 New Revision: 294623 URL: http://llvm.org/viewvc/llvm-project?rev=294623=rev Log: [CodeGen] Remove unneeded `private`. NFCI. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL:

[PATCH] D29773: Add support for armv7ve flag in clang (PR31358).

richard.barton.arm accepted this revision. richard.barton.arm added a comment. This revision is now accepted and ready to land. This all LGTM. If I can assume I am allow to approve, then I approve. Comment at: test/Preprocessor/arm-acle-6.4.c:136 +// CHECK-V7VE:

[clang-tools-extra] r294578 - [clang-tidy] Fix misc-unused-using-decls false positives in presence of compile errors

Author: alexfh Date: Thu Feb 9 04:41:27 2017 New Revision: 294578 URL: http://llvm.org/viewvc/llvm-project?rev=294578=rev Log: [clang-tidy] Fix misc-unused-using-decls false positives in presence of compile errors Added:

[PATCH] D29704: [XRay] [clang] Allow logging the first argument of a function call.

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. Just a minor comment -- I suspect you're going to wait until the patch to LLVM lands? Comment at: lib/Sema/SemaDeclAttr.cpp:4407 + + // It isn't a parameter index [0;n),

Re: [libcxx] r294553 - [libcxx][CMake] Support in-tree libunwind when building as part of runtimes

Ah, ignore me please. I should've read the patch. / Asiri On Thu, Feb 9, 2017 at 9:13 AM, Asiri Rathnayake wrote: > Hi Petr, > > This is breaking static builds of the libraries, cmake complaints with: > > "CMake Error at projects/libcxxabi/src/CMakeLists.txt:134 >

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

bruno created this revision. This fixes PR31863, a regression introduced in r276159. Consider this snippet: struct FVector; struct FVector {}; struct FBox { FVector Min; FBox(int); }; namespace { FBox InvalidBoundingBox(0); } While parsing the DECL_VAR for 'struct FBox', clang

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

This revision was automatically updated to reflect the committed changes. Closed by commit rL294573: Threading support: externalize sleep_for() function. (authored by asiri). Changed prior to commit: https://reviews.llvm.org/D29630?vs=87669=8#toc Repository: rL LLVM

[PATCH] D29755: Cache FileID when translating diagnostics in PCH files

erikjv created this revision. Modules/preambles/PCH files can contain diagnostics, which, when used, are added to the current ASTUnit. For that to work, they are translated to use the current FileManager's FileIDs. When the entry is not the main file, all local source locations will be checked by

Re: [libcxx] r294553 - [libcxx][CMake] Support in-tree libunwind when building as part of runtimes

Hi Petr, This is breaking static builds of the libraries, cmake complaints with: "CMake Error at projects/libcxxabi/src/CMakeLists.txt:134 (target_link_libraries): Target "unwind" of type UTILITY may not be linked into another target. One may link only to STATIC or SHARED libraries, or to

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

jbangert updated this revision to Diff 87879. jbangert added a comment. - fix test https://reviews.llvm.org/D29621 Files: include/clang/Tooling/RefactoringCallbacks.h lib/Tooling/RefactoringCallbacks.cpp unittests/Tooling/RefactoringCallbacksTest.cpp Index:

[libcxx] r294660 - add missing python import

Author: ericwf Date: Thu Feb 9 17:29:08 2017 New Revision: 294660 URL: http://llvm.org/viewvc/llvm-project?rev=294660=rev Log: add missing python import Modified: libcxx/trunk/utils/libcxx/util.py Modified: libcxx/trunk/utils/libcxx/util.py URL:

Re: [cfe-commits] r164177 - in /cfe/trunk: lib/Driver/ test/Driver/ test/Driver/Inputs/freescale_ppc_tree/ test/Driver/Inputs/freescale_ppc_tree/lib/ test/Driver/Inputs/freescale_ppc_tree/usr/ test/Dr

On 9 February 2017 at 16:15, Hal Finkel via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 02/09/2017 04:58 PM, Chandler Carruth wrote: > > On Thu, Feb 9, 2017 at 2:46 PM Tobias von Koch > wrote: > >> On Wed, Feb 8, 2017 at 7:21 PM, Chandler Carruth

Re: [libcxx] r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

Sounds good to me. You said "these changes"; are there more than this one? On Thu, Feb 9, 2017 at 11:15 AM, Eric Fiselier wrote: > I'm planning to merge this fix into the 4.0 release branch. > > Although not a regression, since is a new feature, it would still > be nice to ship

[PATCH] D29748: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:5061 + APValue RVal; + // FIXME: We need to make sure we're passing the right type that + // maintains cv-qualifiers. faisalv wrote: > I don't think we need this fixme

r294639 - Diagnose attempts to explicitly instantiate a template at class scope. Previously Clang would simply ignore the 'template' keyword in this case.

Author: rsmith Date: Thu Feb 9 16:14:25 2017 New Revision: 294639 URL: http://llvm.org/viewvc/llvm-project?rev=294639=rev Log: Diagnose attempts to explicitly instantiate a template at class scope. Previously Clang would simply ignore the 'template' keyword in this case. Modified:

[libcxxabi] r294671 - Fix path to libc++'s python test module

Author: ericwf Date: Thu Feb 9 17:58:54 2017 New Revision: 294671 URL: http://llvm.org/viewvc/llvm-project?rev=294671=rev Log: Fix path to libc++'s python test module Modified: libcxxabi/trunk/test/lit.cfg Modified: libcxxabi/trunk/test/lit.cfg URL:

Re: [cfe-commits] r164177 - in /cfe/trunk: lib/Driver/ test/Driver/ test/Driver/Inputs/freescale_ppc_tree/ test/Driver/Inputs/freescale_ppc_tree/lib/ test/Driver/Inputs/freescale_ppc_tree/usr/ test/Dr

On 9 February 2017 at 14:33, Hal Finkel via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 02/08/2017 07:21 PM, Chandler Carruth wrote: > > It's blast from the past time! > > On Tue, Sep 18, 2012 at 3:28 PM Hal Finkel wrote: > >> Author: hfinkel >> Date: Tue Sep 18

[clang-tools-extra] r294657 - Don't try to link to the 4.0 release notes

Author: hans Date: Thu Feb 9 17:25:52 2017 New Revision: 294657 URL: http://llvm.org/viewvc/llvm-project?rev=294657=rev Log: Don't try to link to the 4.0 release notes Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL:

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

echristo added a comment. Can we not get llc to use the diags interfaces here? https://reviews.llvm.org/D29770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D28478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r294658 - Don't try to link to the 4.0 release notes

Author: hans Date: Thu Feb 9 17:26:34 2017 New Revision: 294658 URL: http://llvm.org/viewvc/llvm-project?rev=294658=rev Log: Don't try to link to the 4.0 release notes Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

Re: [cfe-commits] r164177 - in /cfe/trunk: lib/Driver/ test/Driver/ test/Driver/Inputs/freescale_ppc_tree/ test/Driver/Inputs/freescale_ppc_tree/lib/ test/Driver/Inputs/freescale_ppc_tree/usr/ test/Dr

On 02/09/2017 04:58 PM, Chandler Carruth wrote: On Thu, Feb 9, 2017 at 2:46 PM Tobias von Koch > wrote: On Wed, Feb 8, 2017 at 7:21 PM, Chandler Carruth > wrote:

Re: [PATCH] D16135: Macro Debug Info support in Clang

r294676 On Thu, Feb 9, 2017 at 4:05 PM David L. Jones via Phabricator < revi...@reviews.llvm.org> wrote: > dlj added inline comments. > > > > Comment at: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp:125 > + switch (Status) { > + default: > +llvm_unreachable("Do not expect to

r294680 - Update C style comments to C++ style.

Author: echristo Date: Thu Feb 9 18:20:26 2017 New Revision: 294680 URL: http://llvm.org/viewvc/llvm-project?rev=294680=rev Log: Update C style comments to C++ style. Modified: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp Modified: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp URL:

Re: [libcxx] r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

Looks like it is just this change. I merged it in r294681. /Eric ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r294681 - Merge r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

Author: ericwf Date: Thu Feb 9 18:37:47 2017 New Revision: 294681 URL: http://llvm.org/viewvc/llvm-project?rev=294681=rev Log: Merge r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments A static assertion was misfiring since it checked is_callable

[PATCH] D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: test/clang-tidy/readability-delete-null-pointer.cpp:67 + // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: 'if' statement is unnecessary; deleting

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

jbangert marked 2 inline comments as done. jbangert added a comment. Fixed the test -- I am still getting used to the different ninja test targets. Comment at: lib/Tooling/RefactoringCallbacks.cpp:160 +llvm::Expected +ReplaceNodeWithTemplate::create(StringRef

[PATCH] D16135: Macro Debug Info support in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL294637: [DebugInfo] Added support to Clang FE for generating debug info for… (authored by aaboud). Changed prior to commit: https://reviews.llvm.org/D16135?vs=87819=87881#toc Repository: rL LLVM

Re: [cfe-commits] r164177 - in /cfe/trunk: lib/Driver/ test/Driver/ test/Driver/Inputs/freescale_ppc_tree/ test/Driver/Inputs/freescale_ppc_tree/lib/ test/Driver/Inputs/freescale_ppc_tree/usr/ test/Dr

On 02/08/2017 07:21 PM, Chandler Carruth wrote: It's blast from the past time! On Tue, Sep 18, 2012 at 3:28 PM Hal Finkel > wrote: Author: hfinkel Date: Tue Sep 18 17:25:07 2012 New Revision: 164177 URL:

r294641 - Disallow explicit instantiation and explicit specialization for deduction guides.

Author: rsmith Date: Thu Feb 9 16:47:51 2017 New Revision: 294641 URL: http://llvm.org/viewvc/llvm-project?rev=294641=rev Log: Disallow explicit instantiation and explicit specialization for deduction guides. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: [cfe-commits] r164177 - in /cfe/trunk: lib/Driver/ test/Driver/ test/Driver/Inputs/freescale_ppc_tree/ test/Driver/Inputs/freescale_ppc_tree/lib/ test/Driver/Inputs/freescale_ppc_tree/usr/ test/Dr

On Thu, Feb 9, 2017 at 2:46 PM Tobias von Koch wrote: > On Wed, Feb 8, 2017 at 7:21 PM, Chandler Carruth > wrote: > > > +// The Freescale PPC SDK has the gcc libraries in > +// /usr/lib//x.y.z so have a look there as well. > +"/" +

[PATCH] D29773: Add support for armv7ve flag in clang (PR31358).

This revision was automatically updated to reflect the committed changes. Closed by commit rL294662: Add support for armv7ve flag in clang (PR31358). (authored by gbiv). Changed prior to commit: https://reviews.llvm.org/D29773?vs=87831=87899#toc Repository: rL LLVM

r294662 - Add support for armv7ve flag in clang (PR31358).

Author: gbiv Date: Thu Feb 9 17:30:10 2017 New Revision: 294662 URL: http://llvm.org/viewvc/llvm-project?rev=294662=rev Log: Add support for armv7ve flag in clang (PR31358). This is a followup change to add v7ve support to clang for gcc compatibility. Please see r294661. Patch by Manoj Gupta.

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

EricWF added a comment. IDK how to meaningly test this though. https://reviews.llvm.org/D28478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [cfe-commits] r164177 - in /cfe/trunk: lib/Driver/ test/Driver/ test/Driver/Inputs/freescale_ppc_tree/ test/Driver/Inputs/freescale_ppc_tree/lib/ test/Driver/Inputs/freescale_ppc_tree/usr/ test/Dr

On Wed, Feb 8, 2017 at 7:21 PM, Chandler Carruth wrote: > >> +// The Freescale PPC SDK has the gcc libraries in >> +// /usr/lib//x.y.z so have a look there as well. >> +"/" + CandidateTriple.str(), >> > > So, this is really bad it turns out. > > We use this

[libcxx] r294673 - Add missing libc++ import

Author: ericwf Date: Thu Feb 9 18:01:01 2017 New Revision: 294673 URL: http://llvm.org/viewvc/llvm-project?rev=294673=rev Log: Add missing libc++ import Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL:

Re: [libcxx] r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

This change stands on it's own. But I think there were another couple of bug fixes in the past week. I'm going to look into merging those as well. /Eric On Thu, Feb 9, 2017 at 2:56 PM, Hans Wennborg wrote: > Sounds good to me. You said "these changes"; are there more than

Re: Patch for Bug 30413

Hi David, Thanks for tracking this down. Do you have a small reproducer to use as a test case? Ideally, you'd add a regression test to clang/test/CodeGenObjC, or extend an existing one. vedant > On Feb 7, 2017, at 6:42 PM, Lobron, David via cfe-commits > wrote: >

[PATCH] D16135: Macro Debug Info support in Clang

dlj added inline comments. Comment at: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp:125 + switch (Status) { + default: +llvm_unreachable("Do not expect to enter a file from current scope"); As a heads up... this fails under -Werror:

r294676 - Fix the -Werror build by removing an unused default in a fully covered switch

Author: dblaikie Date: Thu Feb 9 18:06:38 2017 New Revision: 294676 URL: http://llvm.org/viewvc/llvm-project?rev=294676=rev Log: Fix the -Werror build by removing an unused default in a fully covered switch Modified: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp Modified:

Re: [libcxx] r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

Thanks! On Thu, Feb 9, 2017 at 4:49 PM, Eric Fiselier wrote: > Looks like it is just this change. I merged it in r294681. > > /Eric ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r294637 - [DebugInfo] Added support to Clang FE for generating debug info for preprocessor macros.

Author: aaboud Date: Thu Feb 9 16:07:24 2017 New Revision: 294637 URL: http://llvm.org/viewvc/llvm-project?rev=294637=rev Log: [DebugInfo] Added support to Clang FE for generating debug info for preprocessor macros. Added "-fdebug-macro" flag (and "-fno-debug-macro" flag) to enable (and to

[libcxx] r294644 - Start libc++ python cleanup and consolidation.

Author: ericwf Date: Thu Feb 9 16:53:14 2017 New Revision: 294644 URL: http://llvm.org/viewvc/llvm-project?rev=294644=rev Log: Start libc++ python cleanup and consolidation. Libc++ frequently creates and uses utilities written in python. Currently there are python modules under both libcxx/test

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai updated this revision to Diff 87911. smeenai added a comment. Rebase and ping https://reviews.llvm.org/D25208 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/__locale include/__mutex_base include/condition_variable include/future include/mutex

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 87912. smeenai added a comment. Rebase and ping https://reviews.llvm.org/D29157 Files: include/__config include/locale include/string Index: include/string === --- include/string +++

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

chandlerc added a reviewer: EricWF. chandlerc added a comment. This seems good to me. Check with Eric to see if we try to test this any any specific way? https://reviews.llvm.org/D28478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

dlj added a comment. In https://reviews.llvm.org/D28478#672959, @EricWF wrote: > IDK how to meaningly test this though. Heh. Well... I can tell you that with this change (and a couple of others), I'm able to bootstrap Clang (2-stage) using libc++ on Alpine Linux. It totally works, I promise!

[libcxx] r294683 - Check for musl-libc's max_align_t in addition to other variants.

Author: dlj Date: Thu Feb 9 19:27:42 2017 New Revision: 294683 URL: http://llvm.org/viewvc/llvm-project?rev=294683=rev Log: Check for musl-libc's max_align_t in addition to other variants. Summary: Libcxx will define its own max_align_t when it is not available. However, the availability checks

[PATCH] D27486: Correct class-template deprecation behavior

rsmith added inline comments. Comment at: include/clang/Basic/Attr.td:301 bit DuplicatesAllowedWhileMerging = 0; + // Set to true if this attribute should apply to template declarations, + // remains false if this should only be applied to the definition.

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

vsk added a comment. In https://reviews.llvm.org/D29369#672166, @dtzWill wrote: > After some thought, can we discuss why this is a good idea? The goal is to lower ubsan's compile-time + instrumentation overhead at -O0, since this reduces the friction of debugging a ubsan-instrumented project.

[PATCH] D29748: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:5061 + APValue RVal; + // FIXME: We need to make sure we're passing the right type that + // maintains cv-qualifiers. faisalv wrote: > rsmith wrote: > >

r294703 - For X86-64 linux and PPC64 linux align int128 to 16 bytes.

Author: echristo Date: Thu Feb 9 21:32:34 2017 New Revision: 294703 URL: http://llvm.org/viewvc/llvm-project?rev=294703=rev Log: For X86-64 linux and PPC64 linux align int128 to 16 bytes. For other platforms we should find out what they need and likely make the same change, however, a smaller

[PATCH] D28785: Split exception.cpp and new.cpp implementation into different files for different runtimes

EricWF closed this revision. EricWF added a comment. Committed in r294707. https://reviews.llvm.org/D28785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28785: Split exception.cpp and new.cpp implementation into different files for different runtimes

EricWF added a comment. In https://reviews.llvm.org/D28785#673227, @smeenai wrote: > Still not a fan of the amount of vcruntime dependencies this is taking on, > but I guess that can be followed up on. Neither am I. However this gets the debug build working, and fixes RTTI, which in turn

Re: [libcxx] r294707 - Split exception.cpp and new.cpp implementation into different files for different runtimes.

Thanks. looking... On Thu, Feb 9, 2017 at 9:51 PM Eric Fiselier wrote: > To all those who wander here from the sanitizer autoconf buildbot failures > . > > Yes, this commit is responsible for that breakage. The

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294683: Check for musl-libc's max_align_t in addition to other variants. (authored by dlj). Changed prior to commit: https://reviews.llvm.org/D28478?vs=83681=87925#toc Repository: rL LLVM

[PATCH] D29737: Updates documentation to include command to run clang-tidy tests.

dlj added a comment. LGTM. I will land shortly. https://reviews.llvm.org/D29737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r294689 - Adds the commandline need to run clang-tidy tests.

Author: dlj Date: Thu Feb 9 19:48:43 2017 New Revision: 294689 URL: http://llvm.org/viewvc/llvm-project?rev=294689=rev Log: Adds the commandline need to run clang-tidy tests. Patch by Jorge Gorbe (lethalantidote) Differential Revision: https://reviews.llvm.org/D29737 Modified:

[clang-tools-extra] r294690 - [CMake] Fix pthread handling for out-of-tree builds

Author: ericwf Date: Thu Feb 9 19:59:20 2017 New Revision: 294690 URL: http://llvm.org/viewvc/llvm-project?rev=294690=rev Log: [CMake] Fix pthread handling for out-of-tree builds LLVM defines `PTHREAD_LIB` which is used by AddLLVM.cmake and various projects to correctly link the threading

[PATCH] D29655: [X86] Link safestacksepseg runtime

mlemay-intel updated this revision to Diff 87932. mlemay-intel added a comment. Only link safestacksepseg, not safestack. I changed the build configuration for safestacksepseg to also include the files in safestack. https://reviews.llvm.org/D29655 Files: lib/Driver/Tools.cpp Index:

r294693 - [c++1z] P0512R0: support for 'explicit' specifier on deduction-guides.

Author: rsmith Date: Thu Feb 9 20:19:05 2017 New Revision: 294693 URL: http://llvm.org/viewvc/llvm-project?rev=294693=rev Log: [c++1z] P0512R0: support for 'explicit' specifier on deduction-guides. Added: cfe/trunk/test/CXX/over/over.match/over.match.funcs/over.match.class.deduct/p2.cpp

[PATCH] D29739: Make Lit tests C++11 compatible - Objective-C++

tigerleapgorge abandoned this revision. tigerleapgorge added a comment. These tests were failing because I accidentally changed the Objective-C++. Abandoning this patch. https://reviews.llvm.org/D29739 ___ cfe-commits mailing list

[PATCH] D29804: Fully qualify (preprend ::) calls to math functions from libc

EricWF added a comment. This LGTM. Although IDK how far we should go to tolerate collisions with imported namespace names, especially since `libc` can't (since they can't add the ::qualifier). I've wrote tests for this change here

[PATCH] D29804: Fully qualify (preprend ::) calls to math functions from libc

This revision was automatically updated to reflect the committed changes. Closed by commit rL294696: Fully qualify (preprend ::) calls to math functions from libc (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D29804?vs=87933=87939#toc Repository: rL LLVM

[libcxx] r294696 - Fully qualify (preprend ::) calls to math functions from libc

Author: mehdi_amini Date: Thu Feb 9 20:44:23 2017 New Revision: 294696 URL: http://llvm.org/viewvc/llvm-project?rev=294696=rev Log: Fully qualify (preprend ::) calls to math functions from libc Summary: This can cause a compile failure in cases like: double log(double); namespace foo {

[libcxx] r294698 - __threading_support: fix windows build

Author: compnerd Date: Thu Feb 9 20:49:52 2017 New Revision: 294698 URL: http://llvm.org/viewvc/llvm-project?rev=294698=rev Log: __threading_support: fix windows build The build was broken as there was no overload for long and std::chrono::nanoseconds. Add an explicit conversion to use the

[PATCH] D29748: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

faisalv updated this revision to Diff 87943. faisalv marked 6 inline comments as done. faisalv added a comment. Incorporated Richard's feedback and added comments. https://reviews.llvm.org/D29748 Files: lib/AST/ExprConstant.cpp test/SemaCXX/cxx1z-constexpr-lambdas.cpp Index:

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 8 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28785: Split exception.cpp and new.cpp implementation into different files for different runtimes

EricWF updated this revision to Diff 87944. EricWF added a comment. Merge with upstream. https://reviews.llvm.org/D28785 Files: CMakeLists.txt include/exception include/new include/typeinfo src/exception.cpp src/new.cpp src/support/runtime/exception_fallback.ipp

r294708 - Temporarily revert "For X86-64 linux and PPC64 linux align int128 to 16 bytes."

Author: echristo Date: Thu Feb 9 22:35:21 2017 New Revision: 294708 URL: http://llvm.org/viewvc/llvm-project?rev=294708=rev Log: Temporarily revert "For X86-64 linux and PPC64 linux align int128 to 16 bytes." until we can get better TargetMachine::isCompatibleDataLayout to compare - otherwise

r294697 - [Concepts] Class template associated constraints

Author: hubert.reinterpretcast Date: Thu Feb 9 20:46:19 2017 New Revision: 294697 URL: http://llvm.org/viewvc/llvm-project?rev=294697=rev Log: [Concepts] Class template associated constraints Summary: This adds associated constraints as a property of class templates. An error is produced if

Re: [libcxx] r294696 - Fully qualify (preprend ::) calls to math functions from libc

Should we get this in 4.0? — Mehdi > On Feb 9, 2017, at 6:44 PM, Mehdi Amini via cfe-commits > wrote: > > Author: mehdi_amini > Date: Thu Feb 9 20:44:23 2017 > New Revision: 294696 > > URL: http://llvm.org/viewvc/llvm-project?rev=294696=rev > Log: > Fully

[libcxx] r294699 - Attempt to fix finding clang++ on Windows

Author: ericwf Date: Thu Feb 9 21:20:02 2017 New Revision: 294699 URL: http://llvm.org/viewvc/llvm-project?rev=294699=rev Log: Attempt to fix finding clang++ on Windows Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL:

r294700 - [c++1z] In class template argument deduction, all declarators must deduce the same type (just like with auto deduction).

Author: rsmith Date: Thu Feb 9 21:27:13 2017 New Revision: 294700 URL: http://llvm.org/viewvc/llvm-project?rev=294700=rev Log: [c++1z] In class template argument deduction, all declarators must deduce the same type (just like with auto deduction). Added:

[PATCH] D28785: Split exception.cpp and new.cpp implementation into different files for different runtimes

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Accepting before committing. I wasn't able to split out the MSVC only changes in a fruitful way, so I'm going to commit this patch as-is. https://reviews.llvm.org/D28785

[PATCH] D28785: Split exception.cpp and new.cpp implementation into different files for different runtimes

smeenai added a comment. Still not a fan of the amount of vcruntime dependencies this is taking on, but I guess that can be followed up on. Was the `get_new_handler`/`set_new_handler` issue resolved? (The issue being that those functions are in msvcprt, which our tests were silently linking

[PATCH] D22057: Prevent devirtualization of calls to un-instantiated functions.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D22057#543199, @Sunil_Srivastava wrote: > Now: Why the InstantiationIsPending bit is not precisely tracking the > presence in the PendingInstantiations list?

[PATCH] D29739: Make Lit tests C++11 compatible - Objective-C++

probinson added a comment. These are all Objective-C++ tests, and AFAIK we don't intend to change the default Objective-C++ dialect when we finally do change the default C++ dialect. So I think these tests do not need to be modified. https://reviews.llvm.org/D29739

[libcxx] r294707 - Split exception.cpp and new.cpp implementation into different files for different runtimes.

Author: ericwf Date: Thu Feb 9 22:25:33 2017 New Revision: 294707 URL: http://llvm.org/viewvc/llvm-project?rev=294707=rev Log: Split exception.cpp and new.cpp implementation into different files for different runtimes. exception.cpp is a bloody mess. It's full of confusing #ifdef branches for

[PATCH] D29739: Make Lit tests C++11 compatible - Objective-C++

rjmccall added a comment. Hmm. Was there discussion about that? I see no reason not to bump ObjC++. https://reviews.llvm.org/D29739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29737: Updates documentation to include command to run clang-tidy tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294689: Adds the commandline need to run clang-tidy tests. (authored by dlj). Changed prior to commit: https://reviews.llvm.org/D29737?vs=87728=87930#toc Repository: rL LLVM

[PATCH] D29557: [clang-tools-extra] Fix pthread link

EricWF closed this revision. EricWF added a comment. Committed as r294690. https://reviews.llvm.org/D29557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29655: [X86] Link safestacksepseg runtime

mlemay-intel updated this revision to Diff 87959. mlemay-intel added a comment. Added test. https://reviews.llvm.org/D29655 Files: lib/Driver/Tools.cpp test/Driver/sanitizer-ld.c Index: test/Driver/sanitizer-ld.c === ---

[libcxx] r294712 - Correctly default to using the system libc++abi on Apple.

Author: ericwf Date: Thu Feb 9 23:07:03 2017 New Revision: 294712 URL: http://llvm.org/viewvc/llvm-project?rev=294712=rev Log: Correctly default to using the system libc++abi on Apple. This patch fixes a regression where libc++ didn't correctly select the system libc++abi when no in-tree

[PATCH] D29812: Update template-id-expr.cpp test to work when compiler defaults to non-C++03 standard

dyung created this revision. Recently a change was made to this test in r294639 which fails because the compiler only generates one of the warnings when the compiler is in C++03 or lower mode. This change fixes that as well as adds explicit run lines to run the test in C++03 and C++11 modes.

Re: [libcxx] r294707 - Split exception.cpp and new.cpp implementation into different files for different runtimes.

To all those who wander here from the sanitizer autoconf buildbot failures . Yes, this commit is responsible for that breakage. The buildbot in question attempts to compile libc++ in-tree w/o libc++abi. Previously libc++ silently

r294684 - Sink IsExplicitSpecified flag from CXXConstructorDecl and CXXConversionDecl

Author: rsmith Date: Thu Feb 9 19:32:04 2017 New Revision: 294684 URL: http://llvm.org/viewvc/llvm-project?rev=294684=rev Log: Sink IsExplicitSpecified flag from CXXConstructorDecl and CXXConversionDecl into FunctionDecl. Makes CXXConversionDecl 8 bytes smaller. No functionality change intended.

[PATCH] D29804: Fully qualify (preprend ::) calls to math functions from libc

mehdi_amini created this revision. This can cause a compile failure in cases like: double log(double); namespace foo { namespace log {} } using namespace foo; void bar(int i) { log((double)i); } https://reviews.llvm.org/D29804 Files: libcxx/include/math.h Index:

[PATCH] D29806: [clang-tidy] Add -path option to clang-tidy-diff.py

ehsan created this revision. Herald added a subscriber: JDevlieghere. This flag allows specifying a custom path for the compilation database. Unfortunately we can't use the -p flag like other clang-tidy tools because it's already taken. https://reviews.llvm.org/D29806 Files:

[PATCH] D29748: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

faisalv added inline comments. Comment at: lib/AST/ExprConstant.cpp:5061 + APValue RVal; + // FIXME: We need to make sure we're passing the right type that + // maintains cv-qualifiers. rsmith wrote: > faisalv wrote: > > I don't think

  1   2   >