[PATCH] D30018: [XRay] Add __xray_customeevent(...) as a clang-supported builtin

dberris created this revision. Herald added a subscriber: mehdi_amini. We define the `__xray_customeevent` builtin that gets translated to IR calls to the correct intrinsic. The default implementation of this is a no-op function. The codegen side of this follows the following logic: - When

r295279 - [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

Author: faisalv Date: Wed Feb 15 22:12:21 2017 New Revision: 295279 URL: http://llvm.org/viewvc/llvm-project?rev=295279=rev Log: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas. Enable evaluation of captures within constexpr lambdas by using a

r295284 - Add better ODR checking for modules.

Author: rtrieu Date: Wed Feb 15 22:53:40 2017 New Revision: 295284 URL: http://llvm.org/viewvc/llvm-project?rev=295284=rev Log: Add better ODR checking for modules. Recommit r293585 that was reverted in r293611 with new fixes. The previous issue was determined to be an overly aggressive AST

r295291 - [AVX-512] Replace 512-bit masked packss/packus builtins and replace with new unmasked builtins.

Author: ctopper Date: Thu Feb 16 00:32:07 2017 New Revision: 295291 URL: http://llvm.org/viewvc/llvm-project?rev=295291=rev Log: [AVX-512] Replace 512-bit masked packss/packus builtins and replace with new unmasked builtins. These new unmasked builtins will enable us to easily support

[PATCH] D29967: Get class property selectors from property decl if it exists

herzka updated this revision to Diff 88652. herzka added a comment. Rename selectors https://reviews.llvm.org/D29967 Files: lib/Sema/SemaExprObjC.cpp test/SemaObjC/objc-class-property.m Index: test/SemaObjC/objc-class-property.m

r295281 - Revert r295277 to fix buildbot.

Author: rsmith Date: Wed Feb 15 22:22:56 2017 New Revision: 295281 URL: http://llvm.org/viewvc/llvm-project?rev=295281=rev Log: Revert r295277 to fix buildbot. Modified: cfe/trunk/include/clang/Basic/Diagnostic.h cfe/trunk/include/clang/Sema/Sema.h

[PATCH] D30025: [compiler-rt] [builtins] Fix building atomic.c with GCC

mgorny created this revision. Herald added a subscriber: dberris. Make the use of #pragma redefine_extname and appropriate renames of builtins conditional to using clang. GCC used not to support it outside Solaris and currently seems to be very restrictive on applying it. In other words, it does

[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters

twoh added a comment. @eric_niebler I just tried it on Windows machine, and it just succeeded with no warnings/fix-it. Is that expected? https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r295293 - Revert r295284: Add better ODR checking for modules.

Author: rtrieu Date: Thu Feb 16 01:09:18 2017 New Revision: 295293 URL: http://llvm.org/viewvc/llvm-project?rev=295293=rev Log: Revert r295284: Add better ODR checking for modules. Fix modules build bot. Removed: cfe/trunk/include/clang/AST/ODRHash.h cfe/trunk/lib/AST/ODRHash.cpp

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

srhines added inline comments. Comment at: include/clang/Driver/ToolChain.h:304 + // Returns /lib//. When -fopenmp is specified, + // this directory is added to the linker search path if it exists + const std::string getOpenMPLibPath() const; Add a period at

Re: r295279 - [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

The assert below is throwing a -Wsign-compare warning because std::distance returns a signed type. + const size_t NumFields = + std::distance(ClosureClass->field_begin(), ClosureClass->field_end()); + + assert(NumFields == +std::distance(E->capture_init_begin(), E->capture_init_end())

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama added a comment. In https://reviews.llvm.org/D30015#678243, @Hahnfeld wrote: > Why is this only for OpenMP? I imagine this should be done for **all** > runtime libraries The other runtime libraries have the arch included in the library's name and the driver links the correct file.

[PATCH] D29778: Declare lgamma library builtins as never being const

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D29778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29967: Get class property selectors from property decl if it exists

herzka updated this revision to Diff 88650. herzka added a comment. Added test, used auto https://reviews.llvm.org/D29967 Files: lib/Sema/SemaExprObjC.cpp test/SemaObjC/objc-class-property.m Index: test/SemaObjC/objc-class-property.m

[libunwind] r295285 - [libunwind][CMake] Use libc++ headers when available

Author: phosek Date: Wed Feb 15 23:18:08 2017 New Revision: 295285 URL: http://llvm.org/viewvc/llvm-project?rev=295285=rev Log: [libunwind][CMake] Use libc++ headers when available libunwind depends on C++ library headers. When building libunwind as part of LLVM and libc++ is available, use its

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

Hahnfeld added a comment. Why is this only for OpenMP? I imagine this should be done for **all** runtime libraries https://reviews.llvm.org/D30015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

Hahnfeld added a subscriber: mgorny. Hahnfeld added a comment. Yes, that's the current state. We had some discussion on cfe-dev on that matter: http://lists.llvm.org/pipermail/cfe-dev/2017-January/052512.html Could you slightly adapt your patch so that other runtime libraries can follow this

r295277 - Add missing "deduced A == A" check for function template partial ordering.

Author: rsmith Date: Wed Feb 15 21:49:44 2017 New Revision: 295277 URL: http://llvm.org/viewvc/llvm-project?rev=295277=rev Log: Add missing "deduced A == A" check for function template partial ordering. This appears to be the only template argument deduction context where we were missing this

Re: r295279 - [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

On 15 February 2017 at 20:12, Faisal Vali via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: faisalv > Date: Wed Feb 15 22:12:21 2017 > New Revision: 295279 > > URL: http://llvm.org/viewvc/llvm-project?rev=295279=rev > Log: > [cxx1z-constexpr-lambda] Implement captures - thus

r295286 - Loosen a Type check ODR checking to try to fix the build bot.

Author: rtrieu Date: Wed Feb 15 23:48:25 2017 New Revision: 295286 URL: http://llvm.org/viewvc/llvm-project?rev=295286=rev Log: Loosen a Type check ODR checking to try to fix the build bot. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modified:

[PATCH] D28862: [compiler-rt] [test] Use approximate comparison on float types

mgorny abandoned this revision. mgorny added a comment. I've opened http://bugs.llvm.org/show_bug.cgi?id=31964 to track this further. I don't really have time to look into it in more detail at the moment. Repository: rL LLVM https://reviews.llvm.org/D28862

r295163 - [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el

Author: slthakur Date: Wed Feb 15 04:41:38 2017 New Revision: 295163 URL: http://llvm.org/viewvc/llvm-project?rev=295163=rev Log: [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el Summary: Adds xray instrument option for mips/mipsel/mips64/mips64el. Reviewed by sdardis, dberris

[PATCH] D28278: [StaticAnalyzer] dont show wrong 'garbage value' warning when there is array index out of bounds

danielmarjamaki added a comment. I am not against that the error is shown as long as it's not misleading/wrong. To avoid misleading, in my humble opinion the error message should say "array index out of bounds". Repository: rL LLVM https://reviews.llvm.org/D28278

[PATCH] D28297: [StaticAnalyzer] Fix crash in CastToStructChecker

danielmarjamaki added a comment. In https://reviews.llvm.org/D28297#642523, @NoQ wrote: > Looks good. I assume the crash is in `getTypeInfo()`; do you have any idea > what are exact prerequisites for using this method? So that there were no > more crashes here. Yes. The crash happens during

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

sdardis added a comment. @joerg ping? https://reviews.llvm.org/D29032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r295172 - Use dedicated method instead of copying conditions. NFC.

Author: sepavloff Date: Wed Feb 15 06:30:35 2017 New Revision: 295172 URL: http://llvm.org/viewvc/llvm-project?rev=295172=rev Log: Use dedicated method instead of copying conditions. NFC. Modified: cfe/trunk/lib/AST/Decl.cpp Modified: cfe/trunk/lib/AST/Decl.cpp URL:

[PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

rmaprath added a comment. I've raised PR31966 to poke this :) https://reviews.llvm.org/D13289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r295167 - Removed stale comment. NFC.

Author: sepavloff Date: Wed Feb 15 05:34:11 2017 New Revision: 295167 URL: http://llvm.org/viewvc/llvm-project?rev=295167=rev Log: Removed stale comment. NFC. The case of extern inline functions in GNU89 mode is now handled in `canRedefineFunction`, which has appropriate comment. Modified:

[PATCH] D23421: [Clang-tidy] CERT-DCL58-CPP (checker for std namespace modification)

xazax.hun updated this revision to Diff 88506. xazax.hun marked 3 inline comments as done. xazax.hun retitled this revision from "[Clang-tidy] CERT-MSC53-CPP (checker for std namespace modification)" to "[Clang-tidy] CERT-DCL58-CPP (checker for std namespace modification)". xazax.hun edited the

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

vlad.tsyrklevich added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:442 + +const RecordDecl *RD = RT->getDecl()->getDefinition(); +for (const auto *I : RD->fields()) { a.sidorin wrote: > vlad.tsyrklevich wrote: > >

Re: r295156 - Add a definition for __STRUCT_PARM_ALIGN__ for elfv2 and 64-bit darwin platforms to match what other compilers produce.

On Wed, Feb 15, 2017, 00:01 Eric Christopher via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: echristo > Date: Wed Feb 15 01:50:11 2017 > New Revision: 295156 > > URL: http://llvm.org/viewvc/llvm-project?rev=295156=rev > Log: > Add a definition for __STRUCT_PARM_ALIGN__ for elfv2

r295156 - Add a definition for __STRUCT_PARM_ALIGN__ for elfv2 and 64-bit darwin platforms to match what other compilers produce.

Author: echristo Date: Wed Feb 15 01:50:11 2017 New Revision: 295156 URL: http://llvm.org/viewvc/llvm-project?rev=295156=rev Log: Add a definition for __STRUCT_PARM_ALIGN__ for elfv2 and 64-bit darwin platforms to match what other compilers produce. Modified: cfe/trunk/lib/Basic/Targets.cpp

Re: r295156 - Add a definition for __STRUCT_PARM_ALIGN__ for elfv2 and 64-bit darwin platforms to match what other compilers produce.

The PPC one should inherit from this. You're right I should have tested it though. Mostly ppc Darwin isn't well supported. On Wed, Feb 15, 2017, 12:06 AM Tim Shen wrote: > On Wed, Feb 15, 2017, 00:01 Eric Christopher via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

vlad.tsyrklevich updated this revision to Diff 88493. vlad.tsyrklevich added a comment. Remove an unnecessary call to `getBaseRegion()`, remove the logic to create a new SymbolDerived as it's currently unused, and add a comment to reflect that `getLCVSymbol()` is called in a PostStmt and a

[PATCH] D29910: [OpenMP] Specialize default schedule on a worksharing loop on the NVPTX device.

ABataev added a comment. In https://reviews.llvm.org/D29910#676777, @arpith-jacob wrote: > Hi Alexey, > > Thank you for reviewing this patch. > > > I don't like the idea of adding some kind of default scheduling, that is > > not defined in standard in Sema > > Actually, "default scheduling" is

Re: r295114 - Improve diagnostic reporting when using __declspec without enabling __declspec as a keyword.

Hi, Saw now that it's already been fixed. Sorry for the spam :/ Regards, Mikael On 02/15/2017 07:39 AM, Mikael Holmén wrote: Hi Aaron, On 02/14/2017 11:47 PM, Aaron Ballman via cfe-commits wrote: Author: aaronballman Date: Tue Feb 14 16:47:20 2017 New Revision: 295114 URL:

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

vlad.tsyrklevich added inline comments. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:502 +RegionBindingsRef B = getRegionBindings(S); +const MemRegion *MR = L.getRegion()->getBaseRegion(); +if (Optional V = B.getDefaultBinding(MR))

[PATCH] D29957: [clang-tidy] Ignore instantiated functions and static data members of classes in misc-definitions-in-headers.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

bkramer updated this revision to Diff 88515. bkramer marked 16 inline comments as done. bkramer added a comment. - Address review comments. https://reviews.llvm.org/D29886 Files: clangd/ASTManager.cpp clangd/ASTManager.h clangd/CMakeLists.txt clangd/ClangDMain.cpp

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

bkramer added inline comments. Comment at: clangd/ASTManager.cpp:21 +using namespace clang; +using namespace clangd; + ioeric wrote: > Any reason not to wrap code in namespaces instead? I don't really have an opinion one way or the other, but this seems to be

[PATCH] D28768: [clang-tidy] Add check 'modernize-return-braced-init-list'

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LGTM. Please wait for Aaron as well. Repository: rL LLVM https://reviews.llvm.org/D28768 ___ cfe-commits mailing list

[PATCH] D23421: [Clang-tidy] CERT-DCL58-CPP (checker for std namespace modification)

aaron.ballman added inline comments. Comment at: clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:28 + anyOf(hasName("std"), hasName("posix")), + has(decl(unless(cxxRecordDecl(isExplicitTemplateSpecialization()) + .bind("nmspc"), I

[libcxxabi] r295175 - Fix couple of test failures when using the LIBCXXABI_SILENT_TERMINATE mode.

Author: asiri Date: Wed Feb 15 07:43:05 2017 New Revision: 295175 URL: http://llvm.org/viewvc/llvm-project?rev=295175=rev Log: Fix couple of test failures when using the LIBCXXABI_SILENT_TERMINATE mode. When libcxxabi is built in LIBCXXABI_SILENT_TERMINATE mode, libcxx test suite reports two

[PATCH] D29986: Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier

rogfer01 created this revision. This patch fixes an assertion that is hit when a redeclaration with differing types only differs in the unaligned type-qualifier. https://reviews.llvm.org/D29986 Files: lib/AST/ASTContext.cpp test/Sema/unaligned-qualifier.c Index:

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

cierpuchaw added inline comments. Comment at: clangd/DocumentStore.h:42 /// Delete a document from the store. - void removeDocument(StringRef Uri) { Docs.erase(Uri); } + void removeDocument(StringRef Uri) { Docs.erase(Uri); +for (const auto : Listeners)

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#675687, @chandlerc wrote: > In https://reviews.llvm.org/D28404#675616, @mehdi_amini wrote: > > > We're still waiting for @rsmith to comment whether it'd be better to `have > > a LangOpts flag that basically means "pragma clang

r295266 - [Sema] Add lvalue-to-rvalue cast in direct-list-initialization of enum

Author: vedantk Date: Wed Feb 15 19:20:00 2017 New Revision: 295266 URL: http://llvm.org/viewvc/llvm-project?rev=295266=rev Log: [Sema] Add lvalue-to-rvalue cast in direct-list-initialization of enum After r264564, we allowed direct-list-initialization of an enum from an integral value in C++1z

[PATCH] D29723: [Sema] Add lvalue-to-rvalue cast in direct-list-initialization of enum

This revision was automatically updated to reflect the committed changes. Closed by commit rL295266: [Sema] Add lvalue-to-rvalue cast in direct-list-initialization of enum (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D29723?vs=87679=88632#toc Repository: rL LLVM

Re: r295252 - [Modules] Consider enable_if attrs in isSameEntity.

I remember that we wanted to pretend that pass_object_size isn't a part of the FunctionType during the review that added it, though. Do you think that would be better than serializing parameters before we serialize template info? AFAICT, we only do merging after we start reading the template info,

Re: r295252 - [Modules] Consider enable_if attrs in isSameEntity.

On 15 February 2017 at 17:32, George Burgess IV wrote: > I remember that we wanted to pretend that pass_object_size isn't a part of > the FunctionType during the review that added it, though. > I remember we wanted to not add extra fake "parameters" to the

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. LGTM, but should probably get signoff from someone else as well. https://reviews.llvm.org/D30015 ___ cfe-commits mailing list

[PATCH] D30009: Add support for '#pragma clang attribute'

hfinkel added a comment. I don't understand why it only supports some attributes. Is there some handling that needs to take place (I don't see anything obvious in this patch)? If most attributes will "just work", I'd much rather opt-out the few exceptions (which we can then explicitly

r295267 - Add missing regexp quantifiers in a test.

Author: eugenis Date: Wed Feb 15 19:35:23 2017 New Revision: 295267 URL: http://llvm.org/viewvc/llvm-project?rev=295267=rev Log: Add missing regexp quantifiers in a test. Modified: cfe/trunk/test/CodeGen/sanitize-init-order.cpp Modified: cfe/trunk/test/CodeGen/sanitize-init-order.cpp URL:

[PATCH] D28510: Reinstate CWG1607 restrictions on lambdas appearing inside certain constant-expressions

rsmith added a comment. In https://reviews.llvm.org/D28510#654821, @faisalv wrote: > In https://reviews.llvm.org/D28510#653794, @rsmith wrote: > > > I don't think it's possible to check this in the way you're doing so here. > > In general, there's no way to know whether a constant expression

Re: [PATCH] D30009: Add support for '#pragma clang attribute'

On 15 February 2017 at 17:45, Hal Finkel via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > hfinkel added a comment. > > I don't understand why it only supports some attributes. Is there some > handling that needs to take place (I don't see anything obvious in this > patch)?

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

alexfh added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54 +// FIXME use DiagnosticIDs::Level::Note +diag(NoExceptRange.getBegin(), "in a function declared no-throw here:", DiagnosticIDs::Note) +<<

[PATCH] D29884: [analyzer] Proper caching in CallDescription objects.

xazax.hun added inline comments. Comment at: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:73 + : II(nullptr), IsLookupDone(false), FuncName(FuncName), +RequiredArgs(RequiredArgs) {} NoQ wrote: > Maybe

[clang-tools-extra] r295198 - [clangd] Fix another use after free that I missed because COW strings.

Author: d0k Date: Wed Feb 15 11:04:57 2017 New Revision: 295198 URL: http://llvm.org/viewvc/llvm-project?rev=295198=rev Log: [clangd] Fix another use after free that I missed because COW strings. Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp Modified:

Re: r295224 - PR24440: Do not silently discard a fold-expression appearing as the operand of a cast-expression.

Hans, this would be a good candidate for Clang 4. The bug in question is not a regression, but it is an accepts-invalid / wrong-code bug. On 15 February 2017 at 11:57, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Wed Feb 15 13:57:10 2017 > New

Re: r295149 - Fix assertion failure due to implicit special member lookup lacking a source location.

On 15 February 2017 at 11:39, Hans Wennborg wrote: > IIUC, this is a follow-up to r291955, which was merged to 4.0. Should > this one be merged also? > Yes, please. > Cheers, > Hans > > On Tue, Feb 14, 2017 at 8:18 PM, Richard Smith via cfe-commits >

Re: r295150 - [Sema] Disallow returning a __block variable via a move.

On 15 February 2017 at 11:50, Hans Wennborg wrote: > +Richard for risk/reward analysis. > This is an extremely safe change, and fixes what amounts to a subtle miscompile. I think we should take it. > r274291 was also in 3.9, so this isn't strictly speaking a regression. > >

r295224 - PR24440: Do not silently discard a fold-expression appearing as the operand of a cast-expression.

Author: rsmith Date: Wed Feb 15 13:57:10 2017 New Revision: 295224 URL: http://llvm.org/viewvc/llvm-project?rev=295224=rev Log: PR24440: Do not silently discard a fold-expression appearing as the operand of a cast-expression. Modified: cfe/trunk/lib/Parse/ParseExpr.cpp

Re: [libcxx] r294431 - [test] Fix hard_link_count test to account for fs with dir nlink==1

Michal requested this to be merged in PR31965, it seems fine to me, and Marshall OK'd it in an email to me. Merged in r295214. On Wed, Feb 8, 2017 at 1:57 AM, Michal Gorny via cfe-commits wrote: > Author: mgorny > Date: Wed Feb 8 03:57:32 2017 > New Revision: 294431

[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters

eric_niebler added a subscriber: karies. eric_niebler added inline comments. Comment at: lib/Lex/PPDirectives.cpp:1983 + isLeadingSeparator = false; +else + Path.append(Component); What happens on Windows for an absolute path like

[PATCH] D29778: Declare lgamma library builtins as never being const

efriedma added inline comments. Comment at: include/clang/Basic/Builtins.def:1091 +LIBBUILTIN(lgammaf, "ff", "fn", "math.h", ALL_LANGUAGES) +LIBBUILTIN(lgammal, "LdLd", "fn", "math.h", ALL_LANGUAGES) Please add a comment explaining why this doesn't have an "e"

r295186 - [analyzer] Proper caching in CallDescription objects.

Author: xazax Date: Wed Feb 15 09:35:56 2017 New Revision: 295186 URL: http://llvm.org/viewvc/llvm-project?rev=295186=rev Log: [analyzer] Proper caching in CallDescription objects. During the review of D29567 it turned out the caching in CallDescription is not implemented properly. In case an

[PATCH] D29884: [analyzer] Proper caching in CallDescription objects.

xazax.hun added a comment. In https://reviews.llvm.org/D29884#677387, @NoQ wrote: > Yep, seems that somebody has missed these issues :) > > I guess there's no way to test the operator case, because nobody made a > CallDescription with an empty name for us (maybe we should even assert that).

[PATCH] D29884: [analyzer] Proper caching in CallDescription objects.

NoQ added inline comments. Comment at: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:73 + : II(nullptr), IsLookupDone(false), FuncName(FuncName), +RequiredArgs(RequiredArgs) {} Maybe `assert(FuncName.size() > 0)` here?

[clang-tools-extra] r295192 - [clang-tidy] Don't delay parsing of templates in test for misc-unconventional-assign-operator

Author: malcolm.parsons Date: Wed Feb 15 10:32:55 2017 New Revision: 295192 URL: http://llvm.org/viewvc/llvm-project?rev=295192=rev Log: [clang-tidy] Don't delay parsing of templates in test for misc-unconventional-assign-operator Modified:

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

sdardis added a comment. Ok, I'll have `__mips_abicalls` unconditionally defined for everyone, The other two BSD's will have the traditional macro defined as well. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list

[PATCH] D29990: [clangd] Implement format on type

bkramer added inline comments. Comment at: clangd/ProtocolHandlers.cpp:117 + // starting from there. + StringRef Code = Store.getDocument(DOTFP->textDocument.uri); + size_t CursorPos = positionToOffset(Code, DOTFP->position); This should be a std::string in

[clang-tools-extra] r295205 - Fixed indentation issue in release notes

Author: jdevlieghere Date: Wed Feb 15 11:19:44 2017 New Revision: 295205 URL: http://llvm.org/viewvc/llvm-project?rev=295205=rev Log: Fixed indentation issue in release notes Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL:

[clang-tools-extra] r295207 - [clang-tidy] Fix test modernize-return-braced-init-list

Author: jdevlieghere Date: Wed Feb 15 11:37:58 2017 New Revision: 295207 URL: http://llvm.org/viewvc/llvm-project?rev=295207=rev Log: [clang-tidy] Fix test modernize-return-braced-init-list Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-return-braced-init-list.cpp Modified:

[PATCH] D26654: [CMake] Add Fuchsia toolchain CMake cache files

phosek updated this revision to Diff 88575. Repository: rL LLVM https://reviews.llvm.org/D26654 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- /dev/null +++

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

This revision was automatically updated to reflect the committed changes. Closed by commit rL295180: [clangd] Wire up ASTUnit and publish diagnostics with it. (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D29886?vs=88523=88532#toc Repository: rL LLVM

[clang-tools-extra] r295180 - [clangd] Wire up ASTUnit and publish diagnostics with it.

Author: d0k Date: Wed Feb 15 09:04:20 2017 New Revision: 295180 URL: http://llvm.org/viewvc/llvm-project?rev=295180=rev Log: [clangd] Wire up ASTUnit and publish diagnostics with it. Summary: This requires an accessible compilation database. The parsing is done asynchronously on a separate

[clang-tools-extra] r295184 - [clangd] Add missing include.

Author: d0k Date: Wed Feb 15 09:19:13 2017 New Revision: 295184 URL: http://llvm.org/viewvc/llvm-project?rev=295184=rev Log: [clangd] Add missing include. Modified: clang-tools-extra/trunk/clangd/DocumentStore.h Modified: clang-tools-extra/trunk/clangd/DocumentStore.h URL:

[PATCH] D29884: [analyzer] Proper caching in CallDescription objects.

This revision was automatically updated to reflect the committed changes. Closed by commit rL295186: [analyzer] Proper caching in CallDescription objects. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D29884?vs=88166=88537#toc Repository: rL LLVM

[PATCH] D29884: [analyzer] Proper caching in CallDescription objects.

NoQ added inline comments. Comment at: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:73 + : II(nullptr), IsLookupDone(false), FuncName(FuncName), +RequiredArgs(RequiredArgs) {} xazax.hun wrote: > NoQ wrote: > > Maybe

[clang-tools-extra] r295193 - [clangd] Initialize the thread after the mutex.

Author: d0k Date: Wed Feb 15 10:34:58 2017 New Revision: 295193 URL: http://llvm.org/viewvc/llvm-project?rev=295193=rev Log: [clangd] Initialize the thread after the mutex. Otherwise locking the mutex yields a racy assertion failure on picky implementations. Modified:

[libunwind] r295202 - Revert "[libunwind][CMake] Use libc++ headers when available"

Author: phosek Date: Wed Feb 15 11:15:41 2017 New Revision: 295202 URL: http://llvm.org/viewvc/llvm-project?rev=295202=rev Log: Revert "[libunwind][CMake] Use libc++ headers when available" This causing build failure on sanitizer bots because of the unused argument '-nostdinc++' during linking

[PATCH] D28297: [StaticAnalyzer] Fix crash in CastToStructChecker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I sometimes wish ASTContext methods just didn't crash :) Oh well, let's just see if more problems show up. Comment at: lib/StaticAnalyzer/Checkers/CastToStructChecker.cpp:93

r295191 - [index] USR generation: use getTemplateArgs() instead of getTemplateInstantiationArgs()

Author: akirtzidis Date: Wed Feb 15 10:16:27 2017 New Revision: 295191 URL: http://llvm.org/viewvc/llvm-project?rev=295191=rev Log: [index] USR generation: use getTemplateArgs() instead of getTemplateInstantiationArgs() Otherwise we may end up creating a different USR for the definition of a

[PATCH] D28768: [clang-tidy] Add check 'modernize-return-braced-init-list'

JDevlieghere updated this revision to Diff 88550. JDevlieghere added a comment. Fixed latest comment from @aaron.ballman before landing. Repository: rL LLVM https://reviews.llvm.org/D28768 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

[clang-tools-extra] r295194 - [clangd] Synchronize logs access.

Author: d0k Date: Wed Feb 15 10:44:11 2017 New Revision: 295194 URL: http://llvm.org/viewvc/llvm-project?rev=295194=rev Log: [clangd] Synchronize logs access. I don't think that this is necessary for correctness, but makes tsan much more useful. Modified:

[clang-tools-extra] r295199 - [clang-tidy] Add check 'modernize-return-braced-init-list'

Author: jdevlieghere Date: Wed Feb 15 11:06:06 2017 New Revision: 295199 URL: http://llvm.org/viewvc/llvm-project?rev=295199=rev Log: [clang-tidy] Add check 'modernize-return-braced-init-list' Summary: Replaces explicit calls to the constructor in a return with a braced initializer list. This

r295183 - Fix spelling mistake - paramater -> parameter. NFCI.

Author: rksimon Date: Wed Feb 15 09:12:06 2017 New Revision: 295183 URL: http://llvm.org/viewvc/llvm-project?rev=295183=rev Log: Fix spelling mistake - paramater -> parameter. NFCI. Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp cfe/trunk/lib/CodeGen/CGCall.cpp

[clang-tools-extra] r295187 - [clangd] Fix use after free.

Author: d0k Date: Wed Feb 15 09:56:14 2017 New Revision: 295187 URL: http://llvm.org/viewvc/llvm-project?rev=295187=rev Log: [clangd] Fix use after free. Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp URL:

[PATCH] D23421: [Clang-tidy] CERT-DCL58-CPP (checker for std namespace modification)

xazax.hun updated this revision to Diff 88541. xazax.hun added a comment. - Do not warn for function specializations within the std namespace. - Add a test case for swap. https://reviews.llvm.org/D23421 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt

[clang-tools-extra] r295196 - [clangd] Silence GCC warning about falling off a fully covered switch.

Author: d0k Date: Wed Feb 15 10:58:44 2017 New Revision: 295196 URL: http://llvm.org/viewvc/llvm-project?rev=295196=rev Log: [clangd] Silence GCC warning about falling off a fully covered switch. Modified: clang-tools-extra/trunk/clangd/ASTManager.cpp Modified:

[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters

eric_niebler added a comment. My question was more about whether the code is correct for absolute paths on Windows, not about whether this particular test would pass or fail. Have you tested an incorrectly-cased absolute path on a Windows machine? https://reviews.llvm.org/D3

Re: r295150 - [Sema] Disallow returning a __block variable via a move.

On Wed, Feb 15, 2017 at 12:17 PM, Richard Smith wrote: > On 15 February 2017 at 11:50, Hans Wennborg wrote: >> >> +Richard for risk/reward analysis. > > > This is an extremely safe change, and fixes what amounts to a subtle > miscompile. I think we

[PATCH] D24812: Lit C++11 Compatibility Patch #11

rnk added inline comments. Comment at: test/CodeGenCXX/static-init.cpp:14 +// CHECK98: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global %"struct.test4::HasVTable" zeroinitializer, comdat, align 8 +// CHECK11: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global {

[PATCH] D28297: [StaticAnalyzer] Fix crash in CastToStructChecker

zaks.anna added a comment. Please, make sure future reviews go through cfg-dev list. See http://llvm.org/docs/Phabricator.html. Repository: rL LLVM https://reviews.llvm.org/D28297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Patch for Bug 30413, including test case

Hi All, I am re-submitting my patch for Bug 30413, this time with a test case included as well (ivar-type-encoding.m). The test case file should be added to clang/test/CodeGenObjC. The test verifies that correct metadata is emitted by clang for an object-valued instance variable. I've

[PATCH] D29599: Clang Changes for alloc_align

erichkeane updated this revision to Diff 88602. erichkeane added a comment. I was able to get the templated versions working in response to the discussion with Akira. Note the added test file which shows off all of the combos I could think of. It required a little bit of surgery inside the

[PATCH] D28278: [StaticAnalyzer] dont show wrong 'garbage value' warning when there is array index out of bounds

zaks.anna added a comment. Does the code you added detects array out of bounds cases without false positives? Is it an option to just have this checkers produce a more precise error message in the specific case. A lot of work will probably need to be done to implement a proper array out of

Re: r295149 - Fix assertion failure due to implicit special member lookup lacking a source location.

On Wed, Feb 15, 2017 at 12:14 PM, Richard Smith wrote: > On 15 February 2017 at 11:39, Hans Wennborg wrote: >> >> IIUC, this is a follow-up to r291955, which was merged to 4.0. Should >> this one be merged also? > > > Yes, please. r295233. > >> >>

r295245 - Fix the static build.

Author: rafael Date: Wed Feb 15 16:19:04 2017 New Revision: 295245 URL: http://llvm.org/viewvc/llvm-project?rev=295245=rev Log: Fix the static build. Modified: cfe/trunk/tools/c-index-test/CMakeLists.txt Modified: cfe/trunk/tools/c-index-test/CMakeLists.txt URL:

r295252 - [Modules] Consider enable_if attrs in isSameEntity.

Author: gbiv Date: Wed Feb 15 16:43:27 2017 New Revision: 295252 URL: http://llvm.org/viewvc/llvm-project?rev=295252=rev Log: [Modules] Consider enable_if attrs in isSameEntity. Two functions that differ only in their enable_if attributes are considered overloads, so we should check for those

  1   2   >