[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama updated this revision to Diff 88662. pirama added a comment. Changed the name of the utility that builds the arch-specific directory. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama updated this revision to Diff 88663. pirama added a comment. Use getArchTypeName() instead of getArchName(). https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp

[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters

karies added inline comments. Comment at: lib/Lex/PPDirectives.cpp:1983 + isLeadingSeparator = false; +else + Path.append(Component); eric_niebler wrote: > What happens on Windows for an absolute path like "C:/hello/world.h", I >

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

mgorny added inline comments. Comment at: lib/Driver/Tools.cpp:3267 + if (llvm::sys::fs::is_directory(CandidateLibPath)) +CmdArgs.push_back(Args.MakeArgString("-L" + CandidateLibPath)); + Don't you also need rpath for it? Or is this purely for static

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

mgorny added inline comments. Comment at: lib/Driver/ToolChain.cpp:327 + llvm::sys::path::append(Path, "lib", OSLibName, + getArchName()); + return Path.str(); I would suggest using arch type, to avoid e.g. i386/i486/i586 mess. It's

Re: r294954 - Fix r291495 -- Normalize LLVM_CMAKE_PATH in clang standalone build.

Michał, It'd make sense to use file(TO_CMAKE_PATH). I forgot it. I think get_file_component() satisfies in this case. Do you think to use file(TO_CMAKE_PATH) anyways? I'll wait for you as an opinion before proposing this fix to release_40. The bug is still in release_40. I don't think we could

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

rsmith added a comment. Other than (5), all the failing cases look like they should fail per the current `basic_string` spec. Comment at: test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp:57 + { // Testing (2) +// FIXME: (2) doesn't work with

[libcxx] r295390 - add tests for ENAMETOOLONG

Author: ericwf Date: Thu Feb 16 19:00:37 2017 New Revision: 295390 URL: http://llvm.org/viewvc/llvm-project?rev=295390=rev Log: add tests for ENAMETOOLONG Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.exists/exists.pass.cpp

[PATCH] D30035: Add const to function parameters

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. This change is ABI breaking because these functions are exported using explicit template instantiations, and because changing their signature changes the mangling. Can you explain

[libcxx] r295399 - update revision in CHANGELOG.TXT and fix python error

Author: ericwf Date: Thu Feb 16 19:56:57 2017 New Revision: 295399 URL: http://llvm.org/viewvc/llvm-project?rev=295399=rev Log: update revision in CHANGELOG.TXT and fix python error Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT libcxx/trunk/utils/libcxx/sym_check/extract.py Modified:

[PATCH] D29967: Get class property selectors from property decl if it exists

compnerd added a comment. I think Im misunderstanding something. How does the test actually test what you are changing? https://reviews.llvm.org/D29967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r295403 - Mark a couple for basic_string member templates as inline. no ABI change this time.

Author: ericwf Date: Thu Feb 16 20:31:56 2017 New Revision: 295403 URL: http://llvm.org/viewvc/llvm-project?rev=295403=rev Log: Mark a couple for basic_string member templates as inline. no ABI change this time. Modified: libcxx/trunk/include/string Modified: libcxx/trunk/include/string

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

EricWF added inline comments. Comment at: test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp:57 + { // Testing (2) +// FIXME: (2) doesn't work with implicit deduction. +// const test_allocator alloc{}; rsmith wrote: > I think

Re: [libcxx] r294116 - Remove CMake hack

Sorry about the breakage. I'm not sure what else to do. The hack had been sitting there for more than a month IIRC. Any advice for next time? /Eric On Thu, Feb 16, 2017 at 7:00 PM, Justin Bogner wrote: > Eric Fiselier via cfe-commits

[PATCH] D30009: Add support for '#pragma clang attribute'

arphaman added inline comments. Comment at: include/clang/Basic/Attr.td:308-311 + // - An attribute requires delayed parsing (LateParsed is on) + // - An attribute has no GNU/CXX11 spelling + // - An attribute has no subject list + // - An attribute derives from a StmtAttr

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

EricWF added a comment. I applied `inline` to most of the functions changed in `basic_string`, and updated the ABI lists accordingly. Please update this patch so it merges with trunk. Note you can add `_LIBCPP_HIDDEN` to the functions in `basic_string` as well if you want, however the

r295404 - Added doxygen comments to smmintrin.h's intrinsics.

Author: kromanova Date: Thu Feb 16 20:49:50 2017 New Revision: 295404 URL: http://llvm.org/viewvc/llvm-project?rev=295404=rev Log: Added doxygen comments to smmintrin.h's intrinsics. Note: The doxygen comments are automatically generated based on Sony's intrinsic s document. I got an OK from

[PATCH] D30045: Remove `std::random_shuffle` in C++17

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after fixing inline comments. Comment at: include/algorithm:3029 +#if _LIBCPP_STD_VER <= 14 || defined(_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE) class

[PATCH] D29530: [ubsan] Reduce null checking of C++ object pointers (PR27581)

This revision was automatically updated to reflect the committed changes. Closed by commit rL295391: [ubsan] Reduce null checking of C++ object pointers (PR27581) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D29530?vs=88259=88808#toc Repository: rL LLVM

r295391 - [ubsan] Reduce null checking of C++ object pointers (PR27581)

Author: vedantk Date: Thu Feb 16 19:05:42 2017 New Revision: 295391 URL: http://llvm.org/viewvc/llvm-project?rev=295391=rev Log: [ubsan] Reduce null checking of C++ object pointers (PR27581) This patch teaches ubsan to insert exactly one null check for the 'this' pointer per method/lambda.

Re: [libcxx] r294116 - Remove CMake hack

Eric Fiselier via cfe-commits writes: > Author: ericwf > Date: Sat Feb 4 19:19:02 2017 > New Revision: 294116 > > URL: http://llvm.org/viewvc/llvm-project?rev=294116=rev > Log: > Remove CMake hack FWIW, I just spent half an hour trying to figure out why a tree I

r295401 - Retry: [ubsan] Reduce null checking of C++ object pointers (PR27581)

Author: vedantk Date: Thu Feb 16 20:03:51 2017 New Revision: 295401 URL: http://llvm.org/viewvc/llvm-project?rev=295401=rev Log: Retry: [ubsan] Reduce null checking of C++ object pointers (PR27581) This patch teaches ubsan to insert exactly one null check for the 'this' pointer per

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

EricWF added inline comments. Comment at: include/locale:626 template +_LIBCPP_HIDDEN iter_type __do_get_floating_point After applying the changes to `__config` but not this header `check-cxx-abilist` didn't report any changes to these symbols.

[libcxx] r295393 - [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

Author: ericwf Date: Thu Feb 16 19:17:10 2017 New Revision: 295393 URL: http://llvm.org/viewvc/llvm-project?rev=295393=rev Log: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types. Summary: This patch fixes http://llvm.org/PR31938. The description below is

[PATCH] D29818: [libcxx] Threading support: Attempt to externalize system_clock::now() and steady_clock::now() implementations

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. I really don't like this change (and https://reviews.llvm.org/D29757) because they start to include a ton of extra headers, and because they lift complex configuration logic into

[PATCH] D29757: [libcxx] Threading support: Externalize hardware_concurrency()

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Same comment as https://reviews.llvm.org/D29818 I really don't like this change (and https://reviews.llvm.org/D29818) because they start to include a ton of extra headers, and

r295396 - Revert "[ubsan] Reduce null checking of C++ object pointers (PR27581)"

Author: vedantk Date: Thu Feb 16 19:42:36 2017 New Revision: 295396 URL: http://llvm.org/viewvc/llvm-project?rev=295396=rev Log: Revert "[ubsan] Reduce null checking of C++ object pointers (PR27581)" This reverts commit r295391. It breaks this bot:

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

EricWF added inline comments. Comment at: include/string:1100 template +inline _LIBCPP_INLINE_VISIBILITY typename enable_if Why `inline _LIBCPP_INLINE_VISIBILITY` here but `_LIBCPP_HIDDEN` everywhere else? https://reviews.llvm.org/D29157

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

mgorny added inline comments. Comment at: test/Driver/arch-specific-libdir.c:6 +// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \ +// RUN: | FileCheck --check-prefix=CHECK-ARCHDIR %s +// Please be more specific in the tests, i.e. check if the

[PATCH] D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization.

EricWF updated this revision to Diff 88794. EricWF retitled this revision from "Add `__is_direct_constructible` trait for checking safe reference initialization." to "Add `__reference_binds_to_temporary` trait for checking safe reference initialization.". EricWF edited the summary of this

r295381 - Use correct fix-it location for -Wblock-capture-autoreleasing

Author: arphaman Date: Thu Feb 16 17:15:36 2017 New Revision: 295381 URL: http://llvm.org/viewvc/llvm-project?rev=295381=rev Log: Use correct fix-it location for -Wblock-capture-autoreleasing The '__autoreleasing' keyword should be inserted after the Objective-C pointer type. rdar://30123548

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama updated this revision to Diff 88799. pirama added a comment. Stricter tests. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp test/Driver/Inputs/resource_dir_with_arch_subdir/lib/linux/aarch64/.keep

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

EricWF updated this revision to Diff 88803. EricWF added a comment. - Enumerate and test each constructor. https://reviews.llvm.org/D29863 Files: include/string test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp utils/libcxx/test/config.py Index:

Re: [PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

Richard, can you take a look when you have a moment? The PR is marked as a release blocker. On Thu, Feb 9, 2017 at 1:54 PM, Duncan P. N. Exon Smith via Phabricator via cfe-commits wrote: > dexonsmith added a comment. > > I'm not comfortable signing off on this, but it

[PATCH] D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization.

EricWF updated this revision to Diff 88795. EricWF added a comment. Remove test code that snuck in. https://reviews.llvm.org/D29930 Files: docs/LanguageExtensions.rst include/clang/Basic/TokenKinds.def include/clang/Basic/TypeTraits.h lib/Parse/ParseDeclCXX.cpp

[PATCH] D30009: Add support for '#pragma clang attribute'

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:308-311 + // - An attribute requires delayed parsing (LateParsed is on) + // - An attribute has no GNU/CXX11 spelling + // - An attribute has no subject list + // - An attribute derives from a

[PATCH] D29901: Modular Codegen: Add/use a bit in serialized function definitions to track whether they are the subject of modular codegen

dblaikie updated this revision to Diff 88792. dblaikie added a comment. - Simplify ModuleFile lookup https://reviews.llvm.org/D29901 Files: include/clang/AST/ExternalASTSource.h include/clang/Sema/MultiplexExternalSemaSource.h include/clang/Serialization/ASTReader.h

[PATCH] D30009: Add support for '#pragma clang attribute'

arphaman added inline comments. Comment at: include/clang/Basic/Attr.td:308-311 + // - An attribute requires delayed parsing (LateParsed is on) + // - An attribute has no GNU/CXX11 spelling + // - An attribute has no subject list + // - An attribute derives from a StmtAttr

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +// REQUIRES: native +// pirama wrote: > I feel this test is fragile. Any idea how to further restrict and require > that

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

rsmith added a comment. It seems to me that the problem here is that `DeclMustBeEmitted` is not safe to call in the middle of deserialization if anything partially-deserialized might be reachable from the declaration we're querying, and yet we're currently calling it in that case. I don't see

[libcxx] r295406 - [libcxx] Remove unexpected handlers in C++17

Author: ericwf Date: Thu Feb 16 21:25:08 2017 New Revision: 295406 URL: http://llvm.org/viewvc/llvm-project?rev=295406=rev Log: [libcxx] Remove unexpected handlers in C++17 Summary: This patch implements [P0003R5](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0003r5.html) which

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

EricWF marked an inline comment as done. EricWF added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2479 +case Type::DeducedTemplateSpecialization: { + QualType DT = dyn_cast(T)->getDeducedType(); + assert(!DT.isNull() && "Undeduced types shouldn't reach

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

mgorny added a comment. Thanks. The -L tests look good, -rpath is not perfect but I don't think you can improve it without additional changes to the Driver. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +//

[libcxx] r295428 - Use inline namespaces with GCC instead of __attribute__((__strong__)).

Author: ericwf Date: Fri Feb 17 01:31:38 2017 New Revision: 295428 URL: http://llvm.org/viewvc/llvm-project?rev=295428=rev Log: Use inline namespaces with GCC instead of __attribute__((__strong__)). GCC 7.0.1 started warning that __attribute__((__strong__)) is depricated. This patch switches to

[PATCH] D29806: [clang-tidy] Add -path option to clang-tidy-diff.py

ehsan added a comment. Gentle ping. :-) https://reviews.llvm.org/D29806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24812: Lit C++11 Compatibility Patch #11

rjmccall added inline comments. Comment at: test/CodeGenCXX/static-init.cpp:14 +// CHECK98: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global %"struct.test4::HasVTable" zeroinitializer, comdat, align 8 +// CHECK11: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai added a comment. Will do the rebase. Comment at: include/locale:626 template +_LIBCPP_HIDDEN iter_type __do_get_floating_point EricWF wrote: > After applying the changes to `__config` but not this header > `check-cxx-abilist` didn't

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 88854. smeenai added a comment. Rebase https://reviews.llvm.org/D29157 Files: include/__config include/locale include/string Index: include/string === --- include/string +++

r295421 - Add better ODR checking for modules.

Author: rtrieu Date: Thu Feb 16 23:54:30 2017 New Revision: 295421 URL: http://llvm.org/viewvc/llvm-project?rev=295421=rev Log: Add better ODR checking for modules. A slightly weaker form of ODR checking than previous attempts, but hopefully won't break the modules build bot. Future work will

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

Hahnfeld added a comment. Please adapt the title and summary for the more general changes this has evolved to. Comment at: lib/Driver/Tools.cpp:284 +// If we are not cross-compling, add '-rpath' with architecture-specific +// library path so libraries lined from this

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

Hahnfeld added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +// REQUIRES: native +// mgorny wrote: > Hahnfeld wrote: > > pirama wrote: > > > pirama wrote: > > > > I feel this test is

[PATCH] D30045: Remove `std::random_shuffle` in C++17

EricWF added a comment. @mclow.lists A couple of additional things: - Add `_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE` to the `_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES` list in `__config`. - Add a test for that in `test/libcxx/depr/enable_removed_cpp17_features.pass.cpp`

[PATCH] D29986: Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier

rjmccall added a comment. LGTM. https://reviews.llvm.org/D29986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r295411 - Fix test_exception_storage.pass.cpp in C++17 my re-enabling the unexpected handlers

Author: ericwf Date: Thu Feb 16 22:26:22 2017 New Revision: 295411 URL: http://llvm.org/viewvc/llvm-project?rev=295411=rev Log: Fix test_exception_storage.pass.cpp in C++17 my re-enabling the unexpected handlers Modified: libcxxabi/trunk/test/test_exception_storage.pass.cpp Modified:

r295416 - [index] Improvde how we handle synthesized ObjC properties and the associated ivars.

Author: akirtzidis Date: Thu Feb 16 22:49:41 2017 New Revision: 295416 URL: http://llvm.org/viewvc/llvm-project?rev=295416=rev Log: [index] Improvde how we handle synthesized ObjC properties and the associated ivars. Related synthesized properties with the ivar they use with the 'accessor'

[libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.

Author: ericwf Date: Thu Feb 16 23:04:09 2017 New Revision: 295417 URL: http://llvm.org/viewvc/llvm-project?rev=295417=rev Log: Work around Clang assertion when testing C++17 deduction guides with '-g'. Modified:

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

EricWF updated this revision to Diff 88861. EricWF marked an inline comment as done. EricWF added a comment. Address @majnemer's comments. https://reviews.llvm.org/D30082 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-template-deduction-guide.cpp Index:

[libcxx] r295423 - Remove dead code in test

Author: ericwf Date: Fri Feb 17 01:00:04 2017 New Revision: 295423 URL: http://llvm.org/viewvc/llvm-project?rev=295423=rev Log: Remove dead code in test Modified: libcxx/trunk/test/std/strings/string.view/string.view.cons/implicit_deduction_guides.pass.cpp Modified:

[PATCH] D28172: [libcxx] Remove unexpected handlers in C++17

EricWF updated this revision to Diff 88843. EricWF added a comment. - Update so that it merges with master. - add `_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES` macro for re-enabling all removed C++17 features. https://reviews.llvm.org/D28172 Files: docs/UsingLibcxx.rst include/__config

[libcxx] r295407 - Add doc for _LIBCPP_ENABLE_CXX17_DISABLED_AUTO_PTR and make it work under _LIBCPP_ENABLE_CXX17_REMOVED_FEATURES

Author: ericwf Date: Thu Feb 16 21:30:25 2017 New Revision: 295407 URL: http://llvm.org/viewvc/llvm-project?rev=295407=rev Log: Add doc for _LIBCPP_ENABLE_CXX17_DISABLED_AUTO_PTR and make it work under _LIBCPP_ENABLE_CXX17_REMOVED_FEATURES Modified: libcxx/trunk/docs/UsingLibcxx.rst

[PATCH] D29967: Get class property selectors from property decl if it exists

herzka added a comment. Currently, `A.customGetterProperty` would be turned into `[A customGetterProperty]`, which would fail to compile because that selector isn't declared anywhere. With my fix, it does compile because it (correctly) resolves to `[A customGet]`, which does exist. Similarly,

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

EricWF updated this revision to Diff 88852. EricWF added a comment. - Update so that it merges with https://reviews.llvm.org/D26057 https://reviews.llvm.org/D26316 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp lib/Sema/SemaExprMember.cpp

r295427 - Revert r295421, new ODR checker for modules, to fix build bot.

Author: rtrieu Date: Fri Feb 17 01:19:24 2017 New Revision: 295427 URL: http://llvm.org/viewvc/llvm-project?rev=295427=rev Log: Revert r295421, new ODR checker for modules, to fix build bot. Removed: cfe/trunk/include/clang/AST/ODRHash.h cfe/trunk/lib/AST/ODRHash.cpp

r295311 - [OpenCL] Correct ndrange_t implementation

Author: stulova Date: Thu Feb 16 06:27:47 2017 New Revision: 295311 URL: http://llvm.org/viewvc/llvm-project?rev=295311=rev Log: [OpenCL] Correct ndrange_t implementation Removed ndrange_t as Clang builtin type and added as a struct type in the OpenCL header. Use type name to do the Sema

[PATCH] D29943: [clang-format] Align block comment decorations

sylvestre.ledru added a comment. Maybe this could be added to the release notes? Repository: rL LLVM https://reviews.llvm.org/D29943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30035: Add const to function parameters

sebpop added a comment. Looks good to me. https://reviews.llvm.org/D30035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30025: [compiler-rt] [builtins] Fix building atomic.c with GCC

theraven added a comment. No, it's a bug in clang. Clang does not reject other functions that are used to implement builtins (if it did, compiler-rt would be a lot more difficult to build). Repository: rL LLVM https://reviews.llvm.org/D30025

[PATCH] D28058: [OpenCL] Correct ndrange_t implementation

Anastasia closed this revision. Anastasia added a comment. Committed in 295311 https://reviews.llvm.org/D28058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29724: [Driver] Report available language standards on user error

idlecode closed this revision. idlecode added a comment. Committed as r295113 https://reviews.llvm.org/D29724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29943: [clang-format] Align block comment decorations

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29879: [OpenMP] Teams reduction on the NVPTX device.

arpith-jacob updated this revision to Diff 88715. arpith-jacob added a comment. Addressed review comments. https://reviews.llvm.org/D29879 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp lib/CodeGen/CGStmtOpenMP.cpp test/OpenMP/nvptx_teams_reduction_codegen.cpp Index:

[PATCH] D29758: [OpenMP] Parallel reduction on the NVPTX device.

This revision was automatically updated to reflect the committed changes. Closed by commit rL295319: [OpenMP] Parallel reduction on the NVPTX device. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D29758?vs=88149=88726#toc Repository: rL LLVM

[PATCH] D30025: [compiler-rt] [builtins] Fix building atomic.c with GCC

joerg added a comment. Note that the normal compiler-rt functions have a different name than the builtins they provide, at least from the C frontend view. Repository: rL LLVM https://reviews.llvm.org/D30025 ___ cfe-commits mailing list

r295323 - Revert r295319 while investigating buildbot failure.

Author: arpith Date: Thu Feb 16 08:25:35 2017 New Revision: 295323 URL: http://llvm.org/viewvc/llvm-project?rev=295323=rev Log: Revert r295319 while investigating buildbot failure. Removed: cfe/trunk/test/OpenMP/nvptx_target_parallel_reduction_codegen.cpp Modified:

r295319 - [OpenMP] Parallel reduction on the NVPTX device.

Author: arpith Date: Thu Feb 16 08:03:36 2017 New Revision: 295319 URL: http://llvm.org/viewvc/llvm-project?rev=295319=rev Log: [OpenMP] Parallel reduction on the NVPTX device. This patch implements codegen for the reduction clause on any parallel construct for elementary data types. An

[PATCH] D29943: [clang-format] Align block comment decorations

This revision was automatically updated to reflect the committed changes. Closed by commit rL295312: [clang-format] Align block comment decorations (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D29943?vs=88713=88714#toc Repository: rL LLVM

r295312 - [clang-format] Align block comment decorations

Author: krasimir Date: Thu Feb 16 06:39:31 2017 New Revision: 295312 URL: http://llvm.org/viewvc/llvm-project?rev=295312=rev Log: [clang-format] Align block comment decorations Summary: This patch implements block comment decoration alignment. source: ``` /* line 1 * line 2 */ ``` result

Re: r295279 - [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

Of course Richard - I'll be happy to bump that value for C++1z hopefully later today. Thanks! Faisal Vali On Wed, Feb 15, 2017 at 10:30 PM, Richard Smith wrote: > On 15 February 2017 at 20:12, Faisal Vali via cfe-commits > wrote: >> >>

[clang-tools-extra] r295317 - Fix clang-move test after clang-format update r295312

Author: krasimir Date: Thu Feb 16 07:17:38 2017 New Revision: 295317 URL: http://llvm.org/viewvc/llvm-project?rev=295317=rev Log: Fix clang-move test after clang-format update r295312 Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp Modified:

[PATCH] D29830: [OpenCL][Doc] Relase 4.0 notes for OpenCL

Anastasia closed this revision. Anastasia added a comment. Committed to release40@295315 https://reviews.llvm.org/D29830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r295320 - Silence sign compare warning. NFC.

Author: d0k Date: Thu Feb 16 08:08:41 2017 New Revision: 295320 URL: http://llvm.org/viewvc/llvm-project?rev=295320=rev Log: Silence sign compare warning. NFC. ExprConstant.cpp:6344:20: warning: comparison of integers of different signs: 'const size_t' (aka 'const unsigned long') and 'typename

[PATCH] D29764: [OpenCL] Blocks cannot capture/reference another block

Anastasia closed this revision. Anastasia added a comment. Committed in r295307! https://reviews.llvm.org/D29764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

Hahnfeld added a comment. In https://reviews.llvm.org/D30015#678294, @pirama wrote: > I am fine to do this more generally, but not sure of the scope. Should this > be always added or only if a runtime (sanitizer or openmp or xray) is > requested? I think always. From my point of view, this

[PATCH] D29943: [clang-format] Align block comment decorations

krasimir updated this revision to Diff 88713. krasimir added a comment. - Align decorations of block comments spanning two lines https://reviews.llvm.org/D29943 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h unittests/Format/FormatTest.cpp

r295313 - [OpenCL][Doc] Added OpenCL vendor extension description to user manual doc

Author: stulova Date: Thu Feb 16 06:49:29 2017 New Revision: 295313 URL: http://llvm.org/viewvc/llvm-project?rev=295313=rev Log: [OpenCL][Doc] Added OpenCL vendor extension description to user manual doc Added description of a new feature that allows to specify vendor extension in flexible way

[PATCH] D29879: [OpenMP] Teams reduction on the NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29829: [OpenCL][Doc] Description for adding OpenCL vendor extension in user manual

Anastasia closed this revision. Anastasia added a comment. Committed in 295313! https://reviews.llvm.org/D29829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: D29829: [OpenCL][Doc] Description for adding OpenCL vendor extension in user manual

Hans, could we merge this documentation only change (r295313) in release40 branch. I can commit myself if needed. :) Thanks in advance, Anastasia -Original Message- From: Anastasia Stulova via Phabricator [mailto:revi...@reviews.llvm.org] Sent: 16 February 2017 14:15 To: Anastasia

[PATCH] D30035: Add const to function parameters

hiraditya created this revision. https://reviews.llvm.org/D30035 Files: include/locale Index: include/locale === --- include/locale +++ include/locale @@ -385,12 +385,12 @@ _CharT&

[PATCH] D29922: [OpenMP] Prepare Sema for initial implementation for pragma 'distribute parallel for'

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D29922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29755: Cache FileID when translating diagnostics in PCH files

This revision was automatically updated to reflect the committed changes. Closed by commit rL295301: Cache FileID when translating diagnostics in PCH files (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D29755?vs=88366=88701#toc Repository: rL LLVM

[PATCH] D29990: [clangd] Implement format on type

krasimir updated this revision to Diff 88703. krasimir edited the summary of this revision. krasimir added a comment. - Address review comments https://reviews.llvm.org/D29990 Files: clangd/ClangDMain.cpp clangd/Protocol.cpp clangd/Protocol.h clangd/ProtocolHandlers.cpp

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

redm123 added a comment. In https://reviews.llvm.org/D29944#678033, @arphaman wrote: > Do these diagnostics have the full qualifiers for errors that occur with > record types instead of typedefs? Not sure what you mean by that, but as far as I can see all the changed errors refer to

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama added a subscriber: openmp-commits. pirama marked an inline comment as done. pirama added inline comments. Comment at: lib/Driver/Tools.cpp:3267 + if (llvm::sys::fs::is_directory(CandidateLibPath)) +CmdArgs.push_back(Args.MakeArgString("-L" + CandidateLibPath)); +

[PATCH] D29879: [OpenMP] Teams reduction on the NVPTX device.

arpith-jacob marked an inline comment as done. arpith-jacob added a comment. Alexey, do you any more comments on this patch? https://reviews.llvm.org/D29879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

Hahnfeld added a comment. Maybe something like the following (without tests): diff --git a/include/clang/Driver/ToolChain.h b/include/clang/Driver/ToolChain.h index ffb0d60..0f3507d 100644 --- a/include/clang/Driver/ToolChain.h +++ b/include/clang/Driver/ToolChain.h @@ -299,6 +299,11

[PATCH] D30032: Process attributes 'ifunc' and 'alias' when checking for redefinition

sepavloff created this revision. These attributes effectively turns a non-defining declaration into a definition, so the case when the declaration already has a body must be diagnosed properly. https://reviews.llvm.org/D30032 Files: lib/Sema/SemaDecl.cpp test/Sema/alias-redefinition.c

[PATCH] D30034: [clang-tidy] Fix a false positive for explicit template instantiations in misc-unused-using-decls.

alexfh added a comment. Richard, it seems like the AST could be improved here by adding nodes for the explicit instantiation declarations and definitions or using existing nodes, if there are suitable ones. What do you think? https://reviews.llvm.org/D30034

[PATCH] D29943: [clang-format] Align block comment decorations

klimek added inline comments. Comment at: lib/Format/BreakableToken.cpp:397 +// +// Don't try aligning if there are less lines, since some patterns like +// fewer lines Comment at: lib/Format/BreakableToken.cpp:402 +

[PATCH] D29990: [clangd] Implement format on type

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >