[PATCH] D29986: Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier

rogfer01 added a comment. Sorry for the noise. I was expecting some more formal approval in the usual form of "Ready to land" but if you think it is OK I will commit it shortly. Regards. https://reviews.llvm.org/D29986 ___ cfe-commits mailing

r296098 - Add clazy to external Clang examples page

Author: kfunk Date: Fri Feb 24 02:29:46 2017 New Revision: 296098 URL: http://llvm.org/viewvc/llvm-project?rev=296098=rev Log: Add clazy to external Clang examples page Reviewers: silvas, rizsotto.mailinglist, sergio.martins Reviewed By: rizsotto.mailinglist Differential Revision:

[clang-tools-extra] r296100 - [clang-tidy] Fix readability-redundant-declaration false positive

Author: danielmarjamaki Date: Fri Feb 24 03:02:44 2017 New Revision: 296100 URL: http://llvm.org/viewvc/llvm-project?rev=296100=rev Log: [clang-tidy] Fix readability-redundant-declaration false positive Differential Revision: https://reviews.llvm.org/D27048 Modified:

[PATCH] D29986: Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL296099: Fix crash when an incorrect redeclaration only differs in __unaligned type… (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D29986?vs=88514=89617#toc Repository: rL

r296099 - Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier

Author: rogfer01 Date: Fri Feb 24 02:41:09 2017 New Revision: 296099 URL: http://llvm.org/viewvc/llvm-project?rev=296099=rev Log: Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier Fix an assertion that is hit when a redeclaration with differing types only

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

javed.absar created this revision. This patch enables the msvc pragma section to choose whether zero initialized variables are to be placed in data_seg or bss_seg. The current implementation ignores bss_seg directive for variables that are initialized (i.e. it does not check if the

[PATCH] D30327: [Sema] Improve side effect checking for unused-lambda-capture warning

malcolm.parsons created this revision. Don't warn about unused lambda captures that involve copying a value of a type that cannot be trivially copied and destroyed. Fixes PR31977 https://reviews.llvm.org/D30327 Files: include/clang/Sema/Sema.h lib/Sema/SemaLambda.cpp

[PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

sammccall updated this revision to Diff 89632. sammccall added a comment. Report symbols by reference. https://reviews.llvm.org/D30210 Files: include-fixer/InMemorySymbolIndex.cpp include-fixer/InMemorySymbolIndex.h include-fixer/IncludeFixer.cpp include-fixer/SymbolIndex.h

Re: [PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

On Thu, Feb 23, 2017 at 10:40 PM Sam McCall wrote: > > > On Feb 23, 2017 8:48 PM, "Haojian Wu via Phabricator" < > revi...@reviews.llvm.org> wrote: > > hokein added inline comments. > > > > Comment at: >

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric updated this revision to Diff 89627. ioeric added a comment. - removed a debug message https://reviews.llvm.org/D30328 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h change-namespace/tool/ClangChangeNamespace.cpp

[PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

hokein added a comment. Thanks, still LGTM with one nit. Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:262 + if (Filename != "") { +Reporter->reportSymbols(Filename, std::move(FileSymbols)); +FileSymbols = {}; We don't need `std::move`

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.h:21 +/// std::random_shuffle will be removed as of C++17. This check will find and +/// replace all occurences of std::random_shuffle with std::shuffle. +/// Typo

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: change-namespace/tool/ClangChangeNamespace.cpp:78 +// changing namespaces around them. +constexpr const char *WhiteListedSymbolPatterns[] = {"^std::.*$"};

Re: [PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

That's two votes for "this is too surprising" - changed. https://imgflip.com/i/1k93rm https://68.media.tumblr.com/8db2fe0a6f84ff128157a2b615f519bf/tumblr_inline_nenq4hMoQA1sb080b.gif On Fri, Feb 24, 2017 at 9:54 AM, Manuel Klimek wrote: > On Thu, Feb 23, 2017 at 10:40 PM Sam

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric created this revision. https://reviews.llvm.org/D30328 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h change-namespace/tool/ClangChangeNamespace.cpp test/change-namespace/Inputs/fake-std.h test/change-namespace/white-list.cpp

Re: [PATCH] D29303: In VirtualCallChecker, handle indirect calls

Thanks Anna, I'm new to the release process here. Hans: this is a simple fix for a null-dereference in the static analyzer. Does it make sense to cherrypick? On Sat, Feb 18, 2017 at 2:46 AM, Anna Zaks via Phabricator < revi...@reviews.llvm.org> wrote: > zaks.anna added a comment. > > Has this

[PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

sammccall updated this revision to Diff 89636. sammccall added a comment. Remove redundant std::move https://reviews.llvm.org/D30210 Files: include-fixer/InMemorySymbolIndex.cpp include-fixer/InMemorySymbolIndex.h include-fixer/IncludeFixer.cpp include-fixer/SymbolIndex.h

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric updated this revision to Diff 89637. ioeric marked an inline comment as done. ioeric added a comment. - Make the whitelist an option. https://reviews.llvm.org/D30328 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric added a comment. PTAL Comment at: change-namespace/tool/ClangChangeNamespace.cpp:78 +// changing namespaces around them. +constexpr const char *WhiteListedSymbolPatterns[] = {"^std::.*$"}; + hokein wrote: > Maybe consider create a command-line option

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric updated this revision to Diff 89640. ioeric marked 2 inline comments as done. ioeric added a comment. - Addressed comments. https://reviews.llvm.org/D30328 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h change-namespace/tool/ClangChangeNamespace.cpp

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric added inline comments. Comment at: change-namespace/tool/ClangChangeNamespace.cpp:82 + +llvm::ErrorOr GetWhiteListedSymbolPatterns() { + llvm::SmallVector Lines; hokein wrote: > Instead `std::vector`, maybe std::vector is

[PATCH] D28278: [StaticAnalyzer] dont show wrong 'garbage value' warning when there is array index out of bounds

danielmarjamaki updated this revision to Diff 89641. danielmarjamaki added a comment. Fixed review comment. Broke out function. Repository: rL LLVM https://reviews.llvm.org/D28278 Files: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp test/Analysis/uninit-vals-ps.c Index:

[clang-tools-extra] r296110 - [change-namepsace] make it possible to whitelist symbols so they don't get updated.

Author: ioeric Date: Fri Feb 24 05:54:45 2017 New Revision: 296110 URL: http://llvm.org/viewvc/llvm-project?rev=296110=rev Log: [change-namepsace] make it possible to whitelist symbols so they don't get updated. Reviewers: hokein Reviewed By: hokein Subscribers: cfe-commits Differential

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

This revision was automatically updated to reflect the committed changes. Closed by commit rL296110: [change-namepsace] make it possible to whitelist symbols so they don't get… (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D30328?vs=89640=89643#toc Repository: rL

[PATCH] D30157: [analyzer] Improve valist check

danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:189 + const auto *EReg = dyn_cast_or_null(Reg); + return EReg && VaListModelledAsArray ? EReg->getSuperRegion() : Reg; +} I would personally recommend parentheses

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

hokein added inline comments. Comment at: change-namespace/tool/ClangChangeNamespace.cpp:82 + +llvm::ErrorOr GetWhiteListedSymbolPatterns() { + llvm::SmallVector Lines; Instead `std::vector`, maybe std::vector is better, with that we

[PATCH] D30337: [clang-move] Extend clang-move to support moving global variable.

hokein updated this revision to Diff 89659. hokein added a comment. No accident changes. https://reviews.llvm.org/D30337 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/var_test.cpp test/clang-move/Inputs/var_test.h test/clang-move/move-var.cpp

[PATCH] D29757: [libcxx] Threading support: Externalize hardware_concurrency()

rmaprath updated this revision to Diff 89664. rmaprath added a comment. Different take on the patch: Externalize this function only for the externally-thread-api variant. This is much less intrusive. Note that I haven't added the declaration of `__libcpp_thread_hw_concurrency()` into

[PATCH] D29818: [libcxx] Threading support: Attempt to externalize system_clock::now() and steady_clock::now() implementations

rmaprath updated this revision to Diff 89665. rmaprath added a comment. Different approach: Externalize these functions only for the external-thread-api library variant. (Similar to https://reviews.llvm.org/D29757) https://reviews.llvm.org/D29818 Files: src/chrono.cpp Index:

r296116 - Made test more target agnostic

Author: sepavloff Date: Fri Feb 24 07:15:08 2017 New Revision: 296116 URL: http://llvm.org/viewvc/llvm-project?rev=296116=rev Log: Made test more target agnostic Recommits r295975 (Added regression tests), reverted in r295975, because it did not work on non-X86 targets. Added:

[clang-tools-extra] r296113 - [change-namespace] fix asan failure in r296110.

Author: ioeric Date: Fri Feb 24 06:56:51 2017 New Revision: 296113 URL: http://llvm.org/viewvc/llvm-project?rev=296113=rev Log: [change-namespace] fix asan failure in r296110. Modified: clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp Modified:

[PATCH] D30337: [clang-move] Extend clang-move to support moving global variable.

hokein created this revision. Also support dumping global variables. https://reviews.llvm.org/D30337 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/var_test.cpp test/clang-move/Inputs/var_test.h test/clang-move/move-var.cpp unittests/clang-move/ClangMoveTests.cpp Index:

Re: r295474 - [OpenMP] Fix cancellation point in task with no cancel

Merged to 4.0 in r296139 as requested on the r295473 commit thread. On Fri, Feb 17, 2017 at 10:32 AM, Jonas Hahnfeld via cfe-commits wrote: > Author: hahnfeld > Date: Fri Feb 17 12:32:58 2017 > New Revision: 295474 > > URL:

r296221 - [ODRHash] Move inherited visitor call to end of function.

Author: rtrieu Date: Fri Feb 24 19:29:34 2017 New Revision: 296221 URL: http://llvm.org/viewvc/llvm-project?rev=296221=rev Log: [ODRHash] Move inherited visitor call to end of function. Modified: cfe/trunk/lib/AST/ODRHash.cpp Modified: cfe/trunk/lib/AST/ODRHash.cpp URL:

r296231 - [profiling] Fix profile counter increment when emitting selects (PR32019)

Author: vedantk Date: Fri Feb 24 20:30:03 2017 New Revision: 296231 URL: http://llvm.org/viewvc/llvm-project?rev=296231=rev Log: [profiling] Fix profile counter increment when emitting selects (PR32019) Clang has logic to lower certain conditional expressions directly into llvm select

r296209 - [PS4] Set our default dialect to C++11. NFC for other targets.

Author: probinson Date: Fri Feb 24 18:15:45 2017 New Revision: 296209 URL: http://llvm.org/viewvc/llvm-project?rev=296209=rev Log: [PS4] Set our default dialect to C++11. NFC for other targets. Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified:

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

dtzWill accepted this revision. dtzWill added a comment. This revision is now accepted and ready to land. Sorry for the delay! LGTM, thanks! https://reviews.llvm.org/D29369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r296213 - [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

Author: vedantk Date: Fri Feb 24 18:43:36 2017 New Revision: 296213 URL: http://llvm.org/viewvc/llvm-project?rev=296213=rev Log: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193) C requires the operands of arithmetic expressions to be promoted if their types are smaller

[PATCH] D29437: [ubsan] Detect signed overflow UB in remainder operations

This revision was automatically updated to reflect the committed changes. Closed by commit rL296214: [ubsan] Detect signed overflow UB in remainder operations (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D29437?vs=89734=89753#toc Repository: rL LLVM

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

This revision was automatically updated to reflect the committed changes. Closed by commit rL296213: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D29369?vs=89733=89752#toc Repository: rL

r296214 - [ubsan] Detect signed overflow UB in remainder operations

Author: vedantk Date: Fri Feb 24 18:43:39 2017 New Revision: 296214 URL: http://llvm.org/viewvc/llvm-project?rev=296214=rev Log: [ubsan] Detect signed overflow UB in remainder operations Teach ubsan to diagnose remainder operations which have undefined behavior due to signed overflow (e.g

r296216 - Revert r296209, still one more test to go.

Author: probinson Date: Fri Feb 24 18:50:34 2017 New Revision: 296216 URL: http://llvm.org/viewvc/llvm-project?rev=296216=rev Log: Revert r296209, still one more test to go. Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp URL:

RE: r296171 - Try to unbreak tests after r296166

Hi Nico, The test you added is causing a failure on the PS4 Windows bot. The root of the cause is that the Windows version of rm does not accept wildcards unfortunately. To fix make it work on Windows, you likely need to specify exactly what files/directories you want to delete without using a

[PATCH] D30341: [analyzer] clarify error messages about uninitialized function arguments

danielmarjamaki created this revision. This patch clarify the error messages about uninitialized function arguments. It can be really hard to see the problem if there are 10-20 arguments like: printf("debug:", a, b.c, d, e, ...); with no info about which argument is uninitialized and

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL296136: [libcxxabi] Disable calls to fprintf for baremetal targets. (authored by rsingh). Changed prior to commit: https://reviews.llvm.org/D30339?vs=89674=89681#toc Repository: rL LLVM

[libcxxabi] r296136 - [libcxxabi] Disable calls to fprintf for baremetal targets.

Author: rsingh Date: Fri Feb 24 10:43:36 2017 New Revision: 296136 URL: http://llvm.org/viewvc/llvm-project?rev=296136=rev Log: [libcxxabi] Disable calls to fprintf for baremetal targets. We've been having issues with using libcxxabi and libunwind for baremetal targets because fprintf is

Multiple versions of VS

Hello, Is there any plan from the community to have clang support multiple versions of VS? Thanks. -Zahira ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30340: [libunwind] Disable calls to fprintf when building for baremetal targets in release mode

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D30340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30340: [libunwind] Disable calls to fprintf when building for baremetal targets in release mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL296135: [libunwind] Disable calls to fprintf for baremetal targets. (authored by rsingh). Changed prior to commit: https://reviews.llvm.org/D30340?vs=89676=89679#toc Repository: rL LLVM

[PATCH] D30337: [clang-move] Extend clang-move to support moving global variable.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg https://reviews.llvm.org/D30337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30339: Disable calls to fprintf when building for baremetal targets in release mode

rs created this revision. We've been having issues with using libcxxabi and libunwind for baremetal targets because fprintf is dependent on io functions, this patch disable calls to fprintf when building for baremetal targets in release mode. https://reviews.llvm.org/D30339 Files:

[PATCH] D30340: [libunwind] Disable calls to fprintf when building for baremetal targets in release mode

rs created this revision. We've been having issues with using libcxxabi and libunwind for baremetal targets because fprintf is dependent on io functions, this patch disable calls to fprintf when building for baremetal targets in release mode. https://reviews.llvm.org/D30340 Files:

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D30339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] r296135 - [libunwind] Disable calls to fprintf for baremetal targets.

Author: rsingh Date: Fri Feb 24 10:38:05 2017 New Revision: 296135 URL: http://llvm.org/viewvc/llvm-project?rev=296135=rev Log: [libunwind] Disable calls to fprintf for baremetal targets. We've been having issues with using libcxxabi and libunwind for baremetal targets because fprintf is

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

EricWF added a comment. isn't this incorrect because `config.h` always defines LIBCXX_BAREMETAL? Repository: rL LLVM https://reviews.llvm.org/D30339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

jroelofs added a comment. In https://reviews.llvm.org/D30339#685919, @rmaprath wrote: > Perhaps change `config.h` and remove the definition there and adjust other > places accordingly? > > The current form is very easy to trip over. Eric's point is that LIBCXXABI_BAREMETAL is a 0/1 flag, not

[PATCH] D30025: [compiler-rt] [builtins] Fix building atomic.c with GCC

mgorny added a reviewer: doug.gregor. mgorny added a subscriber: doug.gregor. mgorny added a comment. If I read the git correctly, the change that forbid defining builtins was initially made in https://reviews.llvm.org/rL64639. @doug.gregor, any chance you could help us over here? Is clang

Re: r295473 - [OpenMP] Remove barriers at cancel and cancellation point

Oops, it did. Thanks for reminding me; I've merged that in r296139. On Thu, Feb 23, 2017 at 11:13 PM, Hahnfeld, Jonas wrote: > Hi Hans, > > Did r295474 fall off your radar? Sorry that I asked for both commits in one > email, should I reply to the other original

[libcxxabi] r296146 - [libcxxabi] Fix condition typo in rL296136

Author: rsingh Date: Fri Feb 24 12:22:59 2017 New Revision: 296146 URL: http://llvm.org/viewvc/llvm-project?rev=296146=rev Log: [libcxxabi] Fix condition typo in rL296136 Made a mistake in the condition typo because LIBCXXABI_BAREMETAL is always defined, I should have been checking the contents

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

This revision was automatically updated to reflect the committed changes. Closed by commit rL296146: [libcxxabi] Fix condition typo in rL296136 (authored by rsingh). Changed prior to commit: https://reviews.llvm.org/D30343?vs=89687=89693#toc Repository: rL LLVM

[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

arphaman created this revision. This patch refactors the code figures out which block captures need to be copied/destroyed using special copy/destroy code. This is a preparation patch for work on merging block copy/destroy routines. Thanks for taking a look! Repository: rL LLVM

Re: r293604 - In VirtualCallChecker, handle indirect calls

On Mon, Jan 30, 2017 at 9:23 PM, Sam McCall via cfe-commits wrote: > Author: sammccall > Date: Mon Jan 30 23:23:20 2017 > New Revision: 293604 > > URL: http://llvm.org/viewvc/llvm-project?rev=293604=rev > Log: > In VirtualCallChecker, handle indirect calls > > Summary:

RE: [clang-tools-extra] r296110 - [change-namepsace] make it possible to whitelist symbols so they don't get updated.

Hi Eric, I don't know if you are aware, but one of the tests you added in this change is failing on the PS4 Windows bot. The test is " Clang Tools :: change-namespace/white-list.cpp". Can you please take a look? Douglas Yung > -Original Message- > From: cfe-commits

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

rmaprath added a comment. Perhaps change `config.h` and remove the definition there and adjust other places accordingly? The current form is very easy to trip over. Repository: rL LLVM https://reviews.llvm.org/D30339 ___ cfe-commits mailing

Re: [PATCH] D29303: In VirtualCallChecker, handle indirect calls

Yes, this looks very straight-forward. Merged in r296154. On Fri, Feb 24, 2017 at 4:29 AM, Sam McCall via cfe-commits wrote: > Thanks Anna, I'm new to the release process here. > > Hans: this is a simple fix for a null-dereference in the static analyzer. > Does it

[PATCH] D29437: [ubsan] Detect signed overflow UB in remainder operations

efriedma added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:2380 + CGF.SanOpts.has(SanitizerKind::SignedIntegerOverflow)) && + Ops.Ty->isIntegerType()) { CodeGenFunction::SanitizerScope SanScope(); I don't think you need the

Re: r296063 - Revert r291477 "[Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin"

Merged to 4.0 in r296152. On Thu, Feb 23, 2017 at 5:16 PM, Hans Wennborg via cfe-commits wrote: > Author: hans > Date: Thu Feb 23 19:16:34 2017 > New Revision: 296063 > > URL: http://llvm.org/viewvc/llvm-project?rev=296063=rev > Log: > Revert r291477 "[Frontend]

r296161 - clang-format: Enable include sorting for style=Chromium

Author: nico Date: Fri Feb 24 13:13:59 2017 New Revision: 296161 URL: http://llvm.org/viewvc/llvm-project?rev=296161=rev Log: clang-format: Enable include sorting for style=Chromium Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp URL:

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

jroelofs added a comment. In https://reviews.llvm.org/D30339#685888, @EricWF wrote: > isn't this incorrect because `config.h` always defines LIBCXX_BAREMETAL? Oh, right, it needs to be: #if !LIBCXXABI_BAREMETAL || !defined(NDEBUG) Repository: rL LLVM https://reviews.llvm.org/D30339

r296140 - [Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma

Author: arphaman Date: Fri Feb 24 11:45:16 2017 New Revision: 296140 URL: http://llvm.org/viewvc/llvm-project?rev=296140=rev Log: [Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma in macro argument pre-expansion mode when skipping a function body This commit fixes a

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

rs created this revision. Made a mistake in the condition typo because LIBCXXABI_BAREMETAL is always defined, I should have been checking the contents to see if it's enabled https://reviews.llvm.org/D30343 Files: src/abort_message.cpp Index: src/abort_message.cpp

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

rs added a comment. Ah sorry for the mistake. Fix is here https://reviews.llvm.org/D30343 Repository: rL LLVM https://reviews.llvm.org/D30339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28772: [Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma in macro argument pre-expansion mode when skipping a function body

This revision was automatically updated to reflect the committed changes. Closed by commit rL296140: [Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D28772?vs=87801=89688#toc Repository: rL

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

rs added a comment. Going for post-commit. https://reviews.llvm.org/D30343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r296160 - clang-format: Fix many Objective-C formatting regressions from r289428

Author: nico Date: Fri Feb 24 13:10:12 2017 New Revision: 296160 URL: http://llvm.org/viewvc/llvm-project?rev=296160=rev Log: clang-format: Fix many Objective-C formatting regressions from r289428 r289428 added a separate language kind for Objective-C, but kept many "Language == LK_Cpp" checks

[PATCH] D30009: Add support for '#pragma clang attribute'

arphaman added inline comments. Comment at: include/clang/Basic/Attr.td:308-311 + // - An attribute requires delayed parsing (LateParsed is on) + // - An attribute has no GNU/CXX11 spelling + // - An attribute has no subject list + // - An attribute derives from a StmtAttr

[PATCH] D30316: AMDGPU: Make 0 the private nullptr value

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! I assume you will make corresponding changes in backend. https://reviews.llvm.org/D30316 ___ cfe-commits mailing list

[PATCH] D29685: Lit C++11 Compatibility - Function Attributes

tigerleapgorge accepted this revision. tigerleapgorge added a comment. This revision is now accepted and ready to land. Of the 3 tests. format-strings.cpp and printf-cstr.cpp have been commited in r294979 For warn-thread-safety-parsing.cpp, bug 32066 has been filed to track the lack of thread

[PATCH] D20710: Lit C++11 Compatibility Patch #9

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D20710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

On 2/24/17 1:48 PM, Eric Fiselier wrote: Inserting arbitrary feature macros into CMake should not be a supported scenario because it results is macros, such as this one, which are seemingly dead. Good point. Jon /Eric On Fri, Feb 24, 2017 at 1:44 PM, Jonathan Roelofs

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

EricWF added a comment. This works for me, but the idiomatic macro usage in libc++, and (hopefully) libc++abi should always use `defined(FOO)` as opposed to `!FOO`. I'll clean this up in the next week if nobody else wants to. Repository: rL LLVM https://reviews.llvm.org/D30343

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

EricWF added a comment. In https://reviews.llvm.org/D30339#685921, @jroelofs wrote: > In https://reviews.llvm.org/D30339#685919, @rmaprath wrote: > > > Perhaps change `config.h` and remove the definition there and adjust other > > places accordingly? > > > > The current form is very easy to

r296170 - [ODRHash] Add handling of bitfields

Author: rtrieu Date: Fri Feb 24 14:59:28 2017 New Revision: 296170 URL: http://llvm.org/viewvc/llvm-project?rev=296170=rev Log: [ODRHash] Add handling of bitfields Differential Revision: https://reviews.llvm.org/D21675 Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td

[PATCH] D30316: AMDGPU: Make 0 the private nullptr value

arsenm added a comment. In https://reviews.llvm.org/D30316#686174, @yaxunl wrote: > AMDGPUTargetMachine::getNullPointerValue needs also be changed to match > this, otherwise the static initializer will be incorrect for null pointer to > private addr space. Do you plan to change that? Yes,

[PATCH] D20710: Lit C++11 Compatibility Patch #9

This revision was automatically updated to reflect the committed changes. Closed by commit rL296184: [Test] Make Lit tests C++11 compatible #9 (authored by lcharles). Changed prior to commit: https://reviews.llvm.org/D20710?vs=87309=89728#toc Repository: rL LLVM

Re: [PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

On 2/24/17 1:30 PM, Eric Fiselier via Phabricator wrote: EricWF added a comment. In https://reviews.llvm.org/D30339#685921, @jroelofs wrote: In https://reviews.llvm.org/D30339#685919, @rmaprath wrote: Perhaps change `config.h` and remove the definition there and adjust other places

Re: [PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

Inserting arbitrary feature macros into CMake should not be a supported scenario because it results is macros, such as this one, which are seemingly dead. /Eric On Fri, Feb 24, 2017 at 1:44 PM, Jonathan Roelofs wrote: > > > On 2/24/17 1:30 PM, Eric Fiselier via

r296166 - clang-format: Don't leave behind temp files in -i mode on Windows, PR26125

Author: nico Date: Fri Feb 24 14:49:00 2017 New Revision: 296166 URL: http://llvm.org/viewvc/llvm-project?rev=296166=rev Log: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125 Fix and analysis by Wei Mao (see bug), test by me. Added:

r296171 - Try to unbreak tests after r296166

Author: nico Date: Fri Feb 24 15:01:43 2017 New Revision: 296171 URL: http://llvm.org/viewvc/llvm-project?rev=296171=rev Log: Try to unbreak tests after r296166 Looks like %T isn't per-test but per-test-directory, and the rm was deleting temp files written by other tests in test/Format. Limit

[PATCH] D21626: Lit C++11 Compatibility Patch #10

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with a couple of changes. Comment at: test/Modules/Inputs/merge-using-decls/a.h:25 +#if __cplusplus <= 199711L // C++11 does not allow access declerations template

[PATCH] D30316: AMDGPU: Make 0 the private nullptr value

arsenm added a comment. In https://reviews.llvm.org/D30316#686089, @yaxunl wrote: > LGTM. Thanks! I assume you will make corresponding changes in backend. This is to match r295891, so then https://reviews.llvm.org/D28937 is required to fix addrspacecast https://reviews.llvm.org/D30316

[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

vsk added a comment. Looks NFC to me. Comment at: lib/CodeGen/CGBlocks.cpp:1414 + +} // end anonymous namespace + I don't see the need for two GenericInfo types (although it's plausible it'll make sense with your upcoming changes!). I had in mind a single

Re: r296166 - clang-format: Don't leave behind temp files in -i mode on Windows, PR26125

On 24 February 2017 at 20:49, Nico Weber via cfe-commits wrote: > Author: nico > Date: Fri Feb 24 14:49:00 2017 > New Revision: 296166 > > URL: http://llvm.org/viewvc/llvm-project?rev=296166=rev > Log: > clang-format: Don't leave behind temp files in -i mode on

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc added a comment. Sounds good, I will commit https://reviews.llvm.org/D26061 and split out the tests from this (https://reviews.llvm.org/D28952). https://reviews.llvm.org/D28952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r296241 - AMDGPU: export s_sendmsg{halt} instrinsics

Author: jvesely Date: Fri Feb 24 22:20:24 2017 New Revision: 296241 URL: http://llvm.org/viewvc/llvm-project?rev=296241=rev Log: AMDGPU: export s_sendmsg{halt} instrinsics Differential Revision: https://reviews.llvm.org/D30366 Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def

r296239 - AMDGPU: export s_waitcnt builtin

Author: jvesely Date: Fri Feb 24 22:20:20 2017 New Revision: 296239 URL: http://llvm.org/viewvc/llvm-project?rev=296239=rev Log: AMDGPU: export s_waitcnt builtin Differential Revision: https://reviews.llvm.org/D30359 Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def

r296240 - AMDGPU: export l1 cache invalidation intrinsics

Author: jvesely Date: Fri Feb 24 22:20:22 2017 New Revision: 296240 URL: http://llvm.org/viewvc/llvm-project?rev=296240=rev Log: AMDGPU: export l1 cache invalidation intrinsics Differential Revision: https://reviews.llvm.org/D30360 Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def

r296242 - [analyzer] Refactor and simplify SimpleConstraintManager

Author: ddcc Date: Fri Feb 24 22:51:31 2017 New Revision: 296242 URL: http://llvm.org/viewvc/llvm-project?rev=296242=rev Log: [analyzer] Refactor and simplify SimpleConstraintManager Summary: SimpleConstraintManager is difficult to use, and makes assumptions about capabilities of the constraint

[PATCH] D26061: [analyzer] Refactor and simplify SimpleConstraintManager

This revision was automatically updated to reflect the committed changes. Closed by commit rL296242: [analyzer] Refactor and simplify SimpleConstraintManager (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26061?vs=89054=89773#toc Repository: rL LLVM

[PATCH] D30289: [Analyzer] Add bug visitor for taint checker

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Looks great! https://reviews.llvm.org/D30289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >