[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

rs added a comment. > This works for me, but the idiomatic macro usage in libc++, and (hopefully) > libc++abi should always use !defined(FOO) as opposed to !FOO. I'll clean this > up in the next week if nobody else wants to. I can do the clean up later this week. Repository: rL LLVM

[PATCH] D30399: clang-format: [JS] whitespace after async in arrow functions.

mprobst updated this revision to Diff 89859. mprobst added a comment. - Extract local variable for next non comment. https://reviews.llvm.org/D30399 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp

[libcxx] r296338 - Fix cmake dependency for the external-thread-library variant. NFC.

Author: asiri Date: Mon Feb 27 07:19:25 2017 New Revision: 296338 URL: http://llvm.org/viewvc/llvm-project?rev=296338=rev Log: Fix cmake dependency for the external-thread-library variant. NFC. Modified: libcxx/trunk/test/CMakeLists.txt Modified: libcxx/trunk/test/CMakeLists.txt URL:

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

rogfer01 added inline comments. Comment at: lib/Driver/Tools.cpp:5940 + options::OPT_fno_always_use_bss, false)) +CmdArgs.push_back("-always-use-bss"); + I think you mean `"-falways-use-bss"`. Please add a test that checks that the driver

[PATCH] D30337: [clang-move] Extend clang-move to support moving global variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rL296337: [clang-move] Extend clang-move to support moving global variable. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D30337?vs=89659=89869#toc Repository: rL LLVM

[clang-tools-extra] r296337 - [clang-move] Extend clang-move to support moving global variable.

Author: hokein Date: Mon Feb 27 07:19:13 2017 New Revision: 296337 URL: http://llvm.org/viewvc/llvm-project?rev=296337=rev Log: [clang-move] Extend clang-move to support moving global variable. Summary: Also support dumping global variables. Reviewers: ioeric Reviewed By: ioeric Subscribers:

[PATCH] D28278: [StaticAnalyzer] dont show wrong 'garbage value' warning when there is array index out of bounds

This revision was automatically updated to reflect the committed changes. Closed by commit rL296326: [analyzer] clarify 'result is garbage value' when it is out of bounds (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D28278?vs=89641=89854#toc Repository:

r296326 - [analyzer] clarify 'result is garbage value' when it is out of bounds

Author: danielmarjamaki Date: Mon Feb 27 04:44:24 2017 New Revision: 296326 URL: http://llvm.org/viewvc/llvm-project?rev=296326=rev Log: [analyzer] clarify 'result is garbage value' when it is out of bounds Differential Revision: https://reviews.llvm.org/D28278 Modified:

r296341 - [clang-format] Add a NamespaceEndCommentsFixer

Author: krasimir Date: Mon Feb 27 07:28:36 2017 New Revision: 296341 URL: http://llvm.org/viewvc/llvm-project?rev=296341=rev Log: [clang-format] Add a NamespaceEndCommentsFixer Summary: This patch adds a NamespaceEndCommentsFixer TokenAnalyzer for clang-format, which fixes end namespace

[PATCH] D30157: [analyzer] Improve valist check

xazax.hun updated this revision to Diff 89857. xazax.hun edited the summary of this revision. xazax.hun added a comment. - Move the check out of alpha. https://reviews.llvm.org/D30157 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/ValistChecker.cpp

[PATCH] D30399: clang-format: [JS] whitespace after async in arrow functions.

djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2229 +if (Left.is(Keywords.kw_async) && Right.is(tok::l_paren) && +Right.MatchingParen && Right.MatchingParen->getNextNonComment() && +

r296330 - clang-format: [JS] whitespace after async in arrow functions.

Author: mprobst Date: Mon Feb 27 05:15:53 2017 New Revision: 296330 URL: http://llvm.org/viewvc/llvm-project?rev=296330=rev Log: clang-format: [JS] whitespace after async in arrow functions. Summary: Async arrow functions should be marked with a whitespace after the async keyword, before the

[PATCH] D30399: clang-format: [JS] whitespace after async in arrow functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL296330: clang-format: [JS] whitespace after async in arrow functions. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D30399?vs=89859=89860#toc Repository: rL LLVM

[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

rjmccall added a comment. You're doing this refactor to... support doing another refactor of the same code? Why are these patches separate? Repository: rL LLVM https://reviews.llvm.org/D30345 ___ cfe-commits mailing list

[PATCH] D30430: Make Lit tests C++11 compatible - IR ordering

rjmccall added a comment. The C++98 behavior here is not really vital to test precisely; it's just minor differences in what gets instantiated and when. I think it's fine to just update the run line to -std=c++11 for things like this. But if you really want to test both configurations, this

[PATCH] D25556: [Sema] Add variable captured by a block to the enclosing lambda's potential capture list

rjmccall added a comment. Well, I was hoping that Richard would weigh in, but absent that, I don't have any objections. Since it fixes a known bug, let's just go ahead and do it. LGTM. https://reviews.llvm.org/D25556 ___ cfe-commits mailing

Re: [clang-tools-extra] r296110 - [change-namepsace] make it possible to whitelist symbols so they don't get updated.

Hello Eric, This commit broke test on one of our builders: Clang Tools :: change-namespace/white-list.cpp http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/6153/steps/test/logs/stdio Please have a look. Thanks Galina On Fri, Feb 24, 2017 at 3:54

[PATCH] D29221: clang-format-vsix: "format on save" feature

amaiorano added a comment. In https://reviews.llvm.org/D29221#687438, @amaiorano wrote: > In https://reviews.llvm.org/D29221#687425, @hans wrote: > > > In https://reviews.llvm.org/D29221#686865, @amaiorano wrote: > > > > > Made changes based on @hans 's feedback. > > > > > > I looked again at

r296430 - Set ABIs correctly for OpenBSD/arm; soft float and aapcs-linux.

Author: brad Date: Mon Feb 27 21:20:26 2017 New Revision: 296430 URL: http://llvm.org/viewvc/llvm-project?rev=296430=rev Log: Set ABIs correctly for OpenBSD/arm; soft float and aapcs-linux. Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/Driver/Arch/ARM.cpp

[PATCH] D30372: [Driver] Consolidate tools and toolchains by target platform. (NFC)

mehdi_amini added a comment. In https://reviews.llvm.org/D30372#687060, @ahatanak wrote: > In https://reviews.llvm.org/D30372#687054, @dlj wrote: > > > In https://reviews.llvm.org/D30372#686871, @ahatanak wrote: > > > > > Have you considered using "include_directories" in CMakeLists.txt to > >

RE: r296414 - Reland: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

Hi Dominic, Did you forget to submit something to get this patch to work? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/6154/steps/test/logs/stdio: pickle.PicklingError: Can't pickle : it's not found as lit.TestingConfig.AnalyzerTest Douglas Yung >

[PATCH] D30435: [clang-import-test] Lookup inside entities

spyffe updated this revision to Diff 89957. spyffe added a comment. • Applied Adrian's suggestion to move comments before the line they apply to. • Got to 100% coverage by changing a test and making an assert for something I couldn't make happen in a test. I did not take Adrian's suggestion to

Re: r296408 - clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

Hello Nico, This commit broke test on one of our builders: Clang :: Format/inplace.cpp http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/6151/steps/test/logs/stdio Please have a look. Thanks Galina On Mon, Feb 27, 2017 at 2:59 PM, Nico Weber via

[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

ddcc reopened this revision. ddcc added a comment. This revision is now accepted and ready to land. It looks like there's some sort of pickling-related test failure when lit tries to fork, because it can't find the class `lit.TestingConfig.AnalyzerTest`:

RE: r295474 - [OpenMP] Fix cancellation point in task with no cancel

Thanks! Jonas > -Original Message- > From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf > Of Hans Wennborg > Sent: Friday, February 24, 2017 6:39 PM > To: Hahnfeld, Jonas > Cc: cfe-commits > Subject: Re: r295474 - [OpenMP] Fix cancellation point in task with no > cancel

[PATCH] D3583: Sema: Implement DR244

jwillemsen added a comment. In https://reviews.llvm.org/D3583#222045, @rsmith wrote: > This will be in 3.7. As far as we can tell DR244 is not fixed yet in 3.9.1 so any idea why this review sets it to YES as implemented? Repository: rL LLVM https://reviews.llvm.org/D3583

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

rogfer01 added a comment. Ping? :-) Kind regards https://reviews.llvm.org/D30166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r296221 - [ODRHash] Move inherited visitor call to end of function.

An explanation as to why the code was moved (& possibly test cases, or "NFC" in the description) would be handy here. On Fri, Feb 24, 2017 at 5:41 PM Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Fri Feb 24 19:29:34 2017 > New Revision: 296221 > >

Re: [PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

FILE_SHARE_DELETE is for being able to request a file to be deleted when it's closed, which is too late, right? I didn't write the code in Path.inc, but from what I understand you can't generally overwrite a file that's still open on Windows, and Path.inc tries to work around this -- but the

[libcxx] r296346 - Fix typo in error message. NFC.

Author: asiri Date: Mon Feb 27 09:49:51 2017 New Revision: 296346 URL: http://llvm.org/viewvc/llvm-project?rev=296346=rev Log: Fix typo in error message. NFC. Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL:

[libcxx] r296351 - Fix LIBCXX_HAS_EXTERNAL_THREAD_API builds. NFC.

Author: asiri Date: Mon Feb 27 10:10:57 2017 New Revision: 296351 URL: http://llvm.org/viewvc/llvm-project?rev=296351=rev Log: Fix LIBCXX_HAS_EXTERNAL_THREAD_API builds. NFC. Add the missing check in the __config header. Modified: libcxx/trunk/include/__config Modified:

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

klimek added a comment. Also, do we want to not call ReplaceFile in Path.inc on Win if it potentially leaves temp files lying around? Reading the code, it looks like we currently actually believe it may fail, and retry with MoveFileEx afterwards... https://reviews.llvm.org/D30385

Re: [PATCH] D30315: [Driver] Move architecture-specific free helper functions to their own files.

On Thu, Feb 23, 2017 at 4:08 PM David L. Jones via Phabricator via cfe-commits wrote: > dlj created this revision. > Herald added subscribers: mgorny, nemanjai, jyknight, dschuff, srhines, > danalbert, aemerson. > Herald added a reviewer: javed.absar. > > This patch

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

vlad.tsyrklevich added a comment. Here's an example 3 file report from the Linux source: https://cdn.rawgit.com/vlad902/73bd32181151f2f0b07fa501a0f0b627/raw/0106f09cdb0d045b757de3d71ddc58072d33/report2.html It's not as immediately clear this is a multi-file output. Ideas to improve this

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added a comment. Ping. https://reviews.llvm.org/D27387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.

Hi Eric This has been failing for one week on green dragon. I think all the bots running sanitizer should pick up the clang with the fix already if they are building from trunk. Should I try remove the XFAIL? Steven > On Feb 23, 2017, at 11:48 AM, Steven Wu wrote: > > Hi

[libunwind] r296359 - Fix the project name in the license file.

Author: aadg Date: Mon Feb 27 11:47:58 2017 New Revision: 296359 URL: http://llvm.org/viewvc/llvm-project?rev=296359=rev Log: Fix the project name in the license file. Modified: libunwind/trunk/LICENSE.TXT Modified: libunwind/trunk/LICENSE.TXT URL:

[PATCH] D27455: UBSan docs: Explicitly mention that `-fsanitize=unsigned-integer-overflow` does not catch UB.

vsk added a comment. LGTM, fwiw. (IIRC kcc mentioned that samsonov no longer works on the sanitizers.) https://reviews.llvm.org/D27455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen

vleschuk added inline comments. Comment at: test/CodeGenCXX/debug-info-type-calling-conventions.cpp:11-12 + +class UserDtor { +public: + ~UserDtor() {} dblaikie wrote: > I'd probably make this a struct (and drop the 'public:' section since it'll > be the

r296374 - [ubsan] Factor out logic to emit a range check. NFC.

Author: vedantk Date: Mon Feb 27 13:46:19 2017 New Revision: 296374 URL: http://llvm.org/viewvc/llvm-project?rev=296374=rev Log: [ubsan] Factor out logic to emit a range check. NFC. This is a readability improvement, but it will also help prep an upcoming patch to detect UB loads from bitfields.

[PATCH] D30423: [ubsan] Detect UB loads from bitfields

vsk created this revision. We frequently run into user bugs caused by UB loads of out-of-range values from enum / BOOL bitfields. Teach UBSan to diagnose the issue. https://reviews.llvm.org/D30423 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h

[PATCH] D30427: Fix whitespace before token-paste of an argument.

jyknight created this revision. The whitespace should come from the argument name in the macro expansion, rather than from the token passed to the macro (same as it does when not pasting). Added a new test case for the change in behavior to stringize_space.c. FileCheck'ized

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn updated this revision to Diff 89919. madsravn added a comment. Minor update to fix spelling mistake. https://reviews.llvm.org/D30158 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp

[PATCH] D30239: enable -flto=thin in clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rL296373: enable -flto=thin in clang-cl (authored by inglorion). Changed prior to commit: https://reviews.llvm.org/D30239?vs=89598=89913#toc Repository: rL LLVM https://reviews.llvm.org/D30239

[PATCH] D30327: [Sema] Improve side effect checking for unused-lambda-capture warning

aaron.ballman added inline comments. Comment at: lib/Sema/SemaLambda.cpp:1458 + + return false; +} I think this is missing one more case: capturing a `volatile` variable by copy does have a side effect in that the variable is read when the capture occurs.

r296373 - enable -flto=thin in clang-cl

Author: inglorion Date: Mon Feb 27 13:40:19 2017 New Revision: 296373 URL: http://llvm.org/viewvc/llvm-project?rev=296373=rev Log: enable -flto=thin in clang-cl Summary: This enables LTO to be used with the clang-cl frontend. Reviewers: rnk, hans Reviewed By: hans Subscribers: pcc,

[PATCH] D30412: [clang-tidy] Fix a false positive on modernize-use-nullptr check.

hokein created this revision. Herald added a subscriber: JDevlieghere. The false positive happens on two neighbour CXXDefaultArgExpr AST nodes. like below: CXXFunctionalCastExpr 0x85c9670 'struct ZZ' functional cast to struct ZZ `-CXXConstructExpr 0x85c9518

[PATCH] D29221: clang-format-vsix: "format on save" feature

hans added a comment. In https://reviews.llvm.org/D29221#686865, @amaiorano wrote: > Made changes based on @hans 's feedback. > > I looked again at the categories, and I think it makes sense with my changes. > Here's an updated screenshot that shows what the options menu in Visual > Studio

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

javed.absar updated this revision to Diff 89897. javed.absar added a comment. Hi Roger: Thanks for the review. I have extended the test and fixed driver flag passing that you pointed out. Regarding the check in Sema::DeclarationIsZeroInitialized, the check if to keep the function return value

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

vlad.tsyrklevich created this revision. While looking at checker output with https://reviews.llvm.org/D30289 applied I realized I was missing results. After some digging I found that it's because the Linux kernel makes heavy use of inlined functions included in header files, and the resulting

[PATCH] D29221: clang-format-vsix: "format on save" feature

amaiorano added a comment. In https://reviews.llvm.org/D29221#687425, @hans wrote: > In https://reviews.llvm.org/D29221#686865, @amaiorano wrote: > > > Made changes based on @hans 's feedback. > > > > I looked again at the categories, and I think it makes sense with my > > changes. Here's an

[libunwind] r296358 - Add libcxxabi's LICENSE.TXT to libunwind.

Author: aadg Date: Mon Feb 27 11:33:20 2017 New Revision: 296358 URL: http://llvm.org/viewvc/llvm-project?rev=296358=rev Log: Add libcxxabi's LICENSE.TXT to libunwind. When libunwind was spinned off libcxxabi, most file were copied from libcxxabi to libunwind. However, libc++abi's toplevel

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

klimek added a comment. Can we open the files with FILE_SHARE_DELETE instead? https://reviews.llvm.org/D30385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

thakis added inline comments. Comment at: include/clang/Rewrite/Core/Rewriter.h:188-197 + /// prewrite(FID) is called after all changes to FID have been written to a + /// temporary file, but before that temporary file is moved into FID's + /// location. Windows's

[libcxxabi] r296344 - Attempt to fix arm-native libcxxabi tests for the no-exceptions variant

Author: asiri Date: Mon Feb 27 09:31:34 2017 New Revision: 296344 URL: http://llvm.org/viewvc/llvm-project?rev=296344=rev Log: Attempt to fix arm-native libcxxabi tests for the no-exceptions variant These tests embed calls to exceptions-related symbols from the abi library, which are absent in

[PATCH] D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen

dblaikie added a comment. Be best to avoid having to 'fixup' the argabi after the fact - and instead build the type with the right argabi from the get-go. Comment at: lib/CodeGen/CGDebugInfo.cpp:955-957 +// DWARFv5 doesn't specify explicit DW_CC_* value for this case, +

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

rnk added a comment. My understanding is that Windows doesn't allow you to delete a file that has been opened and mapped into any process, even if it has been opened with FILE_SHARE_DELETE. One way to work around this would be to avoid memory mapping files in the SourceManager when using the

[PATCH] D27627: [WIP] Supporting C++ based kernel languages on AMDGPU Target

yaxunl updated this revision to Diff 89899. yaxunl retitled this revision from "[WIP] Specify default address space for C++ on AMDGPU Target" to "[WIP] Supporting C++ based kernel languages on AMDGPU Target". yaxunl edited the summary of this revision. yaxunl added a comment. Fix invalid

Re: [libunwind] r296358 - Add libcxxabi's LICENSE.TXT to libunwind.

Merged together with r296359 to 4.0 in r296364. On Mon, Feb 27, 2017 at 9:33 AM, Arnaud A. de Grandmaison via cfe-commits wrote: > Author: aadg > Date: Mon Feb 27 11:33:20 2017 > New Revision: 296358 > > URL: http://llvm.org/viewvc/llvm-project?rev=296358=rev > Log: >

[libunwind] r296364 - Merging r296358 and r296359:

Author: hans Date: Mon Feb 27 12:03:07 2017 New Revision: 296364 URL: http://llvm.org/viewvc/llvm-project?rev=296364=rev Log: Merging r296358 and r296359: r296358 | aadg | 2017-02-27 09:33:20 -0800 (Mon, 27 Feb 2017) | 8

RE: r296296 - [X86] DAZ Macros Relocation

Hi Craig, All compilers will be updated accordingly including the documentation. Thanks, Oren From: Craig Topper [mailto:craig.top...@gmail.com] Sent: Sunday, February 26, 2017 22:57 To: Ben Simhon, Oren Cc: cfe-commits Subject: Re:

Re: [PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

Is that a "this patch is good" or a "please rewrite"? On Mon, Feb 27, 2017 at 1:50 PM, Reid Kleckner via Phabricator < revi...@reviews.llvm.org> wrote: > rnk added a comment. > > My understanding is that Windows doesn't allow you to delete a file that > has been opened and mapped into any

[PATCH] D27627: [WIP] Supporting C++ based kernel languages on AMDGPU Target

yaxunl updated this revision to Diff 89944. yaxunl added a comment. Fixed invalid bitcasts due to vtable. Added run line for amdgcn target to more Cuda lit tests. https://reviews.llvm.org/D27627 Files: include/clang/AST/ASTContext.h include/clang/Basic/TargetInfo.h lib/AST/ASTContext.cpp

r296408 - clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

Author: nico Date: Mon Feb 27 16:59:58 2017 New Revision: 296408 URL: http://llvm.org/viewvc/llvm-project?rev=296408=rev Log: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded Second attempt after http://llvm.org/viewvc/llvm-project?rev=296166=rev In the

Re: r296171 - Try to unbreak tests after r296166

I relanded the test in r296408. Since this deletes temp files created by the OS following an unpredictable pattern, exactly specifying the filename to delete isn't possible. Let me know if putting a functional rm on your bots is a problem and then we can see if we can think of something else, but

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

Ivan, you are listed as admin of http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf Please issue a clobber for it. If it does not help, the bot runs the following script: https://github.com/llvm-mirror/zorg/blob/master/zorg/buildbot/builders/sanitizers/buildbot_standard.sh It

[PATCH] D28266: Transparent_union attribute should be possible in front of union (rework)

aaron.ballman added a comment. Some minor nits, but I think this is generally correct. Comment at: include/clang/Sema/Sema.h:3059 void ProcessDeclAttributes(Scope *S, Decl *D, const Declarator ); + // Helper for delayed proccessing TransparentUnion attribute. + void

[libcxx] r296385 - Remove XFAIL in implicit_deduction_guides tests

Author: steven_wu Date: Mon Feb 27 15:10:41 2017 New Revision: 296385 URL: http://llvm.org/viewvc/llvm-project?rev=296385=rev Log: Remove XFAIL in implicit_deduction_guides tests The clang assertion causing these tests failing with sanitizer is fixed in r295794. All the bots running libcxx tests

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

thakis added inline comments. Comment at: lib/Rewrite/Rewriter.cpp:455 I->second.write(File.getStream()); + prewrite(I->first); } amccarth wrote: > I'm not familiar with the structure of this code, but it seems odd to me that > the callback is

r296388 - PR32042: Create inlined debug info for EmitInlinedInheritingCXXConstructorCall.

Author: adrian Date: Mon Feb 27 15:30:05 2017 New Revision: 296388 URL: http://llvm.org/viewvc/llvm-project?rev=296388=rev Log: PR32042: Create inlined debug info for EmitInlinedInheritingCXXConstructorCall. When clang emits an inheriting C++ constructor it may inline code during the CodeGen

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm We should file a bug against the Rewriter interface. It should really take MemoryBuffers from the caller and handle this for them. https://reviews.llvm.org/D30385

[PATCH] D30375: Function with unparsed body is a definition

jlebar added a comment. This doesn't look wrong to me, but I feel utterly unqualified to review this. https://reviews.llvm.org/D30375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

thakis closed this revision. thakis added a comment. r296408, thanks! https://reviews.llvm.org/D30385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:25 +static const StringRef ReplaceMessage = +"do not use 'random_shuffle'. It is deprecated and replaced by 'shuffle'."; + Diagnostics are not full sentences.

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

Hi Ivan, I saw a bot failure on your job after this commit: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/5467/steps/tsan%20analyze/logs/stdio

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

Does not seem to be related to tsan. It's just that somebody called a directory with compiler tsan_release_build, but that seems to be the only relation to tsan. Otherwise looks like a violated assertion in clang. On Mon, Feb 27, 2017 at 9:46 PM, Ivan Krasin wrote: > Hi

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

Hm, still can't reproduce this with a normal stage2-RA build of clang+compiler_rt. And it looks like the next build on the job has the same issue: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/5468/steps/annotate/logs/stdio Do you think there could be stale build

[PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

sfertile added inline comments. Comment at: lib/Driver/Tools.cpp:5436 + Args.AddLastArg(CmdArgs, options::OPT_fzvector); } If -fno-zvector has the same problem we should fix it as well. https://reviews.llvm.org/D30415

[PATCH] D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:955-957 +// DWARFv5 doesn't specify explicit DW_CC_* value for this case, +// thus we just return 'normal' here. +return llvm::dwarf::DW_CC_normal; dblaikie wrote: > Could you

[PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

bkramer accepted this revision. bkramer added a comment. lg Comment at: include-fixer/SymbolIndexManager.cpp:156 + for (const auto : MatchedSymbols) +Res.push_back(SymAndSig.Symbol); + return Res; std::move Comment at:

[clang-tools-extra] r296390 - [clangd] Make clangd install to bin

Author: d0k Date: Mon Feb 27 15:40:35 2017 New Revision: 296390 URL: http://llvm.org/viewvc/llvm-project?rev=296390=rev Log: [clangd] Make clangd install to bin This allows the install target to also install clangd to bin, so that it can be deployed and used outside the build tree. Patch by

r296386 - Remove unused variable

Author: dblaikie Date: Mon Feb 27 15:14:42 2017 New Revision: 296386 URL: http://llvm.org/viewvc/llvm-project?rev=296386=rev Log: Remove unused variable Modified: cfe/trunk/include/clang/Serialization/ASTReader.h Modified: cfe/trunk/include/clang/Serialization/ASTReader.h URL:

[PATCH] D27455: UBSan docs: Explicitly mention that `-fsanitize=unsigned-integer-overflow` does not catch UB.

thakis closed this revision. thakis added a comment. 296387. https://reviews.llvm.org/D27455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

Hi Vedant, not on top of my head. Dmitriy, can you please take a look? krasin On Mon, Feb 27, 2017 at 12:43 PM, Vedant Kumar wrote: > Hi Ivan, > > I saw a bot failure on your job after this commit: > > http://lab.llvm.org:8011/builders/sanitizer-x86_64- >

[PATCH] D30192: [Sema] Detecting more array index out of bounds

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. A few minor nits that can be resolved when you commit, but aside from those, LGTM. Comment at: lib/Sema/SemaChecking.cpp:10613 + case

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

amccarth added inline comments. Comment at: lib/Rewrite/Rewriter.cpp:455 I->second.write(File.getStream()); + prewrite(I->first); } I'm not familiar with the structure of this code, but it seems odd to me that the callback is called `prewrite`

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

thakis updated this revision to Diff 89923. thakis edited the summary of this revision. thakis added a comment. Here's a simpler fix, suggested by rnk. https://reviews.llvm.org/D30385 Files: tools/clang-format/ClangFormat.cpp Index: tools/clang-format/ClangFormat.cpp

Re: [libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.

For those watch the bots, Eric upgrade the bots with the new compiler and I remove the XFAIL in r296385. Thanks Steven > On Feb 23, 2017, at 11:48 AM, Steven Wu via cfe-commits > wrote: > > Hi Eric > > Looks like the issue is fixed in r295794? Now green dragon

r296387 - UBSan docs: Explicitly mention that `-fsanitize=unsigned-integer-overflow` does not catch UB.

Author: nico Date: Mon Feb 27 15:27:07 2017 New Revision: 296387 URL: http://llvm.org/viewvc/llvm-project?rev=296387=rev Log: UBSan docs: Explicitly mention that `-fsanitize=unsigned-integer-overflow` does not catch UB. https://reviews.llvm.org/D27455 Modified:

[PATCH] D29901: Modular Codegen: Add/use a bit in serialized function definitions to track whether they are the subject of modular codegen

dblaikie updated this revision to Diff 89931. dblaikie added a comment. - Simplify ModuleFile lookup - Build ModularCodegenDecls list from the same place the modular codegen bit is set on the decl - Cleanup no-longer-needed changes to DeclMustBeEmitted/isRequiredDecl

[PATCH] D30430: Make Lit tests C++11 compatible - IR ordering

tigerleapgorge created this revision. This test failure is caused by difference in IR ordering when compiling at C++98 vs C++11 Because there was a CHECK-NOT between the two CHECKs, just changing the CHECKs to CHECK-DAG would not work. So to make FileCheck more flexible. I have changed the

[PATCH] D30372: [Driver] Consolidate tools and toolchains by target platform. (NFC)

ahatanak added a comment. In https://reviews.llvm.org/D30372#687054, @dlj wrote: > In https://reviews.llvm.org/D30372#686871, @ahatanak wrote: > > > Have you considered using "include_directories" in CMakeLists.txt to avoid > > including "../Something.h"? > > > I don't want to take that

RE: r296171 - Try to unbreak tests after r296166

Thanks Nico. I think your suggestion is the right one, I am just trying to determine if there is a reason why we are not using that version internally (since our internal bot also failied for the same reason) before we recommend upgrading the bot. Douglas Yung From: Nico Weber

[PATCH] D29819: Introduce an 'external_source_symbol' attribute that describes the origin and the nature of a declaration

aaron.ballman added inline comments. Comment at: lib/Parse/ParseDecl.cpp:1161 +} else { + assert(Keyword == Ident_defined_in); + if (HadDefinedIn) { Add a string literal to the assert? Comment at:

[PATCH] D30435: [clang-import-test] Lookup inside entities

spyffe created this revision. Herald added a subscriber: jgosnell. clang-import-test has until now been only able to report top-level entities. This is clearly insufficient; we should be able to look inside structs and namespaces also. This patch adds new test cases for a variety of lookups

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

aaron.ballman added a reviewer: majnemer. aaron.ballman added inline comments. Comment at: include/clang/AST/ASTContext.h:1909 +// the unqualified type. +if (T.getQualifiers().hasUnaligned()) + TI.Align = getCharWidth(); This makes me a bit

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

klimek added inline comments. Comment at: include/clang/Rewrite/Core/Rewriter.h:188-197 + /// prewrite(FID) is called after all changes to FID have been written to a + /// temporary file, but before that temporary file is moved into FID's + /// location. Windows's

[PATCH] D30399: clang-format: [JS] whitespace after async in arrow functions.

mprobst created this revision. Herald added a subscriber: klimek. Async arrow functions should be marked with a whitespace after the async keyword, before the parameter list: x = async () => foo(); Before: x = async() => foo(); This makes it easier to tell apart an async arrow function

[PATCH] D30399: clang-format: [JS] whitespace after async in arrow functions.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, but I don't really know JS ;) https://reviews.llvm.org/D30399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30435: [clang-import-test] Lookup inside entities

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. A few stylistic issues inline. It also wouldn't hurt to document what is being tested, either in the clang-import-test sources or in the input files. Otherwise this looks fine. More tests

  1   2   >