Re: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

On Wed, Mar 1, 2017 at 10:35 AM, Mehdi Amini wrote: > I’m not sure I find this nice to see this upstream. > > I not fond in general of this kind of difference in behavior. I don’t > think it is good for clang to have different default for this kind of > settings depending

RE: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

Mehdi, again I invite you to discuss this on the cfe-dev thread rather than here. I have posted a reply there to bump it up, and any comments you have will be more visible and better serve the community over there. Thanks, --paulr From: mehdi.am...@apple.com [mailto:mehdi.am...@apple.com]

[libcxx] r296724 - Revert "Fix Apple-specific XFAIL directive in libc++ test"

Author: mehdi_amini Date: Wed Mar 1 19:57:40 2017 New Revision: 296724 URL: http://llvm.org/viewvc/llvm-project?rev=296724=rev Log: Revert "Fix Apple-specific XFAIL directive in libc++ test" This reverts commit r296712. It broke our bot. It turns out that the test is passing with c++11 and

[libcxx] r296716 - Fix python 3 syntax error in sym_diff

Author: ericwf Date: Wed Mar 1 18:03:01 2017 New Revision: 296716 URL: http://llvm.org/viewvc/llvm-project?rev=296716=rev Log: Fix python 3 syntax error in sym_diff Modified: libcxx/trunk/utils/libcxx/sym_check/diff.py Modified: libcxx/trunk/utils/libcxx/sym_check/diff.py URL:

[libcxx] r296704 - Fix Apple-specific XFAIL directive in libc++ test

Author: mehdi_amini Date: Wed Mar 1 17:14:34 2017 New Revision: 296704 URL: http://llvm.org/viewvc/llvm-project?rev=296704=rev Log: Fix Apple-specific XFAIL directive in libc++ test These tests are failing in XCode 8.0, 8.1, and 8.2, but not in Xcode 8.3. Annoyingly the version numbering for

[libcxx] r296725 - Recommit r296712: "Fix Apple-specific XFAIL directive in libc++ test"

Author: mehdi_amini Date: Wed Mar 1 20:01:11 2017 New Revision: 296725 URL: http://llvm.org/viewvc/llvm-project?rev=296725=rev Log: Recommit r296712: "Fix Apple-specific XFAIL directive in libc++ test" The test is passing with c++11 and c++14 but not c++1z on this particular version of the

[libcxx] r296712 - Fix Apple-specific XFAIL directive in libc++ test

Author: mehdi_amini Date: Wed Mar 1 17:45:03 2017 New Revision: 296712 URL: http://llvm.org/viewvc/llvm-project?rev=296712=rev Log: Fix Apple-specific XFAIL directive in libc++ test This tests is failing in XCode 7.0. But Xcode 7.3 that shipped an updated clang has this test passing. This is

[PATCH] D30516: [libc++] Add option to disable new/delete overloads when libc++abi provides them.

EricWF created this revision. Currently both libc++ and libc++abi provide definitions for operator new/delete. However I believe this is incorrect and that one or the other should offer them. This patch adds the CMake option `-DLIBCXX_ENABLE_NEW_DELETE_DEFINITIONS` which defaults no `ON`

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

mati865 added a comment. Ping. https://reviews.llvm.org/D29464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30518: Fix msc-version.c test to handle _MSC_VER=1910

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D30518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

jroelofs added a comment. In https://reviews.llvm.org/D30158#690032, @madsravn wrote: > Looks good for the two tests the are for `random_shuffle` in llvm libc++. There were a lot more some time ago, before @mclow.lists performed this transformation on libc++'s testsuite. You might want to try

Re: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

> On Mar 1, 2017, at 3:24 PM, Sean Silva wrote: > > > > On Wed, Mar 1, 2017 at 10:35 AM, Mehdi Amini > wrote: > I’m not sure I find this nice to see this upstream. > > I not fond in general of this kind of

[libcxxabi] r296715 - Cleanup new/delete definitions

Author: ericwf Date: Wed Mar 1 17:59:34 2017 New Revision: 296715 URL: http://llvm.org/viewvc/llvm-project?rev=296715=rev Log: Cleanup new/delete definitions This patch cleans up how libc++abi handles the definitions for new/delete. It is in preperation for upcoming changes to fix how both

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai added a comment. Hi Anna, Thanks for your review! > The information generated by this checker is used for array bounds checking. > For example, see https://reviews.llvm.org/D24307 I will read carefully about that ;-) > This patch looks good. Do you have commit access or should I

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 90264. smeenai added a comment. Changing more instances to new macro, per IRC discussion with Eric https://reviews.llvm.org/D29157 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/locale include/string Index: include/string

[PATCH] D27627: [WIP] Supporting C++ based kernel languages on AMDGPU Target

yaxunl updated this revision to Diff 90243. yaxunl edited the summary of this revision. https://reviews.llvm.org/D27627 Files: include/clang/AST/ASTContext.h include/clang/Basic/TargetInfo.h lib/AST/ASTContext.cpp lib/Basic/TargetInfo.cpp lib/Basic/Targets.cpp

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

hfinkel added inline comments. Comment at: lib/Driver/Tools.cpp:10334 - if (Args.hasFlag(options::OPT_fopenmp, options::OPT_fopenmp_EQ, - options::OPT_fno_openmp, false)) { + // FIXME: Exclude this for platforms with libgomp that don't require +

[PATCH] D30517: [libc++abi] Add option to enable definitions for the new/delete overloads.

EricWF created this revision. Currently both libc++ and libc++abi provide definitions for operator new/delete. However I believe this is incorrect and that one or the other should offer them. This patch adds the CMake option `-DLIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS` which defaults to `OFF`

[PATCH] D30518: Fix msc-version.c test to handle _MSC_VER=1910

DaveBartolomeo created this revision. Previously, VC++ has always set _MSC_VER to a four-digit value with the two least significant digits set to zero. Visual Studio 2017, however, sets _MSC_VER=1910, and we expect to update the least significant digit as we release major updates for VS 2017.

[libcxx] r296727 - Remove more usages of REQUIRES-ANY in the test-suite

Author: ericwf Date: Wed Mar 1 20:04:49 2017 New Revision: 296727 URL: http://llvm.org/viewvc/llvm-project?rev=296727=rev Log: Remove more usages of REQUIRES-ANY in the test-suite Modified: libcxx/trunk/test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.cons/assignment.pass.cpp

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru added a comment. Manuel, is that ok with you? thanks (I will rename the file) https://reviews.llvm.org/D30111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30498: [clangd] Add support for FixIts.

bkramer updated this revision to Diff 90181. bkramer added a comment. - Use typedef instead of decltype() - Rename local variable not to shadow member. - Give FixIts their own mutex - Use const instead of let in typescript https://reviews.llvm.org/D30498 Files: clangd/ASTManager.cpp

[PATCH] D30498: [clangd] Add support for FixIts.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks Great! https://reviews.llvm.org/D30498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

javed.absar added a comment. Hi Nico: This is for the case when using '#pragma bss_seg..' feature outside of msvc context. That's the reason for the flag. One could use attribute, but as attribute is attached to individual declaration, while pragma applies to whole file (unless superseded by

[clang-tools-extra] r296636 - [clangd] Add support for FixIts.

Author: d0k Date: Wed Mar 1 10:16:29 2017 New Revision: 296636 URL: http://llvm.org/viewvc/llvm-project?rev=296636=rev Log: [clangd] Add support for FixIts. Summary: This uses CodeActions to show 'apply fix' actions when code actions are requested for a location. The actions themselves make use

[PATCH] D30498: [clangd] Add support for FixIts.

This revision was automatically updated to reflect the committed changes. Closed by commit rL296636: [clangd] Add support for FixIts. (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D30498?vs=90181=90187#toc Repository: rL LLVM https://reviews.llvm.org/D30498 Files:

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai updated this revision to Diff 90275. smeenai added a comment. Rebase https://reviews.llvm.org/D25208 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/__locale include/__mutex_base include/condition_variable include/future include/mutex

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 90272. smeenai added a comment. Including inline in macro to work around PR32114 https://reviews.llvm.org/D29157 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/locale include/string Index: include/string

[libcxx] r296729 - [libc++] Mark some std::num_get method templates inline

Author: smeenai Date: Wed Mar 1 20:51:27 2017 New Revision: 296729 URL: http://llvm.org/viewvc/llvm-project?rev=296729=rev Log: [libc++] Mark some std::num_get method templates inline D29157 will make explicit template instantiations expand to default visibility, at which point these method

[PATCH] D30523: [libc++] Mark some std::num_get method templates inline

This revision was automatically updated to reflect the committed changes. Closed by commit rL296729: [libc++] Mark some std::num_get method templates inline (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D30523?vs=90270=90271#toc Repository: rL LLVM

[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

rjmccall added a comment. Thanks, LGTM. Repository: rL LLVM https://reviews.llvm.org/D30345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30214: [Driver] Search for libc++ headers in ResourceDir

Hahnfeld added a comment. In https://reviews.llvm.org/D30214#690010, @jroelofs wrote: > libc++ headers should not be installed in the resource dir. They are currently not by default. But with https://reviews.llvm.org/D30015 for runtime libraries, this may become a place for headers packaged

[PATCH] D30523: [libc++] Mark some std::num_get method templates inline

smeenai created this revision. https://reviews.llvm.org/D29157 will make explicit template instantiations expand to default visibility, at which point these method templates will need to be explicitly marked hidden visibility to avoid leaking into other DSOs. Unfortunately, because of clang

[libcxx] r296731 - [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

Author: smeenai Date: Wed Mar 1 21:02:50 2017 New Revision: 296731 URL: http://llvm.org/viewvc/llvm-project?rev=296731=rev Log: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members When building libc++ with hidden visibility, we want explicit template instantiations to export members.

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

This revision was automatically updated to reflect the committed changes. Closed by commit rL296731: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D29157?vs=90272=90274#toc Repository: rL LLVM

[libcxx] r296732 - [libc++] Make _LIBCPP_TYPE_VIS export members

Author: smeenai Date: Wed Mar 1 21:22:18 2017 New Revision: 296732 URL: http://llvm.org/viewvc/llvm-project?rev=296732=rev Log: [libc++] Make _LIBCPP_TYPE_VIS export members Summary: Most classes annotated with _LIBCPP_TYPE_VIS need to have at least some of their members exported, otherwise we

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

This revision was automatically updated to reflect the committed changes. Closed by commit rL296732: [libc++] Make _LIBCPP_TYPE_VIS export members (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D25208?vs=90275=90276#toc Repository: rL LLVM

[PATCH] D30516: [libc++] Add option to disable new/delete overloads when libc++abi provides them.

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D30516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30514: [libc++abi] Update new/delete definitions to match libc++

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. (It seems that having libc++ and libc++abi in the same repo would help sharing code like this) https://reviews.llvm.org/D30514

[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

arphaman updated this revision to Diff 90197. arphaman marked 4 inline comments as done. arphaman added a comment. Addressed John's comments. Repository: rL LLVM https://reviews.llvm.org/D30345 Files: lib/CodeGen/CGBlocks.cpp Index: lib/CodeGen/CGBlocks.cpp

[PATCH] D30499: [analyzer] pr32088: Don't destroy the temporary if its initializer causes return.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Seems like a safe quick fix for the crash. Looks good to me! https://reviews.llvm.org/D30499 ___ cfe-commits mailing list

[clang-tools-extra] r296637 - [clangd] Unbreak the shared build.

Author: d0k Date: Wed Mar 1 10:23:40 2017 New Revision: 296637 URL: http://llvm.org/viewvc/llvm-project?rev=296637=rev Log: [clangd] Unbreak the shared build. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt URL:

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

thakis added a comment. Adding incompatible extensions to MS extensions sounds like bad precedent to me. I think it'd be good if a code owner could opine on this change before it goes in. https://reviews.llvm.org/D30326 ___ cfe-commits mailing

Re: [libcxx] r296561 - Fix PR32097 - is_abstract doesn't work on class templates.

We're at the "should have tagged 'final' days ago" stage :-) Since it's not a regression, I would prefer not to merge it unless you feel super strongly about it. Sounds like a good candidate for 4.0.1 (tracking bug is PR32061). Thanks, Hans On Wed, Mar 1, 2017 at 1:36 AM, Eric Fiselier

r296638 - [clang-format] Don't add namespace end comments for unbalanced right braces after namespace end

Author: krasimir Date: Wed Mar 1 10:38:08 2017 New Revision: 296638 URL: http://llvm.org/viewvc/llvm-project?rev=296638=rev Log: [clang-format] Don't add namespace end comments for unbalanced right braces after namespace end Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp

[PATCH] D30517: [libc++abi] Add option to enable definitions for the new/delete overloads.

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. Comment at: CMakeLists.txt:416 +set(LIBCXXABI_HAS_UNDEFINED_SYMBOLS ((NOT LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS) +OR

Re: [libcxx] r296561 - Fix PR32097 - is_abstract doesn't work on class templates.

@Hans Where are we in the release process? I would like to merge this into 4.0. Although it's not a regression, it is a significant bug. This patch fixes the bug by forwarding to a compiler builtin, which is strictly better than what we have. I'm confident this patch is safe. /Eric On Tue, Feb

[PATCH] D30489: [analyzer] catch out of bounds for VLA

danielmarjamaki created this revision. This is a work in progress patch. I try to detect such error: void foo(int X) { int Buf[X]; Buf[X] = 0; } The patch successfully detects this bug. However it writes FP when you try to take the address. I would like to know if you think my

[PATCH] D30157: [analyzer] Improve valist check

danielmarjamaki added a comment. I am running this checker right now on various projects. Here are currently seen results.. https://drive.google.com/open?id=0BykPmWrCOxt2STZMOXZ5OGlwM3c Feel free to look at it and see if there are FPs or TPs. https://reviews.llvm.org/D30157

[PATCH] D30490: [change-namespace] get insertion points of forward declarations correct.

ioeric created this revision. Previously, the insertion points would conflict with the old namespace deletion. https://reviews.llvm.org/D30490 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index:

[PATCH] D30490: [change-namespace] get insertion points of forward declarations correct.

hokein added inline comments. Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:354 "namespace nb {\n" + "\n" "class FWD;\n" I'd create a new test for the fix instead of modifying the

[PATCH] D30490: [change-namespace] get insertion points of forward declarations correct.

ioeric updated this revision to Diff 90135. ioeric added a comment. - Create a new test case. And slight refactor. https://reviews.llvm.org/D30490 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index:

[clang-tools-extra] r296598 - [clang-tidy] Fix handling of methods with try-statement as a body in modernize-use-override

Author: alexfh Date: Wed Mar 1 04:16:36 2017 New Revision: 296598 URL: http://llvm.org/viewvc/llvm-project?rev=296598=rev Log: [clang-tidy] Fix handling of methods with try-statement as a body in modernize-use-override Summary: Fix generated by modernize-use-override caused syntax error when

[PATCH] D30002: [clang-tidy] Fix handling of methods with try-statement as a body in modernize-use-override

This revision was automatically updated to reflect the committed changes. Closed by commit rL296598: [clang-tidy] Fix handling of methods with try-statement as a body in modernize… (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D30002?vs=88582=90136#toc Repository:

[clang-tools-extra] r296599 - [clang-tidy] Add parametercount for readibility-function-size

Author: alexfh Date: Wed Mar 1 04:17:32 2017 New Revision: 296599 URL: http://llvm.org/viewvc/llvm-project?rev=296599=rev Log: [clang-tidy] Add parametercount for readibility-function-size Summary: Add an option to function-size to warn about high parameter counts. This might be relevant for

[PATCH] D16183: Added CheckName field to YAML report

alexfh added a comment. This patch is superseded by https://reviews.llvm.org/D26137. https://reviews.llvm.org/D16183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r296602 - [Sema] Improve side effect checking for unused-lambda-capture warning

Author: malcolm.parsons Date: Wed Mar 1 04:23:38 2017 New Revision: 296602 URL: http://llvm.org/viewvc/llvm-project?rev=296602=rev Log: [Sema] Improve side effect checking for unused-lambda-capture warning Summary: Don't warn about unused lambda captures that involve copying a value of a type

[PATCH] D30490: [change-namespace] get insertion points of forward declarations correct.

This revision was automatically updated to reflect the committed changes. Closed by commit rL296604: [change-namespace] get insertion points of forward declarations correct. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D30490?vs=90135=90141#toc Repository: rL LLVM

[clang-tools-extra] r296604 - [change-namespace] get insertion points of forward declarations correct.

Author: ioeric Date: Wed Mar 1 04:29:39 2017 New Revision: 296604 URL: http://llvm.org/viewvc/llvm-project?rev=296604=rev Log: [change-namespace] get insertion points of forward declarations correct. Summary: Previously, the insertion points would conflict with the old namespace deletion.

[PATCH] D24933: Enable configuration files in clang

sepavloff added a comment. Glad to know that someone is interested in this feature! Below is actual proposal. **Adding named configuration files to clang driver** A configuration file is a collection of driver options, which are inserted into command line before other options specified in the

r296605 - clang-format: Ignore contents of #ifdef SWIG .. #endif blocks.

Author: djasper Date: Wed Mar 1 04:47:52 2017 New Revision: 296605 URL: http://llvm.org/viewvc/llvm-project?rev=296605=rev Log: clang-format: Ignore contents of #ifdef SWIG .. #endif blocks. Those blocks are used if C++ code is SWIG-wrapped (see swig.org) and usually do not contain C++ code.

[PATCH] D30405: [clang-format] Add a new flag FixNamespaceEndComments to FormatStyle

djasper added inline comments. Comment at: include/clang/Format/Format.h:354 + /// fixes invalid existing ones. + bool FixNamespaceEndComments; + To be consistent with the clang-tidy check, just call this "FixNamespaceComments". After a change like this, you

r296608 - Fix r296605 so that stuff in #ifndef SWIG blocks is still formatted.

Author: djasper Date: Wed Mar 1 05:10:11 2017 New Revision: 296608 URL: http://llvm.org/viewvc/llvm-project?rev=296608=rev Log: Fix r296605 so that stuff in #ifndef SWIG blocks is still formatted. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn updated this revision to Diff 90148. madsravn added a comment. Updated patch according to comments by Ballman. https://reviews.llvm.org/D30158 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn marked 9 inline comments as done. madsravn added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77 + + auto Diag = [=]() { +std::string Message = ReplaceMessage; aaron.ballman wrote: > Is there a reason this needs

[PATCH] D30459: [libcxxabi] Clean up macro usage

rmaprath added a comment. In https://reviews.llvm.org/D30459#689461, @rs wrote: > Thanks for reviewing. Before I commit could you tell me if I need to update > any build systems e.g. buildbots ? Those two options are not used by any of the current public builders, so I think it's safe to

[PATCH] D30493: [change-namespace] avoid adding leading '::' when possible.

ioeric created this revision. When changing namespaces, the tool adds leading "::" to references that need to be fully-qualified, which would affect readability. We avoid adding "::" when the symbol name does not conflict with the new namespace name. For example, a symbol name "na::nb::X"

[libcxxabi] r296612 - [libcxxabi] Clean up macro usage.

Author: rsingh Date: Wed Mar 1 05:42:01 2017 New Revision: 296612 URL: http://llvm.org/viewvc/llvm-project?rev=296612=rev Log: [libcxxabi] Clean up macro usage. Convention in libcxxabi is to use !defined(FOO) not !FOO. Differential Revision: https://reviews.llvm.org/D30459 Modified:

[PATCH] D30459: [libcxxabi] Clean up macro usage

This revision was automatically updated to reflect the committed changes. Closed by commit rL296612: [libcxxabi] Clean up macro usage. (authored by rsingh). Changed prior to commit: https://reviews.llvm.org/D30459?vs=90150=90155#toc Repository: rL LLVM https://reviews.llvm.org/D30459

[PATCH] D30459: [libcxxabi] Clean up macro usage

rs added a comment. ok thanks. https://reviews.llvm.org/D30459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r296616 - Introducing clang::tooling::AtomicChange for refactoring tools.

Author: ioeric Date: Wed Mar 1 07:14:01 2017 New Revision: 296616 URL: http://llvm.org/viewvc/llvm-project?rev=296616=rev Log: Introducing clang::tooling::AtomicChange for refactoring tools. Summary: An AtomicChange is used to create and group a set of source edits, e.g. replacements or header

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

This revision was automatically updated to reflect the committed changes. Closed by commit rL296616: Introducing clang::tooling::AtomicChange for refactoring tools. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D27054?vs=90018=90165#toc Repository: rL LLVM

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

Abpostelnicu updated this revision to Diff 90171. Abpostelnicu added a comment. Also added tests. Repository: rL LLVM https://reviews.llvm.org/D30487 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp

[PATCH] D30489: [analyzer] catch out of bounds for VLA

xazax.hun added a comment. There is an alternative approach idea: This is not found by ArrayBoundCheckerV2? If no, an alternative approach would be to properly set the constraints on the extent of the VLA's memory region. After that, maybe ArrayBoundCheckerV2 would work automatically on this

[PATCH] D30405: [clang-format] Add a new flag FixNamespaceEndComments to FormatStyle

krasimir updated this revision to Diff 90172. krasimir marked 2 inline comments as done. krasimir added a comment. - Address review comments https://reviews.llvm.org/D30405 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp

[clang-tools-extra] r296618 - [clangd] Add a toy VS Code integration for development purposes

Author: krasimir Date: Wed Mar 1 07:53:12 2017 New Revision: 296618 URL: http://llvm.org/viewvc/llvm-project?rev=296618=rev Log: [clangd] Add a toy VS Code integration for development purposes Summary: This patch adds bare-bone VS Code integration for development purposes of clangd.

[PATCH] D30476: [clangd] Add a toy Eclipse integration for development purposes

malaperle-ericsson added a comment. To be honest, I don't think this needs to be merged but it makes sense to put it somewhere people can try it. Repository: rL LLVM https://reviews.llvm.org/D30476 ___ cfe-commits mailing list

[PATCH] D30498: [clangd] Add support for FixIts.

bkramer created this revision. This uses CodeActions to show 'apply fix' actions when code actions are requested for a location. The actions themselves make use of a clangd.applyFix command which has to be implemented on the editor side. I included an implementation for vscode. This also adds a

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

Abpostelnicu updated this revision to Diff 90176. Abpostelnicu added a comment. added patch against the updated repo. Repository: rL LLVM https://reviews.llvm.org/D30487 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp

[clang-tools-extra] r296627 - [clang-tidy] Attempt to fix the test where exceptions are disabled by default.

Author: alexfh Date: Wed Mar 1 08:41:11 2017 New Revision: 296627 URL: http://llvm.org/viewvc/llvm-project?rev=296627=rev Log: [clang-tidy] Attempt to fix the test where exceptions are disabled by default. Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-use-override.cpp

[PATCH] D30405: [clang-format] Add a new flag FixNamespaceComments to FormatStyle

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D30405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

sylvestre.ledru added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:430 + If ``true``, in the class inheritance expression clang-format will + break before operands ``:`` and ``,`` only if there is multiple + inheritance. s/is/are/

[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

ddcc added a comment. With the first method, I'm not sure how to refer to the `AnalyzerTest` class defined in `lit.cfg` from `lit.local.cfg`. It doesn't seem to be in scope, so unless I store an instantiation in the `config` object, I don't think it's accessible. Repository: rL LLVM

[PATCH] D30405: [clang-format] Add a new flag FixNamespaceComments to FormatStyle

This revision was automatically updated to reflect the committed changes. Closed by commit rL296632: [clang-format] Add a new flag FixNamespaceComments to FormatStyle (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D30405?vs=90172=90179#toc Repository: rL LLVM

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

djasper added a comment. Could you please upload a diff with the entire file as context? That makes reviewing this easier. Comment at: docs/ClangFormatStyleOptions.rst:428 +**BreakBeforeInhertianceDelimiter** (``boolt``) + If ``true``, in the class inheritance expression

r296648 - [Test] NFC: Fixed typo in comments

Author: lcharles Date: Wed Mar 1 11:55:03 2017 New Revision: 296648 URL: http://llvm.org/viewvc/llvm-project?rev=296648=rev Log: [Test] NFC: Fixed typo in comments Changed "declerations" to "declarations" Modified: cfe/trunk/test/Modules/Inputs/merge-using-decls/b.h

[PATCH] D29819: Introduce an 'external_source_symbol' attribute that describes the origin and the nature of a declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL296649: Introduce an 'external_source_symbol' attribute that describes the origin (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D29819?vs=90042=90205#toc Repository: rL

r296649 - Introduce an 'external_source_symbol' attribute that describes the origin

Author: arphaman Date: Wed Mar 1 12:06:25 2017 New Revision: 296649 URL: http://llvm.org/viewvc/llvm-project?rev=296649=rev Log: Introduce an 'external_source_symbol' attribute that describes the origin and the nature of a declaration This commit adds an external_source_symbol attribute to

[PATCH] D29819: Introduce an 'external_source_symbol' attribute that describes the origin and the nature of a declaration

arphaman added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3830-3837 + unsigned NumArgs; + // Some Clang-scoped attributes have some special parsing behavior. + if (ScopeName && ScopeName->getName() == "clang") +NumArgs = +

Re: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

I’m not sure I find this nice to see this upstream. I not fond in general of this kind of difference in behavior. I don’t think it is good for clang to have different default for this kind of settings depending on the platform. It does not provide a very good user experience from a

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77 + + auto Diag = [=]() { +std::string Message = ReplaceMessage; madsravn wrote: > aaron.ballman wrote: > > Is there a reason this needs to capture

r296646 - [analyzer] pr32088: Don't destroy the temporary if its initializer causes return.

Author: dcoughlin Date: Wed Mar 1 11:48:39 2017 New Revision: 296646 URL: http://llvm.org/viewvc/llvm-project?rev=296646=rev Log: [analyzer] pr32088: Don't destroy the temporary if its initializer causes return. In the following code involving GNU statement-expression extension: struct S {

[PATCH] D30499: [analyzer] pr32088: Don't destroy the temporary if its initializer causes return.

This revision was automatically updated to reflect the committed changes. Closed by commit rL296646: [analyzer] pr32088: Don't destroy the temporary if its initializer causes… (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D30499?vs=90178=90201#toc Repository: rL

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

zaks.anna added a comment. No multi-file support is a long outstanding limitation of scan-build html output. Great to see the patch!! Thank you for working on it! > It's not as immediately clear this is a multi-file output. In addition to Artem's suggestions, you might want to insert multiple

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

rnk added a comment. This functionality doesn't feel worth a driver flag. It customizes a very small aspect of a Microsoft extension that was only implemented for compatibility. It also reimplements the logic that LLVM uses in the backend to put global variables in .bss or .data. Can you

[PATCH] D30489: [analyzer] catch out of bounds for VLA

zaks.anna added a comment. Gábor's suggestion sounds good to me. I think ArrayBoundCheckerV2 checker has a higher chance to be productized / moved out of alpha in the future. Should we just remove ArrayBoundChecker.cpp or is there a value in keeping it around? Repository: rL LLVM

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn marked an inline comment as done. madsravn added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77 + + auto Diag = [=]() { +std::string Message = ReplaceMessage; aaron.ballman wrote: > madsravn wrote: > >

r296659 - clang-format: [JS/TS] Properly understand cast expressions.

Author: djasper Date: Wed Mar 1 13:26:12 2017 New Revision: 296659 URL: http://llvm.org/viewvc/llvm-project?rev=296659=rev Log: clang-format: [JS/TS] Properly understand cast expressions. Many things were wrong: - We didn't always allow wrapping after "as", which can be necessary. - We used to

[PATCH] D30268: Avoid copy of __atoms when char_type is char

hiraditya updated this revision to Diff 90214. hiraditya added a comment. Guarded the new implementation with _LIBCPP_ABI_OPTIMIZED_LOCALE macro to avoid ABI incompatibilities. https://reviews.llvm.org/D30268 Files: libcxx/include/__config libcxx/include/locale Index:

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77 + + auto Diag = [=]() { +std::string Message = ReplaceMessage; aaron.ballman wrote: > madsravn wrote: > > aaron.ballman wrote: > > > madsravn wrote: > > > >

  1   2   >