danielmarjamaki marked 2 inline comments as done.
danielmarjamaki added inline comments.
Comment at: lib/StaticAnalyzer/Core/CheckerHelpers.cpp:100
+ BinaryOperatorKind BOK,
+
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/CodeGen/CGObjC.cpp:3428
+ // CoreFoundation is not used in the code, the linker won't link the
+ // framework.
+ auto = getLLVMContext();
smaksimovic created this revision.
Reasoning behind this change was allowing the function to accept all values
from range [-128, 255] since all of them can be encoded in an 8bit wide value.
This differs from the prior state where only range [-128, 127] was accepted,
where values were assumed to
danielmarjamaki updated this revision to Diff 92150.
danielmarjamaki added a comment.
Fix review comments
Repository:
rL LLVM
https://reviews.llvm.org/D30295
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/CheckerHelpers.h
lib/StaticAnalyzer/Checkers/ConversionChecker.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298101: [Clang-tidy] Fix for misc-noexcept-move-constructor
false triggers on defaulted… (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D31049?vs=92037=92159#toc
Repository:
alexfh added a comment.
Could you generate a diff with full context
(http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)?
https://reviews.llvm.org/D30931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: dmgreen
Date: Fri Mar 17 10:38:49 2017
New Revision: 298097
URL: http://llvm.org/viewvc/llvm-project?rev=298097=rev
Log:
Test commit.
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/ARM.h
Modified: cfe/trunk/lib/Driver/ToolChains/Arch/ARM.h
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298098: [clang-cl] Fix cross-compilation with MSVC 2017.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D30991?vs=92050=92154#toc
Repository:
rL LLVM
Author: zturner
Date: Fri Mar 17 11:24:34 2017
New Revision: 298098
URL: http://llvm.org/viewvc/llvm-project?rev=298098=rev
Log:
[clang-cl] Fix cross-compilation with MSVC 2017.
clang-cl works best when the user runs vcvarsall to set up
an environment before running, but even this is not enough
Author: alexfh
Date: Fri Mar 17 11:40:34 2017
New Revision: 298101
URL: http://llvm.org/viewvc/llvm-project?rev=298101=rev
Log:
[Clang-tidy] Fix for misc-noexcept-move-constructor false triggers on defaulted
declarations
Summary:
There is no need for triggering warning when noexcept specifier
tejohnson created this revision.
Herald added subscribers: Prazek, mehdi_amini.
We noticed that when invoking the thinBackend via clang (for the
distributed build case) that flags like -ffunction-sections and
-emit-llvm were not having the intended effect. This could have been
fixed by setting up
Author: mgehre
Date: Fri Mar 17 16:41:20 2017
New Revision: 298126
URL: http://llvm.org/viewvc/llvm-project?rev=298126=rev
Log:
Implement DR 373 "Lookup on namespace qualified name in using-directive"
Summary:
3.4.6 [basic.lookup.udir] paragraph 1:
In a using-directive or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298126: Implement DR 373 "Lookup on namespace qualified name
in using-directive" (authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D30848?vs=91956=92209#toc
Repository:
rL LLVM
danielmarjamaki added a comment.
In my opinion, we should stop warning about all implicit casts.
Take for instance:
long l1;
if (condition)
l1 = n << 8; // <- implicit cast
else
l1 = ~0L;
That is fine. Nothing suspicious. Just because the destination variable is long
doesn't
jutocz updated this revision to Diff 92205.
jutocz added a comment.
Updated diff to show full context
https://reviews.llvm.org/D30931
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
clang-tidy/readability/IdentifierNamingCheck.h
Index:
danielmarjamaki created this revision.
Herald added a subscriber: JDevlieghere.
This patch fixes https://bugs.llvm.org/show_bug.cgi?id=32246
To avoid spurious warnings, clang-tidy should not warn about misplaced widening
casts for implicit casts in function calls.
Repository:
rL LLVM
erichkeane added a comment.
Ping!
https://reviews.llvm.org/D29599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
LLVM buildmaster will be updated and restarted after 5 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: niravd
Date: Fri Mar 17 19:43:39 2017
New Revision: 298177
URL: http://llvm.org/viewvc/llvm-project?rev=298177=rev
Log:
[X86] Add NumRegisterParameters Module Flag.
Reviewers: rnk, mkuper
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D27051
Added:
mgehre updated this revision to Diff 92211.
mgehre marked an inline comment as done.
mgehre added a comment.
Update for review comments
https://reviews.llvm.org/D24886
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaStmtAttr.cpp
Author: dexonsmith
Date: Fri Mar 17 17:55:13 2017
New Revision: 298165
URL: http://llvm.org/viewvc/llvm-project?rev=298165=rev
Log:
Modules: Cache PCMs in memory and avoid a use-after-free
Clang's internal build system for implicit modules uses lock files to
ensure that after a process writes a
bkelley updated this revision to Diff 92218.
bkelley added a comment.
Updated with feedback from @jordan_rose and @arphaman
https://reviews.llvm.org/D31005
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaExprMember.cpp
bkelley marked an inline comment as done.
bkelley added inline comments.
Comment at: lib/Sema/SemaCast.cpp:125
+ assert(Self.getLangOpts().ObjCAutoRefCount ||
+ Self.getLangOpts().ObjCWeak);
rjmccall wrote:
> Unlike the other patches, we do
bkelley updated this revision to Diff 92220.
bkelley added a comment.
Integrated feedback from @rjmccall
https://reviews.llvm.org/D31007
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/Sema/SemaCast.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDeclCXX.cpp
lib/Sema/SemaInit.cpp
dexonsmith closed this revision.
dexonsmith marked an inline comment as done.
dexonsmith added a comment.
Thanks for the reviews! Committed in r298165.
https://reviews.llvm.org/D28299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: akirtzidis
Date: Fri Mar 17 18:41:59 2017
New Revision: 298170
URL: http://llvm.org/viewvc/llvm-project?rev=298170=rev
Log:
[index] For C++ constructors/destructors, add references to the parent type
where its name appears in definitions and declarations
Patch by Nathan Hawes!
Author: bruno
Date: Fri Mar 17 19:26:18 2017
New Revision: 298175
URL: http://llvm.org/viewvc/llvm-project?rev=298175=rev
Log:
[Modules] In case of lock timeout, fallback and build module
Duncan's r298165 introduced the PCMCache mechanism, which guarantees
that locks aren't necessary anymore for
Author: davide
Date: Fri Mar 17 17:19:20 2017
New Revision: 298160
URL: http://llvm.org/viewvc/llvm-project?rev=298160=rev
Log:
[Sema] Unbreak GCC -Werror build (enum compare).
Modified:
cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp
Modified: cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp
URL:
bkelley updated this revision to Diff 92217.
bkelley added a comment.
Updated with feedback from @rjmccall
https://reviews.llvm.org/D31004
Files:
lib/AST/Type.cpp
lib/Sema/SemaExprCXX.cpp
test/SemaObjCXX/objc-weak-type-traits.mm
Index: test/SemaObjCXX/objc-weak-type-traits.mm
bkelley marked 3 inline comments as done.
bkelley added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:10184
+ (!getLangOpts().ObjCAutoRefCount && getLangOpts().ObjCWeak &&
+ VDecl->getType().getObjCLifetime() != Qualifiers::OCL_Weak)) &&
bkelley updated this revision to Diff 92219.
bkelley marked an inline comment as done.
bkelley added a comment.
Updated with feedback from @rjmccall
https://reviews.llvm.org/D31006
Files:
include/clang/Basic/LangOptions.h
include/clang/Sema/Sema.h
lib/Sema/SemaCast.cpp
bkelley added a comment.
Thanks for all the feedback! I think things are looking a lot better now.
https://reviews.llvm.org/D31007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkelley updated this revision to Diff 92216.
bkelley marked an inline comment as done.
bkelley added a comment.
Integrated feedback from @rjmccall
https://reviews.llvm.org/D31003
Files:
lib/AST/DeclCXX.cpp
lib/Sema/SemaDeclCXX.cpp
test/CodeGenObjCXX/objc-weak.mm
Index:
bkelley marked 2 inline comments as done.
bkelley added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:4407
+ (SemaRef.getLangOpts().ObjCWeak &&
+FieldBaseElementType.getObjCLifetime() == Qualifiers::OCL_Weak))) {
+// ARC and Weak:
bkelley added a comment.
Looks like we can simplify everything by using `hasNonTrivialObjCLifetime()`,
like in https://reviews.llvm.org/D31003.
https://reviews.llvm.org/D31004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
chandlerc updated this revision to Diff 92245.
chandlerc added a comment.
Update with fixes suggested in review.
https://reviews.llvm.org/D30806
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/Builtins.def
lib/AST/ASTContext.cpp
lib/CodeGen/CGCall.cpp
test/CodeGen/nonnull.c
chandlerc marked an inline comment as done.
chandlerc added a comment.
Function argument order fixed.
https://reviews.llvm.org/D30806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Core/CheckerHelpers.cpp:99
+bool clang::ento::isExprResultConformsComparisonRule(CheckerContext ,
+ BinaryOperatorKind BOK,
+
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM
https://reviews.llvm.org/D30848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ctopper
Date: Fri Mar 17 00:59:22 2017
New Revision: 298041
URL: http://llvm.org/viewvc/llvm-project?rev=298041=rev
Log:
[AVX-512] Fix test cases that were using the builtins directly without
typecasts instead of the intrinsic header.
Modified:
Author: ctopper
Date: Fri Mar 17 00:59:25 2017
New Revision: 298042
URL: http://llvm.org/viewvc/llvm-project?rev=298042=rev
Log:
[AVX-512] Change the input type for some load intrinsics to take void type like
the spec (and the test cases say).
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
jutocz updated this revision to Diff 92108.
jutocz retitled this revision from "[clang-tidy] added new identifier naming
case type for ignoring case style" to "[clang-tidy] modified identifier naming
case to use CT_AnyCase for ignoring case style".
jutocz edited the summary of this revision.
Author: alexfh
Date: Fri Mar 17 03:40:07 2017
New Revision: 298052
URL: http://llvm.org/viewvc/llvm-project?rev=298052=rev
Log:
[clang-tidy] Ignore deleted members in google-explicit-constructor.
This fixes http://llvm.org/PR32221.
Modified:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D30841#702980, @fgross wrote:
> Now using `ASTContext::getParents` instead of `ChainedIfs` map.
>
> For some reason I thought of `getParents` as an expensive
ogoffart added a comment.
Ping
https://reviews.llvm.org/D26350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298059: [clang-tidy] readability-misleading-indentation: fix
chained if (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D30841?vs=92026=92116#toc
Repository:
rL LLVM
Author: alexfh
Date: Fri Mar 17 04:58:30 2017
New Revision: 298059
URL: http://llvm.org/viewvc/llvm-project?rev=298059=rev
Log:
[clang-tidy] readability-misleading-indentation: fix chained if
Summary:
Fixed erroneously flagging of chained if statements when styled like this:
```
if (cond) {
}
Author: alexfh
Date: Fri Mar 17 05:05:49 2017
New Revision: 298060
URL: http://llvm.org/viewvc/llvm-project?rev=298060=rev
Log:
[clang-tidy] Added a test with a different format.
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-misleading-indentation.cpp
Modified:
ioeric created this revision.
https://reviews.llvm.org/D31076
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
===
---
alexfh added a comment.
Do you have commit rights?
Repository:
rL LLVM
https://reviews.llvm.org/D31049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
edyp87 added a comment.
No, please apply this patch for me. Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D31049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 92138.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Merged with origin/master
- Addressed comments. Merged with origin/master.
https://reviews.llvm.org/D30493
Files:
change-namespace/ChangeNamespace.cpp
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:291
+ assert(!SymbolSplitted.empty());
+ SymbolSplitted.pop_back();
+
hokein wrote:
> Is this needed? Looks like you are removing the name of the symbol here, but
> from the code
ahmedasadi added a comment.
Thanks for reviewing. Yes, I need someone to commit for me.
https://reviews.llvm.org/D31069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D31049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: alexfh
Date: Fri Mar 17 04:47:05 2017
New Revision: 298057
URL: http://llvm.org/viewvc/llvm-project?rev=298057=rev
Log:
[clang-tidy] Verify some conditions in a matcher instead of check(). NFC
Modified:
clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.cpp
Modified:
uweigand added a comment.
In https://reviews.llvm.org/D30415#703442, @hfinkel wrote:
> In https://reviews.llvm.org/D30415#703398, @echristo wrote:
>
> > Different suggestion:
> >
> > Remove the faltivec option. Even gcc doesn't support it anymore afaict.
>
>
> What are you suggesting? Always
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D31076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ioeric
Date: Fri Mar 17 09:05:39 2017
New Revision: 298090
URL: http://llvm.org/viewvc/llvm-project?rev=298090=rev
Log:
[change-namespace] do not rename specialized template parameters.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D31076
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298090: [change-namespace] do not rename specialized
template parameters. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D31076?vs=92135=92141#toc
Repository:
rL LLVM
rs created this revision.
Convention in libunwind is to use !defined(FOO) not !FOO.
https://reviews.llvm.org/D31078
Files:
include/__libunwind_config.h
include/libunwind.h
include/unwind.h
src/AddressSpace.hpp
src/Unwind-EHABI.cpp
src/Unwind-EHABI.h
src/Unwind-sjlj.c
61 matches
Mail list logo
