[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

ABataev added a comment. Guys, sorry for the delay with the reviews. I was on a vacation, now I'm on a relocation process. Will look at all patches as soon as possible, but not earlier than next week :( Sorry again. https://reviews.llvm.org/D30739

[libcxx] r298418 - Add a bit more to one of the chrono tests

Author: marshall Date: Tue Mar 21 13:40:46 2017 New Revision: 298418 URL: http://llvm.org/viewvc/llvm-project?rev=298418=rev Log: Add a bit more to one of the chrono tests Modified: libcxx/trunk/test/std/utilities/time/time.duration/time.duration.arithmetic/op_+.pass.cpp Modified:

Re: [PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

On 03/21/2017 12:19 PM, Ulrich Weigand via Phabricator wrote: uweigand added a comment. In https://reviews.llvm.org/D30415#705889, @echristo wrote: In https://reviews.llvm.org/D30415#705196, @uweigand wrote: Well, mainline GCC doesn't have -faltivec at all and never had, I think this was

r298392 - [index/AST] Determine if a typedef shares a name and spelling location with its underlying tag type

Author: akirtzidis Date: Tue Mar 21 11:56:02 2017 New Revision: 298392 URL: http://llvm.org/viewvc/llvm-project?rev=298392=rev Log: [index/AST] Determine if a typedef shares a name and spelling location with its underlying tag type In such a case, as when using the NS_ENUM macro, for indexing

[PATCH] D27486: Correct class-template deprecation behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rL298410: Correct class-template deprecation behavior (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D27486?vs=84330=92514#toc Repository: rL LLVM

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

brenoguim added a comment. I appreciate it! https://reviews.llvm.org/D31130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: FW: SemaAccess bug (protected members of derived)

Thanks, It looks like your solution isn't quite right as it causes Clang to accept invalid access to protected members, e.g. as tested by "test/CXX/class.access/class.protected/p1.cpp". Do you think there's an alternative solution that you could use? Alex On 21 March 2017 at 14:48, Dixon Ryan

[libcxx] r298416 - Implement P0548: 'common_type and duration' This involves a subtle change in the return type of the unary +/- operators for std::chrono::duration, though I expect that no one will n

Author: marshall Date: Tue Mar 21 13:38:57 2017 New Revision: 298416 URL: http://llvm.org/viewvc/llvm-project?rev=298416=rev Log: Implement P0548: 'common_type and duration' This involves a subtle change in the return type of the unary +/- operators for std::chrono::duration, though I expect

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. In https://reviews.llvm.org/D30810#706676, @Anastasia wrote: > In https://reviews.llvm.org/D30810#699428, @Anastasia wrote: > > > Would you be able to update ScalarExprEmitter::VisitAsTypeExpr > > implementation accordingly to make things consistent? > > > Not sure it

r298424 - [CMake] fix CLANG_INCLUDE_DIRS CMake export

Author: papin_g Date: Tue Mar 21 14:17:53 2017 New Revision: 298424 URL: http://llvm.org/viewvc/llvm-project?rev=298424=rev Log: [CMake] fix CLANG_INCLUDE_DIRS CMake export Summary: This change should fixes the export of CLANG_INCLUDE_DIRS variable in ClangConfig.cmake. Unlike for the other

r298394 - Update Clang for LLVM rename AttributeSet -> AttributeList

Author: rnk Date: Tue Mar 21 11:57:30 2017 New Revision: 298394 URL: http://llvm.org/viewvc/llvm-project?rev=298394=rev Log: Update Clang for LLVM rename AttributeSet -> AttributeList Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/lib/CodeGen/CGCXX.cpp

[PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

uweigand added a comment. In https://reviews.llvm.org/D30415#705889, @echristo wrote: > In https://reviews.llvm.org/D30415#705196, @uweigand wrote: > > > Well, mainline GCC doesn't have -faltivec at all and never had, I think > > this was only an Apple GCC extension ... Not sure what exactly

[PATCH] D30009: Add support for '#pragma clang attribute'

arphaman added a comment. In https://reviews.llvm.org/D30009#706515, @aaron.ballman wrote: > In https://reviews.llvm.org/D30009#706171, @arphaman wrote: > > > I would be ok with that. We could merge `apply_to` and `apply_only_to` into > > a single `apply_to` matching rule set specifier (it

r298420 - Fix array sizes where address space is not yet known

Author: kzhuravl Date: Tue Mar 21 13:55:39 2017 New Revision: 298420 URL: http://llvm.org/viewvc/llvm-project?rev=298420=rev Log: Fix array sizes where address space is not yet known For variables in generic address spaces, for example: ``` unsigned char V[6442450944]; ... ``` the address

[PATCH] D30845: Fix array sizes where address space is not yet known

This revision was automatically updated to reflect the committed changes. kzhuravl marked an inline comment as done. Closed by commit rL298420: Fix array sizes where address space is not yet known (authored by kzhuravl). Changed prior to commit:

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r298421. https://reviews.llvm.org/D31130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27627: [WIP] Supporting C++ based kernel languages on AMDGPU Target

rjmccall added a comment. Okay. That does seem more sensible than trying to change everything around the other way. https://reviews.llvm.org/D27627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31134: [Serialization] Serialize DependentSizedExtVectorType

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Alex, thanks! Repository: rL LLVM https://reviews.llvm.org/D31134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

aaron.ballman added a comment. In https://reviews.llvm.org/D31130#706623, @brenoguim wrote: > Hi @aaron.ballman, > > Thanks for the review! > > I don't have rights to push this. Who should I contact to push the change in > my behalf? I'm happy to do so on your behalf (it'll happen later this

r298414 - Modules: Remove an invalid check in unit tests for r298278

Author: dexonsmith Date: Tue Mar 21 13:26:18 2017 New Revision: 298414 URL: http://llvm.org/viewvc/llvm-project?rev=298414=rev Log: Modules: Remove an invalid check in unit tests for r298278 This is a fixup for the unit tests from r298278 (originally r298165). Since the buffer that RawB2

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. In https://reviews.llvm.org/D30810#699428, @Anastasia wrote: > Would you be able to update ScalarExprEmitter::VisitAsTypeExpr implementation > accordingly to make things consistent? Not sure it got lost somewhere... do you think you could address this too?

[clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

Author: aaronballman Date: Tue Mar 21 14:01:17 2017 New Revision: 298421 URL: http://llvm.org/viewvc/llvm-project?rev=298421=rev Log: Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros. Patch by Breno Rodrigues

[PATCH] D31179: Objective-C categories should support attributes

arphaman added inline comments. Comment at: test/SemaObjC/attr-deprecated.m:124-128 +@interface A(Blah) // no warning +- (A*)getA; @end +@implementation A(Blah) // no warning aaron.ballman wrote: > I would have assumed the use in the `@implementation` would

[PATCH] D31174: [X86][MS-compatability] allow MS TYPE/SIZE/LENGTH operators as a part of a compound expression

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D31174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r298410 - Correct class-template deprecation behavior

Author: erichkeane Date: Tue Mar 21 12:49:17 2017 New Revision: 298410 URL: http://llvm.org/viewvc/llvm-project?rev=298410=rev Log: Correct class-template deprecation behavior Based on the comment in the test, and my reading of the standard, a deprecated warning should be issued in the

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

brenoguim marked 4 inline comments as done. brenoguim added a comment. Hi @aaron.ballman, Thanks for the review! I don't have rights to push this. Who should I contact to push the change in my behalf? https://reviews.llvm.org/D31130 ___

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. > Hi Anastasia, Bruno, > > Do you still have other opinion? or Can we go ahead and commit this patch? I would like to see this patch committed. I see clear evidence of it improving existing GPU targets in the master repo as well as outside of the main tree

[PATCH] D31153: Add the ability to use the children() range API in a const-correct manner

aaron.ballman updated this revision to Diff 92522. aaron.ballman added a comment. Missed a case for `UnaryExprOrTypeTraitExpr`. https://reviews.llvm.org/D31153 Files: include/clang/AST/Expr.h include/clang/AST/StmtIterator.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp

[libcxx] r298422 - Fix a couple of 'C++11'-isms from the last checkin, which broke the '03 bot.

Author: marshall Date: Tue Mar 21 14:12:21 2017 New Revision: 298422 URL: http://llvm.org/viewvc/llvm-project?rev=298422=rev Log: Fix a couple of 'C++11'-isms from the last checkin, which broke the '03 bot. Modified: libcxx/trunk/include/type_traits

[PATCH] D31202: Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase.

danielcdh created this revision. Herald added subscribers: Prazek, mehdi_amini. Because SamplePGO passes will be invoked twice in ThinLTO build: once at compile phase, the other at backend. We want to make sure the IR at the 2nd phase matches the hot part in pro file, thus we do not want to

[PATCH] D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes

rjmccall added inline comments. Comment at: lib/AST/Type.cpp:3773 +/// lifetime semantics. +bool Type::isNonTrivialObjCLifetimeType() const { + return CanonicalType.hasNonTrivialObjCLifetime(); Is this method not identical in behavior to

[PATCH] D31006: [Objective-C] Fix "weak-unavailable" warning with -fobjc-weak

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/Sema/SemaCast.cpp:125 + assert(Self.getLangOpts().ObjCAutoRefCount || + Self.getLangOpts().ObjCWeak); bkelley

[PATCH] D31004: [Objective-C] Fix __weak type traits with -fobjc-weak

rjmccall added inline comments. Comment at: lib/AST/Type.cpp:2026 - if (Context.getLangOpts().ObjCAutoRefCount) { -switch (getObjCLifetime()) { -case Qualifiers::OCL_ExplicitNone: - return true; - -case Qualifiers::OCL_Strong: -case

[PATCH] D31174: [X86][MS-compatability] allow MS TYPE/SIZE/LENGTH operators as a part of a compound expression

coby created this revision. This patch introduces X86AsmParser with the ability to handle the aforementioned ops within compound "MS" arithmetical expressions. Currently - only supported as a stand alone Operand, e.g.: "TYPE X" now allowed : "4 + TYPE X * 128" LLVM side:

[PATCH] D31082: [mips][msa] Range adjustment for ldi_b builtin function operand

smaksimovic updated this revision to Diff 92439. smaksimovic added a comment. Added a new test to test/CodeGen/builtins-mips-msa.c, covering the new extended range for ldi.b. https://reviews.llvm.org/D31082 Files: lib/Sema/SemaChecking.cpp test/CodeGen/builtins-mips-msa-error.c

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added a comment. Thanks, I do not have commit rights, can anyone commit this? https://reviews.llvm.org/D30739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r298369 - [OpenCL] Added diagnostic for checking length of vector

Author: echuraev Date: Tue Mar 21 08:20:57 2017 New Revision: 298369 URL: http://llvm.org/viewvc/llvm-project?rev=298369=rev Log: [OpenCL] Added diagnostic for checking length of vector Reviewers: Anastasia, cfe-commits Reviewed By: Anastasia Subscribers: bader, yaxunl Differential Revision:

[PATCH] D31187: Fix removal of out-of-line definitions.

v.g.vassilev created this revision. Consider: ` struct MyClass { void f() {} } MyClass::f(){} // expected error redefinition of f. ` The routine fails to remove the lookup entry is registered in the semantic decl context and not in the primary decl context of the lexical decl context where

[PATCH] D31187: Fix removal of out-of-line definitions.

v.g.vassilev updated this revision to Diff 92481. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. U https://reviews.llvm.org/D31187 Files: lib/AST/DeclBase.cpp Index: lib/AST/DeclBase.cpp

r298371 - [DOXYGEN] Improvements to smmintrin.h and emmintrin.h intrinsics.

Author: kromanova Date: Tue Mar 21 08:34:06 2017 New Revision: 298371 URL: http://llvm.org/viewvc/llvm-project?rev=298371=rev Log: [DOXYGEN] Improvements to smmintrin.h and emmintrin.h intrinsics. I made some small changes in smmintrin.h and emmintrin.h intrinsics. - changed some regular

[PATCH] D31177: [ARC][ObjC++] Use ObjC semantic rules for comparisons between a pointer and objective-c object pointer

arphaman created this revision. When ARC is enabled in Objective-C++, comparisons between a pointer and Objective-C object pointer typically result in errors like this: `invalid operands to a binary expression`. This error message can be quite confusing as it doesn't provide a solution to the

[PATCH] D30777: Added `applyAtomicChanges` function.

ioeric added a comment. Ping ;) https://reviews.llvm.org/D30777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31176: [clang-rename] Support renaming qualified symbol

ioeric added a comment. I think this is a great start! First round with some nits. Comment at: clang-rename/RenamingAction.cpp:87 +class QualifiedRenamingASTConsumer : public ASTConsumer { +public: Comments. Comment at:

[PATCH] D30810: Preserve vec3 type.

jaykang10 added a comment. In https://reviews.llvm.org/D30810#702637, @jaykang10 wrote: > In https://reviews.llvm.org/D30810#702614, @Anastasia wrote: > > > In https://reviews.llvm.org/D30810#702443, @bruno wrote: > > > > > > As a result, I think it would be good for clang to have both of > > >

[PATCH] D30009: Add support for '#pragma clang attribute'

arphaman added a comment. In https://reviews.llvm.org/D30009#705699, @aaron.ballman wrote: > In https://reviews.llvm.org/D30009#705649, @efriedma wrote: > > > Looking over the most recent version, I'm happy with the general semantics > > of push with apply_only_to. I'm not sure I see the point

r298355 - [scan-build-py] reuse command line output parameter for report directory

Author: rizsotto Date: Tue Mar 21 05:15:18 2017 New Revision: 298355 URL: http://llvm.org/viewvc/llvm-project?rev=298355=rev Log: [scan-build-py] reuse command line output parameter for report directory Differential Revision: https://reviews.llvm.org/D30861 Modified:

[PATCH] D31178: [libcxxabi] Fix exception address alignment test for EHABI

rmaprath created this revision. Herald added a subscriber: aemerson. This test was failing on our downstream (bare-metal) runs and only now I got around to investigate it. The problem is, this test assumes the Itanium ABI, whereas EHABI requires the exception address to be 8-byte aligned. I

[PATCH] D31178: [libcxxabi] Fix exception address alignment test for EHABI

rmaprath updated this revision to Diff 92450. rmaprath added a comment. Fixed a few paths. https://reviews.llvm.org/D31178 Files: test/libcxxabi/test/config.py test/lit.site.cfg.in test/test_exception_address_alignment.pass.cpp Index: test/test_exception_address_alignment.pass.cpp

[PATCH] D30493: [change-namespace] avoid adding leading '::' when possible.

ioeric added a comment. Ping ;) https://reviews.llvm.org/D30493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31178: [libcxxabi] Fix exception address alignment test for EHABI

rengolin added a comment. This looks like a simple oversight from my perspective, so looks good. But I'll let the others have a look at it, as I'm not overly familiar with libcxxabi. cheers, --renato https://reviews.llvm.org/D31178 ___

[PATCH] D30493: [change-namespace] avoid adding leading '::' when possible.

ioeric added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:296 +assert(!NsSplitted.empty()); +for (auto I = NsSplitted.begin() + 1, E = NsSplitted.end(); I != E; ++I) { + if (*I == SymbolSplitted.front()) hokein wrote: > ioeric

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

Hahnfeld added a comment. In principal looks good to me although I'm not really familiar with this part. Does that work for you if you have the `declare simd` in a header file and the implementation in another file? On x86_64 I currently get: remark: loop not vectorized: call instruction

[PATCH] D30493: [change-namespace] avoid adding leading '::' when possible.

ioeric updated this revision to Diff 92475. ioeric added a comment. - fixed newly added tests. https://reviews.llvm.org/D30493 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-namespace/ChangeNamespaceTests.cpp

[clang-tools-extra] r298363 - [change-namespace] avoid adding leading '::' when possible.

Author: ioeric Date: Tue Mar 21 07:41:59 2017 New Revision: 298363 URL: http://llvm.org/viewvc/llvm-project?rev=298363=rev Log: [change-namespace] avoid adding leading '::' when possible. Summary: When changing namespaces, the tool adds leading "::" to references that need to be fully-qualified,

[PATCH] D30493: [change-namespace] avoid adding leading '::' when possible.

This revision was automatically updated to reflect the committed changes. Closed by commit rL298363: [change-namespace] avoid adding leading '::' when possible. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D30493?vs=92475=92476#toc Repository: rL LLVM

r298364 - [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305)

Author: rksimon Date: Tue Mar 21 07:46:13 2017 New Revision: 298364 URL: http://llvm.org/viewvc/llvm-project?rev=298364=rev Log: [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305) Differential Revision: https://reviews.llvm.org/D31155 Modified:

[PATCH] D31155: [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305)

This revision was automatically updated to reflect the committed changes. Closed by commit rL298364: [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305) (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D31155?vs=92390=92477#toc Repository: rL

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:60 +// Set timeout to 15000ms = 15s +Z3_set_param_value(Config, "timeout", "15000"); + } Sorry for being a bit late in the party, I was wondering whether this

r298366 - [OpenCL] Added implicit conversion rank for overloading functions with vector data type in OpenCL

Author: echuraev Date: Tue Mar 21 07:55:55 2017 New Revision: 298366 URL: http://llvm.org/viewvc/llvm-project?rev=298366=rev Log: [OpenCL] Added implicit conversion rank for overloading functions with vector data type in OpenCL Summary: I added a new rank to ImplicitConversionRank enum to

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added a comment. In https://reviews.llvm.org/D30739#706292, @Hahnfeld wrote: > In principal looks good to me although I'm not really familiar with this > part. Does that work for you if you have the `declare simd` in a header file > and the implementation in another file? On x86_64

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D30739#706304, @fpetrogalli wrote: > AFAIK, none of the machinery required in LLVM to expose the mangled names in > the vectorizer is present in trunk. There

[PATCH] D30954: Modules: Simulate diagnostic settings for implicit modules

dexonsmith added a comment. Ping! https://reviews.llvm.org/D30954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r298410 - Correct class-template deprecation behavior

Ended up being simpler than I expected. I added -r298433 To fix this. The issue is that the test had a conditional based on the "C" version, so I explicitly added a test for C89 and C99, which the PS4 is apparently not defaulting to. Thanks! -Erich -Original Message- From: Yung,

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

leanil updated this revision to Diff 92542. leanil added a comment. Suppress warning only on std::enable_if. Make note on copy and move constructors. Repository: rL LLVM https://reviews.llvm.org/D30547 Files: clang-tidy/misc/CMakeLists.txt

Re: r298392 - [index/AST] Determine if a typedef shares a name and spelling location with its underlying tag type

Could you please take a look at these leaks http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/3606/steps/check-clang%20asan/logs/stdio = ==32547==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24

[PATCH] D31210: [AMDGPU] Add new address space mapping

kzhuravl added a comment. In https://reviews.llvm.org/D31210#706880, @rampitec wrote: > I'm concerned about the default address space to be 64 bit. It would move > alloca into generic address space effectively making private address to be 64 > bit. > This may have very undesirable performance

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib added a comment. In https://reviews.llvm.org/D31140#706411, @jroelofs wrote: > Can you clarify the logic here? It's my understanding that: > > `-fno-exceptions` does *not* imply `-fno-unwind-tables` > > however: > > `-fno-unwind-tables` *does* imply that exceptions cannot be used on

r298433 - iFix Test deprecation behavior in C89 mode as a result of r298410

Author: erichkeane Date: Tue Mar 21 15:14:46 2017 New Revision: 298433 URL: http://llvm.org/viewvc/llvm-project?rev=298433=rev Log: iFix Test deprecation behavior in C89 mode as a result of r298410 Modified: cfe/trunk/test/Sema/attr-deprecated.c Modified:

[PATCH] D31210: [AMDGPU] Add new address space mapping

rampitec added a comment. I'm concerned about the default address space to be 64 bit. It would move alloca into generic address space effectively making private address to be 64 bit. This may have very undesirable performance implications, like address arithmetic can become expensive 64 bit

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

vsk updated this revision to Diff 92572. vsk added a comment. Add a test which shows that we don't regress alignment-checking when accessing extern variables. https://reviews.llvm.org/D30283 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprCXX.cpp lib/CodeGen/CodeGenFunction.cpp

[PATCH] D30810: Preserve vec3 type.

jaykang10 added a comment. In https://reviews.llvm.org/D30810#706677, @Anastasia wrote: > In https://reviews.llvm.org/D30810#706676, @Anastasia wrote: > > > In https://reviews.llvm.org/D30810#699428, @Anastasia wrote: > > > > > Would you be able to update ScalarExprEmitter::VisitAsTypeExpr > >

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

efriedma added inline comments. Comment at: test/CodeGenCXX/ubsan-global-alignment.cpp:9 +extern S1 S1_array[]; +extern S1 *S1ptr_array[]; + Probably a good idea to also test extern globals which aren't arrays; arrays are sort of a special-case due to

[clang-tools-extra] r298470 - Reverting r298421 due to using a header that's unavailable to all systems and some other post-commit review feedback.

Author: aaronballman Date: Tue Mar 21 20:08:54 2017 New Revision: 298470 URL: http://llvm.org/viewvc/llvm-project?rev=298470=rev Log: Reverting r298421 due to using a header that's unavailable to all systems and some other post-commit review feedback. Modified:

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

On Tue, Mar 21, 2017 at 9:15 PM, Richard Smith wrote: > On 21 March 2017 at 12:01, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Tue Mar 21 14:01:17 2017 >> New Revision: 298421 >> >> URL:

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

On 21 March 2017 at 18:57, Breno Guimarães via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hey guys, > > I'm sorry the test did not make the decay explicit. It's indeed sort of > tricky: https://bugs.llvm.org/show_bug.cgi?id=32239 > > Basically, assert is expanded into: > >

r298464 - [Modules] Rebuild modules on umbrella header mismatch

Author: bruno Date: Tue Mar 21 19:11:21 2017 New Revision: 298464 URL: http://llvm.org/viewvc/llvm-project?rev=298464=rev Log: [Modules] Rebuild modules on umbrella header mismatch This restores behavior pre-r230064 since after PCMCache work (r298278) we don't reload PCMs from disk within the

[PATCH] D30760: Record command lines in objects built by clang

zhizhouy added a comment. Hi aprantl, thanks for replying. I checked the usage of DwarfDebugFlags, it seems that it really did the same work of recording command line options. And I noticed that it is set to false by default. Is it because of some concerns like the debug info size? Is it

Re: [PATCH] D30760: Record command lines in objects built by clang

I think that's a good idea. On Tue, Mar 21, 2017 at 5:19 PM Adrian Prantl via Phabricator < revi...@reviews.llvm.org> wrote: > aprantl added a comment. > > Sorry for being late to the party, but have you looked at > CodeGenOptions::DwarfDebugFlags? It looks like it almost does what you > want,

Buildbot numbers for the week of 03/12/2017 - 03/18/2017

Hello everyone, Below are some buildbot numbers for the last week of 03/12/2017 - 03/18/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

Buildbot numbers for the week of 03/05/2017 - 03/11/2017

Hello everyone, Below are some buildbot numbers for the week of 03/05/2017 - 03/11/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

ahatanak updated this revision to Diff 92583. ahatanak added a comment. Rebase and ping. https://reviews.llvm.org/D22391 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaChecking.cpp lib/Sema/SemaDecl.cpp

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

Thank you! On 21 March 2017 at 18:22, Aaron Ballman wrote: > On Tue, Mar 21, 2017 at 9:15 PM, Richard Smith > wrote: > > On 21 March 2017 at 12:01, Aaron Ballman via cfe-commits > > wrote: > >> > >> Author:

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

Hey guys, I'm sorry the test did not make the decay explicit. It's indeed sort of tricky: https://bugs.llvm.org/show_bug.cgi?id=32239 Basically, assert is expanded into: (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) Well, __func__ and __FILE__ are const char[],

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl updated this revision to Diff 92587. yaxunl added a comment. Fix getDWARFAddressSpace. https://reviews.llvm.org/D31210 Files: include/clang/Driver/Options.td lib/Basic/Targets.cpp test/CodeGenOpenCL/amdgpu-new-addr.cl Index: test/CodeGenOpenCL/amdgpu-new-addr.cl

[PATCH] D31069: Don't warn about an unreachable fallthrough annotation in a template function

This revision was automatically updated to reflect the committed changes. Closed by commit rL298477: Suppress warning on unreachable [[clang::fallthrough]] within a template… (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D31069?vs=92104=92588#toc Repository: rL

r298477 - Suppress warning on unreachable [[clang::fallthrough]] within a template instantiation.

Author: rsmith Date: Tue Mar 21 20:49:19 2017 New Revision: 298477 URL: http://llvm.org/viewvc/llvm-project?rev=298477=rev Log: Suppress warning on unreachable [[clang::fallthrough]] within a template instantiation. We don't know whether some other instantiation of the template might be able to

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

vsk added a comment. In https://reviews.llvm.org/D30283#707007, @efriedma wrote: > It's possible to misalign a global definition by misaligning its section with > a linker script... but we can probably ignore that possibility. The current implementation does ignore this case. > It's very

[PATCH] D30760: Record command lines in objects built by clang

aprantl added a comment. Sorry for being late to the party, but have you looked at CodeGenOptions::DwarfDebugFlags? It looks like it almost does what you want, but it is currently only enabled for MachO and when a specific environment variable is set. Would it make sense to generalize that

r298469 - Remove -ffp-contract=fast from this test

Author: anemet Date: Tue Mar 21 19:58:18 2017 New Revision: 298469 URL: http://llvm.org/viewvc/llvm-project?rev=298469=rev Log: Remove -ffp-contract=fast from this test It does not need it and causes mismatch after -ffp-contract=fast is turned into an FMF. Modified:

r298468 - Change -ffp-contract=fast test to run on Aarch64

Author: anemet Date: Tue Mar 21 19:58:15 2017 New Revision: 298468 URL: http://llvm.org/viewvc/llvm-project?rev=298468=rev Log: Change -ffp-contract=fast test to run on Aarch64 (I don't have powerpc enabled in my build and I am changing how -ffp-contract=fast works.) Modified:

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

On 21 March 2017 at 12:01, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Tue Mar 21 14:01:17 2017 > New Revision: 298421 > > URL: http://llvm.org/viewvc/llvm-project?rev=298421=rev > Log: > Prevent

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This change was reverted in r298470. The use of the include is a problem because this is not a clang-supplied header file. Also, there's a (good) question about what array

[PATCH] D30760: Record command lines in objects built by clang

aprantl added a comment. In https://reviews.llvm.org/D30760#707178, @zhizhouy wrote: > Hi aprantl, thanks for replying. I checked the usage of DwarfDebugFlags, it > seems that it really did the same work of recording command line options. > > And I noticed that it is set to false by default. Is

[PATCH] D30018: [XRay] Add __xray_customeevent(...) as a clang-supported builtin

dberris added a reviewer: rnk. dberris added a subscriber: rnk. dberris added a comment. @rnk -- if you have time, a review for this would be appreciated too. https://reviews.llvm.org/D30018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc added inline comments. Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:60 +// Set timeout to 15000ms = 15s +Z3_set_param_value(Config, "timeout", "15000"); + } xazax.hun wrote: > Sorry for being a bit late in the party, I was wondering

r298429 - Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase.

Author: dehao Date: Tue Mar 21 14:55:46 2017 New Revision: 298429 URL: http://llvm.org/viewvc/llvm-project?rev=298429=rev Log: Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase. Summary: Because SamplePGO passes will be invoked twice in ThinLTO build: once at

r298431 - Let llvm.objectsize be conservative with null pointers

Author: gbiv Date: Tue Mar 21 15:09:35 2017 New Revision: 298431 URL: http://llvm.org/viewvc/llvm-project?rev=298431=rev Log: Let llvm.objectsize be conservative with null pointers D28494 adds another parameter to @llvm.objectsize. Clang needs to be sure to pass that third arg whenever

[clang-tools-extra] r298434 - Don't make unqualified calls to functions that could well be found via

Author: chandlerc Date: Tue Mar 21 15:15:42 2017 New Revision: 298434 URL: http://llvm.org/viewvc/llvm-project?rev=298434=rev Log: Don't make unqualified calls to functions that could well be found via ADL as reasonable extension points. All of this would be cleaner if this code followed the

r298443 - Apply clang-tidy's performance-unnecessary-value-param to parts of clang.

Author: d0k Date: Tue Mar 21 16:35:04 2017 New Revision: 298443 URL: http://llvm.org/viewvc/llvm-project?rev=298443=rev Log: Apply clang-tidy's performance-unnecessary-value-param to parts of clang. No functionality change intended. Modified: cfe/trunk/include/clang/Driver/ToolChain.h

[PATCH] D31202: Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >