r298903 - [libclang] Fix crash in member access code completion with implicit base

Author: erikjv Date: Tue Mar 28 02:22:21 2017 New Revision: 298903 URL: http://llvm.org/viewvc/llvm-project?rev=298903&view=rev Log: [libclang] Fix crash in member access code completion with implicit base If there is an unresolved member access AST node, and the base is implicit, do not access/u

[PATCH] D30248: [libclang] Fix crash in member access code completion with implicit base

erikjv closed this revision. erikjv added a comment. Landed as r298903. https://reviews.llvm.org/D30248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31370: [clang-tidy] Prototype to check for exception specification

JonasToth planned changes to this revision. JonasToth marked 2 inline comments as done. JonasToth added a comment. commented review Comment at: clang-tidy/modernize/NoexceptCorrectnessCheck.cpp:60 + N.getNodeAs("direct_throwing_decl")) { +// FIXME how is that done?

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib added a comment. Yes we can enable cantunwind with the nothrow gcc attribute when exceptions are enabled Forcing it in exceptions are not enabled (e.g for attribute cleanup) would require -funwind-tables at function level anyway So the flag should work, but conceptually I think you are ri

[PATCH] D31370: [clang-tidy] Prototype to check for exception specification

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tidy/modernize/NoexceptCorrectnessCheck.cpp:60 + N.getNodeAs("direct_throwing_decl")) { +// FIXME how is that done? i did not find a noThrow predicate +//if (ThrowingDe

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

erikjv updated this revision to Diff 93221. erikjv added a comment. Added a test for the specific scenario, and added asserts for validity of UFEs returned by getVirtualFile. https://reviews.llvm.org/D27810 Files: lib/Basic/FileManager.cpp unittests/Basic/FileManagerTest.cpp Index: unitte

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

xiangzhai added a comment. Hi Raphael, Thanks for your reply! > regarding performance: Last time I checked we spend most of the time on the > verification of the hash values. We can do some tricks to make this faster > (like delaying the verification to the end of the constraints where we have

r298905 - FileManager: mark virtual file entries as valid entries

Author: erikjv Date: Tue Mar 28 04:18:05 2017 New Revision: 298905 URL: http://llvm.org/viewvc/llvm-project?rev=298905&view=rev Log: FileManager: mark virtual file entries as valid entries The getVirtualFile method would create entries for e.g. libclang's CXUnsavedFile but not mark them as valid.

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor marked an inline comment as done. teemperor added a comment. Well this patch won't change a lot with the false-positives or performance (it's more refactoring) :) https://reviews.llvm.org/D23418 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

bader added a comment. Anastasia, could you generate patch with full context, please? https://reviews.llvm.org/D31397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr created this revision. Herald added a subscriber: rengolin. Adds a new flag ('-fopenmp-simd') to clang which enables processing of 'simd' and 'declare simd' pragmas without supporting the rest of OpenMP. The pragma handler will filter out directives and clauses which aren't related to si

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

erikjv closed this revision. erikjv added a comment. Committed as r298905. https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

fpetrogalli added a comment. Hi Graham, thank you for working on this. I understand that you are gonna take care of the CodeGen side of things for the new `-fopenmp-simd` option in a separate patch? I am asking because I expect that the tests in `test/OpenMP/declare_simd_*` will give the same

[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

Anastasia updated this revision to Diff 93225. Anastasia added a comment. Updated with the full diff. https://reviews.llvm.org/D31397 Files: lib/Sema/SemaDecl.cpp test/SemaOpenCL/types.cl Index: test/SemaOpenCL/types.cl === -

[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:2157 if (getDiagnostics().getSuppressSystemWarnings() && - (Context.getSourceManager().isInSystemHeader(Old->getLocation()) || + // Some standard types are defined implicitly in Clang (e.g. OpenCL). +

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

aaron.ballman added a comment. I'm not certain of a good way to test it, but I have a question about the value you picked for `init_priority`. My understanding of the values starting from 101 is that 1-100 are reserved for implementation use. Is that understanding correct? If so, you may want t

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added a comment. In https://reviews.llvm.org/D31417#712008, @fpetrogalli wrote: > Hi Graham, > > thank you for working on this. I understand that you are gonna take care of > the CodeGen side of things for the new `-fopenmp-simd` option in a separate > patch? CodeGen for 'simd' pragm

[PATCH] D31370: [clang-tidy] Prototype to check for exception specification

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/NoexceptCorrectnessCheck.cpp:60 + N.getNodeAs("direct_throwing_decl")) { +// FIXME how is that done? i did not find a noThrow predicate +//if (ThrowingDecl->isNoThrow()) { Jona

[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:2157 if (getDiagnostics().getSuppressSystemWarnings() && - (Context.getSourceManager().isInSystemHeader(Old->getLocation()) || + // Some standard types are defined implicitly in Clang (e.g. OpenCL). +

[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

Anastasia updated this revision to Diff 93226. Anastasia added a comment. Removed check of implicit for new type. https://reviews.llvm.org/D31397 Files: lib/Sema/SemaDecl.cpp test/SemaOpenCL/types.cl Index: test/SemaOpenCL/types.cl =

[PATCH] D28671: [ASTMatchers] add typeAliasTemplateDecl matcher.

ioeric updated this revision to Diff 93227. ioeric added a comment. - generate html for the new matcher. https://reviews.llvm.org/D28671 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersNodeTest.cpp Index: unittests/ASTMat

[PATCH] D28671: [ASTMatchers] add typeAliasTemplateDecl matcher.

ioeric added a comment. PTAL https://reviews.llvm.org/D28671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

bader added inline comments. Comment at: lib/Sema/SemaDecl.cpp:2157 if (getDiagnostics().getSuppressSystemWarnings() && - (Context.getSourceManager().isInSystemHeader(Old->getLocation()) || + // Some standard types are defined implicitly in Clang (e.g. OpenCL). +

[PATCH] D28671: [ASTMatchers] add typeAliasTemplateDecl matcher.

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:191 +const internal::VariadicDynCastAllOfMatcher +typeAliasTemplateDecl; + Be sure to add this to Registry.cpp so that it c

[PATCH] D28671: [ASTMatchers] add typeAliasTemplateDecl matcher.

ioeric updated this revision to Diff 93228. ioeric marked an inline comment as done. ioeric added a comment. - Register the matcher to Dynamic. https://reviews.llvm.org/D28671 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry

[PATCH] D28671: [ASTMatchers] add typeAliasTemplateDecl matcher.

ioeric added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:191 +const internal::VariadicDynCastAllOfMatcher +typeAliasTemplateDecl; + aaron.ballman wrote: > Be sure to add this to Registry.cpp so that it can be used as a dynamic > matc

[PATCH] D28671: [ASTMatchers] add typeAliasTemplateDecl matcher.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D28671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

r298912 - [ASTMatchers] add typeAliasTemplateDecl matcher.

Author: ioeric Date: Tue Mar 28 07:56:47 2017 New Revision: 298912 URL: http://llvm.org/viewvc/llvm-project?rev=298912&view=rev Log: [ASTMatchers] add typeAliasTemplateDecl matcher. Reviewers: hokein, aaron.ballman Reviewed By: aaron.ballman Subscribers: aaron.ballman, cfe-commits, klimek Diff

[PATCH] D28671: [ASTMatchers] add typeAliasTemplateDecl matcher.

This revision was automatically updated to reflect the committed changes. Closed by commit rL298912: [ASTMatchers] add typeAliasTemplateDecl matcher. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D28671?vs=93228&id=93230#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D30777: Added `applyAtomicChanges` function.

ioeric updated this revision to Diff 93231. ioeric added a comment. - addressed comment. https://reviews.llvm.org/D30777 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling/Refactoring/AtomicChange.cpp unittests/Tooling/RefactoringTest.cpp Index: unittests/Tooling/Refacto

r298913 - Added `applyAtomicChanges` function.

Author: ioeric Date: Tue Mar 28 08:05:32 2017 New Revision: 298913 URL: http://llvm.org/viewvc/llvm-project?rev=298913&view=rev Log: Added `applyAtomicChanges` function. Summary: ... which applies a set of `AtomicChange`s on code. Reviewers: klimek, djasper Reviewed By: djasper Subscribers: cf

[PATCH] D30777: Added `applyAtomicChanges` function.

This revision was automatically updated to reflect the committed changes. Closed by commit rL298913: Added `applyAtomicChanges` function. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D30777?vs=93231&id=93232#toc Repository: rL LLVM https://reviews.llvm.org/D30777

[PATCH] D31370: [clang-tidy] Prototype to check for exception specification

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/modernize-noexcept-correctness.rst:41 + +- AnnotateThrow -> boolean if a function that can throw for sure will be annotated with `noexcept(false)` JonasToth wrote: > Eugene.Zelenko wrot

r298919 - Try to unbreak buildbots after r298913.

Author: ioeric Date: Tue Mar 28 08:56:19 2017 New Revision: 298919 URL: http://llvm.org/viewvc/llvm-project?rev=298919&view=rev Log: Try to unbreak buildbots after r298913. Modified: cfe/trunk/unittests/Tooling/RefactoringTest.cpp Modified: cfe/trunk/unittests/Tooling/RefactoringTest.cpp URL

[PATCH] D30777: Added `applyAtomicChanges` function.

chapuni added inline comments. Comment at: cfe/trunk/include/clang/Tooling/Refactoring/AtomicChange.h:19 #include "clang/Basic/SourceManager.h" +#include "clang/Format/Format.h" #include "clang/Tooling/Core/Replacement.h" It requires clangFormat in LINK_LIBS. F

r298921 - clangToolingRefactor: Add libdeps upon clangFormat in r298913.

Author: chapuni Date: Tue Mar 28 09:18:10 2017 New Revision: 298921 URL: http://llvm.org/viewvc/llvm-project?rev=298921&view=rev Log: clangToolingRefactor: Add libdeps upon clangFormat in r298913. Modified: cfe/trunk/lib/Tooling/Refactoring/CMakeLists.txt Modified: cfe/trunk/lib/Tooling/Refa

[PATCH] D29659: [OpenMP] Add flag for disabling the default generation of relocatable OpenMP target code for NVIDIA GPUs.

gtbercea updated this revision to Diff 93240. gtbercea added a comment. Herald added a subscriber: rengolin. Update patch to reflect latest source code changes. Repository: rL LLVM https://reviews.llvm.org/D29659 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp tes

Re: [PATCH] D30777: Added `applyAtomicChanges` function.

Thank you Nakamura! On Tue, Mar 28, 2017, 16:35 NAKAMURA Takumi via Phabricator < revi...@reviews.llvm.org> wrote: > chapuni added inline comments. > > > > Comment at: cfe/trunk/include/clang/Tooling/Refactoring/AtomicChange.h:19 > #include "clang/Basic/SourceManager.h" > +#incl

[PATCH] D31334: [clang-format] Add options for indenting preprocessor directives

curdeius added a comment. Thanks Daniel. I'll give it a try using the proposed approach and update you soon(ish). https://reviews.llvm.org/D31334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:2157 if (getDiagnostics().getSuppressSystemWarnings() && - (Context.getSourceManager().isInSystemHeader(Old->getLocation()) || + // Some standard types are defined implicitly in Clang (e.g. OpenCL). +

[PATCH] D31183: [OpenCL] Added parsing for OpenCL vector types.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D31183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D31321: [OpenCL] Do not generate "kernel_arg_type_qual" metadata for non-pointer args

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/kernel-arg-info.cl:66 // CHECK: ![[MD13]] = !{!"int*", !"int", !"int", !"float*"} -// CHECK: ![[MD14]] = !{!"restrict", !"const", !"volatile", !"restrict const"} // ARGINFO: ![[MD15]] = !{!"X", !"Y", !"anotherArg",

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

Anastasia added inline comments. Comment at: test/SemaOpenCL/atomic-init.cl:6 +kernel void test_atomic_initialization() { + a1 = 1; // expected-error {{atomic variable can only be assigned to a compile time constant and to variables in global adress space}} + atomic_int a2 = 0

[PATCH] D31375: Add docs for libunwind

jroelofs added a comment. In https://reviews.llvm.org/D31375#711839, @EricWF wrote: > In https://reviews.llvm.org/D31375#710897, @jroelofs wrote: > > > In https://reviews.llvm.org/D31375#710891, @compnerd wrote: > > > > > What happens when you try building it in tree? > > > > > > The docs-libunwi

[PATCH] D31375: Add docs for libunwind

jroelofs added a comment. In https://reviews.llvm.org/D31375#712152, @jroelofs wrote: > In https://reviews.llvm.org/D31375#711839, @EricWF wrote: > > > In https://reviews.llvm.org/D31375#710897, @jroelofs wrote: > > > > > In https://reviews.llvm.org/D31375#710891, @compnerd wrote: > > > > > > > W

[libunwind] r298922 - [libunwind] Add sphinx docs

Author: jroelofs Date: Tue Mar 28 10:21:43 2017 New Revision: 298922 URL: http://llvm.org/viewvc/llvm-project?rev=298922&view=rev Log: [libunwind] Add sphinx docs https://reviews.llvm.org/D31375 Added: libunwind/trunk/docs/ libunwind/trunk/docs/BuildingLibunwind.rst libunwind/trunk/d

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea updated this revision to Diff 93244. gtbercea added a comment. Herald added a subscriber: rengolin. Update patch to reflect latest source code changes. Repository: rL LLVM https://reviews.llvm.org/D29660 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp tes

[PATCH] D31375: Add docs for libunwind

jroelofs closed this revision. jroelofs added a comment. r298922 https://reviews.llvm.org/D31375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31397: [Bug 25404] Fix crash on typedef in OpenCL 2.0

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. I think my topics are not related to the bug 25404 and can be handled separately. Thanks! https://reviews.llvm.org/D31397 ___ cfe-commits mailing

[PATCH] D31422: Add builder for libunwind docs

jroelofs created this revision. Dimitri, do you mind hosting another docs builder on your machine? https://reviews.llvm.org/D31422 Files: buildbot/osuosl/master/config/builders.py zorg/buildbot/builders/SphinxDocsBuilder.py Index: zorg/buildbot/builders/SphinxDocsBuilder.py ==

[PATCH] D31375: Add docs for libunwind

jroelofs added a comment. Review for adding a builder in: https://reviews.llvm.org/D31422 https://reviews.llvm.org/D31375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r298924 - [analyzer] When creating a temporary object, properly copy the value into it.

Author: dergachev Date: Tue Mar 28 10:43:26 2017 New Revision: 298924 URL: http://llvm.org/viewvc/llvm-project?rev=298924&view=rev Log: [analyzer] When creating a temporary object, properly copy the value into it. Adjustments should be considered properly; we should copy the unadjusted object ove

[PATCH] D30534: [analyzer] When creating a temporary object copy, properly copy the value into it.

This revision was automatically updated to reflect the committed changes. Closed by commit rL298924: [analyzer] When creating a temporary object, properly copy the value into it. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D30534?vs=92618&id=93250#toc Repository:

r298927 - [analyzer] Fix symbolication for unknown unary increment/decrement results.

Author: dergachev Date: Tue Mar 28 10:57:12 2017 New Revision: 298927 URL: http://llvm.org/viewvc/llvm-project?rev=298927&view=rev Log: [analyzer] Fix symbolication for unknown unary increment/decrement results. If the value is known, but we cannot increment it, conjure a symbol to represent the

[PATCH] D31289: [analyzer] Fix symbolication for unknown unary increment/decrement results.

This revision was automatically updated to reflect the committed changes. Closed by commit rL298927: [analyzer] Fix symbolication for unknown unary increment/decrement results. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D31289?vs=92812&id=93251#toc Repository:

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

rsanchezsaez added a comment. I think this makes the warning to trigger on methods such as: - (instancetype)initWithValues:(const int32_t [])values - (void)updateWithRange:(NSRange)range floatArray:(CGFloat[])array; (experienced on the just released //Xcode 8.3//). Perhaps I'm misunderstand

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

jordan_rose added a comment. No, the *arrays themselves* need to be marked as nullable or non-nullable. Remember that in C array parameters are passed as pointers. The compiler should give you a fix-it that shows the correct syntax. Repository: rL LLVM https://reviews.llvm.org/D26108 ___

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

rsanchezsaez added a comment. Oh, I see. Thanks for the explanation. The fix-it syntax got me confused: - (instancetype)initWithValues:(const int32_t [__null_unspecified])values Repository: rL LLVM https://reviews.llvm.org/D26108 ___ cfe-comm

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

jordan_rose added a comment. Yep, that's the correct syntax. It's not wonderful, but it's already where the C standard lets you put `const`, so we're just following established practice. (Learn something new and awful about C every day!) Repository: rL LLVM https://reviews.llvm.org/D26108

[PATCH] D31428: [x86] fix AVX FP cmp intrinsic documentation (PR28110)

spatel created this revision. Herald added a subscriber: mcrosier. This copies the text used in the #define statements to the code comments. The conflicting text comes from AMD manuals, but those are wrong. Sadly, this part has not been updated even after some docs were updated for Zen: http://s

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

rsanchezsaez added a comment. Haha! That makes sense. (I miss GitHub's comment reactions on Phabricator, consider your comments 👍'ed.) Repository: rL LLVM https://reviews.llvm.org/D26108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D31363: [libc++] Remove cmake glob for source files

beanz added a comment. LLVM has a CMake module "LLVMProcessSources.cmake" which verifies that all source files are referenced in the CMakeLists file. Since it is part of the LLVM distributed modules, you can re-use it in libcxx. https://reviews.llvm.org/D31363 __

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor updated this revision to Diff 93270. teemperor added a comment. - Remove the `assert(ChildHash)` which is obviously wrong code that just rarely fails. https://reviews.llvm.org/D23418 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp lib/StaticAnalyz

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added a comment. In https://reviews.llvm.org/D27387#711866, @EricWF wrote: > This LGTM, but I have a question: Should we add these dylib definitions right > away so that it's easier to adopt the ABI change in future? This will allow > legacy dylibs to support this ABI change in future.

[PATCH] D31272: Do not pass an explicit reexported symbol list when building libc++ dylib if also defining new/delete

mehdi_amini added a comment. OK, I figured, it is because I have this revision locally on top of this one: https://reviews.llvm.org/D30765 ; and I can't submit the latter without the change here. https://reviews.llvm.org/D31272 ___ cfe-commits mai

[libcxx] r298937 - [libc++] Add a key function for bad_function_call

Author: smeenai Date: Tue Mar 28 14:33:31 2017 New Revision: 298937 URL: http://llvm.org/viewvc/llvm-project?rev=298937&view=rev Log: [libc++] Add a key function for bad_function_call Summary: bad_function_call is currently an empty class, so any object files using that class will end up with the

[PATCH] D27387: [libc++] Add a key function for bad_function_call

This revision was automatically updated to reflect the committed changes. Closed by commit rL298937: [libc++] Add a key function for bad_function_call (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D27387?vs=90524&id=93276#toc Repository: rL LLVM https://reviews.ll

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

ahmedasadi marked 3 inline comments as done. ahmedasadi added inline comments. Comment at: test/SemaCXX/warn-shadow.cpp:65 char *data; // expected-warning {{declaration shadows a static data member of 'A'}} +char *a1; // expected-warning {{declaration shadows a typedef

[PATCH] D31044: Update for alloca construction changes

arsenm updated this revision to Diff 93282. https://reviews.llvm.org/D31044 Files: lib/CodeGen/CGCall.cpp lib/CodeGen/CGExpr.cpp Index: lib/CodeGen/CGExpr.cpp === --- lib/CodeGen/CGExpr.cpp +++ lib/CodeGen/CGExpr.cpp @@ -71,7 +

[PATCH] D31044: Update for alloca construction changes

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D31044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

yaxunl added inline comments. Comment at: lib/AST/ASTContext.cpp:9547-9555 +unsigned ASTContext::getTargetAddressSpace(unsigned AS) const { + // For OpenCL, the address space qualifier is 0 in AST. + if (AS == 0 && LangOpts.OpenCL) +return getTargetInfo().getDataLayout().ge

[PATCH] D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests

mgorny updated this revision to Diff 93296. mgorny added a comment. Rebased. Ping. Now that we have lit tests for builtins, it would be really useful for us to be able to build them without having to enable sanitizers. https://reviews.llvm.org/D25157 Files: cmake/config-ix.cmake include/CM

[PATCH] D31440: PR32382: Adapt to LLVM changes in DIExpression.

aprantl created this revision. LLVM now interprets DIExpressions correctly and no longer determines the location description kind by looking at whether the first operator is a DW_OP_deref. The code that emitted debug info for block captures used to rely on this and used the presence of

[PATCH] D31441: [clang-format] fix crash in NamespaceEndCommentsFixer (PR32438)

mgehre created this revision. Herald added a subscriber: klimek. The new test case was crashing before. Now it passes as expected. https://reviews.llvm.org/D31441 Files: lib/Format/NamespaceEndCommentsFixer.cpp unittests/Format/NamespaceEndCommentsFixerTest.cpp Index: unittests/Format/Nam

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

t-tye added inline comments. Comment at: lib/AST/ASTContext.cpp:9547-9555 +unsigned ASTContext::getTargetAddressSpace(unsigned AS) const { + // For OpenCL, the address space qualifier is 0 in AST. + if (AS == 0 && LangOpts.OpenCL) +return getTargetInfo().getDataLayout().get

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor updated this revision to Diff 93302. teemperor added a comment. - `auto` to `const auto` to be more consistent with LLVM style. https://reviews.llvm.org/D23418 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp lib/StaticAnalyzer/Checkers/CloneChecker

[PATCH] D31363: [libc++] Remove cmake glob for source files

smeenai planned changes to this revision. smeenai added a comment. I like the idea of verifying that all source files have been included. Will amend this accordingly. Thanks for the cmake pointer @beanz! Comment at: lib/CMakeLists.txt:304 if (LIBCXX_ENABLE_EXPERIMENTAL_LIBRAR

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

yaxunl added inline comments. Comment at: lib/AST/ASTContext.cpp:9547-9555 +unsigned ASTContext::getTargetAddressSpace(unsigned AS) const { + // For OpenCL, the address space qualifier is 0 in AST. + if (AS == 0 && LangOpts.OpenCL) +return getTargetInfo().getDataLayout().ge

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

t-tye added inline comments. Comment at: lib/AST/ASTContext.cpp:9547-9555 +unsigned ASTContext::getTargetAddressSpace(unsigned AS) const { + // For OpenCL, the address space qualifier is 0 in AST. + if (AS == 0 && LangOpts.OpenCL) +return getTargetInfo().getDataLayout().get

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. I am very happy to see this converging! Thanks for the work and perseverance! LGTM. https://reviews.llvm.org/D23418 ___ cfe-commits

[PATCH] D31441: [clang-format] fix crash in NamespaceEndCommentsFixer (PR32438)

krasimir added a comment. Looks good! I just have two nits. Comment at: lib/Format/NamespaceEndCommentsFixer.cpp:139 +} if (NamespaceTok->isNot(tok::kw_namespace)) continue; I'd instead just add a guard check at old line 136: ``` if (!Namespace

[PATCH] D31308: [clang-tidy] new check readability-no-alternative-tokens

mgehre updated this revision to Diff 93309. mgehre added a comment. Improved diagnostic; updated documentation; added test for overloaded operator https://reviews.llvm.org/D31308 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/OperatorsRepresentationCheck.cpp clang-tid

[PATCH] D31308: [clang-tidy] new check readability-no-alternative-tokens

mgehre added inline comments. Comment at: clang-tidy/readability/OperatorsRepresentationCheck.cpp:34 + + if (const auto *B = Result.Nodes.getNodeAs("binary")) { +switch (B->getOpcode()) { aaron.ballman wrote: > alexfh wrote: > > aaron.ballman wrote: > > > I

r298956 - Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors:

Author: echristo Date: Tue Mar 28 18:03:19 2017 New Revision: 298956 URL: http://llvm.org/viewvc/llvm-project?rev=298956&view=rev Log: Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors: http://www.intel.co

Re: r298956 - Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors:

Hi Craig, Quentin, Jim, Just bringing this patch to your attention here. I haven't turned it off in the backend since some processors do support it and we want to allow the code generation, with this change we simply make the user use -mrtm to get the functionality for now. Question: Do we want t

Re: r298956 - Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors:

So if you use -march=hsw the backend will think rtm is enabled, but clang will block the intrinsics in the frontend? Not sure what you mean by split the haswell and broadwell cpu. ~Craig On Tue, Mar 28, 2017 at 4:18 PM, Eric Christopher wrote: > Hi Craig, Quentin, Jim, > > Just bringing this p

[PATCH] D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests

jroelofs added inline comments. Comment at: test/sanitizer_common/CMakeLists.txt:7 set(SUPPORTED_TOOLS) -if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID) +if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID AND + COMPILER_RT_HAS_ASAN) --

Re: r298956 - Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors:

On Tue, Mar 28, 2017 at 4:31 PM Craig Topper wrote: > So if you use -march=hsw the backend will think rtm is enabled, but clang > will block the intrinsics in the frontend? > Yeah. I've come to the conclusion that I think we should remove the feature from the backend too. Using the option/featur

[PATCH] D31022: Implement P0298R3: `std::byte`

mehdi_amini added inline comments. Comment at: test/std/language.support/support.types/byteops/xor.assign.pass.cpp:13 + +// XFAIL: c++98, c++03, c++11, c++14 + EricWF wrote: > Nit. These should be `// UNSUPPORTED`. `XFAIL` is for bugs we need to fix. I have mixe

[PATCH] D31276: Add #pragma clang fast_math

anemet updated this revision to Diff 93325. anemet retitled this revision from "Add #pragma clang fp" to "Add #pragma clang fast_math". anemet edited the summary of this revision. anemet added a comment. Rename pragma from #pragma clang fast_math contract_fast(on/off) -> #pragma clang fp contrac

[PATCH] D31276: Add #pragma clang fp

anemet added a comment. (Sorry about updating the title/description back and forth but arcanist is buggy) https://reviews.llvm.org/D31276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

r298965 - Revert "clangToolingRefactor: Add libdeps upon clangFormat in r298913."

Author: ributzka Date: Tue Mar 28 19:24:32 2017 New Revision: 298965 URL: http://llvm.org/viewvc/llvm-project?rev=298965&view=rev Log: Revert "clangToolingRefactor: Add libdeps upon clangFormat in r298913." Modified: cfe/trunk/lib/Tooling/Refactoring/CMakeLists.txt Modified: cfe/trunk/lib/To

r298966 - Revert "Try to unbreak buildbots after r298913."

Author: ributzka Date: Tue Mar 28 19:24:34 2017 New Revision: 298966 URL: http://llvm.org/viewvc/llvm-project?rev=298966&view=rev Log: Revert "Try to unbreak buildbots after r298913." Modified: cfe/trunk/unittests/Tooling/RefactoringTest.cpp Modified: cfe/trunk/unittests/Tooling/RefactoringT

r298967 - Revert "Added `applyAtomicChanges` function."

Author: ributzka Date: Tue Mar 28 19:24:36 2017 New Revision: 298967 URL: http://llvm.org/viewvc/llvm-project?rev=298967&view=rev Log: Revert "Added `applyAtomicChanges` function." This broke GreenDragon: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA_build/4776/ Reverting this

Re: r298913 - Added `applyAtomicChanges` function.

I reverted the commit in r298967. Please fix the cyclic dependency issue found here: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA_build/4776/ Cheers, Juergen On Tue, Mar 28, 2017 at 6:05 AM, Eric Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ioeric > Date

Re: r298956 - Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors:

SGTM Sent from my iPhone > On Mar 28, 2017, at 5:25 PM, Eric Christopher wrote: > > > >> On Tue, Mar 28, 2017 at 4:31 PM Craig Topper wrote: >> So if you use -march=hsw the backend will think rtm is enabled, but clang >> will block the intrinsics in the frontend? > > Yeah. I've come to th

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

xiangzhai added a comment. Hi Raphael, Congratulate the patch was accepted! > Well this patch won't change a lot with the false-positives or performance > (it's more refactoring) :) So may I Teach CloneDetection about Qt Meta-Object Compiler and filter other

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

yaxunl updated this revision to Diff 93329. yaxunl added a comment. Revised by Tony's comments. https://reviews.llvm.org/D31404 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/AddressSpaces.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/ASTCont

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:413 + + while (Param && !Param->is(tok::l_paren)) { +if (!Param->is(tok::identifier) && !Param->is(tok::comma)) djasper wrote: > enyquist wrote: > > djasper wrote: > > > I think you

  1   2   >