[PATCH] D31491: [XRay][clang] Fix the -fxray-instruction-threshold flag processing

dberris created this revision. The refactoring introduced a regression in the flag processing for -fxray-instruction-threshold which causes it to not get passed properly. This change should restore the previous behaviour. https://reviews.llvm.org/D31491 Files: lib/Driver/XRayArgs.cpp lib/Fr

[PATCH] D31492: Add `addReplacement` interface in AtomicChange.

hokein created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D31492 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling/Refactoring/AtomicChange.cpp Index: lib/Tooling/Refactoring/AtomicChange.cpp =

[PATCH] D31492: Add `addReplacement` interface in AtomicChange.

ioeric added a comment. Please see comment from a previous patch (https://reviews.llvm.org/D27054?id=79099#inline-234270). Generally, `AtomicChange` is a higher level of abstraction than `Replacement`, and we don't want users to deal with `Replacement` and the related errors. https://reviews.

[PATCH] D29221: clang-format-vsix: "format on save" feature

hans added a comment. In https://reviews.llvm.org/D29221#698679, @amaiorano wrote: > Hey guys, any feedback on this? About 1.5 weeks ago, @hans asked @klimek and > @djasper for their opinions on "clang-format" vs "ClangFormat". Thanks! Let's get this committed now and not worry about renaming

[PATCH] D31492: Add `addReplacement` interface in AtomicChange.

hokein updated this revision to Diff 93456. hokein added a comment. Get rid of Replacement, and implement "replace" interface with range. https://reviews.llvm.org/D31492 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling/Refactoring/AtomicChange.cpp Index: lib/Tooling/Ref

[PATCH] D31492: Add `replace` interface with range in AtomicChange.

alexshap added a comment. to avoid misunderstanding - are the tools like clang-rename, change-namespace and clang-reorder-fields supposed to use AtomicChange (via the methods insert, replace etc) ? (i am asking just to make sure i understand correctly the intentions behind AtomicChange interfac

[PATCH] D26830: [libcxx] Add string_view literals

AntonBikineev added a comment. In https://reviews.llvm.org/D26830#711870, @EricWF wrote: > @AntonBikineev when will you be able to make he requested changes? I would > like to land this ASAP. Eric, have you looked at commit 7d32d2f5a1f39d4cae9469645faa74b647698001? This functionality has alre

[PATCH] D31370: [clang-tidy] Prototype to check for exception specification

mboehme added inline comments. Comment at: docs/clang-tidy/checks/modernize-noexcept-correctness.rst:7 +This check will mark functions as noexcept if that is possible. +`noexcept` is a new keyword in C++ 11 to signal, that no exception will escape from +the function annotated w

[PATCH] D31492: Add `replace` interface with range in AtomicChange.

ioeric added a comment. In https://reviews.llvm.org/D31492#713908, @alexshap wrote: > to avoid misunderstanding - are the tools like clang-rename, change-namespace > and clang-reorder-fields supposed to use AtomicChange (via the methods > insert, replace etc) ? > (i am asking just to make sure

[PATCH] D29221: clang-format-vsix: "format on save" feature

amaiorano added a comment. In https://reviews.llvm.org/D29221#713902, @hans wrote: > In https://reviews.llvm.org/D29221#698679, @amaiorano wrote: > > > Hey guys, any feedback on this? About 1.5 weeks ago, @hans asked @klimek > > and @djasper for their opinions on "clang-format" vs "ClangFormat".

[PATCH] D31492: Add `replace` interface with range in AtomicChange.

hokein updated this revision to Diff 93467. hokein added a comment. Rebase to master. https://reviews.llvm.org/D31492 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling/Refactoring/AtomicChange.cpp Index: lib/Tooling/Refactoring/AtomicChange.cpp ==

[PATCH] D31492: Add `replace` interface with range in AtomicChange.

ioeric added a comment. Could you add a simple test? https://reviews.llvm.org/D31492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31176: [clang-rename] Support renaming qualified symbol

hokein updated this revision to Diff 93468. hokein marked 2 inline comments as done. hokein added a comment. Use AtomicChange. https://reviews.llvm.org/D31176 Files: clang-rename/CMakeLists.txt clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/USRFinder.cpp cl

[PATCH] D31176: [clang-rename] Support renaming qualified symbol

hokein updated this revision to Diff 93469. hokein marked an inline comment as done. hokein added a comment. update comments. https://reviews.llvm.org/D31176 Files: clang-rename/CMakeLists.txt clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/USRFinder.cpp cla

[PATCH] D31176: [clang-rename] Support renaming qualified symbol

hokein added inline comments. Comment at: clang-rename/USRLocFinder.cpp:359 + + // Returns a list of using declarations which are needed to update. + const std::vector &getUsingDecls() const { ioeric wrote: > hokein wrote: > > ioeric wrote: > > > I think these

[clang-tools-extra] r299068 - [clang-tidy] add aliases for hicpp module

Author: jbcoe Date: Thu Mar 30 06:57:54 2017 New Revision: 299068 URL: http://llvm.org/viewvc/llvm-project?rev=299068&view=rev Log: [clang-tidy] add aliases for hicpp module Summary: Add some hicpp checks that can be implmented as alises for existing clang-tidy checks: hicpp-explicit-conversions

[PATCH] D31176: [clang-rename] Support renaming qualified symbol

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg with a few nits. Comment at: clang-rename/RenamingAction.cpp:104 + USRList[I], NewNames[I], Context.getTranslationUnitDecl()); + for (const auto AtomicChange

[PATCH] D30009: Add support for '#pragma clang attribute'

arphaman added inline comments. Comment at: docs/LanguageExtensions.rst:2430 + +- ``function(is_method)``: Can be used to apply attributes to C++ methods, + including operators and constructors/destructors. aaron.ballman wrote: > Instead of `is_method`, I think

[clang-tools-extra] r299070 - [clang-tidy] fix for linker errors in hicpp checks

Author: jbcoe Date: Thu Mar 30 07:31:02 2017 New Revision: 299070 URL: http://llvm.org/viewvc/llvm-project?rev=299070&view=rev Log: [clang-tidy] fix for linker errors in hicpp checks Speculative fix for linker errors in r299068. Modified: clang-tools-extra/trunk/clang-tidy/hicpp/CMakeLists.t

[PATCH] D31492: Add `replace` interface with range in AtomicChange.

hokein updated this revision to Diff 93472. hokein added a comment. Add unittest. https://reviews.llvm.org/D31492 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling/Refactoring/AtomicChange.cpp unittests/Tooling/RefactoringTest.cpp Index: unittests/Tooling/RefactoringTes

[PATCH] D31492: Add `replace` interface with range in AtomicChange.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Looks good and thanks for the cleanup. https://reviews.llvm.org/D31492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[clang-tools-extra] r299071 - [clang-tidy] fix docs in hicpp checks

Author: jbcoe Date: Thu Mar 30 07:59:41 2017 New Revision: 299071 URL: http://llvm.org/viewvc/llvm-project?rev=299071&view=rev Log: [clang-tidy] fix docs in hicpp checks Fix for sphinx-doc warnings in r299068. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/hicpp-noexcept-move.rst

[PATCH] D31328: [clangd] Add code completion support

bkramer accepted this revision. bkramer added a comment. lg https://reviews.llvm.org/D31328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r299073 - Add `replace` interface with range in AtomicChange.

Author: hokein Date: Thu Mar 30 08:07:38 2017 New Revision: 299073 URL: http://llvm.org/viewvc/llvm-project?rev=299073&view=rev Log: Add `replace` interface with range in AtomicChange. Reviewers: ioeric Reviewed By: ioeric Subscribers: alexshap, klimek, cfe-commits Differential Revision: https

[PATCH] D31492: Add `replace` interface with range in AtomicChange.

This revision was automatically updated to reflect the committed changes. Closed by commit rL299073: Add `replace` interface with range in AtomicChange. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D31492?vs=93472&id=93473#toc Repository: rL LLVM https://reviews.l

[clang-tools-extra] r299074 - Spelling mistakes in comments. NFCI.

Author: rksimon Date: Thu Mar 30 08:10:33 2017 New Revision: 299074 URL: http://llvm.org/viewvc/llvm-project?rev=299074&view=rev Log: Spelling mistakes in comments. NFCI. Based on corrections mentioned in patch for clang for PR27635 Modified: clang-tools-extra/trunk/clang-rename/USRFinder.cp

[PATCH] D31176: [clang-rename] Support renaming qualified symbol

hokein updated this revision to Diff 93474. hokein marked 2 inline comments as done. hokein added a comment. Fix a few nits. https://reviews.llvm.org/D31176 Files: clang-rename/CMakeLists.txt clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/USRFinder.cpp clan

[PATCH] D31492: Add `replace` interface with range in AtomicChange.

hokein added a comment. > are the tools like clang-rename, change-namespace and clang-reorder-fields > supposed to use AtomicChange (via the methods insert, replace etc) ? Yeah. We are using AtomicChange in clang-rename refinement (https://reviews.llvm.org/D31176). Repository: rL LLVM http

r299078 - [Sema][ObjC] Avoid the "type of property does not match type of accessor"

Author: arphaman Date: Thu Mar 30 08:33:51 2017 New Revision: 299078 URL: http://llvm.org/viewvc/llvm-project?rev=299078&view=rev Log: [Sema][ObjC] Avoid the "type of property does not match type of accessor" warning for methods that resemble the setters of readonly properties rdar://30415679 Mo

r299079 - Move NumRegParameters Module Flag. NFCI.

Author: niravd Date: Thu Mar 30 08:41:44 2017 New Revision: 299079 URL: http://llvm.org/viewvc/llvm-project?rev=299079&view=rev Log: Move NumRegParameters Module Flag. NFCI. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp URL: http://llvm.

r299080 - [ARC][ObjC++] Use ObjC semantic rules for comparisons between a pointer and

Author: arphaman Date: Thu Mar 30 08:48:33 2017 New Revision: 299080 URL: http://llvm.org/viewvc/llvm-project?rev=299080&view=rev Log: [ARC][ObjC++] Use ObjC semantic rules for comparisons between a pointer and an ObjC object pointer When ARC is enabled in Objective-C++, comparisons between a poi

[PATCH] D31177: [ARC][ObjC++] Use ObjC semantic rules for comparisons between a pointer and objective-c object pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL299080: [ARC][ObjC++] Use ObjC semantic rules for comparisons between a pointer and (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D31177?vs=92783&id=93475#toc Repository:

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

delcypher added a comment. I'm a little late to the review but hopefully I'll have useful comments. Nice work @ddc > I looked around for a generic smt-lib interface earlier, but couldn't find > much available, and since I wanted floating-point arithmetic support, I ended > up just directly usi

Re: r299079 - Move NumRegParameters Module Flag. NFCI.

Thanks! If you like, might make sense now to move all these addModuleFlag() into a new helper function, addModuleFlags(). ‫בתאריך יום ה׳, 30 במרץ 2017 ב-16:54 מאת ‪Nirav Dave via cfe-commits‬‏ <‪ cfe-commits@lists.llvm.org‬‏>:‬ > Author: niravd > Date: Thu Mar 30 08:41:44 2017 > New Revision: 29

r299083 - Spelling mistakes in comments. NFCI. (PR27635)

Author: rksimon Date: Thu Mar 30 09:13:19 2017 New Revision: 299083 URL: http://llvm.org/viewvc/llvm-project?rev=299083&view=rev Log: Spelling mistakes in comments. NFCI. (PR27635) Modified: cfe/trunk/include/clang/AST/ASTContext.h cfe/trunk/include/clang/AST/Decl.h cfe/trunk/include/

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: include/clang/AST/ASTContext.h:2319 return AddrSpaceMapMangling || - AS < LangAS::Offset || - AS >= LangAS::Offset + LangAS::Count; + AS > LangAS::target_first;

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

GorNishanov added inline comments. Comment at: lib/Sema/CoroutineBuilder.h:53 +assert(this->IsValid && "coroutine already invalid"); +this->IsValid = makeReturnObject() && makeParamMoves(); +if (this->IsValid && !IsPromiseDependentType) makeReturnObje

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

delcypher added a comment. In https://reviews.llvm.org/D28952#655337, @dcoughlin wrote: > In https://reviews.llvm.org/D28952#655278, @ddcc wrote: > > > > - That said, I think there are still significant optimization > > > opportunities. It looks like when performing a query you create a new > >

Re: r299058 - [APInt] Remove references to integerPartWidth and integerPart outside of APFloat implentation.

On Thu, Mar 30, 2017 at 7:48 AM, Craig Topper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ctopper > Date: Thu Mar 30 00:48:58 2017 > New Revision: 299058 > > URL: http://llvm.org/viewvc/llvm-project?rev=299058&view=rev > Log: > [APInt] Remove references to integerPartWidth and i

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

delcypher added inline comments. Comment at: CMakeLists.txt:188 +find_package(Z3 4.5) + @ddcc It is of course up to you but I recently [[ added support for using `libz3` directly | added support for using `libz3` directly ]] from CMake. via it's own CMake con

[PATCH] D31496: Make -defsym a driver option

salari01 created this revision. Extended the integrated assembler -Wa,-defsym option to be usable with the Clang driver. Both options arehandled in the same way. Using -defsym when not assembling files shows an unused argument warning. https://reviews.llvm.org/D31496 Files: include/clan

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: include/clang/AST/Type.h:336-342 + /// Get the address space value used in diagnostics. + unsigned getAddressSpacePrintValue() const { +unsigned AS = getAddressSpace(); +if (AS >= LangAS:

[PATCH] D31496: Make -defsym a driver option

rogfer01 added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1882 +TakeNextArg = true; } } else { I wonder if you should `break;` here if validation fails like the original code did? https://reviews.llvm.org/D31496

[PATCH] D31496: Make -defsym a driver option

salari01 added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1882 +TakeNextArg = true; } } else { rogfer01 wrote: > I wonder if you should `break;` here if validation fails like the original > code did? The reason for

[PATCH] D31496: Make -defsym a driver option

rogfer01 added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1882 +TakeNextArg = true; } } else { salari01 wrote: > rogfer01 wrote: > > I wonder if you should `break;` here if validation fails like the original > > co

[PATCH] D19979: [analyzer] ScopeContext - initial implementation

xazax.hun added a comment. What is the status of this? Aleksei, could you upload a new patch with the context available? (And also with a testcase added for jumps/gotos and VLA.) You modified the malloc checker but I did not see a test for that. https://reviews.llvm.org/D19979 __

[PATCH] D31168: Set FMF for -ffp-contract=fast

anemet updated this revision to Diff 93487. anemet added a comment. Also add 'contract' for CompoundAssignOperator (+= and -=). For l-values, these don't go through the expr-visitor in ScalarExprEmitter::Visit. This again piggybacks on how debug-locations are added. https://reviews.llvm.org/D3

[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Thank you for finding out the root cause here! Comment at: clang-tidy/ClangTidy.cpp:241 -const FileEntry *File = SourceMgr.getFileManager().getFile(FilePath);

[PATCH] D29599: Clang Changes for alloc_align

erichkeane updated this revision to Diff 93491. erichkeane marked 3 inline comments as done. erichkeane added a comment. Thanks for the feedback John! https://reviews.llvm.org/D29599 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Sema/Sema.h lib/CodeGen

[PATCH] D31501: [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine

sanwou01 created this revision. Herald added a subscriber: aemerson. Add initial support for printing assembly diagnostics using the DiagnosticsEngine infrastructure. Add support for -w (no warnings) and -Werror (warnings are errors) and print a summary with the number of errors and warnings. -fc

[PATCH] D31308: [clang-tidy] new check readability-no-alternative-tokens

alexfh added inline comments. Comment at: clang-tidy/readability/OperatorsRepresentationCheck.cpp:34 + + if (const auto *B = Result.Nodes.getNodeAs("binary")) { +switch (B->getOpcode()) { aaron.ballman wrote: > mgehre wrote: > > aaron.ballman wrote: > > > al

[libcxxabi] r299087 - [libc++abi] Remove unistd.h include

Author: smeenai Date: Thu Mar 30 11:27:09 2017 New Revision: 299087 URL: http://llvm.org/viewvc/llvm-project?rev=299087&view=rev Log: [libc++abi] Remove unistd.h include This was originally there for the _POSIX_THREADS define, to detect the presence of pthreads. That went away with the externaliz

[PATCH] D31502: [libc++abi] Delete config.h

smeenai created this revision. It's now completely empty, so we can remove it entirely. https://reviews.llvm.org/D31502 Files: src/config.h src/cxa_default_handlers.cpp src/cxa_exception.cpp src/cxa_exception_storage.cpp src/cxa_guard.cpp src/cxa_handlers.cpp src/cxa_personality.c

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

delcypher added inline comments. Comment at: CMakeLists.txt:188 +find_package(Z3 4.5) + delcypher wrote: > @ddcc It is of course up to you but I recently [[ added support for using > `libz3` directly | added support for using `libz3` directly ]] from CMake. >

[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

chh updated this revision to Diff 93499. chh marked an inline comment as done. chh added a comment. Use getOrCreateFileID. https://reviews.llvm.org/D31406 Files: clang-tidy/ClangTidy.cpp Index: clang-tidy/ClangTidy.cpp === ---

[PATCH] D30837: [libcxx] Support for shared_ptr

erik.pilkington updated this revision to Diff 93488. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. In this new patch, use an explicit specialization of std::allocator that specifically only performs a rebind. This needs to be a specialization of std::allocato

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

Anastasia added a comment. I can't see clearly why the alloca has to be extended to accommodate the address space too? Couldn't the address space for alloca just be taken directly from the data layout? In fact is seems from the LLVM review, an address space for alloca doesn't go into the bitc

[PATCH] D31321: [OpenCL] Do not generate "kernel_arg_type_qual" metadata for non-pointer args

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Comment at: test/CodeGenOpenCL/kernel-arg-info.cl:66 // CHECK: ![[MD13]] = !{!"int*", !"int", !"int", !"float*"} -// CHECK: ![[MD14]] = !{!"restrict", !"const",

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

Anastasia added inline comments. Comment at: test/SemaOpenCL/atomic-init.cl:6 +kernel void test_atomic_initialization() { + a1 = 1; // expected-error {{atomic variable can only be assigned to a compile time constant and to variables in global adress space}} + atomic_int a2 = 0

[PATCH] D16682: 19957 - OpenCL incorrectly accepts implicit address space conversion with ternary operator

arsenm added a comment. Is this still necessary? The bug is marked fixed https://reviews.llvm.org/D16682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29642: [OpenMP] Make OpenMP generated code for the NVIDIA device relocatable by default

gtbercea updated this revision to Diff 93501. gtbercea added a comment. Remove redundant check. Repository: rL LLVM https://reviews.llvm.org/D29642 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c ===

[PATCH] D29644: [OpenMP] Pass -v to PTXAS if it was passed to the driver.

gtbercea updated this revision to Diff 93502. gtbercea added a comment. Remove redundant check. Repository: rL LLVM https://reviews.llvm.org/D29644 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c ===

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor updated this revision to Diff 93503. teemperor added a comment. - Remove the mysterious unicode-character at the start of CloneDetection.cpp - Fixed formatting of the comment in CloneDetectionTest.cpp - Fixed comment in StmtSequence::contains that was still talking about checking for tr

[PATCH] D31441: [clang-format] fix crash in NamespaceEndCommentsFixer (PR32438)

mgehre updated this revision to Diff 93507. mgehre added a comment. Updated for comments https://reviews.llvm.org/D31441 Files: lib/Format/NamespaceEndCommentsFixer.cpp unittests/Format/NamespaceEndCommentsFixerTest.cpp Index: unittests/Format/NamespaceEndCommentsFixerTest.cpp ===

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

EricWF updated this revision to Diff 93508. EricWF added a comment. - Fix insane definition of `hasDependentPromiseType()` https://reviews.llvm.org/D31487 Files: include/clang/AST/StmtCXX.h lib/AST/StmtCXX.cpp lib/Sema/CoroutineBuilder.h lib/Sema/SemaCoroutine.cpp lib/Sema/TreeTransfo

[PATCH] D31502: [libc++abi] Delete config.h

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Thanks. I'm surprised this wasn't done earlier. https://reviews.llvm.org/D31502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

r299094 - Correcting a typo; NFC.

Author: aaronballman Date: Thu Mar 30 13:11:20 2017 New Revision: 299094 URL: http://llvm.org/viewvc/llvm-project?rev=299094&view=rev Log: Correcting a typo; NFC. Modified: cfe/trunk/test/Analysis/simple-stream-checks.c Modified: cfe/trunk/test/Analysis/simple-stream-checks.c URL: http://ll

[PATCH] D31491: [XRay][clang] Fix the -fxray-instruction-threshold flag processing

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: test/CodeGen/xray-instruction-threshold.cpp:11 + +// CHECK-DAG: define i32 @_Z3foov() #[[THRESHOLD:[0-9]+]] { +// CHECK-DAG: define i32 @_Z3barv() #[[NEVERATTR:[0-

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

mgehre updated this revision to Diff 93511. mgehre added a comment. Put 'u' and 'l' on integer literals https://reviews.llvm.org/D24892 Files: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h docs/ReleaseNotes.rst docs/clang-t

[PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

mgehre marked an inline comment as done. mgehre added a comment. Friendly ping https://reviews.llvm.org/D15031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31167: Use FPContractModeKind universally

rnk added inline comments. Comment at: cfe/trunk/include/clang/Basic/LangOptions.h:217 /// Adjust BinaryOperator::FPFeatures to match the bit-field size of this. - unsigned fp_contract : 1; + LangOptions::FPContractModeKind fp_contract : 2; }; anemet wrote:

Re: r298913 - Added `applyAtomicChanges` function.

[+ Adrian] Adrian knows more about the bot setup. On Wed, Mar 29, 2017 at 8:04 AM, Eric Liu wrote: > Hi Juergen, thanks for taking care of this, but I'm wondering if this > build bot is using a different set of build rules? The error message says > "Clang_Tooling > -> Clang_Format -> Clang_Too

[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

gtbercea updated this revision to Diff 93513. gtbercea added a comment. Herald added a subscriber: rengolin. Clean-up test. Repository: rL LLVM https://reviews.llvm.org/D29904 Files: lib/Frontend/CompilerInvocation.cpp test/OpenMP/target_parallel_no_exceptions.cpp Index: test/OpenMP/ta

Re: r298913 - Added `applyAtomicChanges` function.

Note that the green dragon bot doesn't use local submodule visibility, so every #include pulls in the entire clang module that header belongs to. Does this explain what you are seeing? (You should be able to reproduce with cmake -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=0) -- adrian > On Mar 30

[PATCH] D31308: [clang-tidy] new check readability-no-alternative-tokens

mgehre updated this revision to Diff 93519. mgehre added a comment. only check C++ code; only match operators that can have alternative representations https://reviews.llvm.org/D31308 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/OperatorsRepresentationCheck.cpp cla

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

EricWF updated this revision to Diff 93510. EricWF added a comment. - Remove incorrect comments. https://reviews.llvm.org/D31487 Files: include/clang/AST/StmtCXX.h lib/AST/StmtCXX.cpp lib/Sema/CoroutineBuilder.h lib/Sema/SemaCoroutine.cpp lib/Sema/TreeTransform.h test/SemaCXX/corout

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

EricWF added inline comments. Comment at: lib/Sema/CoroutineBuilder.h:53 +assert(this->IsValid && "coroutine already invalid"); +this->IsValid = makeReturnObject() && makeParamMoves(); +if (this->IsValid && !IsPromiseDependentType) GorNishanov wrote:

[PATCH] D29599: Clang Changes for alloc_align

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:4363 +} else if (AllocAlignParam && TargetDecl->hasAttr()) + EmitAlignmentAssumption(Ret.getScalarVal(), AllocAlignParam); } rjmccall wrote: > Your old code was fine, you just needed t

[libcxx] r299100 - Implement LWG 2842 - optional(U&&) needs to SFINAE on decay_t

Author: ericwf Date: Thu Mar 30 14:43:50 2017 New Revision: 299100 URL: http://llvm.org/viewvc/llvm-project?rev=299100&view=rev Log: Implement LWG 2842 - optional(U&&) needs to SFINAE on decay_t Modified: libcxx/trunk/include/optional libcxx/trunk/test/std/utilities/optional/optional.obj

[libcxx] r299105 - Fix LWG 2934 - optional doesn't compare with T

Author: ericwf Date: Thu Mar 30 15:06:52 2017 New Revision: 299105 URL: http://llvm.org/viewvc/llvm-project?rev=299105&view=rev Log: Fix LWG 2934 - optional doesn't compare with T Modified: libcxx/trunk/include/optional libcxx/trunk/test/std/utilities/optional/optional.comp_with_t/equal.p

Re: [PATCH] Use the correct ObjC++ personality

> Testcase? Shouldn't be necessary for such a simple and extremely obvious one-liner. -- Jonathan ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31101: [ThinLTO] Use clang's existing code gen handling for ThinLTO backends

tejohnson added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:1007 else AsmHelper.EmitAssembly(Action, std::move(OS)); tejohnson wrote: > I just noticed that EmitAssembly does a lot more than just emission - it is > also setting up an optimi

[PATCH] D31101: [ThinLTO] Use clang's existing code gen handling for ThinLTO backends

tejohnson updated this revision to Diff 93535. tejohnson added a comment. Use LTO to emit LLVM IR https://reviews.llvm.org/D31101 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/thinlto-emit-llvm.c Index: test/CodeGen/thinlto-emit-llvm.c ===

[PATCH] D31508: [ThinLTO] Set up lto::Config properly for codegen in ThinLTO backends

tejohnson created this revision. Herald added a subscriber: Prazek. This involved refactoring out pieces of EmitAssemblyHelper::CreateTargetMachine for use in runThinLTOBackend. Subsumes https://reviews.llvm.org/D31114. https://reviews.llvm.org/D31508 Files: lib/CodeGen/BackendUtil.cpp tes

[PATCH] D31114: Refactor `initTargetOptions` out of `EmitAssemblyHelper::CreateTargetMachine` and use it to initialize TargetOptions for ThinLTO Backends

tejohnson added a comment. As discussed with Mehdi offline, I am taking this one over. I just mailed https://reviews.llvm.org/D31508 which supersedes this one. https://reviews.llvm.org/D31114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29599: Clang Changes for alloc_align

erichkeane updated this revision to Diff 93537. erichkeane added a comment. Added tests as requested by John. https://reviews.llvm.org/D29599 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Sema/Sema.h lib/CodeGen/CGCall.cpp lib/CodeGen/CodeGenFunction

[PATCH] D29599: Clang Changes for alloc_align

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks. With that, LGTM. https://reviews.llvm.org/D29599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D29599: Clang Changes for alloc_align

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Can you drop the svn props on the new files when you commit? I don't think we usually set them, and I've seen commits specifically removing the eol-style props before. https://reviews.llvm.org/D29599 ___

[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Do you have commit rights? https://reviews.llvm.org/D31406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

r299117 - Clang changes for alloc_align attribute

Author: erichkeane Date: Thu Mar 30 16:48:55 2017 New Revision: 299117 URL: http://llvm.org/viewvc/llvm-project?rev=299117&view=rev Log: Clang changes for alloc_align attribute GCC has the alloc_align attribute, which is similar to assume_aligned, except the attribute's parameter is the index o

[PATCH] D29599: Clang Changes for alloc_align

erichkeane added a comment. Thanks guys. I THINK I properly removed the svn properties properly, though, I actually didn't know they existed until just now! Repository: rL LLVM https://reviews.llvm.org/D29599 ___ cfe-commits mailing list cfe-co

[PATCH] D29599: Clang Changes for alloc_align

This revision was automatically updated to reflect the committed changes. Closed by commit rL299117: Clang changes for alloc_align attribute (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D29599?vs=93537&id=93549#toc Repository: rL LLVM https://reviews.llvm.org

[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

EricWF created this revision. LWG 2911 adds `std::is_aggregate` to the library, which requires a new builtin trait. This patch implements `__is_aggregate`. Additionally this patch implements LWG 2015

[clang-tools-extra] r299119 - [clang-tidy] Reuse FileID in getLocation

Author: chh Date: Thu Mar 30 17:09:17 2017 New Revision: 299119 URL: http://llvm.org/viewvc/llvm-project?rev=299119&view=rev Log: [clang-tidy] Reuse FileID in getLocation One FileID per warning will increase and overflow NextLocalOffset when input file is large with many warnings. Reusing FileID

[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

This revision was automatically updated to reflect the committed changes. Closed by commit rL299119: [clang-tidy] Reuse FileID in getLocation (authored by chh). Changed prior to commit: https://reviews.llvm.org/D31406?vs=93499&id=93554#toc Repository: rL LLVM https://reviews.llvm.org/D31406

[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

EricWF updated this revision to Diff 93555. EricWF added a comment. - Move test to correct file. https://reviews.llvm.org/D31513 Files: include/clang/Basic/TokenKinds.def include/clang/Basic/TypeTraits.h lib/Parse/ParseDeclCXX.cpp lib/Parse/ParseExpr.cpp lib/Sema/SemaExprCXX.cpp tes

[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

gtbercea added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2167-2172 +// Set the flag to prevent the implementation from emitting device exception +// handling code for those requiring so. +if (Opts.OpenMPIsDevice && T.isNVPTX()) { + Opts.Ex

[PATCH] D29642: [OpenMP] Make OpenMP generated code for the NVIDIA device relocatable by default

gtbercea updated this revision to Diff 93557. gtbercea added a comment. Change prefix name in test. Repository: rL LLVM https://reviews.llvm.org/D29642 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c ===

[PATCH] D31515: [libc++] Implement LWG 2911 - add an is_aggregate type-trait

EricWF created this revision. This patch implements http://cplusplus.github.io/LWG/lwg-defects.html#2911. I'm putting this up for review until __is_aggregate is added to clang (See https://reviews.llvm.org/D31513) https://reviews.llvm.org/D31515 Files: include/__config include/type_traits

  1   2   >