[PATCH] D26830: [libcxx] Add string_view literals

EricWF added a comment. @AntonBikineev Yeah, this should be abandoned. Sorry my mistake. https://reviews.llvm.org/D26830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31725: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM minus doc. https://reviews.llvm.org/D31725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31725: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

EricWF added a comment. Please add docs to http://libcxx.llvm.org/docs/UsingLibcxx.html#libc-configuration-macros https://reviews.llvm.org/D31725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24371: Add diagnostics to require_constant_initialization

EricWF added a comment. @rsmith gentle ping. Repository: rL LLVM https://reviews.llvm.org/D24371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26830: [libcxx] Add string_view literals

EricWF added inline comments. Comment at: test/std/strings/string.view/string.view.literals/literal2.pass.cpp:16 + +int main() +{ EricWF wrote: > What's the point of this test that `literal.pass.cpp` doesn't cover? Ping on this comment.

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM minus inline comments. Comment at: libcxx/include/math.h:354 inline _LIBCPP_INLINE_VISIBILITY -typename std::enable_if::value, bool>::type

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

joerg added a comment. In https://reviews.llvm.org/D31992#725963, @klimek wrote: > If I understand correctly, that's " and \ for JSON and ", \ and all > non-printable characters (which unfortunately requires understanding of > unicode to solve this fully correctly) in YAML. I'd modify that

[libcxx] r300246 - [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

Author: smeenai Date: Thu Apr 13 15:13:32 2017 New Revision: 300246 URL: http://llvm.org/viewvc/llvm-project?rev=300246=rev Log: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option When the libc++ extern template macros were added, the intent was for it to be possible for consumers of the

[PATCH] D31725: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

smeenai updated this revision to Diff 95189. smeenai added a comment. Add documentation https://reviews.llvm.org/D31725 Files: docs/UsingLibcxx.rst include/__config Index: include/__config === --- include/__config +++

[PATCH] D31725: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

This revision was automatically updated to reflect the committed changes. Closed by commit rL300246: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D31725?vs=95189=95190#toc Repository: rL LLVM

[PATCH] D32035: [OpenMP] Error when trying to offload to an unsupported architecture

gtbercea created this revision. Herald added a subscriber: rengolin. Throw an error when offloading is unsupported for a particular target architecture. Repository: rL LLVM https://reviews.llvm.org/D32035 Files: include/clang/Basic/DiagnosticDriverKinds.td

r300231 - Follow-up to r300225: update ClangFormat.csproj too

Author: hans Date: Thu Apr 13 13:15:00 2017 New Revision: 300231 URL: http://llvm.org/viewvc/llvm-project?rev=300231=rev Log: Follow-up to r300225: update ClangFormat.csproj too Modified: cfe/trunk/tools/clang-format-vs/ClangFormat/ClangFormat.csproj Modified:

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300226 - Follow-up to r300225: update ClangFormat.sln to VS2017

Author: hans Date: Thu Apr 13 12:47:47 2017 New Revision: 300226 URL: http://llvm.org/viewvc/llvm-project?rev=300226=rev Log: Follow-up to r300225: update ClangFormat.sln to VS2017 This got lost in the previous patch somehow. Modified: cfe/trunk/tools/clang-format-vs/ClangFormat.sln

[PATCH] D25383: [libcxx][modules] Add a submodule for math.h

bruno abandoned this revision. bruno added a comment. This isn't needed anymore. https://reviews.llvm.org/D25383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r300232 - Remove the binders from C++17. Reviewed as https://reviews.llvm.org/D31769

Author: marshall Date: Thu Apr 13 13:25:32 2017 New Revision: 300232 URL: http://llvm.org/viewvc/llvm-project?rev=300232=rev Log: Remove the binders from C++17. Reviewed as https://reviews.llvm.org/D31769 Added: libcxx/trunk/test/libcxx/depr/depr.function.objects/

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

erichkeane abandoned this revision. erichkeane added a comment. I don't really see a good solution for this, and haven't tried in a while, so I'll see if I can prep another version of this in the future. https://reviews.llvm.org/D29401 ___

[PATCH] D32047: [Driver] Add support for default UBSan blacklists

vsk created this revision. Clang should look for a default UBSan blacklist in its resource dir. Depends on https://reviews.llvm.org/D32043. https://reviews.llvm.org/D32047 Files: lib/Driver/SanitizerArgs.cpp test/Driver/Inputs/resource_dir/ubsan_blacklist.txt

r300223 - clang-format-vs: Use a separate license.txt copy

Author: hans Date: Thu Apr 13 12:37:17 2017 New Revision: 300223 URL: http://llvm.org/viewvc/llvm-project?rev=300223=rev Log: clang-format-vs: Use a separate license.txt copy The regular file used to display very poorly in the VSIX installer due to long lines, wrapping etc. Added:

[PATCH] D27546: [ASTReader] Sort RawComments before merging

rsmith added inline comments. Comment at: lib/Serialization/ASTReader.cpp:8487 +std::sort(Comments.begin(), Comments.end(), + BeforeThanCompare(SourceMgr)); Context.Comments.addDeserializedComments(Comments); Does this cause us to

[PATCH] D27263: Address of bitfield in anonymous struct doesn't error.

jacobly added a comment. Ping. https://reviews.llvm.org/D27263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea updated this revision to Diff 95175. gtbercea added a comment. Use the rename() utility function of LLVM for renaming the PTXAS output before invoking NVLINK. Repository: rL LLVM https://reviews.llvm.org/D29654 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein added a comment. Thanks for the comments. Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:81 + hasLoopInit(LoopVarInit), + hasCondition(binaryOperator(hasOperatorName("<"), +

[PATCH] D27546: [ASTReader] Sort RawComments before merging

bruno closed this revision. bruno added a comment. Done in r290134 https://reviews.llvm.org/D27546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300245 - clang-format-vs licence.txt: drop svn:executable

Author: hans Date: Thu Apr 13 15:09:18 2017 New Revision: 300245 URL: http://llvm.org/viewvc/llvm-project?rev=300245=rev Log: clang-format-vs licence.txt: drop svn:executable Not sure how it ended up with that property in the first place. Modified:

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

aaron.ballman added inline comments. Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:95-96 +const MatchFinder::MatchResult ) { + if (Result.Context->getDiagnostics().hasUncompilableErrorOccurred()) +return; + hokein wrote: >

[PATCH] D30837: [libcxx] Support for shared_ptr<T()>

erik.pilkington added inline comments. Comment at: include/memory:3606 +template <> +class _LIBCPP_TEMPLATE_VIS allocator<__shared_ptr_dummy_rebind_allocator_type> +{ EricWF wrote: > I would prefer using an entirely different allocator type, not a >

r300257 - [CMake] Support building Fuchsia toolchain on Darwin

Author: phosek Date: Thu Apr 13 16:09:42 2017 New Revision: 300257 URL: http://llvm.org/viewvc/llvm-project?rev=300257=rev Log: [CMake] Support building Fuchsia toolchain on Darwin This is already supported on Linux but on Darwin it requires some extra flags. Differential Revision:

[PATCH] D31769: Remove the binders `bind1st`, `bind2nd`, `men_fun`, etc from C++17

mclow.lists closed this revision. mclow.lists added a comment. committed as revision 300232 https://reviews.llvm.org/D31769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r300122 - [clang-cl] Make all sanitizer flags available in clang-cl

> On Apr 13, 2017, at 9:50 AM, Reid Kleckner wrote: > > Fixed in r300209. Was the -Wslash-u-filename warning not explanatory enough > to suggest the solution? Maybe we could add a note like "escape source paths > starting with /U by passing them at the end of the command line

[PATCH] D30837: [libcxx] Support for shared_ptr<T()>

erik.pilkington updated this revision to Diff 95210. erik.pilkington added a comment. This new patch includes @EricWF's static_assert & test. Thanks, Erik https://reviews.llvm.org/D30837 Files: include/memory

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea marked 4 inline comments as done. gtbercea added inline comments. Comment at: test/Driver/openmp-offload.c:594 +/// Check cubin file generation and usage by nvlink +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -save-temps

[PATCH] D31717: CodeGen: Let lifetime intrinsic use alloca address space

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/CodeGenOpenCL/lifetime.cl:14 +// AMDGIZ: @llvm.lifetime.start.p5i + helper_no_markers(); +} Check line for the end as well?

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno added a comment. @rsmith ping! https://reviews.llvm.org/D31778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32035: [OpenMP] Error when trying to offload to an unsupported architecture

gtbercea updated this revision to Diff 95198. gtbercea added a comment. Re-use an already existing flag rather than creating a new one. Repository: rL LLVM https://reviews.llvm.org/D32035 Files: lib/Frontend/CompilerInvocation.cpp test/OpenMP/target_messages.cpp Index:

[PATCH] D32043: [Driver] Load all necessary default sanitizer blacklists

vsk created this revision. This patch removes a limitation which causes us to load at most one default sanitizer blacklist when multiple sanitizers are enabled. E.g if asan + cfi are enabled, and default blacklists for both sanitizers are present, we would only load one of the blacklists. The

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

NoQ updated this revision to Diff 95082. NoQ added a comment. Remove accidentally added braces in unrelated code. https://reviews.llvm.org/D31982 Files: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp lib/StaticAnalyzer/Core/Store.cpp test/Analysis/explain-svals.cpp

[PATCH] D31886: [analyzer] Simplify values in binary operations more aggressively

This revision was automatically updated to reflect the committed changes. Closed by commit rL300178: [analyzer] Simplify values in binary operations a bit more aggressively. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D31886?vs=94955=95084#toc Repository: rL

r300181 - Revert "[clang-cl] Make all sanitizer flags available in clang-cl"

Author: ahatanak Date: Thu Apr 13 03:02:29 2017 New Revision: 300181 URL: http://llvm.org/viewvc/llvm-project?rev=300181=rev Log: Revert "[clang-cl] Make all sanitizer flags available in clang-cl" This reverts commit 47979b20b475664013d19382fc6875b5b9f3ed9d. This was causing a couple of bots to

[libcxx] r300191 - Add TEST_NOEXCEPT_FALSE to support D31738

Author: ericwf Date: Thu Apr 13 05:17:23 2017 New Revision: 300191 URL: http://llvm.org/viewvc/llvm-project?rev=300191=rev Log: Add TEST_NOEXCEPT_FALSE to support D31738 Modified: libcxx/trunk/test/support/test_macros.h Modified: libcxx/trunk/test/support/test_macros.h URL:

r300187 - [analyzer] Add numerous assertions to SVal, SymExpr, and MemRegion classes.

Author: dergachev Date: Thu Apr 13 04:48:05 2017 New Revision: 300187 URL: http://llvm.org/viewvc/llvm-project?rev=300187=rev Log: [analyzer] Add numerous assertions to SVal, SymExpr, and MemRegion classes. Clean up vtable anchors (remove anchors for regions that have regular out-of-line virtual

[PATCH] D26837: [analyzer] Litter the SVal/SymExpr/MemRegion class hierarchy with asserts.

This revision was automatically updated to reflect the committed changes. Closed by commit rL300187: [analyzer] Add numerous assertions to SVal, SymExpr, and MemRegion classes. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D26837?vs=79538=95092#toc Repository:

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:975 + if (Op->getOpcode() == UO_AddrOf) +if (Op->getSubExpr()->isLValue()) { + Ex = Op->getSubExpr()->IgnoreParenCasts(); Maybe you could move this

Re: r300122 - [clang-cl] Make all sanitizer flags available in clang-cl

I’m afraid I have to revert this to turn the bots green again. > On Apr 12, 2017, at 10:41 PM, Akira Hatanaka via cfe-commits > wrote: > > I think this broke some of the bots. > > http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/30152/ >

[PATCH] D31885: Remove TBAA information from LValues representing union members

kparzysz updated this revision to Diff 95217. kparzysz edited the summary of this revision. kparzysz added a reviewer: hfinkel. kparzysz added a comment. Fixed the testcases (forgot to use FileCheck). Repository: rL LLVM https://reviews.llvm.org/D31885 Files: lib/CodeGen/CGExpr.cpp

[PATCH] D32014: Remove unused varible

chenwj added a comment. I don't have commit access, need someone's help. :-) https://reviews.llvm.org/D32014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r300261 - [libcxx] Direct support for Fuchsia

Author: phosek Date: Thu Apr 13 16:29:21 2017 New Revision: 300261 URL: http://llvm.org/viewvc/llvm-project?rev=300261=rev Log: [libcxx] Direct support for Fuchsia Fuchsia's libc was forked from musl, but has evolved sufficiently since then so it no longer makes sense to pretend it's musl. This

r300266 - Add test for anonymous struct containing an implicitly private data member.

Author: rsmith Date: Thu Apr 13 16:51:04 2017 New Revision: 300266 URL: http://llvm.org/viewvc/llvm-project?rev=300266=rev Log: Add test for anonymous struct containing an implicitly private data member. Patch by Jacob Young! Modified: cfe/trunk/test/SemaCXX/anonymous-struct.cpp Modified:

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and CGOpts

pcc added a comment. I think it would be better to move this logic to the driver and have it pass in an `-mllvm` flag. The sanitizer passes should really be taking no arguments in the constructor like the other passes, so I don't want us to add another argument here. Repository: rL LLVM

r300262 - PR32185: Revert r291512 and add a testcase for PR32185.

Author: rsmith Date: Thu Apr 13 16:37:24 2017 New Revision: 300262 URL: http://llvm.org/viewvc/llvm-project?rev=300262=rev Log: PR32185: Revert r291512 and add a testcase for PR32185. This reverts an attempt to check that types match when matching a dependently-typed non-type template parameter.

[PATCH] D27263: Address of bitfield in anonymous struct doesn't error.

This revision was automatically updated to reflect the committed changes. Closed by commit rL300264: Diagnose attempt to take address of bitfield members in anonymous structs. (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D27263?vs=79759=95222#toc Repository: rL

r300264 - Diagnose attempt to take address of bitfield members in anonymous structs.

Author: rsmith Date: Thu Apr 13 16:49:46 2017 New Revision: 300264 URL: http://llvm.org/viewvc/llvm-project?rev=300264=rev Log: Diagnose attempt to take address of bitfield members in anonymous structs. Patch by Jacob Young! Differential Revision: https://reviews.llvm.org/D27263 Modified:

r300271 - [docs] Regenerate diagnostics reference.

Author: rsmith Date: Thu Apr 13 17:44:22 2017 New Revision: 300271 URL: http://llvm.org/viewvc/llvm-project?rev=300271=rev Log: [docs] Regenerate diagnostics reference. Modified: cfe/trunk/docs/DiagnosticsReference.rst Modified: cfe/trunk/docs/DiagnosticsReference.rst URL:

[PATCH] D32029: [ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, looks good to me. Repository: rL LLVM https://reviews.llvm.org/D32029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r300287 - [ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt

Author: kuba.brecka Date: Thu Apr 13 19:32:43 2017 New Revision: 300287 URL: http://llvm.org/viewvc/llvm-project?rev=300287=rev Log: [ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt CodeGenFunction::EmitObjCForCollectionStmt currently emits lifetime markers for the loop

[PATCH] D32029: [ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rL300287: [ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt (authored by kuba.brecka). Changed prior to commit: https://reviews.llvm.org/D32029?vs=95157=95251#toc Repository:

r300272 - [IR] Make getParamAttributes take argument numbers, not ArgNo+1

Author: rnk Date: Thu Apr 13 18:12:13 2017 New Revision: 300272 URL: http://llvm.org/viewvc/llvm-project?rev=300272=rev Log: [IR] Make getParamAttributes take argument numbers, not ArgNo+1 Add hasParamAttribute() and use it instead of hasAttribute(ArgNo+1, Kind) everywhere. The fact that the

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

yamaguchi added a comment. I don't have a commit access. Can you commit? https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300290 - Revert r300287.

Author: kuba.brecka Date: Thu Apr 13 20:00:03 2017 New Revision: 300290 URL: http://llvm.org/viewvc/llvm-project?rev=300290=rev Log: Revert r300287. Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp cfe/trunk/test/CodeGenObjC/arc-foreach.m cfe/trunk/test/CodeGenObjC/arc-ternary-op.m

r300270 - [docs] Fix a couple of typos in command line flag help text and regenerate documentation.

Author: rsmith Date: Thu Apr 13 17:39:49 2017 New Revision: 300270 URL: http://llvm.org/viewvc/llvm-project?rev=300270=rev Log: [docs] Fix a couple of typos in command line flag help text and regenerate documentation. Modified: cfe/trunk/docs/ClangCommandLineReference.rst

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and CGOpts

eugenis created this revision. The linux part is a bit ahead of time - the instrumentation code where this matters have not landed yet. But when it does, this would be the right condition, and for now ELF instrumentation simply ignores this setting. Repository: rL LLVM

[PATCH] D32029: [ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt

kubamracek added a comment. Note that C++ foreach loops also generate lifetime.start and lifetime.end inside of the loop body. Repository: rL LLVM https://reviews.llvm.org/D32029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r300279 - [Profile] PE binary coverage bug fix

Author: davidxl Date: Thu Apr 13 18:37:21 2017 New Revision: 300279 URL: http://llvm.org/viewvc/llvm-project?rev=300279=rev Log: [Profile] PE binary coverage bug fix PR/32584 Differential Revision: https://reviews.llvm.org/D32023 Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and CGOpts

eugenis added a comment. From a quick look at the code, it seems like -fno-data-sections on COFF would suppress GC of globals the same as on ELF. Is that true? Repository: rL LLVM https://reviews.llvm.org/D32064 ___ cfe-commits mailing list

[PATCH] D32063: [clang-move] cleanup: create ClangMoveActionFactory on the stack

alexshap created this revision. alexshap created this object with visibility "All Users". This diff removes unnecessary using of unique_ptr with ClangMoveActionFactory (pico cleanup). NFC Repository: rL LLVM https://reviews.llvm.org/D32063 Files: tool/ClangMoveMain.cpp Index:

[PATCH] D27263: Address of bitfield in anonymous struct doesn't error.

rsmith added a comment. The change to test/SemaCXX/anonymous-struct.cpp appeared to be unrelated to the rest of the patch, so I committed it separately as r300266. Thank you! Repository: rL LLVM https://reviews.llvm.org/D27263 ___ cfe-commits

r300283 - Fix PR31934: forming refs to functions with enable_if attrs.

Author: gbiv Date: Thu Apr 13 18:47:08 2017 New Revision: 300283 URL: http://llvm.org/viewvc/llvm-project?rev=300283=rev Log: Fix PR31934: forming refs to functions with enable_if attrs. Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/trunk/test/SemaCXX/enable_if.cpp Modified:

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

eugenis updated this revision to Diff 95254. eugenis retitled this revision from "[asan] Disable ASan global-GC depending on the target and CGOpts" to "[asan] Disable ASan global-GC depending on the target and compiler flags". Repository: rL LLVM https://reviews.llvm.org/D32064 Files:

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

dexonsmith added reviewers: hfinkel, rsmith. dexonsmith added a comment. +Hal and Richard, a couple of possible reviewers. https://reviews.llvm.org/D31856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r300225 - Warning-free clang-format plugin install for VS 15.0

Author: hans Date: Thu Apr 13 12:42:45 2017 New Revision: 300225 URL: http://llvm.org/viewvc/llvm-project?rev=300225=rev Log: Warning-free clang-format plugin install for VS 15.0 With the new release of VS, it's required that all plugins migrate to the new VSIX manifest format. The new format is

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein updated this revision to Diff 95174. hokein marked 11 inline comments as done. hokein added a comment. Address review comments. https://reviews.llvm.org/D31757 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/InefficientVectorOperationCheck.cpp

[PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

bruno closed this revision. bruno added a comment. Done way back in r248932 Repository: rL LLVM https://reviews.llvm.org/D13117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27429: [Chrono][Darwin] On Darwin use CLOCK_UPTIME_RAW instead of CLOCK_MONOTONIC

bruno closed this revision. bruno added a comment. r291466 & r291517 https://reviews.llvm.org/D27429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

gtbercea updated this revision to Diff 95171. gtbercea added a comment. Remove tests which belong into a different patch. Repository: rL LLVM https://reviews.llvm.org/D29658 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp

[PATCH] D29001: [Modules] Fallback to building the module if a timeout occurs

bruno closed this revision. bruno added a comment. Updating: already done in r298175 https://reviews.llvm.org/D29001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

aaron.ballman added inline comments. Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:81 + hasLoopInit(LoopVarInit), + hasCondition(binaryOperator(hasOperatorName("<"), + hasLHS(RefersToLoopVar),

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

malaperle-ericsson added a comment. In https://reviews.llvm.org/D31992#725913, @joerg wrote: > I'm strongly against this patch. Can you give an actual test case for the > problematic behavior? Sure I can add a test. If you meant more real work scenario, you can juste type "é" in VS Code and

r300178 - [analyzer] Simplify values in binary operations a bit more aggressively.

Author: dergachev Date: Thu Apr 13 02:20:04 2017 New Revision: 300178 URL: http://llvm.org/viewvc/llvm-project?rev=300178=rev Log: [analyzer] Simplify values in binary operations a bit more aggressively. SValBuilder tries to constant-fold symbols in the left-hand side of the symbolic expression

[PATCH] D31167: Use FPContractModeKind universally

mehdi_amini added a comment. I believe considering the goal of moving to using per-instruction FMF and kills the global backend option, this leads to a bitcode upgrade issue: OpenCL (or other) bitcode that were generated bitcode don't have the right FMF and will be upgraded conservatively.

[PATCH] D26838: [analyzer] Enforce super-region classes for various memory regions through compile-time and run-time type checks.

This revision was automatically updated to reflect the committed changes. Closed by commit rL300189: [analyzer] Enforce super-region classes for various memory regions. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D26838?vs=79537=95093#toc Repository: rL LLVM

r300189 - [analyzer] Enforce super-region classes for various memory regions.

Author: dergachev Date: Thu Apr 13 04:56:07 2017 New Revision: 300189 URL: http://llvm.org/viewvc/llvm-project?rev=300189=rev Log: [analyzer] Enforce super-region classes for various memory regions. We now check the type of the super-region pointer for most SubRegion classes in compile time;

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

GorNishanov added inline comments. Comment at: lib/Sema/CoroutineBuilder.h:1 +//===- CoroutineBuilder.h - Coroutine Semantic checking -*- C++ -*-===// +// This file is called: CoroutineStmtBuilder.h in trunk Comment at:

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

joerg added a comment. I'm strongly against this patch. Can you give an actual test case for the problematic behavior? Repository: rL LLVM https://reviews.llvm.org/D31992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

klimek added inline comments. Comment at: clangd/Protocol.cpp:26-50 + for (llvm::StringRef::iterator i = Input.begin(), e = Input.end(); i != e; ++i) { +if (*i == '\\') + EscapedInput += ""; +else if (*i == '"') + EscapedInput += "\\\""; +// bell +

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

malaperle-ericsson added a comment. In https://reviews.llvm.org/D31992#725866, @krasimir wrote: > Seems that we're starting to hit some YAML/JSON mismatches, or is it that > your YAML string support is lacking? I don't think so. It seems like JSON and YAML are not completely aligned on

[PATCH] D31976: Avoid assert when a non-static member function is qualified with __unaligned

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This seems reasonable to me, but you should wait for confirmation before committing (I'm not as familiar with the mangler as others are). Comment at:

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

klimek added a comment. In https://reviews.llvm.org/D31992#725912, @malaperle-ericsson wrote: > In https://reviews.llvm.org/D31992#725866, @krasimir wrote: > > > Seems that we're starting to hit some YAML/JSON mismatches, or is it that > > your YAML string support is lacking? > > > I don't

r300295 - [docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin

Author: vedantk Date: Thu Apr 13 20:59:44 2017 New Revision: 300295 URL: http://llvm.org/viewvc/llvm-project?rev=300295=rev Log: [docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin Printing out stack traces along with UBSan diagnostics is unsupported on Darwin. That's because

[PATCH] D31482: [AMDGPU][GFX9] Set +fp32-denormals for >=gfx900 unless -cl-denorms-are-zero is set

This revision was automatically updated to reflect the committed changes. kzhuravl marked 2 inline comments as done. Closed by commit rL300306: [AMDGPU][GFX9] Set +fp32-denormals for >=gfx900 unless -cl-denorms-are-zero is… (authored by kzhuravl). Changed prior to commit:

r300306 - [AMDGPU][GFX9] Set +fp32-denormals for >=gfx900 unless -cl-denorms-are-zero is set

Author: kzhuravl Date: Fri Apr 14 00:33:57 2017 New Revision: 300306 URL: http://llvm.org/viewvc/llvm-project?rev=300306=rev Log: [AMDGPU][GFX9] Set +fp32-denormals for >=gfx900 unless -cl-denorms-are-zero is set Differential Revision: https://reviews.llvm.org/D31482 Added:

r300303 - clang/test/CoverageMapping/unused_names.c: Relax an expression for targeting PECOFF.

Author: chapuni Date: Thu Apr 13 22:16:48 2017 New Revision: 300303 URL: http://llvm.org/viewvc/llvm-project?rev=300303=rev Log: clang/test/CoverageMapping/unused_names.c: Relax an expression for targeting PECOFF. Modified: cfe/trunk/test/CoverageMapping/unused_names.c Modified:

Re: r300303 - clang/test/CoverageMapping/unused_names.c: Relax an expression for targeting PECOFF.

Could you confirm if it is right fix? On Fri, Apr 14, 2017 at 12:29 PM NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chapuni > Date: Thu Apr 13 22:16:48 2017 > New Revision: 300303 > > URL: http://llvm.org/viewvc/llvm-project?rev=300303=rev > Log: >

[PATCH] D32029: [ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt

kubamracek reopened this revision. kubamracek added a comment. This revision is now accepted and ready to land. Reverted because this fails for-in.m by crashing the compiler when compiling: void t2(NSArray *array) { for (NSArray *array in array) { // expected-warning {{collection

r300301 - Remove unused function /nfc

Author: davidxl Date: Thu Apr 13 22:01:25 2017 New Revision: 300301 URL: http://llvm.org/viewvc/llvm-project?rev=300301=rev Log: Remove unused function /nfc Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp URL:

[PATCH] D32063: [clang-move] cleanup: create ClangMoveActionFactory on the stack

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup ;) Repository: rL LLVM https://reviews.llvm.org/D32063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein added inline comments. Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:109-111 + auto AllVectorVarRefs = utils::decl_ref_expr::allDeclRefExprs( + *VectorVarDecl, *LoopParent, *Result.Context); + for (const auto *Ref : AllVectorVarRefs) {

[PATCH] D32029: [ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt

kubamracek updated this revision to Diff 95271. kubamracek added a comment. Trying a different approach: Keeping the loop variable alive for the whole loop by extending ForScope and registering the cleanup function inside EmitAutoVarAlloca. https://reviews.llvm.org/D32029 Files:

r300296 - Remove empty test directory for nonexistent standard clause.

Author: rsmith Date: Thu Apr 13 21:04:44 2017 New Revision: 300296 URL: http://llvm.org/viewvc/llvm-project?rev=300296=rev Log: Remove empty test directory for nonexistent standard clause. Removed: cfe/trunk/test/CXX/garbage.collection/ ___

Re: r300295 - [docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin

Does anyone know what it would take to get the slow unwinder to work on Darwin? thanks, vedant > On Apr 13, 2017, at 6:59 PM, Vedant Kumar via cfe-commits > wrote: > > Author: vedantk > Date: Thu Apr 13 20:59:44 2017 > New Revision: 300295 > > URL:

r300304 - Fix use after free error

Author: davidxl Date: Thu Apr 13 23:14:29 2017 New Revision: 300304 URL: http://llvm.org/viewvc/llvm-project?rev=300304=rev Log: Fix use after free error Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp URL:

  1   2   >