[libcxxabi] r305278 - Set a default value for LIBCXXABI_LIBDIR_SUFFIX, fixes installing into lib64 after r304374

Author: ismail Date: Tue Jun 13 03:16:44 2017 New Revision: 305278 URL: http://llvm.org/viewvc/llvm-project?rev=305278=rev Log: Set a default value for LIBCXXABI_LIBDIR_SUFFIX, fixes installing into lib64 after r304374 Modified: libcxxabi/trunk/CMakeLists.txt Modified:

[PATCH] D33526: Fix spurious Wunused-lambda-capture warning

malcolm.parsons accepted this revision. malcolm.parsons added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM https://reviews.llvm.org/D33526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34107: [clangd] Allow to override contents of the file during completion.

ilya-biryukov added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:452 + StringRef(OverridenSourceContents)) +.Value; +EXPECT_TRUE(ContainsItem(CodeCompletionResultsOverriden, "cbc")); krasimir wrote: > Is

[PATCH] D32428: Fix for Itanium mangler issue with templates (bug: 31405)

Serge_Preis added a reviewer: rsmith. Serge_Preis added a comment. Would you please take a look into proposed minor changes to avoid mangler assertion in some template cases. https://reviews.llvm.org/D32428 ___ cfe-commits mailing list

[clang-tools-extra] r305283 - Revert "[clangd] Allow to override contents of the file during completion."

Author: ibiryukov Date: Tue Jun 13 05:01:11 2017 New Revision: 305283 URL: http://llvm.org/viewvc/llvm-project?rev=305283=rev Log: Revert "[clangd] Allow to override contents of the file during completion." This caused buildbots failures, reverting until we'll find out what's wrong. Modified:

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

Serge_Preis added a reviewer: arphaman. Serge_Preis added a comment. Hello, would you please review my small fix for incorrect source positions for certain entities. The changes were submitted more than a month ago and I understand you all are busy people, but I hope this review won't take

[PATCH] D33852: Enable __declspec(selectany) on linux

Prazek added inline comments. Comment at: include/clang/Basic/Attr.td:2421 -def SelectAny : InheritableAttr, TargetSpecificAttr { +def SelectAny : InheritableAttr, TargetSpecificAttr { let Spellings = [Declspec<"selectany">, GCC<"selectany">]; rnk wrote: >

[clang-tools-extra] r305279 - [clangd] Use 'std::string' for VFSTag instead of 'int'

Author: ibiryukov Date: Tue Jun 13 03:24:48 2017 New Revision: 305279 URL: http://llvm.org/viewvc/llvm-project?rev=305279=rev Log: [clangd] Use 'std::string' for VFSTag instead of 'int' Reviewers: krasimir Reviewed By: krasimir Subscribers: klimek, cfe-commits Tags: #clang-tools-extra

[PATCH] D34107: [clangd] Allow to override contents of the file during completion.

ilya-biryukov updated this revision to Diff 102300. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. Fixed formatting, added a space (see krasimir's comment) https://reviews.llvm.org/D34107 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h

[PATCH] D33526: Fix spurious Wunused-lambda-capture warning

malcolm.parsons added a comment. I don't understand why init captures have this problem. The variable is defined within the context of the lambda, but it's not within the context of the templated method. Are you working around a bug somewhere else? Repository: rL LLVM

[PATCH] D32942: [clang-tidy] readability-function-size: add NestingThreshold param.

malcolm.parsons added a comment. In https://reviews.llvm.org/D32942#777001, @lebedev.ri wrote: > Which makes sense, since in AST, they are nested: They're not nested in the formatting, so I don't think it makes sense. Repository: rL LLVM https://reviews.llvm.org/D32942

[clang-tools-extra] r305280 - [clangd] Allow to override contents of the file during completion.

Author: ibiryukov Date: Tue Jun 13 03:32:27 2017 New Revision: 305280 URL: http://llvm.org/viewvc/llvm-project?rev=305280=rev Log: [clangd] Allow to override contents of the file during completion. Reviewers: krasimir Reviewed By: krasimir Subscribers: klimek, cfe-commits Differential

[PATCH] D34107: [clangd] Allow to override contents of the file during completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL305280: [clangd] Allow to override contents of the file during completion. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34107?vs=102300=102301#toc Repository: rL LLVM

[PATCH] D33526: Fix spurious Wunused-lambda-capture warning

kongyi added a comment. For normal captures, variables are safe to eliminate if they are non-ODR used or totally unused. However for init captures, non-ODR usage still depends on the capture; they are only safe to eliminate if totally unused. Repository: rL LLVM

[PATCH] D34106: [clangd] Use 'std::string' for VFSTag instead of 'int'

This revision was automatically updated to reflect the committed changes. Closed by commit rL305279: [clangd] Use 'std::string' for VFSTag instead of 'int' (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34106?vs=102189=102298#toc Repository: rL LLVM

[PATCH] D34146: [clangd] Allow to override contents of the file during completion.

ilya-biryukov created this revision. This is a reapplied r305280 with a fix to the crash found by build bots (StringRef to an out-of-scope local std::string). https://reviews.llvm.org/D34146 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h unittests/clangd/ClangdTests.cpp Index:

[PATCH] D32146: PR32476: __nop_locale_mgmt.h not needed with newlib 2.5+

mclow.lists added a comment. This change looks fine to me - but I don't have the different newlib versions to test against. Once everyone else is happy with the version detection, then I'm good with this. https://reviews.llvm.org/D32146 ___

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

I cannot reproduce such fail, so I can only guess how changes made in https://reviews.llvm.org/rL303756 and https://reviews.llvm.org/rL303741 could cause such problem. Behavior of `Driver::BuildCompilation` is changed so that it returns null pointer if errors occur during driver argument parse. It

[libcxx] r305292 - Fix bug 33389 - __is_transparent check requires too much

Author: marshall Date: Tue Jun 13 09:34:58 2017 New Revision: 305292 URL: http://llvm.org/viewvc/llvm-project?rev=305292=rev Log: Fix bug 33389 - __is_transparent check requires too much Modified: libcxx/trunk/include/__functional_base

Re: r305239 - Revert r301742 which made ExprConstant checking apply to all full-exprs.

Hi, I reverted r305287, since the bots were red for a very long time. More bots with the same error: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/7727 http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/5503

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This was committed as r305136 https://reviews.llvm.org/D34038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34146: [clangd] Allow to override contents of the file during completion.

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:190 + llvm::Optional OverridenContents) { + std::string DraftStorage; + if (!OverridenContents) { This is the relevant line that changed from the previous

[clang-tools-extra] r305291 - [clangd] Allow to override contents of the file during completion.

Author: ibiryukov Date: Tue Jun 13 09:15:56 2017 New Revision: 305291 URL: http://llvm.org/viewvc/llvm-project?rev=305291=rev Log: [clangd] Allow to override contents of the file during completion. Summary: This is a reapplied r305280 with a fix to the crash found by build bots (StringRef to an

[PATCH] D32146: PR32476: __nop_locale_mgmt.h not needed with newlib 2.5+

MartinO accepted this revision. MartinO added a comment. This revision is now accepted and ready to land. `Looks good. Previously I had also got a check for 'defined(__NEWLIB_MINOR__)' but I realise that was not necessary` https://reviews.llvm.org/D32146

[PATCH] D34146: [clangd] Allow to override contents of the file during completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL305291: [clangd] Allow to override contents of the file during completion. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34146?vs=102328=102331#toc Repository: rL LLVM

[PATCH] D34148: [clangd] Store references instead of unique_ptrs in ClangdServer.

ilya-biryukov created this revision. ClangdServer was owning objects passed to it in constructor for no good reason. Lots of stuff was moved from the heap to the stack thanks to this change. https://reviews.llvm.org/D34148 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D33681: Allow function declaration with empty argument list.

bader updated this revision to Diff 102319. bader added a comment. Update one more test missed in the first version of the patch. Actually it looks like a bug in Parser. Clang interprets following statement as variable declaration. extern pipe write_only int get_pipe(); So the type of the

r305287 - Revert "Revert r301742 which made ExprConstant checking apply to all full-exprs."

Author: rovka Date: Tue Jun 13 07:50:06 2017 New Revision: 305287 URL: http://llvm.org/viewvc/llvm-project?rev=305287=rev Log: Revert "Revert r301742 which made ExprConstant checking apply to all full-exprs." This reverts commit r305239 because it broke the buildbots (the diag-flags.cpp test is

[PATCH] D30268: Avoid copy of __atoms when char_type is char

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Could you please add the benchmark under `libcxx/benchmarks`. Could you also make sure that the existing tests (under `test/std`) for number parsing have sufficient test coverages for

[PATCH] D33833: Fix PR 33189: Clang assertion on template destructor declaration

kuang_he added a comment. Can we have this patch reviewed? https://reviews.llvm.org/D33833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

fedor.sergeev added inline comments. Comment at: lib/Driver/ToolChains/Gnu.h:219-220 +void AddGnuIncludeArgs(const llvm::opt::ArgList , + llvm::opt::ArgStringList ) const; + To me this does not belong to GCC-Installation-Detector

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

fedor.sergeev added a comment. > docs are rather clear that this functionality is Linux-only Oh, well, gcc implementation is rather generic, it relies on gcc's config.gcc to detect glibc and then it adds a hook that unconditionally provides stdc-predef.h (TARGET_C_PREINCLUDE). Currently

r305325 - Preserve cold attribute for function decls

Author: davidxl Date: Tue Jun 13 16:14:07 2017 New Revision: 305325 URL: http://llvm.org/viewvc/llvm-project?rev=305325=rev Log: Preserve cold attribute for function decls Differential Revision: http://reviews.llvm.org/D34133 Modified: cfe/trunk/lib/CodeGen/CGCall.cpp

[PATCH] D34133: Cold attribute on function decls are lost. Fix the problem

This revision was automatically updated to reflect the committed changes. Closed by commit rL305325: Preserve cold attribute for function decls (authored by davidxl). Changed prior to commit: https://reviews.llvm.org/D34133?vs=102358=102409#toc Repository: rL LLVM

[PATCH] D34121: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430)

vsk added a comment. In https://reviews.llvm.org/D34121#779347, @dtzWill wrote: > Don't mean to block this, but just FYI I won't be able to look into this > carefully until later this week (sorry!). > > Kicked off a rebuild using these patches just now, though! O:) No problem, thanks for

[PATCH] D34156: [LTO] Add -femit-summary-index flag to emit summary for regular LTO

pcc added a comment. Have you considered writing the regular LTO summaries unconditionally if `-flto` was specified? That was how I imagined that the interface would look. Also, how were you planning to expose the reference graph to the linker? I gather from your message that you are teaching

[PATCH] D34173: [Completion] Code complete the members for a dependent type after a '::'

arphaman created this revision. This is a follow up to r302797 which added support for dependent completions after '.' and '->'. This patch handles the '::' operator. Repository: rL LLVM https://reviews.llvm.org/D34173 Files: lib/Sema/SemaCodeComplete.cpp

[PATCH] D34175: [driver][macOS] Pick the system version for the deployment target if the SDK is newer than the system

arphaman created this revision. This patch improves the driver by making sure that it picks the system version for the deployment target when the version of the macOS SDK is newer than the system version. Repository: rL LLVM https://reviews.llvm.org/D34175 Files:

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Adding Richard to the review for some wider perspective than just mine on the overall design. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:296 + + if (ThrowType->isReferenceType()) +ThrowType =

RE: D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

Thanks I'll fix that. -Original Message- From: Fedor Sergeev via Phabricator [mailto:revi...@reviews.llvm.org] Sent: Tuesday, June 13, 2017 3:30 PM To: Blower, Melanie ; zhangsheng...@huawei.com; olivier...@gmail.com; kalinichev.s...@gmail.com; kf...@kde.org;

[PATCH] D34121: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430)

dtzWill added a comment. Don't mean to block this, but just FYI I won't be able to look into this carefully until later this week (sorry!). Kicked off a rebuild using these patches just now, though! O:) https://reviews.llvm.org/D34121 ___

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

fedor.sergeev added a comment. There is no /usr/include/stdc-predef.h on Solaris and I see no sense in adding this -include for anything except Linux (as docs are rather clear that this functionality is Linux-only). Checked gcc on Solaris11/12 both SPARC and X86 - none are doing stdc-predef.h

[PATCH] D34021: [coroutines] Fix co_await for range statement

EricWF added inline comments. Comment at: include/clang/AST/ExprCXX.h:4136 + : Expr(SC, Resume->getType(), + (Resume->getType()->isLValueReferenceType() ? VK_LValue : + Resume->getType()->isRValueReferenceType() ? VK_XValue :

[PATCH] D34170: [libcxx] Moving compiler specific test infrastructure to compiler.py

bcraig created this revision. format.py and config.py were routinely reaching into the innards of compiler.py, then setting variables in a very gcc / clang-centric way. Now, all the compiler specific code has been moved to compiler.py. These makes it possible to (in theory) build with MSVC

[PATCH] D34133: Cold attribute on function decls are lost. Fix the problem

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

Ah, I find that the test passes if I remove the compile_commands.json file from my build directory (I have Ninja configured to generate a compile_commands.json file). Looks like what happens is it finds the compilation database and fails hard when the database doesn't contain a compile command

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc updated this revision to Diff 102382. mibintc added a comment. forgot to add the new lit test https://reviews.llvm.org/D34158 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

yaxunl added a comment. Can you add missing types to test/CodeGenOpenCL/opencl_types.cl ? Comment at: include/clang/Basic/TargetInfo.h:1034 + virtual LangAS::ID getOpenCLTypeAddrSpace(BuiltinType::Kind K) const { +switch (K) { +#define IMAGE_TYPE(ImgType, Id, SingletonId,

r305361 - [ODRHash] Hash Template and TemplateExpansion in TemplateArgument.

Author: rtrieu Date: Tue Jun 13 22:17:26 2017 New Revision: 305361 URL: http://llvm.org/viewvc/llvm-project?rev=305361=rev Log: [ODRHash] Hash Template and TemplateExpansion in TemplateArgument. Modified: cfe/trunk/lib/AST/ODRHash.cpp cfe/trunk/test/Modules/odr_hash.cpp Modified:

[libcxx] r305370 - Add an `__is_inplace_index` metafunction.

Author: mpark Date: Wed Jun 14 00:51:18 2017 New Revision: 305370 URL: http://llvm.org/viewvc/llvm-project?rev=305370=rev Log: Add an `__is_inplace_index` metafunction. Summary: This is used to constrain `variant`'s converting constructor correctly. Reviewers: EricWF, mclow.lists Reviewed By:

r305362 - [ODRHash] Remove debugging code from r305361

Author: rtrieu Date: Tue Jun 13 22:19:58 2017 New Revision: 305362 URL: http://llvm.org/viewvc/llvm-project?rev=305362=rev Log: [ODRHash] Remove debugging code from r305361 Modified: cfe/trunk/lib/AST/ODRHash.cpp Modified: cfe/trunk/lib/AST/ODRHash.cpp URL:

[libcxx] r305365 - Implement the non-parallel versions of reduce and transform_reduce for C++17

Author: marshall Date: Tue Jun 13 23:48:45 2017 New Revision: 305365 URL: http://llvm.org/viewvc/llvm-project?rev=305365=rev Log: Implement the non-parallel versions of reduce and transform_reduce for C++17 Added: libcxx/trunk/test/std/numerics/numeric.ops/reduce/

[PATCH] D34021: [coroutines] Fix co_await for range statement

EricWF updated this revision to Diff 102472. EricWF added a comment. - Remove changes to how `CoroutineSuspendExpr`s `ExprValueType` is calculated. They were incorrect. However this means that Clang still fails to compile `co_await` and `co_yield` expressions where `await_resume` returns an

Re: r284060 - Implement MS _BitScan intrinsics

On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits wrote: > SGTM too. Regarding Duncan's last question -- I can't think of any such > customer. :) If you all think the right thing for clang to do is to infer > LLP64 behavior on LP64 (Darwin) +

r305363 - [coroutines] Fix co_await for range statement

Author: ericwf Date: Tue Jun 13 22:24:55 2017 New Revision: 305363 URL: http://llvm.org/viewvc/llvm-project?rev=305363=rev Log: [coroutines] Fix co_await for range statement Summary: Currently we build the co_await expressions on the wrong implicit statements of the implicit ranged for;

[PATCH] D34194: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

EricWF created this revision. The title says it all. However I can't figure out how to test `int& x = co_yield 42;` since that expression doesn't seem to want to parse. https://reviews.llvm.org/D34194 Files: lib/CodeGen/CGCoroutine.cpp lib/CodeGen/CGExpr.cpp

[PATCH] D33976: [clang] Fix format specifiers fixits

mehdi_amini added a comment. In https://reviews.llvm.org/D33976#776486, @mehdi_amini wrote: > In https://reviews.llvm.org/D33976#775918, @alexshap wrote: > > > @mehdi_amini , thanks, i see, regarding the "opposite issue" - probably an > > example / test case would be helpful, that looks like a

[PATCH] D34182: [analyzer] Performance optimizations for the CloneChecker

teemperor created this revision. Herald added a subscriber: xazax.hun. This patch aims at optimizing the CloneChecker for larger programs. Before this patch we took around 102 seconds to analyze sqlite3 with a complexity value of 50. After this patch we now take 2.1 seconds to analyze sqlite3.

r305328 - [ODRHash] Add TemplateArgument kind to hash.

Author: rtrieu Date: Tue Jun 13 17:21:18 2017 New Revision: 305328 URL: http://llvm.org/viewvc/llvm-project?rev=305328=rev Log: [ODRHash] Add TemplateArgument kind to hash. Modified: cfe/trunk/lib/AST/ODRHash.cpp cfe/trunk/test/Modules/odr_hash.cpp Modified:

[PATCH] D34156: [LTO] Add -femit-summary-index flag to emit summary for regular LTO

tobiasvk added a comment. In https://reviews.llvm.org/D34156#779270, @pcc wrote: > Have you considered writing the regular LTO summaries unconditionally if > `-flto` was specified? That was how I imagined that the interface would look. Absolutely, if people are OK with that. I would have

[PATCH] D34156: [LTO] Add -femit-summary-index flag to emit summary for regular LTO

pcc added a comment. In https://reviews.llvm.org/D34156#779661, @tobiasvk wrote: > In https://reviews.llvm.org/D34156#779270, @pcc wrote: > > > Have you considered writing the regular LTO summaries unconditionally if > > `-flto` was specified? That was how I imagined that the interface would >

[PATCH] D33977: [libcxx][WIP] Experimental support for a scheduler for use in the parallel stl algorithms

dexonsmith added a comment. You mention that the lock-free `deque` gives a speedup. I agree that should be left for a follow-up, but what kind of speedup did it give? Have you measured whether the parallel algorithm gives a speedup, compared to a non-parallel algorithm?

r305360 - [ODRHash] Hash Expr for TemplateArgument::Expression

Author: rtrieu Date: Tue Jun 13 20:28:00 2017 New Revision: 305360 URL: http://llvm.org/viewvc/llvm-project?rev=305360=rev Log: [ODRHash] Hash Expr for TemplateArgument::Expression Modified: cfe/trunk/lib/AST/ODRHash.cpp cfe/trunk/test/Modules/odr_hash.cpp Modified:

[libcxx] r305352 - Creating release candidate rc3 from release_401 branch

Author: tstellar Date: Tue Jun 13 20:04:51 2017 New Revision: 305352 URL: http://llvm.org/viewvc/llvm-project?rev=305352=rev Log: Creating release candidate rc3 from release_401 branch Added: libcxx/tags/RELEASE_401/rc3/ (props changed) - copied from r305351,

[libunwind] r305359 - Creating release candidate rc3 from release_401 branch

Author: tstellar Date: Tue Jun 13 20:05:11 2017 New Revision: 305359 URL: http://llvm.org/viewvc/llvm-project?rev=305359=rev Log: Creating release candidate rc3 from release_401 branch Added: libunwind/tags/RELEASE_401/rc3/ (props changed) - copied from r305358,

[libcxxabi] r305353 - Creating release candidate rc3 from release_401 branch

Author: tstellar Date: Tue Jun 13 20:04:54 2017 New Revision: 305353 URL: http://llvm.org/viewvc/llvm-project?rev=305353=rev Log: Creating release candidate rc3 from release_401 branch Added: libcxxabi/tags/RELEASE_401/rc3/ (props changed) - copied from r305352,

[PATCH] D34179: [SEMA] PR32318 Handle -ast-dump-all properly.

hintonda created this revision. Handle -ast-dump-all when passed as the only option. https://reviews.llvm.org/D34179 Files: lib/Frontend/ASTConsumers.cpp test/Coverage/ast-printing.c test/Coverage/ast-printing.cpp Index: test/Coverage/ast-printing.cpp

[PATCH] D34185: [Parser][ObjC] Avoid crashing when skipping to EOF while parsing an ObjC interface/implementation

arphaman created this revision. This patch fixes a Clang crash that happens when an Objective-C source code contains an `@interface`/`@implementation` declaration that follows unterminated `@implementation` declaration that contains a method with a message send that doesn't have the ']'. The

[PATCH] D32046: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments

erichkeane updated this revision to Diff 102458. erichkeane added a comment. Added unit test to validate that this still works throughout the range of arguments, and asserts as soon as you get to the end as requested. https://reviews.llvm.org/D32046 Files: include/clang/Lex/MacroArgs.h

r305294 - Add comma to comment.

Author: gbercea Date: Tue Jun 13 10:35:27 2017 New Revision: 305294 URL: http://llvm.org/viewvc/llvm-project?rev=305294=rev Log: Add comma to comment. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp URL:

[clang-tools-extra] r305299 - [clangd] A comment for ClangdServer's constructor. NFC.

Author: ibiryukov Date: Tue Jun 13 11:02:27 2017 New Revision: 305299 URL: http://llvm.org/viewvc/llvm-project?rev=305299=rev Log: [clangd] A comment for ClangdServer's constructor. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.h Modified:

[PATCH] D34133: Cold attribute on function decls are lost. Fix the problem

davidxl updated this revision to Diff 102358. davidxl added a comment. Herald added a subscriber: javed.absar. Add a test case. https://reviews.llvm.org/D34133 Files: lib/CodeGen/CGCall.cpp test/CodeGen/attributes.c Index: test/CodeGen/attributes.c

[PATCH] D33304: [clang-tidy][Part1] Add a new module Android and three new checks.

yawanng added inline comments. Comment at: docs/clang-tidy/checks/android-file-open-flag.rst:6 + +A common source of security bugs has been code that opens file without using +the ``O_CLOEXEC`` flag. Without that flag, an opened sensitive file would alexfh

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

v.g.vassilev added a comment. Waiting on resolution to: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79162 Repository: rL LLVM https://reviews.llvm.org/D33467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r305293 - [clang-format] Document the StartOfTokenColumn parameter, NFC

Author: krasimir Date: Tue Jun 13 09:58:55 2017 New Revision: 305293 URL: http://llvm.org/viewvc/llvm-project?rev=305293=rev Log: [clang-format] Document the StartOfTokenColumn parameter, NFC Modified: cfe/trunk/lib/Format/WhitespaceManager.h Modified:

[PATCH] D34148: [clangd] Store references instead of unique_ptrs in ClangdServer.

krasimir added inline comments. Comment at: clangd/ClangdLSPServer.h:75 + LSPDiagnosticsConsumer DiagConsumer; + RealFileSystemProvider FSProvider; + This approach is still inflexible. I'd make ClangdLSPServer : public DiagnosticsConsumer and pass references

[PATCH] D34151: [clangd] Add a filename parameter to FileSystemProvider.

ilya-biryukov created this revision. https://reviews.llvm.org/D34151 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h unittests/clangd/ClangdTests.cpp Index: unittests/clangd/ClangdTests.cpp === ---

[PATCH] D32428: Fix for Itanium mangler issue with templates (bug: 31405)

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D32428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r305272 - clang-format: add option to merge empty function body

Author: typz Date: Tue Jun 13 02:02:43 2017 New Revision: 305272 URL: http://llvm.org/viewvc/llvm-project?rev=305272=rev Log: clang-format: add option to merge empty function body Summary: This option supplements the AllowShortFunctionsOnASingleLine flag, to merge empty function body at the

[PATCH] D33447: clang-format: add option to merge empty function body

This revision was automatically updated to reflect the committed changes. Closed by commit rL305272: clang-format: add option to merge empty function body (authored by Typz). Changed prior to commit: https://reviews.llvm.org/D33447?vs=100420=102294#toc Repository: rL LLVM

[PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

dblaikie added a comment. I take it there's already handling for these attributes on non-member functions? There's probably a reason this code can't be wherever that code is & subtract one from the index? (reducing code duplication by having all the error handling, etc, in one place/once)

[PATCH] D32046: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments

erichkeane added a comment. Sure, I'll work on that, thanks! https://reviews.llvm.org/D32046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32046: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments

arphaman added a comment. Can you somehow test this change? Maybe a unittest for `getStringifiedArgument`that ensures that the assertion is triggered after the number of macro arguments is reached? https://reviews.llvm.org/D32046 ___ cfe-commits

[PATCH] D32942: [clang-tidy] readability-function-size: add NestingThreshold param.

lebedev.ri added a comment. In https://reviews.llvm.org/D32942#778729, @malcolm.parsons wrote: > In https://reviews.llvm.org/D32942#777001, @lebedev.ri wrote: > > > Which makes sense, since in AST, they are nested: > > > They're not nested in the formatting, so I don't think it makes sense. As

r305312 - Align definition of DW_OP_plus with DWARF spec [2/3]

Author: fhahn Date: Tue Jun 13 13:06:15 2017 New Revision: 305312 URL: http://llvm.org/viewvc/llvm-project?rev=305312=rev Log: Align definition of DW_OP_plus with DWARF spec [2/3] Summary: This patch is part of 3 patches that together form a single patch, but must be introduced in stages in

[PATCH] D32046: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments

erichkeane added a comment. Anyone have a chance to look at this? I'll note that this is in no way MSVC specific, this is a code-health issue. https://reviews.llvm.org/D32046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34082: [Frontend] 'Show hotness' can be used with a sampling profile

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D34082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33977: [libcxx][WIP] Experimental support for a scheduler for use in the parallel stl algorithms

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D33977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

dberris added a comment. In https://reviews.llvm.org/D34052#778670, @dblaikie wrote: > I take it there's already handling for these attributes on non-member > functions? Yes, we're just extending it to also apply to the case where it doesn't support this one case where we actually do need

[PATCH] D32480: clang-format: Add CompactNamespaces option

djasper added a comment. Ok. Works for me. https://reviews.llvm.org/D32480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

hard to say if it's more readable without seeing it - if you could attach a patch, if it's easy enough/you worked it up before, might be worth comparing/contrasting On Tue, Jun 13, 2017 at 12:28 AM Dean Michael Berris via Phabricator < revi...@reviews.llvm.org> wrote: > dberris added a comment.

[PATCH] D34156: [LTO] Add -femit-summary-index flag to emit summary for regular LTO

tobiasvk created this revision. Herald added subscribers: eraman, inglorion. With https://reviews.llvm.org/D33921, we gained the ability to have module summaries in regular LTO modules without triggering ThinLTO compilation. There is however, currently, no way to trigger the emission of a module

[PATCH] D33526: Fix spurious Wunused-lambda-capture warning

This revision was automatically updated to reflect the committed changes. Closed by commit rL305315: Fix spurious Wunused-lambda-capture warning (authored by kongyi). Changed prior to commit: https://reviews.llvm.org/D33526?vs=102099=102371#toc Repository: rL LLVM

r305315 - Fix spurious Wunused-lambda-capture warning

Author: kongyi Date: Tue Jun 13 13:38:31 2017 New Revision: 305315 URL: http://llvm.org/viewvc/llvm-project?rev=305315=rev Log: Fix spurious Wunused-lambda-capture warning Summary: Clang emits unused-lambda-capture warning for captures in generic lambdas even though they are actually used.

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl updated this revision to Diff 102374. yaxunl marked 11 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by John's comments. https://reviews.llvm.org/D28691 Files: docs/LanguageExtensions.rst include/clang/AST/Expr.h

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc created this revision. mibintc created this object with visibility "All Users". Herald added subscribers: fedor.sergeev, arichardson, Anastasia, sdardis, klimek. As reported in llvm bugzilla 32377. Here’s a patch to add preinclude of stdc-predef.h for gcc >= 4.8 The gcc documentation

[PATCH] D34148: [clangd] Store references instead of unique_ptrs in ClangdServer.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. But, of course, that can be done in a separate commit. https://reviews.llvm.org/D34148 ___ cfe-commits mailing list

[clang-tools-extra] r305298 - [clangd] Store references instead of unique_ptrs in ClangdServer.

Author: ibiryukov Date: Tue Jun 13 10:59:43 2017 New Revision: 305298 URL: http://llvm.org/viewvc/llvm-project?rev=305298=rev Log: [clangd] Store references instead of unique_ptrs in ClangdServer. Summary: ClangdServer owned objects passed to it in constructor for no good reason. Lots of stuff

[PATCH] D34148: [clangd] Store references instead of unique_ptrs in ClangdServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL305298: [clangd] Store references instead of unique_ptrs in ClangdServer. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D34148?vs=102333=102344#toc Repository: rL LLVM

[PATCH] D32480: clang-format: Add CompactNamespaces option

Typz updated this revision to Diff 102346. Typz added a comment. - make "compacted" namespaces always add at most one level of indentation - compact only namespaces which both start and end on consecutive lines https://reviews.llvm.org/D32480 Files: include/clang/Format/Format.h

  1   2   >