[PATCH] D35450: [analyzer] Support generating and reasoning over more symbolic constraint types

ddcc created this revision. Generate more IntSymExpr constraints, perform SVal simplification for IntSymExpr and SymbolCast constraints, and create fully symbolic SymExprs https://reviews.llvm.org/D35450 Files: include/clang/Config/config.h.cmake

[PATCH] D35427: [clang] Fix handling of "%zd" format specifier

chapuni added inline comments. Comment at: cfe/trunk/test/FixIt/format.m:240 + int x; + printf("%zn", ); // expected-warning{{format specifies type 'ssize_t *' (aka 'long *') but the argument has type 'int *'}} + // PrintfSpecifier::fixType doesn't handle %n, so a fix-it is

[PATCH] D35427: [clang] Fix handling of "%zd" format specifier

alexshap added a comment. @chapuni - many thanks! Repository: rL LLVM https://reviews.llvm.org/D35427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

yamaguchi updated this revision to Diff 106764. yamaguchi added a comment. Add code comment. https://reviews.llvm.org/D35447 Files: clang/include/clang/Basic/DiagnosticIDs.h clang/lib/Basic/DiagnosticIDs.cpp clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c Index:

r308084 - clang/test/FixIt/format.m: Tweak for i686, where ssize_t is int. (r308067)

Author: chapuni Date: Fri Jul 14 23:14:47 2017 New Revision: 308084 URL: http://llvm.org/viewvc/llvm-project?rev=308084=rev Log: clang/test/FixIt/format.m: Tweak for i686, where ssize_t is int. (r308067) Modified: cfe/trunk/test/FixIt/format.m Modified: cfe/trunk/test/FixIt/format.m URL:

[clang-tools-extra] r308085 - ClangApplyReplacementsTests: Add clangBasic in libdeps.

Author: chapuni Date: Fri Jul 14 23:32:10 2017 New Revision: 308085 URL: http://llvm.org/viewvc/llvm-project?rev=308085=rev Log: ClangApplyReplacementsTests: Add clangBasic in libdeps. r308015 introduced clangBasic to instantiate Diagnostics , Modified:

[PATCH] D35450: [analyzer] Support generating and reasoning over more symbolic constraint types

ddcc updated this revision to Diff 106758. ddcc added a comment. Modify Z3RangeConstraintManager::fixAPSInt() and add Expr::isCommutativeOp() https://reviews.llvm.org/D35450 Files: include/clang/AST/Expr.h include/clang/Config/config.h.cmake

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. See the comment on https://reviews.llvm.org/D35372. https://reviews.llvm.org/D35368 ___ cfe-commits mailing list

[PATCH] D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. See the comment on https://reviews.llvm.org/D35372. Repository: rL LLVM https://reviews.llvm.org/D35362 ___ cfe-commits mailing

[PATCH] D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. See the comment on https://reviews.llvm.org/D35372. Repository: rL LLVM https://reviews.llvm.org/D35363 ___ cfe-commits mailing

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

alexfh added a comment. In https://reviews.llvm.org/D35372#810457, @alexfh wrote: > I have deja vu ;) > > Should we make a single check for all CLOEXEC and friends with a single > configurable list of (function name, flag name) pairs? Okay, it may be a bit more complicated than just a list of

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

yamaguchi updated this revision to Diff 106763. yamaguchi added a comment. Update diff according to Rui and teemperor's comments. https://reviews.llvm.org/D35447 Files: clang/include/clang/Basic/DiagnosticIDs.h clang/lib/Basic/DiagnosticIDs.cpp clang/lib/Driver/Driver.cpp

[PATCH] D34937: Suppressing Reference Counting Diagnostics for Functions Containing 'rc_ownership_trusted_implementation' Annotate Attribute

malhar1995 updated this revision to Diff 106765. malhar1995 added a comment. Checked for "trusted" annotation on the function declaration corresponding to the function definition. Repository: rL LLVM https://reviews.llvm.org/D34937 Files:

[PATCH] D35448: [Bash-autocompletion] Fixed a bug on bash

This revision was automatically updated to reflect the committed changes. Closed by commit rL308091: [Bash-autocompletion] Fixed a bug on bash (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D35448?vs=106752=106762#toc Repository: rL LLVM

r308091 - [Bash-autocompletion] Fixed a bug on bash

Author: yamaguchi Date: Sat Jul 15 02:09:51 2017 New Revision: 308091 URL: http://llvm.org/viewvc/llvm-project?rev=308091=rev Log: [Bash-autocompletion] Fixed a bug on bash Summary: Maybe I mismerged when merging previous commits by hand. Differential Revision: https://reviews.llvm.org/D35448

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

teemperor added a comment. @yamaguchi yes, the reason why we have to treat the `-W...` flags specially should be documented (as they're not in the OptTable as you said). E.g. something like `// We have to query the -W flags manually as they're not in the OptTable.` and then maybe a `TODO: Find

[PATCH] D26350: Keep invalid Switch in the AST

ogoffart added a comment. Thanks for your review and i'll try to address the concerns. I believe tools that really need valid code relies on the diagnostics and bail out on error. On the other hand, tools that may work on code containing error do a best effort to work on the remaining AST .

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. It seems the code doesn't compile in clang because on your platform `std::vector` is implicitly included by some header, on clang+Arch however it isn`t (see the error at the

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

alexfh added a comment. I have deja vu ;) Should we make a single check for all CLOEXEC and friends with a single configurable list of (function name, flag name) pairs? https://reviews.llvm.org/D35372 ___ cfe-commits mailing list

[PATCH] D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. See the comment on https://reviews.llvm.org/D35372. https://reviews.llvm.org/D35370 ___ cfe-commits mailing list

[PATCH] D35450: [analyzer] Support generating and reasoning over more symbolic constraint types

ddcc added a comment. Compared with https://reviews.llvm.org/D28953, this revision fixes the test failure with `PR3991.m` with RangeConstraintManager, and a few other failures with Z3ConstraintManager. However, there's one remaining test failure in `range_casts.c` that I'm not sure how to

[PATCH] D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. See the comment on https://reviews.llvm.org/D35372. https://reviews.llvm.org/D35367 ___ cfe-commits mailing list

[PATCH] D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module.

alexfh added a comment. See the comment on https://reviews.llvm.org/D35372. Repository: rL LLVM https://reviews.llvm.org/D35364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. See the comment on https://reviews.llvm.org/D35372. https://reviews.llvm.org/D35365 ___ cfe-commits mailing list

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

rjmccall added a comment. In https://reviews.llvm.org/D32210#810292, @ahatanak wrote: > Address review comments. > > - Allow attaching "noescape" to pointers other than block pointers. Update > the docs accordingly. > - Attach attribute "nocapture" to parameters that are annotated with >

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

yamaguchi added a comment. @teemperor I forgot to include in DiagnosticIDs, thanks! What do you mean `reuse the normal flags` ? Do you think we should define these -W in Options.td like other flags? https://reviews.llvm.org/D35447 ___

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

fhahn abandoned this revision. fhahn added a comment. My understanding is that https://reviews.llvm.org/D35436 prevents the case described in this review from happening. Thanks for having a look! https://reviews.llvm.org/D35081 ___ cfe-commits

r308092 - Use ARC parsing rules for ns_returns_retained in MRC so that code can

Author: rjmccall Date: Sat Jul 15 04:06:46 2017 New Revision: 308092 URL: http://llvm.org/viewvc/llvm-project?rev=308092=rev Log: Use ARC parsing rules for ns_returns_retained in MRC so that code can be shared without warnings. Build AttributedTypes to leave breadcrumbs for tools like the static

[PATCH] D35454: [c++2a] Add option -std=c++2a to enable support for potential/transitional C++2a features

faisalv created this revision. faisalv added a project: clang. At the optimistic least, I'm hoping to get around to adding support for familiar template syntax to lambdas and vaopt to the preprocessor, under it. Repository: rL LLVM https://reviews.llvm.org/D35454 Files:

[PATCH] D35454: [c++2a] Add option -std=c++2a to enable support for potential/transitional C++2a features

faisalv updated this revision to Diff 106777. faisalv added a comment. Remove some erroneously included fragments (patches to Sema) of a future potential patch. https://reviews.llvm.org/D35454 Files: include/clang/Basic/LangOptions.def include/clang/Frontend/LangStandard.h

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru updated this revision to Diff 106778. https://reviews.llvm.org/D34824 Files: docs/ClangFormat.rst docs/ReleaseNotes.rst test/Format/verbose.cpp tools/clang-format/ClangFormat.cpp Index: tools/clang-format/ClangFormat.cpp

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru marked 7 inline comments as done. sylvestre.ledru added inline comments. Comment at: test/Format/verbose.cpp:2 +// RUN: clang-format %s -verbose | FileCheck %s +// CHECK: Formatting + djasper wrote: > This seems like a pretty minimal test to me.

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache added a comment. Friendly ping! I'm pretty excited about this change, it helps a pet project of mine, which builds Clang and LLVM checked out as submodules, display correct revision information. Let me know if I can modify this change at all, to make it easier to accept.

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I have a last request in my inline comment regarding the documentation, otherwise this is good to go. Nice work! Comment at:

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

ruiu accepted this revision. ruiu added a comment. LGTM Comment at: clang/lib/Driver/Driver.cpp:1283 + for (StringRef S : DiagnosticIDs::getDiagnosticFlags()) +if (StringRef(S).startswith(PassedFlags)) + SuggestedCompletions.push_back(S);

[PATCH] D35449: [X86] Implement __builtin_cpu_is

RKSimon added a comment. I don't have much experience with this builtin - does gcc use it for anything but x86? google didn't turn up much. https://reviews.llvm.org/D35449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35454: [c++2a] Add option -std=c++2a to enable support for potential/transitional C++2a features

aaron.ballman added a comment. Has GCC picked the same name for their language standard? I want to make sure we're consistent there (and think this is the correct name). https://reviews.llvm.org/D35454 ___ cfe-commits mailing list

[PATCH] D35454: [c++2a] Add option -std=c++2a to enable support for potential/transitional C++2a features

faisalv added a comment. Hmm - good point - not sure about the best way to confirm that... I'm fairly sure Jason said something during a discussion with me (about the additional template syntax to lambdas) in which he referred to gcc as already having a "C++2a feature" - and so i just inferred

Getting Started docs need updating with libcxxabi

http://clang.llvm.org/get_started.html Missing instructions to checkout llvm/projects/libcxxabi (now needed). Howard signature.asc Description: Message signed with OpenPGP ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28954: [analyzer] Add support for symbolic float expressions

dcoughlin added a comment. This looks like a very solid start! One area that I'm very worried about is that in various places the analyzer makes assumptions about algebraic simplifications that don't hold for floating point because of NaN and other floating point oddities. I think it really

[PATCH] D35449: [X86] Implement __builtin_cpu_is

craig.topper added a comment. I think gcc supports __builtin_cpu_supports and __builtin_cpu_is for non-x86. We already have an x86 only implementation of __builtin_cpu_supports so I did the same here. https://reviews.llvm.org/D35449 ___

[PATCH] D35454: [c++2a] Add option -std=c++2a to enable support for potential/transitional C++2a features

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small commenting nit. Comment at: lib/Frontend/InitPreprocessor.cpp:377 } else { +// FIXME: Use correct value for C++20 +if

r308099 - [cxx_status] Add approved Toronto WG21 motions.

Author: rsmith Date: Sat Jul 15 08:42:36 2017 New Revision: 308099 URL: http://llvm.org/viewvc/llvm-project?rev=308099=rev Log: [cxx_status] Add approved Toronto WG21 motions. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL:

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

yamaguchi updated this revision to Diff 106774. yamaguchi added a comment. Fixed indent. https://reviews.llvm.org/D35447 Files: clang/include/clang/Basic/DiagnosticIDs.h clang/lib/Basic/DiagnosticIDs.cpp clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c Index:

[libcxx] r308097 - Update issues moved in Toronto

Author: marshall Date: Sat Jul 15 08:22:21 2017 New Revision: 308097 URL: http://llvm.org/viewvc/llvm-project?rev=308097=rev Log: Update issues moved in Toronto Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

r308101 - [cxx_status] Fix typos.

Author: rsmith Date: Sat Jul 15 08:51:59 2017 New Revision: 308101 URL: http://llvm.org/viewvc/llvm-project?rev=308101=rev Log: [cxx_status] Fix typos. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL:

r308118 - [c++2a] Add option -std=c++2a to enable support for potential/transitional C++2a features

Author: faisalv Date: Sat Jul 15 17:23:04 2017 New Revision: 308118 URL: http://llvm.org/viewvc/llvm-project?rev=308118=rev Log: [c++2a] Add option -std=c++2a to enable support for potential/transitional C++2a features - as usual C++2a implies all the C++'s that came before it. Thank you Aaron

[PATCH] D35454: [c++2a] Add option -std=c++2a to enable support for potential/transitional C++2a features

faisalv closed this revision. faisalv marked an inline comment as done. faisalv added a comment. Committed here https://reviews.llvm.org/rL308118 Thanks! https://reviews.llvm.org/D35454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org