[PATCH] D35603: [Driver] Consider -fno-sanitize=... state when filtering out -fsanitize-coverage=...

2017-07-20 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r308593 - clang/module.modulemap: Clang_Diagnostics: Activate "Sema/SemaDiagnostic.h".

2017-07-20 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Thu Jul 20 00:51:47 2017 New Revision: 308593 URL: http://llvm.org/viewvc/llvm-project?rev=308593=rev Log: clang/module.modulemap: Clang_Diagnostics: Activate "Sema/SemaDiagnostic.h". It seems issues were resolved. Modified: cfe/trunk/include/clang/module.modulemap

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

2017-07-20 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Hmm. Could you invert those conditions so that they early-return, just for consistency? Sorry this is dragging out so long, and thanks for being so patient. Comment at: lib/CodeGen/TargetInfo.cpp:2357 +return; +

r308587 - clang/module.modulemap: Split out Clang_RewriteFrontend from Clang_Rewrite.

2017-07-20 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Wed Jul 19 23:08:53 2017 New Revision: 308587 URL: http://llvm.org/viewvc/llvm-project?rev=308587=rev Log: clang/module.modulemap: Split out Clang_RewriteFrontend from Clang_Rewrite. FIXME: Both Rewrite(Core) and RewriteFrontend don't cover just under clang/Rewrite.

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

2017-07-20 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan updated this revision to Diff 107446. atanasyan added a comment. My bad. I did not read your comment thoroughly. - Restore `IsForDefinition` checkings in `WinX86_32TargetCodeGenInfo::setTargetAttributes` and `WindowsARMTargetCodeGenInfo::setTargetAttributes` methods. Repository:

[PATCH] D35661: [clang] Implement P0704: "Fixing const-qualified pointers to members"

2017-07-20 Thread Anton Bikineev via Phabricator via cfe-commits
AntonBikineev created this revision. https://reviews.llvm.org/D35661 Files: lib/Sema/SemaExprCXX.cpp test/CXX/expr/expr.mptr.oper/p7-1z.cpp Index: test/CXX/expr/expr.mptr.oper/p7-1z.cpp === ---

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

2017-07-20 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan updated this revision to Diff 107461. atanasyan added a comment. Addressed review comments. Repository: rL LLVM https://reviews.llvm.org/D35479 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h

[PATCH] D35613: Add Support for Generic Reference Counting Annotations in RetainCountChecker

2017-07-20 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:2012 + } else if (CurrV.getObjKind() == RetEffect::GenericC) { +if (Sym->getType().isNull()) { + os << " returns an object with a "; malhar1995 wrote:

[PATCH] D35613: Add Support for Generic Reference Counting Annotations in RetainCountChecker

2017-07-20 Thread Malhar Thakkar via Phabricator via cfe-commits
malhar1995 added inline comments. Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:2012 + } else if (CurrV.getObjKind() == RetEffect::GenericC) { +if (Sym->getType().isNull()) { + os << " returns an object with a "; NoQ wrote:

[PATCH] D35674: [analyzer] Treat C++ throw as sink during CFG-based suppress-on-sink.

2017-07-20 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. Because throws produce sinks during symbolic execution, we need to treat them as noreturn during our suppress-on-sink analysis as well. This would get a lot less conservative when CFG actually supports exceptions. https://reviews.llvm.org/D35674 Files:

r308604 - [vfs] Assert that the status is known in equivalent().

2017-07-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Jul 20 04:57:02 2017 New Revision: 308604 URL: http://llvm.org/viewvc/llvm-project?rev=308604=rev Log: [vfs] Assert that the status is known in equivalent(). Otherwise we'd silently compare uninitialized data. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp

r308592 - Revert "[StaticAnalyzer] Completely unrolling specific loops with known bound option"

2017-07-20 Thread Peter Szecsi via cfe-commits
Author: szepet Date: Thu Jul 20 00:35:11 2017 New Revision: 308592 URL: http://llvm.org/viewvc/llvm-project?rev=308592=rev Log: Revert "[StaticAnalyzer] Completely unrolling specific loops with known bound option" Revert r308561 and r308558. Clang-ppc64be-linux seems to crash while running the

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

2017-07-20 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/tool/run-clang-tidy.py:96-98 + # Clang-tidy < 4.0.0 uses "Replacements" as a key to the list + # of replacements. Clang-tidy >= 4.0.0

[PATCH] D35329: [clang-reorder-fields] Enable reordering for plain C structs

2017-07-20 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D35329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r308619 - Reland "[mips] Teach the driver to accept -m(no-)gpopt."

2017-07-20 Thread Simon Dardis via cfe-commits
Author: sdardis Date: Thu Jul 20 07:04:12 2017 New Revision: 308619 URL: http://llvm.org/viewvc/llvm-project?rev=308619=rev Log: Reland "[mips] Teach the driver to accept -m(no-)gpopt." This patch teaches the driver to pass -mgpopt by default to the backend when it is supported, i.e. we are

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

2017-07-20 Thread Chad Rosier via Phabricator via cfe-commits
mcrosier added reviewers: echristo, ddunbar. mcrosier added subscribers: echristo, ddunbar. mcrosier added a comment. Adding @echristo and @ddunbar who have been the primary owners of the driver for the past decade or so. https://reviews.llvm.org/D35578

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

2017-07-20 Thread Chad Rosier via Phabricator via cfe-commits
mcrosier added subscribers: echristo, ddunbar, mcrosier. mcrosier added reviewers: echristo, ddunbar. mcrosier added a comment. Adding @echristo and @ddunbar who have been the primary owners of the driver for the past decade or so. https://reviews.llvm.org/D35577

[PATCH] D35682: Fixed failing assert in code completion.

2017-07-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. The code was accessing uninstantiated default argument. This resulted in failing assertion at ParamVarDecl::getDefaultArg(). https://reviews.llvm.org/D35682 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/uninstantiated_params.cpp Index:

[PATCH] D35673: [analyzer] A better CFG-based suppress-on-sink.

2017-07-20 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. Because https://reviews.llvm.org/D28023 wasn't enough, as i've just seen an assertion-like macro with as many as 12 CFG blocks (including `do..while(false)` loops), i mocked up a quick CFG depth-first search to easily detect blocks dominated by noreturn blocks.

[PATCH] D35051: [clang-tidy] Add bugprone-undefined-memory-manipulation check.

2017-07-20 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. The top of stack trace is: clang::CXXRecordDecl::isTriviallyCopyable() (unknown) clang::tidy::bugprone::(anonymous namespace)::internal::matcher_isNotTriviallyCopyableMatcher::matches() Repository: rL LLVM https://reviews.llvm.org/D35051

[PATCH] D35483: clang-format: fix block OpeningLineIndex around preprocessor

2017-07-20 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:464 + for (const auto : PPStack) { +hash_combine(h, i.Kind); +hash_combine(h, i.Line); When I patch this, I get an `UnwrappedLineParser.cpp:457:16 error: implicit

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

2017-07-20 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. I wonder whether anyone uses file patterns that need anything from regular expressions beyond `|` and `.*`. If not, globs (as used in -checks=) would be a better solution. One problem with a header-filter + exclude-header-filter is that it doesn't make it easier to

[PATCH] D35051: [clang-tidy] Add bugprone-undefined-memory-manipulation check.

2017-07-20 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. FYI, bugprone-undefined-memory-manipulation crashes on some of our code. I guess, this happens with dependent types, but I don't have an isolated repro yet. Repository: rL LLVM https://reviews.llvm.org/D35051 ___

[PATCH] D35613: Add Support for Generic Reference Counting Annotations in RetainCountChecker

2017-07-20 Thread Malhar Thakkar via Phabricator via cfe-commits
malhar1995 updated this revision to Diff 107471. malhar1995 added a comment. Removed the checks to see if the symbol type is NULL while printing diagnostics as they are unnecessary. Repository: rL LLVM https://reviews.llvm.org/D35613 Files:

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

2017-07-20 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. > In our project we want to do something like include src/.*.h but exclude > src/some-thirdparty/.*.h. There are at least two other possibilities to handle this use case. The first one is to extend the way clang-tidy handles per-directory configs. Currently, for each

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

2017-07-20 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In https://reviews.llvm.org/D24892#733016, @alexfh wrote: > In https://reviews.llvm.org/D24892#732243, @malcolm.parsons wrote: > > > In https://reviews.llvm.org/D24892#732217,

[PATCH] D35678: Omit sumbodule semantics for TS modules

2017-07-20 Thread Boris Kolpackov via Phabricator via cfe-commits
boris created this revision. If a TS module name has more than one component (e.g., foo.bar) then we erroneously activate the submodule semantics when encountering a module declaration in the module implementation unit (e.g., module foo.bar;). https://reviews.llvm.org/D35678 Files:

[PATCH] D34748: [clang-diff] improve mapping accuracy, HTML side-by-side diff.

2017-07-20 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes updated this revision to Diff 107479. johannes retitled this revision from "[clang-diff] Fix multiple mappings." to "[clang-diff] improve mapping accuracy, HTML side-by-side diff.". Herald added a subscriber: mgorny. https://reviews.llvm.org/D34748 Files:

[clang-tools-extra] r308605 - [clang-tidy] Unify the way IncludeStyle and HeaderFileExtesions options are used

2017-07-20 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Thu Jul 20 05:02:03 2017 New Revision: 308605 URL: http://llvm.org/viewvc/llvm-project?rev=308605=rev Log: [clang-tidy] Unify the way IncludeStyle and HeaderFileExtesions options are used Modified:

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

2017-07-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:167 +std::move(VFS)); + CI->getFrontendOpts().DisableFree = false; + return CI; krasimir wrote: > Why `DisableFree`? We rely on CompilerInstance

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

2017-07-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 107475. ilya-biryukov added a comment. Added a few comments. https://reviews.llvm.org/D35406 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h Index: clangd/ClangdUnit.h

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

2017-07-20 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D33277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32047: [Driver] Add support for default UBSan blacklists

2017-07-20 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. I'd like to address the current problems with sanitizer blacklists before moving on to this patch: https://reviews.llvm.org/D32842 The summary is that the entries in a blacklist file apply to all sanitizers, resulting in potential false negatives when multiple default

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-20 Thread Anton Korobeynikov via Phabricator via cfe-commits
asl added a comment. In https://reviews.llvm.org/D34440#809525, @alexfh wrote: > In https://reviews.llvm.org/D34440#808156, @vladimir.plyashkun wrote: > > > **To discuss:** > > ... > > By this moment, we unable to use //CompilationDatabase.json// from //CLion > > //side which is widely used

r308641 - [Docs] Regenerate the command line option reference.

2017-07-20 Thread Craig Topper via cfe-commits
Author: ctopper Date: Thu Jul 20 10:52:48 2017 New Revision: 308641 URL: http://llvm.org/viewvc/llvm-project?rev=308641=rev Log: [Docs] Regenerate the command line option reference. Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst

[PATCH] D35426: [clang] Add abi-breaking-checks support to clang

2017-07-20 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added a comment. Ping for reviews please. https://reviews.llvm.org/D35426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

2017-07-20 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, that looks great! Repository: rL LLVM https://reviews.llvm.org/D35479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 107539. krasimir marked 3 inline comments as done. krasimir added a comment. - Address review comments https://reviews.llvm.org/D35683 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp

r308629 - [OPENMP] Fix DSA processing for member declaration.

2017-07-20 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jul 20 09:47:47 2017 New Revision: 308629 URL: http://llvm.org/viewvc/llvm-project?rev=308629=rev Log: [OPENMP] Fix DSA processing for member declaration. If the member declaration is captured in the OMPCapturedExprDecl, we may loose data-sharing attribute info for this

[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Martin Probst via Phabricator via cfe-commits
mprobst accepted this revision. mprobst added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/BreakableToken.cpp:436 + if (Style.Language == FormatStyle::LK_JavaScript) { +if ((Lines[0] == "*" || Lines[0].startswith("* ")) &&

Re: r308641 - [Docs] Regenerate the command line option reference.

2017-07-20 Thread Craig Topper via cfe-commits
Hans, This needs to be ported to the 5.0 branch. Not sure if any new options have been added to 6.0 since the branch that would make this patch not correct. Probably safest to just regenerate it in the 5.0 branch. ~Craig On Thu, Jul 20, 2017 at 10:52 AM, Craig Topper via cfe-commits <

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

2017-07-20 Thread Yan Wang via Phabricator via cfe-commits
yawanng updated this revision to Diff 107557. yawanng added a comment. Refactor the check, add a base class for it, which can facilitate all other similar checks. Basically, all checks in the same category will have only one or two lines code by inheriting the base class. If this looks good, I

[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir marked 2 inline comments as done. krasimir added inline comments. Comment at: lib/Format/BreakableToken.cpp:435 + // Detect a multiline jsdoc comment and set DelimitersOnNewline in that case. + if (Style.Language == FormatStyle::LK_JavaScript) { +if ((Lines[0] ==

[PATCH] D33852: Enable __declspec(selectany) on linux

2017-07-20 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: include/clang/Basic/Attr.td:2421 -def SelectAny : InheritableAttr, TargetSpecificAttr { +def SelectAny : InheritableAttr, TargetSpecificAttr { let Spellings = [Declspec<"selectany">, GCC<"selectany">]; Prazek wrote: >

[PATCH] D35652: [clang] Fix handling of "%zd" format specifier in scanf

2017-07-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small testing nit. Comment at: test/Sema/format-strings-scanf.c:1 -// RUN: %clang_cc1 -fsyntax-only -verify -Wformat-nonliteral %s +// RUN:

[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Martin Probst via Phabricator via cfe-commits
mprobst added inline comments. Comment at: lib/Format/BreakableToken.cpp:435 + // Detect a multiline jsdoc comment and set DelimitersOnNewline in that case. + if (Style.Language == FormatStyle::LK_JavaScript) { +if ((Lines[0] == "*" || Lines[0].startswith("* ")) &&

[clang-tools-extra] r308621 - [clang-tidy] s/1/true/, NFC

2017-07-20 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Thu Jul 20 07:56:52 2017 New Revision: 308621 URL: http://llvm.org/viewvc/llvm-project?rev=308621=rev Log: [clang-tidy] s/1/true/, NFC Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp Modified:

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

2017-07-20 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11846 // an address space. if (T.getAddressSpace() != 0) { // OpenCL allows function arguments declared to be an array of a type yaxunl wrote: > Anastasia wrote: > > yaxunl wrote: > >

r308714 - Fix tblgen error.

2017-07-20 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Thu Jul 20 21:56:48 2017 New Revision: 308714 URL: http://llvm.org/viewvc/llvm-project?rev=308714=rev Log: Fix tblgen error. tblgen couldn't determing a unique name between "long_call" and "far", so it errored out when generating documentation. Copy the documentation, and

[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 107593. krasimir marked an inline comment as done. krasimir added a comment. - Add negative tests https://reviews.llvm.org/D35683 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp

[PATCH] D35705: [CMake] Use ABI version 2 for C++ library

2017-07-20 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D35705 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === ---

[PATCH] D35709: Remove Bitrig: CompilerRT Changes

2017-07-20 Thread Eric Christopher via Phabricator via cfe-commits
echristo accepted this revision. echristo added a comment. LGTM. https://reviews.llvm.org/D35709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35708: Remove Bitrig: Clang Changes

2017-07-20 Thread Eric Christopher via Phabricator via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35603: [Driver] Consider -fno-sanitize=... state when filtering out -fsanitize-coverage=...

2017-07-20 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308707: [Driver] Consider -fno-sanitize=... state when filtering out -fsanitizeā€¦ (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35603?vs=107234=107620#toc Repository: rL

r308707 - [Driver] Consider -fno-sanitize=... state when filtering out -fsanitize-coverage=...

2017-07-20 Thread Petr Hosek via cfe-commits
Author: phosek Date: Thu Jul 20 18:17:49 2017 New Revision: 308707 URL: http://llvm.org/viewvc/llvm-project?rev=308707=rev Log: [Driver] Consider -fno-sanitize=... state when filtering out -fsanitize-coverage=... The driver ignores -fsanitize-coverage=... flags when also given -fsanitize=...

[PATCH] D35708: Remove Bitrig: Clang Changes

2017-07-20 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. Herald added subscribers: javed.absar, mgorny. Bitrig code has been merged back to OpenBSD, thus the OS has been abandoned. https://reviews.llvm.org/D35708 Files: lib/Basic/Targets.cpp lib/Basic/Targets/ARM.h lib/Basic/Targets/OSTargets.h

[PATCH] D35715: Preserve typedef names in debug info for template type parameters

2017-07-20 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added inline comments. Comment at: include/clang/AST/PrettyPrinter.h:205 + + /// \brief When true, print template type arguments without removing typedefs. + unsigned PrintTemplateTypesWithTypedefs : 1; `\brief` is no longer necessary and just makes

r308683 - [mips] Add support for -m(no-)local-sdata

2017-07-20 Thread Simon Dardis via cfe-commits
Author: sdardis Date: Thu Jul 20 15:23:21 2017 New Revision: 308683 URL: http://llvm.org/viewvc/llvm-project?rev=308683=rev Log: [mips] Add support for -m(no-)local-sdata Teach the driver to support -mlocal-sdata. The backend already matches GCC's default behaviour. Reviewers: atanasyan,

[PATCH] D35693: [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions

2017-07-20 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Does the ARM64 ABI call for unwind tables to be emitted for all functions, like the x86-64 ABI does? Anyway, it seems pretty unfortunate that the default behavior breaks exceptions. https://reviews.llvm.org/D35693 ___

[PATCH] D35709: Remove Bitrig: CompilerRT Changes

2017-07-20 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. Bitrig code has been merged back to OpenBSD, thus the OS has been abandoned. https://reviews.llvm.org/D35709 Files: lib/builtins/clear_cache.c lib/builtins/int_endianness.h test/builtins/Unit/endianness.h Index: test/builtins/Unit/endianness.h

r308684 - [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Thu Jul 20 15:29:39 2017 New Revision: 308684 URL: http://llvm.org/viewvc/llvm-project?rev=308684=rev Log: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs Reviewers: mprobst Reviewed By: mprobst Subscribers: cfe-commits, klimek Differential Revision:

[PATCH] D35683: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs

2017-07-20 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308684: [clang-format] Put '/**' and '*/' on own lines in multiline jsdocs (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D35683 Files: cfe/trunk/lib/Format/BreakableToken.cpp

[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

2017-07-20 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In https://reviews.llvm.org/D35701#816721, @krytarowski wrote: > In https://reviews.llvm.org/D35701#816703, @erichkeane wrote: > > > In https://reviews.llvm.org/D35701#816680, @krytarowski wrote: > > > > > Bitrig has to be eliminated - it's dead upstream and will be

[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

2017-07-20 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. In https://reviews.llvm.org/D35701#816703, @erichkeane wrote: > In https://reviews.llvm.org/D35701#816680, @krytarowski wrote: > > > Bitrig has to be eliminated - it's dead upstream and will be removed from > > LLVM. (confirmed from ex developers, nobody needs it

[PATCH] D35705: [CMake] Use ABI version 2 for C++ library

2017-07-20 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

2017-07-20 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. So, what's the overall logical idea behind the need for this option? While I understand that you don't want people just doing this via the -mllvm set of options, but if you're just doing this to provide a temporary option rather than turning it off in the backend I'm

[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

2017-07-20 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Just review blank lines between every function. I'm too lazy to keep marking them. Comment at: lib/Basic/Targets/AArch64.cpp:20 +using namespace clang::targets; +const char *const AArch64TargetInfo::GCCRegNames[] = { +// 32-bit Integer

[PATCH] D35705: [CMake] Use ABI version 2 for C++ library in Fuchsia

2017-07-20 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308705: [CMake] Use ABI version 2 for C++ library in Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35705?vs=107600=107617#toc Repository: rL LLVM

[PATCH] D35715: Preserve typedef names in debug info for template type parameters

2017-07-20 Thread Paul Robinson via Phabricator via cfe-commits
probinson created this revision. If a template instantiation uses a typedef'd name as a template parameter, this is usually resolved to its underlying type when we generate the name of the instance in the debug info. PS4 prefers to see the original parameter as in the source. Define an option

[PATCH] D35549: [mips] Add support for -m(no-)local-sdata

2017-07-20 Thread Simon Dardis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308683: [mips] Add support for -m(no-)local-sdata (authored by sdardis). Changed prior to commit: https://reviews.llvm.org/D35549?vs=107071=107592#toc Repository: rL LLVM

r308705 - [CMake] Use ABI version 2 for C++ library in Fuchsia

2017-07-20 Thread Petr Hosek via cfe-commits
Author: phosek Date: Thu Jul 20 17:59:38 2017 New Revision: 308705 URL: http://llvm.org/viewvc/llvm-project?rev=308705=rev Log: [CMake] Use ABI version 2 for C++ library in Fuchsia Fuchsia has always been using ABI version 2 but I forgot this option when setting up the cache file for runtimes

[PATCH] D35718: [clang-tidy] Do not issue fixit for explicit template specializations

2017-07-20 Thread Felix Berger via Phabricator via cfe-commits
flx created this revision. Herald added subscribers: xazax.hun, JDevlieghere. Do not issue fixit in UnnecessaryValueParamCheck if the function is an explicit template specialization as this could cause build breakages. Repository: rL LLVM https://reviews.llvm.org/D35718 Files:

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

2017-07-20 Thread Michael F. Herbst via Phabricator via cfe-commits
mfherbst updated this revision to Diff 107633. mfherbst added a comment. Remove compatiblity with clang-tidy < 4.0.0 https://reviews.llvm.org/D31326 Files: run-clang-tidy.py Index: run-clang-tidy.py === --- run-clang-tidy.py

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

2017-07-20 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre updated this revision to Diff 107632. mgehre marked 3 inline comments as done. mgehre added a comment. Herald added subscribers: kbarton, xazax.hun, JDevlieghere. Implemented all review comments Use global settings "UseAssignment" https://reviews.llvm.org/D24892 Files:

r308662 - [clang] Fix handling of "%zd" in scanf

2017-07-20 Thread Alexander Shaposhnikov via cfe-commits
Author: alexshap Date: Thu Jul 20 13:11:47 2017 New Revision: 308662 URL: http://llvm.org/viewvc/llvm-project?rev=308662=rev Log: [clang] Fix handling of "%zd" in scanf This diff addresses FIXMEs in lib/Analysis/ScanfFormatString.cpp for the case of ssize_t format specifier and adds tests. In

[PATCH] D35652: [clang] Fix handling of "%zd" format specifier in scanf

2017-07-20 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308662: [clang] Fix handling of "%zd" in scanf (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D35652?vs=107569=107574#toc Repository: rL LLVM

r308667 - [CodeGen][mips] Support `long_call/far/near` attributes

2017-07-20 Thread Simon Atanasyan via cfe-commits
Author: atanasyan Date: Thu Jul 20 13:34:18 2017 New Revision: 308667 URL: http://llvm.org/viewvc/llvm-project?rev=308667=rev Log: [CodeGen][mips] Support `long_call/far/near` attributes This patch adds support for the `long_call`, `far`, and `near` attributes for MIPS targets. The `long_call`

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

2017-07-20 Thread Simon Atanasyan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308667: [CodeGen][mips] Support `long_call/far/near` attributes (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D35479?vs=107461=107578#toc Repository: rL LLVM

r308675 - [NVPTX] Add lowering of i128 params.

2017-07-20 Thread Artem Belevich via cfe-commits
Author: tra Date: Thu Jul 20 14:16:03 2017 New Revision: 308675 URL: http://llvm.org/viewvc/llvm-project?rev=308675=rev Log: [NVPTX] Add lowering of i128 params. The patch adds support of i128 params lowering. The changes are quite trivial to support i128 as a "special case" of integer type.

[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

2017-07-20 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. Bitrig has to be eliminated - it's dead upstream and will be removed from LLVM. (confirmed from ex developers, nobody needs it any more) https://reviews.llvm.org/D35701 ___ cfe-commits mailing list

[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

2017-07-20 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover added a comment. > I tended to keep function definitions in the class declaration unless it > caused additional includes to be necessary. Was that for implementation simplicity, or part of some cunning design goal? A lot of these pairs look pretty header-heavy to me (especially

[PATCH] D35693: [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions

2017-07-20 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. Herald added subscribers: kristof.beyls, aemerson. When I compile the following code targeting arm64 and execute it, it terminates with an uncaught exception: "libc++abi.dylib: terminating with uncaught exception of type int": int foo1() noexcept { try {

[PATCH] D35652: [clang] Fix handling of "%zd" format specifier in scanf

2017-07-20 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap updated this revision to Diff 107569. alexshap added a comment. Address comments Repository: rL LLVM https://reviews.llvm.org/D35652 Files: lib/Analysis/ScanfFormatString.cpp test/Sema/format-strings-fixit-ssize_t.c test/Sema/format-strings-scanf.c Index:

[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

2017-07-20 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In https://reviews.llvm.org/D35701#816678, @t.p.northover wrote: > > I tended to keep function definitions in the class declaration unless it > > caused additional includes to be necessary. > > Was that for implementation simplicity, or part of some cunning design

[clang-tools-extra] r308678 - [clang-tools-extra] Add support for plain C structs in clang-reorder-fields

2017-07-20 Thread Alexander Shaposhnikov via cfe-commits
Author: alexshap Date: Thu Jul 20 14:41:20 2017 New Revision: 308678 URL: http://llvm.org/viewvc/llvm-project?rev=308678=rev Log: [clang-tools-extra] Add support for plain C structs in clang-reorder-fields This diff updates the tool clang-reorder-fields to enable reordering of fields of plain C

[PATCH] D35329: [clang-reorder-fields] Enable reordering for plain C structs

2017-07-20 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308678: [clang-tools-extra] Add support for plain C structs in clang-reorder-fields (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D35329?vs=107143=107588#toc Repository:

[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

2017-07-20 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In https://reviews.llvm.org/D35701#816680, @krytarowski wrote: > Bitrig has to be eliminated - it's dead upstream and will be removed from > LLVM. (confirmed from ex developers, nobody needs it any more) I just did a bit of looking about, and noticed that the