[PATCH] D37287: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

craig.topper created this revision. This patch implements the broadcastf32x2/broadcasti32x2 intrinsics using __builtin_shufflevector. https://reviews.llvm.org/D37287 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512dqintrin.h lib/Headers/avx512vldqintrin.h

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris marked 2 inline comments as done. boris added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:986 +if (Val.find('=') == StringRef::npos) + Opts.ExtraDeps.push_back(Val); + } rsmith wrote: > Does a module file specified via

[PATCH] D37287: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

aymanmus accepted this revision. aymanmus added a comment. This revision is now accepted and ready to land. LGTM Thanks for the 2 patches. https://reviews.llvm.org/D37287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37287: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

craig.topper added a comment. Yes I did. With the other bug fixed they all produced the correct instruction. https://reviews.llvm.org/D37287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:26 } throw non_derived_exception(); // Bad + // CHECK-MESSAGES: [[@LINE-1]]:9: warning: throwing an exception whose type 'non_derived_exception' is not derived from

[PATCH] D37287: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

aymanmus added a comment. Did you make sure the resulted IR was lowered to the expected X86 instructions? https://reviews.llvm.org/D37287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r312102 - [clang-tidy] test commit for granted access

Author: jonastoth Date: Wed Aug 30 00:50:28 2017 New Revision: 312102 URL: http://llvm.org/viewvc/llvm-project?rev=312102=rev Log: [clang-tidy] test commit for granted access Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/NoMallocCheck.cpp Modified:

[PATCH] D37278: Restore clang_rt library name on i686-android.

mgorny added a comment. Thanks a lot for taking care of this. Repository: rL LLVM https://reviews.llvm.org/D37278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 113272. JonasToth marked 5 inline comments as done. JonasToth added a comment. - fix typos and bad language https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

aaron.ballman added a comment. In https://reviews.llvm.org/D36272#856722, @erichkeane wrote: > In https://reviews.llvm.org/D36272#856040, @anatol.pomozov wrote: > > > Hi Eric, thank you for your reply. Both these triples are currently broken, > > with my change and without. > > > > The

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth added a comment. language in the docuementation improved https://reviews.llvm.org/D36354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

On 30 August 2017 at 18:29, Jonas Toth wrote: > Hi Diana, > > i will investigate this issue. Can i see from somewhere, what email my > buildbot uses? I actually don't know if you can check anywhere, but in principle it should be the same address that the commit email came

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Hi Jonas, I haven't seen any commit from you (*) fixing the buildbot failures caused by your previous commit (r312122). This has been keeping several bots red for quite a while: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/10590

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Hello Diana, you are right, i did not commit anything earlier, I am really new to the process, these were my first commits. I am sorry that i broke the bots, i thought i would get an automatic mail, when they find a problem and i was in the commit range. Is there anything automated to find

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Hi Jonas, Usually the buildbots send emails when you're in the commit range. I'm surprised that you haven't received anything. Are you sure you don't have some mail filters that are catching them and sending them somewhere unexpected? In any case, you can see a live-but-slow buildbot status

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. In https://reviews.llvm.org/D36272#856849, @anatol.pomozov wrote: > > if we corrected the attribute spelling to be GCC instead of GNU and added > > some documentation to the attribute > > These are great suggestions! But I think it makes more sense to have a >

[PATCH] D37299: [Modules] Add ability to specify module name to module file mapping in a file

boris created this revision. Add the -fmodule-file-map=[=] option which can be used to specify a file that contains module name to precompiled modules files mapping, similar to -fmodule-file==. The can be used to only consider certain lines which can be useful if we want to store the mapping

[clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Author: jonastoth Date: Wed Aug 30 08:59:01 2017 New Revision: 312134 URL: http://llvm.org/viewvc/llvm-project?rev=312134=rev Log: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better Summary: This patch is a followup to the first revision D36583, that had problems with

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst:11 +The relevant sections in the `C++ Core Guidelines `_ are I.11, C.33, R.3 and GSL.Views +The

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood updated this revision to Diff 113271. hamzasood added a comment. Herald added a subscriber: klimek. Implemented pretty printing and recursive AST visiting (both with appropriate unit tests). The pretty printing implementation includes fixing a few printing bugs (which I needed fixed

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

On Wed, Aug 30, 2017 at 12:16 PM, Jonas Toth via cfe-commits wrote: > Hello Diana, > > you are right, i did not commit anything earlier, I am really new to the > process, these were my first commits. > > I am sorry that i broke the bots, i thought i would get an

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun added a comment. In https://reviews.llvm.org/D34512#856821, @benlangmuir wrote: > In https://reviews.llvm.org/D34512#856301, @xazax.hun wrote: > > > In https://reviews.llvm.org/D34512#856184, @dcoughlin wrote: > > > > > In either case, the important scenario I think we should support

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. > As I said, as long as BOTH windows versions have the same issue, I think _I_ > am OK with it. The tests fail at windows the same way. The only difference - "attribute is not supported at 64bit" compiler warning is gone with my change. > if we corrected the

[PATCH] D33852: Enable __declspec(selectany) on linux

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:2477 let Spellings = [Declspec<"selectany">, GCC<"selectany">]; let Documentation = [Undocumented]; } Prazek wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > Since

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! https://reviews.llvm.org/D37060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34512: Add preliminary Cross Translation Unit support library

benlangmuir added a comment. In https://reviews.llvm.org/D34512#856301, @xazax.hun wrote: > In https://reviews.llvm.org/D34512#856184, @dcoughlin wrote: > > > In either case, the important scenario I think we should support is > > choosing at a call site to a C function the most likely

[clang-tools-extra] r312141 - [clang-tidy] fix buildbot

Author: jonastoth Date: Wed Aug 30 10:21:41 2017 New Revision: 312141 URL: http://llvm.org/viewvc/llvm-project?rev=312141=rev Log: [clang-tidy] fix buildbot Use `signed char` instead of `char`. Modified: clang-tools-extra/trunk/test/clang-tidy/hicpp-signed-bitwise.cpp Modified:

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

aaron.ballman accepted this revision. aaron.ballman added a comment. In https://reviews.llvm.org/D36272#856857, @erichkeane wrote: > In https://reviews.llvm.org/D36272#856849, @anatol.pomozov wrote: > > > > if we corrected the attribute spelling to be GCC instead of GNU and added > > > some

[PATCH] D37287: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL312135: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using… (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D37287?vs=113199=113275#toc Repository: rL LLVM

r312135 - [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

Author: ctopper Date: Wed Aug 30 09:15:12 2017 New Revision: 312135 URL: http://llvm.org/viewvc/llvm-project?rev=312135=rev Log: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins This patch implements the broadcastf32x2/broadcasti32x2

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Hi Diana, i will investigate this issue. Can i see from somewhere, what email my buildbot uses? To fix the break I created a new Patch https://reviews.llvm.org/D37301 What is the right thing now, wait for review or just commit it and that review would occur on the commit? Thank you for

[clang-tools-extra] r312137 - clang-tools-extra/test/clang-tidy/hicpp-signed-bitwise.cpp: Appease *-win32 to add explicit triple.

Author: chapuni Date: Wed Aug 30 09:34:51 2017 New Revision: 312137 URL: http://llvm.org/viewvc/llvm-project?rev=312137=rev Log: clang-tools-extra/test/clang-tidy/hicpp-signed-bitwise.cpp: Appease *-win32 to add explicit triple. Modified:

[PATCH] D33852: Enable __declspec(selectany) on linux

Prazek added inline comments. Comment at: include/clang/Basic/Attr.td:2477 let Spellings = [Declspec<"selectany">, GCC<"selectany">]; let Documentation = [Undocumented]; } aaron.ballman wrote: > aaron.ballman wrote: > > Since we're drastically modifying

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth updated this revision to Diff 113213. JonasToth added a comment. fix patch, to diff against master again https://reviews.llvm.org/D37060 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exception-baseclass.cpp Index:

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 113217. JonasToth marked 5 inline comments as done. JonasToth added a comment. - fix spelling and grammar errors - adjust unit test to new diagnostics https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth added a comment. addressed some issues, not all yet https://reviews.llvm.org/D36354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes

arphaman updated this revision to Diff 113223. arphaman added a comment. Use `std::move` Repository: rL LLVM https://reviews.llvm.org/D37291 Files: include/clang/Tooling/Refactoring/RefactoringActionRule.h include/clang/Tooling/Refactoring/RefactoringActionRules.h

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

krasimir added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:89 + // if --compileCommands arg was invoked, check value and override default path + std::size_t found = CompileCommands.find_first_of("/"); + std::string TempString = CompileCommands;

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

NoQ added a comment. In https://reviews.llvm.org/D35216#856093, @rsmith wrote: > The `CXXStdInitializerListExpr` node has pretty simple evaluation semantics: > it takes a glvalue array expression, and constructs a > `std::initializer_list` from it as if by filling in the two members with a >

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

arphaman updated this revision to Diff 113224. arphaman marked an inline comment as done. arphaman added a comment. Herald added a reviewer: JonasToth. This revision now requires review to proceed. Rebase on top of https://reviews.llvm.org/D37291 Repository: rL LLVM

[PATCH] D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes

arphaman created this revision. Herald added a reviewer: JonasToth. This patch changes the way that the refactoring results are produced. Instead of using different `RefactoringActionRule` subclasses for each result type, we now use a single `RefactoringResultConsumer`. This was suggested by

[PATCH] D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes

arphaman updated this revision to Diff 113222. arphaman added a comment. Fixed a comment Repository: rL LLVM https://reviews.llvm.org/D37291 Files: include/clang/Tooling/Refactoring/RefactoringActionRule.h include/clang/Tooling/Refactoring/RefactoringActionRules.h

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

lebedev.ri updated this revision to Diff 113226. lebedev.ri added a comment. Rebased. Repository: rL LLVM https://reviews.llvm.org/D36892 Files: test/clang-tidy/check_clang_tidy.py Index: test/clang-tidy/check_clang_tidy.py

r312106 - [docs] Regenerate command line options reference

Author: borisk Date: Wed Aug 30 02:15:53 2017 New Revision: 312106 URL: http://llvm.org/viewvc/llvm-project?rev=312106=rev Log: [docs] Regenerate command line options reference Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst URL:

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:23 + const auto SignedIntegerOperand = + expr(ignoringImpCasts(hasType(isSignedInteger(.bind("signed_operand"); + JonasToth wrote: > aaron.ballman wrote: > >

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols marked 10 inline comments as done. rwols added a comment. I followed your advice and kept the snippet functionality. We'll do the SignatureHelp stuff in another review. A "major" change is that, because CK_Informative chunks are put into the label now, we have to use the insertText,

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri updated this revision to Diff 113228. lebedev.ri added a comment. Rebased. Repository: rL LLVM https://reviews.llvm.org/D36836 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp

r312105 - [modules] Add ability to specify module name to module file mapping

Author: borisk Date: Wed Aug 30 01:45:59 2017 New Revision: 312105 URL: http://llvm.org/viewvc/llvm-project?rev=312105=rev Log: [modules] Add ability to specify module name to module file mapping Extend the -fmodule-file option to support the [=] value format. If the name is omitted, then the

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rL312105: [modules] Add ability to specify module name to module file mapping (authored by borisk). Changed prior to commit: https://reviews.llvm.org/D35020?vs=111826=113207#toc Repository: rL LLVM

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun updated this revision to Diff 113206. xazax.hun added a comment. - Added unit test to ensure the produced index format can be parsed. - Added further diagnostics. https://reviews.llvm.org/D34512 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/CMakeLists.txt

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun added a comment. In https://reviews.llvm.org/D34512#856184, @dcoughlin wrote: > In either case, the important scenario I think we should support is choosing > at a call site to a C function the most likely definition of the called > function, based on number and type of parameters,

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

Alexander-Shukaev added a comment. Did anybody have a chance to review it and/or try it out? Repository: rL LLVM https://reviews.llvm.org/D15465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth updated this revision to Diff 113212. JonasToth marked 2 inline comments as done. JonasToth added a comment. - removing trailing comments https://reviews.llvm.org/D37060 Files: test/clang-tidy/hicpp-exception-baseclass.cpp Index: test/clang-tidy/hicpp-exception-baseclass.cpp

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth updated this revision to Diff 113214. JonasToth added a comment. struggling with arc... https://reviews.llvm.org/D37060 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exception-baseclass.cpp Index: test/clang-tidy/hicpp-exception-baseclass.cpp

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

nevion added a comment. I'm paying attention at least. I updated your patch prior to your posting and temporarily made due with it. I'm pretty nervous that I will lose work with my commit style and the lingering issue. Based on what I've seen so far I can't use the git hooks and so I want

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. Any news on this? cc @djasper Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols updated this revision to Diff 113219. rwols added a comment. Tidy up snippet handling - Put CK_Informative chunks in the label - Assert that there's at most one CK_ResultType chunk - CK_CurrentParameter never occurs while collecting completions, only while handling overloads. - For

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols added a comment. So at this point the C++ changes are basically done, save for some minor things I guess. The problem is still that the VSCode extension doesn't do anything clever with the snippets. I have zero experience with TypeScript let alone extension development for VSCode, so it

r312108 - Revert "Improve constant expression evaluation of arrays of unknown bound."

Author: mboehme Date: Wed Aug 30 03:44:46 2017 New Revision: 312108 URL: http://llvm.org/viewvc/llvm-project?rev=312108=rev Log: Revert "Improve constant expression evaluation of arrays of unknown bound." This reverts commit r311970. Breaks internal tests. Modified:

r312109 - Add test case that was broken by r311970.

Author: mboehme Date: Wed Aug 30 03:44:51 2017 New Revision: 312109 URL: http://llvm.org/viewvc/llvm-project?rev=312109=rev Log: Add test case that was broken by r311970. See also discussion here: https://reviews.llvm.org/rL301963 As far as I can tell, this discussion was never resolved.

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

hokein added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:29 +SourceChangeRefactoringRuleKind, +FindSymbolOccurrencesRefactoringRuleKind + }; I might miss some context here. As per your comment in

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:29 +SourceChangeRefactoringRuleKind, +FindSymbolOccurrencesRefactoringRuleKind + }; hokein wrote: > I might miss some context here. As per your comment

[PATCH] D33719: Add _Float16 as a C/C++ source language type

SjoerdMeijer updated this revision to Diff 113218. SjoerdMeijer added a comment. Comments addressed. Thanks for reviewing. https://reviews.llvm.org/D33719 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/Basic/Specifiers.h

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Thank you for working on this! I just tried, and the original false-positive i was hitting is now gone. So as far i'm concerned, this is good to go. Comment at:

[PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

rjmccall added a comment. In https://reviews.llvm.org/D33826#856652, @lebedev.ri wrote: > In https://reviews.llvm.org/D33826#856619, @Eugene.Zelenko wrote: > > > In https://reviews.llvm.org/D33826#856610, @lebedev.ri wrote: > > > > > Any status update here? :) > > > I generally do see a benefit

[PATCH] D37308: Interface class with uuid base record

erichkeane added a comment. 1- You need to do your diff with -U9 so that we get the full context of the file. 2- Better explain the issue in the description 3 SemaDeclCXX.cpp changes look like they need clang-format run on them. https://reviews.llvm.org/D37308

[PATCH] D37308: Interface class with uuid base record

zahiraam created this revision. Added support for interface inheriting from a uuid base record. https://reviews.llvm.org/D37308 Files: lib/Sema/SemaDeclCXX.cpp test/SemaCXX/ms-uuid.cpp Index: test/SemaCXX/ms-uuid.cpp === ---

r312167 - Let -Wdelete-non-virtual-dtor fire in system headers too.

Author: nico Date: Wed Aug 30 13:25:22 2017 New Revision: 312167 URL: http://llvm.org/viewvc/llvm-project?rev=312167=rev Log: Let -Wdelete-non-virtual-dtor fire in system headers too. Makes the warning useful again in a std::unique_ptr world, PR28460. Also make the warning not fire in

[PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.

thakis closed this revision. thakis added a comment. Thanks, landed in r312167. dblaikie: I believe the test can't be much simpler -- the pragma is file-based and having the main TU be marked as system header would be fairly different from what happens in real life even if it worked.

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Hi Aaron. Thank you very much for reviewing this patch. I'll be glad to add documentation for 'force_align_arg_pointer' attribute and upload another patch. But before doing it I would like to finish work on the current patch and make its forward progress toward

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. Current patch is ready. Guessing you do not have commit rights? https://reviews.llvm.org/D36272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

aaron.ballman added a comment. In https://reviews.llvm.org/D36272#857005, @anatol.pomozov wrote: > Hi Aaron. Thank you very much for reviewing this patch. > > I'll be glad to add documentation for 'force_align_arg_pointer' attribute and > upload another patch. But before doing it I would like

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. I have no commit permissions (this is my first patch to LLVM project). Ideally if someone of you merge it. If not then I'll ask a friend of mine who works on clang sanitizers to merge it. https://reviews.llvm.org/D36272

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. In https://reviews.llvm.org/D36272#857010, @anatol.pomozov wrote: > I have no commit permissions (this is my first patch to LLVM project). > Ideally if someone of you merge it. If not then I'll ask a friend of mine who > works on clang sanitizers to merge it. I'll

[clang-tools-extra] r312166 - [cppcoreguidelines] Don't rely on SmallPtrSet iteration order.

Author: d0k Date: Wed Aug 30 13:18:40 2017 New Revision: 312166 URL: http://llvm.org/viewvc/llvm-project?rev=312166=rev Log: [cppcoreguidelines] Don't rely on SmallPtrSet iteration order. The fixit emission breaks if the iteration order changes and also missed to emit fixits for some edge cases.

r312149 - docs: typo fix

Author: hans Date: Wed Aug 30 11:35:44 2017 New Revision: 312149 URL: http://llvm.org/viewvc/llvm-project?rev=312149=rev Log: docs: typo fix Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

[PATCH] D36707: [CodeGen]Refactor CpuSupports/CPUIs Builtin Code Gen to better work with "target" implementation

erichkeane updated this revision to Diff 113291. erichkeane added a comment. This revision is now accepted and ready to land. I figured out that combining the CpuSupports items via an array is a REALLY useful function for dispatch. I've got most of gcc's target implemented, so I believe that

[PATCH] D36410: [OpenCL] Handle taking address of block captures

bader added a comment. In https://reviews.llvm.org/D36410#856716, @yaxunl wrote: > The captured variable is still passed by value. The address taking is on the > duplicate of the captured variable, not on the original variable. In this case address of captured variables should point to the

[PATCH] D37308: Interface class with uuid base record

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:2403-2406 +static bool IsBasePublicInterface(const CXXRecordDecl *RD, + AccessSpecifier spec) { + return RD->isInterface() && spec == AS_public; +} I'm

r312148 - Adapt testcases to LLVM change r312144 in DIGlobalVariableExpression

Author: adrian Date: Wed Aug 30 11:22:23 2017 New Revision: 312148 URL: http://llvm.org/viewvc/llvm-project?rev=312148=rev Log: Adapt testcases to LLVM change r312144 in DIGlobalVariableExpression Modified: cfe/trunk/test/CodeGen/2009-10-20-GlobalDebug.c

Re: [PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

Victor Leschuk writes: > Hello Boris, looks like this revision broke tests on our win10 builder: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/11760 > > Clang :: CXX/modules-ts/basic/basic.link/module-declaration.cpp > >

[PATCH] D36707: [CodeGen]Refactor CpuSupports/CPUIs Builtin Code Gen to better work with "target" implementation

erichkeane updated this revision to Diff 113297. erichkeane added a comment. Woops, messed up my rebase! https://reviews.llvm.org/D36707 Files: lib/CodeGen/CGBuiltin.cpp lib/CodeGen/CodeGenFunction.h Index: lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

On 30 August 2017 at 11:52, Boris Kolpackov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Victor Leschuk writes: > > > Hello Boris, looks like this revision broke tests on our win10 builder: > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_ >

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

rsmith added inline comments. Comment at: lib/AST/Expr.cpp:1857 + if (!PExp->IgnoreParenCasts() + ->isNullPointerConstant(Ctx, Expr::NPC_ValueDependentIsNull)) +return false; andrew.w.kaylor wrote: > rsmith wrote: > > If we get here with a

[PATCH] D37322: [Sema] Correct typos in LHS, RHS before building a binop expression.

vsapsai created this revision. Specifically, typo correction should be done before dispatching between different kinds of binary operations like pseudo-object assignment, overloaded binary operation, etc. Without this change we hit an assertion Assertion failed:

r312191 - [cxx_status] Update to describe current status a bit better.

Author: rsmith Date: Wed Aug 30 16:10:31 2017 New Revision: 312191 URL: http://llvm.org/viewvc/llvm-project?rev=312191=rev Log: [cxx_status] Update to describe current status a bit better. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL:

[PATCH] D37312: Add documentation for force_align_arg_pointer function attribute

anatol.pomozov updated this revision to Diff 113340. https://reviews.llvm.org/D37312 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td === ---

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor updated this revision to Diff 113343. andrew.w.kaylor added a comment. Fixed value-dependent argument in isNullPointerConstant checks. Added check for C++ zero offset in subtraction. Added value-dependent test cases. https://reviews.llvm.org/D37042 Files:

[PATCH] D37206: [ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data on MinGW

mstorsjo updated this revision to Diff 113309. mstorsjo added a comment. The previous diff lacked the extra context around the diff - fixed. https://reviews.llvm.org/D37206 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/rtti-mingw64.cpp Index: test/CodeGenCXX/rtti-mingw64.cpp

r312175 - Test-case golfing.

Author: adrian Date: Wed Aug 30 14:31:16 2017 New Revision: 312175 URL: http://llvm.org/viewvc/llvm-project?rev=312175=rev Log: Test-case golfing. Modified: cfe/trunk/test/CodeGenCXX/debug-info-inlined.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-inlined.cpp URL:

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

Reduced in r312175. -- adrian > On Aug 28, 2017, at 4:47 PM, David Blaikie wrote: > > *nod* Thanks - let me know if you have trouble simplifying or explaining it & > I'll see if fresh eyes help :) > > On Mon, Aug 28, 2017 at 4:46 PM Adrian Prantl

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor added inline comments. Comment at: lib/AST/Expr.cpp:1857 + if (!PExp->IgnoreParenCasts() + ->isNullPointerConstant(Ctx, Expr::NPC_ValueDependentIsNull)) +return false; rsmith wrote: > If we get here with a value-dependent

r312186 - [Sema] Make SpecialMemberDecl a PointerIntPair so we can stash it in a SmallPtrSet.

Author: d0k Date: Wed Aug 30 15:51:50 2017 New Revision: 312186 URL: http://llvm.org/viewvc/llvm-project?rev=312186=rev Log: [Sema] Make SpecialMemberDecl a PointerIntPair so we can stash it in a SmallPtrSet. We have enough spare bits in the alignment of CXXRecordDecl. No functionality change

RE: r312181 - Fix tests for ARM targets

Sorry about that, thanks for fixing it up for me! Douglas Yung > -Original Message- > From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans > Wennborg > Sent: Wednesday, August 30, 2017 16:28 > To: Yung, Douglas > Cc: cfe-commits > Subject: Re: r312181 - Fix tests

[PATCH] D37312: Add documentation for force_align_arg_pointer function attribute

anatol.pomozov added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2809 + let Content = [{ +Use this attribute to force stack alignment. + Feel free to reword the documentation (English is not my native language). Let me know if something is not

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8808 +Context.getTypeSize(pointerType) == +Context.getTypeSize(IExp->getType())) + IsGNUIdiom = true; efriedma wrote: > andrew.w.kaylor wrote: > > efriedma wrote: > > >

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL312185: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer (authored by morehouse). Changed prior to commit: https://reviews.llvm.org/D37156?vs=113177=113329#toc Repository: rL

[PATCH] D37206: [ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data on MinGW

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37310: [Atomic] Merge alignment information from Decl and from Type when emit atomic expression.

wmi created this revision. Herald added a subscriber: sanjoy. This is to fix PR34347. EmitAtomicExpr will only use alignment information from Type, instead of Decl, so when the declaration of an atomic variable is marked to have the alignment equal as its size, EmitAtomicExpr don't know about

[PATCH] D37206: [ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data on MinGW

mstorsjo added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2994 + CGM.getContext().getTargetInfo().getTriple().isOSWindows(); + // MinGW always uses LinkOnceODRLinkage for type info. + if (RD->isDynamicClass() && !IsMinGW)

  1   2   >