[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

r.stahl created this revision. This fixes importing of CaseStmts, because the importer was not importing its SubStmt. A test was added and the test procedure was adjusted to also dump the imported Decl, because otherwise the bug would not be detected. https://reviews.llvm.org/D38943 Files:

[PATCH] D38939: [clangd] Handle exit notification (proper shutdown)

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: test/clangd/authority-less-uri.test:33 {"jsonrpc":"2.0","id":3,"method":"shutdown"} +# CHECK: {"jsonrpc":"2.0","id":3,"result":null} +Content-Length:

[PATCH] D38882: [clang-rename] Add function unit tests.

hokein added a comment. Sorry, I thought I have run all the tests. The previous version broke one test in RenameClass. We still need the workaround for the `std::function` special case. I added it back, and also added a corresponding test case for renaming function, but it is

[PATCH] D37695: [clang-format] Break non-trailing comments, try 2

This revision was automatically updated to reflect the committed changes. Closed by commit rL315893: [clang-format] Break non-trailing comments, try 2 (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D37695 Files: cfe/trunk/lib/Format/BreakableToken.cpp

r315893 - [clang-format] Break non-trailing comments, try 2

Author: krasimir Date: Mon Oct 16 02:08:53 2017 New Revision: 315893 URL: http://llvm.org/viewvc/llvm-project?rev=315893=rev Log: [clang-format] Break non-trailing comments, try 2 Summary: This patch enables `BreakableToken` to manage the formatting of non-trailing block comments. It is a

[PATCH] D38893: [change-namespace] do not change type locs in defaulted functions.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric updated this revision to Diff 119117. ioeric added a comment. - clang-format code. https://reviews.llvm.org/D34272 Files: include/clang/Tooling/CommonOptionsParser.h include/clang/Tooling/Execution.h include/clang/Tooling/ToolExecutorPluginRegistry.h

[PATCH] D38882: [clang-rename] Add function unit tests.

hokein updated this revision to Diff 119121. hokein added a comment. Update, and add one unfixed testcase. https://reviews.llvm.org/D38882 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/CMakeLists.txt unittests/Rename/RenameClassTest.cpp

[PATCH] D38893: [change-namespace] do not change type locs in defaulted functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315892: [change-namespace] do not change type locs in defaulted functions. (authored by ioeric). Repository: rL LLVM https://reviews.llvm.org/D38893 Files:

[clang-tools-extra] r315892 - [change-namespace] do not change type locs in defaulted functions.

Author: ioeric Date: Mon Oct 16 01:20:10 2017 New Revision: 315892 URL: http://llvm.org/viewvc/llvm-project?rev=315892=rev Log: [change-namespace] do not change type locs in defaulted functions. Reviewers: hokein Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D38893

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric updated this revision to Diff 119122. ioeric marked 5 inline comments as done. ioeric added a comment. - Address review comments. https://reviews.llvm.org/D34272 Files: include/clang/Tooling/CommonOptionsParser.h include/clang/Tooling/Execution.h

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric added a comment. Thanks for the review! Comment at: include/clang/Tooling/CommonOptionsParser.h:109 + + const std::string () const { return ErrorMessage; } + hokein wrote: > return `llvm::StringRef`? I'm not a big fan of `StringRef` as a return value.

[PATCH] D38882: [clang-rename] Add function unit tests.

ioeric accepted this revision. ioeric added a comment. Still LGTM Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:469 + // name. + // FIXME: Consider using using-decls to shorten the namespace + // qualifers. The current

[PATCH] D38882: [clang-rename] Add function unit tests.

hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:469 + // name. + // FIXME: Consider using using-decls to shorten the namespace + // qualifers. ioeric wrote: > The current behavior looks fine to

[PATCH] D38945: [CodeGen] Pass TBAA info along with lvalue base info everywhere

kosarev created this revision. kosarev added a project: clang. This patch addresses the rest of the cases where we pass lvalue base info, but do not provide corresponding TBAA info. This patch should not bring in any functional changes. This is part of https://reviews.llvm.org/D38126 reworked

[PATCH] D38868: [OpenCL] Restrict swizzle length check to OpenCL mode

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Comment at: test/SemaOpenCL/vector_swizzle_length.cl:7 void foo() { -float8 f2 = (float8)(0, 0, 0, 0, 0, 0, 0, 0); +float8 f2 = (float8){0, 0, 0, 0, 0,

[PATCH] D38882: [clang-rename] Add function unit tests.

hokein updated this revision to Diff 119128. hokein marked an inline comment as done. hokein added a comment. Remove the FIXME. https://reviews.llvm.org/D38882 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/CMakeLists.txt unittests/Rename/RenameClassTest.cpp

r315898 - [clang-rename] Add function unit tests.

Author: hokein Date: Mon Oct 16 03:37:42 2017 New Revision: 315898 URL: http://llvm.org/viewvc/llvm-project?rev=315898=rev Log: [clang-rename] Add function unit tests. Summary: Also contain a fix: * Fix a false positive of renaming a using shadow function declaration. Reviewers: ioeric

[PATCH] D38882: [clang-rename] Add function unit tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315898: [clang-rename] Add function unit tests. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D38882 Files: cfe/trunk/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: unittests/AST/ASTImporterTest.cpp:100 + // This might catch other cases. + Imported->dump(ToNothing); I would

[PATCH] D38731: [clangd] Allow to pass code completion opts to ClangdServer.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Great! I like the unit testing approach a lot! https://reviews.llvm.org/D38731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38901: [CUDA] Require libdevice only if needed

This revision was automatically updated to reflect the committed changes. Closed by commit rL315902: [CUDA] Require libdevice only if needed (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D38901?vs=118969=119149#toc Repository: rL LLVM

r315902 - [CUDA] Require libdevice only if needed

Author: hahnfeld Date: Mon Oct 16 06:31:30 2017 New Revision: 315902 URL: http://llvm.org/viewvc/llvm-project?rev=315902=rev Log: [CUDA] Require libdevice only if needed If the user passes -nocudalib, we can live without it being present. Simplify the code by just checking whether LibDeviceMap

[PATCH] D36471: [StaticAnalyzer] Try to calculate arithmetic result when operand has a range of possible values

danielmarjamaki added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D36471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26350: Keep invalid Switch in the AST

ogoffart updated this revision to Diff 119142. ogoffart added a comment. Updated the patch so that ActOnStartOfSwitchStmt returns void, and ActOnFinishSwitchStmt will skip some checks in case of error https://reviews.llvm.org/D26350 Files: include/clang/Sema/Sema.h lib/Parse/ParseStmt.cpp

[PATCH] D38947: [CodeGen] Refine generation of TBAA info for bit-field lvalues

kosarev created this revision. kosarev added a project: clang. The main change is that now we generate TBAA info before constructing the resulting lvalue instead of constructing lvalue with some default TBAA info and fixing it as necessary afterwards. We also keep the TBAA info close to lvalue

[PATCH] D38921: [analyzer] LoopUnrolling: update the matched assignment operators

danielmarjamaki added a comment. LGTM.. however I would like approval from somebody else also. https://reviews.llvm.org/D38921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37437: [analyzer] Fix some checker's output plist not containing the checker name

xazax.hun updated this revision to Diff 119141. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. Herald added a subscriber: szepet. - Address review comments. https://reviews.llvm.org/D37437 Files: include/clang/StaticAnalyzer/Core/BugReporter/BugType.h

[PATCH] D37437: [analyzer] Fix some checker's output plist not containing the checker name

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:308 if (StOutBound && !StInBound) { +if (!Filter.CheckCStringOutOfBounds) + return state; zaks.anna wrote: > This seems to be related to the change in the

[PATCH] D38801: [analyzer] In getSVal() API, disable auto-detection of void type as char type.

danielmarjamaki added a comment. LGTM https://reviews.llvm.org/D38801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

r.stahl added a comment. Thanks for the fast response. See inline comment. Comment at: unittests/AST/ASTImporterTest.cpp:100 + // This might catch other cases. + Imported->dump(ToNothing); xazax.hun wrote: > I would elaborate a bit more on the purpose of

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

r.stahl added a comment. If all is good, I will need someone to commit this for me please. Comment at: unittests/AST/ASTImporterTest.cpp:100 + // This might catch other cases. + Imported->dump(ToNothing); xazax.hun wrote: > r.stahl wrote: > > xazax.hun

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis added a reviewer: compnerd. sdardis added a subscriber: compnerd. sdardis added a comment. Two last inlined comments and I think that's everything. @compnerd Have I missed anything? Comment at: src/UnwindRegistersSave.S:100 +#

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

This revision was automatically updated to reflect the committed changes. Closed by commit rL315915: [Bitfield] Add an option to access bitfield in a fine-grained manner. (authored by wmi). Changed prior to commit: https://reviews.llvm.org/D36562?vs=118181=119170#toc Repository: rL LLVM

r315915 - [Bitfield] Add an option to access bitfield in a fine-grained manner.

Author: wmi Date: Mon Oct 16 09:50:27 2017 New Revision: 315915 URL: http://llvm.org/viewvc/llvm-project?rev=315915=rev Log: [Bitfield] Add an option to access bitfield in a fine-grained manner. Currently all the consecutive bitfields are wrapped as a large integer unless there is unamed zero

[PATCH] D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

JDevlieghere added inline comments. Comment at: clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp:76 + +std::size_t twoPow(std::size_t Bits) { + const std::size_t DiscreteValues = 1ul << Bits; Add a comment describing what this function does. I'd move and rephrase

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

arphaman added inline comments. Comment at: include/clang/Tooling/CommonOptionsParser.h:116 + bool HasError; + std::string ErrorMessage; std::unique_ptr Compilations; Would it be better to have an `llvm::Error' instead of the two fields?

[PATCH] D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros.

lebedev.ri created this revision. lebedev.ri added a project: clang. The warning was initially introduced in https://reviews.llvm.org/D32914 by @thakis, and the concerns were raised there, and later in https://reviews.llvm.org/rL302247 and PR33771. I do believe that it makes sense to relax the

[PATCH] D38921: [analyzer] LoopUnrolling: update the matched assignment operators

NoQ added a comment. Neat! Tests? https://reviews.llvm.org/D38921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

xazax.hun added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:100 + // This might catch other cases. + Imported->dump(ToNothing); r.stahl wrote: > xazax.hun wrote: > > I would elaborate a bit more on the purpose of the code below. > I will

[PATCH] D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros.

thakis added a comment. As said on the bug, this matches gcc's behavior, and with this you won't see this warning for NULL. I don't think this is better. Repository: rL LLVM https://reviews.llvm.org/D38954 ___ cfe-commits mailing list

[PATCH] D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros.

lebedev.ri added a comment. In https://reviews.llvm.org/D38954#898586, @thakis wrote: > As said on the bug, this matches gcc's behavior, https://bugs.llvm.org/show_bug.cgi?id=33771#c3 > and with this you won't see this warning for NULL. Finally, an argument that can actually be addressed. >

Re: r315755 - Fix -Woverloaded-virtual warning in clang-refactor

At the moment this method override is not used by the clang-refactor tool, so I don't think I can add a test for it. On 16 October 2017 at 10:11, David Blaikie wrote: > Is there a test that could be added to cover this new code? > > On Fri, Oct 13, 2017 at 2:15 PM Alex

[PATCH] D38857: [OpenCL] Improve printing and semantic check related to implicit addr space

yaxunl marked an inline comment as done. yaxunl added a comment. In https://reviews.llvm.org/D38857#896994, @Anastasia wrote: > LGTM! Thanks! > > Can we close https://bugs.llvm.org/show_bug.cgi?id=33418 after this commit? Will do. Comment at:

r315923 - clang-refactor: Use llvm_unreachable in an unused override

Author: arphaman Date: Mon Oct 16 11:07:16 2017 New Revision: 315923 URL: http://llvm.org/viewvc/llvm-project?rev=315923=rev Log: clang-refactor: Use llvm_unreachable in an unused override As suggested by David Blaikie! Modified: cfe/trunk/tools/clang-refactor/ClangRefactor.cpp Modified:

[PATCH] D38966: CodeGen: Fix invalid bitcasts for atomic builtins

yaxunl created this revision. Currently clang assumes the temporary variables emitted during codegen of atomic builtins have address space 0, which is not true for target triple amdgcn---amdgiz and causes invalid bitcasts. This patch fixes that. https://reviews.llvm.org/D38966 Files:

Re: r315755 - Fix -Woverloaded-virtual warning in clang-refactor

Is there a test that could be added to cover this new code? On Fri, Oct 13, 2017 at 2:15 PM Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Fri Oct 13 14:15:25 2017 > New Revision: 315755 > > URL: http://llvm.org/viewvc/llvm-project?rev=315755=rev >

Re: [clang-tools-extra] r315323 - [clangd] Added forgotten return in UniqueFunction.

Is there missing test coverage for this? On Tue, Oct 10, 2017 at 9:12 AM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryukov > Date: Tue Oct 10 09:12:47 2017 > New Revision: 315323 > > URL: http://llvm.org/viewvc/llvm-project?rev=315323=rev > Log: > [clangd]

Re: r315755 - Fix -Woverloaded-virtual warning in clang-refactor

Generally it's preferably to avoid adding dead code (partly for this reason - it's hard to track when it gets used and ensure it's appropriately tested) could the member function's body be replaced with llvm_unreachable for now, then? On Mon, Oct 16, 2017 at 10:27 AM Alex L

[PATCH] D38939: [clangd] Handle exit notification (proper shutdown)

rwols added inline comments. Comment at: test/clangd/authority-less-uri.test:33 {"jsonrpc":"2.0","id":3,"method":"shutdown"} +# CHECK: {"jsonrpc":"2.0","id":3,"result":null} +Content-Length: 33 sammccall wrote: > Having the shutdown/exit boilerplate in every

Re: [libcxx] r315874 - Silence clang's -Wtautological-constant-compare in last_write_time.pass.cpp

Would it be better/possible to improve the warning to not have this false positive, rather than suppressing it? On Sun, Oct 15, 2017 at 1:12 PM Roman Lebedev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: lebedevri > Date: Sun Oct 15 13:12:42 2017 > New Revision: 315874 > > URL:

r315918 - Recommit r315738 "[clang-refactor] Apply source replacements"

Author: arphaman Date: Mon Oct 16 10:31:16 2017 New Revision: 315918 URL: http://llvm.org/viewvc/llvm-project?rev=315918=rev Log: Recommit r315738 "[clang-refactor] Apply source replacements" The fixed commit ensures that ParsedSourceRange works correctly with Windows paths. Original message:

[PATCH] D38908: Do not link clang_rt.cfi on Android.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315921: Do not link clang_rt.cfi on Android. (authored by eugenis). Changed prior to commit: https://reviews.llvm.org/D38908?vs=118986=119180#toc Repository: rL LLVM https://reviews.llvm.org/D38908

r315921 - Do not link clang_rt.cfi on Android.

Author: eugenis Date: Mon Oct 16 11:02:57 2017 New Revision: 315921 URL: http://llvm.org/viewvc/llvm-project?rev=315921=rev Log: Do not link clang_rt.cfi on Android. Summary: The OS provides cross-dso CFI support starting with Android O. Trapping mode does not require any runtime at all, and

[PATCH] D38772: [refactor] allow the use of refactoring diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rL315924: [refactor] allow the use of refactoring diagnostics (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D38772?vs=118701=119185#toc Repository: rL LLVM

r315924 - [refactor] allow the use of refactoring diagnostics

Author: arphaman Date: Mon Oct 16 11:28:26 2017 New Revision: 315924 URL: http://llvm.org/viewvc/llvm-project?rev=315924=rev Log: [refactor] allow the use of refactoring diagnostics This commit allows the refactoring library to use its own set of refactoring-specific diagnostics to reports

Re: [libcxx] r315874 - Silence clang's -Wtautological-constant-compare in last_write_time.pass.cpp

On Mon, Oct 16, 2017 at 8:09 PM, David Blaikie wrote: > Would it be better/possible to improve the warning to not have this false > positive, rather than suppressing it? I am willing to look into it, once there is a clear minimal test-case, that does not boil down to

Re: r315755 - Fix -Woverloaded-virtual warning in clang-refactor

That's a good idea! I'll commit an llvm_unreachable fix for this override then. On 16 October 2017 at 10:32, David Blaikie wrote: > Generally it's preferably to avoid adding dead code (partly for this > reason - it's hard to track when it gets used and ensure it's

[PATCH] D38979: Fix usage in TableGen of getValueAsString

erichkeane created this revision. Record::getValueAsString returns a stringref to an interned string (apparently had been changed since most of tablegen was written). In this patch, I audited the usage of getValueAsString to find places where we can trivially stop storing 'std::string' and

[PATCH] D38979: Fix usage in TableGen of getValueAsString

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the cleanup! https://reviews.llvm.org/D38979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros.

lebedev.ri updated this revision to Diff 119159. lebedev.ri added a comment. Address @thakis review notes: do make sure that we still warn on `NULL`. Any other special macros/cases? Repository: rL LLVM https://reviews.llvm.org/D38954 Files: lib/Sema/Sema.cpp

[PATCH] D38969: Sort Attributes by "HeaderName"

erichkeane created this revision. Attributes in the docs were previously sorted (apparently) by the attribute name, so AnyX86Interrupt ended up being the first one, rather than in a meaningful place. This resulted in the 4 'interrupt' titled sections being all in different places. This replaces

[PATCH] D38939: [clangd] Handle exit notification (proper shutdown)

rwols added a comment. I couldn't get the protocol.test to succeed; `clangd` returns 1 now and that trips up `lit`. I think I have to use `XFAIL` from `lit` somehow but didn't figure it out. https://reviews.llvm.org/D38939 ___ cfe-commits mailing

[PATCH] D38970: Clarify the 'interrupt' names in Attribute Docs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D38970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38969: Sort Attributes by "HeaderName"

This revision was automatically updated to reflect the committed changes. Closed by commit rL315931: Sort Attributes by "HeaderName" (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D38969?vs=119195=119200#toc Repository: rL LLVM https://reviews.llvm.org/D38969

r315931 - Sort Attributes by "HeaderName"

Author: erichkeane Date: Mon Oct 16 13:31:05 2017 New Revision: 315931 URL: http://llvm.org/viewvc/llvm-project?rev=315931=rev Log: Sort Attributes by "HeaderName" Attributes in the docs were previously sorted (apparently) by the attribute name, so AnyX86Interrupt ended up being the first one,

[PATCH] D38968: [OpenMP] Implement omp_is_initial_device() as builtin

grokos added a comment. Now that this issue has been addressed and regressions tests pass, should we re-enable Cmake to build libomptarget by default? https://reviews.llvm.org/D38968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38976: [OpenMP] Add implicit data sharing support when offloading to NVIDIA GPUs using OpenMP device offloading

gtbercea created this revision. Herald added a subscriber: jholewinski. This patch is part of the development effort to add support in the current OpenMP GPU offloading implementation for implicitly sharing variables between a target region executed by the team master thread and the worker

[PATCH] D38978: [OpenMP] Enable the lowering of implicitly shared variables in OpenMP GPU-offloaded target regions to the GPU shared memory

gtbercea created this revision. Herald added subscribers: mgorny, jholewinski. This patch is part of the development effort to add support in the current OpenMP GPU offloading implementation for implicitly sharing variables between a target region executed by the team master thread and the

r315950 - Replace usage of std::stringstream with raw_string_ostream

Author: erichkeane Date: Mon Oct 16 15:47:26 2017 New Revision: 315950 URL: http://llvm.org/viewvc/llvm-project?rev=315950=rev Log: Replace usage of std::stringstream with raw_string_ostream Typically we don't use the stringstream, so instead use raw_string_stream. Additionally, the dependent

r315953 - Don't print end-of-directive tokens in -E output

Author: rnk Date: Mon Oct 16 16:07:15 2017 New Revision: 315953 URL: http://llvm.org/viewvc/llvm-project?rev=315953=rev Log: Don't print end-of-directive tokens in -E output This comes up when pre-processing standalone .s files containing hash-prefixed comments. The pre-processor should skip the

[PATCH] D38979: Fix usage in TableGen of getValueAsString

This revision was automatically updated to reflect the committed changes. Closed by commit rL315956: Fix usage in TableGen of getValueAsString (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D38979?vs=119218=119227#toc Repository: rL LLVM

r315956 - Fix usage in TableGen of getValueAsString

Author: erichkeane Date: Mon Oct 16 16:25:24 2017 New Revision: 315956 URL: http://llvm.org/viewvc/llvm-project?rev=315956=rev Log: Fix usage in TableGen of getValueAsString Record::getValueAsString returns a stringref to an interned string (apparently had been changed since most of tablegen was

[PATCH] D36973: [libclang] Add support for querying cursor availability

This revision was automatically updated to reflect the committed changes. Closed by commit rL315959: [libclang] Add support for querying cursor availability (authored by jbcoe). Changed prior to commit: https://reviews.llvm.org/D36973?vs=118333=119234#toc Repository: rL LLVM

r315959 - [libclang] Add support for querying cursor availability

Author: jbcoe Date: Mon Oct 16 16:46:02 2017 New Revision: 315959 URL: http://llvm.org/viewvc/llvm-project?rev=315959=rev Log: [libclang] Add support for querying cursor availability Summary: This patch allows checking the availability of cursors through libclang and clang.cindex (Python). This

[PATCH] D38978: [OpenMP] Enable the lowering of implicitly shared variables in OpenMP GPU-offloaded target regions to the GPU shared memory

tra added a comment. Please add tests for the cases where such local->shaed conversion should and should not happen. I would appreciate if you could add details on what exactly your passes are supposed to move to shared memory. Considering that device-side code tends to be heavily inlined, it

r315951 - Make __builtin_types_compatible_p more like GCC's

Author: gbiv Date: Mon Oct 16 15:58:37 2017 New Revision: 315951 URL: http://llvm.org/viewvc/llvm-project?rev=315951=rev Log: Make __builtin_types_compatible_p more like GCC's GCC ignore qualifiers on array types. Since we seem to have this function primarily for GCC compatibility, we should try

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

craig.topper added inline comments. Comment at: lib/Headers/avx512bwintrin.h:2109 + return _mm512_cmp_epi8_mask(_mm512_and_epi32(__A, __B), +_mm512_setzero_qi(), 4); } Can you align this with the opening paren on the line above? Same with all

[PATCH] D38982: [refactor] Initial outline of implementation of "extract function" refactoring

arphaman created this revision. Herald added a subscriber: mgorny. This patch adds an initial, skeleton outline of the "extract function" refactoring. The extracted function doesn't capture variables / rewrite code yet, it just basically does a simple copy-paste. The following initiation rules

r315958 - [libclang] Visit attributes for function and class templates

Author: jbcoe Date: Mon Oct 16 16:43:02 2017 New Revision: 315958 URL: http://llvm.org/viewvc/llvm-project?rev=315958=rev Log: [libclang] Visit attributes for function and class templates Summary: Previously, `VisitAttributes` was not called for function and class templates and thus their

[PATCH] D36955: [libclang] Visit attributes for function and class templates

This revision was automatically updated to reflect the committed changes. Closed by commit rL315958: [libclang] Visit attributes for function and class templates (authored by jbcoe). Changed prior to commit: https://reviews.llvm.org/D36955?vs=118330=119233#toc Repository: rL LLVM

Re: r315951 - Make __builtin_types_compatible_p more like GCC's

Yuck, sorry for the typos in the commit message. It should read: GCC ignores qualifiers on array types. Since we seem to have this function primarily for GCC compatibility, we should try to match that behavior. This also adds a few more test-cases for __builtin_types_compatible_p, which were

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

howard.hinnant added a comment. Fwiw, I wrote this code. All of that "fallback" stuff was written to make customer code that was incorrect, but working on OS X -version-that-used-libsupc++ continue to work. I.e. to be a crutch for incorrect code. It should all be removed if you no longer

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert added a comment. In https://reviews.llvm.org/D38599#899196, @howard.hinnant wrote: > Fwiw, I wrote this code. All of that "fallback" stuff was written to make > customer code that was incorrect, but working on OS X > -version-that-used-libsupc++ continue to work. I.e. to be a

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

howard.hinnant added a comment. Ok. Well that's why it is under a #define: to make it easier to include or not, depending on the needs of the platform. https://reviews.llvm.org/D38599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

arphaman created this revision. Herald added subscribers: ilya-biryukov, mgorny. This patch adds support for editor commands that allow refactoring to be used in editor clients like libclang or clangd. An editor command can be bound to an refactoring action rule. Once it is bound, it's

[PATCH] D38883: [CMake][OpenMP] Customize default offloading arch

gtbercea added a comment. LGTM https://reviews.llvm.org/D38883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38970: Clarify the 'interrupt' names in Attribute Docs

erichkeane created this revision. All 4 of the 'interrupt' headers were automatically named 'interrupt'. This patch gives them unique names. https://reviews.llvm.org/D38970 Files: include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td

[PATCH] D38969: Sort Attributes by "HeaderName"

erichkeane added inline comments. Comment at: utils/TableGen/ClangAttrEmitter.cpp:3670 + DocumentationData(const Record , const Record , +const std::pair &) + : Documentation(), Attribute(), Craig brought up that

[PATCH] D38939: [clangd] Handle exit notification (proper shutdown)

rwols updated this revision to Diff 119198. rwols added a comment. Return 0 if shutdown was received before exit, otherwise return 1 The protocol.test test fails now. https://reviews.llvm.org/D38939 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/Protocol.h

[PATCH] D38969: Sort Attributes by "HeaderName"

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D38969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38770: AMDGPU: Use stricter bounds for workitem builtins

arsenm updated this revision to Diff 119209. arsenm added a comment. Use 1024 for OpenCL https://reviews.llvm.org/D38770 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-amdgcn.cl

[PATCH] D37905: [libclang, bindings]: add spelling location

frutiger updated this revision to Diff 119191. frutiger added a comment. Added 'Location' to '__all__'. https://reviews.llvm.org/D37905 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_location.py tools/libclang/CXSourceLocation.cpp Index:

[PATCH] D38969: Sort Attributes by "HeaderName"

erichkeane updated this revision to Diff 119195. erichkeane added a comment. Change the constructor in DocumentationData to take by value. https://reviews.llvm.org/D38969 Files: utils/TableGen/ClangAttrEmitter.cpp Index: utils/TableGen/ClangAttrEmitter.cpp

[PATCH] D38835: [refactor] selection: new CodeRangeASTSelection represents a set of selected consecutive statements

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/ASTSelection.h:74 +/// An AST selection value that corresponds to a selection of a set of +/// statements that belong to one body of code (like one function). +/// hokein wrote: > I

[PATCH] D38835: [refactor] selection: new CodeRangeASTSelection represents a set of selected consecutive statements

arphaman updated this revision to Diff 119197. arphaman marked 6 inline comments as done. arphaman added a comment. Address review comments Repository: rL LLVM https://reviews.llvm.org/D38835 Files: include/clang/Tooling/Refactoring/ASTSelection.h

r315929 - Clarify the 'interrupt' names in Attribute Docs

Author: erichkeane Date: Mon Oct 16 13:13:36 2017 New Revision: 315929 URL: http://llvm.org/viewvc/llvm-project?rev=315929=rev Log: Clarify the 'interrupt' names in Attribute Docs All 4 of the 'interrupt' headers were automatically named 'interrupt'. This patch gives them unique names.

[PATCH] D38968: [OpenMP] Implement omp_is_initial_device() as builtin

Hahnfeld created this revision. This allows to return the static value that we know at compile time. https://reviews.llvm.org/D38968 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h lib/AST/ExprConstant.cpp lib/Basic/Builtins.cpp test/OpenMP/is_initial_device.c

[PATCH] D38968: [OpenMP] Implement omp_is_initial_device() as builtin

Hahnfeld added a comment. In https://reviews.llvm.org/D38968#898951, @grokos wrote: > Now that this issue has been addressed and regressions tests pass, should we > re-enable Cmake to build libomptarget by default? Yes, I already have a local patch which also takes care of restricting the

[PATCH] D38639: [clangd] #include statements support for Open definition

Nebiroth marked 21 inline comments as done. Nebiroth added inline comments. Comment at: clangd/ClangdUnit.cpp:103 + void AfterExecute(CompilerInstance ) override { +const SourceManager = CI.getSourceManager(); ilya-biryukov wrote: > There's a much better

  1   2   >