r316211 - [CodeGen] Fix generation of TBAA info for array-to-pointer conversions

Author: kosarev Date: Fri Oct 20 05:35:17 2017 New Revision: 316211 URL: http://llvm.org/viewvc/llvm-project?rev=316211=rev Log: [CodeGen] Fix generation of TBAA info for array-to-pointer conversions Resolves: Fatal error: Offset not zero at the point of scalar access. http://llvm.org/PR34992

[PATCH] D39083: [CodeGen] Fix generation of TBAA info for array-to-pointer conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rL316211: [CodeGen] Fix generation of TBAA info for array-to-pointer conversions (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D39083?vs=119552=119646#toc Repository: rL

[PATCH] D39092: [clang-refactor] Add "-Inplace" option to the commandline tool.

This revision was automatically updated to reflect the committed changes. Closed by commit rL316212: [clang-refactor] Add "-Inplace" option to the commandline tool. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D39092 Files:

[PATCH] D39120: [rename] Don't overwrite the template argument when renaming a template function.

hokein created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39120 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/RenameFunctionTest.cpp Index: unittests/Rename/RenameFunctionTest.cpp

[PATCH] D39120: [rename] Don't overwrite the template argument when renaming a template function.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:227 +SourceLocation EndLoc = Expr->hasExplicitTemplateArgs() +? Expr->getLAngleLoc().getLocWithOffset(-1) +:

r316212 - [clang-refactor] Add "-Inplace" option to the commandline tool.

Author: hokein Date: Fri Oct 20 05:37:16 2017 New Revision: 316212 URL: http://llvm.org/viewvc/llvm-project?rev=316212=rev Log: [clang-refactor] Add "-Inplace" option to the commandline tool. Summary: Change clang-refactor default behavior to print the new code after refactoring (instead of

[PATCH] D39083: [CodeGen] Fix generation of TBAA info for array-to-pointer conversions

kosarev added a comment. Thanks Hal. Repository: rL LLVM https://reviews.llvm.org/D39083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

baloghadamsoftware created this revision. Herald added subscribers: mgorny, srhines. A possible error is to write ``malloc(strlen(s+1))`` instead of ``malloc(strlen(s)+1)``. Unfortunately the former is also valid syntactically, but allocates less memory by two bytes (if ``s`` is at least one

[PATCH] D39120: [rename] Don't overwrite the template argument when renaming a template function.

hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:227 +SourceLocation EndLoc = Expr->hasExplicitTemplateArgs() +? Expr->getLAngleLoc().getLocWithOffset(-1) +:

[PATCH] D39122: [Sema] Fixes for enum handling for tautological comparison diagnostics

lebedev.ri updated this revision to Diff 119705. lebedev.ri marked 5 inline comments as done. lebedev.ri added a comment. Addressed review notes. For C++, enum handling clearly needs more work, because not all tautological comparisons are actually diagnosed, so there is no

[libclc] r316238 - r600: Add missing datalayout to .ll files

Author: jvesely Date: Fri Oct 20 14:00:31 2017 New Revision: 316238 URL: http://llvm.org/viewvc/llvm-project?rev=316238=rev Log: r600: Add missing datalayout to .ll files Signed-off-by: Jan Vesely Acked-by: Aaron Watry Modified:

r316235 - Revert "[OpenMP] Avoid VLAs for some reductions on array sections"

Author: hahnfeld Date: Fri Oct 20 13:16:17 2017 New Revision: 316235 URL: http://llvm.org/viewvc/llvm-project?rev=316235=rev Log: Revert "[OpenMP] Avoid VLAs for some reductions on array sections" This breaks at least two buildbots:

[PATCH] D38982: [refactor] Initial outline of implementation of "extract function" refactoring

arphaman updated this revision to Diff 119708. arphaman marked 4 inline comments as done. arphaman added a comment. Address review comments. Repository: rL LLVM https://reviews.llvm.org/D38982 Files: include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h

[PATCH] D38982: [refactor] Initial outline of implementation of "extract function" refactoring

arphaman updated this revision to Diff 119711. arphaman added a comment. Fix diff Repository: rL LLVM https://reviews.llvm.org/D38982 Files: include/clang/Basic/DiagnosticRefactoringKinds.td include/clang/Tooling/Refactoring/ASTSelection.h

[PATCH] D38982: [refactor] Initial outline of implementation of "extract function" refactoring

arphaman added a comment. In https://reviews.llvm.org/D38982#900744, @ioeric wrote: > Code looks good in general. I see there are a bunch of major features > missing; it might make sense to print a warning or document the major missing > features in the high-level API. I added a warning in

[PATCH] D39105: Patch bug 27628 (clang-tidy should exit with a failure code when there are errors)

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Thank you! https://reviews.llvm.org/D39105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38549: [clang-tidy] Link targets and Asm parsers

alexfh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/hicpp-no-assembler.cpp:13-16 + _asm { +mov al, 2; +// CHECK-MESSAGES: :[[@LINE-2]]:3: warning: do not use inline assembler in safety-critical code [hicpp-no-assembler] + }

r316245 - Implement current CWG direction for support of arrays of unknown bounds in

Author: rsmith Date: Fri Oct 20 15:56:25 2017 New Revision: 316245 URL: http://llvm.org/viewvc/llvm-project?rev=316245=rev Log: Implement current CWG direction for support of arrays of unknown bounds in constant expressions. We permit array-to-pointer decay on such arrays, but disallow pointer

[PATCH] D39105: Patch bug 27628 (clang-tidy should exit with a failure code when there are errors)

alexfh added inline comments. Comment at: clang-tidy/tool/ClangTidyMain.cpp:452 + if (FoundErrors) { + return 1; Failed tests reminded me of the -fix-errors flag. I suppose, clang-tidy should not return an error code, when all errors it noticed,

[PATCH] D38549: [clang-tidy] Link targets and Asm parsers

This revision was automatically updated to reflect the committed changes. Closed by commit rL316246: [clang-tidy] Don't error on MS-style inline assembly. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D38549?vs=119677=119722#toc Repository: rL LLVM

[PATCH] D39105: Patch bug 27628 (clang-tidy should exit with a failure code when there are errors)

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. This patch breaks a number of tests. Please run the tests and fix the failures. https://reviews.llvm.org/D39105 ___ cfe-commits

[clang-tools-extra] r316247 - [clang-tidy] Remove MSVC inline assembly test from cross-plat test.

Author: zturner Date: Fri Oct 20 16:09:20 2017 New Revision: 316247 URL: http://llvm.org/viewvc/llvm-project?rev=316247=rev Log: [clang-tidy] Remove MSVC inline assembly test from cross-plat test. This originally started out here in dev, but I moved it to another file when it became clear this

r316250 - [CodeGen] add tests for __builtin_sqrt*; NFC

Author: spatel Date: Fri Oct 20 16:32:41 2017 New Revision: 316250 URL: http://llvm.org/viewvc/llvm-project?rev=316250=rev Log: [CodeGen] add tests for __builtin_sqrt*; NFC I don't know if this is correct, but this is what we currently do. More discussion in PR27108 and PR27435 and D27618.

[PATCH] D39031: [Analyzer] Correctly handle parameters passed by reference when bodyfarming std::call_once

This revision was automatically updated to reflect the committed changes. Closed by commit rL316249: [Analyzer] Correctly handle parameters passed by reference when bodyfarming std… (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39031?vs=119415=119724#toc

[PATCH] D39149: [libc++] Prevent tautological comparisons

smeenai created this revision. Tip-of-tree clang produces `-Wtautological-constant-compare` for tautological constant comparisons, and these pieces of code will trigger that diagnostic when `int` and `long` have the same size (for example, when compiling for a 32-bit target, or for Windows

r316249 - [Analyzer] Correctly handle parameters passed by reference when bodyfarming std::call_once

Author: george.karpenkov Date: Fri Oct 20 16:29:59 2017 New Revision: 316249 URL: http://llvm.org/viewvc/llvm-project?rev=316249=rev Log: [Analyzer] Correctly handle parameters passed by reference when bodyfarming std::call_once Explicitly not supporting functor objects. Differential Revision:

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

alexfh added a comment. Apart from all other comments, I think, this check would better be placed under bugprone/. Repository: rL LLVM https://reviews.llvm.org/D39121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libclc] r316239 - amdgcn: Add missing datalayout info to .ll files

Author: jvesely Date: Fri Oct 20 14:10:18 2017 New Revision: 316239 URL: http://llvm.org/viewvc/llvm-project?rev=316239=rev Log: amdgcn: Add missing datalayout info to .ll files Signed-off-by: Jan Vesely Acked-by: Aaron Watry Modified:

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39136: [OpenMP] Avoid VLAs for some reductions on array sections

Hahnfeld reopened this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. At least two buildbots failing: http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/1175 http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/10478

[PATCH] D38704: [libunwind] Abstract rwlocks into a class, provide a SRW lock implementation for windows

mstorsjo added a comment. Ping @zturner and others https://reviews.llvm.org/D38704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64

mstorsjo added a comment. Ping https://reviews.llvm.org/D38819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38549: [clang-tidy] Link targets and Asm parsers

alexfh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/hicpp-no-assembler.cpp:13-16 + _asm { +mov al, 2; +// CHECK-MESSAGES: :[[@LINE-2]]:3: warning: do not use inline assembler in safety-critical code [hicpp-no-assembler] + }

[clang-tools-extra] r316246 - [clang-tidy] Don't error on MS-style inline assembly.

Author: zturner Date: Fri Oct 20 16:00:51 2017 New Revision: 316246 URL: http://llvm.org/viewvc/llvm-project?rev=316246=rev Log: [clang-tidy] Don't error on MS-style inline assembly. To get MS-style inline assembly, we need to link in the various backends. Some other clang tools already do

[PATCH] D39114: [XRay] Initial XRay in Darwin Support

dberris created this revision. Herald added a subscriber: mgorny. This is a work-in-progress change that attempts to allow us to build and use the XRay runtime in Darwin. Current state: - Assembler files are broken due to assumptions about ELFisms. - Test infrastructure is laid out, but we

[PATCH] D39116: clang patch for -fno-var-tracking-assignments option

martemyev created this revision. martemyev added a project: clang. The patch adds a new option '-fno-var-tracking-assignments' in the same group (clang_ignored_f_Group) where the existing '-fno-var-tracking' resides. https://reviews.llvm.org/D39116 Files: include/clang/Driver/Options.td

clang patch for -fno-var-tracking-assignments option

Hi All, The attached patch adds a new option '-fno-var-tracking-assignments' in the same group (clang_ignored_f_Group) where the existing '-fno-var-tracking' resides. Thanks, Mikhail clang-no-var-tracking-assignments.patch Description: Binary data

Re: clang patch for -fno-var-tracking-assignments option

On Fri, Oct 20, 2017 at 11:44 AM, Mikhail Artemyev via cfe-commits wrote: > Hi All, > > The attached patch adds a new option '-fno-var-tracking-assignments' in the > same group (clang_ignored_f_Group) where the existing '-fno-var-tracking' > resides. It might be best

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:651-652 + } else if (StoreSite->getLocation().getAs()) { +os << "Reach the max loop limit."; +os << " Assigning a conjured symbol"; +if (R->canPrintPretty()) {

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

joerg added a comment. This is not about any operating system, but basic consistent behavior. either do the canonicalisation or not. Doing it sometimes is just bogus. You've effectively implemented -fcanonical-system-headers=sometimes. Repository: rL LLVM https://reviews.llvm.org/D37954

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

materi added a comment. In https://reviews.llvm.org/D38101#901733, @lebedev.ri wrote: > In https://reviews.llvm.org/D38101#901709, @materi wrote: > > > Hi! > > > Hi. > > > After this patch I started to see warnings: > > Thank you for the report! > > > e.c:8:23: warning: integer constant not in

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:651-652 + } else if (StoreSite->getLocation().getAs()) { +os << "Reach the max loop limit."; +os << " Assigning a conjured symbol"; +if (R->canPrintPretty()) {

[PATCH] D39122: [Sema] Fixes for enum handling for tautological comparison diagnostics

lebedev.ri created this revision. lebedev.ri added a project: clang. As Mattias Eriksson has reported in PR35009, in C, for enums, the underlying type should be used when checking for the tautological comparison, unlike C++, where the enumerator values define the value range. So if not in

[PATCH] D39120: [rename] Don't overwrite the template argument when renaming a template function.

hokein updated this revision to Diff 119654. hokein marked an inline comment as done. hokein added a comment. Test for `foo ()`. https://reviews.llvm.org/D39120 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/RenameFunctionTest.cpp Index:

[PATCH] D39120: [rename] Don't overwrite the template argument when renaming a template function.

hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:227 +SourceLocation EndLoc = Expr->hasExplicitTemplateArgs() +? Expr->getLAngleLoc().getLocWithOffset(-1) +:

Re: [PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

+jingham On Fri, Oct 20, 2017 at 6:57 AM Don Hinton via Phabricator < revi...@reviews.llvm.org> wrote: > hintonda added a comment. > > In https://reviews.llvm.org/D36347#901885, @zturner wrote: > > > One possible reason for why this never got any traction is that > `lldb-commits` wasn't added

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/misc-misplaced-operator-in-strlen-in-alloc.rst:16 +void bad_malloc(char *str) { + char *c = (char*) malloc(strlen(str + 1)); +} xazax.hun wrote: > What if this code is

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

martong added a comment. We might get false positives in case of certain substring operations. Consider the case of copying a substring, pseudo code below: const char * s = "abcdefg"; int offset = my_find('d', s); // I want to copy "defg" char *new_subststring = (char*) malloc(strlen(s +

[PATCH] D39120: [rename] Don't overwrite the template argument when renaming a template function.

cierpuchaw added inline comments. Comment at: unittests/Rename/RenameFunctionTest.cpp:232 + std::string Expected = R"( + namespace na { + template T Y(); Shouldn't this be `namespace nb {`? https://reviews.llvm.org/D39120

[PATCH] D33537: [clang-tidy] Exception Escape Checker

xazax.hun added a comment. I agree that we should not spend too much effort on making warnings from the compiler and tidy disjunct. https://reviews.llvm.org/D33537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39120: [rename] Don't overwrite the template argument when renaming a template function.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D39120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

hintonda added a comment. In https://reviews.llvm.org/D36347#901885, @zturner wrote: > One possible reason for why this never got any traction is that > `lldb-commits` wasn't added as a subscriber. While it's true that the tagged > people should have chimed in, having the whole commits list

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

martong added a comment. Consider the use of a function pointer: void* malloc(int); int strlen(char*); auto fp = malloc; void bad_malloc(char *str) { char *c = (char *)fp(strlen(str + 1)); } I think, the checker will not match in this case. One might use allocation functions via a

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

xazax.hun added inline comments. Comment at: clang-tidy/misc/MisplacedOperatorInStrlenInAllocCheck.cpp:30 + Finder->addMatcher( + callExpr(callee(functionDecl(hasName("malloc"))), + hasArgument(0, anyOf(hasDescendant(BadUse), BadUse))) Maybe

[PATCH] D37299: [Modules] Add ability to specify module name to module file mapping in a file

boris added a comment. Ping. https://reviews.llvm.org/D37299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

Eugene.Zelenko added a comment. Same mistake could be made with new[] operator. Comment at: docs/clang-tidy/checks/list.rst:10 android-cloexec-creat + android-cloexec-dup android-cloexec-epoll-create I think will be better to fix order of other

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

clayborg added a comment. Please do convert to python. Just know that you can use "lldb -P" to get the python path that is needed in order to do "import lldb" in the python script. So you can try doing a "import lldb", and if that fails, catch the exception, run "lldb -P", add that path to the

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:651-652 + } else if (StoreSite->getLocation().getAs()) { +os << "Reach the max loop limit."; +os << " Assigning a conjured symbol"; +if (R->canPrintPretty()) {

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

zturner added a comment. In https://reviews.llvm.org/D36347#902157, @clayborg wrote: > Please do convert to python. Just know that you can use "lldb -P" to get the > python path that is needed in order to do "import lldb" in the python script. > So you can try doing a "import lldb", and if

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

jingham added a comment. I can't see anything wrong with the SB API use here. I don't feel qualified to comment on the most effective workflow for an analysis I've never had to do, however. https://reviews.llvm.org/D36347 ___ cfe-commits mailing

[PATCH] D33537: [clang-tidy] Exception Escape Checker

JonasToth added a comment. > I agree that we should not spend too much effort on making warnings from the > compiler and tidy disjunct. +1 There is an effort to treat clangs frontend warnings similar to clang-tidy checks within clang-tidy. This would allow to manage the overlap as well. Will

Re: r316046 - Basic: fix __{,U}INTPTR_TYPE__ on ARM

On 10/17/2017 5:00 PM, Saleem Abdulrasool via cfe-commits wrote: Author: compnerd Date: Tue Oct 17 17:00:50 2017 New Revision: 316046 URL: http://llvm.org/viewvc/llvm-project?rev=316046=rev Log: Basic: fix __{,U}INTPTR_TYPE__ on ARM Darwin and OpenBSD are the only platforms which use `long

[PATCH] D38549: [clang-tidy] Link targets and Asm parsers

zturner updated this revision to Diff 119677. zturner added a comment. Added a test. Alex, if you can confirm this test gives sufficient coverage I can go ahead and submit today. Thanks! https://reviews.llvm.org/D38549 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D39122: [Sema] Fixes for enum handling for tautological comparison diagnostics

efriedma added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8612 +OtherT = OtherT->getAs()->getDecl()->getIntegerType(); + } + Why are you changing this here, as opposed to changing IntRange::forValueOfCanonicalType? Repository: rL LLVM

[PATCH] D39104: Allow /showIncludes with /P

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D39104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39133: [Sema] Better fix for tags defined inside an enumeration (PR28903).

vsapsai created this revision. When we encounter an opening parenthesis and parse the rest as type cast, use DeclSpecContext DSC_type_specifier so we hit the existing check that prevents defining tags in contexts where type specifier is expected. This reverts implementation done in r313386,

[PATCH] D38922: [analyzer] LoopUnrolling: check the bitwidth of the used numbers (pr34943)

dcoughlin accepted this revision. dcoughlin added a comment. Thanks for fixing this! https://reviews.llvm.org/D38922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r316221 - [clang-tidy] Add missing test files in r316090.

Author: hokein Date: Fri Oct 20 10:54:53 2017 New Revision: 316221 URL: http://llvm.org/viewvc/llvm-project?rev=316221=rev Log: [clang-tidy] Add missing test files in r316090. Added: clang-tools-extra/trunk/test/clang-tidy/objc-arc-and-properties.m

[PATCH] D39129: [OpenCL] Fix generation of constant address space sampler in function scope

Anastasia created this revision. After the change of constant address space function scope variable in 6e34f0e ("[OpenCL] Emit function-scope variable in constant address space as static variable", 2017-05-15) a bug has been introduced that triggered unreachable during generation of samplers.

[PATCH] D39031: [Analyzer] Correctly handle parameters passed by reference when bodyfarming std::call_once

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Some nits inline, but looks good to me! Comment at: lib/Analysis/BodyFarm.cpp:388 + // reference. + for (unsigned int i = 2; i < D->getNumParams(); i++) { +

[libunwind] r316224 - GNU: do not read the FDE count if omitted

Author: compnerd Date: Fri Oct 20 11:47:35 2017 New Revision: 316224 URL: http://llvm.org/viewvc/llvm-project?rev=316224=rev Log: GNU: do not read the FDE count if omitted If there is no binary search table computed, the FDECount encoding is DW_EH_PE_omit. Do not attempt to read the FDECount in

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

clayborg added a comment. If you want to run the script from the command line, then it is necessary. If it is run from within LLDB it will just work. I like to have my LLDB python scripts work both ways. This might be better implemented as a new command that gets installed and can be used

[PATCH] D38986: [Analyzer] Better unreachable message in enumeration

dcoughlin added a comment. What is the workflow where this is needed? Is it when an end-user is running a build with assertions and can't provide a reproducer but can provide the console output? Does llvm_unreachable() guarantee that the string construction code is completely removed from

[PATCH] D39035: Unnamed bitfields don't block constant evaluation of constexpr constructors

jordan_rose added a comment. Thanks, Aaron! Comment at: test/SemaCXX/warn-global-constructors.cpp:130 + +namespace HasUnnamedBitfield { + struct HasUnnamedBitfield { aaron.ballman wrote: > Does this namespace require a name? If so, can it be named different

[PATCH] D37182: [libcxx] Special visibility macros for the experimental library

smeenai added a comment. Sorry, this has been on my queue for a long time, but I haven't gotten the chance to get to it yet. I'll try to take a look (at this and your other patches) in the next few days. https://reviews.llvm.org/D37182 ___

r316225 - Allow /showIncludes with /P

Author: erichkeane Date: Fri Oct 20 12:18:30 2017 New Revision: 316225 URL: http://llvm.org/viewvc/llvm-project?rev=316225=rev Log: Allow /showIncludes with /P r213589 was checked in as a solution to https://bugs.llvm.org/show_bug.cgi?id=20336. However, it is possible to use /EP with /P to

[PATCH] D39104: Allow /showIncludes with /P

This revision was automatically updated to reflect the committed changes. Closed by commit rL316225: Allow /showIncludes with /P (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D39104?vs=119607=119686#toc Repository: rL LLVM https://reviews.llvm.org/D39104

[PATCH] D39136: [OpenMP] Avoid VLAs for some reductions on array sections

Hahnfeld created this revision. In some cases the compiler can deduce the length of an array section as constants. With this information, VLAs can be avoided in place of a constant sized array or even a scalar value if the length is 1. Example: int a[4], b[2]; pragma omp parallel

[PATCH] D39122: [Sema] Fixes for enum handling for tautological comparison diagnostics

Rakete added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8610 + if(!S.getLangOpts().CPlusPlus && OtherT->isEnumeralType()) { +OtherT = OtherT->getAs()->getDecl()->getIntegerType(); Please drop the braces. Comment at:

[PATCH] D39136: [OpenMP] Avoid VLAs for some reductions on array sections

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D39136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r316229 - [OpenMP] Avoid VLAs for some reductions on array sections

Author: hahnfeld Date: Fri Oct 20 12:40:40 2017 New Revision: 316229 URL: http://llvm.org/viewvc/llvm-project?rev=316229=rev Log: [OpenMP] Avoid VLAs for some reductions on array sections In some cases the compiler can deduce the length of an array section as constants. With this information,

[PATCH] D39136: [OpenMP] Avoid VLAs for some reductions on array sections

This revision was automatically updated to reflect the committed changes. Closed by commit rL316229: [OpenMP] Avoid VLAs for some reductions on array sections (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D39136?vs=119687=119689#toc Repository: rL LLVM

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

jasonmolenda added a comment. Sorry for missing this back in August. I think it'd be clearer to import your python once in the startup, like -o "script import $module" \ Multiple imports are a no-op IIUC so it's harmless to re-import the module every time the breakpoint is hit (I'm guessing

[PATCH] D39138: [CodeGen] Generate TBAA info for 'this' pointers

kosarev created this revision. kosarev added a project: clang. Repository: rL LLVM https://reviews.llvm.org/D39138 Files: lib/CodeGen/CGCXXABI.cpp test/CodeGen/tbaa-this.cpp Index: test/CodeGen/tbaa-this.cpp === ---