[PATCH] D40185: Loosen -Wempty-body warning.

ilya-biryukov added a comment. In https://reviews.llvm.org/D40185#928845, @rnk wrote: > Why does passing the rparen location for the if condition fix the warning for > IF_ELSE? I assumed that would refer to the else clause semicolon. Using spelling locations fixes the `else` case, but breaks

[PATCH] D39430: [clangd] formatting: don't ignore style

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:289 + llvm::Expected + formatRange(llvm::StringRef Code, PathRef File, Range Rng); + rwols wrote: > rwols wrote: > > ilya-biryukov wrote: > > > rwols wrote: > > > >

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

mstorsjo added a comment. In https://reviews.llvm.org/D39673#929536, @martell wrote: > When doing that I noticed there is something really strange about the > existing macro defines. I assume they should only be defined when exceptions > is enabled. > This is by default in c++ mode of with

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

mgrang updated this revision to Diff 123546. https://reviews.llvm.org/D40234 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Driver.cpp +++ lib/Driver/Driver.cpp @@ -1197,8 +1197,11 @@ //

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

mstorsjo added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:684 +else if (TI.getTriple().isThumb() || TI.getTriple().isARM()) + Builder.defineMacro("__ARM_DWARF_EH__"); + } martell wrote: > mstorsjo wrote: > > Won't this start setting

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

mgrang added a comment. In https://reviews.llvm.org/D40234#929943, @ruiu wrote: > Perhaps, this is a bit more straightforward. > > if (int X = A.compare_lower(B)) > return X < 0; > return A.compare(B) < 0; Thanks. Done. https://reviews.llvm.org/D40234

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

ruiu accepted this revision. ruiu added a comment. LGTM Comment at: lib/Driver/Driver.cpp:1204 +return X < 0; + return A.compare(B) > 0; }); I believe that if you use clang-format, `});` will be put to a separate line like this.

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

ro added a comment. What's the status here? This patch is required for my WIP sanitizers-on-Solaris work. https://reviews.llvm.org/D35755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Notice: The buildbot bb.pgr.jp will be suspended within a few days

Due to resource issue, I have to terminate it. As you know, it has been working for several years and I am certain it has been useful and helpful to guys. I am not sure whether I could restart it or not. I loved it. Thank you, Takumi Nakamura ___

[PATCH] D39722: [ASTImporter] Support TypeTraitExpr Importing

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D39722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40073: [Analyzer] Non-determinism: don't sort indirect goto LabelDecl's by addresses

ilya-palachev updated this revision to Diff 123558. ilya-palachev added a comment. Ok, I agree, this test file is rather better. https://reviews.llvm.org/D40073 Files: lib/Analysis/CFG.cpp test/Analysis/cfg-indirect-goto-determinism.cpp Index:

[PATCH] D39834: [clangd] -foptimization-record-file= should imply -fsave-optimization-record

Quolyk updated this revision to Diff 123559. https://reviews.llvm.org/D39834 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/opt-record.c Index: test/Driver/opt-record.c === --- test/Driver/opt-record.c +++

[PATCH] D40182: [clangd] Add parsing and value inspection to JSONExpr.

ioeric added a comment. Code looks good. Just some nits. Comment at: clangd/JSONExpr.h:62 +// Array and Object also have typed indexing accessors for easy traversal: +// if (json::obj* Opts = O.array("options")) +// if (Optional Font = Opts->string("font"))

[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

ogoffart created this revision. Do not perform the analysis based warning if all warnings are ignored. This saves some cycles when compiling with "-w". But more importantly, for my tool, this fixes a potential crash which may happen on invalid code. Because the analysis might compute the CFG

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 added a comment. In https://reviews.llvm.org/D20124#928552, @ilya-biryukov wrote: > Why do we store raw source locations in `PPSkippedRange`? Would storing > `SourceLocation` and using `ASTWriter::AddSourceLocation` and `ASTReader:: > ReadSourceLocation` do the trick? I followed

r318665 - Revert r318556 "Loosen -Wempty-body warning"

Author: hans Date: Mon Nov 20 09:38:16 2017 New Revision: 318665 URL: http://llvm.org/viewvc/llvm-project?rev=318665=rev Log: Revert r318556 "Loosen -Wempty-body warning" It seems this somehow made -Wempty-body fire in some macro cases where it didn't before, e.g.

r318669 - For Linux/gnu compatibility, preinclude if the file is available

Author: erichkeane Date: Mon Nov 20 09:57:42 2017 New Revision: 318669 URL: http://llvm.org/viewvc/llvm-project?rev=318669=rev Log: For Linux/gnu compatibility, preinclude if the file is available As reported in llvm bugzilla 32377. Here’s a patch to add preinclude of stdc-predef.h. The gcc

[clang-tools-extra] r318668 - extra test modifications for D34158

Author: erichkeane Date: Mon Nov 20 09:57:20 2017 New Revision: 318668 URL: http://llvm.org/viewvc/llvm-project?rev=318668=rev Log: extra test modifications for D34158 When adding support for D34158 which changes preprocessed output, I needed to make tiny test corrections for these. Adding the

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks, looks great, please commit!~ Repository: rL LLVM https://reviews.llvm.org/D39438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

Hahnfeld marked 2 inline comments as done. Hahnfeld added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:431 -SmallString<256> Name(II.getFilename()); -llvm::sys::path::replace_extension(Name, "cubin"); - -const char *CubinF = -

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

Hahnfeld created this revision. This was previously done in some places, but for example not for bundling so that single object compilation with -c failed. In addition cubin was used for all file types during unbundling which is incorrect for assembly files that are passed to ptxas. Tighten up

[PATCH] D40073: [Analyzer] Non-determinism: don't sort indirect goto LabelDecl's by addresses

dcoughlin added a comment. Thanks! Do you have commit access, or do you need someone to commit this for you? https://reviews.llvm.org/D40073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

This revision was automatically updated to reflect the committed changes. Closed by commit rL318669: For Linux/gnu compatibility, preinclude if the file is available (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D34158?vs=120581=123613#toc Repository: rL LLVM

[PATCH] D34624: extra test modifications for D34158

This revision was automatically updated to reflect the committed changes. Closed by commit rL318668: extra test modifications for D34158 (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D34624?vs=120584=123612#toc Repository: rL LLVM

r318672 - [Docs] Regenerate the command line option reference.

Author: ctopper Date: Mon Nov 20 10:07:43 2017 New Revision: 318672 URL: http://llvm.org/viewvc/llvm-project?rev=318672=rev Log: [Docs] Regenerate the command line option reference. Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:431 -SmallString<256> Name(II.getFilename()); -llvm::sys::path::replace_extension(Name, "cubin"); - -const char *CubinF = -C.addTempFile(C.getArgs().MakeArgString(Name)); +const

[PATCH] D40073: [Analyzer] Non-determinism: don't sort indirect goto LabelDecl's by addresses

a.sidorin added a comment. Thank you, Devin! Ilya doesn't have commit access so please commit the patch (or leave it for me, I'm going to commit some patches tomorrow). By the way, is there a common way to write tests for non-determinism for LLVM test suite? https://reviews.llvm.org/D40073

Re: r318456 - Issue -Wempty-body warnings for else blocks

Reverted in r318667. See coments on the r318556 thread. On Thu, Nov 16, 2017 at 3:32 PM, Richard Smith via cfe-commits wrote: > This is kicking up false positives on code that does the following: > > #define USED(x) if(x);else > // ... > assert(x); > USED(x); > >

Re: r318556 - Loosen -Wempty-body warning

I've reverted in r318665 to get the buildbots green until this is figured out. On Sat, Nov 18, 2017 at 11:55 AM, Hans Wennborg wrote: > We're still seeing some in macro-related code. From Chromium: > > ../../third_party/ffmpeg/libavcodec/bitstream.c(169,5): error: if >

Re: r318556 - Loosen -Wempty-body warning

Reverted the original patch too, in r318667 since I assume that was breaking Ilya's build. Hopefully this is easy to fix and they can be re-landed together. On Mon, Nov 20, 2017 at 9:39 AM, Hans Wennborg wrote: > I've reverted in r318665 to get the buildbots green until this

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

K-ballo created this revision. Implement LWG2993, `reference_wrapper` conversion from `T&&`. The conversion fail test currently fails to fail (passes), due to https://bugs.llvm.org/show_bug.cgi?id=35332. Flagging it `XFAIL` does not seem to have any effect. https://reviews.llvm.org/D40259

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5340 + +const ToolChain *CurTC = (); +if (const auto *OA = dyn_cast(JA.getInputs()[I])) { Please add a comment here describing what this entire code snippet is doing.

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

keith.walker.arm created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. To be compatible with GCC if soft floating point is in effect any FPU specified is effectively ignored, eg, -mfloat-abi=soft -fpu=neon If any floating point features which require FPU

r318662 - [CodeGen] Move Reciprocals option from TargetOptions to CodeGenOptions

Author: ctopper Date: Mon Nov 20 09:09:22 2017 New Revision: 318662 URL: http://llvm.org/viewvc/llvm-project?rev=318662=rev Log: [CodeGen] Move Reciprocals option from TargetOptions to CodeGenOptions Diffrential Revision: https://reviews.llvm.org/D40226 Modified:

r318667 - Revert r318456 "Issue -Wempty-body warnings for else blocks"

Author: hans Date: Mon Nov 20 09:48:54 2017 New Revision: 318667 URL: http://llvm.org/viewvc/llvm-project?rev=318667=rev Log: Revert r318456 "Issue -Wempty-body warnings for else blocks" This caused warnings also when the if or else comes from macros. There was an attempt to fix this in r318556,

[PATCH] D40230: Add -mprefer-vector-width driver option and attribute during CodeGen.

craig.topper updated this revision to Diff 123614. craig.topper added a comment. Address comments. The value of 'none' is intended to cancel out any other option specified. I've changed it so that we no longer pass 'none' to llvm and instead suppress the attribute.

[clang-tools-extra] r318670 - [clang-tidy] revert hicpp-multiway-paths-covered

Author: jonastoth Date: Mon Nov 20 10:01:35 2017 New Revision: 318670 URL: http://llvm.org/viewvc/llvm-project?rev=318670=rev Log: [clang-tidy] revert hicpp-multiway-paths-covered The address sanitizer found a stackoverflow with this patch. There is no obvious fix. This patch will be reapplied

[PATCH] D40257: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add

phosek created this revision. Herald added a subscriber: mgorny. Escaping ; in list arguments passed to ExternalProject_Add doesn't seem to be working in newer versions of CMake (see https://public.kitware.com/Bug/view.php?id=16137 for more details). Use a custom LIST_SEPARATOR instead which is

[PATCH] D40258: [CMake] Support side-by-side checkouts in multi-stage build

phosek created this revision. Herald added a subscriber: mgorny. Passthrough LLVM_ENABLE_{PROJECTS,RUNTIMES} to followup stages to support the side-by-side checkouts (aka monorepo layout). Repository: rL LLVM https://reviews.llvm.org/D40258 Files: CMakeLists.txt Index: CMakeLists.txt

[PATCH] D40226: [CodeGen] Move Reciprocals option from TargetOptions to CodeGenOptions

craig.topper closed this revision. craig.topper added a comment. Committed in r318662, but I botched the "Differential Revision" in the commit message. https://reviews.llvm.org/D40226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

kubamracek added a comment. And we should probably introduce files named `xray_linux.cc` and `xray_mac.cc` to contain platform-specific functions. https://reviews.llvm.org/D39114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:431 -SmallString<256> Name(II.getFilename()); -llvm::sys::path::replace_extension(Name, "cubin"); - -const char *CubinF = -C.addTempFile(C.getArgs().MakeArgString(Name)); +const

[PATCH] D39834: [clang] -foptimization-record-file= should imply -fsave-optimization-record

JDevlieghere added a comment. This also ensures that if `fno_save_optimization_record` is specified, you don't overwrite it by setting the file. This is definitely something you'd want to add to your test case. https://reviews.llvm.org/D39834 ___

[PATCH] D39834: [clang] -foptimization-record-file= should imply -fsave-optimization-record

JDevlieghere added a comment. I think you can achieve the same result with less code by checking for the flag's presence higher up, where currently `OPT_fsave_optimization_record` is handled (Clang.cpp:4329). Something like: if (Args.hasFlag(options::OPT_fsave_optimization_record,

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

kubamracek added a comment. Hi, can you split the patch and send individual changes as separate patches? It's getting hard to follow. And I think we should land the parts that are "safe to land", e.g. the ASM changes or some of the NFC whitespace changes. The Darwin-specific changes in tests

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

tra added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5341-5344 +if (const auto *OA = dyn_cast(JA.getInputs()[I])) { + OA->doOnEachDependence( + [&](Action *, const ToolChain *TC, const char *) { CurTC = TC; }); +} Can we

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

asb added subscribers: llvm-commits, asb. asb added a comment. It would have been much cleaner if it worked as @efriedma suggests and -mfloat-abi was only concerned with the ABI (as its name would suggest), but sadly the -mfloat-abi=soft option seems to be defined in GCC to control more than

[PATCH] D40228: [Target] Keep the TargetOptions feature list sorted instead of sorting during CodeGen

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This seems strictly more difficult to keep under control? Though I guess the assert helps. Feel free to go ahead, but... https://reviews.llvm.org/D40228

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

Hahnfeld marked 2 inline comments as done. Hahnfeld added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:431 -SmallString<256> Name(II.getFilename()); -llvm::sys::path::replace_extension(Name, "cubin"); - -const char *CubinF = -

Re: [clang-tools-extra] r318600 - [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

Hi, We are seeing a bot failure with this commit. Please see the bot page here: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/5470/consoleFull#17462642768254eaf0-7326-4999-85b0-388101f2d404 Please let me know if you will be able to provide a patch for this in the next couple of

[PATCH] D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, thanks for the heads up Repository: rL LLVM https://reviews.llvm.org/D38445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35470: [libcxx] Implement std::to_address for C++20

glenjofe added inline comments. Comment at: test/std/utilities/memory/pointer.conversion/to_address.pass.cpp:119 +ASSERT_NOEXCEPT(std::to_address(p4)); +assert(std::to_address(p4) == ); +} EricWF wrote: > Shouldn't one of these tests hit a non-noexcept

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

tra added a comment. Looks OK to me. I'll defer to gtbercea@ for the final stamp. Comment at: test/Driver/openmp-offload-gpu.c:34 +/// Check cubin file generation and usage by nvlink when toolchain has BindArchAction +// RUN: %clang -### -no-canonical-prefixes -target

[PATCH] D40261: Add default argument AST matcher

juliehockett updated this revision to Diff 123654. juliehockett added a comment. Removed spurious semicolons https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

rjmccall accepted this revision. rjmccall added a comment. Yes, LGTM. Repository: rL LLVM https://reviews.llvm.org/D39947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth updated this revision to Diff 123662. Nebiroth marked 10 inline comments as done. Nebiroth added a comment. Removed all std::pair objects Fixed and updated all tests findHover doesn't call findDefinitions anymore DeclarationLocationsFinder fills two Decl and MacroInfos vectors instead of

[PATCH] D40144: Implement `std::launder`

mclow.lists added inline comments. Comment at: include/new:260 +static_assert (!is_function<_Tp>::value, "can't launder functions" ); +static_assert (!is_same_v>, "can't launder cv-void" ); +#ifdef _LIBCPP_COMPILER_HAS_BUILTIN_LAUNDER

[PATCH] D40261: Add default argument AST matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor nit with the comments leading to the public docs, LGTM! Comment at: include/clang/ASTMatchers/ASTMatchers.h:5825-5826 +/// \code +/// void

r318697 - Resubmit "Refactor debuginfo-tests" again.

Author: zturner Date: Mon Nov 20 13:41:36 2017 New Revision: 318697 URL: http://llvm.org/viewvc/llvm-project?rev=318697=rev Log: Resubmit "Refactor debuginfo-tests" again. This was reverted due to the tests being run twice on some build bots. Each run had a slightly different configuration due

r318698 - Revert r318669/318694

Author: erichkeane Date: Mon Nov 20 13:46:29 2017 New Revision: 318698 URL: http://llvm.org/viewvc/llvm-project?rev=318698=rev Log: Revert r318669/318694 Broke some libclang tests, so reverting for now. Removed: cfe/trunk/test/Driver/Inputs/stdc-predef/

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

efriedma added a comment. Oh, I see, for some silly reason there are actually *three* -mfloat-abi options: hard, soft, and softfp. hard means float instructions and a hard-float calling convention, soft means no floating-point and a soft-float convention, and softfp means float instructions

[clang-tools-extra] r318702 - Revert 318668, which is associated with a broken patch

Author: erichkeane Date: Mon Nov 20 14:10:28 2017 New Revision: 318702 URL: http://llvm.org/viewvc/llvm-project?rev=318702=rev Log: Revert 318668, which is associated with a broken patch Modified: clang-tools-extra/trunk/test/pp-trace/pp-trace-pragma-general.cpp

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev marked an inline comment as not done. fedor.sergeev added a comment. In https://reviews.llvm.org/D35755#930030, @ro wrote: > What's the status here? This patch is required for my WIP > sanitizers-on-Solaris work. since @tstellar just resolved the only remaining question I will

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

This revision was automatically updated to reflect the committed changes. Closed by commit rL318705: [analyzer] Diagnose stack leaks via block captures (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D39438?vs=123392=123664#toc Repository: rL LLVM

[PATCH] D40270: [Modules TS] Added re-export support

hamzasood created this revision. This patch adds support for re-exporting modules as described in `[dcl.modules.export]` https://reviews.llvm.org/D40270 Files: include/clang/Parse/Parser.h lib/Parse/ParseObjc.cpp lib/Parse/Parser.cpp lib/Sema/SemaDecl.cpp

[PATCH] D40228: [Target] Keep the TargetOptions feature list sorted instead of sorting during CodeGen

echristo added a comment. No strong opinion. I think I like that one more though. https://reviews.llvm.org/D40228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/DefaultArgumentsCheck.cpp:22 + // Calling a function which uses default arguments is disallowed. + Finder->addMatcher(cxxDefaultArgExpr().bind("stmt"), this); + // Declaring default parameters is disallowed.

[PATCH] D40187: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for' on host

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 318692. Repository: rL LLVM https://reviews.llvm.org/D40187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123677. juliehockett marked 8 inline comments as done. juliehockett added a comment. Moved AST matcher out to ASTMatchers.h (see D40261 ), fixing comments https://reviews.llvm.org/D40108 Files:

[PATCH] D40267: WG14 DR496

aaron.ballman created this revision. This DR was discussed at the WG14 meeting in Albuquerque and the outcome was that member-designator wording could safely be replaced by "subobject", which will be the Proposed Technical Corrigendum coming out of that meeting. This patch removes the

[PATCH] D40181: [libcxx] Allow to set locale on Windows.

mstorsjo added a comment. In order to make this work with MinGW (more or less), I had to change the `_LIBCPP_MSVCRT` into `_LIBCPP_MSVCRT_LIKE` both in `include/__locale` and in `include/__config` (where `_LIBCPP_LOCALE__L_EXTENSIONS` is defined). Normal mingw that uses msvcrt.dll doesn't have

[PATCH] D39279: Stringizing raw string literals containing newline

twoh updated this revision to Diff 123658. twoh added a comment. Addressing @vsapsai's comments. Thank you for the suggestion! Added test case actually finds an off-by-one error in the original patch. I improved the comments as well. https://reviews.llvm.org/D39279 Files:

[PATCH] D40144: Implement `std::launder`

mclow.lists updated this revision to Diff 123663. mclow.lists added a comment. Un-c++17'ed the internal function `__launder` https://reviews.llvm.org/D40144 Files: include/__config include/new test/std/language.support/support.dynamic/ptr.launder/launder.nodiscard.fail.cpp

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

Hahnfeld updated this revision to Diff 123649. Hahnfeld marked 13 inline comments as done. Hahnfeld added a comment. Address reviewers' comments. https://reviews.llvm.org/D40250 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains/Clang.cpp

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

Hahnfeld added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5341-5344 +if (const auto *OA = dyn_cast(JA.getInputs()[I])) { + OA->doOnEachDependence( + [&](Action *, const ToolChain *TC, const char *) { CurTC = TC; }); +} tra

r318705 - [analyzer] Diagnose stack leaks via block captures

Author: alexshap Date: Mon Nov 20 14:53:30 2017 New Revision: 318705 URL: http://llvm.org/viewvc/llvm-project?rev=318705=rev Log: [analyzer] Diagnose stack leaks via block captures This diff extends StackAddrEscapeChecker to catch stack addresses leaks via block captures if the block is executed

[PATCH] D40228: [Target] Keep the TargetOptions feature list sorted instead of sorting during CodeGen

craig.topper added a comment. Yeah don't like it either, but was surprised to find that CodeGen even had a non-const reference to TargetOptions. Would it be better to make a copy and sort the copy during CodeGen? https://reviews.llvm.org/D40228

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

K-ballo updated this revision to Diff 123679. K-ballo added a comment. Addressed review comments. Added tests for SFINAE, noexcept, deduction guide. https://reviews.llvm.org/D40259 Files: include/__functional_base include/functional

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D39947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35470: [libcxx] Implement std::to_address for C++20

EricWF added inline comments. Comment at: test/std/utilities/memory/pointer.conversion/to_address.pass.cpp:119 +ASSERT_NOEXCEPT(std::to_address(p4)); +assert(std::to_address(p4) == ); +} Shouldn't one of these tests hit a non-noexcept function?

[PATCH] D40261: Add default argument AST matcher

juliehockett created this revision. Herald added a subscriber: klimek. Adds AST matcher for declarations with default arguments. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

tcanens added inline comments. Comment at: include/__functional_base:377 +inline _LIBCPP_INLINE_VISIBILITY +_Tp& __lvref_bind(_Tp& r) _NOEXCEPT { return r; } + I'd make these member functions of a class template, to avoid having to reason about partial ordering

[PATCH] D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization.

EricWF added a comment. @rsmith Ping. https://reviews.llvm.org/D29930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

aaron.ballman added a comment. You should add a test case that demonstrates code which would otherwise trigger an analysis-based warning but doesn't due to disabling all warnings. https://reviews.llvm.org/D40242 ___ cfe-commits mailing list

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

efriedma added a comment. -mfpu controls what floating-point/vector instructions the compiler generates. -mfloat-abi controls whether floating-point arguments to functions are passed in floating-point registers. These are completely independent, and we need to support using both of them

[PATCH] D40261: Add default argument AST matcher

juliehockett updated this revision to Diff 123646. juliehockett added a comment. Updated Registry.cpp to include new matcher. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

rengolin added a comment. Wasn't that the mess about -mfpu=softfp? https://reviews.llvm.org/D40256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40144: Implement `std::launder`

tcanens added inline comments. Comment at: include/new:260 +static_assert (!is_function<_Tp>::value, "can't launder functions" ); +static_assert (!is_same_v>, "can't launder cv-void" ); +#ifdef _LIBCPP_COMPILER_HAS_BUILTIN_LAUNDER

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Mon, Nov 20, 2017 at 11:02:13AM -0800, Volodymyr Sapsai wrote: > > catch (...) > > { > > +if (__n > 0) > > +*__s = char_type(); > > this->__set_badbit_and_consider_rethrow(); > > } > > or maybe something else? That one (note that the

r318681 - [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

Author: mgrang Date: Mon Nov 20 10:49:14 2017 New Revision: 318681 URL: http://llvm.org/viewvc/llvm-project?rev=318681=rev Log: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering Summary: This fixes the failure in

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rL318681: [AutoComplete] Use stronger sort predicate for autocomplete candidates to… (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D40234?vs=123546=123623#toc Repository: rL

[PATCH] D40218: [Clang] Add __builtin_launder

EricWF updated this revision to Diff 123627. EricWF added a comment. - Improve quality of tests. - Format code. https://reviews.llvm.org/D40218 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td lib/AST/ExprConstant.cpp lib/CodeGen/CGBuiltin.cpp

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

mgrang added a comment. Ping for reviews please. Repository: rL LLVM https://reviews.llvm.org/D39947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Nov 19, 2017, at 08:07, Reimar Döffinger wrote: > > On Wed, Nov 15, 2017 at 11:35:56AM -0800, Volodymyr Sapsai wrote: >> On Nov 12, 2017, at 12:37, Reimar Döffinger wrote: >> libc++ can be built with exceptions enabled or disabled (see >>

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. I would much rather take this change in all dialects except for C++03. Comment at: include/__functional_base:398 +!is_same<__uncvref_t<_Up>,

[PATCH] D40181: [libcxx] Allow to set locale on Windows.

mstorsjo added a comment. In https://reviews.llvm.org/D40181#930602, @EricWF wrote: > This LGTM. I would love if another party interested in Windows could review > it though. I can test this in a MinGW context and see if what it uses happens to be available there or not.

[libcxx] r318690 - Fix std::string::data() symbol during library build.

Author: ericwf Date: Mon Nov 20 12:23:27 2017 New Revision: 318690 URL: http://llvm.org/viewvc/llvm-project?rev=318690=rev Log: Fix std::string::data() symbol during library build. The non-const data() member of std::string is only exposed in C++17 and beyond. However std::string is externally

[PATCH] D40257: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add

phosek updated this revision to Diff 123640. Repository: rL LLVM https://reviews.llvm.org/D40257 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -653,7 +653,7 @@

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

EricWF added a comment. Also, you're lacking tests for `noexcept` and the deduction guide. https://reviews.llvm.org/D40259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >