[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

martell added a comment. In https://reviews.llvm.org/D39673#931861, @rnk wrote: > We have to know the EH model before pre-processing, and that shouldn't rely > on LLVM TargetOptions. We can probably reuse the `llvm::ExceptionHandling` > enum instead of these various overlapping booleans, if

[PATCH] D40176: [CodeGen] Collect information about sizes of accesses and access types for TBAA

kosarev added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2426 llvm::StoreInst *Store = Builder.CreateStore(VTableAddressPoint, VTableField); - CGM.DecorateInstructionWithTBAA(Store, CGM.getTBAAVTablePtrAccessInfo()); + TBAAAccessInfo TBAAInfo =

[PATCH] D39836: [clangd] Drop impossible completions (unavailable or inaccessible)

ilya-biryukov added inline comments. Comment at: clangd/tool/ClangdMain.cpp:169 + clangd::CodeCompleteOptions CCOpts; + CCOpts.EnableSnippets = EnableSnippets; + CCOpts.IncludeIneligibleResults = IncludeIneligibleResults; We should also set

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

martell updated this revision to Diff 123883. martell edited the summary of this revision. martell added a comment. Herald added subscribers: kristof.beyls, emaste, aemerson. fold USESjLjExceptions into GetExceptionModel. do a best effort to check the llvm default exception model for the triple

[PATCH] D40013: [DeclPrinter] Allow printing fully qualified name of function declaration

nik added a comment. Please submit/land this for me. I don't have the necessary permissions. https://reviews.llvm.org/D40013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

Nebiroth added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:108 Logger.log("Failed to find compilation database for " + Twine(File) + - "in overriden directory " + CompileCommandsDir.getValue() + + " in overriden

[libcxx] r318889 - Add [[nodiscard]] to std::async as part of P0600.

Author: marshall Date: Wed Nov 22 17:25:03 2017 New Revision: 318889 URL: http://llvm.org/viewvc/llvm-project?rev=318889=rev Log: Add [[nodiscard]] to std::async as part of P0600. Added: libcxx/trunk/test/std/thread/futures/futures.async/async.fail.cpp Modified:

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added inline comments. Comment at: clangd/ClangdLSPServer.cpp:230 + std::vector LocationVector; + auto test = Items->Value; + remove Comment at: clangd/ClangdLSPServer.cpp:236 + + C.reply(json::ary(LocationVector)); }

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

Nebiroth updated this revision to Diff 124024. Nebiroth marked 19 inline comments as done. Nebiroth added a comment. Fixed DraftStore thread-safe API being broken Removed superfluous getCompilationDatabase call Changed name of struct to ClangDConfigurationParamsChange Removed operator ! overload

r318888 - [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Wed Nov 22 17:20:07 2017 New Revision: 31 URL: http://llvm.org/viewvc/llvm-project?rev=31=rev Log: [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/AST/ASTContext.h

[PATCH] D40310: Restructure how we break tokens.

krasimir added a comment. Here're a few nits. I'll need an evening to review the meaty part :) Comment at: lib/Format/BreakableToken.cpp:73 + if (ColumnLimit <= ContentStartColumn + 1) { return BreakableToken::Split(StringRef::npos, 0); + } nit: no

[PATCH] D40068: Implement more accurate penalty & trade-offs while breaking protruding tokens.

krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. looks like there are more changes needed. https://reviews.llvm.org/D40068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.

OK, I think r318830 fixes the other one here. Thanks! Billy3 On Wed, Nov 22, 2017 at 4:25 AM, Billy O'Neal wrote: > Sorry, I saw one bot fail and I thought I fixed it with > 37332d772480307af423fbea817c29a0832be86e but apparently there were > others I missed. > > On Wed,

Re: [PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.

Sorry, I saw one bot fail and I thought I fixed it with 37332d772480307af423fbea817c29a0832be86e but apparently there were others I missed. On Wed, Nov 22, 2017 at 4:04 AM, Evgeny Astigeevich wrote: > Hi Billy, > > These changes caused buildbot failures:

[PATCH] D39834: [clang] -foptimization-record-file= should imply -fsave-optimization-record

Quolyk updated this revision to Diff 123914. https://reviews.llvm.org/D39834 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/opt-record.c Index: test/Driver/opt-record.c === --- test/Driver/opt-record.c +++

[PATCH] D40181: [libcxx] Allow to set locale on Windows.

halyavin added a comment. In https://reviews.llvm.org/D40181#930779, @mstorsjo wrote: > (but I think it does define some sort of dummy functions that at least will > allow it to build) Looked into MinGW-w64 sources and this is indeed the case. _configthreadlocale will return -1 and will

[libcxx] r318830 - Add another test_macros.h include I missed to tuple.by.type.pass.cpp

Author: bion Date: Wed Nov 22 04:29:17 2017 New Revision: 318830 URL: http://llvm.org/viewvc/llvm-project?rev=318830=rev Log: Add another test_macros.h include I missed to tuple.by.type.pass.cpp Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.elem/tuple.by.type.fail.cpp

[PATCH] D40181: [libcxx] Allow to set locale on Windows.

halyavin updated this revision to Diff 123921. halyavin added a comment. Herald added a subscriber: krytarowski. Fixed problem with C++98, added std for nullptr_t and switched on _l functions for MinGW. https://reviews.llvm.org/D40181 Files: include/__config include/__locale

[PATCH] D40288: [clang-format] Add option to group multiple #include blocks when sorting includes

krasimir added a comment. Looks good! Just a few nits: Comment at: lib/Format/Format.cpp:1570 IncludesInBlock.push_back({IncludeName, Line, Prev, Category}); + } else if (Style.IncludeBlocks > FormatStyle::IBS_Preserve && + Trimmed.empty()) {

r318827 - [Docs] Update list of languages clang-format can format

Author: malcolm.parsons Date: Wed Nov 22 02:47:35 2017 New Revision: 318827 URL: http://llvm.org/viewvc/llvm-project?rev=318827=rev Log: [Docs] Update list of languages clang-format can format Modified: cfe/trunk/docs/ClangFormat.rst Modified: cfe/trunk/docs/ClangFormat.rst URL:

[PATCH] D40270: [Modules TS] Added re-export support

boris added a comment. All our tests pass as well. Thanks for your work! Repository: rL LLVM https://reviews.llvm.org/D40270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.

Yes, r318830 has made our libcxx buildbots green. The public ones should become green as well. Thanks, Evgeny -Original Message- From: Billy O'Neal Date: Wednesday, 22 November 2017 at 12:30 To: Evgeny Astigeevich Cc:

[PATCH] D39722: [ASTImporter] Support TypeTraitExpr Importing

a.sidorin added inline comments. Comment at: lib/AST/ASTImporter.cpp:5622 + SmallVector ToArgVec; + for (auto FromArg : E->getArgs()) { +TypeSourceInfo *ToTI = Importer.Import(FromArg); aaron.ballman wrote: > `const auto *`? By the way, you can replace the

Re: [PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.

Hi Billy, These changes caused buildbot failures: tuple.by.type.fail.cpp Line 19: unknown type name 'TEST_IGNORE_NODISCARD' http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx14/builds/1109

[PATCH] D40181: [libcxx] Allow to set locale on Windows.

halyavin updated this revision to Diff 123923. https://reviews.llvm.org/D40181 Files: include/__config include/__locale include/support/win32/locale_win32.h src/support/win32/locale_win32.cpp Index: include/__config === ---

[PATCH] D40284: [Sema] Improve diagnostics for template arg deduction

jtbandes updated this revision to Diff 124033. jtbandes added a comment. @erik.pilkington Updated to use a wrapper function. This is definitely less invasive, but it could defeat some optimizations (any approach that checks the return value will defeat tail recursion, I suppose...)

[libcxx] r318897 - Add additional 'UNSUPPORTED' to the test case.

Author: marshall Date: Wed Nov 22 21:43:25 2017 New Revision: 318897 URL: http://llvm.org/viewvc/llvm-project?rev=318897=rev Log: Add additional 'UNSUPPORTED' to the test case. Modified: libcxx/trunk/test/std/thread/futures/futures.async/async.fail.cpp Modified:

Re: [clang-tools-extra] r318809 - Silence some MSVC warnings about not all control paths returning a value; NFC.

Den 21 nov. 2017 11:24 em skrev "Aaron Ballman via cfe-commits" < cfe-commits@lists.llvm.org>: Author: aaronballman Date: Tue Nov 21 14:24:13 2017 New Revision: 318809 URL: http://llvm.org/viewvc/llvm-project?rev=318809=rev Log: Silence some MSVC warnings about not all control paths returning a

[PATCH] D40381: Parse concept definition

changyu added a comment. I should add that this depends on https://reviews.llvm.org/D40380 https://reviews.llvm.org/D40381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40381: Parse concept definition

changyu created this revision. Per p0734r0. https://reviews.llvm.org/D40381 Files: include/clang/AST/DeclTemplate.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/DeclNodes.td include/clang/Basic/TemplateKinds.h include/clang/Parse/Parser.h include/clang/Sema/Sema.h

r318896 - [DeclPrinter] Allow printing fully qualified name of function declaration

Author: sepavloff Date: Wed Nov 22 21:38:20 2017 New Revision: 318896 URL: http://llvm.org/viewvc/llvm-project?rev=318896=rev Log: [DeclPrinter] Allow printing fully qualified name of function declaration When requesting a tooltip for a function call in an IDE, the fully qualified name helps to

[PATCH] D40013: [DeclPrinter] Allow printing fully qualified name of function declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL318896: [DeclPrinter] Allow printing fully qualified name of function declaration (authored by sepavloff). Repository: rL LLVM https://reviews.llvm.org/D40013 Files:

[PATCH] D40354: [OpenMP] Adjust arguments of nvptx runtime functions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D40354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r318835 - Merging r312892:

Author: tstellar Date: Wed Nov 22 06:45:26 2017 New Revision: 318835 URL: http://llvm.org/viewvc/llvm-project?rev=318835=rev Log: Merging r312892: r312892 | ericwf | 2017-09-10 16:41:20 -0700 (Sun, 10 Sep 2017) | 10 lines

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

keith.walker.arm updated this revision to Diff 123936. keith.walker.arm added a comment. I have updated the patch with the suggested change to use a list of features to disable. I checked that LLVM does indeed implicitly disable features if they are dependent on a feature that is explicitly

[PATCH] D40224: [X86] Control-Flow Enforcement Technology - Shadow Stack and Indirect Branch Tracking support (Clang side)

oren_ben_simhon updated this revision to Diff 123937. oren_ben_simhon added a comment. Implemented comments posted until 11/21 (Thanks Craig) Repository: rL LLVM https://reviews.llvm.org/D40224 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def

[clang-tools-extra] r318840 - [FindAllSymbols] Cache regexes, creating them is expensive

Author: d0k Date: Wed Nov 22 07:38:23 2017 New Revision: 318840 URL: http://llvm.org/viewvc/llvm-project?rev=318840=rev Log: [FindAllSymbols] Cache regexes, creating them is expensive This is a bit annoying because LLVM regexes are always mutable to store errors. Assert that there are never

[concepts] Step 1: Remove unneeded partial support for concepts.

As part of the roadmap for concepts, https://github.com/saarraz/clang-concepts-roadmap, as discussed on [cfe-dev] - http://lists.llvm.org/pipermail/cfe-dev/2017-November/056009.html, we're doing incremental commits with the end goal of supporting concepts as they are in the current C++2a working

r318834 - [OPENMP] Codegen for `target teams` directive.

Author: abataev Date: Wed Nov 22 06:25:55 2017 New Revision: 318834 URL: http://llvm.org/viewvc/llvm-project?rev=318834=rev Log: [OPENMP] Codegen for `target teams` directive. Added codegen of the clauses for `target teams` directive. Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp

[libcxx] r318837 - Merging r315994:

Author: tstellar Date: Wed Nov 22 07:06:35 2017 New Revision: 318837 URL: http://llvm.org/viewvc/llvm-project?rev=318837=rev Log: Merging r315994: r315994 | ericwf | 2017-10-17 06:03:17 -0700 (Tue, 17 Oct 2017) | 18 lines

[PATCH] D40288: [clang-format] Add option to group multiple #include blocks when sorting includes

KrzysztofKapusta updated this revision to Diff 123924. KrzysztofKapusta added a comment. Addressed all comments. Changed one testcase to better reflect the desired effect. Repository: rL LLVM https://reviews.llvm.org/D40288 Files: docs/ClangFormatStyleOptions.rst

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

ABataev updated this revision to Diff 123932. ABataev added a comment. Added codegen for `target teams` construct. https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index.rst Index: docs/index.rst === ---

[PATCH] D40354: [OpenMP] Adjust arguments of nvptx runtime functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL318836: [OpenMP] Adjust arguments of nvptx runtime functions (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D40354?vs=123930=123934#toc Repository: rL LLVM

r318836 - [OpenMP] Adjust arguments of nvptx runtime functions

Author: hahnfeld Date: Wed Nov 22 06:46:49 2017 New Revision: 318836 URL: http://llvm.org/viewvc/llvm-project?rev=318836=rev Log: [OpenMP] Adjust arguments of nvptx runtime functions In the future the compiler will analyze whether the OpenMP runtime needs to be (fully) initialized and avoid that

[PATCH] D40288: [clang-format] Add option to group multiple #include blocks when sorting includes

KrzysztofKapusta added inline comments. Comment at: unittests/Format/SortIncludesTest.cpp:357 + "#include \"c.h\"\n", + "a.cc")); +} krasimir wrote: > What is this testing? I changed this to better reflect what I was trying to

[PATCH] D39882: [clangd] Filter completion results by fuzzy-matching identifiers.

ilya-biryukov added a comment. We definitely need to: - Rebase this change on top of current head (to account for limits and scoring) - Set `incomplete=true` for fuzzy-matched completion results Maybe also make fuzzy-matching configurable via a flag? Off-by-default for now, so we could start

[PATCH] D40354: [OpenMP] Adjust arguments of nvptx runtime functions

Hahnfeld created this revision. Herald added a subscriber: jholewinski. In the future the compiler will analyze whether the OpenMP runtime needs to be (fully) initialized and avoid that overhead if possible. The functions already take an argument to transfer that information to the runtime, so

[PATCH] D40132: [clangd] Tracing improvements

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Oops, accidentally accepted the revision. There are no major issues, but still wanted to learn the reasons we use rval-refs and allocate span dynamically.

r318849 - [OPENMP] General improvement of code, NFC.

Author: abataev Date: Wed Nov 22 09:19:31 2017 New Revision: 318849 URL: http://llvm.org/viewvc/llvm-project?rev=318849=rev Log: [OPENMP] General improvement of code, NFC. Modified: cfe/trunk/lib/Basic/OpenMPKinds.cpp cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified:

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth updated this revision to Diff 123958. Nebiroth marked 10 inline comments as done. Nebiroth added a comment. Removed accidentally included files Fixed some coding standard issues Removed getDeclarationLocation declaration from header file Replaced getFunctionComments with clang

[PATCH] D40224: [X86] Control-Flow Enforcement Technology - Shadow Stack and Indirect Branch Tracking support (Clang side)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D40224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40132: [clangd] Tracing improvements

ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: clangd/JSONRPCDispatcher.h:61 + llvm::Optional ID) + : Out(Out), ID(std::move(ID)), Tracer(new trace::Span(Method)) { +

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc reopened this revision. mibintc added a comment. Hi. I also posted this question on IRC @erichkeane pushed a fix for https://reviews.llvm.org/D34158 which on Linux does a preinclude of stdc-predef.h; on Monday. Later on Monday he pulled it out because it caused 3 test failures and

[PATCH] D40023: [RISCV] Implement ABI lowering

apazos added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:8872 + else +NeededArgGPRs = 1; + Suggestion to make 1 default value when you declare the var Comment at: lib/CodeGen/TargetInfo.cpp:8938 + + // The size of the actual

[PATCH] D39936: [OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D39936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a comment. Ping. https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r318853 - [CodeGen] Fix vtable not receiving hidden visibility when using push(visibility)

Author: phosek Date: Wed Nov 22 09:59:30 2017 New Revision: 318853 URL: http://llvm.org/viewvc/llvm-project?rev=318853=rev Log: [CodeGen] Fix vtable not receiving hidden visibility when using push(visibility) This change should resolve https://bugs.llvm.org/show_bug.cgi?id=35022 Patch by Jake

r318857 - CachePruning: Allow limiting the number of files in the cache directory.

Author: pcc Date: Wed Nov 22 10:27:31 2017 New Revision: 318857 URL: http://llvm.org/viewvc/llvm-project?rev=318857=rev Log: CachePruning: Allow limiting the number of files in the cache directory. The default limit is 100 but it can be configured with a cache policy. The motivation is that

[PATCH] D40372: [ExprConstant] Fix assert when initializing constexpr array

erik.pilkington created this revision. Previously, clang would assert on the following: struct S { constexpr S (const int& ir = 0) {} }; constexpr S foo[2]; The problem was that while initializing foo, CallStackFrame::createTemporary() was called twice for the

[PATCH] D39627: Fix vtable not receiving hidden visibility when using push(visibility)

This revision was automatically updated to reflect the committed changes. Closed by commit rL318853: [CodeGen] Fix vtable not receiving hidden visibility when using push(visibility) (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D39627?vs=123399=123969#toc Repository:

r318860 - [OPENMP] Added missed checks for for [simd] based directives.

Author: abataev Date: Wed Nov 22 10:34:02 2017 New Revision: 318860 URL: http://llvm.org/viewvc/llvm-project?rev=318860=rev Log: [OPENMP] Added missed checks for for [simd] based directives. Added missed checks/analysis for safelen/simdlen clauses + linear clause in for [simd] based directives.

[libcxx] r318862 - [libcxx] Make std::basic_istream::getline 0-terminate input array in case of error.

Author: vsapsai Date: Wed Nov 22 10:52:36 2017 New Revision: 318862 URL: http://llvm.org/viewvc/llvm-project?rev=318862=rev Log: [libcxx] Make std::basic_istream::getline 0-terminate input array in case of error. It covers the cases when the sentry object returns false and when an exception was

[PATCH] D40325: add new check to find OSSpinlock usage

hokein added a comment. The implementation looks good, I will let Ben to do the Object-C specific review since he probably knows more about it. Comment at: clang-tidy/objc/AvoidSpinlockCheck.cpp:35 + diag(MatchedExpr->getLocStart(), + "OSSpinlock is deprecated on iOS.

[PATCH] D40284: [Sema] Improve diagnostics for template arg deduction

jtbandes added a reviewer: rsmith. jtbandes added a subscriber: rsmith. jtbandes added a comment. Adding @rsmith for review based on the commit history of SemaTemplateDeduction.cpp :) https://reviews.llvm.org/D40284 ___ cfe-commits mailing list

r318881 - [OPENMP] Add support for cancel constructs in `target teams distribute

Author: abataev Date: Wed Nov 22 13:12:03 2017 New Revision: 318881 URL: http://llvm.org/viewvc/llvm-project?rev=318881=rev Log: [OPENMP] Add support for cancel constructs in `target teams distribute parallel for`. Add support for cancel/cancellation point directives inside `target teams

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

tra added a comment. @rjmccall : are you OK with this approach? If VLA is not supported by the target, CUDA is handled as a special case so it can emit deferred diag, OpenMP reports an error only if shouldDiagnoseTargetSupportFromOpenMP() allows it, and everything else does so unconditionally.

[libcxx] r318863 - [libcxx][fixup] Mark std::basic_istream::getline tests as failing for previous libcxx versions.

Author: vsapsai Date: Wed Nov 22 11:36:54 2017 New Revision: 318863 URL: http://llvm.org/viewvc/llvm-project?rev=318863=rev Log: [libcxx][fixup] Mark std::basic_istream::getline tests as failing for previous libcxx versions. r318862 added a fix for 0-termination input array in case of an error.

[PATCH] D40325: add new check to find OSSpinlock usage

hokein added inline comments. Comment at: clang-tidy/objc/AvoidSpinlockCheck.cpp:35 + diag(MatchedExpr->getLocStart(), + "OSSpinlock is deprecated on iOS. Please use other locks or dispatch " + "queue."); hokein wrote: > nit: clang-tidy message is

[libcxx] r318865 - [libcxx] Implement std::to_address for C++20

Author: ericwf Date: Wed Nov 22 11:49:21 2017 New Revision: 318865 URL: http://llvm.org/viewvc/llvm-project?rev=318865=rev Log: [libcxx] Implement std::to_address for C++20 Summary: Now implements P0653R2 - Utility to convert to raw pointer. Reviewers: mclow.lists, EricWF Reviewed By: EricWF

[libcxx] r318864 - Implement p0137r1 - std::launder. Reviewed as https://reviews.llvm.org/D40144

Author: marshall Date: Wed Nov 22 11:49:03 2017 New Revision: 318864 URL: http://llvm.org/viewvc/llvm-project?rev=318864=rev Log: Implement p0137r1 - std::launder. Reviewed as https://reviews.llvm.org/D40144 Added: libcxx/trunk/test/std/language.support/support.dynamic/ptr.launder/

[PATCH] D40181: [libcxx] Allow to set locale on Windows.

mstorsjo accepted this revision. mstorsjo added a comment. LGTM, thanks for updating it! https://reviews.llvm.org/D40181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40144: Implement `std::launder`

mclow.lists closed this revision. mclow.lists added a comment. landed as revision 318864 https://reviews.llvm.org/D40144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r318872 - [OPENMP] Add support for cancel constructs in [teams] distribute

Author: abataev Date: Wed Nov 22 12:19:50 2017 New Revision: 318872 URL: http://llvm.org/viewvc/llvm-project?rev=318872=rev Log: [OPENMP] Add support for cancel constructs in [teams] distribute parallel for directives. Added codegen/sema support for cancel constructs in [teams] distribute

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

mstorsjo accepted this revision. mstorsjo added a comment. Looks really good to me now! @rnk? Repository: rL LLVM https://reviews.llvm.org/D39673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] r318874 - [demangler] Support for abi_tag attribute

Author: epilk Date: Wed Nov 22 12:38:22 2017 New Revision: 318874 URL: http://llvm.org/viewvc/llvm-project?rev=318874=rev Log: [demangler] Support for abi_tag attribute Differential revision: https://reviews.llvm.org/D40279 Modified: libcxxabi/trunk/src/cxa_demangle.cpp

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

K-ballo updated this revision to Diff 124005. K-ballo added a comment. Back to `decltype`-based SFINAE. https://reviews.llvm.org/D40259 Files: include/__functional_base include/functional test/std/utilities/function.objects/refwrap/refwrap.assign/copy_assign.pass.cpp

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

EricWF requested changes to this revision. EricWF added inline comments. This revision now requires changes to proceed. Comment at: include/__functional_base:396 +!is_same<__uncvref_t<_Up>, reference_wrapper>::value +>::type, bool _IsNothrow =

r318866 - Revert "[CodeGen] Fix vtable not receiving hidden visibility when using push(visibility)"

Author: phosek Date: Wed Nov 22 11:50:17 2017 New Revision: 318866 URL: http://llvm.org/viewvc/llvm-project?rev=318866=rev Log: Revert "[CodeGen] Fix vtable not receiving hidden visibility when using push(visibility)" This reverts commit r318853: tests are failing on Windows bots Removed:

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Nov 20, 2017, at 23:59, Reimar Döffinger wrote: > > On 21.11.2017, at 03:54, Volodymyr Sapsai > wrote: >> >>> If (exceptions()) != 0 then the exception is rethrown. >> And looks like libstdc++ rethrows exception even

[PATCH] D40279: [libcxxabi][demangler] Add demangling for __attribute__((abi_tag))

This revision was automatically updated to reflect the committed changes. Closed by commit rL318874: [demangler] Support for abi_tag attribute (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D40279?vs=123787=124003#toc Repository: rL LLVM

r318882 - [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Wed Nov 22 13:32:07 2017 New Revision: 318882 URL: http://llvm.org/viewvc/llvm-project?rev=318882=rev Log: [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/AST/DeclObjC.h

[PATCH] D40325: add new check to find OSSpinlock usage

Wizard updated this revision to Diff 124011. Wizard marked an inline comment as done. Wizard added a comment. fix nit https://reviews.llvm.org/D40325 Files: clang-tidy/objc/AvoidSpinlockCheck.cpp clang-tidy/objc/AvoidSpinlockCheck.h clang-tidy/objc/CMakeLists.txt

[PATCH] D40284: [Sema] Improve diagnostics for template arg deduction

erik.pilkington added a comment. This looks correct, but I definitely agree that RAII would make this a lot nicer. Have you considered adding a `CancelableSaveAndRestore` or something to SaveAndRestore.h? It seems useful and generic enough to make it worthwhile. Otherwise, you could just write