[PATCH] D40528: add new check to find NSError init invocation

hokein added inline comments. Comment at: docs/clang-tidy/checks/objc-avoid-nserror-init.rst:10 +``errorWithDomain:code:userInfo:`` to create new NSError objects instead +of ``[NSError alloc] init]``. Otherwise it will lead to a warning message +during compilation in Xcode.

[clang-tools-extra] r319159 - [clangd] Switch from YAMLParser to JSONExpr

Author: sammccall Date: Tue Nov 28 01:37:43 2017 New Revision: 319159 URL: http://llvm.org/viewvc/llvm-project?rev=319159=rev Log: [clangd] Switch from YAMLParser to JSONExpr Summary: - Converted Protocol.h parse() functions to take JSON::Expr. These no longer detect and log unknown fields,

[PATCH] D40310: Restructure how we break tokens.

krasimir added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1525 + if (!DryRun) +Token->adaptStartOfLine(0, Whitespaces); + If we indent here, shouldn't that also change ContentStartColumn? Comment at:

[PATCH] D40548: [clangd] Prototyping index support and naive index-based global code completion. WIP

ioeric created this revision. Herald added subscribers: ilya-biryukov, mgorny. o Experimental interfaces to support use multiple index sources (e.g. AST index, global index) for code completion, cross-reference finding etc. o Replace sema code completion for qualified-id with index-based

[PATCH] D40543: Pass by reference NewQualifiedName in QualifiedRenameRule

Quolyk added inline comments. Comment at: include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79 QualifiedRenameRule(const NamedDecl *ND, - std::string NewQualifiedName) + const std::string ) : ND(ND),

[PATCH] D38171: [clang-tidy] Implement clang-tidy check aliases

xazax.hun added a comment. In https://reviews.llvm.org/D38171#927046, @alexfh wrote: > And, btw, sorry for the long delay. I've been on travelling / on vacation for > the last few weeks. No problem. Will you have some time to think about the overall concept? Implementation and test wise it

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

dberris added a comment. In https://reviews.llvm.org/D39114#930461, @kubamracek wrote: > Hi, can you split the patch and send individual changes as separate patches? > It's getting hard to follow. And I think we should land the parts that are > "safe to land", e.g. the ASM changes or some of

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

ilya-biryukov added inline comments. Comment at: clangd/Context.cpp:16 + +static Context *GlobalCtx = nullptr; +static Context EmptyContext(nullptr, {}); sammccall wrote: > Seems like it would simplify things if: > - GlobalCtx was always set (static local

[PATCH] D40528: add new check to find NSError init invocation

Wizard added inline comments. Comment at: docs/clang-tidy/checks/objc-avoid-nserror-init.rst:10 +``errorWithDomain:code:userInfo:`` to create new NSError objects instead +of ``[NSError alloc] init]``. Otherwise it will lead to a warning message +during compilation in Xcode.

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

nik updated this revision to Diff 124550. nik marked an inline comment as done. nik added a comment. Rebaed and clarified the documentation only. Please submit as I don't have the permissions. https://reviews.llvm.org/D40072 Files: include/clang-c/Index.h test/Index/print-type-size.cpp

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

erikjv closed this revision. erikjv added a comment. Submitted as r317308. https://reviews.llvm.org/D38578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40406: [clangd] Switch from YAMLParser to JSONExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE319159: [clangd] Switch from YAMLParser to JSONExpr (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D40406?vs=124163=124529#toc Repository: rCTE Clang Tools Extra

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

xazax.hun accepted this revision. xazax.hun added a comment. I found some nit, otherwise LG! I think you should includ the context in the patches, that makes them reviewing much easier. See: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

erikjv added a comment. Maybe something like this works: --- a/tools/libclang/CIndex.cpp +++ b/tools/libclang/CIndex.cpp @@ -8090,6 +8090,7 @@ CXSourceRangeList *clang_getSkippedRanges(CXTranslationUnit TU, CXFile file) { SourceManager = Ctx.getSourceManager(); FileEntry

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris updated this revision to Diff 124538. dberris retitled this revision from "[XRay][darwin] Initial XRay in Darwin Support" to "[XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin". dberris edited the summary of this revision. dberris added a comment. This revision is now

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

dberris updated this revision to Diff 124539. dberris edited the summary of this revision. dberris added a comment. Update description to not use tabs. https://reviews.llvm.org/D39114 Files: compiler-rt/cmake/config-ix.cmake compiler-rt/lib/xray/CMakeLists.txt

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Comment at: include/clang-c/Index.h:2622 + * + * A declaration is invalid if it could not be parsed successfully. + */ Perhaps add that we need to have

[PATCH] D39347: Fix __has_unique_object_representations based on rsmith's input

erichkeane added inline comments. Comment at: lib/AST/ASTContext.cpp:2238-2240 + // All other pointers are unique. + if (Ty->isPointerType() || Ty->isMemberPointerType()) +return true; rsmith wrote: > erichkeane wrote: > > rsmith wrote: > > > This is not

[PATCH] D40508: Replace long type names in IR with hashes

sepavloff added a comment. In https://reviews.llvm.org/D40508#937212, @rjmccall wrote: > In Swift's IRGen, we have an option controlling whether to emit meaningful > value names. That option can be set directly from the command line, but it > defaults to whether we're emitting IR assembly

[PATCH] D40228: [Target] Make a copy of TargetOptions feature list before sorting during CodeGen

This revision was automatically updated to reflect the committed changes. Closed by commit rL319195: [Target] Make a copy of TargetOptions feature list before sorting during CodeGen (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D40228?vs=123862=124599#toc

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

aaron.ballman added a comment. Thanks for the nit fix. If you'd like me to commit this on your behalf, just let me know. https://reviews.llvm.org/D40108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40568: design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer

kcc updated this revision to Diff 124604. kcc added a comment. minor edit (explained shadow) Repository: rC Clang https://reviews.llvm.org/D40568 Files: docs/TaggedAddressSanitizerDesign.rst Index: docs/TaggedAddressSanitizerDesign.rst

[PATCH] D40508: Replace long type names in IR with hashes

sepavloff updated this revision to Diff 124587. sepavloff added a comment. Updated patch as part of it was committed in https://reviews.llvm.org/rL319178 https://reviews.llvm.org/D40508 Files: include/clang/AST/PrettyPrinter.h lib/AST/TypePrinter.cpp lib/CodeGen/CodeGenTypes.cpp

[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

ioeric created this revision. https://reviews.llvm.org/D40563 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp === --- lib/Sema/SemaCodeComplete.cpp +++

[PATCH] D40508: Replace long type names in IR with hashes

sepavloff marked 3 inline comments as done. sepavloff added a comment. In https://reviews.llvm.org/D40508#936617, @rnk wrote: > It's not clear to me that this abbreviation functionality should live in > Support. Clang probably wants enough control over this (assuming we're doing > it) that the

[PATCH] D40568: design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer

kcc created this revision. Herald added subscribers: cfe-commits, fedor.sergeev. preliminary design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer The name TaggedAddressSanitizer and the rest of the document, are early draft, suggestions are welcome.

[PATCH] D40508: Replace long type names in IR with hashes

sepavloff added a comment. https://reviews.llvm.org/D40567 presents a patch that adds template argument names to class template specializations. It also describes the use case in which type names are used to identify type across different TUs. Adding template parameters obviously increase

[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

nik created this revision. For the function declaration auto foo5(Foo) -> Foo; the parameter tokens were mapped to cursors representing the FunctionDecl: Keyword: "auto" [1:1 - 1:5] FunctionDecl=test5:1:6 Identifier: "test5" [1:6 - 1:11] FunctionDecl=test5:1:6 Punctuation: "(" [1:11 -

[PATCH] D40507: [clang-tidy] Move more checks from misc- to performance-

alexfh updated this revision to Diff 124580. alexfh added a comment. Herald added a subscriber: rnkovacs. - Add dependencies to prevent a link error Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40507 Files: clang-tidy/hicpp/CMakeLists.txt

[PATCH] D39730: Enabling constructor code completion

jkorous-apple added a comment. No luck. If I understand it correctly all the information that would be needed to distinguish between: foo:: and int i = foo:: in ResultBuilder::AddResult() is missing since the context is represented only by DeclContext. Something like a

[PATCH] D40310: Restructure how we break tokens.

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1525 + if (!DryRun) +Token->adaptStartOfLine(0, Whitespaces); + krasimir wrote: > If we indent here, shouldn't that also change ContentStartColumn? Nope, this will exactly adapt

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

NoQ added a comment. The reason why i don't want to commit the MAX/4 approach now (for `>`/`<` case) is that it has too little useful effects until the iterator checker is enabled by default. However, it is a core change that immediately affects all users with all its negative effects (such as

[PATCH] D37806: [analyzer] PthreadLock: Fix return values of XNU lock functions.

NoQ added a comment. Hey wb! Get well :) Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:282 +} +// We might want to handle the case when the mutex lock function was inlined +// and returned an Unknown or Undefined value. a.sidorin

[PATCH] D37806: [analyzer] PthreadLock: Fix return values of XNU lock functions.

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:271 } -assert(lockFail && lockSucc); -C.addTransition(lockFail); - +

[PATCH] D40566: Check if MemberExpr arguments are type-dependent.

mattd created this revision. Fixes: PR28290 When checking an argument list, arguments from the templated class instance, were returning 'is dependent' based on the 'this' pointer. In that case, arguments were being marked dependent, and name lookup was delayed until template instantiation.

[PATCH] D40567: Always show template parameters in IR type names

sepavloff created this revision. Herald added subscribers: JDevlieghere, eraman. If a module contains opaque type and another one contains definition of equivalent type in sense of C++, `llvm-link` merges these types. In this procedure it can rely only on type name. An issue arises if the type is

[PATCH] D40507: [clang-tidy] Move more checks from misc- to performance-

This revision was automatically updated to reflect the committed changes. alexfh marked 2 inline comments as done. Closed by commit rCTE319183: [clang-tidy] Move more checks from misc- to performance- (authored by alexfh). Changed prior to commit:

[clang-tools-extra] r319183 - [clang-tidy] Move more checks from misc- to performance-

Author: alexfh Date: Tue Nov 28 08:41:03 2017 New Revision: 319183 URL: http://llvm.org/viewvc/llvm-project?rev=319183=rev Log: [clang-tidy] Move more checks from misc- to performance- Summary: rename_check.py misc-move-const-arg performance-move-const-arg rename_check.py

r319195 - [Target] Make a copy of TargetOptions feature list before sorting during CodeGen

Author: ctopper Date: Tue Nov 28 10:00:32 2017 New Revision: 319195 URL: http://llvm.org/viewvc/llvm-project?rev=319195=rev Log: [Target] Make a copy of TargetOptions feature list before sorting during CodeGen Currently CodeGen is calling std::sort on the features vector in TargetOptions for

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

tra added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2188 + !Context.getTargetInfo().isVLASupported() && + shouldDiagnoseTargetSupportFromOpenMP()) { + // Some targets don't support VLAs. rjmccall wrote: > tra

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

MTC marked an inline comment as done. MTC added a comment. Hi dcoughlin, Thank you very much for your help. I have no commit access and hope someone can commit it on my behalf. Thanks a lot! https://reviews.llvm.org/D37187 ___ cfe-commits mailing

[PATCH] D40505: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw

malcolm.parsons updated this revision to Diff 124566. malcolm.parsons added a comment. clang-format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40505 Files: clang-tidy/readability/ElseAfterReturnCheck.cpp test/clang-tidy/readability-else-after-return.cpp Index:

[PATCH] D40560: [analyzer] WIP: Get construction into `operator new` running in simple cases.

NoQ added a comment. > for the sake of this proof-of-concept, i've crudely disabled garbage > collection on the respective moments of time Forgot to mention that this breaks tests in `NewDeleteLeaks-PR19102.cpp`, which are still failing in the present revision. Leak warnings get delayed to

[PATCH] D40507: [clang-tidy] Move more checks from misc- to performance-

alexfh marked 2 inline comments as done. alexfh added inline comments. Comment at: clang-tidy/hicpp/HICPPTidyModule.cpp:33 +#include "../performance/MoveConstArgCheck.h" +#include "../performance/NoexceptMoveConstructorCheck.h" #include

[PATCH] D40310: Restructure how we break tokens.

klimek updated this revision to Diff 124581. klimek marked 3 inline comments as done. klimek added a comment. Address review comments. https://reviews.llvm.org/D40310 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

ioeric created this revision. ... in qualified code completion and decl lookup. https://reviews.llvm.org/D40562 Files: lib/Sema/SemaCodeComplete.cpp lib/Sema/SemaLookup.cpp test/CodeCompletion/ignore-global-decls.cpp Index: test/CodeCompletion/ignore-global-decls.cpp

[PATCH] D40507: [clang-tidy] Move more checks from misc- to performance-

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Found one possible problem. Once fixed, LG! Comment at: clang-tidy/hicpp/HICPPTidyModule.cpp:33 +#include "../performance/MoveConstArgCheck.h" +#include

[PATCH] D40507: [clang-tidy] Move more checks from misc- to performance-

alexfh updated this revision to Diff 124554. alexfh added a comment. - Reverted formatting in tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40507 Files: clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D40505: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor formatting nit. Comment at: test/clang-tidy/readability-else-after-return.cpp:7 + ~string(); +}; +} Indentation is

[clang-tools-extra] r319174 - [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw

Author: malcolm.parsons Date: Tue Nov 28 06:57:47 2017 New Revision: 319174 URL: http://llvm.org/viewvc/llvm-project?rev=319174=rev Log: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw Summary: The readability-else-after-return check was not warning about an else after a

[PATCH] D40505: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE319174: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D40505?vs=124566=124567#toc

[PATCH] D40507: [clang-tidy] Move more checks from misc- to performance-

alexfh updated this revision to Diff 124553. alexfh added a comment. Herald added a subscriber: klimek. - clang-format -style=llvm Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40507 Files: clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/misc/CMakeLists.txt

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from one small nit with the test file missing a trailing newline. Comment at: test/clang-tidy/fuchsia-default-arguments.cpp:82 +} \ No newline at

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

keith.walker.arm updated this revision to Diff 124579. keith.walker.arm added a comment. > What are these disabled "R-UN" lines? Oops! They shouldn't have been disabled in the patch. > Do we really need to check every combination like this? I don't think the > underlying logic actually

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

george.karpenkov requested changes to this revision. george.karpenkov added inline comments. This revision now requires changes to proceed. Comment at: tools/scan-build-py/libscanbuild/analyze.py:44 +CTU_FUNCTION_MAP_FILENAME = 'externalFnMap.txt' +CTU_TEMP_FNMAP_FOLDER =

[PATCH] D40560: [analyzer] WIP: Get construction into `operator new` running in simple cases.

NoQ created this revision. Herald added subscribers: rnkovacs, eraman. Under the assumption of `-analyzer-config c++-allocator-inlining=true`, which enables evaluation of `operator new` as a regular function call, this patch shows what it takes to actually inline the constructor into the

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

MTC updated this revision to Diff 124549. MTC added a comment. Update the llvm_unreachable's description of the BlockEntrance-branch from "Unexpected ProgramPoint" to "Unexpected CFG element at front of block". https://reviews.llvm.org/D37187 Files:

[clang-tools-extra] r319170 - [clang-tidy] Fix tests for ReplaceRandomShuffleCheck

Author: xazax Date: Tue Nov 28 05:54:52 2017 New Revision: 319170 URL: http://llvm.org/viewvc/llvm-project?rev=319170=rev Log: [clang-tidy] Fix tests for ReplaceRandomShuffleCheck Patch by: Daniel Kolozsvari! Differential Revision: https://reviews.llvm.org/D40516 Modified:

[PATCH] D40548: [clangd] Prototyping index support and naive index-based global code completion. WIP

malaperle added a comment. Hi Eric! As you might know I'm working on persisted indexing. I was wondering which cases needed the index for code completion? Could you give a small example? I thought the AST alone would be sufficient for that. I'll look at this patch more closely a bit later but

[PATCH] D40548: [clangd] Prototyping index support and naive index-based global code completion. WIP

ioeric added a comment. In https://reviews.llvm.org/D40548#937626, @malaperle wrote: > Hi Eric! As you might know I'm working on persisted indexing. I was wondering > which cases needed the index for code completion? Could you give a small > example? I thought the AST alone would be sufficient

Re: Clang-format: add finer-grained options for putting all arguments on one line.

Another bump on this - again, this is my first time trying to submit a patch, so please let me know if there's a better way to go about this. On Mon, Nov 20, 2017 at 10:22 AM, Russell McClellan wrote: > Hi - > > Just pinging this after a week; let me know if there's

[PATCH] D40310: Restructure how we break tokens.

krasimir added inline comments. Comment at: lib/Format/BreakableToken.cpp:178 Split Split) const { // Example: consider the content // lala lala Offtopic: Should add a FIXME that this doesn't really work in

LLVM buildmaster will be restarted in few minutes

Hello everyone, LLVM buildmaster will be restarted in few minutes. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39376: [PowerPC] Add implementation for -msave-toc-indirect option - clang portion

jtony added inline comments. Comment at: test/Driver/ppc-features.cpp:140 + // RUN: %clang -target powerpc64-unknown-linux-gnu %s -mno-htm -### -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-NOHTM %s // CHECK-NOHTM: "-target-feature" "-htm" We probably need to

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rL319222: [OpenMP] Stable sort Privates to remove non-deterministic ordering (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D39947?vs=122751=124622#toc Repository: rL LLVM

[PATCH] D39730: Enabling constructor code completion

arphaman added a comment. I'll take a look, but my guess is that you might have to use scoping information https://reviews.llvm.org/D39730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40508: Replace long type names in IR with hashes

rjmccall added a comment. My skepticism about the raw_ostream is not about the design of having a custom raw_ostream subclass, it's that that subclass could conceivably be re-used by some other client. It feels like it belongs as an internal hack in Clang absent some real evidence that

[PATCH] D40299: [Complex] Don't use __div?c3 when building with fast-math.

fhahn added reviewers: arphaman, GorNishanov, hfinkel, fhahn. fhahn added a comment. Looks good to me, with some nits. However it seems that we do not use the fast math flags anywhere else in Clang codegen, so it would be good to clarify if it is OK to use it here. Comment

r319201 - [CUDA] Report "unsupported VLA" errors only on device side.

Author: tra Date: Tue Nov 28 10:51:42 2017 New Revision: 319201 URL: http://llvm.org/viewvc/llvm-project?rev=319201=rev Log: [CUDA] Report "unsupported VLA" errors only on device side. This fixes erroneously reported CUDA compilation errors in host-side code during device-side compilation. I've

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

This revision was automatically updated to reflect the committed changes. Closed by commit rL319201: [CUDA] Report "unsupported VLA" errors only on device side. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D40275?vs=123831=124607#toc Repository: rL LLVM

[PATCH] D39347: Fix __has_unique_object_representations based on rsmith's input

erichkeane updated this revision to Diff 124609. erichkeane added a comment. Add has padding to CXXABI getMemberPointerWidthAndAlign to correct padding behavior here. https://reviews.llvm.org/D39347 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h lib/AST/ASTContext.cpp

[PATCH] D40569: Use default IR alignment for cleanup.dest.slot.

jacobly created this revision. Forcing the 4 byte alignment caused an issue in my out of tree backend that doesn't even have a 4 byte aligned stack. Using the default target-specific alignment for i32 seems more reasonable. Repository: rC Clang https://reviews.llvm.org/D40569 Files:

[PATCH] D40463: [analyzer] Fix false negative on post-increment of uninitialized variable.

dcoughlin added a comment. Thanks for tackling this! There is one major comment inline (you are generating an extra node that you shouldn't, which is causing the analyzer to explore code it shouldn't) and a suggestion for simpler diagnostic text. Comment at:

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

rnk requested changes to this revision. rnk added inline comments. This revision now requires changes to proceed. Comment at: lib/Driver/ToolChain.cpp:450-458 + const llvm::Target *TT = llvm::TargetRegistry::lookupTarget(TS, Error); + if (!TT) +return

[PATCH] D40569: Use default IR alignment for cleanup.dest.slot.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, seems reasonable enough. Repository: rC Clang https://reviews.llvm.org/D40569 ___ cfe-commits mailing list

[PATCH] D40572: [OpenMP] Make test robust against quotation, NFC.

Hahnfeld created this revision. This is needed to not break with an upcoming change in LLVM to use dollar signs (which need to be quoted) instead of dots for generating unique names. https://reviews.llvm.org/D40572 Files: test/OpenMP/nvptx_parallel_codegen.cpp Index:

[PATCH] D40044: [CodeGen] convert math libcalls/builtins to equivalent LLVM intrinsics

spatel added a comment. Ping * 2. https://reviews.llvm.org/D40044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40310: Restructure how we break tokens.

krasimir added a comment. Re: "I tried to write a test for this, and convinced myself that while +1 is correct, it is currently impossible to change behavior based on the missing +1.": In order to have different outcome based on the start column, you could use tabs. Consider the content

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

bsdjhb added a comment. Ping @compnerd, @sdardis https://reviews.llvm.org/D38110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2188 + !Context.getTargetInfo().isVLASupported() && + shouldDiagnoseTargetSupportFromOpenMP()) { + // Some targets don't support VLAs. tra wrote: > rjmccall

[clang-tools-extra] r319225 - Add a new clang-tidy module for Fuchsia as an umbrella to diagnose issues with the Fuschia and Zircon coding guidelines (https://fuchsia.googlesource.com/zircon/+/master/

Author: aaronballman Date: Tue Nov 28 13:09:25 2017 New Revision: 319225 URL: http://llvm.org/viewvc/llvm-project?rev=319225=rev Log: Add a new clang-tidy module for Fuchsia as an umbrella to diagnose issues with the Fuschia and Zircon coding guidelines

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r319225. https://reviews.llvm.org/D40108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

sylvestre.ledru updated this revision to Diff 124629. https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp === --- lib/Driver/ToolChains/Cuda.cpp +++

[PATCH] D40568: design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer

eugenis added inline comments. Comment at: docs/TaggedAddressSanitizerDesign.rst:2 +=== +TaggedAddressSanitizer Design Documentation +=== I vote for HardwareAssistedAddressSanitizer,

[PATCH] D40577: Clang support for simd functions

mmasten created this revision. This patch adds "vector-variants" function attributes to simd functions. https://reviews.llvm.org/D40577 Files: lib/CodeGen/CGOpenMPRuntime.cpp Index: lib/CodeGen/CGOpenMPRuntime.cpp === ---

[PATCH] D40574: Bounds check argument_with_type_tag attribute.

mattd created this revision. Fixes: PR28520 Perform a bounds check on a function's argument list, before accessing any index value specified by an 'argument_with_type_tag' attribute. https://reviews.llvm.org/D40574 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

Hahnfeld added a comment. I'm getting "multiple definition" errors on powerpc64le when linking the unit tests, for example `XRayBufferQueueTest`: src/projects/compiler-rt/lib/xray/xray_utils.cc:34: multiple definition of `__xray::retryingWriteAll(int, char*, char*)'

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D40108#938131, @juliehockett wrote: > If you could, that'd be great! Thank you! It'll be good idea it you'll request commit rights, since you have more checks in development queue. https://reviews.llvm.org/D40108

[PATCH] D40577: Clang support for simd functions

mmasten added a comment. This patch is related to revisions https://reviews.llvm.org/D22792 and https://reviews.llvm.org/D40575 https://reviews.llvm.org/D40577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

tra added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:81 + +if (Distro.IsDebian()) + CudaPathCandidates.push_back(D.SysRoot + "/usr/lib/cuda"); No need for a named temporary. `if (Distro(D.getVFS).IsDebian())` should do. Also, please

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

Hahnfeld added a comment. On a related note please add context to your patch as described here: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface https://reviews.llvm.org/D40453 ___ cfe-commits mailing list

[PATCH] D40577: Clang support for simd functions

Hahnfeld added a reviewer: ABataev. Hahnfeld added a comment. This should add or extend a regression test https://reviews.llvm.org/D40577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

sylvestre.ledru updated this revision to Diff 124636. https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp === --- lib/Driver/ToolChains/Cuda.cpp +++

[PATCH] D40548: [clangd] Prototyping index support and naive index-based global code completion. WIP

ilya-biryukov added a comment. In https://reviews.llvm.org/D40548#937626, @malaperle wrote: > Hi Eric! As you might know I'm working on persisted indexing. I was wondering > which cases needed the index for code completion? Could you give a small > example? I thought the AST alone would be

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett added a comment. If you could, that'd be great! Thank you! https://reviews.llvm.org/D40108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r319227 - [OPENMP] Generalize capturing of clauses expressions.

Author: abataev Date: Tue Nov 28 13:11:44 2017 New Revision: 319227 URL: http://llvm.org/viewvc/llvm-project?rev=319227=rev Log: [OPENMP] Generalize capturing of clauses expressions. The handling and capturing of the non-constant expressions of some of the capturable clauses in combined

[PATCH] D40568: design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer

kcc marked an inline comment as done. kcc added inline comments. Comment at: docs/TaggedAddressSanitizerDesign.rst:2 +=== +TaggedAddressSanitizer Design Documentation +=== eugenis

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett created this revision. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn when a class inheritsfrom multiple classes that are not pure virtual. See

[PATCH] D40586: Implement p0457r2 - String Prefix and Suffix Checking

mclow.lists created this revision. This adds six calls each to `basic_string` and `basic_string_view`: - starts_with (3 variants) - ends_with (3 variants) This is a C++2a feature https://reviews.llvm.org/D40586 Files: include/string include/string_view

LLVM buildmaster is back to work now but two builders remain OFF

Hello everyone, LLVM buildmaster is back to work. Two slaves remain off for now as they produce a lot of warnings and their log files are way too big. The next builds have full logs available. Hope this helps to fix this issue:

  1   2   >