[PATCH] D40937: [clang-tidy] Infinite loop checker

Eugene.Zelenko added a comment. Does it really belong to Clang-tidy or Clang Analyzer is better place because of path-ensitivity? Please rebase from trunk. General note: CLang-tidy use //check// in terminology, not //checker//. Comment at: docs/ReleaseNotes.rst:63 + + The

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

xgsa added a comment. So can this patch be submitted? Should I do something to make it happen? https://reviews.llvm.org/D40671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40937: [clang-tidy] Infinite loop checker

szepet added a comment. Hi Eugen! Good question, probably should have detailed it in the description. This matcher based solution would not gain much benefit from the symbolic execution provided information. (I mean, it would mean a much different type of check on the states.) The main

[PATCH] D40937: [clang-tidy] Infinite loop checker

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D40937#947658, @szepet wrote: > Other note: If somebody would came up with an approach which can benefit from > the symbolic execution, these solutions could still live happily in the > different tools eg. UseAfterMove (tidy) and

[PATCH] D40937: [clang-tidy] Infinite loop checker

JVApen added a comment. How does this check deal with atomic members? struct A { std:: atomic a; void f() const { while (a); } }; https://reviews.llvm.org/D40937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40939: [analyzer] Avoid element regions of void type.

NoQ created this revision. Herald added subscribers: cfe-commits, rnkovacs. Add an assertion that `ElementRegion`'s element type is not void. Fix two violations of this rule that shown up on four of our existing test files. I accidentally noticed that problem when i was looking at how

[PATCH] D40940: [ubsan] Use pass_object_size info in bounds checks

vsk created this revision. Herald added a reviewer: george.burgess.iv. Teach UBSan's bounds check to opportunistically use pass_object_size information to check array accesses. rdar://33272922 https://reviews.llvm.org/D40940 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h

[PATCH] D37057: [clang] Require address space to be specified when creating functions (4/4)

dylanmckay updated this revision to Diff 125887. dylanmckay added a comment. Herald added a subscriber: cfe-commits. - Remove the switch table stuff for a later patch - Rebased on top of trunk Repository: rC Clang https://reviews.llvm.org/D37057 Files: lib/CodeGen/CGBlocks.cpp

[PATCH] D40806: CodeGen: Fix invalid bitcasts for memcpy

This revision was automatically updated to reflect the committed changes. Closed by commit rL32: CodeGen: Fix invalid bitcasts for memcpy (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D40806?vs=125417=125863#toc Repository: rL LLVM

r320000 - CodeGen: Fix invalid bitcasts for memcpy

Author: yaxunl Date: Wed Dec 6 17:39:52 2017 New Revision: 32 URL: http://llvm.org/viewvc/llvm-project?rev=32=rev Log: CodeGen: Fix invalid bitcasts for memcpy CreateCoercedLoad/CreateCoercedStore assumes pointer argument of memcpy is in addr space 0, which is not correct and causes

[PATCH] D40936: Hardware-assisted AddressSanitizer (clang part).

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM please give at least Aleksey a chance to review as well. https://reviews.llvm.org/D40936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40806: CodeGen: Fix invalid bitcasts for memcpy

rjmccall added inline comments. Comment at: cfe/trunk/lib/CodeGen/CGCall.cpp:1238 + Address Casted = CGF.Builder.CreateBitCast(Tmp, CGF.AllocaInt8PtrTy); + Address SrcCasted = CGF.Builder.CreateBitCast(Src, CGF.AllocaInt8PtrTy); CGF.Builder.CreateMemCpy(Casted, SrcCasted,

[PATCH] D40938: update hwasan docs

kcc created this revision. Herald added a subscriber: cfe-commits. - use more readable name - document the hwasan attribute Repository: rC Clang https://reviews.llvm.org/D40938 Files: docs/HardwareAssistedAddressSanitizerDesign.rst Index: docs/HardwareAssistedAddressSanitizerDesign.rst

[PATCH] D40937: [clang-tidy] Infinite loop checker

szepet updated this revision to Diff 125870. szepet marked an inline comment as done. szepet added a comment. Updated the wording in the docs. https://reviews.llvm.org/D40937 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/InfiniteLoopCheck.cpp clang-tidy/misc/InfiniteLoopCheck.h

r320008 - Test commit access

Author: lichray Date: Wed Dec 6 22:27:58 2017 New Revision: 320008 URL: http://llvm.org/viewvc/llvm-project?rev=320008=rev Log: Test commit access Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL:

[PATCH] D40941: [ubsan] Use pass_object_size info in bounds checks (compiler-rt)

vsk created this revision. Herald added subscribers: dberris, kubamracek. This is a test update for the clang change in https://reviews.llvm.org/D40940 https://reviews.llvm.org/D40941 Files: test/ubsan/TestCases/Misc/bounds.cpp Index: test/ubsan/TestCases/Misc/bounds.cpp

[PATCH] D40937: [clang-tidy] Infinite loop checker

szepet created this revision. Herald added subscribers: rnkovacs, baloghadamsoftware, whisperity, mgorny. The checker aims to find loops where none of the condition variables are updated in the body. In this version it only works on integer types but the final aim is to make it work for

[PATCH] D40939: [analyzer] Avoid element regions of void type.

NoQ added a comment. > I accidentally noticed that problem The actual problem was that `RegionStore` was unable to retrieve the binding to such `ElementRegion` (in case of this example, `5 S32b`). There may be more problems with such regions. But at the same time i believe that the very idea

[PATCH] D40929: Unblock Swift Calling Convention Mangling on Windows

rjmccall added reviewers: rnk, majnemer. rjmccall added a comment. Reid, David, do you have a recommendation about the right way to support non-MS-supported CCs here? Repository: rC Clang https://reviews.llvm.org/D40929 ___ cfe-commits mailing

[PATCH] D40937: [clang-tidy] Infinite loop checker

Eugene.Zelenko added inline comments. Comment at: clang-tidy/misc/InfiniteLoopCheck.cpp:94 + +std::unique_ptr createSequence(Stmt *FunctionBody, + ASTContext ) { Missing static? Comment at:

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rC320011: Allow conditions to be decomposed with structured bindings (authored by lichray). Changed prior to commit: https://reviews.llvm.org/D39284?vs=125665=125892#toc Repository: rC Clang

r320011 - Allow conditions to be decomposed with structured bindings

Author: lichray Date: Wed Dec 6 23:03:15 2017 New Revision: 320011 URL: http://llvm.org/viewvc/llvm-project?rev=320011=rev Log: Allow conditions to be decomposed with structured bindings Summary: This feature was discussed but not yet proposed. It allows a structured binding to appear as a

[PATCH] D39279: Stringizing raw string literals containing newline

This revision was automatically updated to reflect the committed changes. Closed by commit rC319904: Stringizing raw string literals containing newline (authored by twoh). Changed prior to commit: https://reviews.llvm.org/D39279?vs=125564=125745#toc Repository: rC Clang

r319904 - Stringizing raw string literals containing newline

Author: twoh Date: Wed Dec 6 09:00:53 2017 New Revision: 319904 URL: http://llvm.org/viewvc/llvm-project?rev=319904=rev Log: Stringizing raw string literals containing newline Summary: This patch implements 4.3 of http://open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4220.pdf. If a raw string

[PATCH] D40909: [clang-format] Reorganize raw string delimiters

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rC Clang https://reviews.llvm.org/D40909 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h lib/Format/Format.cpp

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

ioeric added a comment. In https://reviews.llvm.org/D40562#942521, @arphaman wrote: > In https://reviews.llvm.org/D40562#941753, @ilya-biryukov wrote: > > > In https://reviews.llvm.org/D40562#941570, @arphaman wrote: > > > > > I'm not actually 100% sure, but I would imagine that this one of the

[PATCH] D40567: Always show template parameters in IR type names

sepavloff updated this revision to Diff 125761. sepavloff added a comment. Updated patch - old type names are generated always if --ir-type-names is not specified, - added new value of --ir-type-names, none, to suppress type names, - value of --ir-type-names is stored in module properties.

Re: [PATCH] D40838: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

Thanks! On Wed, Dec 6, 2017 at 2:12 AM Sven van Haastregt via Phabricator < revi...@reviews.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rC319883: [OpenCL] Fix layering violation by > getOpenCLTypeAddrSpace (authored by svenvh).

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

Hahnfeld created this revision. Herald added a subscriber: cfe-commits. The adjustment is calculated with CreatePtrDiff() which returns the difference in (base) elements. This is passed to CreateGEP() so make sure that the GEP base has the correct pointer type: It needs to be a pointer to the

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

lichray added a comment. Can someone commit this please? One more patch then I'll go get a commit bit. Repository: rC Clang https://reviews.llvm.org/D39284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

hokein added a comment. In https://reviews.llvm.org/D40897#946708, @malaperle wrote: > Hi! Have you looked into https://reviews.llvm.org/D40548 ? Maybe we need to > coordinate the two a bit. Hi Marc! Thanks for the input! Yeah, Eric and I are working closely on a prototype of global code

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1110 +PrivateAddr.getPointer(), +SharedAddresses[N].first.getPointer()->getType()); +llvm::Value *Ptr = CGF.Builder.CreateGEP(PrivatePointer, Adjustment);

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

Hahnfeld updated this revision to Diff 125768. Hahnfeld marked 3 inline comments as done. Hahnfeld added a comment. Get type from `Address`. https://reviews.llvm.org/D40911 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/for_reduction_codegen.cpp

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D40911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL319931: Fix PR35542: Correct adjusting of private reduction variable (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D40911?vs=125768=125770#toc Repository: rL LLVM

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

This revision was automatically updated to reflect the committed changes. Closed by commit rC319931: Fix PR35542: Correct adjusting of private reduction variable (authored by Hahnfeld). Repository: rC Clang https://reviews.llvm.org/D40911 Files: lib/CodeGen/CGOpenMPRuntime.cpp

r319931 - Fix PR35542: Correct adjusting of private reduction variable

Author: hahnfeld Date: Wed Dec 6 11:15:28 2017 New Revision: 319931 URL: http://llvm.org/viewvc/llvm-project?rev=319931=rev Log: Fix PR35542: Correct adjusting of private reduction variable The adjustment is calculated with CreatePtrDiff() which returns the difference in (base) elements. This

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

ioeric updated this revision to Diff 125777. ioeric added a comment. - Add a new code-completion option IncludeNamespaceLevelDecls. For now, I only restrict this option work for qualified id completion to reduce the impact. Repository: rC Clang https://reviews.llvm.org/D40562 Files:

Re: r319875 - Fix a bunch of wrong "tautological unsigned enum compare" diagnostics in C++.

This made Clang start warning about unsigned vs enum compares on Windows. $ echo 'enum E { foo }; bool f(unsigned a, E b) { return a == b; }' | bin/clang -Wsign-compare -c -x c++ - -target i686-pc-win32 :1:52: warning: comparison of integers of different signs: 'unsigned int' and 'E'

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

Hahnfeld added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1110 +PrivateAddr.getPointer(), +SharedAddresses[N].first.getPointer()->getType()); +llvm::Value *Ptr = CGF.Builder.CreateGEP(PrivatePointer, Adjustment);

[PATCH] D40911: [OpenMP] Fix PR35542: Correct adjusting of private reduction variable

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1110 +PrivateAddr.getPointer(), +SharedAddresses[N].first.getPointer()->getType()); +llvm::Value *Ptr = CGF.Builder.CreateGEP(PrivatePointer, Adjustment);

r319942 - Delete special-case "out-of-range" handling for bools, and just use the normal

Author: rsmith Date: Wed Dec 6 11:23:19 2017 New Revision: 319942 URL: http://llvm.org/viewvc/llvm-project?rev=319942=rev Log: Delete special-case "out-of-range" handling for bools, and just use the normal codepath plus the new "minimum / maximum value of type" diagnostic to get the same effect.

[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

ahatanak added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:442 Options.DebuggerTuning = CodeGenOpts.getDebuggerTuning(); + Options.EnableStackProbe = CodeGenOpts.StackProbe; aemerson wrote: > ahatanak wrote: > > Is there a reason you can't use

[PATCH] D40884: [Index] Add setPreprocessor member to IndexDataConsumer.

ioeric created this revision. This enables us to use information in Preprocessor when handling symbol occurrences. Repository: rC Clang https://reviews.llvm.org/D40884 Files: include/clang/Index/IndexDataConsumer.h include/clang/Index/IndexingAction.h lib/Index/IndexingAction.cpp

[PATCH] D40643: [libclang] Add function to get the buffer for a file

This revision was automatically updated to reflect the committed changes. Closed by commit rL319881: [libclang] Add function to get the buffer for a file (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D40643?vs=124904=125677#toc Repository: rL LLVM

r319881 - [libclang] Add function to get the buffer for a file

Author: erikjv Date: Wed Dec 6 01:02:52 2017 New Revision: 319881 URL: http://llvm.org/viewvc/llvm-project?rev=319881=rev Log: [libclang] Add function to get the buffer for a file This can be used by clients in conjunction with an offset returned by e.g. clang_getFileLocation. Now those clients

[PATCH] D40884: [Index] Add setPreprocessor member to IndexDataConsumer.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: include/clang/Index/IndexingAction.h:14 #include "clang/Basic/LLVM.h" +#include "clang/Lex/Preprocessor.h" #include "llvm/ADT/ArrayRef.h"

[PATCH] D40884: [Index] Add setPreprocessor member to IndexDataConsumer.

malaperle added a comment. In https://reviews.llvm.org/D40884#946630, @ioeric wrote: > In https://reviews.llvm.org/D40884#946506, @malaperle wrote: > > > You can get the preprocessor from the ASTContext, no? > > > I don't think `ASTContext` contains preprocessor information. My bad, it was the

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

ro created this revision. ro added a project: Sanitizers. Herald added subscribers: fedor.sergeev, jyknight. This patch (on top of https://reviews.llvm.org/D35755) provides the clang side necessary to enable the Solaris port of the sanitizers implemented by https://reviews.llvm.org/D40898,

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

aaron.ballman added inline comments. Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:30 +class D : public B, public C { + // CHECK-MESSAGES: [[@LINE-1]]:1: warning: virtual inheritance is disallowed [fuchsia-virtual-inheritance] + // CHECK-NEXT: class C : public

[PATCH] D40871: [CUDA] Added overloads for '[unsigned] long' variants of shfl builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rC319908: [CUDA] Added overloads for '[unsigned] long' variants of shfl builtins. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D40871?vs=125648=125756#toc Repository: rC Clang

[PATCH] D40871: [CUDA] Added overloads for '[unsigned] long' variants of shfl builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL319908: [CUDA] Added overloads for '[unsigned] long' variants of shfl builtins. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D40871?vs=125648=125755#toc Repository: rL LLVM

r319908 - [CUDA] Added overloads for '[unsigned] long' variants of shfl builtins.

Author: tra Date: Wed Dec 6 09:40:35 2017 New Revision: 319908 URL: http://llvm.org/viewvc/llvm-project?rev=319908=rev Log: [CUDA] Added overloads for '[unsigned] long' variants of shfl builtins. Differential Revision: https://reviews.llvm.org/D40871 Modified:

r319909 - [NVPTX, CUDA] Added llvm.nvvm.fns intrinsic and matching __nvvm_fns builtin in clang.

Author: tra Date: Wed Dec 6 09:50:05 2017 New Revision: 319909 URL: http://llvm.org/viewvc/llvm-project?rev=319909=rev Log: [NVPTX,CUDA] Added llvm.nvvm.fns intrinsic and matching __nvvm_fns builtin in clang. Differential Revision: https://reviews.llvm.org/D40872 Modified:

[PATCH] D40884: [Index] Add setPreprocessor member to IndexDataConsumer.

ioeric added a comment. In https://reviews.llvm.org/D40884#946506, @malaperle wrote: > You can get the preprocessor from the ASTContext, no? I don't think `ASTContext` contains preprocessor information. Repository: rC Clang https://reviews.llvm.org/D40884

[PATCH] D40901: Refactor lazy loading of template specializations. NFC

v.g.vassilev updated this revision to Diff 125738. v.g.vassilev added a comment. Fix preexisting comment typo. https://reviews.llvm.org/D40901 Files: include/clang/AST/DeclTemplate.h lib/AST/DeclTemplate.cpp Index: lib/AST/DeclTemplate.cpp

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel added a comment. Ping * 3. https://reviews.llvm.org/D39812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

gerazo added a comment. The code modifications are coming soon (after doing some extensive testing) for the scan-build part. Comment at: tools/scan-build-py/libscanbuild/analyze.py:223 +ctu_config = get_ctu_config(args) +if ctu_config.collect: +

[PATCH] D40901: Refactor lazy loading of template specializations. NFC

v.g.vassilev created this revision. Unify the loading of lazy template specializations across class, function and variable templates. Repository: rL LLVM https://reviews.llvm.org/D40901 Files: include/clang/AST/DeclTemplate.h lib/AST/DeclTemplate.cpp Index: lib/AST/DeclTemplate.cpp

[PATCH] D40888: [ARM] ACLE parallel arithmetic and DSP style multiplications

samparker accepted this revision. samparker added a comment. This revision is now accepted and ready to land. Great, LGTM, many thanks for doing this! https://reviews.llvm.org/D40888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40895: Ignore pointers to incomplete types when diagnosing misaligned addresses

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D40895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40872: [NVPTX, CUDA] Added llvm.nvvm.fns intrinsic and matching __nvvm_fns builtin in clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rL319909: [NVPTX,CUDA] Added llvm.nvvm.fns intrinsic and matching __nvvm_fns builtin in… (authored by tra). Changed prior to commit: https://reviews.llvm.org/D40872?vs=125649=125757#toc Repository: rL

[PATCH] D40806: CodeGen: Fix invalid bitcasts for memcpy

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D40806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40486: [clangd] Implemented logging using Context

sammccall added a comment. Mostly nits - throughout there's going to be lots of judgement calls about where to propagate context and where not. No need to get all those "exactly right", but trying to get a feel for what these answers are likely to be. Most of the interesting stuff is around

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

malaperle added a comment. Hi! Have you looked into https://reviews.llvm.org/D40548 ? Maybe we need to coordinate the two a bit. Comment at: clangd/Symbol.h:37 +// The class presents a C++ symbol, e.g. class, function. +struct Symbol { + // The symbol identifier, using USR.

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

erichkeane updated this revision to Diff 125779. erichkeane marked 3 inline comments as done. erichkeane added a comment. Fix all rsmith's and craig's fixes, AFAIK. https://reviews.llvm.org/D40819 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td

[clang-tools-extra] r319948 - [CMake] Use PRIVATE in target_link_libraries for fuzzers.

Author: morehouse Date: Wed Dec 6 11:52:40 2017 New Revision: 319948 URL: http://llvm.org/viewvc/llvm-project?rev=319948=rev Log: [CMake] Use PRIVATE in target_link_libraries for fuzzers. Several fuzzers were missed by r319840. Modified: clang-tools-extra/trunk/clangd/fuzzer/CMakeLists.txt

r319948 - [CMake] Use PRIVATE in target_link_libraries for fuzzers.

Author: morehouse Date: Wed Dec 6 11:52:40 2017 New Revision: 319948 URL: http://llvm.org/viewvc/llvm-project?rev=319948=rev Log: [CMake] Use PRIVATE in target_link_libraries for fuzzers. Several fuzzers were missed by r319840. Modified: cfe/trunk/tools/clang-format/fuzzer/CMakeLists.txt

[PATCH] D40567: Always show template parameters in IR type names

rsmith added a comment. In https://reviews.llvm.org/D40567#943747, @sepavloff wrote: > Although code generation (in LTO compilation) might be unaffected by this > distortions, other applications of IR linking suffer from it. It does not > allow to implement some checks, validation techniques

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

erichkeane marked 14 inline comments as done. erichkeane added a comment. Incoming patch! Comment at: include/clang/Basic/Attr.td:1809 bool DuplicateArchitecture = false; + bool operator ==(const ParsedTargetAttr ) { +return DuplicateArchitecture ==

r319950 - [clang] Use PRIVATE in target_link_libraries

Author: smeenai Date: Wed Dec 6 12:05:42 2017 New Revision: 319950 URL: http://llvm.org/viewvc/llvm-project?rev=319950=rev Log: [clang] Use PRIVATE in target_link_libraries I'd missed this one in r319840 because I hadn't been configuring with an order file before. Modified:

[PATCH] D40548: [clangd] Prototyping index support and naive index-based global code completion. WIP

ioeric added a comment. Hi Marc, the patch is not ready for review yet. I am still cleaning up the prototype and will let you know when it's ready for review. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40548 ___ cfe-commits

[PATCH] D40680: [libc++] Create install-stripped targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL319959: [libc++] Create install-stripped targets (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D40680 Files: libcxx/trunk/include/CMakeLists.txt

[libcxx] r319959 - [libc++] Create install-stripped targets

Author: smeenai Date: Wed Dec 6 13:03:42 2017 New Revision: 319959 URL: http://llvm.org/viewvc/llvm-project?rev=319959=rev Log: [libc++] Create install-stripped targets LLVM is gaining install-*-stripped targets to perform stripped installs, and in order for this to be useful for

[PATCH] D37813: clang-format: better handle namespace macros

klimek added a comment. In https://reviews.llvm.org/D37813#945125, @Typz wrote: > I don't think this is really relevant for this tool: if someone changes the > implementation of the macro, then *they* must indeed if it should not be > formatted like a namespace (and keep the clang-format

[PATCH] D40838: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

This revision was automatically updated to reflect the committed changes. Closed by commit rC319883: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace (authored by svenvh). Repository: rC Clang https://reviews.llvm.org/D40838 Files: include/clang/AST/ASTContext.h

r319883 - [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

Author: svenvh Date: Wed Dec 6 02:11:28 2017 New Revision: 319883 URL: http://llvm.org/viewvc/llvm-project?rev=319883=rev Log: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace Commit 7ac28eb0a5 / r310911 ("[OpenCL] Allow targets to select address space per type", 2017-08-15) made Basic

[PATCH] D40838: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

This revision was automatically updated to reflect the committed changes. Closed by commit rL319883: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D40838?vs=125554=125682#toc Repository: rL LLVM

[PATCH] D40489: [clangd] Changed tracing interfaces

ilya-biryukov updated this revision to Diff 125696. ilya-biryukov added a comment. Herald added a subscriber: klimek. - Update the patch to accomodate changes from tracing and Context patches. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40489 Files: clangd/Trace.cpp

[PATCH] D40488: [clangd] Implemented tracing using Context

ilya-biryukov updated this revision to Diff 125690. ilya-biryukov added a comment. Herald added a subscriber: klimek. - Updated tracing to use the new Context implementation. - Restored global tracer. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40488 Files:

[PATCH] D38639: [clangd] #include statements support for Open definition

Nebiroth updated this revision to Diff 125814. Nebiroth added a comment. Fixed re-added include Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Protocol.h

[PATCH] D40398: Remove ValueDependent assertions on ICE checks.

mattd added a comment. ping https://reviews.llvm.org/D40398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40818: [libcxxabi] Pass LIBCXXABI_SYSROOT and LIBCXXABI_GCC_TOOLCHAIN to lit

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXXA libc++abi https://reviews.llvm.org/D40818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r319983 - [clang] Add PRIVATE to target_link_libraries

Author: smeenai Date: Wed Dec 6 15:02:00 2017 New Revision: 319983 URL: http://llvm.org/viewvc/llvm-project?rev=319983=rev Log: [clang] Add PRIVATE to target_link_libraries Another follow-up to r319840. I'd done a test configure with LLVM_BUILD_STATIC, so I'm not sure why this didn't show up in

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

Nebiroth updated this revision to Diff 125815. Nebiroth added a comment. Reverted formatting changes to ASTUnit Repository: rC Clang https://reviews.llvm.org/D39375 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/ASTUnit.cpp lib/Frontend/PrecompiledPreamble.cpp

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

compnerd accepted this revision. compnerd added a comment. LGTM if @sdardis is good with it https://reviews.llvm.org/D38110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38639: [clangd] #include statements support for Open definition

Nebiroth updated this revision to Diff 125813. Nebiroth added a comment. Herald added a subscriber: klimek. Using PPCallbacks interface to find non-preamble includes Created inner class to store vectors in to find locations Refactored methods to remove some unnecessary parameters Refactored Unit

[PATCH] D40637: [CMake] Support runtimes and monorepo layouts when looking for libc++

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rCRT Compiler Runtime https://reviews.llvm.org/D40637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40815: [libcxxabi] Use the correct variable name for target triple in lit

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCXXA libc++abi https://reviews.llvm.org/D40815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40814: [libcxx] Use the correct variable name for target triple in lit

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCXX libc++ https://reviews.llvm.org/D40814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

amadio added a comment. The problems fixed here also happen when compiling with Clang-5.0 and C++17 enabled. What happens is that the assignment to `ProfileFileName` needs a conversion of `PGOTestProfileFile` from the `opt` type to `std::string`, but the compiler is trying to use a deleted

[PATCH] D40888: [ARM] ACLE parallel arithmetic and DSP style multiplications

SjoerdMeijer created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. This is a follow up of r302131, in which we forgot to add SemaChecking tests. Adding these tests revealed two problems which have been fixed: - added missing intrinsic __qdbl, - properly

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

ilya-biryukov updated this revision to Diff 125712. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Removed unused helpers from Context.h - Use assert instead of llvm_unreachable in getExisiting(Key<>) Repository: rCTE Clang Tools Extra

[PATCH] D40488: [clangd] Implemented tracing using Context

ilya-biryukov updated this revision to Diff 125713. ilya-biryukov added a comment. - Use getExistingKey instead of getPtr in JSONRPCDispatcher. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40488 Files: clangd/ClangdUnit.cpp clangd/JSONRPCDispatcher.cpp clangd/Trace.cpp

[PATCH] D40888: [ARM] ACLE parallel arithmetic and DSP style multiplications

samparker added a comment. Thanks for looking into this! Comment at: include/clang/Basic/BuiltinsARM.def:39 BUILTIN(__builtin_arm_qsub, "iii", "nc") +BUILTIN(__builtin_arm_qdbl, "ii", "nc") BUILTIN(__builtin_arm_ssat, "iiUi", "nc") Do we now need a codegen

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

nik added a comment. In https://reviews.llvm.org/D20124#943592, @cameron314 wrote: > Here's the final patch that fixes `clang_getSkippedRegions` with regions in > the preamble (as well as serializing the skipped regions in the PCH file). Works fine for me, thanks! Test from the bug report is

r319986 - [Lex] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Wed Dec 6 15:18:41 2017 New Revision: 319986 URL: http://llvm.org/viewvc/llvm-project?rev=319986=rev Log: [Lex] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Lex/HeaderSearch.h

[PATCH] D40380: Remove old concepts parsing code

This revision was automatically updated to reflect the committed changes. Closed by commit rC319992: Remove old concepts parsing code (authored by hubert.reinterpretcast). Changed prior to commit: https://reviews.llvm.org/D40380?vs=124032=125844#toc Repository: rC Clang

r319992 - Remove old concepts parsing code

Author: hubert.reinterpretcast Date: Wed Dec 6 16:34:20 2017 New Revision: 319992 URL: http://llvm.org/viewvc/llvm-project?rev=319992=rev Log: Remove old concepts parsing code Summary: This is so we can implement concepts per P0734R0. Relevant failing test cases are disabled. Reviewers:

  1   2   >